Re: [Xen-devel] [PATCH V2] xen/arm: mm: fix nr_second calculation in setup_frametable_mappings

2016-05-16 Thread Wei Liu
On Mon, May 16, 2016 at 10:36:11AM +0100, Julien Grall wrote: > (CC Wei for Xen 4.7) > > Hi, > > On 12/05/16 14:03, Peng Fan wrote: > >On ARM64, "frametable_size >> SECOND_SHIFT" computes the number > >of second level entries, not the number of second level pages. > > >

Re: [Xen-devel] [PATCH V2] xen/arm: mm: fix nr_second calculation in setup_frametable_mappings

2016-05-16 Thread Julien Grall
(CC Wei for Xen 4.7) Hi, On 12/05/16 14:03, Peng Fan wrote: On ARM64, "frametable_size >> SECOND_SHIFT" computes the number of second level entries, not the number of second level pages. "ROUNDUP(frametable_size, FIRST_SIZE) >> FIRST_SHIFT" which computes the number of the first level entries

[Xen-devel] [PATCH V2] xen/arm: mm: fix nr_second calculation in setup_frametable_mappings

2016-05-12 Thread Peng Fan
On ARM64, "frametable_size >> SECOND_SHIFT" computes the number of second level entries, not the number of second level pages. "ROUNDUP(frametable_size, FIRST_SIZE) >> FIRST_SHIFT" which computes the number of the first level entries (the number of second level pages), is the correct one that