Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-23 Thread Lan Tianyu
On 2017年08月23日 17:24, Jan Beulich wrote: On 23.08.17 at 09:42, wrote: >> On 2017年08月22日 23:32, Roger Pau Monné wrote: >>> On Wed, Aug 09, 2017 at 04:34:03PM -0400, Lan Tianyu wrote: +static inline void irq_request_ioapic_fill(struct irq_remapping_request

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-23 Thread Jan Beulich
>>> On 23.08.17 at 09:42, wrote: > On 2017年08月22日 23:32, Roger Pau Monné wrote: >> On Wed, Aug 09, 2017 at 04:34:03PM -0400, Lan Tianyu wrote: >>> +static inline void irq_request_ioapic_fill(struct irq_remapping_request >>> *req, >>> + uint32_t

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-23 Thread Lan Tianyu
On 2017年08月22日 23:32, Roger Pau Monné wrote: > On Wed, Aug 09, 2017 at 04:34:03PM -0400, Lan Tianyu wrote: >> This patch is to add irq request callback for platform implementation >> to deal with irq remapping request. >> >> Signed-off-by: Lan Tianyu >> --- >>

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-22 Thread Roger Pau Monné
On Wed, Aug 09, 2017 at 04:34:03PM -0400, Lan Tianyu wrote: > This patch is to add irq request callback for platform implementation > to deal with irq remapping request. > > Signed-off-by: Lan Tianyu > --- > xen/common/viommu.c | 15 + >

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-22 Thread Lan Tianyu
On 2017年08月22日 18:53, Wei Liu wrote: > On Tue, Aug 22, 2017 at 06:39:32PM +0800, Lan Tianyu wrote: >> On 2017年08月22日 16:42, Wei Liu wrote: >>> On Tue, Aug 22, 2017 at 04:04:09PM +0800, Lan Tianyu wrote: On 2017年08月18日 18:13, Wei Liu wrote: >>> ASSERT(info->viommu[viommu_id]->ops);

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-22 Thread Wei Liu
On Tue, Aug 22, 2017 at 06:39:32PM +0800, Lan Tianyu wrote: > On 2017年08月22日 16:42, Wei Liu wrote: > > On Tue, Aug 22, 2017 at 04:04:09PM +0800, Lan Tianyu wrote: > >> On 2017年08月18日 18:13, Wei Liu wrote: > > ASSERT(info->viommu[viommu_id]->ops); > >>> > >>> For extra safety. > > >

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-22 Thread Lan Tianyu
On 2017年08月22日 16:42, Wei Liu wrote: > On Tue, Aug 22, 2017 at 04:04:09PM +0800, Lan Tianyu wrote: >> On 2017年08月18日 18:13, Wei Liu wrote: > ASSERT(info->viommu[viommu_id]->ops); >>> >>> For extra safety. > > Or check ops in the previous if? > >>> That depends on if ops can

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-22 Thread Wei Liu
On Tue, Aug 22, 2017 at 04:04:09PM +0800, Lan Tianyu wrote: > On 2017年08月18日 18:13, Wei Liu wrote: > >>> ASSERT(info->viommu[viommu_id]->ops); > >>> > > > >>> > > For extra safety. > >> > > >> > Or check ops in the previous if? > >> > > > That depends on if ops can be null or not. > > If ops

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-22 Thread Lan Tianyu
On 2017年08月18日 18:13, Wei Liu wrote: >>> ASSERT(info->viommu[viommu_id]->ops); >>> > > >>> > > For extra safety. >> > >> > Or check ops in the previous if? >> > > That depends on if ops can be null or not. If ops isn't be set, it will be null. Because struct viommu is allocated via xzalloc().

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-18 Thread Wei Liu
On Fri, Aug 18, 2017 at 03:09:55PM +0800, Lan Tianyu wrote: > On 2017年08月17日 19:18, Wei Liu wrote: > > On Wed, Aug 09, 2017 at 04:34:03PM -0400, Lan Tianyu wrote: > >> This patch is to add irq request callback for platform implementation > >> to deal with irq remapping request. > >> > >>

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-18 Thread Lan Tianyu
On 2017年08月17日 19:18, Wei Liu wrote: > On Wed, Aug 09, 2017 at 04:34:03PM -0400, Lan Tianyu wrote: >> This patch is to add irq request callback for platform implementation >> to deal with irq remapping request. >> >> Signed-off-by: Lan Tianyu >> --- >> xen/common/viommu.c

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-17 Thread Wei Liu
On Wed, Aug 09, 2017 at 04:34:03PM -0400, Lan Tianyu wrote: > This patch is to add irq request callback for platform implementation > to deal with irq remapping request. > > Signed-off-by: Lan Tianyu > --- > xen/common/viommu.c | 15 + >

[Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-09 Thread Lan Tianyu
This patch is to add irq request callback for platform implementation to deal with irq remapping request. Signed-off-by: Lan Tianyu --- xen/common/viommu.c | 15 + xen/include/asm-x86/viommu.h | 73