Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-25 Thread Wei Liu
On Fri, Aug 25, 2017 at 03:33:47PM +0800, Lan Tianyu wrote: > > > > int libxl__arch_domain_finalise_hw_description(libxl__gc *gc, > >libxl_domain_build_info > > *info, > >struct xc_dom_image *dom) > >

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-25 Thread Lan Tianyu
On 2017年08月25日 11:19, Lan Tianyu wrote: > On 2017年08月24日 19:08, Wei Liu wrote: > If add dmar table for hvmlite, we should combine dmar table with other ACPI table and populate into acpi_modules[2]. This is how hvmlite add other ACPI tables in libxl__dom_load_acpi().

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-24 Thread Lan Tianyu
On 2017年08月24日 19:08, Wei Liu wrote: If add dmar table for hvmlite, we should combine dmar table with other > >> ACPI table and populate into acpi_modules[2]. This is how hvmlite add > >> other ACPI tables in libxl__dom_load_acpi(). > >> >>> > > >>> > > Sure, that sounds

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-24 Thread Wei Liu
On Thu, Aug 24, 2017 at 11:24:12AM +0800, Lan Tianyu wrote: > On 2017年08月23日 16:34, Wei Liu wrote: > >>> > >>> I would like the code to generate dmar take into consideration > >>> libxl__dom_load_acpi. > >>> > >> > >> If add dmar table for hvmlite, we should combine dmar table with other > >> ACPI

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-23 Thread Lan Tianyu
On 2017年08月23日 16:34, Wei Liu wrote: > On Wed, Aug 23, 2017 at 01:35:17PM +0800, Lan Tianyu wrote: >> On 2017年08月22日 21:48, Wei Liu wrote: > Hi, Wei > Thanks for your comments. > > iirc, HVM only supports one module; DMAR cannot be a new module. Joining > to > the existing

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-23 Thread Wei Liu
On Wed, Aug 23, 2017 at 01:35:17PM +0800, Lan Tianyu wrote: > On 2017年08月22日 21:48, Wei Liu wrote: > >> > Hi, Wei > >> > Thanks for your comments. > >> > > >> > iirc, HVM only supports one module; DMAR cannot be a new module. Joining > >> > to > >> > the existing one is the approach we are

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-22 Thread Lan Tianyu
On 2017年08月22日 21:48, Wei Liu wrote: >> > Hi, Wei >> > Thanks for your comments. >> > >> > iirc, HVM only supports one module; DMAR cannot be a new module. Joining to >> > the existing one is the approach we are taking. >> > >> > Which kind of conflicts you think should be resolved? If you mean

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-22 Thread Wei Liu
On Fri, Aug 18, 2017 at 01:45:50PM +0800, Chao Gao wrote: > On Thu, Aug 17, 2017 at 01:28:21PM +0100, Wei Liu wrote: > >On Thu, Aug 17, 2017 at 12:32:17PM +0100, Wei Liu wrote: > >> On Wed, Aug 09, 2017 at 04:34:10PM -0400, Lan Tianyu wrote: > >> > diff --git a/tools/libxl/libxl_dom.c

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-22 Thread Wei Liu
On Fri, Aug 18, 2017 at 07:56:36AM -0600, Jan Beulich wrote: > >>> On 18.08.17 at 15:45, wrote: > > On Fri, Aug 18, 2017 at 01:45:50PM +0800, Chao Gao wrote: > >> > > >> >> > +} > >> >> > +} > >> >> > +} > >> >> > >> >> This still looks wrong to me.

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-18 Thread Jan Beulich
>>> On 18.08.17 at 15:45, wrote: > On Fri, Aug 18, 2017 at 01:45:50PM +0800, Chao Gao wrote: >> > >> >> > +} >> >> > +} >> >> > +} >> >> >> >> This still looks wrong to me. How do you know acpi_modules[0] is DMAR >> >> table? >> >> >> > >> >Oh, I

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-18 Thread Wei Liu
On Fri, Aug 18, 2017 at 01:45:50PM +0800, Chao Gao wrote: > > > >> > +} > >> > +} > >> > +} > >> > >> This still looks wrong to me. How do you know acpi_modules[0] is DMAR > >> table? > >> > > > >Oh, I sorta see why you do this, but I still think this is wrong. The >

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-17 Thread Chao Gao
On Thu, Aug 17, 2017 at 01:28:21PM +0100, Wei Liu wrote: >On Thu, Aug 17, 2017 at 12:32:17PM +0100, Wei Liu wrote: >> On Wed, Aug 09, 2017 at 04:34:10PM -0400, Lan Tianyu wrote: >> > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c >> > index f54fd49..94c9196 100644 >> > ---

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-17 Thread Wei Liu
On Thu, Aug 17, 2017 at 12:32:17PM +0100, Wei Liu wrote: > On Wed, Aug 09, 2017 at 04:34:10PM -0400, Lan Tianyu wrote: > > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c > > index f54fd49..94c9196 100644 > > --- a/tools/libxl/libxl_dom.c > > +++ b/tools/libxl/libxl_dom.c > > @@

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-17 Thread Wei Liu
On Wed, Aug 09, 2017 at 04:34:10PM -0400, Lan Tianyu wrote: > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c > index f54fd49..94c9196 100644 > --- a/tools/libxl/libxl_dom.c > +++ b/tools/libxl/libxl_dom.c > @@ -1060,6 +1060,42 @@ static int libxl__domain_firmware(libxl__gc *gc, >

[Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

2017-08-09 Thread Lan Tianyu
From: Chao Gao A new logic is added to build ACPI DMAR table in tool stack for a guest with one virtual VTD and pass through it to guest via existing mechanism. If there already are ACPI tables needed to pass through, we joint the tables. Signed-off-by: Chao Gao