Re: [Xen-devel] [PATCH V5 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-17 Thread Jan Beulich
On 13.02.15 at 19:09, andrew.coop...@citrix.com wrote: On 13/02/15 18:03, Tamas K Lengyel wrote: On Fri, Feb 13, 2015 at 6:23 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 13/02/15 16:33, Tamas K Lengyel wrote: v5: Style fixes Convert gfn to uint32_t It is perfectly possible to

[Xen-devel] [PATCH V5 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-13 Thread Tamas K Lengyel
The public mem_event structures used to communicate with helper applications via shared rings have been used in different settings. However, the variable names within this structure have not reflected this fact, resulting in the reuse of variables to mean different things under different

Re: [Xen-devel] [PATCH V5 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-13 Thread Andrew Cooper
On 13/02/15 16:33, Tamas K Lengyel wrote: The public mem_event structures used to communicate with helper applications via shared rings have been used in different settings. However, the variable names within this structure have not reflected this fact, resulting in the reuse of variables to

Re: [Xen-devel] [PATCH V5 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-13 Thread Andrew Cooper
On 13/02/15 18:03, Tamas K Lengyel wrote: On Fri, Feb 13, 2015 at 6:23 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 13/02/15 16:33, Tamas K Lengyel wrote: The public mem_event structures used to communicate with helper applications via shared rings have been used in different

Re: [Xen-devel] [PATCH V5 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-13 Thread Tamas K Lengyel
On Fri, Feb 13, 2015 at 7:09 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 13/02/15 18:03, Tamas K Lengyel wrote: On Fri, Feb 13, 2015 at 6:23 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 13/02/15 16:33, Tamas K Lengyel wrote: The public mem_event structures used to

Re: [Xen-devel] [PATCH V5 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-13 Thread Tamas K Lengyel
On Fri, Feb 13, 2015 at 6:23 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 13/02/15 16:33, Tamas K Lengyel wrote: The public mem_event structures used to communicate with helper applications via shared rings have been used in different settings. However, the variable names within