Re: [Xen-devel] [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value

2017-10-11 Thread Andrew Cooper 
On 11/10/17 16:41, Ross Lagerwall wrote:
> Return 0 to indicate success rather than whatever rc was previously set
> to (-EINVAL).
>
> Signed-off-by: Ross Lagerwall 
> ---
>  xen/arch/x86/hvm/dm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
> index 82addea..32ade95 100644
> --- a/xen/arch/x86/hvm/dm.c
> +++ b/xen/arch/x86/hvm/dm.c
> @@ -636,6 +636,7 @@ static int dm_op(const struct dmop_args *op_args)
>  _shutdown;
>  
>  domain_shutdown(d, data->reason);
> +rc = 0;

Ideally with a newline here (can be fixed on commit).

Reviewed-by: Andrew Cooper 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value

2017-10-11 Thread Ian Jackson 
Andrew Cooper writes ("Re: [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown 
return value"):
> On 11/10/17 16:41, Ross Lagerwall wrote:
> > Return 0 to indicate success rather than whatever rc was previously set
> > to (-EINVAL).
> >
> > Signed-off-by: Ross Lagerwall 
> > ---
> >  xen/arch/x86/hvm/dm.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
> > index 82addea..32ade95 100644
> > --- a/xen/arch/x86/hvm/dm.c
> > +++ b/xen/arch/x86/hvm/dm.c
> > @@ -636,6 +636,7 @@ static int dm_op(const struct dmop_args *op_args)
> >  _shutdown;
> >  
> >  domain_shutdown(d, data->reason);
> > +rc = 0;
> 
> Ideally with a newline here (can be fixed on commit).

Thanks to Ross for spotting this, and to whoever committed it so
speedily.

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value

2017-10-11 Thread Wei Liu 
On Wed, Oct 11, 2017 at 04:41:57PM +0100, Ross Lagerwall wrote:
> Return 0 to indicate success rather than whatever rc was previously set
> to (-EINVAL).
> 
> Signed-off-by: Ross Lagerwall 

Reviewed-by: Wei Liu 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value

2017-10-11 Thread Jan Beulich 
>>> On 11.10.17 at 17:41,  wrote:
> Return 0 to indicate success rather than whatever rc was previously set
> to (-EINVAL).
> 
> Signed-off-by: Ross Lagerwall 

Reviewed-by: Jan Beulich 



___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value

2017-10-11 Thread Ross Lagerwall 
Return 0 to indicate success rather than whatever rc was previously set
to (-EINVAL).

Signed-off-by: Ross Lagerwall 
---
 xen/arch/x86/hvm/dm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
index 82addea..32ade95 100644
--- a/xen/arch/x86/hvm/dm.c
+++ b/xen/arch/x86/hvm/dm.c
@@ -636,6 +636,7 @@ static int dm_op(const struct dmop_args *op_args)
 _shutdown;
 
 domain_shutdown(d, data->reason);
+rc = 0;
 break;
 }
 
-- 
2.9.5


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel