Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-29 Thread Stefano Stabellini
On Wed, 28 Oct 2015, Jan Beulich wrote: > >>> On 28.10.15 at 16:44, wrote: > > On 27/10/15 08:05, Jan Beulich wrote: > > On 26.10.15 at 19:08, wrote: > >>> However, IIUC, the get_xen_guest_handle is only exposed to the tools and > >>>

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-28 Thread Julien Grall
On 27/10/15 08:05, Jan Beulich wrote: On 26.10.15 at 19:08, wrote: >> However, IIUC, the get_xen_guest_handle is only exposed to the tools and >> therefore possible to modify it in order to pass the type. Am I wrong? >> FWIW, I haven't seen any usage in the tools

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-28 Thread Jan Beulich
>>> On 28.10.15 at 16:44, wrote: > On 27/10/15 08:05, Jan Beulich wrote: > On 26.10.15 at 19:08, wrote: >>> However, IIUC, the get_xen_guest_handle is only exposed to the tools and >>> therefore possible to modify it in order to pass the

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-27 Thread Jan Beulich
>>> On 26.10.15 at 19:08, wrote: > On 23/10/15 15:55, Ian Campbell wrote: >> On Fri, 2015-10-23 at 15:44 +0100, Julien Grall wrote: >>> Thank you for the explanation. I think we can do the same as x86 does >>> i.e: >>> >>> #define set_xen_guest_handle_raw(hnd, val)

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-27 Thread Jan Beulich
>>> On 26.10.15 at 19:08, wrote: > However, IIUC, the get_xen_guest_handle is only exposed to the tools and > therefore possible to modify it in order to pass the type. Am I wrong? > FWIW, I haven't seen any usage in the tools directory. Indeed. Rather than worrying

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-27 Thread Julien Grall
Hi Jan, On 27/10/2015 08:07, Jan Beulich wrote: On 26.10.15 at 19:08, wrote: On 23/10/15 15:55, Ian Campbell wrote: On Fri, 2015-10-23 at 15:44 +0100, Julien Grall wrote: Thank you for the explanation. I think we can do the same as x86 does i.e: #define

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-26 Thread Julien Grall
Hi, On 23/10/15 15:55, Ian Campbell wrote: > On Fri, 2015-10-23 at 15:44 +0100, Julien Grall wrote: >> On 23/10/15 15:37, Jan Beulich wrote: >> On 23.10.15 at 16:31, wrote: On Fri, 2015-10-23 at 08:16 -0600, Jan Beulich wrote: > No, the validating script is

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Jan Beulich
>>> On 23.10.15 at 15:58, wrote: > On 23/10/15 14:52, Jan Beulich wrote: > On 23.10.15 at 15:30, wrote: >>> On Fri, 2015-10-23 at 14:13 +0100, Julien Grall wrote: Hi, On 04/10/15 20:24, Julien Grall wrote: > The keyword

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Ian Campbell
On Fri, 2015-10-23 at 15:31 +0100, Ian Campbell wrote: > On Fri, 2015-10-23 at 08:16 -0600, Jan Beulich wrote: > > > > > On 23.10.15 at 15:58, wrote: > > > On 23/10/15 14:52, Jan Beulich wrote: > > > > > > > On 23.10.15 at 15:30, wrote: > > > > >

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Ian Campbell
On Fri, 2015-10-23 at 14:13 +0100, Julien Grall wrote: > Hi, > > On 04/10/15 20:24, Julien Grall wrote: > > The keyword typeof is not portable: > > > > /usr/src/freebsd/sys/xen/hypervisor.h:93:2: error: implicit declaration > > of function 'typeof' is invalid in C99 > >

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Julien Grall
Hi, On 04/10/15 20:24, Julien Grall wrote: > The keyword typeof is not portable: > > /usr/src/freebsd/sys/xen/hypervisor.h:93:2: error: implicit declaration > of function 'typeof' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] Ping? Aside the fact that other bits of the header

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Julien Grall
On 23/10/15 14:52, Jan Beulich wrote: On 23.10.15 at 15:30, wrote: >> On Fri, 2015-10-23 at 14:13 +0100, Julien Grall wrote: >>> Hi, >>> >>> On 04/10/15 20:24, Julien Grall wrote: The keyword typeof is not portable:

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Ian Campbell
On Fri, 2015-10-23 at 07:52 -0600, Jan Beulich wrote: > > > > On 23.10.15 at 15:30, wrote: > > On Fri, 2015-10-23 at 14:13 +0100, Julien Grall wrote: > > > Hi, > > > > > > On 04/10/15 20:24, Julien Grall wrote: > > > > The keyword typeof is not portable: > > > > > > > >

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Jan Beulich
>>> On 23.10.15 at 15:30, wrote: > On Fri, 2015-10-23 at 14:13 +0100, Julien Grall wrote: >> Hi, >> >> On 04/10/15 20:24, Julien Grall wrote: >> > The keyword typeof is not portable: >> > >> > /usr/src/freebsd/sys/xen/hypervisor.h:93:2: error: implicit declaration >> >

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Jan Beulich
>>> On 23.10.15 at 16:31, wrote: > On Fri, 2015-10-23 at 08:16 -0600, Jan Beulich wrote: >> > > > On 23.10.15 at 15:58, wrote: >> > On 23/10/15 14:52, Jan Beulich wrote: >> > > > > > On 23.10.15 at 15:30, wrote: >> > > >

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Jan Beulich
>>> On 23.10.15 at 16:55, wrote: > On Fri, 2015-10-23 at 15:44 +0100, Julien Grall wrote: >> #define set_xen_guest_handle_raw(hnd, val) \ >> do { if ( sizeof(hnd) == 8 ) *(uint64_t *)&(hnd) = 0; \ >> (hnd).p = val;

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Ian Campbell
On Fri, 2015-10-23 at 08:16 -0600, Jan Beulich wrote: > > > > On 23.10.15 at 15:58, wrote: > > On 23/10/15 14:52, Jan Beulich wrote: > > > > > > On 23.10.15 at 15:30, wrote: > > > > On Fri, 2015-10-23 at 14:13 +0100, Julien Grall wrote: > > > > >

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Julien Grall
On 23/10/15 15:37, Jan Beulich wrote: On 23.10.15 at 16:31, wrote: >> On Fri, 2015-10-23 at 08:16 -0600, Jan Beulich wrote: >>> No, the validating script is a nice-to-have, but nothing more. What >>> I was referring to was a patch to drop the use of this gcc

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Ian Campbell
On Fri, 2015-10-23 at 08:24 -0600, Jan Beulich wrote: > > > > On 23.10.15 at 16:03, wrote: > > On Fri, 2015-10-23 at 07:52 -0600, Jan Beulich wrote: > > > > > > On 23.10.15 at 15:30, wrote: > > > > On Fri, 2015-10-23 at 14:13 +0100, Julien Grall

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Ian Campbell
On Fri, 2015-10-23 at 15:44 +0100, Julien Grall wrote: > On 23/10/15 15:37, Jan Beulich wrote: > > > > > On 23.10.15 at 16:31, wrote: > > > On Fri, 2015-10-23 at 08:16 -0600, Jan Beulich wrote: > > > > No, the validating script is a nice-to-have, but nothing more. What >

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Jan Beulich
>>> On 23.10.15 at 16:48, wrote: > Perhaps this needs to be explicitly asked then, So, given: > #define set_xen_guest_handle_raw(hnd, val) \ > do {\ > typeof(&(hnd)) _sxghr_tmp = &(hnd);

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-23 Thread Jan Beulich
>>> On 23.10.15 at 16:03, wrote: > On Fri, 2015-10-23 at 07:52 -0600, Jan Beulich wrote: >> > > > On 23.10.15 at 15:30, wrote: >> > On Fri, 2015-10-23 at 14:13 +0100, Julien Grall wrote: >> > > Hi, >> > > >> > > On 04/10/15 20:24, Julien Grall

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-07 Thread Jan Beulich
>>> On 06.10.15 at 19:25, wrote: > On 05/10/15 11:31, Jan Beulich wrote: > On 04.10.15 at 21:24, wrote: >>> The keyword typeof is not portable: >>> >>> /usr/src/freebsd/sys/xen/hypervisor.h:93:2: error: implicit declaration >>> of function

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-07 Thread Ian Campbell
On Wed, 2015-10-07 at 00:31 -0600, Jan Beulich wrote: > > > > On 06.10.15 at 19:25, wrote: > > On 05/10/15 11:31, Jan Beulich wrote: > > > > > > On 04.10.15 at 21:24, wrote: > > > > The keyword typeof is not portable: > > > > > > > >

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-06 Thread Julien Grall
On 05/10/2015 14:40, Wei Liu wrote: On Sun, Oct 04, 2015 at 08:24:02PM +0100, Julien Grall wrote: The keyword typeof is not portable: /usr/src/freebsd/sys/xen/hypervisor.h:93:2: error: implicit declaration of function 'typeof' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-06 Thread Julien Grall
Hi Jan, On 05/10/15 11:31, Jan Beulich wrote: On 04.10.15 at 21:24, wrote: >> The keyword typeof is not portable: >> >> /usr/src/freebsd/sys/xen/hypervisor.h:93:2: error: implicit declaration >> of function 'typeof' is invalid in C99 >>

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-05 Thread Jan Beulich
>>> On 04.10.15 at 21:24, wrote: > The keyword typeof is not portable: > > /usr/src/freebsd/sys/xen/hypervisor.h:93:2: error: implicit declaration > of function 'typeof' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] Actually, it's worse than that -

Re: [Xen-devel] [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof

2015-10-05 Thread Wei Liu
On Sun, Oct 04, 2015 at 08:24:02PM +0100, Julien Grall wrote: > The keyword typeof is not portable: > > /usr/src/freebsd/sys/xen/hypervisor.h:93:2: error: implicit declaration > of function 'typeof' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > > Signed-off-by: Julien Grall