Re: [Xen-devel] [PATCH for-4.7] x86/compat: Cleanup and further debugging of SMAP/SMEP fixup

2016-05-17 Thread Jan Beulich
>>> On 16.05.16 at 12:49, wrote: > * Abstract (X86_CR4_SMEP | X86_CR4_SMAP) behind XEN_CR4_PV32_BITS to avoid >opencoding the invidial bits which are fixed up behind a 32bit PV guests >back. > * In the debug case, perform the the AND and CMP on 64bit values

Re: [Xen-devel] [PATCH for-4.7] x86/compat: Cleanup and further debugging of SMAP/SMEP fixup

2016-05-16 Thread Wei Liu
On Mon, May 16, 2016 at 11:49:31AM +0100, Andrew Cooper wrote: > * Abstract (X86_CR4_SMEP | X86_CR4_SMAP) behind XEN_CR4_PV32_BITS to avoid >opencoding the invidial bits which are fixed up behind a 32bit PV guests >back. > * In the debug case, perform the the AND and CMP on 64bit values

[Xen-devel] [PATCH for-4.7] x86/compat: Cleanup and further debugging of SMAP/SMEP fixup

2016-05-16 Thread Andrew Cooper
* Abstract (X86_CR4_SMEP | X86_CR4_SMAP) behind XEN_CR4_PV32_BITS to avoid opencoding the invidial bits which are fixed up behind a 32bit PV guests back. * In the debug case, perform the the AND and CMP on 64bit values rather than 32bit values, to match the logic in then non-debug case.