Re: [Xen-devel] [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU

2014-11-18 Thread Ian Jackson
Julien Grall writes (Re: [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU): I need to create an empty structure. Is the dummy field really needed? Empty structs are a gcc extension (`(gcc-4.4) Empty Structures'). I would be very surprised if clang didn't support them too. AIUI our

Re: [Xen-devel] [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU

2014-11-18 Thread Julien Grall
On 11/18/2014 03:10 PM, Ian Jackson wrote: Julien Grall writes (Re: [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU): I need to create an empty structure. Is the dummy field really needed? Empty structs are a gcc extension (`(gcc-4.4) Empty Structures'). I would be very

Re: [Xen-devel] [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU

2014-11-18 Thread Ian Jackson
Julien Grall writes (Re: [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU): On 11/18/2014 03:10 PM, Ian Jackson wrote: Empty structs are a gcc extension (`(gcc-4.4) Empty Structures'). I would be very surprised if clang didn't support them too. AFAIK, clang doesn't complain

Re: [Xen-devel] [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU

2014-11-18 Thread Jan Beulich
On 18.11.14 at 16:00, julien.gr...@linaro.org wrote: On 10/31/2014 09:02 AM, Jan Beulich wrote: On 30.10.14 at 19:51, julien.gr...@linaro.org wrote: The naming suggests that the #if really should be around just the gic_version field (with a dummy field in the #else case to be C89 compatible,

Re: [Xen-devel] [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU

2014-11-18 Thread Julien Grall
On 11/18/2014 04:15 PM, Jan Beulich wrote: On 18.11.14 at 16:00, julien.gr...@linaro.org wrote: On 10/31/2014 09:02 AM, Jan Beulich wrote: On 30.10.14 at 19:51, julien.gr...@linaro.org wrote: The naming suggests that the #if really should be around just the gic_version field (with a dummy