Re: [Xen-devel] [PATCH v2] hvm: vmx/svm_cpu_up_prepare should be called only once

2017-08-18 Thread Boris Ostrovsky
On 08/17/2017 02:07 PM, Andrew Cooper wrote: > On 17/08/17 17:51, Boris Ostrovsky wrote: >> @@ -1589,7 +1585,7 @@ const struct hvm_function_table * __init >> start_svm(void) >> >> svm_host_osvw_reset(); >> >> -if ( _svm_cpu_up(true) ) >> +if (

Re: [Xen-devel] [PATCH v2] hvm: vmx/svm_cpu_up_prepare should be called only once

2017-08-17 Thread Andrew Cooper
On 17/08/17 17:51, Boris Ostrovsky wrote: > @@ -1589,7 +1585,7 @@ const struct hvm_function_table * __init start_svm(void) > > svm_host_osvw_reset(); > > -if ( _svm_cpu_up(true) ) > +if ( svm_cpu_up_prepare(smp_processor_id()) || _svm_cpu_up(true) ) Both of these could pass 0

[Xen-devel] [PATCH v2] hvm: vmx/svm_cpu_up_prepare should be called only once

2017-08-17 Thread Boris Ostrovsky
These routines are first called via CPU_UP_PREPARE notifier by the BSP and then by the booting ASP from vmx_cpu_up()/_svm_cpu_up(). Avoid the unnecessary second call. Signed-off-by: Boris Ostrovsky Reported-by: Andrew Cooper --- V2: * Call