Re: [Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

On 01/30/2017 08:47 AM, Vineeth Remanan Pillai wrote: On 01/29/2017 03:09 PM, Boris Ostrovsky wrote: There are couple of problems with this patch. 1. The 'if' clause now evaluates to true on pretty much every call to xennet_alloc_rx_buffers(). Thanks for catching this. In my testing I did

Re: [Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

On 01/30/2017 09:06 AM, Boris Ostrovsky wrote: On 01/30/2017 11:47 AM, Vineeth Remanan Pillai wrote: 2. It tickles a latent bug during resume where the timer triggers before we re-connect. The trouble is that we now try to dereference queue->rx.sring which is NULL since we disconnect in

Re: [Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

On 01/30/2017 11:47 AM, Vineeth Remanan Pillai wrote: > >> 2. It tickles a latent bug during resume where the timer triggers >> before we re-connect. The trouble is that we now try to dereference >> queue->rx.sring which is NULL since we disconnect in >> netfront_resume(). (Curiously, I only

Re: [Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

On 01/29/2017 03:09 PM, Boris Ostrovsky wrote: There are couple of problems with this patch. 1. The 'if' clause now evaluates to true on pretty much every call to xennet_alloc_rx_buffers(). Thanks for catching this. In my testing I did not notice this - mostly because of the nature of the

Re: [Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

On 01/19/2017 11:35 AM, Vineeth Remanan Pillai wrote: From: Vineeth Remanan Pillai During an OOM scenario, request slots could not be created as skb allocation fails. So the netback cannot pass in packets and netfront wrongly assumes that there is no more work to be done

[Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

From: Vineeth Remanan Pillai During an OOM scenario, request slots could not be created as skb allocation fails. So the netback cannot pass in packets and netfront wrongly assumes that there is no more work to be done and it disables polling. This causes Rx to stall. The

Re: [Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

On 01/18/2017 12:10 PM, David Miller wrote: This v2 never made it into patchwork. I don't know why, so please resend it to netdev with the accumulated reviewed-by etc. tags added. Thanks. Sorry about that. Will resend as a separate thread right away. Thanks

Re: [Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

This v2 never made it into patchwork. I don't know why, so please resend it to netdev with the accumulated reviewed-by etc. tags added. Thanks. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

From: Vineeth Remanan Pillai Date: Wed, 18 Jan 2017 09:02:17 -0800 > > On 01/15/2017 10:24 PM, Juergen Gross wrote: >> On 13/01/17 18:55, Remanan Pillai wrote: >>> From: Vineeth Remanan Pillai >>> >>> During an OOM scenario, request slots could not be

Re: [Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

On 01/15/2017 10:24 PM, Juergen Gross wrote: On 13/01/17 18:55, Remanan Pillai wrote: From: Vineeth Remanan Pillai During an OOM scenario, request slots could not be created as skb allocation fails. So the netback cannot pass in packets and netfront wrongly assumes that

Re: [Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

On 13/01/17 18:55, Remanan Pillai wrote: > From: Vineeth Remanan Pillai > > During an OOM scenario, request slots could not be created as skb > allocation fails. So the netback cannot pass in packets and netfront > wrongly assumes that there is no more work to be done and it

[Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

From: Vineeth Remanan Pillai During an OOM scenario, request slots could not be created as skb allocation fails. So the netback cannot pass in packets and netfront wrongly assumes that there is no more work to be done and it disables polling. This causes Rx to stall. The