Re: [Xen-devel] [PATCH v2 03/16] xen/x86: p2m-pod: Fix coding style for comments

2017-09-21 Thread Julien Grall
Hi, On 21/09/17 17:28, George Dunlap wrote: On 09/21/2017 01:40 PM, Julien Grall wrote: Signed-off-by: Julien Grall Acked-by: Andrew Cooper Should probably add something like: "While we're here, specify 1UL when shifting in a couple of

Re: [Xen-devel] [PATCH v2 03/16] xen/x86: p2m-pod: Fix coding style for comments

2017-09-21 Thread George Dunlap
On 09/21/2017 05:28 PM, George Dunlap wrote: > On 09/21/2017 01:40 PM, Julien Grall wrote: >> Signed-off-by: Julien Grall >> Acked-by: Andrew Cooper > > Should probably add something like: > > "While we're here, specify 1UL when shifting in a

Re: [Xen-devel] [PATCH v2 03/16] xen/x86: p2m-pod: Fix coding style for comments

2017-09-21 Thread George Dunlap
On 09/21/2017 01:40 PM, Julien Grall wrote: > Signed-off-by: Julien Grall > Acked-by: Andrew Cooper Should probably add something like: "While we're here, specify 1UL when shifting in a couple of cases." This could be done on check-in.

Re: [Xen-devel] [PATCH v2 03/16] xen/x86: p2m-pod: Fix coding style for comments

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:22PM +0100, Julien Grall wrote: > Signed-off-by: Julien Grall > Acked-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list

[Xen-devel] [PATCH v2 03/16] xen/x86: p2m-pod: Fix coding style for comments

2017-09-21 Thread Julien Grall
Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Changes in v2: - Add Andrew's acked-by ---