Re: [Xen-devel] [PATCH v2 05/16] xen/x86: p2m-pod: Avoid redundant assignments in p2m_pod_demand_populate

2017-09-21 Thread George Dunlap
On 09/21/2017 01:40 PM, Julien Grall wrote: > gfn_aligned is assigned 3 times with the exact same formula. All the > variables used are not modified, so consolidate in a single assignment > at the beginning of the function. > > Signed-off-by: Julien Grall > Acked-by: Andrew

Re: [Xen-devel] [PATCH v2 05/16] xen/x86: p2m-pod: Avoid redundant assignments in p2m_pod_demand_populate

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:24PM +0100, Julien Grall wrote: > gfn_aligned is assigned 3 times with the exact same formula. All the > variables used are not modified, so consolidate in a single assignment > at the beginning of the function. > > Signed-off-by: Julien Grall

[Xen-devel] [PATCH v2 05/16] xen/x86: p2m-pod: Avoid redundant assignments in p2m_pod_demand_populate

2017-09-21 Thread Julien Grall
gfn_aligned is assigned 3 times with the exact same formula. All the variables used are not modified, so consolidate in a single assignment at the beginning of the function. Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George