Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t

2015-07-14 Thread Ian Jackson
Jan Beulich writes (Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t): On 13.07.15 at 18:56, ian.jack...@eu.citrix.com wrote: Surely xfree() ought to have the same prototype as free() ? Why? If it were to be a full match, why wouldn't we call

Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t

2015-07-14 Thread Jan Beulich
On 13.07.15 at 18:56, ian.jack...@eu.citrix.com wrote: Jan Beulich writes (Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t): On 07.07.15 at 12:07, andrew.coop...@citrix.com wrote: Just like free(), these functions are not performing a read

Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t

2015-07-14 Thread Jan Beulich
On 14.07.15 at 12:54, ian.jack...@eu.citrix.com wrote: Jan Beulich writes (Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t): On 13.07.15 at 18:56, ian.jack...@eu.citrix.com wrote: Surely xfree() ought to have the same prototype as free

Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t

2015-07-13 Thread Ian Jackson
Jan Beulich writes (Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t): On 07.07.15 at 12:07, andrew.coop...@citrix.com wrote: Just like free(), these functions are not performing a read-only operation on the destination pointer, therefore must

Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t

2015-07-07 Thread Ian Campbell
On Thu, 2015-07-02 at 13:04 +0100, Ben Catterall wrote: From: Andrew Cooper andrew.coop...@citrix.com The sh_map/unmap wrappers can be dropped, and take the opportunity to turn some #define's into static inlines, for added type saftey. As part of adding the type safety, GCC highlights an

Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t

2015-07-07 Thread Andrew Cooper
On 07/07/15 11:01, Jan Beulich wrote: On 02.07.15 at 14:04, ben.catter...@citrix.com wrote: --- a/xen/include/xen/domain_page.h +++ b/xen/include/xen/domain_page.h @@ -41,11 +41,15 @@ unsigned long domain_page_map_to_mfn(const void *va); * address spaces (not just within the VCPU that

Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t

2015-07-07 Thread Jan Beulich
On 07.07.15 at 12:07, andrew.coop...@citrix.com wrote: On 07/07/15 11:01, Jan Beulich wrote: On 02.07.15 at 14:04, ben.catter...@citrix.com wrote: --- a/xen/include/xen/domain_page.h +++ b/xen/include/xen/domain_page.h @@ -41,11 +41,15 @@ unsigned long domain_page_map_to_mfn(const void *va);

[Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t

2015-07-02 Thread Ben Catterall
From: Andrew Cooper andrew.coop...@citrix.com The sh_map/unmap wrappers can be dropped, and take the opportunity to turn some #define's into static inlines, for added type saftey. As part of adding the type safety, GCC highlights an problematic include cycle with arm/mm.h including domain_page.h