Re: [Xen-devel] [PATCH v3 10/24] xen/arm: gic: Add sanity checks gic_route_irq_to_guest

2015-02-23 Thread Julien Grall
Hi Ian, On 23/02/15 15:20, Ian Campbell wrote: On Fri, 2015-02-20 at 17:28 +, Julien Grall wrote: The priority is controlled by route_irq_to_guest and set statically using GIC_PRI_IRQ. If we decide to hardcoded the priority here, we should drop the parameter on gic_route_irq_guest. But

Re: [Xen-devel] [PATCH v3 10/24] xen/arm: gic: Add sanity checks gic_route_irq_to_guest

2015-02-23 Thread Ian Campbell
On Fri, 2015-02-20 at 17:28 +, Julien Grall wrote: Hi Ian, On 20/02/15 16:07, Ian Campbell wrote: More importantly: We have (hopefully) guaranteed elsewhere that an PPI or SGI can never make it here, I take it. If that's the case then either the comment should say that, or more

Re: [Xen-devel] [PATCH v3 10/24] xen/arm: gic: Add sanity checks gic_route_irq_to_guest

2015-02-23 Thread Ian Campbell
On Mon, 2015-02-23 at 15:54 +, Julien Grall wrote: On 23/02/15 15:52, Ian Campbell wrote: On Mon, 2015-02-23 at 15:47 +, Julien Grall wrote: Hi Ian, On 23/02/15 15:20, Ian Campbell wrote: On Fri, 2015-02-20 at 17:28 +, Julien Grall wrote: The priority is controlled by

Re: [Xen-devel] [PATCH v3 10/24] xen/arm: gic: Add sanity checks gic_route_irq_to_guest

2015-02-23 Thread Julien Grall
On 23/02/15 15:52, Ian Campbell wrote: On Mon, 2015-02-23 at 15:47 +, Julien Grall wrote: Hi Ian, On 23/02/15 15:20, Ian Campbell wrote: On Fri, 2015-02-20 at 17:28 +, Julien Grall wrote: The priority is controlled by route_irq_to_guest and set statically using GIC_PRI_IRQ. If we

Re: [Xen-devel] [PATCH v3 10/24] xen/arm: gic: Add sanity checks gic_route_irq_to_guest

2015-02-20 Thread Julien Grall
Hi Ian, On 20/02/15 16:07, Ian Campbell wrote: More importantly: We have (hopefully) guaranteed elsewhere that an PPI or SGI can never make it here, I take it. If that's the case then either the comment should say that, or more likely, the comment is redundently restating the assert's

Re: [Xen-devel] [PATCH v3 10/24] xen/arm: gic: Add sanity checks gic_route_irq_to_guest

2015-02-20 Thread Ian Campbell
On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: With the addition of interrupt assignment to guest, we need to make sure the guest don't blow up the interrupt management in Xen. s/don't/can't/ Before associating the IRQ to a vIRQ we need to make sure: - the vIRQ is not already

Re: [Xen-devel] [PATCH v3 10/24] xen/arm: gic: Add sanity checks gic_route_irq_to_guest

2015-01-28 Thread Stefano Stabellini
On Tue, 13 Jan 2015, Julien Grall wrote: With the addition of interrupt assignment to guest, we need to make sure the guest don't blow up the interrupt management in Xen. Before associating the IRQ to a vIRQ we need to make sure: - the vIRQ is not already associated to another IRQ -