Re: [Xen-devel] [PATCH v3 5/6] x86/pagewalk: Improve the logic behind setting access and dirty bits

2017-03-27 Thread Tim Deegan
At 11:03 +0100 on 27 Mar (1490612603), Andrew Cooper wrote: > The boolean pse2M is misnamed, because it might refer to a 4M superpage. > > Switch the logic to be in terms of the level of the leaf entry, and rearrange > the calls to set_ad_bits() to be a fallthrough switch statement, to make it >

[Xen-devel] [PATCH v3 5/6] x86/pagewalk: Improve the logic behind setting access and dirty bits

2017-03-27 Thread Andrew Cooper
The boolean pse2M is misnamed, because it might refer to a 4M superpage. Switch the logic to be in terms of the level of the leaf entry, and rearrange the calls to set_ad_bits() to be a fallthrough switch statement, to make it easier to follow. Alter set_ad_bits() to take properly typed pointers