Re: [Xen-devel] [PATCH v4] xen: Allow a default compiled-in command line using Kconfig

2017-03-13 Thread Zhongze Liu
>2017-03-13 19:52 GMT+08:00 Jan Beulich : @@ -1566,14 +1557,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) /* Grab the DOM0 command line. */ cmdline = (char *)(mod[0].string ? __va(mod[0].string) : NULL); -if ( (cmdline

Re: [Xen-devel] [PATCH v4] xen: Allow a default compiled-in command line using Kconfig

2017-03-13 Thread Jan Beulich
>>> On 10.03.17 at 18:36, wrote: > 2017-03-10 23:03 GMT+08:00 Jan Beulich : > On 09.03.17 at 04:13, wrote: >>> If CMDLINE is set, the cmdline_parse() routine will append the bootloader >>> command line to this string, forming the

Re: [Xen-devel] [PATCH v4] xen: Allow a default compiled-in command line using Kconfig

2017-03-10 Thread Zhongze Liu
2017-03-10 23:03 GMT+08:00 Jan Beulich : On 09.03.17 at 04:13, wrote: >> If CMDLINE is set, the cmdline_parse() routine will append the bootloader >> command line to this string, forming the complete command line >> before parsing. > > I disagree to

Re: [Xen-devel] [PATCH v4] xen: Allow a default compiled-in command line using Kconfig

2017-03-10 Thread Jan Beulich
>>> On 09.03.17 at 04:13, wrote: > If CMDLINE is set, the cmdline_parse() routine will append the bootloader > command line to this string, forming the complete command line > before parsing. I disagree to making it behave like this: There's no need to concatenate both,

[Xen-devel] [PATCH v4] xen: Allow a default compiled-in command line using Kconfig

2017-03-08 Thread Zhongze Liu
Added 2 new config entries in common/Kconfig: CMDLINE and CMDLINE_OVERRIDE Modified the interface common/kernel.c:cmdline_parse(). The 2 new entries allow an embedded command line to be compiled in the hypervisor.This allows downstreams to set their defaults without modifying the source code