Re: [Xen-devel] [PATCH v4 2/2] xen: move TLB-flush filtering out into populate_physmap during vm creation

2016-09-16 Thread Dongli Zhang
> What is the scenario that you would want toolstack to set such flag? > > Shouldn't hypervisor always set the flag when the guest is never > unpaused and always clear / ignore that flag if the guest is ever > unpaused? If that's all is needed, why does toolstack need to get > involved? You are r

Re: [Xen-devel] [PATCH v4 2/2] xen: move TLB-flush filtering out into populate_physmap during vm creation

2016-09-16 Thread Wei Liu
On Fri, Sep 16, 2016 at 03:47:23AM -0700, Dongli Zhang wrote: > > > +/* > > > + * MEMF_no_tlbflush can be set only during vm creation phase when > > > + * is_ever_unpaused is still false before this domain gets unpaused > > > for > > > + * the first time. > > > + */ > > > +

Re: [Xen-devel] [PATCH v4 2/2] xen: move TLB-flush filtering out into populate_physmap during vm creation

2016-09-16 Thread Dongli Zhang
> > +/* > > + * MEMF_no_tlbflush can be set only during vm creation phase when > > + * is_ever_unpaused is still false before this domain gets unpaused for > > + * the first time. > > + */ > > +if ( unlikely(!d->is_ever_unpaused) ) > > +a->memflags |= MEMF_no_tlbflus

Re: [Xen-devel] [PATCH v4 2/2] xen: move TLB-flush filtering out into populate_physmap during vm creation

2016-09-15 Thread Jan Beulich
>>> On 12.09.16 at 10:16, wrote: > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -303,6 +303,8 @@ struct domain *domain_create(domid_t domid, unsigned int > domcr_flags, > if ( !zalloc_cpumask_var(&d->domain_dirty_cpumask) ) > goto fail; > > +d->is_ever_unpaused =

Re: [Xen-devel] [PATCH v4 2/2] xen: move TLB-flush filtering out into populate_physmap during vm creation

2016-09-14 Thread Dario Faggioli
On Mon, 2016-09-12 at 16:16 +0800, Dongli Zhang wrote: > This patch implemented parts of TODO left in commit id > a902c12ee45fc9389eb8fe54eeddaf267a555c58. > We usually put both the (not necessarily full) hash and the subject line of the commit in here. > Signed-off-by: Dongli Zhang >  > diff --

[Xen-devel] [PATCH v4 2/2] xen: move TLB-flush filtering out into populate_physmap during vm creation

2016-09-12 Thread Dongli Zhang
This patch implemented parts of TODO left in commit id a902c12ee45fc9389eb8fe54eeddaf267a555c58. It moved TLB-flush filtering out into populate_physmap. Because of TLB-flush in alloc_heap_pages, it's very slow to create a guest with memory size of more than 100GB on host with 100+ cpus. This patch