Re: [Xen-devel] [RFC PATCH V2 4/4] xl/libacpi: extend lapic_id() to uint32_t

2017-09-04 Thread Wei Liu 
On Fri, Sep 01, 2017 at 04:41:48PM +0100, Wei Liu wrote:
> On Thu, Aug 31, 2017 at 01:01:49AM -0400, Lan Tianyu wrote:
> > From: Chao Gao 
> > 
> > This patch is to extend lapic_id() to support more vcpus.
> > 
> > Signed-off-by: Chao Gao 
> > Signed-off-by: Lan Tianyu 
> 
> Acked-by: Wei Liu 
> 
> Please remember to pick up my ack next time around -- I believed I
> already acked this in the previous version.

No, my memory messed up, I didn't actually give my ack. Sorry for the
noise.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [RFC PATCH V2 4/4] xl/libacpi: extend lapic_id() to uint32_t

2017-09-01 Thread Wei Liu 
On Thu, Aug 31, 2017 at 01:01:49AM -0400, Lan Tianyu wrote:
> From: Chao Gao 
> 
> This patch is to extend lapic_id() to support more vcpus.
> 
> Signed-off-by: Chao Gao 
> Signed-off-by: Lan Tianyu 

Acked-by: Wei Liu 

Please remember to pick up my ack next time around -- I believed I
already acked this in the previous version.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [RFC PATCH V2 4/4] xl/libacpi: extend lapic_id() to uint32_t

2017-08-31 Thread Andrew Cooper 
On 31/08/17 06:01, Lan Tianyu wrote:
> From: Chao Gao 
>
> This patch is to extend lapic_id() to support more vcpus.
>
> Signed-off-by: Chao Gao 
> Signed-off-by: Lan Tianyu 

Reviewed-by: Andrew Cooper 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [RFC PATCH V2 4/4] xl/libacpi: extend lapic_id() to uint32_t

2017-08-31 Thread Lan Tianyu 
From: Chao Gao 

This patch is to extend lapic_id() to support more vcpus.

Signed-off-by: Chao Gao 
Signed-off-by: Lan Tianyu 
---
 tools/firmware/hvmloader/util.c | 2 +-
 tools/libacpi/libacpi.h | 2 +-
 tools/libxl/libxl_x86_acpi.c| 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c
index db5f240..814ac2e 100644
--- a/tools/firmware/hvmloader/util.c
+++ b/tools/firmware/hvmloader/util.c
@@ -883,7 +883,7 @@ static void acpi_mem_free(struct acpi_ctxt *ctxt,
 /* ACPI builder currently doesn't free memory so this is just a stub */
 }
 
-static uint8_t acpi_lapic_id(unsigned cpu)
+static uint32_t acpi_lapic_id(unsigned cpu)
 {
 return LAPIC_ID(cpu);
 }
diff --git a/tools/libacpi/libacpi.h b/tools/libacpi/libacpi.h
index 74778a5..0b04cbc 100644
--- a/tools/libacpi/libacpi.h
+++ b/tools/libacpi/libacpi.h
@@ -93,7 +93,7 @@ struct acpi_config {
 unsigned long rsdp;
 
 /* x86-specific parameters */
-uint8_t (*lapic_id)(unsigned cpu);
+uint32_t (*lapic_id)(unsigned cpu);
 uint32_t lapic_base_address;
 uint32_t ioapic_base_address;
 uint16_t pci_isa_irq_mask;
diff --git a/tools/libxl/libxl_x86_acpi.c b/tools/libxl/libxl_x86_acpi.c
index 1fa97ff..8fe084d 100644
--- a/tools/libxl/libxl_x86_acpi.c
+++ b/tools/libxl/libxl_x86_acpi.c
@@ -85,7 +85,7 @@ static void acpi_mem_free(struct acpi_ctxt *ctxt,
 {
 }
 
-static uint8_t acpi_lapic_id(unsigned cpu)
+static uint32_t acpi_lapic_id(unsigned cpu)
 {
 return cpu * 2;
 }
-- 
1.8.3.1


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel