Re: [Xen-devel] [RFC v2 7/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2017-11-21 Thread Goel, Sameer
On 11/20/2017 7:25 AM, Julien Grall wrote: > Hi Sameer, > > On 19/11/17 07:45, Goel, Sameer wrote: >> On 10/12/2017 10:36 AM, Julien Grall wrote: + +typedef paddr_t phys_addr_t; +typedef paddr_t dma_addr_t; + +/* Alias to Xen device tree helpers */ +#define

Re: [Xen-devel] [RFC v2 7/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2017-11-20 Thread Julien Grall
Hi, On 20/11/17 15:19, Robin Murphy wrote: On 20/11/17 14:25, Julien Grall wrote: [...] +    else {    cpu_relax(); Hmmm I now see why you added cpu_relax() at the top. Well, on Xen cpu_relax is just a barrier. On Linux it is used to yield. And that bit is worrying me.

Re: [Xen-devel] [RFC v2 7/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2017-11-20 Thread Robin Murphy
On 20/11/17 14:25, Julien Grall wrote: [...] +    else {    cpu_relax(); Hmmm I now see why you added cpu_relax() at the top. Well, on Xen cpu_relax is just a barrier. On Linux it is used to yield. And that bit is worrying me. The Linux code will allow context switching

Re: [Xen-devel] [RFC v2 7/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2017-11-20 Thread Julien Grall
Hi Sameer, On 19/11/17 07:45, Goel, Sameer wrote: On 10/12/2017 10:36 AM, Julien Grall wrote: + +typedef paddr_t phys_addr_t; +typedef paddr_t dma_addr_t; + +/* Alias to Xen device tree helpers */ +#define device_node dt_device_node +#define of_phandle_args dt_phandle_args +#define

Re: [Xen-devel] [RFC v2 7/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2017-11-18 Thread Goel, Sameer
On 10/12/2017 10:36 AM, Julien Grall wrote: > Hi Sameer, > > Given this is all Arm specific. I am not sure why people like Andrew, Jan > have been added. > > Please use scripts/get_maintainers to find the list of maintainers per > patches and avoid to CC all of them on each patches. Ok. >

Re: [Xen-devel] [RFC v2 7/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2017-10-12 Thread Julien Grall
Hi Sameer, Given this is all Arm specific. I am not sure why people like Andrew, Jan have been added. Please use scripts/get_maintainers to find the list of maintainers per patches and avoid to CC all of them on each patches. On 21/09/17 01:37, Sameer Goel wrote: This driver follows an

Re: [Xen-devel] [RFC v2 7/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2017-09-25 Thread Goel, Sameer
On 9/20/2017 6:37 PM, Sameer Goel wrote: > This driver follows an approach similar to smmu driver. The intent here > is to reuse as much Linux code as possible. > - Glue code has been introduced to bridge the API calls. > - Called Linux functions from the Xen IOMMU function calls. > - Xen

[Xen-devel] [RFC v2 7/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2017-09-20 Thread Sameer Goel
This driver follows an approach similar to smmu driver. The intent here is to reuse as much Linux code as possible. - Glue code has been introduced to bridge the API calls. - Called Linux functions from the Xen IOMMU function calls. - Xen modifications are preceded by /*Xen: comment */