Re: [Xen-devel] [Resend PATCH 1/2] Xen/Keyhandler: Make keyhandler always run in tasklet

2016-10-10 Thread Lan Tianyu
On 2016年10月10日 21:55, Konrad Rzeszutek Wilk wrote: > On Sat, Oct 08, 2016 at 11:26:44AM +0800, Lan Tianyu wrote: >> On 2016年10月06日 20:52, Jan Beulich wrote: >> On 30.09.16 at 04:19, wrote: @@ -87,10 +89,10 @@ void handle_keypress(unsigned char key, struct

Re: [Xen-devel] [Resend PATCH 1/2] Xen/Keyhandler: Make keyhandler always run in tasklet

2016-10-10 Thread Konrad Rzeszutek Wilk
On Sat, Oct 08, 2016 at 11:26:44AM +0800, Lan Tianyu wrote: > On 2016年10月06日 20:52, Jan Beulich wrote: > On 30.09.16 at 04:19, wrote: > >> @@ -87,10 +89,10 @@ void handle_keypress(unsigned char key, struct > >> cpu_user_regs *regs) > >> if ( key >=

Re: [Xen-devel] [Resend PATCH 1/2] Xen/Keyhandler: Make keyhandler always run in tasklet

2016-10-10 Thread Jan Beulich
>>> On 08.10.16 at 05:26, wrote: > On 2016年10月06日 20:52, Jan Beulich wrote: > On 30.09.16 at 04:19, wrote: >>> @@ -87,10 +89,10 @@ void handle_keypress(unsigned char key, struct > cpu_user_regs *regs) >>> if ( key >= ARRAY_SIZE(key_table) ||

Re: [Xen-devel] [Resend PATCH 1/2] Xen/Keyhandler: Make keyhandler always run in tasklet

2016-10-07 Thread Lan Tianyu
On 2016年10月06日 20:52, Jan Beulich wrote: On 30.09.16 at 04:19, wrote: >> @@ -87,10 +89,10 @@ void handle_keypress(unsigned char key, struct >> cpu_user_regs *regs) >> if ( key >= ARRAY_SIZE(key_table) || !(h = _table[key])->fn ) >> return; >> >> -if

Re: [Xen-devel] [Resend PATCH 1/2] Xen/Keyhandler: Make keyhandler always run in tasklet

2016-10-07 Thread Lan Tianyu
Hi Konrad: Thanks for your review. On 2016年10月01日 02:07, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 30, 2016 at 10:19:05AM +0800, Lan Tianyu wrote: >> Keyhandler may run for a long time in a timer handler on the large machine > > I am bit lost. > > You say 'timer handler' which will

Re: [Xen-devel] [Resend PATCH 1/2] Xen/Keyhandler: Make keyhandler always run in tasklet

2016-10-06 Thread Jan Beulich
>>> On 30.09.16 at 04:19, wrote: > @@ -87,10 +89,10 @@ void handle_keypress(unsigned char key, struct > cpu_user_regs *regs) > if ( key >= ARRAY_SIZE(key_table) || !(h = _table[key])->fn ) > return; > > -if ( !in_irq() || h->irq_callback ) > +if (

Re: [Xen-devel] [Resend PATCH 1/2] Xen/Keyhandler: Make keyhandler always run in tasklet

2016-09-30 Thread Konrad Rzeszutek Wilk
On Fri, Sep 30, 2016 at 10:19:05AM +0800, Lan Tianyu wrote: > Keyhandler may run for a long time in a timer handler on the large machine I am bit lost. You say 'timer handler' which will imply that there is some form of 'init_timer' and 'set_timer' that would call the handle_keypress function?

[Xen-devel] [Resend PATCH 1/2] Xen/Keyhandler: Make keyhandler always run in tasklet

2016-09-29 Thread Lan Tianyu
Keyhandler may run for a long time in a timer handler on the large machine with a lot of physical cpus(E,G keyhandler for dumping timer info) when serial port driver works in the poll mode. When timer interrupt arrives, timer subsystem runs all timer handlers before programming next timer