Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-21 Thread Ian Jackson
Prashant Sreedharan writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): On Fri, 2015-04-17 at 15:12 -0400, David Miller wrote: From: Konrad Rzeszutek Wilk konrad.w...@oracle.com Date: Fri, 17 Apr 2015 15:04:48 -0400 A huge amount of NIC drivers use the DMA API,

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread Michael Chan
On Fri, 2015-04-17 at 13:19 -0400, David Miller wrote: So the gist of the situation is, that NEED_DMA_MAP_STATE can be 'n' in situations where we might actually need it to be 'y' based upon kernel comman line boot options given. Right? Yes.

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread David Miller
From: Ian Jackson ian.jack...@eu.citrix.com Date: Fri, 17 Apr 2015 17:29:28 +0100 Prashant Sreedharan writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): Ok this is what is causing the problem, the driver uses DEFINE_DMA_UNMAP_ADDR(), dma_unmap_addr_set() to keep a

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread Konrad Rzeszutek Wilk
On Fri, Apr 17, 2015 at 10:46:09AM -0700, Michael Chan wrote: On Fri, 2015-04-17 at 13:19 -0400, David Miller wrote: So the gist of the situation is, that NEED_DMA_MAP_STATE can be 'n' in situations where we might actually need it to be 'y' based upon kernel comman line boot options given.

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread David Miller
From: Konrad Rzeszutek Wilk konrad.w...@oracle.com Date: Fri, 17 Apr 2015 15:04:48 -0400 From 9e417af099e3cee2b219ab28ffc1e96b0564b213 Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk konrad.w...@oracle.com Date: Fri, 17 Apr 2015 14:55:47 -0400 Subject: [PATCH] config: Enable

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread Ian Jackson
Prashant Sreedharan writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): Ok this is what is causing the problem, the driver uses DEFINE_DMA_UNMAP_ADDR(), dma_unmap_addr_set() to keep a copy of the dma mapping and dma_unmap_addr() to get the mapping value. On most of the

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-16 Thread Ian Jackson
Prashant writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): Ian, using your config we are able to recreate the problem that you are seeing. The driver finds the RX data buffer to be all zero, with a analyzer trace we are seeing the chip is DMA'ing valid RX data buffer

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-16 Thread Michael Chan
On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: Yes, this looks like the driver is not syncing the DMA buffers. Unmap is supposed to synchronize as well. For small rx packets ( 256 bytes), we sync the DMA buffer before we copy the data to another SKB. For larger

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-16 Thread cascardo
On Thu, Apr 16, 2015 at 11:18:39AM +0100, Ian Jackson wrote: Prashant writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): Ian, using your config we are able to recreate the problem that you are seeing. The driver finds the RX data buffer to be all zero, with a

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-16 Thread Ian Jackson
Michael Chan writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: Yes, this looks like the driver is not syncing the DMA buffers. Unmap is supposed to synchronize as well. For small rx packets (

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-16 Thread Prashant Sreedharan
On Thu, 2015-04-16 at 18:15 +0100, Ian Jackson wrote: Michael Chan writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: Yes, this looks like the driver is not syncing the DMA buffers. Unmap is

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-16 Thread David Miller
From: Michael Chan mc...@broadcom.com Date: Thu, 16 Apr 2015 09:39:13 -0700 On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: Yes, this looks like the driver is not syncing the DMA buffers. Unmap is supposed to synchronize as well. For small rx packets ( 256 bytes),

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-15 Thread Prashant
On 4/15/2015 3:54 AM, Ian Jackson wrote: Prashant writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): I tried to reproduce the problem on 32 bit 3.14.34 stable kernel baremetal, with iommu=soft swiotlb=force but no luck, no drops or errors. I did not try with Xen 64 bit

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-15 Thread Ian Jackson
Prashant writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): I tried to reproduce the problem on 32 bit 3.14.34 stable kernel baremetal, with iommu=soft swiotlb=force but no luck, no drops or errors. I did not try with Xen 64 bit yet. Btw I need a pcie analyzer trace

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-09 Thread Prashant Sreedharan
On Thu, 2015-04-09 at 12:11 +0100, Ian Jackson wrote: Prashant Sreedharan writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): On Wed, 2015-04-08 at 14:59 +0100, Ian Jackson wrote: Ian Jackson writes (Re: tg3 NIC driver bug in 3.14.x under Xen): The value for

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-09 Thread Ian Jackson
Ian Jackson writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): Prashant Sreedharan writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): yes please do I will do so. I did this test: - Linux 3.14.21 - baremetal - `iommu=soft swiotlb=force'

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-09 Thread Ian Jackson
Prashant Sreedharan writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): On Thu, 2015-04-09 at 12:11 +0100, Ian Jackson wrote: No. I can try to repro the problem without the bridge, if it would help. yes please do I will do so. FYI, when I came back to this test box

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-09 Thread Prashant Sreedharan
On Thu, 2015-04-09 at 18:25 +0100, Ian Jackson wrote: root@bedbug:~# ethtool -S eth0 | grep -v ': 0$' NIC statistics: rx_octets: 8196868 rx_ucast_packets: 633 rx_mcast_packets: 1 rx_bcast_packets: 123789 tx_octets: 42854 tx_ucast_packets: 9

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-09 Thread Ian Jackson
Prashant Sreedharan writes (Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]): On Wed, 2015-04-08 at 14:59 +0100, Ian Jackson wrote: Ian Jackson writes (Re: tg3 NIC driver bug in 3.14.x under Xen): The value for dropped increases steadily. This particular box is on a

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-09 Thread Prashant Sreedharan
On Wed, 2015-04-08 at 14:59 +0100, Ian Jackson wrote: Thanks to Konrad, Michael and Prashant for your attention. Prashant Sreedharan writes (Re: tg3 NIC driver bug in 3.14.x under Xen): Ian, in your previous mail you indicated there are no drops or errors reported on eth0 (assuming this

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-08 Thread Ian Jackson
Thanks to Konrad, Michael and Prashant for your attention. Prashant Sreedharan writes (Re: tg3 NIC driver bug in 3.14.x under Xen): Ian, in your previous mail you indicated there are no drops or errors reported on eth0 (assuming this is the tg3 port), which is added to the bridge xenbr0 is