Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen

2018-06-12 Thread Oleksandr Andrushchenko
On 06/13/2018 02:40 AM, Dmitry Torokhov wrote: On Tue, Jun 12, 2018 at 03:46:10PM +0200, Juergen Gross wrote: On 12/06/18 09:48, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.

Re: [Xen-devel] [PATCH v5 3/3] Input: xen-kbdfront - allow better run-time configuration

2018-06-12 Thread Oleksandr Andrushchenko
On 06/13/2018 01:07 AM, Dmitry Torokhov wrote: On Tue, Jun 12, 2018 at 10:48:56AM +0300, Oleksandr Andrushchenko wrote: + if (!(with_kbd | with_ptr | with_mtouch)) { I changed this to logical "OR" and applied, thank you. Yes, that's better, thank you + ret = -ENXIO; +

[Xen-devel] strange behavior with Multiboot2 on EFI

2018-06-12 Thread Kristaps Čivkulis
Hello, I am implementing Multiboot2 support for FreeBSD loader to load Xen kernel. Currently I pass EFI 64-bit system table pointer tag, EFI boot services not terminated tag, EFI 64-bit image handle pointer tag and Image load base physical address tag. The problem is, Xen kernel gets stuck into

Re: [Xen-devel] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions

2018-06-12 Thread Richard Henderson
On 06/10/2018 03:14 PM, Philippe Mathieu-Daudé wrote: > xen_pv_printf(xendev, 1, "type \"%s\", fileproto \"%s\", filename > \"%s\"," > - " size %" PRId64 " (%" PRId64 " MB)\n", > + " size %" PRId64 " (%llu MB)\n", >blkdev->type,

[Xen-devel] [xen-4.8-testing test] 124100: regressions - FAIL

2018-06-12 Thread osstest service owner
flight 124100 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/124100/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-xsm broken in 124070 build-i386-pvops

Re: [Xen-devel] [PATCH v3 9/9] xen/gntdev: Implement dma-buf import functionality

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:42 AM, Oleksandr Andrushchenko wrote: int gntdev_dmabuf_imp_release(struct gntdev_dmabuf_priv *priv, u32 fd) { - return -EINVAL; + struct gntdev_dmabuf *gntdev_dmabuf; + struct dma_buf_attachment *attach; + struct dma_buf *dma_buf; + +

Re: [Xen-devel] [PATCH v3 8/9] xen/gntdev: Implement dma-buf export functionality

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko 1. Create a dma-buf from grant references provided by the foreign domain. By default dma-buf is backed by system memory pages, but by providing GNTDEV_DMA_FLAG_XXX flags it can also be created as

Re: [Xen-devel] [PATCH v3 7/9] xen/gntdev: Add initial support for dma-buf UAPI

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index a09db23e9663..e82660d81d7e 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -48,6 +48,9 @@ #include #include "gntdev-common.h" +#ifdef

Re: [Xen-devel] [PATCH v3 6/9] xen/gntdev: Make private routines/structures accessible

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko This is in preparation for adding support of DMA buffer functionality: make map/unmap related code and structures, used privately by gntdev, ready for dma-buf extension, which will re-use these. Rename

Re: [Xen-devel] [PATCH v3 5/9] xen/gntdev: Allow mappings for DMA buffers

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: static void gntdev_print_maps(struct gntdev_priv *priv, @@ -121,8 +146,27 @@ static void gntdev_free_map(struct grant_map *map) if (map == NULL) return; +#ifdef CONFIG_XEN_GRANT_DMA_ALLOC + if

Re: [Xen-devel] [PATCH v3 4/9] xen/grant-table: Allow allocating buffers suitable for DMA

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Extend grant table module API to allow allocating buffers that can be used for DMA operations and mapping foreign grant references on top of those. The resulting buffer is similar to the one allocated by the

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: One more thing: please add a comment here saying that frames array is array of PFNs (in Xen granularity), which is what XENMEM_populate_physmap requires. And remove (or update to name the actual call you are making) the corresponding

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko diff --git a/include/xen/mem-reservation.h b/include/xen/mem-reservation.h new file mode 100644 index ..e0939387278d --- /dev/null +++ b/include/xen/mem-reservation.h @@ -0,0 +1,64 @@ +/*

Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen

2018-06-12 Thread Dmitry Torokhov
On Tue, Jun 12, 2018 at 03:46:10PM +0200, Juergen Gross wrote: > On 12/06/18 09:48, Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko > > > > This is the sync up with the canonical definitions of the input, > > sound and display protocols in Xen. > > > > Changes to kbdif: > > 1.

Re: [Xen-devel] TESTDAY report 4.11rc6

2018-06-12 Thread Tamas K Lengyel
> > ## Functionality tested > > - PV & HVM/ xl create, shu, des > - HVM/ altp2m with LibVMI and Drakvuf (on the modern hardware only) Happy to see Drakvuf getting some tests alongside Xen :) This test report thus covers vm_event and memaccess interfaces as well. Thanks! Tamas

[Xen-devel] [qemu-mainline test] 124093: tolerable FAIL - PUSHED

2018-06-12 Thread osstest service owner
flight 124093 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/124093/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 123987 test-armhf-armhf-libvirt 14

Re: [Xen-devel] [PATCH v5 0/10] arm: more kconfig configurability and small default configs

2018-06-12 Thread Julien Grall
Hi Stefano, On 12/06/2018 20:53, Stefano Stabellini wrote: On Tue, 12 Jun 2018, Jan Beulich wrote: As a consequence of these changes, some options will become user-visible and not dependent on CONFIG_EXPERT. It does not mean that Xen Project will security support all possible combinations of

Re: [Xen-devel] [PATCH v5 3/3] Input: xen-kbdfront - allow better run-time configuration

2018-06-12 Thread Dmitry Torokhov
On Tue, Jun 12, 2018 at 10:48:56AM +0300, Oleksandr Andrushchenko wrote: > > + if (!(with_kbd | with_ptr | with_mtouch)) { I changed this to logical "OR" and applied, thank you. > + ret = -ENXIO; > + goto error; > + } > + > ret =

Re: [Xen-devel] [PATCH v5 07/10] arm: add a tiny kconfig configuration

2018-06-12 Thread Julien Grall
On 12/06/2018 20:41, Stefano Stabellini wrote: On Tue, 12 Jun 2018, Julien Grall wrote: Hi, On 12/06/18 16:55, Stefano Stabellini wrote: On Tue, 12 Jun 2018, Julien Grall wrote: Hi Stefano, On 12/06/18 01:50, Stefano Stabellini wrote: On Tue, 5 Jun 2018, Julien Grall wrote: Hi Stefano,

Re: [Xen-devel] [PATCH v3 07/13] xen/arm: Simplify alternative patching of non-writable region

2018-06-12 Thread Julien Grall
Hi Konrad, On 12/06/2018 22:17, Konrad Rzeszutek Wilk wrote: On Tue, Jun 12, 2018 at 12:36:37PM +0100, Julien Grall wrote: During the MMU setup process, Xen will set SCTLR_EL2.WNX (Write-Non-eXecutable) bit. Because of that, the alternative code need to re-mapped the region in a difference

[Xen-devel] [linux-linus test] 124092: regressions - FAIL

2018-06-12 Thread osstest service owner
flight 124092 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/124092/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 123554

[Xen-devel] TESTDAY report 4.11rc6

2018-06-12 Thread pierre-philipp braun
Hello! Here is a success report for 4.11.0 rc6. Better late than never, right? ## Hardware - modern Lenovo V520-15IKL Desktop (i5-7400: 4 cores) - old monster IBM 3850 M2 (x4 Xeon X7350: 16 cores) I wish I had some Opterons available. ## Software (resp.) - Devuan/ascii and Linux

Re: [Xen-devel] [PATCH v3 07/13] xen/arm: Simplify alternative patching of non-writable region

2018-06-12 Thread Konrad Rzeszutek Wilk
On Tue, Jun 12, 2018 at 12:36:37PM +0100, Julien Grall wrote: > During the MMU setup process, Xen will set SCTLR_EL2.WNX > (Write-Non-eXecutable) bit. Because of that, the alternative code need > to re-mapped the region in a difference place in order to modify the > text section. > > At the

Re: [Xen-devel] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions

2018-06-12 Thread Eric Blake
On 06/12/2018 03:51 PM, Richard Henderson wrote: On 06/10/2018 03:14 PM, Philippe Mathieu-Daudé wrote: xen_pv_printf(xendev, 1, "type \"%s\", fileproto \"%s\", filename \"%s\"," - " size %" PRId64 " (%" PRId64 " MB)\n", + " size %" PRId64 " (%llu MB)\n",

[Xen-devel] [RFC PATCH 07/12] xen-netfront: add callbacks for PM suspend and hibernation support

2018-06-12 Thread Anchal Agarwal
From: Munehisa Kamata Add freeze and restore callbacks for PM suspend and hibernation support. The freeze handler simply disconnects the frotnend from the backend and frees resources associated with queues after disabling the net_device from the system. The restore handler just changes the

[Xen-devel] [RFC PATCH 10/12] xen/events: add xen_shutdown_pirqs helper function

2018-06-12 Thread Anchal Agarwal
From: Munehisa Kamata Add a simple helper function to "shutdown" active PIRQs, which actually closes event channels but keeps related IRQ structures intact. PM suspend/hibernation code will rely on this. Signed-off-by: Munehisa Kamata Signed-off-by: Anchal Agarwal Reviewed-by: Munehisa Kamata

[Xen-devel] [RFC PATCH 11/12] x86/xen: close event channels for PIRQs in system core suspend callback

2018-06-12 Thread Anchal Agarwal
From: Munehisa Kamata Close event channels allocated for devices which are backed by PIRQ and still active when suspending the system core. Normally, the devices are emulated legacy devices, e.g. PS/2 keyboard, floppy controller and etc. Without this, in PM hibernation, information about the

[Xen-devel] [RFC PATCH 02/12] xen/manage: introduce helper function to know the on-going suspend mode

2018-06-12 Thread Anchal Agarwal
From: Munehisa Kamata Introduce simple functions which help to know the on-going suspend mode so that other Xen-related code can behave differently according to the current suspend mode. Signed-off-by: Munehisa Kamata Signed-off-by: Anchal Agarwal Reviewed-by: Alakesh Haloi Reviewed-by:

[Xen-devel] [RFC PATCH 03/12] xenbus: add freeze/thaw/restore callbacks support

2018-06-12 Thread Anchal Agarwal
From: Munehisa Kamata Since commit b3e96c0c7562 ("xen: use freeze/restore/thaw PM events for suspend/resume/chkpt"), xenbus uses PMSG_FREEZE, PMSG_THAW and PMSG_RESTORE events for Xen suspend. However, they're actually assigned to xenbus_dev_suspend(), xenbus_dev_cancel() and xenbus_dev_resume()

[Xen-devel] [RFC PATCH 05/12] x86/xen: add system core suspend and resume callbacks

2018-06-12 Thread Anchal Agarwal
From: Munehisa Kamata Add Xen PVHVM specific system core callbacks for PM suspend and hibernation support. The callbacks suspend and resume Xen primitives, like shared_info, pvclock and grant table. Note that Xen suspend can handle them in a different manner, but system core callbacks are called

[Xen-devel] [RFC PATCH 01/12] xen/manage: keep track of the on-going suspend mode

2018-06-12 Thread Anchal Agarwal
From: Munehisa Kamata To differentiate between Xen suspend, PM suspend and PM hibernation, keep track of the on-going suspend mode by mainly using a new PM notifier. Since Xen suspend doesn't have corresponding PM event, its main logic is modfied to acquire pm_mutex and set the current mode.

[Xen-devel] [RFC PATCH 09/12] x86/xen: save and restore steal clock

2018-06-12 Thread Anchal Agarwal
From: Munehisa Kamata Save steal clock values of all present CPUs in the system core ops suspend callbacks. Also, restore a boot CPU's steal clock in the system core resume callback. For non-boot CPUs, restore after they're brought up, because runstate info for non-boot CPUs are not active until

[Xen-devel] [RFC PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2018-06-12 Thread Anchal Agarwal
From: Munehisa Kamata Add freeze and restore callbacks for PM suspend and hibernation support. The freeze handler stops a block-layer queue and disconnect the frontend from the backend while freeing ring_info and associated resources. The restore handler re-allocates ring_info and re-connect to

[Xen-devel] [RFC PATCH 08/12] xen-time-introduce-xen_-save-restore-_steal_clock

2018-06-12 Thread Anchal Agarwal
From: Munehisa Kamata Currently, steal time accounting code in scheduler expects steal clock callback to provide monotonically increasing value. If the accounting code receives a smaller value than previous one, it uses a negative value to calculate steal time and results in incorrectly updated

[Xen-devel] [RFC PATCH 04/12] x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume

2018-06-12 Thread Anchal Agarwal
Introduce a small function which re-uses shared page's PA allocated during guest initialization time in reserve_shared_info() and not allocate new page during resume flow. It also does the mapping of shared_info_page by calling xen_hvm_init_shared_info() to use the function. Signed-off-by:

[Xen-devel] [RFC PATCH 12/12] PM / hibernate: update the resume offset on SNAPSHOT_SET_SWAP_AREA

2018-06-12 Thread Anchal Agarwal
From: Aleksei Besogonov The SNAPSHOT_SET_SWAP_AREA is supposed to be used to set the hibernation offset on a running kernel to enable hibernating to a swap file. However, it doesn't actually update the swsusp_resume_block variable. As a result, the hibernation fails at the last step (after all

[Xen-devel] [RFC PATCH 00/12] Enable PM hibernation on guest VMs

2018-06-12 Thread Anchal Agarwal
Hello, I am sending out a series of patches that implements guest PM hibernation. These guests are running on xen hypervisor. The patches had been tested against mainstream kernel and latest xen version-4.11. EC2 instance hibernation feature is provided to the AWS EC2 customers. PM hibernation

Re: [Xen-devel] 4.11.0 RC1 panic

2018-06-12 Thread Manuel Bouyer
On Tue, Jun 12, 2018 at 05:38:45PM +0200, Manuel Bouyer wrote: > On Tue, Jun 12, 2018 at 01:39:05PM +0200, Manuel Bouyer wrote: > > I applied this patch to 4.11rc4 (let's not change too much things at the > > same time) and rebooted my test host. Hopefully I'll have some data to > > report > >

Re: [Xen-devel] [PATCH v5 0/10] arm: more kconfig configurability and small default configs

2018-06-12 Thread Stefano Stabellini
On Tue, 12 Jun 2018, Jan Beulich wrote: > >> >> As a consequence of these changes, some options will become user-visible > >> >> and not dependent on CONFIG_EXPERT. It does not mean that Xen Project > >> >> will security support all possible combinations of kconfig options. > >> >> Instead, there

Re: [Xen-devel] [PATCH v1] unmodified_drivers: unplug the emulated devices at resume time

2018-06-12 Thread Stefano Stabellini
On Tue, 12 Jun 2018, Jan Beulich wrote: > >>> On 12.06.18 at 16:10, wrote: > > Since qemu-2.10 it is required to unplug emulated devices again after > > a live migration. If this is not done, qemu's block-backend driver > > will be unable to open the backing disk image because it is still busy >

Re: [Xen-devel] [PATCH 4/7] xen/arm: Drop support for loading ELF Dom0 kernel

2018-06-12 Thread Stefano Stabellini
On Tue, 5 Jun 2018, Julien Grall wrote: > The code has been around since the beginning of Xen Arm. However, I am > not aware of any user and the code is pretty bogus: > 1) It is assuming virtual address == physical address. > 2) The cache is not cleaned after the Image is loaded but the

Re: [Xen-devel] [PATCH 7/7] xen/arm: setup: Move in init code only used at boot in setup.c

2018-06-12 Thread Stefano Stabellini
On Tue, 5 Jun 2018, Julien Grall wrote: > Some of the functions implemented in setup.c are only used at boot but > not yet marked as such. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/setup.c | 10 +- > 1 file changed, 5 insertions(+), 5

Re: [Xen-devel] [PATCH 5/7] xen: Don't build libelf for Arm

2018-06-12 Thread Stefano Stabellini
On Tue, 5 Jun 2018, Julien Grall wrote: > Now that ELF support has been dropped to boot Dom0, no-one is using > libelf within the hypervisor. > > Introduce a config option to select libelf on x86 and keep unselected > for Arm. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini

Re: [Xen-devel] [PATCH v5 07/10] arm: add a tiny kconfig configuration

2018-06-12 Thread Stefano Stabellini
On Tue, 12 Jun 2018, Julien Grall wrote: > Hi, > > On 12/06/18 16:55, Stefano Stabellini wrote: > > On Tue, 12 Jun 2018, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 12/06/18 01:50, Stefano Stabellini wrote: > > > > On Tue, 5 Jun 2018, Julien Grall wrote: > > > > > Hi Stefano, > > > > >

Re: [Xen-devel] [PATCH 6/7] xen/libfdt: Put all libfdt in init

2018-06-12 Thread Stefano Stabellini
On Tue, 5 Jun 2018, Julien Grall wrote: > Libfdt is used for: > - Unflatten the Flatten Device-Tree (FDT) blob > - Create Device-Tree for the Hardware-Domain > > Both use are done during the initialization of Xen. So move all the > libfdt to init. > > Note that the runes was borrowed

Re: [Xen-devel] [PATCH 3/7] xen/arm: kernel: Move in init all the code/data of kernel.c

2018-06-12 Thread Stefano Stabellini
On Tue, 5 Jun 2018, Julien Grall wrote: > The file kernel.c only contains code/data used during the > initialization. So move everything to init and mark the file as such. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/Makefile | 2 +- >

Re: [Xen-devel] [PATCH 2/7] xen/arm: domain_build: Move in init all code/data of domain_build.c

2018-06-12 Thread Stefano Stabellini
On Tue, 5 Jun 2018, Julien Grall wrote: > The file domain_build.c only contains code/data used during the > initialization. So move everything to init and mark the file as such. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/Makefile | 2 +- >

Re: [Xen-devel] [PATCH 1/7] xen/arm: Remove the variable dom0_11_mapping and open-code the value

2018-06-12 Thread Stefano Stabellini
On Tue, 5 Jun 2018, Julien Grall wrote: > Dom0 (aka hardware domain on Arm) is always direct mapped. Rather than > using a global variable to store a const, directly open-code it or > replace the use with is_domain_direct_mapped(...) macros. > > This will also help a follow-up patch to move all

Re: [Xen-devel] [PATCH v2 8/9] x86/vmx: Support removing MSRs from the host/guest load/save lists

2018-06-12 Thread Andrew Cooper
On 12/06/18 18:40, Andrew Cooper wrote: > On 12/06/18 09:27, Jan Beulich wrote: >>> +end = start + total; >>> +ent = locate_msr_entry(start + substart, start + subend, msr); >>> + >>> +if ( (ent == end) || (ent->index != msr) ) >>> +return -ESRCH; >>> + >>> +memmove(ent,

[Xen-devel] [OSSTEST PATCH 4/5] cs-bisection-step: Handle build job chains

2018-06-12 Thread Ian Jackson
cs-bisection-step assumes that every job it will need to create has a unique name. Indeed, in general, it is probably not reasonable to expect it to work if that is not the case. build-amd64-freebsd needs a previous build-amd64-freebsd. Currently cs-bisection-step confuses itself into writing a

[Xen-devel] [OSSTEST PATCH 1/5] db_retry: Honour new OSSTEST_DB_ALWAYS_ABORT variable

2018-06-12 Thread Ian Jackson
This is useful for debugging. Signed-off-by: Ian Jackson --- Osstest.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Osstest.pm b/Osstest.pm index 2263786..3377ea3 100644 --- a/Osstest.pm +++ b/Osstest.pm @@ -330,6 +330,8 @@ sub db_retry ($$$;$$) { last if

[Xen-devel] [OSSTEST PATCH 3/5] cs-bisection-step: Refactor $subjobs calculations a bit

2018-06-12 Thread Ian Jackson
Parse the runvar name earlier, adding job and orgflight members to the row hashes we got from the db. This slightly unifies the call to preparejob, but more relevantly, makes the effective job and flight information available earlier. That will be useful in a moment. No functional change.

[Xen-devel] [OSSTEST PATCH 5/5] cs-bisection-step: Do explicitly set runvar for suppressed recursion

2018-06-12 Thread Ian Jackson
When we detect that we are considering a job which is identically named to one earlier in the dependency chain, it could happen that the final referencing runvar in the job at which we break the cycle is actually to an unqualified job name. (This cannot happen unless the cycle has more than 2

[Xen-devel] [OSSTEST PATCH 0/5] Handle jobs that depend on identically-named jobs

2018-06-12 Thread Ian Jackson
From: Ian Jackson Ian Jackson (5): db_retry: Honour new OSSTEST_DB_ALWAYS_ABORT variable cs-bisection-step: Improve a message cs-bisection-step: Refactor $subjobs calculations a bit cs-bisection-step: Handle build job chains cs-bisection-step: Do explicitly set runvar for suppressed

Re: [Xen-devel] [PATCH v2 5/9] x86/vmx: Improvements to LBR MSR handling

2018-06-12 Thread Andrew Cooper
On 12/06/18 10:00, Jan Beulich wrote: On 12.06.18 at 10:51, wrote: >> On 12/06/2018 09:15, Jan Beulich wrote: >> On 08.06.18 at 20:48, wrote: @@ -3106,14 +3104,13 @@ static int vmx_msr_write_intercept(unsigned int msr, >> uint64_t msr_content) for ( ; (rc

Re: [Xen-devel] 4.11.0 RC1 panic

2018-06-12 Thread Andrew Cooper
On 12/06/18 17:00, Manuel Bouyer wrote: > On Tue, Jun 12, 2018 at 04:54:30PM +0100, Andrew Cooper wrote: >> On 12/06/18 16:38, Manuel Bouyer wrote: >>> On Tue, Jun 12, 2018 at 01:39:05PM +0200, Manuel Bouyer wrote: I applied this patch to 4.11rc4 (let's not change too much things at the

Re: [Xen-devel] [PATCH v3 05/13] xen/arm: Add command line option to control SSBD mitigation

2018-06-12 Thread Stefano Stabellini
On Tue, 12 Jun 2018, Julien Grall wrote: > On a system where the firmware implements ARCH_WORKAROUND_2, it may be > useful to either permanently enable or disable the workaround for cases > where the user decides that they'd rather not get a trap overhead, and > keep the mitigation permanently on

Re: [Xen-devel] [PATCH v3 04/13] xen/arm: Add ARCH_WORKAROUND_2 probing

2018-06-12 Thread Stefano Stabellini
On Tue, 12 Jun 2018, Julien Grall wrote: > As for Spectre variant-2, we rely on SMCCC 1.1 to provide the discovery > mechanism for detecting the SSBD mitigation. > > A new capability is also allocated for that purpose, and a config > option. > > This is part of XSA-263. > > Signed-off-by:

Re: [Xen-devel] [PATCH v5 07/10] arm: add a tiny kconfig configuration

2018-06-12 Thread Julien Grall
Hi, On 12/06/18 16:55, Stefano Stabellini wrote: On Tue, 12 Jun 2018, Julien Grall wrote: Hi Stefano, On 12/06/18 01:50, Stefano Stabellini wrote: On Tue, 5 Jun 2018, Julien Grall wrote: Hi Stefano, On 04/06/18 18:24, Stefano Stabellini wrote: Add a tiny kconfig configuration. Enabled

Re: [Xen-devel] 4.11.0 RC1 panic

2018-06-12 Thread Manuel Bouyer
On Tue, Jun 12, 2018 at 04:54:30PM +0100, Andrew Cooper wrote: > On 12/06/18 16:38, Manuel Bouyer wrote: > > On Tue, Jun 12, 2018 at 01:39:05PM +0200, Manuel Bouyer wrote: > >> I applied this patch to 4.11rc4 (let's not change too much things at the > >> same time) and rebooted my test host.

[Xen-devel] [xen-unstable test] 123379: regressions - FAIL

2018-06-12 Thread Juergen Gross
On 08/06/18 12:12, Juergen Gross wrote: > On 07/06/18 13:30, Juergen Gross wrote: >> On 06/06/18 11:40, Juergen Gross wrote: >>> On 06/06/18 11:35, Jan Beulich wrote: >>> On 05.06.18 at 18:19, wrote: >>> test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 14 >>> guest-saverestore.2

Re: [Xen-devel] [PATCH v5 07/10] arm: add a tiny kconfig configuration

2018-06-12 Thread Stefano Stabellini
On Tue, 12 Jun 2018, Julien Grall wrote: > Hi Stefano, > > On 12/06/18 01:50, Stefano Stabellini wrote: > > On Tue, 5 Jun 2018, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 04/06/18 18:24, Stefano Stabellini wrote: > > > > Add a tiny kconfig configuration. Enabled NULL and Credit

Re: [Xen-devel] 4.11.0 RC1 panic

2018-06-12 Thread Andrew Cooper
On 12/06/18 16:38, Manuel Bouyer wrote: > On Tue, Jun 12, 2018 at 01:39:05PM +0200, Manuel Bouyer wrote: >> I applied this patch to 4.11rc4 (let's not change too much things at the >> same time) and rebooted my test host. Hopefully I'll have some data to report >> soon > Got the first panic (still

[Xen-devel] [PATCH 1/1] libxl/xl: rename id to unique-id in vdispl xen store

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov In the display protocol connector's id is named as unique-id. This patch renames it in the libxl/xl code and uses XENDISPL_FIELD... definitions from the protocol header. Signed-off-by: Oleksandr Grytsov --- docs/man/xl.cfg.pod.5.in| 2 +-

Re: [Xen-devel] [PATCH] xen/altp2m: set access_required properly for all altp2ms

2018-06-12 Thread Razvan Cojocaru
On 06/12/2018 03:35 PM, Razvan Cojocaru wrote: >>> @@ -210,7 +211,7 @@ static int p2m_init_altp2m(struct domain *d) >>> return -ENOMEM; >>> } >>> p2m->p2m_class = p2m_alternate; >>> -p2m->access_required = 1; >>> +p2m->access_required =

Re: [Xen-devel] [PATCH v1] unmodified_drivers: unplug the emulated devices at resume time

2018-06-12 Thread Olaf Hering
Am Tue, 12 Jun 2018 09:01:07 -0600 schrieb "Jan Beulich" : > So there's no plan to fix this on the qemu side? Even if there would be one, existing dom0s may not get an update in time. I sent some prototype of a potential fix for qemu, it needs more work. Olaf pgpzDYSfvvGmr.pgp Description:

Re: [Xen-devel] [PATCH v1] unmodified_drivers: unplug the emulated devices at resume time

2018-06-12 Thread Jan Beulich
>>> On 12.06.18 at 16:10, wrote: > Since qemu-2.10 it is required to unplug emulated devices again after > a live migration. If this is not done, qemu's block-backend driver > will be unable to open the backing disk image because it is still busy > by qemu's IDE driver. As a result the domUs

Re: [Xen-devel] [libvirt] Likely build race, "/usr/bin/ld: cannot find -lvirt"

2018-06-12 Thread Daniel P . Berrangé
On Tue, Jun 12, 2018 at 04:16:53PM +0200, Jiri Denemark wrote: > On Tue, Jun 12, 2018 at 07:57:40 -0500, Eric Blake wrote: > > On 06/12/2018 06:11 AM, Jiri Denemark wrote: > > > > > I hit the same race twice on aarch64 and ppc64 and I can confirm the > > > installation phase fails if libvirt.la

[Xen-devel] [xen-unstable-smoke test] 124108: tolerable all pass - PUSHED

2018-06-12 Thread osstest service owner
flight 124108 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/124108/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [libvirt] Likely build race, "/usr/bin/ld: cannot find -lvirt"

2018-06-12 Thread Jiri Denemark
On Tue, Jun 12, 2018 at 07:57:40 -0500, Eric Blake wrote: > On 06/12/2018 06:11 AM, Jiri Denemark wrote: > > > I hit the same race twice on aarch64 and ppc64 and I can confirm the > > installation phase fails if libvirt.la is installed later than libraries > > which link to it. However, the

[Xen-devel] [PATCH v1] unmodified_drivers: unplug the emulated devices at resume time

2018-06-12 Thread Olaf Hering
Since qemu-2.10 it is required to unplug emulated devices again after a live migration. If this is not done, qemu's block-backend driver will be unable to open the backing disk image because it is still busy by qemu's IDE driver. As a result the domUs block-frontend driver will be unable to access

Re: [Xen-devel] [PATCH v5 3/3] Input: xen-kbdfront - allow better run-time configuration

2018-06-12 Thread Juergen Gross
On 12/06/18 09:48, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > It is now only possible to control if multi-touch virtual device > is created or not (via the corresponding XenStore entries), > but keyboard and pointer devices are always created. > In some cases this is not

Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen

2018-06-12 Thread Oleksandr Andrushchenko
On 06/12/2018 04:46 PM, Juergen Gross wrote: On 12/06/18 09:48, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko This is the sync up with the canonical definitions of the input, sound and display protocols in Xen. Changes to kbdif: 1. Add missing string constants for

[Xen-devel] [PATCH v2 2/2] VT-d: reconcile iommu_inclusive_mapping and iommu=dom0-strict

2018-06-12 Thread Paul Durrant
The documentation for the iommu_inclusive_mapping Xen command line option states: "Use this to work around firmware issues providing incorrect RMRR entries" Unfortunately this workaround does not function correctly if the dom0-strict iommu option is also specified. The documentation goes on to

[Xen-devel] [PATCH v2 1/2] VT-d: re-phrase logic in vtd_set_hwdom_mapping() for clarity

2018-06-12 Thread Paul Durrant
It is hard to reconcile the comment at the top of the loop in vtd_set_hwdom_mapping() with the if statement following it. This patch re-phrases the logic, preserving the semantics, but making it easier to read. The patch also modifies the Xen command line documentation to make it clear that

Re: [Xen-devel] [PATCH v5 2/3] Input: xen-kbdfront - fix multi-touch XenStore node's locations

2018-06-12 Thread Juergen Gross
On 12/06/18 09:48, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > kbdif protocol describes multi-touch device parameters as a > part of frontend's XenBus configuration nodes while they > belong to backend's configuration. Fix this by reading the > parameters as defined by the

Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen

2018-06-12 Thread Juergen Gross
On 12/06/18 09:48, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the sync up with the canonical definitions of the input, > sound and display protocols in Xen. > > Changes to kbdif: > 1. Add missing string constants for {feature|request}-raw-pointer >to align

[Xen-devel] [PATCH v3 2/9] xen/grant-table: Make set/clear page private code shared

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Make set/clear page private code shared and accessible to other kernel modules which can re-use these instead of open-coding. Signed-off-by: Oleksandr Andrushchenko Reviewed-by: Boris Ostrovsky --- drivers/xen/grant-table.c | 54

[Xen-devel] [PATCH v3 1/9] xen/grant-table: Export gnttab_{alloc|free}_pages as GPL

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Only gnttab_{alloc|free}_pages are exported as EXPORT_SYMBOL while all the rest are exported as EXPORT_SYMBOL_GPL, thus effectively making it not possible for non-GPL driver modules to use grant table module. Export gnttab_{alloc|free}_pages as EXPORT_SYMBOL_GPL so

[Xen-devel] [PATCH v3 8/9] xen/gntdev: Implement dma-buf export functionality

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko 1. Create a dma-buf from grant references provided by the foreign domain. By default dma-buf is backed by system memory pages, but by providing GNTDEV_DMA_FLAG_XXX flags it can also be created as a DMA write-combine/coherent buffer, e.g. allocated with

[Xen-devel] [PATCH v3 0/9] xen: dma-buf support for grant device

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This work is in response to my previous attempt to introduce Xen/DRM zero-copy driver [1] to enable Linux dma-buf API [2] for Xen based frontends/backends. There is also an existing hyper_dmabuf approach available [3] which, if reworked to utilize the proposed

[Xen-devel] [PATCH v3 6/9] xen/gntdev: Make private routines/structures accessible

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This is in preparation for adding support of DMA buffer functionality: make map/unmap related code and structures, used privately by gntdev, ready for dma-buf extension, which will re-use these. Rename corresponding structures as those become non-private to gntdev

[Xen-devel] [PATCH v3 5/9] xen/gntdev: Allow mappings for DMA buffers

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Allow mappings for DMA backed buffers if grant table module supports such: this extends grant device to not only map buffers made of balloon pages, but also from buffers allocated with dma_alloc_xxx. Signed-off-by: Oleksandr Andrushchenko ---

[Xen-devel] [PATCH v3 9/9] xen/gntdev: Implement dma-buf import functionality

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko 1. Import a dma-buf with the file descriptor provided and export granted references to the pages of that dma-buf into the array of grant references. 2. Add API to close all references to an imported buffer, so it can be released by the owner. This is only

[Xen-devel] [PATCH v3 4/9] xen/grant-table: Allow allocating buffers suitable for DMA

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Extend grant table module API to allow allocating buffers that can be used for DMA operations and mapping foreign grant references on top of those. The resulting buffer is similar to the one allocated by the balloon driver in terms that proper memory reservation is

[Xen-devel] [PATCH v3 7/9] xen/gntdev: Add initial support for dma-buf UAPI

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Add UAPI and IOCTLs for dma-buf grant device driver extension: the extension allows userspace processes and kernel modules to use Xen backed dma-buf implementation. With this extension grant references to the pages of an imported dma-buf can be exported for other

[Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Memory {increase|decrease}_reservation and VA mappings update/reset code used in balloon driver can be made common, so other drivers can also re-use the same functionality without open-coding. Create a dedicated file for the shared code and export corresponding

[Xen-devel] [PATCH v2 6/6] libxl: vkb add extended parameters

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add parsing and adding to xen store following extended parameters: * feature-disable-keyboard * feature-disable-pointer * feature-abs-pointer * feature-multi-touch * feature-raw-pointer * width * height * multi-touch-width * multi-touch-height * multi-touch-num-contacts

[Xen-devel] [PATCH v2 3/6] libxl: vkb add list and info functions

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl.h | 10 +++ tools/libxl/libxl_types.idl | 11 tools/libxl/libxl_utils.h | 3 + tools/libxl/libxl_vkb.c | 127 +++- 4 files changed, 149

[Xen-devel] [PATCH v2 0/6] libxl: create standalone vkb device

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Changes since initial: * id field is changed to unique_id in libxl_device_vkb to be comply with protocol; * use XENKBD_FIELD_... defines from protocol to address xen store entries and fields in domain config file; * add support of new protocol parameters: -

[Xen-devel] [PATCH v2 4/6] xl: add vkb config parser and CLI

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 16 + tools/xl/xl_parse.c| 76 - tools/xl/xl_parse.h| 2 +- tools/xl/xl_vkb.c | 147

[Xen-devel] [PATCH v2 1/6] libxl: move vkb device to libxl_vkb.c

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Logically it is better to move vkb to separate file as vkb device used not only by vfb and console. Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/Makefile| 2 +- tools/libxl/libxl_console.c | 53 -

[Xen-devel] [PATCH v2 5/6] docs: add vkb device to xl.cfg and xl

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- docs/man/xl.cfg.pod.5.in | 24 docs/man/xl.pod.1.in | 22 ++ 2 files changed, 46 insertions(+) diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in

[Xen-devel] [PATCH v2 2/6] libxl: add backend type and id to vkb

2018-06-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov New field backend_type is added to vkb device in order to have QEMU and user space backend simultaneously. Each vkb backend shall read appropriate XS entry and service only own frontends. Id is a string field which used by the backend to indentify the frontend.

[Xen-devel] [ovmf test] 124091: regressions - FAIL

2018-06-12 Thread osstest service owner
flight 124091 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/124091/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 124058 version targeted for

[Xen-devel] [linux-4.9 test] 124084: regressions - FAIL

2018-06-12 Thread osstest service owner
flight 124084 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/124084/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 7 xen-bootfail REGR. vs. 122969

Re: [Xen-devel] [libvirt] Likely build race, "/usr/bin/ld: cannot find -lvirt"

2018-06-12 Thread Eric Blake
On 06/12/2018 06:11 AM, Jiri Denemark wrote: I hit the same race twice on aarch64 and ppc64 and I can confirm the installation phase fails if libvirt.la is installed later than libraries which link to it. However, the dependencies seem to be set correctly in the Makefiles. But it looks like

Re: [Xen-devel] [PATCH] xen/altp2m: set access_required properly for all altp2ms

2018-06-12 Thread Jan Beulich
>>> On 12.06.18 at 14:35, wrote: > On 06/12/2018 03:23 PM, Jan Beulich wrote: > On 11.06.18 at 17:12, wrote: >>> --- a/xen/common/domctl.c >>> +++ b/xen/common/domctl.c >>> @@ -1094,6 +1094,8 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) >>> u_domctl) >>>

Re: [Xen-devel] [PATCH 1/2] VT-d: re-phrase logic in vtd_set_hwdom_mapping() for clarity

2018-06-12 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 11 June 2018 11:35 > To: Roger Pau Monne > Cc: Kevin Tian ; Stefano Stabellini > ; Wei Liu ; Andrew Cooper > ; Tim (Xen.org) ; George > Dunlap ; Julien Grall ; > Jan

Re: [Xen-devel] [PATCH] xen/altp2m: set access_required properly for all altp2ms

2018-06-12 Thread Razvan Cojocaru
Thanks for the review! On 06/12/2018 03:23 PM, Jan Beulich wrote: On 11.06.18 at 17:12, wrote: >> --- a/xen/arch/x86/domain.c >> +++ b/xen/arch/x86/domain.c >> @@ -38,6 +38,7 @@ >> #include >> #include >> #include >> +#include > > Not the least to avoid this I think ... > >> @@

  1   2   >