[Xen-devel] [qemu-mainline test] 131788: tolerable FAIL - PUSHED

2019-01-08 Thread osstest service owner
flight 131788 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/131788/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 131743 test-armhf-armhf-libvirt 14 sav

[Xen-devel] [linux-3.18 test] 131780: regressions - trouble: broken/fail/pass

2019-01-08 Thread osstest service owner
flight 131780 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/131780/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-win7-amd64 broken test-amd64-i386-qemut-rhel6hvm-intel

Re: [Xen-devel] [PATCH v2 4/4] x86/shim: only mark special pages as RAM in pvshim mode

2019-01-08 Thread Jan Beulich
>>> On 28.12.18 at 13:04, wrote: > @@ -113,6 +115,47 @@ uint64_t pv_shim_mem(uint64_t avail) > return shim_nrpages; > } > > +static void __init mark_pfn_as_ram(struct e820map *e820, uint64_t pfn) > +{ > +if ( !e820_add_range(e820, pfn << PAGE_SHIFT, > + (pfn <<

Re: [Xen-devel] [PATCH for-4.12] xen/iommu: fix dev assignment on ARM after 91d4eca7

2019-01-08 Thread Jan Beulich
>>> On 08.01.19 at 09:30, wrote: >> -Original Message- > [snip] >> > >> > The use of iommu_use_hap_pt() here is indeed a problem, but I think it >> would be sufficient to move the line "hd->status = >> IOMMU_STATUS_initializing" to just before the if rather than to a >> completely separat

Re: [Xen-devel] [PATCH] xen/build-id: Fix xen_build_id_check() to be robust against malformed notes

2019-01-08 Thread Jan Beulich
>>> On 07.01.19 at 18:34, wrote: > On 07/01/2019 10:36, Jan Beulich wrote: > On 31.12.18 at 18:34, wrote: >>> A NT_GNU_BUILD_ID with namesz longer than 4 will cause the strncmp() to use >>> bytes in adjacent stringtable entries. >>> >>> Instead, check for namesz exactly equal to 4, >> Is that

Re: [Xen-devel] [PATCH v2] xen/cmdline: Fix buggy strncmp(s, LITERAL, ss - s) construct

2019-01-08 Thread Jan Beulich
>>> On 07.01.19 at 18:28, wrote: > On 07/01/2019 08:59, Jan Beulich wrote: >>> @@ -271,6 +297,27 @@ int parse_boolean(const char *name, const char *s, > const char *e) >>> return -1; >>> } >>> >>> +int cmdline_strcmp(const char *frag, const char *name) >> So you've decided to retain the s

Re: [Xen-devel] [PATCH for-4.12] xen/iommu: fix dev assignment on ARM after 91d4eca7

2019-01-08 Thread Paul Durrant
> -Original Message- [snip] > > > > The use of iommu_use_hap_pt() here is indeed a problem, but I think it > would be sufficient to move the line "hd->status = > IOMMU_STATUS_initializing" to just before the if rather than to a > completely separate function. > > Yes, that works too. > >

Re: [Xen-devel] [PATCH v5 2/2] xen/blkback: rework connect_ring() to avoid inconsistent xenstore 'ring-page-order' set by malicious blkfront

2019-01-08 Thread Dongli Zhang
oops. Please ignore this v5 patch. I just realized Linus suggested in an old email not use BUG()/BUG_ON() in the code. I will switch to the WARN() solution and resend again. Sorry for the junk email. Dongli Zhang On 2019/1/8 下午4:15, Dongli Zhang wrote: > The xenstore 'ring-page-order' is used

[Xen-devel] [PATCH v5 2/2] xen/blkback: rework connect_ring() to avoid inconsistent xenstore 'ring-page-order' set by malicious blkfront

2019-01-08 Thread Dongli Zhang
The xenstore 'ring-page-order' is used globally for each blkback queue and therefore should be read from xenstore only once. However, it is obtained in read_per_ring_refs() which might be called multiple times during the initialization of each blkback queue. If the blkfront is malicious and the 'r

[Xen-devel] [PATCH v5 1/2] xen/blkback: add stack variable 'blkif' in connect_ring()

2019-01-08 Thread Dongli Zhang
As 'be->blkif' is used for many times in connect_ring(), the stack variable 'blkif' is added to substitute 'be-blkif'. Suggested-by: Paul Durrant Signed-off-by: Dongli Zhang Reviewed-by: Paul Durrant Reviewed-by: Roger Pau Monné --- drivers/block/xen-blkback/xenbus.c | 27 ++--

Re: [Xen-devel] [PATCH v5 4/4] xen/common: use SYMBOL when required

2019-01-08 Thread Jan Beulich
>>> On 07.01.19 at 20:16, wrote: > On Mon, 7 Jan 2019, Jan Beulich wrote: >> >>> On 03.01.19 at 20:19, wrote: >> > --- a/xen/common/virtual_region.c >> > +++ b/xen/common/virtual_region.c >> > @@ -119,7 +119,11 @@ void __init setup_virtual_regions(const struct >> > exception_table_entry *start,

Re: [Xen-devel] [PATCH v5 3/4] xen/x86: use SYMBOL when required

2019-01-08 Thread Jan Beulich
>>> On 07.01.19 at 20:33, wrote: > On Mon, 7 Jan 2019, Jan Beulich wrote: >> >>> On 03.01.19 at 20:19, wrote: >> > --- a/xen/arch/x86/alternative.c >> > +++ b/xen/arch/x86/alternative.c >> > @@ -194,7 +194,7 @@ void init_or_livepatch apply_alternatives(struct >> > alt_instr *start, >> > *

[Xen-devel] [ovmf test] 131789: regressions - FAIL

2019-01-08 Thread osstest service owner
flight 131789 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/131789/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i3866 xen-buildfail REGR. vs. 129475 build-i386-xsm

Re: [Xen-devel] [PATCH v4 2/2] xen: use SYMBOL when required

2019-01-08 Thread Jan Beulich
>>> On 07.01.19 at 19:29, wrote: > On Mon, 7 Jan 2019, Jan Beulich wrote: >> >>> On 04.01.19 at 18:05, wrote: >> > I realize that you are not convinced by these arguments, but let's find >> > a way forward. My preference would be to have SYMBOL returning unsigned >> > long and do unsigned long co

<    1   2