[Xen-devel] [linux-linus test] 142398: regressions - FAIL

2019-10-07 Thread osstest service owner
flight 142398 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/142398/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 133580

Re: [Xen-devel] Latest development (master) Xen fails to boot on HP ProLiant DL20 GEN10

2019-10-07 Thread Roman Shaposhnik
Sorry -- was traveling last week, but I'm still very curious to get to the bottom of this: On Tue, Oct 1, 2019 at 1:25 AM Jan Beulich wrote: > > On 01.10.2019 00:38, Roman Shaposhnik wrote: > > Btw, forgot to attach the patch with maxcpus=2 -- interestingly enough > > Xen seems to hang much

[Xen-devel] [linux-4.4 test] 142401: regressions - FAIL

2019-10-07 Thread osstest service owner
flight 142401 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/142401/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 18 guest-localmigrate/x10 fail REGR. vs. 139698 Tests which are

Re: [Xen-devel] [PATCH for-4.13 v2 0/3] fixes for make_[memory/cpu]_node

2019-10-07 Thread Jürgen Groß
On 08.10.19 03:14, Stefano Stabellini wrote: Hi all, This is a small collection of fixes for make_memory_node and make_cpus_node for 4.13. Cheers, Stefano Stefano Stabellini (3): xen/arm: fix buf size in make_cpus_node xen/arm: make_memory_node return error on nr_banks == 0

Re: [Xen-devel] [PATCH 01/24] golang/xenlight: fix calls to libxl_domain_unpause/pause

2019-10-07 Thread Jürgen Groß
On 07.10.19 18:39, George Dunlap wrote: On 10/7/19 4:12 PM, Nick Rosbrook wrote: From: Nick Rosbrook These functions require a third argument of type const *libxl_asyncop_how. Pass nil to fix compilation errors. This will have the effect of performing these operations synchronously.

[Xen-devel] [linux-next test] 142391: tolerable FAIL

2019-10-07 Thread osstest service owner
flight 142391 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/142391/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-examine 8 reboot fail like 142258 test-amd64-i386-libvirt-pair 10

[Xen-devel] [PATCH v2 1/3] xen/arm: fix buf size in make_cpus_node

2019-10-07 Thread Stefano Stabellini
The size of buf is calculated wrongly: the number is 64bit, not 32bit. Also the number is printed as a hexadecimal number, so we need 8 bytes for 32bit, not 10 bytes. As a result, it should be sizeof("cpu@") + 16 bytes for a 64-bit number + 1 byte for \0. Total = 21. Fixes: fafd682c3e (xen/arm:

[Xen-devel] [PATCH v2 3/3] xen/arm: fix duplicate memory node in DT

2019-10-07 Thread Stefano Stabellini
When reserved-memory regions are present in the host device tree, dom0 is started with multiple memory nodes. Each memory node should have a unique name, but today they are all called "memory" leading to Linux printing the following warning at boot: OF: Duplicate name in base, renamed to

[Xen-devel] [PATCH v2 2/3] xen/arm: make_memory_node return error on nr_banks == 0

2019-10-07 Thread Stefano Stabellini
Call make_memory_node for reserved_memory only if we actually have any reserved_memory regions to handle. Add a check in make_memory_node to return an error if it has been called with no memory banks as argument. Fixes: 248faa637d2 (xen/arm: add reserved-memory regions to the dom0 memory node)

[Xen-devel] [PATCH for-4.13 v2 0/3] fixes for make_[memory/cpu]_node

2019-10-07 Thread Stefano Stabellini
Hi all, This is a small collection of fixes for make_memory_node and make_cpus_node for 4.13. Cheers, Stefano Stefano Stabellini (3): xen/arm: fix buf size in make_cpus_node xen/arm: make_memory_node return error on nr_banks == 0 xen/arm: fix duplicate memory node in DT

[Xen-devel] On unions usage, specifically arch.{hvm,pv}

2019-10-07 Thread Marek Marczykowski-Górecki
Hi all, To be honest, I think unions are very scary from security point of view. It's quite easy to use a field that in given context have very different meaning and easily results in security issue. In the most cases, compiler can't help you here. And seeing "IOMMU: add missing HVM check" patch

Re: [Xen-devel] [[PATCH for-4.13]] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-07 Thread Stefano Stabellini
On Mon, 7 Oct 2019, Julien Grall wrote: > Hi, > > On 03/10/2019 02:02, Stefano Stabellini wrote: > > On Fri, 20 Sep 2019, Julien Grall wrote: > >> That's not correct. alloc_boot_pages() is actually here to allow dynamic > >> allocation before the memory subsystem (and therefore the runtime > >>

Re: [Xen-devel] [PATCH for-4.13] xen/arm: fix duplicate memory node in DT

2019-10-07 Thread Stefano Stabellini
On Mon, 7 Oct 2019, Julien Grall wrote: > Hi, > > On 07/10/2019 22:30, Stefano Stabellini wrote: > > On Mon, 7 Oct 2019, Julien Grall wrote: > >> On 05/10/2019 00:09, Stefano Stabellini wrote: > >>> When reserved-memory regions are present in the host device tree, dom0 > >>> is started with

Re: [Xen-devel] [PATCH for-4.13] xen/arm: fix duplicate memory node in DT

2019-10-07 Thread Julien Grall
Hi, On 07/10/2019 22:30, Stefano Stabellini wrote: > On Mon, 7 Oct 2019, Julien Grall wrote: >> On 05/10/2019 00:09, Stefano Stabellini wrote: >>> When reserved-memory regions are present in the host device tree, dom0 >>> is started with multiple memory nodes. Each memory node should have a >>>

Re: [Xen-devel] [PATCH for-4.13] xen/arm: fix duplicate memory node in DT

2019-10-07 Thread Stefano Stabellini
On Mon, 7 Oct 2019, Jürgen Groß wrote: > On 05.10.19 01:09, Stefano Stabellini wrote: > > When reserved-memory regions are present in the host device tree, dom0 > > is started with multiple memory nodes. Each memory node should have a > > unique name, but today they are all called "memory" leading

Re: [Xen-devel] [PATCH for-4.13] xen/arm: fix duplicate memory node in DT

2019-10-07 Thread Stefano Stabellini
On Mon, 7 Oct 2019, Julien Grall wrote: > On 05/10/2019 00:09, Stefano Stabellini wrote: > > When reserved-memory regions are present in the host device tree, dom0 > > is started with multiple memory nodes. Each memory node should have a > > unique name, but today they are all called "memory"

Re: [Xen-devel] [PATCH 2/2] xen/arm: domain_build: Don't expose IOMMU specific properties to the guest

2019-10-07 Thread Julien Grall
Hi, On 03/10/2019 13:18, Oleksandr wrote: > > On 01.10.19 22:07, Julien Grall wrote: >> On 10/1/19 5:07 PM, Oleksandr wrote: >>> >>> On 01.10.19 18:36, Julien Grall wrote: On 01/10/2019 16:25, Oleksandr wrote: > > On 01.10.19 18:04, Julien Grall wrote: >>> > 1. Giving the IOMMU to

[Xen-devel] [xen-unstable test] 142383: regressions - FAIL

2019-10-07 Thread osstest service owner
flight 142383 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/142383/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair 22 guest-migrate/src_host/dst_host fail REGR. vs. 141822

Re: [Xen-devel] [[PATCH for-4.13]] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-07 Thread Julien Grall
Hi, On 03/10/2019 02:02, Stefano Stabellini wrote: > On Fri, 20 Sep 2019, Julien Grall wrote: >> That's not correct. alloc_boot_pages() is actually here to allow dynamic >> allocation before the memory subsystem (and therefore the runtime allocator) >> is initialized. > > Let me change the

[Xen-devel] [qemu-mainline test] 142388: regressions - FAIL

2019-10-07 Thread osstest service owner
flight 142388 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/142388/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 140282

[Xen-devel] [xen-unstable-smoke test] 142403: tolerable all pass - PUSHED

2019-10-07 Thread osstest service owner
flight 142403 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/142403/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [freebsd-master test] 142392: regressions - trouble: blocked/fail

2019-10-07 Thread osstest service owner
flight 142392 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/142392/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-freebsd 7 freebsd-buildfail REGR. vs. 141501 Tests which did

[Xen-devel] [libvirt test] 142384: regressions - FAIL

2019-10-07 Thread osstest service owner
flight 142384 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/142384/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-qcow2 16 guest-start.2 fail in 142345 REGR. vs. 142252 Tests which are

Re: [Xen-devel] [PATCH 01/24] golang/xenlight: fix calls to libxl_domain_unpause/pause

2019-10-07 Thread George Dunlap
On 10/7/19 4:12 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > These functions require a third argument of type const *libxl_asyncop_how. > > Pass nil to fix compilation errors. This will have the effect of > performing these operations synchronously. > > Signed-off-by: Nick Rosbrook

Re: [Xen-devel] [PATCH v2 5/6] Add guide on Communication Best Practice

2019-10-07 Thread George Dunlap
On 9/27/19 10:14 AM, Jan Beulich wrote: > On 26.09.2019 21:39, Lars Kurth wrote: >> +### Verbose vs. terse >> +Due to the time it takes to review and compose code reviewer, reviewers >> often adopt a >> +terse style. It is not unusual to see review comments such as >> +> typo >> +>

Re: [Xen-devel] [PATCH v2 5/6] Add guide on Communication Best Practice

2019-10-07 Thread George Dunlap
On 9/26/19 8:39 PM, Lars Kurth wrote: > +investigate the practice foot-binding, it is hard to disagree with the > dictionart entry. Typo: dictionary -George ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] [PATCH 16/24] golang/xenlight: begin C to Go type marshaling

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Implement basic type conversion in fromC functions such as strings and integer types. Also, remove existing toGo functions from xenlight.go in favor of the new generated functions. Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu

[Xen-devel] [PATCH 21/24] golang/xenlight: implement array Go to C marshaling

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu tools/golang/xenlight/gengotypes.py | 44 ++- tools/golang/xenlight/xenlight_helpers.go | 359 ++ 2 files changed, 402 insertions(+), 1 deletion(-) diff --git

[Xen-devel] [PATCH 22/24] golang/xenlight: revise use of Context type

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Remove the exported global context variable, 'Ctx.' Generally, it is better to not export global variables for use through a Go package. However, there are some exceptions that can be found in the standard library. Add a NewContext function instead, and remove the Open,

[Xen-devel] [PATCH 19/24] golang/xenlight: begin Go to C type marshaling

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Implement conversion of basic type conversions such as strings and integer types in toC functions. Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu tools/golang/xenlight/gengotypes.py | 80 ++

[Xen-devel] [PATCH 23/24] golang/xenlight: add error return type to Context.Cpupoolinfo

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook A previous commit that removed Context.CheckOpen revealed an ineffectual assignent to err in Context.Cpupoolinfo, as there is no error return type. Since it appears that the intent is to return an error here, add an error return value to the function signature.

[Xen-devel] [PATCH 24/24] golang/xenlight: add make target for generated files

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Remove the PKGSOURCES variable since adding xenlight_types.go and xenlight_helpers.go to this list breaks the rest of the Makefile. Add xenlight_%.go target for generated files, and use full file names within install, uninstall and $(XEN_GOPATH)$(GOXL_PKG_DIR) rule.

[Xen-devel] [PATCH 20/24] golang/xenlight: implement keyed union Go to C marshaling

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Since the C union cannot be directly populated, populate the fields of the corresponding C struct defined in the cgo preamble, and then copy that struct as bytes into the byte slice that Go uses as the union. Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian

[Xen-devel] [PATCH 17/24] golang/xenlight: implement keyed union C to Go marshaling

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Switch over union key to determine how to populate 'union' in Go struct. Since the unions of C types cannot be directly accessed, add C structs in cgo preamble to assist in marshaling keyed unions. This allows the C type defined in the preamble to be populated first, and

[Xen-devel] [PATCH 18/24] golang/xenlight: implement array C to Go marshaling

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu tools/golang/xenlight/gengotypes.py | 39 ++- tools/golang/xenlight/xenlight_helpers.go | 300 ++ 2 files changed, 338 insertions(+), 1 deletion(-) diff --git

[Xen-devel] [PATCH 14/24] golang/xenlight: generate structs from the IDL

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Add struct and keyed union generation to gengotypes.py. For keyed unions, use a method similar to gRPC's oneof to interpret C unions as Go types. Meaning, for a given struct with a union field, generate a struct for each sub-struct defined in the union. Then, define an

[Xen-devel] [PATCH 15/24] golang/xenlight: remove no-longer used type MemKB

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu tools/golang/xenlight/xenlight.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go index 0adb12d1bf..f91c0d2be2

[Xen-devel] [PATCH 13/24] golang/xenlight: re-factor Hwcap type implementation

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Re-define Hwcap as [8]uint32, and implement toC function. Also, re-name and modify signature of toGo function to fromC. Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu tools/golang/xenlight/xenlight.go | 29 +++--

[Xen-devel] [PATCH 11/24] golang/xenlight: define CpuidPolicyList builtin type

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Define CpuidPolicyList as a wrapper struct with field val of type *C.libxl_cpuid_policy_list and implement fromC and toC functions. Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu tools/golang/xenlight/xenlight.go | 20

[Xen-devel] [PATCH 08/24] golang/xenlight: define Mac builtin type

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Define Mac as [6]byte and implement fromC, toC, and String functions. Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu tools/golang/xenlight/xenlight.go | 35 +++ 1 file changed, 35 insertions(+) diff --git

[Xen-devel] [PATCH 12/24] golang/xenlight: re-factor Uuid type implementation

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Re-define Uuid as [16]byte and implement fromC, toC, and String functions. Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu tools/golang/xenlight/xenlight.go | 37 +-- 1 file changed, 35 insertions(+), 2

[Xen-devel] [PATCH 10/24] golang/xenlight: define EvLink builtin as empty struct

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Define EvLink as empty struct as there is currently no reason the internal of this type should be used in Go. Implement fromC and toC functions as no-ops. Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu tools/golang/xenlight/xenlight.go

[Xen-devel] [PATCH 07/24] golang/xenlight: define StringList builtin type

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Define StringList as []string an implement fromC and toC functions. Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu tools/golang/xenlight/xenlight.go | 29 + 1 file changed, 29 insertions(+) diff --git

[Xen-devel] [PATCH 05/24] golang/xenlight: define KeyValueList builtin type

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Define KeyValueList builtin type, analagous to libxl_key_value_list as map[string]string, and implement its fromC and toC functions. Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu tools/golang/xenlight/xenlight.go | 33

[Xen-devel] [PATCH 03/24] golang/xenlight: define Defbool builtin type

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Define Defbool as struct analagous to the C type, and define the type 'defboolVal' that represent true, false, and default defbool values. Implement Set, Unset, SetIfDefault, IsDefault, Val, and String functions on Defbool so that the type can be used in Go analagously to

[Xen-devel] [PATCH 00/24] generated Go libxl bindings using IDL

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook After Xen summit, we started the discussion in this[1] RFC thread to figure out how to generate Go bindings for libxl. This series implements that Go code generation using the existing IDL, and updates the existing hand-written code in xenlight.go to use the generated code.

[Xen-devel] [PATCH 09/24] golang/xenlight: define MsVmGenid builtin type

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Define MsVmGenid as [int(C.LIBXL_MS_VM_GENID_LEN)]byte and implement fromC and toC functions. Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu tools/golang/xenlight/xenlight.go | 23 +++ 1 file changed, 23

[Xen-devel] [PATCH 02/24] golang/xenlight: generate enum types from IDL

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Introduce gengotypes.py to generate Go code the from IDL. As a first step, implement 'enum' type generation. As a result of the newly-generated code, remove the existing, and now conflicting definitions in xenlight.go. In the case of the Error type, rename the slice 'errors'

[Xen-devel] [PATCH 06/24] golang/xenlight: re-name Bitmap marshaling functions

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Re-name and modify signature of toGo function to fromC. The reason for using 'fromC' rather than 'toGo' is that it is not a good idea to define methods on the C types. Also, add error return type to Bitmap's toC function. Finally, as code-cleanup, re-organize the Bitmap

[Xen-devel] [PATCH 01/24] golang/xenlight: fix calls to libxl_domain_unpause/pause

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook These functions require a third argument of type const *libxl_asyncop_how. Pass nil to fix compilation errors. This will have the effect of performing these operations synchronously. Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu

[Xen-devel] [PATCH 04/24] golang/xenlight: define Devid type as int

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Signed-off-by: Nick Rosbrook --- Cc: George Dunlap Cc: Ian Jackson Cc: Wei Liu tools/golang/xenlight/xenlight.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go index 7bf16dc03b..4d4fad2a9d

[Xen-devel] [xen-unstable-smoke test] 142395: tolerable all pass - PUSHED

2019-10-07 Thread osstest service owner
flight 142395 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/142395/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [linux-4.4 test] 142381: regressions - FAIL

2019-10-07 Thread osstest service owner
flight 142381 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/142381/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 18 guest-localmigrate/x10 fail REGR. vs. 139698 Tests which are

Re: [Xen-devel] [PATCH] xen/xenbus: fix self-deadlock after killing user process

2019-10-07 Thread James Dingwall
On Tue, Oct 01, 2019 at 01:37:24PM -0400, Boris Ostrovsky wrote: > On 10/1/19 11:03 AM, Juergen Gross wrote: > > In case a user process using xenbus has open transactions and is killed > > e.g. via ctrl-C the following cleanup of the allocated resources might > > result in a deadlock due to trying

Re: [Xen-devel] [PATCH 1/4] docs/sphinx: License content with CC-BY-4.0

2019-10-07 Thread Lars Kurth
On 07/10/2019, 13:29, "Andrew Cooper" wrote: On 07/10/2019 13:01, Lars Kurth wrote: > > On 03/10/2019, 21:56, "Andrew Cooper" wrote: > > Creative Commons is a more common license than GPL for documentation purposes. > Switch to using CC-BY-4.0 to explicitly

Re: [Xen-devel] [PATCH v3 08/10] vpci: register as an internal ioreq server

2019-10-07 Thread Jan Beulich
On 30.09.2019 15:32, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build.c > @@ -29,6 +29,7 @@ > > #include > #include > +#include > #include > #include > #include This is the only change to this file, and there's no addition to

[Xen-devel] [linux-linus test] 142372: regressions - FAIL

2019-10-07 Thread osstest service owner
flight 142372 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/142372/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 133580

Re: [Xen-devel] [PATCH 1/4] docs/sphinx: License content with CC-BY-4.0

2019-10-07 Thread Andrew Cooper
On 07/10/2019 13:01, Lars Kurth wrote: > > On 03/10/2019, 21:56, "Andrew Cooper" wrote: > > Creative Commons is a more common license than GPL for documentation > purposes. > Switch to using CC-BY-4.0 to explicitly permit re-purposing and remixing > of > the content. > >

Re: [Xen-devel] [PATCH 1/4] docs/sphinx: License content with CC-BY-4.0

2019-10-07 Thread Lars Kurth
On 03/10/2019, 21:56, "Andrew Cooper" wrote: Creative Commons is a more common license than GPL for documentation purposes. Switch to using CC-BY-4.0 to explicitly permit re-purposing and remixing of the content. Signed-off-by: Andrew Cooper --- CC: Lars Kurth

Re: [Xen-devel] [PATCH v3 07/10] ioreq: allow decoding accesses to MMCFG regions

2019-10-07 Thread Jan Beulich
On 30.09.2019 15:32, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/io.c > +++ b/xen/arch/x86/hvm/io.c > @@ -279,6 +279,18 @@ unsigned int hvm_pci_decode_addr(unsigned int cf8, > unsigned int addr, > return CF8_ADDR_LO(cf8) | (addr & 3); > } > > +unsigned int hvm_mmcfg_decode_addr(const

Re: [Xen-devel] [PATCH v2 1/6] Import v1.4 of Contributor Covenant CoC

2019-10-07 Thread Lars Kurth
On 07/10/2019, 12:06, "George Dunlap" wrote: On 9/26/19 8:39 PM, Lars Kurth wrote: > From: Lars Kurth > > Signed-off-by: Lars Kurth > --- > Cc: minios-de...@lists.xenproject.org > Cc: xen-...@lists.xenproject.org > Cc: win-pv-de...@lists.xenproject.org >

Re: [Xen-devel] [PATCH for-4.13] docs: update all URLs in man pages

2019-10-07 Thread Wei Liu
On Mon, Oct 07, 2019 at 11:07:03AM +, Lars Kurth wrote: > > > On 07/10/2019, 10:01, "Wei Liu" wrote: > > On Mon, 7 Oct 2019 at 09:13, Lars Kurth wrote: > > > > > > > > On 04/10/2019, 09:57, "Wei Liu" wrote: > > > > On Thu, Oct 03, 2019 at 04:12:30PM

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-07 Thread Jürgen Groß
On 07.10.19 12:49, Jan Beulich wrote: On 07.10.2019 12:19, Jürgen Groß wrote: On 07.10.19 12:03, Jan Beulich wrote: I appreciate the ack, but I think I'd prefer to not make use of it if at all possible under these conditions. Instead I'd like us to reach some common ground here. Seeing that

Re: [Xen-devel] [PATCH for-4.13] docs: update all URLs in man pages

2019-10-07 Thread Jürgen Groß
On 07.10.19 13:07, Lars Kurth wrote: On 07/10/2019, 10:01, "Wei Liu" wrote: On Mon, 7 Oct 2019 at 09:13, Lars Kurth wrote: > > > > On 04/10/2019, 09:57, "Wei Liu" wrote: > > On Thu, Oct 03, 2019 at 04:12:30PM +, Lars Kurth wrote: > >

Re: [Xen-devel] [PATCH for-4.13] docs: update all URLs in man pages

2019-10-07 Thread Lars Kurth
On 07/10/2019, 10:01, "Wei Liu" wrote: On Mon, 7 Oct 2019 at 09:13, Lars Kurth wrote: > > > > On 04/10/2019, 09:57, "Wei Liu" wrote: > > On Thu, Oct 03, 2019 at 04:12:30PM +, Lars Kurth wrote: > > Specifically > > * xen.org to

Re: [Xen-devel] [PATCH v2 1/6] Import v1.4 of Contributor Covenant CoC

2019-10-07 Thread George Dunlap
On 9/26/19 8:39 PM, Lars Kurth wrote: > From: Lars Kurth > > Signed-off-by: Lars Kurth > --- > Cc: minios-de...@lists.xenproject.org > Cc: xen-...@lists.xenproject.org > Cc: win-pv-de...@lists.xenproject.org > Cc: mirageos-de...@lists.xenproject.org > Cc: committ...@xenproject.org > --- >

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-07 Thread Jan Beulich
On 07.10.2019 12:19, Jürgen Groß wrote: > On 07.10.19 12:03, Jan Beulich wrote: >> I appreciate the ack, but I think I'd prefer to not make use of it >> if at all possible under these conditions. Instead I'd like us to >> reach some common ground here. Seeing that we're past the deadline >>

Re: [Xen-devel] [PATCH v2] xen/sched: let credit scheduler control its timer all alone

2019-10-07 Thread George Dunlap
On 10/7/19 7:35 AM, Juergen Gross wrote: > The credit scheduler is the only scheduler with tick_suspend and > tick_resume callbacks. Today those callbacks are invoked without being > guarded by the scheduler lock which is critical when at the same the > cpu those callbacks are active is being

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-07 Thread Jürgen Groß
On 07.10.19 12:03, Jan Beulich wrote: I appreciate the ack, but I think I'd prefer to not make use of it if at all possible under these conditions. Instead I'd like us to reach some common ground here. Seeing that we're past the deadline already, Jürgen's release ack will now be needed anyway.

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-07 Thread Jan Beulich
On 04.10.2019 19:28, Andrew Cooper wrote: > On 04/10/2019 14:30, Jan Beulich wrote: >> On 04.10.2019 15:18, Andrew Cooper wrote: >>> On 26/09/2019 15:28, Jan Beulich wrote: @@ -1068,8 +1067,29 @@ static void * __init allocate_ppr_log(st

Re: [Xen-devel] [PATCH for-4.13] xen/arm: fix duplicate memory node in DT

2019-10-07 Thread Julien Grall
Hi, On 05/10/2019 00:09, Stefano Stabellini wrote: When reserved-memory regions are present in the host device tree, dom0 is started with multiple memory nodes. Each memory node should have a unique name, but today they are all called "memory" leading to Linux printing the following warning at

Re: [Xen-devel] [PATCH] read grubenv and set default from saved_entry or next_entry [and 1 more messages]

2019-10-07 Thread Ian Jackson
Hi. Thanks for the message. Just one thing I wanted to reply to in your mail: YOUNG, MICHAEL A. writes ("Re: [Xen-devel] [PATCH] read grubenv and set default from saved_entry or next_entry [and 1 more messages]"): > On Wed, 11 Sep 2019, Ian Jackson wrote: > > I find this filename hackery

Re: [Xen-devel] [XEN PATCH for-4.13 3/6] libxl: libxl__domain_config_setdefault: New function

2019-10-07 Thread Ian Jackson
Anthony PERARD writes ("Re: [XEN PATCH for-4.13 3/6] libxl: libxl__domain_config_setdefault: New function"): > On Fri, Oct 04, 2019 at 05:04:27PM +0100, Ian Jackson wrote: > > Anthony PERARD writes ("Re: [XEN PATCH for-4.13 3/6] libxl: > > libxl__domain_config_setdefault: New function"): > > >

Re: [Xen-devel] [PATCH] xen/typesafe: Force helpers to be always_inline

2019-10-07 Thread Jan Beulich
On 04.10.2019 19:02, George Dunlap wrote: > On 10/2/19 9:11 AM, Jan Beulich wrote: >> On 01.10.2019 22:59, Andrew Cooper wrote: >>> On 01/10/2019 09:38, Jan Beulich wrote: On 30.09.2019 21:16, Andrew Cooper wrote: > Clang in particular has a habit of out-of-lining these and creating

Re: [Xen-devel] [PATCH v2] xen/sched: let credit scheduler control its timer all alone

2019-10-07 Thread Jürgen Groß
On 07.10.19 11:05, Dario Faggioli wrote: On Mon, 2019-10-07 at 08:35 +0200, Juergen Gross wrote: The credit scheduler is the only scheduler with tick_suspend and tick_resume callbacks. Today those callbacks are invoked without being guarded by the scheduler lock which is critical when at the

Re: [Xen-devel] [PATCH v2] xen/sched: let credit scheduler control its timer all alone

2019-10-07 Thread Dario Faggioli
On Mon, 2019-10-07 at 08:35 +0200, Juergen Gross wrote: > The credit scheduler is the only scheduler with tick_suspend and > tick_resume callbacks. Today those callbacks are invoked without > being > guarded by the scheduler lock which is critical when at the same the > cpu those callbacks are

Re: [Xen-devel] [PATCH for-4.13] docs: update all URLs in man pages

2019-10-07 Thread Wei Liu
On Mon, 7 Oct 2019 at 09:13, Lars Kurth wrote: > > > > On 04/10/2019, 09:57, "Wei Liu" wrote: > > On Thu, Oct 03, 2019 at 04:12:30PM +, Lars Kurth wrote: > > Specifically > > * xen.org to xenproject.org > > * http to https > > * Replaced pages where page has moved >

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-07 Thread Dario Faggioli
On Sun, 2019-10-06 at 20:05 +0200, Jürgen Groß wrote: > On 04.10.19 18:09, George Dunlap wrote: > > > > I can think of a couple of options: > > > > 1. Have schedule.c call s->tick_* when switching to / from idle > > > > 2. Get rid of s->tick_*, and have sched_credit.c suspend / resume > > ticks

Re: [Xen-devel] [RESEND TRIVIAL 3/3] treewide: arch: Fix Kconfig indentation

2019-10-07 Thread Geert Uytterhoeven
On Fri, Oct 4, 2019 at 4:57 PM Krzysztof Kozlowski wrote: > Adjust indentation from spaces to tab (+optional two spaces) as in > coding style with command like: > $ sed -e 's/^/\t/' -i */Kconfig > > Signed-off-by: Krzysztof Kozlowski > arch/m68k/Kconfig.bus | 2 +-

Re: [Xen-devel] [PATCH for-4.13] docs: update all URLs in man pages

2019-10-07 Thread Lars Kurth
On 04/10/2019, 09:57, "Wei Liu" wrote: On Thu, Oct 03, 2019 at 04:12:30PM +, Lars Kurth wrote: > Specifically > * xen.org to xenproject.org > * http to https > * Replaced pages where page has moved > (including on xen pages as well as external pages) > *

Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-07 Thread Jan Beulich
On 05.10.2019 01:58, Chao Gao wrote: > On Wed, Oct 02, 2019 at 12:49:35PM +0200, Roger Pau Monne wrote: >> The current implementation of host_maskall makes it sticky across >> assign and deassign calls, which means that once a guest forces Xen to >> set host_maskall the maskall bit is not going to

Re: [Xen-devel] [Xen-users] xenstat_domain_cpu_ns() occasionally returns a huge value

2019-10-07 Thread Jan Beulich
On 06.10.2019 11:01, Jürgen Groß wrote: > On 06.10.19 07:19, Andy Smith wrote: >> Hi, >> >> I was writing a little utility to dump out domain CPU times and I >> noticed that occasionally xenstat_domain_cpu_ns() returns an >> erroneous huge value like 9223488034477457013. >> >> Attached is a small

Re: [Xen-devel] [PATCH for-4.13] xen/xsm: flask: Prevent NULL deference in flask_assign_{, dt}device()

2019-10-07 Thread Jürgen Groß
On 04.10.19 18:42, Julien Grall wrote: flask_assign_{, dt}device() may be used to check whether you can test if a device is assigned. In this case, the domain will be NULL. However, flask_iommu_resource_use_perm() will be called and may end up to deference a NULL pointer. This can be prevented

Re: [Xen-devel] [PATCH for-4.13] xen/arm: fix duplicate memory node in DT

2019-10-07 Thread Jürgen Groß
On 05.10.19 01:09, Stefano Stabellini wrote: When reserved-memory regions are present in the host device tree, dom0 is started with multiple memory nodes. Each memory node should have a unique name, but today they are all called "memory" leading to Linux printing the following warning at boot:

Re: [Xen-devel] [XEN PATCH for-4.13 0/6] Drop/deprecate libxl_get_required_*_memory

2019-10-07 Thread Jürgen Groß
On 04.10.19 17:17, Ian Jackson wrote: libxl_get_required_shadow_memory has always been anomalous. libxl ought to default these things itself. Recently, another analogous setting, iommu_memkb, was introduced, along with another function along the same lines. This API is not very good. Fixing

Re: [Xen-devel] [PATCH for-4.13] xen/xsm: flask: Check xmalloc_array() return in security_sid_to_context()

2019-10-07 Thread Jürgen Groß
On 04.10.19 18:56, Julien Grall wrote: xmalloc_array() may return NULL if there are memory. Rather than trying to deference it directly, we should check the return value first. Coverity-ID: 1381852 Signed-off-by: Julien Grall Release-acked-by: Juergen Gross Juergen

[Xen-devel] [PATCH v2] xen/sched: let credit scheduler control its timer all alone

2019-10-07 Thread Juergen Gross
The credit scheduler is the only scheduler with tick_suspend and tick_resume callbacks. Today those callbacks are invoked without being guarded by the scheduler lock which is critical when at the same the cpu those callbacks are active is being moved to or from a cpupool. Crashes like the

[Xen-devel] [qemu-mainline test] 142369: regressions - FAIL

2019-10-07 Thread osstest service owner
flight 142369 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/142369/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 140282

Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()

2019-10-07 Thread Jürgen Groß
On 06.10.19 20:05, Jürgen Groß wrote: On 04.10.19 18:09, George Dunlap wrote: On 10/4/19 4:40 PM, Jürgen Groß wrote: On 04.10.19 17:37, George Dunlap wrote: On 10/4/19 4:03 PM, Jürgen Groß wrote: On 04.10.19 16:56, George Dunlap wrote: On 10/4/19 3:43 PM, Jürgen Groß wrote: On 04.10.19