Re: [Xen-devel] [PATCH v3 1/3] xen/flask: Drop the gen-policy.py script

On 09.12.2019 18:01, Andrew Cooper wrote: > On 09/12/2019 13:38, Jan Beulich wrote: >> On 07.12.2019 22:16, Andrew Cooper wrote: >>> --- /dev/null >>> +++ b/xen/xsm/flask/flask-policy.S >>> @@ -0,0 +1,20 @@ >>> +.section .init.rodata, "a", %progbits >>> + >>> +/* const unsigned char

Re: [Xen-devel] [PATCH] docs/sphinx: How Xen Boots on x86

On 09.12.2019 17:42, Andrew Cooper wrote: > On 09/12/2019 15:20, Jan Beulich wrote: >> On 06.12.2019 20:34, Andrew Cooper wrote: >>> +Objects >>> +~~~ >>> + >>> +To begin with, most object files are compiled and linked. This includes >>> the >>> +Multiboot 1 and 2 headers and entrypoints,

Re: [Xen-devel] [PATCH v2] x86 / iommu: set up a scratch page in the quarantine domain

> From: Jan Beulich > Sent: Tuesday, December 3, 2019 5:36 PM > > On 28.11.2019 12:32, Jürgen Groß wrote: > > On 28.11.19 12:17, Jan Beulich wrote: > >> On 27.11.2019 18:11, Paul Durrant wrote: > >>> This patch introduces a new iommu_op to facilitate a per- > implementation > >>> quarantine set

Re: [Xen-devel] [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk

On 09.12.19 21:14, Nathan Chancellor wrote: Clang warns: ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] nr_parts = PARTS_PER_DISK; ^

Re: [Xen-devel] [PATCH] x86/svm: Fix handling of EFLAGS.RF on task switch

On 03.12.19 23:30, Andrew Cooper wrote: VT-x updates RF before vmexit, so eflags written into the outgoing TSS happens to be correct. SVM does not update RF before vmexit, and instead provides it via a bit in exitinfo2. In practice, needing RF set in the outgoing state occurs when a task gate

Re: [Xen-devel] [PATCH] x86/svm: Fix handling of EFLAGS.RF on task switch

> From: Andrew Cooper > Sent: Wednesday, December 4, 2019 6:31 AM > > VT-x updates RF before vmexit, so eflags written into the outgoing TSS > happens > to be correct. SVM does not update RF before vmexit, and instead provides > it > via a bit in exitinfo2. > > In practice, needing RF set in

[Xen-devel] [ovmf test] 144646: regressions - FAIL

flight 144646 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144646/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 144637 build-i386-xsm

Re: [Xen-devel] [PATCH v4 1/2] xenbus/backend: Add memory pressure handler callback

On Tue, Dec 10, 2019 at 7:23 AM Jürgen Groß wrote: > > On 09.12.19 20:43, SeongJae Park wrote: > > From: SeongJae Park > > > > Granting pages consumes backend system memory. In systems configured > > with insufficient spare memory for those pages, it can cause a memory > > pressure situation.

Re: [Xen-devel] [PATCH v4 1/2] xenbus/backend: Add memory pressure handler callback

On Tue, Dec 10, 2019 at 7:11 AM Jürgen Groß wrote: > > On 09.12.19 20:43, SeongJae Park wrote: > > From: SeongJae Park > > > > Granting pages consumes backend system memory. In systems configured > > with insufficient spare memory for those pages, it can cause a memory > > pressure situation.

Re: [Xen-devel] [PATCH v4 2/2] xen/blkback: Squeeze page pools if a memory pressure is detected

On 09.12.19 20:43, SeongJae Park wrote: From: SeongJae Park Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and be increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has

Re: [Xen-devel] [PATCH v4 1/2] xenbus/backend: Add memory pressure handler callback

On 09.12.19 20:43, SeongJae Park wrote: From: SeongJae Park Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging

Re: [Xen-devel] [PATCH v4 1/2] xenbus/backend: Add memory pressure handler callback

On 09.12.19 20:43, SeongJae Park wrote: From: SeongJae Park Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging

Re: [Xen-devel] [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk

On 09.12.19 22:07, Nick Desaulniers wrote: On Mon, Dec 9, 2019 at 12:14 PM Nathan Chancellor wrote: Clang warns: ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] nr_parts =

[Xen-devel] [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk

Clang warns: ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] nr_parts = PARTS_PER_DISK; ^ ../drivers/block/xen-blkfront.c:1115:3: note: previous statement is here

Re: [Xen-devel] [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk

On Mon, Dec 9, 2019 at 12:14 PM Nathan Chancellor wrote: > > Clang warns: > > ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation; > statement is not part of the previous 'if' [-Wmisleading-indentation] > nr_parts = PARTS_PER_DISK; > ^ >

Re: [Xen-devel] [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk

On Mon, Dec 09, 2019 at 01:07:41PM -0800, Nick Desaulniers wrote: > On Mon, Dec 9, 2019 at 12:14 PM Nathan Chancellor > wrote: > > > > Clang warns: > > > > ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation; > > statement is not part of the previous 'if'

[Xen-devel] [qemu-mainline test] 144643: trouble: broken/fail/pass

acking branch 'remotes/dgibson/tags/ppc-for-4.2-20191209' into staging ppc patch queue 2019-12-09 This is a last minute pull request for ppc-for-4.2. I know it's very late in freeze, but this does fix a regression: a bad interaction between the new qemu and SLOF device tre

[Xen-devel] [seabios test] 144644: trouble: broken/fail/pass

flight 144644 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/144644/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadowbroken

[Xen-devel] [xen-unstable test] 144641: regressions - trouble: broken/fail/pass

flight 144641 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/144641/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2broken test-amd64-i386-xl-qemuu-win7-amd64

[Xen-devel] [xen-4.13-testing test] 144640: regressions - trouble: broken/fail/pass

flight 144640 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144640/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 broken

Re: [Xen-devel] [PATCH] x86/microcode: Support builtin CPU microcode

On 09.12.19 16:19, Andrew Cooper wrote: On 09/12/2019 08:41, Eslam Elnikety wrote: diff --git a/docs/misc/builtin-ucode.txt b/docs/misc/builtin-ucode.txt new file mode 100644 index 00..43bb60d3eb Instead of introducing a new file, please extend docs/admin-guide/microcode-loading.rst

Re: [Xen-devel] [PATCH] xen/pciback: Prevent NULL pointer dereference in quirks_show

On 12/9/19 1:16 PM, Nuernberger, Stefan wrote: On Fri, 2019-12-06 at 15:15 -0500, Boris Ostrovsky wrote: On 12/6/19 1:09 PM, Nuernberger, Stefan wrote: On Fri, 2019-12-06 at 10:11 -0500, Boris Ostrovsky wrote: On 12/6/19 8:48 AM, Stefan Nuernberger wrote: From: Uwe Dannowski  

[Xen-devel] [PATCH v4 2/2] xen/blkback: Squeeze page pools if a memory pressure is detected

From: SeongJae Park Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and be increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has passed since last I/O requests handling, it

[Xen-devel] [PATCH v4 0/2] xenbus/backend: Add a memory pressure handler callback

Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging for large systems having dynamic resource utilization patterns.

[Xen-devel] [PATCH v4 1/2] xenbus/backend: Add memory pressure handler callback

From: SeongJae Park Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging for large systems having dynamic resource

[Xen-devel] [qemu-mainline test] 144638: trouble: broken/fail/pass

: Peter Maydell Date: Mon Dec 9 11:07:34 2019 + Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.2-20191209' into staging ppc patch queue 2019-12-09 This is a last minute pull request for ppc-for-4.2. I know it's very late in freeze, but this does fix

Re: [Xen-devel] [PATCH-for-5.0 v3 0/6] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through

Patchew URL: https://patchew.org/QEMU/20191209095002.32194-1-phi...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Xen-devel] [PATCH-for-5.0 v3 0/6] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through

Patchew URL: https://patchew.org/QEMU/20191209095002.32194-1-phi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Xen-devel] [PATCH v3 1/3] xen/flask: Drop the gen-policy.py script

On 12/7/19 4:16 PM, Andrew Cooper wrote: The script is Python 2 specific, and fails with string/binary issues with Python 3: Traceback (most recent call last): File "gen-policy.py", line 14, in for char in sys.stdin.read(): File "/usr/lib/python3.5/codecs.py", line 321, in

Re: [Xen-devel] [PATCH 5/6] xen/tasklet: Return -ERESTART from continue_hypercall_on_cpu()

On 09/12/2019 16:52, Jan Beulich wrote: > On 05.12.2019 23:30, Andrew Cooper wrote: >> Some hypercalls tasklets want to create a continuation, rather than fail the >> hypercall with a hard error. By the time the tasklet is executing, it is too >> late to create the continuation, and even

Re: [Xen-devel] [PATCH 4/6] xen/hypercall: Cope with -ERESTART on more hypercall paths

On 09/12/2019 16:29, Jan Beulich wrote: > On 09.12.2019 17:25, Jan Beulich wrote: >> On 05.12.2019 23:30, Andrew Cooper wrote: >>> These hypercalls each use continue_hypercall_on_cpu(), whose API is about to >>> switch to use -ERESTART. Update the soon-to-be affected paths to cope, >>> folding

[Xen-devel] [PATCH v4] x86: do not enable global pages when virtualized on AMD hardware

When using global pages a full tlb flush can only be performed by toggling the PGE bit in CR4, which is usually quite expensive in terms of performance when running virtualized. This is specially relevant on AMD hardware, which doesn't have the ability to do selective CR4 trapping, but can also be

Re: [Xen-devel] [PATCH 4/6] xen/hypercall: Cope with -ERESTART on more hypercall paths

On 08/12/2019 12:57, Julien Grall wrote: > Hi Andrew, > > On 05/12/2019 22:30, Andrew Cooper wrote: >> These hypercalls each use continue_hypercall_on_cpu(), whose API is >> about to >> switch to use -ERESTART.  Update the soon-to-be affected paths to cope, >> folding existing contination logic

Re: [Xen-devel] [PATCH 3/6] xen/domctl: Consolidate hypercall continuation handling at the top level

On 09/12/2019 16:19, Jan Beulich wrote: > On 05.12.2019 23:30, Andrew Cooper wrote: >> --- a/xen/arch/x86/domctl.c >> +++ b/xen/arch/x86/domctl.c >> @@ -326,9 +326,12 @@ long arch_do_domctl( >> >> switch ( domctl->cmd ) >> { >> - >> case XEN_DOMCTL_shadow_op: >> ret =

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Roger Pau Monné > Sent: 09 December 2019 17:18 > To: Durrant, Paul > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Juergen > Gross ; Stefano Stabellini ; > Boris Ostrovsky > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH 3/6] xen/domctl: Consolidate hypercall continuation handling at the top level

On 08/12/2019 12:18, Julien Grall wrote: > Hi, > > On 05/12/2019 22:30, Andrew Cooper wrote: >> More paths are going start using hypercall continuations.  We could >> add extra >> calls to hypercall_create_continuation() but it is much easier to handle >> -ERESTART once at the top level. >> >> One

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On Mon, Dec 09, 2019 at 04:26:15PM +, Durrant, Paul wrote: > > > If you want unbind to actually do a proper unplug then that's extra work > > and not really something I want to tackle (and re-bind would still need to > > be toolstack initiated as something would have to re-create the xenstore

Re: [Xen-devel] [PATCH v3 1/3] xen/flask: Drop the gen-policy.py script

On 09/12/2019 13:38, Jan Beulich wrote: > On 07.12.2019 22:16, Andrew Cooper wrote: >> --- /dev/null >> +++ b/xen/xsm/flask/flask-policy.S >> @@ -0,0 +1,20 @@ >> +.section .init.rodata, "a", %progbits >> + >> +/* const unsigned char xsm_flask_init_policy[] __initconst */ >> +.align

[Xen-devel] [xen-unstable-smoke test] 144639: tolerable all pass - PUSHED

flight 144639 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/144639/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH 5/6] xen/tasklet: Return -ERESTART from continue_hypercall_on_cpu()

On 05.12.2019 23:30, Andrew Cooper wrote: > Some hypercalls tasklets want to create a continuation, rather than fail the > hypercall with a hard error. By the time the tasklet is executing, it is too > late to create the continuation, and even continue_hypercall_on_cpu() doesn't > have enough

Re: [Xen-devel] [PATCH] docs/sphinx: How Xen Boots on x86

On 09/12/2019 15:20, Jan Beulich wrote: > On 06.12.2019 20:34, Andrew Cooper wrote: >> Begin to document how the x86 build of Xen boots. It is by no means >> complete, >> but is a start. >> >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: Wei Liu >> CC: Roger Pau Monné >> >>

Re: [Xen-devel] [PATCH 3/4] xen/interface: don't discard pending work in FRONT/BACK_RING_ATTACH

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 13:55 > To: Durrant, Paul ; linux-ker...@vger.kernel.org; > xen-devel@lists.xenproject.org > Cc: Boris Ostrovsky ; Stefano Stabellini > > Subject: Re: [PATCH 3/4] xen/interface: don't discard pending work in >

Re: [Xen-devel] [PATCH 4/6] xen/hypercall: Cope with -ERESTART on more hypercall paths

On 09.12.2019 17:25, Jan Beulich wrote: > On 05.12.2019 23:30, Andrew Cooper wrote: >> These hypercalls each use continue_hypercall_on_cpu(), whose API is about to >> switch to use -ERESTART. Update the soon-to-be affected paths to cope, >> folding existing contination logic where applicable. >>

Re: [Xen-devel] [PATCH 4/6] xen/hypercall: Cope with -ERESTART on more hypercall paths

On 05.12.2019 23:30, Andrew Cooper wrote: > These hypercalls each use continue_hypercall_on_cpu(), whose API is about to > switch to use -ERESTART. Update the soon-to-be affected paths to cope, > folding existing contination logic where applicable. > > In addition: > * For platform op and

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- [snip] > > > > Well unbind is pretty useless now IMO since bind doesn't work, and a > transition straight to closed is just plain wrong anyway. > > Why do you claim that a straight transition into the closed state is > wrong? It's badly documented, I agree, but have

Re: [Xen-devel] [PATCH 3/6] xen/domctl: Consolidate hypercall continuation handling at the top level

On 05.12.2019 23:30, Andrew Cooper wrote: > --- a/xen/arch/x86/domctl.c > +++ b/xen/arch/x86/domctl.c > @@ -326,9 +326,12 @@ long arch_do_domctl( > > switch ( domctl->cmd ) > { > - > case XEN_DOMCTL_shadow_op: > ret = paging_domctl(d, >u.shadow_op, u_domctl, 0); > +

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On 09.12.2019 16:52, Roger Pau Monné wrote: > On Mon, Dec 09, 2019 at 04:39:58PM +0100, Jan Beulich wrote: >> On 09.12.2019 16:36, Roger Pau Monné wrote: >>> On Mon, Dec 09, 2019 at 04:04:51PM +0100, Jan Beulich wrote: On 09.12.2019 15:46, Roger Pau Monné wrote: > On Mon, Dec 09, 2019 at

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

> On 9 Dec 2019, at 11:02, Lars Kurth wrote: > > > > On 06/12/2019, 09:51, "Jan Beulich" > wrote: > >On 06.12.2019 00:41, Lars Kurth wrote: >> I propose to add the following section to code-review-guide.md >> >> >> ## Problematic Patch Reviews >> >> A

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On Mon, Dec 09, 2019 at 04:39:58PM +0100, Jan Beulich wrote: > On 09.12.2019 16:36, Roger Pau Monné wrote: > > On Mon, Dec 09, 2019 at 04:04:51PM +0100, Jan Beulich wrote: > >> On 09.12.2019 15:46, Roger Pau Monné wrote: > >>> On Mon, Dec 09, 2019 at 03:21:28PM +0100, Jan Beulich wrote: > On

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On 09.12.2019 16:36, Roger Pau Monné wrote: > On Mon, Dec 09, 2019 at 04:04:51PM +0100, Jan Beulich wrote: >> On 09.12.2019 15:46, Roger Pau Monné wrote: >>> On Mon, Dec 09, 2019 at 03:21:28PM +0100, Jan Beulich wrote: On 09.12.2019 11:20, Roger Pau Monné wrote: > On Wed, Dec 04, 2019 at

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On Mon, Dec 09, 2019 at 04:04:51PM +0100, Jan Beulich wrote: > On 09.12.2019 15:46, Roger Pau Monné wrote: > > On Mon, Dec 09, 2019 at 03:21:28PM +0100, Jan Beulich wrote: > >> On 09.12.2019 11:20, Roger Pau Monné wrote: > >>> On Wed, Dec 04, 2019 at 06:05:11PM +0100, Jan Beulich wrote: > On

Re: [Xen-devel] [PATCH 2/6] xen/tasklet: Switch data parameter from unsigned long to void *.

On 05.12.2019 23:30, Andrew Cooper wrote: > Most users pass a vcpu pointer, and only stopmachine_action() takes an integer > parameter. Switch to using void * to substantially reduce the number of > explicit casts. > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Jan

Re: [Xen-devel] [PATCH] docs/sphinx: How Xen Boots on x86

On 06.12.2019 20:34, Andrew Cooper wrote: > Begin to document how the x86 build of Xen boots. It is by no means complete, > but is a start. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Wei Liu > CC: Roger Pau Monné > > This came about while I sat in SFO waiting for a

Re: [Xen-devel] [PATCH] x86/microcode: Support builtin CPU microcode

On 09/12/2019 08:41, Eslam Elnikety wrote: > diff --git a/docs/misc/builtin-ucode.txt b/docs/misc/builtin-ucode.txt > new file mode 100644 > index 00..43bb60d3eb Instead of introducing a new file, please extend docs/admin-guide/microcode-loading.rst I have an in-prep

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On Mon, Dec 09, 2019 at 02:41:40PM +, Durrant, Paul wrote: > > -Original Message- > > From: Roger Pau Monné > > Sent: 09 December 2019 14:29 > > To: Durrant, Paul > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Juergen > > Gross ; Stefano Stabellini ; > > Boris

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On 09.12.2019 15:46, Roger Pau Monné wrote: > On Mon, Dec 09, 2019 at 03:21:28PM +0100, Jan Beulich wrote: >> On 09.12.2019 11:20, Roger Pau Monné wrote: >>> On Wed, Dec 04, 2019 at 06:05:11PM +0100, Jan Beulich wrote: On 04.12.2019 17:18, Roger Pau Monné wrote: > On Wed, Dec 04, 2019 at

Re: [Xen-devel] [PATCH v3 2/4] x86/apic: force phys mode if interrupt remapping is disabled

On Mon, Dec 09, 2019 at 03:30:27PM +0100, Jan Beulich wrote: > On 09.12.2019 11:25, Roger Pau Monné wrote: > > On Thu, Dec 05, 2019 at 10:32:34AM +0100, Jan Beulich wrote: > >> On 04.12.2019 17:20, Roger Pau Monne wrote: > >>> Cluster mode can only be used with interrupt remapping support, since >

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On Mon, Dec 09, 2019 at 03:21:28PM +0100, Jan Beulich wrote: > On 09.12.2019 11:20, Roger Pau Monné wrote: > > On Wed, Dec 04, 2019 at 06:05:11PM +0100, Jan Beulich wrote: > >> On 04.12.2019 17:18, Roger Pau Monné wrote: > >>> On Wed, Dec 04, 2019 at 05:11:42PM +0100, Jan Beulich wrote: > On

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 14:41 > To: Durrant, Paul ; Roger Pau Monné > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano > Stabellini ; Boris Ostrovsky > > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Roger Pau Monné > Sent: 09 December 2019 14:29 > To: Durrant, Paul > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Juergen > Gross ; Stefano Stabellini ; > Boris Ostrovsky > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On 09.12.19 15:23, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 14:10 To: Durrant, Paul ; Roger Pau Monné Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano Stabellini ; Boris Ostrovsky Subject: Re: [Xen-devel] [PATCH 2/4]

Re: [Xen-devel] [PATCH v3 4/4] x86/apic: allow enabling x2APIC mode regardless of interrupt remapping

On 09.12.2019 11:56, Roger Pau Monné wrote: > On Thu, Dec 05, 2019 at 10:45:59AM +0100, Jan Beulich wrote: >> On 04.12.2019 17:20, Roger Pau Monne wrote: >>> +switch ( iommu_enable_x2apic() ) >>> { >>> +case 0: >>> +iommu_x2apic_enabled = true; >>> +

Re: [Xen-devel] [PATCH v3 2/4] x86/apic: force phys mode if interrupt remapping is disabled

On 09.12.2019 11:25, Roger Pau Monné wrote: > On Thu, Dec 05, 2019 at 10:32:34AM +0100, Jan Beulich wrote: >> On 04.12.2019 17:20, Roger Pau Monne wrote: >>> Cluster mode can only be used with interrupt remapping support, since >>> the top 16bits of the APIC ID are filled with the cluster ID, and

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On Mon, Dec 09, 2019 at 12:40:47PM +, Durrant, Paul wrote: > > -Original Message- > > From: Roger Pau Monné > > Sent: 09 December 2019 12:26 > > To: Durrant, Paul > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Juergen > > Gross ; Stefano Stabellini ; > > Boris

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 14:10 > To: Durrant, Paul ; Roger Pau Monné > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano > Stabellini ; Boris Ostrovsky > > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

On 09.12.2019 11:20, Roger Pau Monné wrote: > On Wed, Dec 04, 2019 at 06:05:11PM +0100, Jan Beulich wrote: >> On 04.12.2019 17:18, Roger Pau Monné wrote: >>> On Wed, Dec 04, 2019 at 05:11:42PM +0100, Jan Beulich wrote: On 04.12.2019 16:12, Roger Pau Monne wrote: > @@ -130,7 +143,7 @@

Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

On 09.12.2019 15:06, George Dunlap wrote: > On 12/6/19 4:42 PM, Jan Beulich wrote: >> On 06.12.2019 17:20, Julien Grall wrote: >>> Hi, >>> >>> On 06/12/2019 16:06, Jan Beulich wrote: On 06.12.2019 15:46, Julien Grall wrote: > On 05/12/2019 16:50, Jan Beulich wrote: >> On 05.12.2019

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On 09.12.19 15:06, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 13:39 To: Durrant, Paul ; Roger Pau Monné Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano Stabellini ; Boris Ostrovsky Subject: Re: [Xen-devel] [PATCH 2/4]

Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

On 12/6/19 4:42 PM, Jan Beulich wrote: > On 06.12.2019 17:20, Julien Grall wrote: >> Hi, >> >> On 06/12/2019 16:06, Jan Beulich wrote: >>> On 06.12.2019 15:46, Julien Grall wrote: On 05/12/2019 16:50, Jan Beulich wrote: > On 05.12.2019 17:27, Julien Grall wrote: >> On 05/12/2019

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 13:39 > To: Durrant, Paul ; Roger Pau Monné > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano > Stabellini ; Boris Ostrovsky > > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH 4/4] xen-blkback: support dynamic unbind/bind

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 13:58 > To: Durrant, Paul ; linux-ker...@vger.kernel.org; > xen-devel@lists.xenproject.org > Cc: Konrad Rzeszutek Wilk ; Roger Pau Monné > ; Jens Axboe ; Boris Ostrovsky > ; Stefano Stabellini > Subject: Re: [PATCH 4/4]

Re: [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU

On 09.12.19 14:06, Jan Beulich wrote: On 26.09.2019 17:23, Jürgen Groß wrote: On 25.09.19 17:27, Jan Beulich wrote: There's nothing to restore here if there's no FPU in the first place. Signed-off-by: Jan Beulich Release-acked-by: Juergen Gross While I've committed the change to the

Re: [Xen-devel] [PATCH 4/4] xen-blkback: support dynamic unbind/bind

On 05.12.19 15:01, Paul Durrant wrote: By simply re-attaching to shared rings during connect_ring() rather than assuming they are freshly allocated (i.e assuming the counters are zero) it is possible for vbd instances to be unbound and re-bound from and to (respectively) a running guest. This

Re: [Xen-devel] [PATCH 3/4] xen/interface: don't discard pending work in FRONT/BACK_RING_ATTACH

On 05.12.19 15:01, Paul Durrant wrote: Currently these macros will skip over any requests/responses that are added to the shared ring whilst it is detached. This, in general, is not a desirable semantic since most frontend implementations will eventually block waiting for a response which would

Re: [Xen-devel] [PATCH v3] CODING_STYLE: Document how to handle unexpected conditions

On 09.12.2019 12:29, George Dunlap wrote: > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -133,3 +133,97 @@ the end of files. It should be: > * indent-tabs-mode: nil > * End: > */ > + > +Handling unexpected conditions > +-- > + > +GUIDELINES: > + > +Passing errors

Re: [Xen-devel] [PATCH v3 1/3] xen/flask: Drop the gen-policy.py script

On 07.12.2019 22:16, Andrew Cooper wrote: > --- /dev/null > +++ b/xen/xsm/flask/flask-policy.S > @@ -0,0 +1,20 @@ > +.section .init.rodata, "a", %progbits > + > +/* const unsigned char xsm_flask_init_policy[] __initconst */ > +.align 4 I'm afraid .align is not universal enough to

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On 09.12.19 13:19, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 12:09 To: Durrant, Paul ; Roger Pau Monné Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano Stabellini ; Boris Ostrovsky Subject: Re: [Xen-devel] [PATCH 2/4]

Re: [Xen-devel] [PATCH 1/2] x86/mm: factor out the code for shattering an l3 PTE

On 07.12.2019 19:20, Xia, Hongyan wrote: > On Fri, 2019-12-06 at 17:50 +, Andrew Cooper wrote: >> On 06/12/2019 15:53, Hongyan Xia wrote: >>> +/* Shatter an l3 entry and populate l2. If virt is passed in, also >>> do flush. */ >>> +static void shatter_l3e(l3_pgentry_t *pl3e, l2_pgentry_t *l2t,

Re: [Xen-devel] XSA-255 and Arm

Sorry I forgot to CC xen-devel. On 09/12/2019 13:13, Julien Grall wrote: Hi all, I was looking at the Grant Table code over the week-end and noticed thart XSA-255 [1] introduced some unintended consequences on Arm. Since the XSA, gnttab_map_frame() will remove the previous mapping (if any)

Re: [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU

On 26.09.2019 17:23, Jürgen Groß wrote: > On 25.09.19 17:27, Jan Beulich wrote: >> There's nothing to restore here if there's no FPU in the first place. >> >> Signed-off-by: Jan Beulich > > Release-acked-by: Juergen Gross While I've committed the change to the unstable branch, making use of

Re: [Xen-devel] [PATCH 3/4] xen/interface: don't discard pending work in FRONT/BACK_RING_ATTACH

> -Original Message- > From: Xen-devel On Behalf Of > Jürgen Groß > Sent: 09 December 2019 11:52 > To: Roger Pau Monné ; Durrant, Paul > > Cc: xen-devel@lists.xenproject.org; Boris Ostrovsky > ; Stefano Stabellini ; > linux-ker...@vger.kernel.org > Subject: Re: [Xen-devel] [PATCH 3/4]

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Roger Pau Monné > Sent: 09 December 2019 12:26 > To: Durrant, Paul > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Juergen > Gross ; Stefano Stabellini ; > Boris Ostrovsky > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH for-4.13] xen: Drop bogus BOOLEAN definitions, TRUE and FALSE

Hi Jan, On 09/12/2019 12:11, Jan Beulich wrote: On 06.12.2019 22:02, Andrew Cooper wrote: On 12/11/2019 14:03, Jan Beulich wrote: Bottom line - I'm half convinced and willing to give my ack, but I'm not convinced you truly thought through the longer term consequences. I'd therefore be far

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On Mon, Dec 09, 2019 at 12:01:38PM +, Durrant, Paul wrote: > > -Original Message- > > From: Roger Pau Monné > > Sent: 09 December 2019 11:39 > > To: Durrant, Paul > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Juergen > > Gross ; Stefano Stabellini ; > > Boris

Re: [Xen-devel] [PATCH 4/4] xen-blkback: support dynamic unbind/bind

> -Original Message- > From: Roger Pau Monné > Sent: 09 December 2019 12:17 > To: Durrant, Paul > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Konrad > Rzeszutek Wilk ; Jens Axboe ; > Boris Ostrovsky ; Juergen Gross > ; Stefano Stabellini > Subject: Re: [PATCH 4/4]

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 12:09 > To: Durrant, Paul ; Roger Pau Monné > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano > Stabellini ; Boris Ostrovsky > > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH 4/4] xen-blkback: support dynamic unbind/bind

On Thu, Dec 05, 2019 at 02:01:23PM +, Paul Durrant wrote: > By simply re-attaching to shared rings during connect_ring() rather than > assuming they are freshly allocated (i.e assuming the counters are zero) > it is possible for vbd instances to be unbound and re-bound from and to >

Re: [Xen-devel] [PATCH for-4.13] xen: Drop bogus BOOLEAN definitions, TRUE and FALSE

On 06.12.2019 22:02, Andrew Cooper wrote: > On 12/11/2019 14:03, Jan Beulich wrote: >> Bottom line - I'm half convinced and willing to give my ack, but >> I'm not convinced you truly thought through the longer term >> consequences. I'd therefore be far happier to see this patch >> split into a

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On 09.12.19 13:03, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 11:55 To: Roger Pau Monné ; Durrant, Paul Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano Stabellini ; Boris Ostrovsky Subject: Re: [Xen-devel] [PATCH 2/4]

Re: [Xen-devel] [PATCH 1/3] x86: relax GDT check in arch_set_info_guest()

On 06.12.2019 20:51, Andrew Cooper wrote: > On 06/12/2019 11:32, Jan Beulich wrote: >> On 06.12.2019 11:25, Andrew Cooper wrote: >>> On 06/12/2019 10:14, Jan Beulich wrote: It is wrong for us to check frames beyond the guest specified limit. Signed-off-by: Jan Beulich >>> I don't

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 11:55 > To: Roger Pau Monné ; Durrant, Paul > > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Stefano > Stabellini ; Boris Ostrovsky > > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

> -Original Message- > From: Roger Pau Monné > Sent: 09 December 2019 11:39 > To: Durrant, Paul > Cc: linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org; Juergen > Gross ; Stefano Stabellini ; > Boris Ostrovsky > Subject: Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is

Re: [Xen-devel] [PATCH 1/4] xenbus: move xenbus_dev_shutdown() into frontend code...

On 09.12.19 12:55, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 11:34 To: Durrant, Paul ; linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org Cc: Boris Ostrovsky ; Stefano Stabellini Subject: Re: [PATCH 1/4] xenbus: move

Re: [Xen-devel] [PATCH 1/4] xenbus: move xenbus_dev_shutdown() into frontend code...

> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 11:34 > To: Durrant, Paul ; linux-ker...@vger.kernel.org; > xen-devel@lists.xenproject.org > Cc: Boris Ostrovsky ; Stefano Stabellini > > Subject: Re: [PATCH 1/4] xenbus: move xenbus_dev_shutdown() into frontend > code...

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

On 09.12.19 12:39, Roger Pau Monné wrote: On Thu, Dec 05, 2019 at 02:01:21PM +, Paul Durrant wrote: Only force state to closed in the case when the toolstack may need to clean up. This can be detected by checking whether the state in xenstore has been set to closing prior to device removal.

Re: [Xen-devel] [PATCH 3/4] xen/interface: don't discard pending work in FRONT/BACK_RING_ATTACH

On 09.12.19 12:41, Roger Pau Monné wrote: On Thu, Dec 05, 2019 at 02:01:22PM +, Paul Durrant wrote: Currently these macros will skip over any requests/responses that are added to the shared ring whilst it is detached. This, in general, is not a desirable semantic since most frontend

Re: [Xen-devel] [PATCH v4] gnttab: don't expose host physical address without need

On 06.12.2019 20:48, Andrew Cooper wrote: > On 05/12/2019 16:57, Jan Beulich wrote: >> On 05.12.2019 16:47, Andrew Cooper wrote: >>> On 05/12/2019 15:34, Jan Beulich wrote: Translated domains shouldn't see host physical addresses. While the address is also not supposed to be handed back

[Xen-devel] [PATCH v2 1/2] x86/mm: factor out the code for shattering an l3 PTE

map_pages_to_xen and modify_xen_mappings are performing almost exactly the same operations when shattering an l3 PTE, the only difference being whether we want to flush. Signed-off-by: Hongyan Xia --- Changes in v2: - improve asm. - re-read pl3e from memory when taking the lock. - move the

[Xen-devel] [PATCH v2 2/2] x86/mm: factor out the code for shattering an l2 PTE

map_pages_to_xen and modify_xen_mappings are performing almost exactly the same operations when shattering an l2 PTE, the only difference being whether we want to flush. Signed-off-by: Hongyan Xia --- Changes in v2: - improve asm. - re-read pl2e from memory when taking the lock. - move the

[Xen-devel] [PATCH v2 0/2] Refactor super page shattering

map_pages_to_xen and modify_xen_mappings use almost exactly the same page shattering logic, and the code is mingled with other PTE manipulations so it is less obvious that the intention is page shattering. Factor out the functions to make them reusable and to make the intention more obvious. Of

  1   2   >