Re: [Xen-devel] Problem booting Debian buster on arndale

2019-12-09 Thread Julien Grall
Hi, On 09/12/2019 11:39, Ian Jackson wrote: Julien Grall writes ("Re: Problem booting Debian buster on arndale"): Looking at the command line for Linux, we don't pass clk_ignore_unused. Without it, the Linux may disable the clock of the UART if it wasn't shared with another device. This would

Re: [Xen-devel] [PATCH 3/4] xen/interface: don't discard pending work in FRONT/BACK_RING_ATTACH

2019-12-09 Thread Roger Pau Monné
On Thu, Dec 05, 2019 at 02:01:22PM +, Paul Durrant wrote: > Currently these macros will skip over any requests/responses that are > added to the shared ring whilst it is detached. This, in general, is not > a desirable semantic since most frontend implementations will eventually > block

Re: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed

2019-12-09 Thread Roger Pau Monné
On Thu, Dec 05, 2019 at 02:01:21PM +, Paul Durrant wrote: > Only force state to closed in the case when the toolstack may need to > clean up. This can be detected by checking whether the state in xenstore > has been set to closing prior to device removal. I'm not sure I see the point of this,

Re: [Xen-devel] Problem booting Debian buster on arndale

2019-12-09 Thread Ian Jackson
Julien Grall writes ("Re: Problem booting Debian buster on arndale"): > Looking at the command line for Linux, we don't pass clk_ignore_unused. > Without it, the Linux may disable the clock of the UART if it wasn't > shared with another device. This would explain the sudden loss of the >

Re: [Xen-devel] [PATCH 1/4] xenbus: move xenbus_dev_shutdown() into frontend code...

2019-12-09 Thread Jürgen Groß
On 05.12.19 15:01, Paul Durrant wrote: ...and make it static xenbus_dev_shutdown() is seemingly intended to cause clean shutdown of PV frontends when a guest is rebooted. Indeed the function waits for a conpletion which is only set by a call to xenbus_frontend_closed(). This patch removes the

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

2019-12-09 Thread SeongJae Park
On Mon, 9 Dec 2019 12:08:10 +0100 "Jürgen Groß" wrote: >On 09.12.19 11:52, SeongJae Park wrote: >> On Mon, 9 Dec 2019 11:15:22 +0100 "Jürgen Groß" wrote: >> >>> On 09.12.19 10:46, Durrant, Paul wrote: > -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 09:39

[Xen-devel] [PATCH v3] CODING_STYLE: Document how to handle unexpected conditions

2019-12-09 Thread George Dunlap
It's not always clear what the best way is to handle unexpected conditions: whether with ASSERT(), domain_crash(), BUG_ON(), or some other method. All methods have a risk of introducing security vulnerabilities and unnecessary instabilities to production systems. Provide guidelines for different

[Xen-devel] [ovmf test] 144637: all pass - PUSHED

2019-12-09 Thread osstest service owner
flight 144637 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144637/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 804666c86e7b6f04fe5c5cfdb13199c19e0e99b0 baseline version: ovmf

Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge

2019-12-09 Thread Paolo Bonzini
On 09/12/19 11:56, Philippe Mathieu-Daudé wrote: > > I think so, but with PC_I440FX -> PCI_I440FX ;) > > It would be cleaner to pass the CONFIG_XEN_PCI_PASSTHROUGH variable to > Kconfig and use it (use 'depends on XEN_PCI_PASSTHROUGH'). > > This can be another step, so if this series looks OK

Re: [Xen-devel] [PATCH] x86/iommu: remove usage of {set/clear}_identity_p2m_entry against PV domains

2019-12-09 Thread Roger Pau Monné
On Thu, Dec 05, 2019 at 12:24:29PM +0100, Jan Beulich wrote: > On 02.08.2019 11:22, Roger Pau Monne wrote: > > Switch rmrr_identity_mapping to use iommu_{un}map in order to > > establish RMRR mappings for PV domains, like it's done in > > arch_iommu_hwdom_init. This solves the issue of a PV

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

2019-12-09 Thread Lars Kurth
On 06/12/2019, 09:51, "Jan Beulich" wrote: On 06.12.2019 00:41, Lars Kurth wrote: > I propose to add the following section to code-review-guide.md > > > ## Problematic Patch Reviews > > A typical waterfall software development process is sequential with the

Re: [Xen-devel] [PATCH v3 2/3] xen/banner: Drop the fig-to-oct.py script

2019-12-09 Thread George Dunlap
On 12/7/19 9:16 PM, Andrew Cooper wrote: > The script is 664 rather than 775, so the banner conversion doesn't actually > work if $(PYTHON) is empty: > > /bin/sh: tools/fig-to-oct.py: Permission denied > make[3]: *** [include/xen/compile.h] Error 126 > make[3]: Leaving directory

Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge

2019-12-09 Thread Philippe Mathieu-Daudé
On 12/9/19 11:42 AM, Paolo Bonzini wrote: On 09/12/19 11:10, Durrant, Paul wrote: Signed-off-by: Philippe Mathieu-Daudé --- v3: Only default with Xen (Alex Williamson) I did not used 'depends on XEN' as suggested by Alex but 'default y if XEN', so one can build XEN without this feature (for

Re: [Xen-devel] [PATCH v3 3/3] xen/build: Automatically locate a suitable python interpreter

2019-12-09 Thread George Dunlap
On 12/7/19 9:16 PM, Andrew Cooper wrote: > Needing to pass PYTHON=python3 into hypervisor builds is irritating and > unnecessary. Locate a suitable interpreter automatically, defaulting to Py3 > if it is available. > > Reported-by: Steven Haigh > Signed-off-by: Andrew Cooper > --- > CC: George

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

2019-12-09 Thread Jürgen Groß
On 09.12.19 11:52, SeongJae Park wrote: On Mon, 9 Dec 2019 11:15:22 +0100 "Jürgen Groß" wrote: On 09.12.19 10:46, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 09:39 To: Park, Seongjae ; ax...@kernel.dk; konrad.w...@oracle.com; roger@citrix.com

Re: [Xen-devel] [PATCH v3 4/4] x86/apic: allow enabling x2APIC mode regardless of interrupt remapping

2019-12-09 Thread Roger Pau Monné
On Thu, Dec 05, 2019 at 10:45:59AM +0100, Jan Beulich wrote: > On 04.12.2019 17:20, Roger Pau Monne wrote: > > +switch ( iommu_enable_x2apic() ) > > { > > +case 0: > > +iommu_x2apic_enabled = true; > > +break; > > + > > +case -ENXIO: /*

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

2019-12-09 Thread SeongJae Park
On Mon, 9 Dec 2019 11:15:22 +0100 "Jürgen Groß" wrote: >On 09.12.19 10:46, Durrant, Paul wrote: >>> -Original Message- >>> From: Jürgen Groß >>> Sent: 09 December 2019 09:39 >>> To: Park, Seongjae ; ax...@kernel.dk; >>> konrad.w...@oracle.com; roger@citrix.com >>> Cc:

Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge

2019-12-09 Thread Paolo Bonzini
On 09/12/19 11:10, Durrant, Paul wrote: >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> v3: Only default with Xen (Alex Williamson) >> >> I did not used 'depends on XEN' as suggested by Alex but >> 'default y if XEN', so one can build XEN without this feature >> (for example, on other ARCH

Re: [Xen-devel] [PATCH v3 1/3] xen/flask: Drop the gen-policy.py script

2019-12-09 Thread George Dunlap
On Sat, Dec 7, 2019 at 9:17 PM Andrew Cooper wrote: > > The script is Python 2 specific, and fails with string/binary issues with > Python 3: > > Traceback (most recent call last): > File "gen-policy.py", line 14, in > for char in sys.stdin.read(): > File

Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge

2019-12-09 Thread Paolo Bonzini
On 09/12/19 10:50, Philippe Mathieu-Daudé wrote: > Add the XEN_IGD_PASSTHROUGH Kconfig option. > > Xen build has that option selected by default. Non-Xen builds now > have to select this feature manually. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v3: Only default with Xen (Alex

Re: [Xen-devel] Problem booting Debian buster on arndale

2019-12-09 Thread Julien Grall
Hi, On 06/12/2019 18:08, Ian Jackson wrote: Julien Grall writes ("Re: Problem booting Debian buster on arndale"): On 06/12/2019 16:47, Ian Jackson wrote: It seems to have hung during boot. NB that I don't know whether this is a one-off. Looking at [1], most of the recent flight have

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

2019-12-09 Thread Jürgen Groß
On 09.12.19 11:23, SeongJae Park wrote: On Mon, 9 Dec 2019 10:39:02 +0100 Juergen wrote: On 09.12.19 09:58, SeongJae Park wrote: Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and be increased on demand while processing the I/O requests.

Re: [Xen-devel] [PATCH v3 3/4] x86/smp: check APIC ID on AP bringup

2019-12-09 Thread Roger Pau Monné
On Thu, Dec 05, 2019 at 10:33:44AM +0100, Jan Beulich wrote: > On 04.12.2019 17:20, Roger Pau Monne wrote: > > Check that the processor to be woken up APIC ID is addressable in the > > current APIC mode. > > > > Note that in practice systems with APIC IDs > 255 should already have > > x2APIC

Re: [Xen-devel] [PATCH v3 2/4] x86/apic: force phys mode if interrupt remapping is disabled

2019-12-09 Thread Roger Pau Monné
On Thu, Dec 05, 2019 at 10:32:34AM +0100, Jan Beulich wrote: > On 04.12.2019 17:20, Roger Pau Monne wrote: > > Cluster mode can only be used with interrupt remapping support, since > > the top 16bits of the APIC ID are filled with the cluster ID, and > > hence on systems where the physical ID is

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

2019-12-09 Thread SeongJae Park
On Mon, 9 Dec 2019 10:39:02 +0100 Juergen wrote: >On 09.12.19 09:58, SeongJae Park wrote: >> Each `blkif` has a free pages pool for the grant mapping. The size of >> the pool starts from zero and be increased on demand while processing >> the I/O requests. If current I/O requests handling

Re: [Xen-devel] [PATCH v3] x86: do not enable global pages when virtualized on AMD hardware

2019-12-09 Thread Roger Pau Monné
On Wed, Dec 04, 2019 at 06:05:11PM +0100, Jan Beulich wrote: > On 04.12.2019 17:18, Roger Pau Monné wrote: > > On Wed, Dec 04, 2019 at 05:11:42PM +0100, Jan Beulich wrote: > >> On 04.12.2019 16:12, Roger Pau Monne wrote: > >>> @@ -130,7 +143,7 @@ unsigned long pv_make_cr4(const struct vcpu *v) >

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

2019-12-09 Thread Jürgen Groß
On 09.12.19 10:46, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 09:39 To: Park, Seongjae ; ax...@kernel.dk; konrad.w...@oracle.com; roger@citrix.com Cc: linux-bl...@vger.kernel.org; linux-ker...@vger.kernel.org; Durrant, Paul ;

Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge

2019-12-09 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of > Philippe Mathieu-Daudé > Sent: 09 December 2019 09:50 > To: qemu-de...@nongnu.org > Cc: Thomas Huth ; Stefano Stabellini > ; Michael S. Tsirkin ; Paul > Durrant ; Markus Armbruster ; Alex > Williamson ; Marcel Apfelbaum > ; Paolo

Re: [Xen-devel] [PATCH-for-5.0 v3 5/6] hw/pci-host/i440fx: Extract the IGD passthrough host bridge device

2019-12-09 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of > Philippe Mathieu-Daudé > Sent: 09 December 2019 09:50 > To: qemu-de...@nongnu.org > Cc: Thomas Huth ; Stefano Stabellini > ; Michael S. Tsirkin ; Paul > Durrant ; Markus Armbruster ; Alex > Williamson ; Marcel Apfelbaum > ; Paolo

Re: [Xen-devel] [PATCH-for-5.0 v3 4/6] hw/pci-host/i440fx: Use definitions instead of magic values

2019-12-09 Thread Thomas Huth
On 09/12/2019 10.50, Philippe Mathieu-Daudé wrote: > Use definitions from "hw/pci/pci_regs.h". > This also helps when using git-grep. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/i440fx.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git

Re: [Xen-devel] [PATCH-for-5.0 v3 3/6] hw/pci-host/i440fx: Use size_t to iterate over ARRAY_SIZE()

2019-12-09 Thread Thomas Huth
On 09/12/2019 10.49, Philippe Mathieu-Daudé wrote: > We don't enforce the -Wsign-conversion CPPFLAG, but it doesn't hurt > to avoid this warning: > > warning: implicit conversion changes signedness: 'int' to 'size_t' (aka > 'unsigned long') [-Wsign-conversion] > > Signed-off-by: Philippe

Re: [Xen-devel] [PATCH-for-5.0 v3 2/6] hw/pci-host/i440fx: Extract PCII440FXState to "hw/pci-host/i440fx.h"

2019-12-09 Thread Thomas Huth
On 09/12/2019 10.49, Philippe Mathieu-Daudé wrote: > Make the PCII440FXState structure public, so it can be used out of > this source file. This will allow us to extract the IGD Passthrough > Host Bridge, which is a children of the TYPE_I440FX_PCI_DEVICE. > > Signed-off-by: Philippe Mathieu-Daudé

Re: [Xen-devel] [PATCH-for-5.0 v3 1/6] hw/pci-host/i440fx: Correct the header description

2019-12-09 Thread Thomas Huth
On 09/12/2019 10.49, Philippe Mathieu-Daudé wrote: > Missed during the refactor in commits 14a026dd58 and 0f25d865a, > this file is now only about the i440FX chipset. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/i440fx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge

2019-12-09 Thread Philippe Mathieu-Daudé
Add the XEN_IGD_PASSTHROUGH Kconfig option. Xen build has that option selected by default. Non-Xen builds now have to select this feature manually. Signed-off-by: Philippe Mathieu-Daudé --- v3: Only default with Xen (Alex Williamson) I did not used 'depends on XEN' as suggested by Alex but

[Xen-devel] [PATCH-for-5.0 v3 5/6] hw/pci-host/i440fx: Extract the IGD passthrough host bridge device

2019-12-09 Thread Philippe Mathieu-Daudé
We can use a i440FX without the IGD passthrough host bridge. Extract it into a new file, 'hw/pci-host/igd_pt.c'. Signed-off-by: Philippe Mathieu-Daudé --- v3: - Rename as 'xen_igd_pt.c' (Alex Williamson) - Add an entry in MAINTAINERS::Xen --- hw/pci-host/i440fx.c | 84

[Xen-devel] [PATCH-for-5.0 v3 0/6] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through

2019-12-09 Thread Philippe Mathieu-Daudé
Introduce a kconfig selector to allow builds without Intel Integrated Graphics Device GPU PCIe passthrough. This device is enabled by default on the Xen build. v3: - Make it Xen specific v2: - do not mix with vfio code (Alex) - extract to different file to avoid #ifdef (Thomas) Philippe

[Xen-devel] [PATCH-for-5.0 v3 4/6] hw/pci-host/i440fx: Use definitions instead of magic values

2019-12-09 Thread Philippe Mathieu-Daudé
Use definitions from "hw/pci/pci_regs.h". This also helps when using git-grep. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/i440fx.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c index

[Xen-devel] [PATCH-for-5.0 v3 1/6] hw/pci-host/i440fx: Correct the header description

2019-12-09 Thread Philippe Mathieu-Daudé
Missed during the refactor in commits 14a026dd58 and 0f25d865a, this file is now only about the i440FX chipset. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/i440fx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c index

[Xen-devel] [PATCH-for-5.0 v3 3/6] hw/pci-host/i440fx: Use size_t to iterate over ARRAY_SIZE()

2019-12-09 Thread Philippe Mathieu-Daudé
We don't enforce the -Wsign-conversion CPPFLAG, but it doesn't hurt to avoid this warning: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion] Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/i440fx.c | 5 ++--- 1 file changed, 2

[Xen-devel] [PATCH-for-5.0 v3 2/6] hw/pci-host/i440fx: Extract PCII440FXState to "hw/pci-host/i440fx.h"

2019-12-09 Thread Philippe Mathieu-Daudé
Make the PCII440FXState structure public, so it can be used out of this source file. This will allow us to extract the IGD Passthrough Host Bridge, which is a children of the TYPE_I440FX_PCI_DEVICE. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci-host/i440fx.h | 19 +--

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

2019-12-09 Thread Durrant, Paul
> -Original Message- > From: Jürgen Groß > Sent: 09 December 2019 09:39 > To: Park, Seongjae ; ax...@kernel.dk; > konrad.w...@oracle.com; roger@citrix.com > Cc: linux-bl...@vger.kernel.org; linux-ker...@vger.kernel.org; Durrant, > Paul ; sj38.p...@gmail.com; xen- >

Re: [Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

2019-12-09 Thread Jürgen Groß
On 09.12.19 09:58, SeongJae Park wrote: Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and be increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has passed since last I/O

[Xen-devel] [PATCH v3 1/1] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-09 Thread SeongJae Park
From: SeongJae Park Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and be increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has passed since last I/O requests handling, it

[Xen-devel] [PATCH v3 0/1] xen/blkback: Squeeze page pools if a memory pressure

2019-12-09 Thread SeongJae Park
Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and be increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has passed since last I/O requests handling, it checks and shrinks the

[Xen-devel] [PATCH] x86/microcode: Support builtin CPU microcode

2019-12-09 Thread Eslam Elnikety
Xen relies on boot modules to perform early microcode updates. This commit adds another mode, namely "builtin" via the BUILTIN_UCODE config parameter. If set, the Xen image itself will contain the microcode updates. Upon boot, Xen inspects its image for microcode blobs and performs the update. A

[Xen-devel] [libvirt test] 144636: regressions - trouble: blocked/broken/fail/pass

2019-12-09 Thread osstest service owner
flight 144636 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/144636/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt broken build-i386-libvirt4

[Xen-devel] [xen-unstable test] 144635: trouble: blocked/broken/fail/pass

2019-12-09 Thread osstest service owner
flight 144635 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/144635/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd broken

<    1   2