Re: [Xen-devel] [PATCH 5/6] xen/tasklet: Return -ERESTART from continue_hypercall_on_cpu()

2019-12-10 Thread Jan Beulich
On 10.12.2019 18:55, Andrew Cooper wrote: > On 10/12/2019 08:55, Jan Beulich wrote: >> On 09.12.2019 18:49, Andrew Cooper wrote: >>> On 09/12/2019 16:52, Jan Beulich wrote: On 05.12.2019 23:30, Andrew Cooper wrote: > Some hypercalls tasklets want to create a continuation, rather than fail

[Xen-devel] clock source in PV Linux

2019-12-10 Thread Jan Beulich
Jürgen, Boris, I've noticed <6>clocksource: Switched to clocksource tsc as the final clocksource related boot message in a PV Dom0's log with 5.4.2. Is it intentional that it's not the "xen" one that gets used by default? Thanks, Jan ___ Xen-devel

[Xen-devel] [xen-4.13-testing test] 144673: tolerable FAIL - PUSHED

2019-12-10 Thread osstest service owner
flight 144673 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144673/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail REGR. vs. 144609

[Xen-devel] [ovmf test] 144683: regressions - FAIL

2019-12-10 Thread osstest service owner
flight 144683 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144683/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 144637 build-i386-xsm

[Xen-devel] [PATCH v6 2/3] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-10 Thread SeongJae Park
Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and be increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has passed since last I/O requests handling, it checks and shrinks the

[Xen-devel] [PATCH v6 3/3] xen/blkback: Remove unnecessary static variable name prefixes

2019-12-10 Thread SeongJae Park
A few of static variables in blkback have 'xen_blkif_' prefix, though it is unnecessary for static variables. This commit removes such prefixes. Signed-off-by: SeongJae Park --- drivers/block/xen-blkback/blkback.c | 37 + 1 file changed, 17 insertions(+), 20

[Xen-devel] [PATCH v6 1/3] xenbus/backend: Add memory pressure handler callback

2019-12-10 Thread SeongJae Park
Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging for large systems having dynamic resource utilization patterns.

[Xen-devel] [PATCH v6 0/2] xenbus/backend: Add a memory pressure handler callback

2019-12-10 Thread SeongJae Park
Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging for large systems having dynamic resource utilization patterns.

Re: [Xen-devel] [PATCH v5 2/2] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-10 Thread SeongJae Park
On Tue, 10 Dec 2019 12:04:32 +0100 "Roger Pau Monné" wrote: > > Each `blkif` has a free pages pool for the grant mapping. The size of > > the pool starts from zero and be increased on demand while processing > > the I/O requests. If current I/O requests handling is finished or 100 > >

[Xen-devel] [ovmf bisection] complete build-i386-xsm

2019-12-10 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-i386-xsm testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree:

Re: [Xen-devel] [PATCH v5 1/2] xenbus/backend: Add memory pressure handler callback

2019-12-10 Thread SeongJae Park
On Tue, 10 Dec 2019 11:16:35 +0100 "Roger Pau Monné" wrote: > > Granting pages consumes backend system memory. In systems configured > > with insufficient spare memory for those pages, it can cause a memory > > pressure situation. However, finding the optimal amount of the spare > > memory is

[Xen-devel] [qemu-mainline test] 144671: tolerable FAIL - PUSHED

2019-12-10 Thread osstest service owner
flight 144671 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/144671/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds16 guest-start/debian.repeat fail REGR. vs. 144591 Tests which did not

[Xen-devel] [xen-unstable test] 144668: tolerable FAIL - PUSHED

2019-12-10 Thread osstest service owner
flight 144668 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/144668/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 144631 test-amd64-i386-xl-qemuu-win7-amd64

[Xen-devel] [ovmf test] 144676: regressions - FAIL

2019-12-10 Thread osstest service owner
flight 144676 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144676/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 144637 build-i386-xsm

Re: [Xen-devel] [PATCH] x86/microcode: Support builtin CPU microcode

2019-12-10 Thread Eslam Elnikety
On 10.12.19 10:37, Jan Beulich wrote: On 09.12.2019 09:41, Eslam Elnikety wrote: --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -2113,7 +2113,7 @@ logic applies: active by default. ### ucode (x86) -> `= List of [ | scan=, nmi= ]` +> `= List of [

Re: [Xen-devel] [PATCH] x86/microcode: Support builtin CPU microcode

2019-12-10 Thread Eslam Elnikety
On 10.12.19 10:21, Jan Beulich wrote: On 09.12.2019 22:49, Eslam Elnikety wrote: On 09.12.19 16:19, Andrew Cooper wrote: On 09/12/2019 08:41, Eslam Elnikety wrote: --- /dev/null +++ b/xen/arch/x86/microcode/Makefile @@ -0,0 +1,40 @@ +# Copyright (C) 2019 Amazon.com, Inc. or its affiliates. +#

[Xen-devel] [seabios test] 144665: tolerable FAIL - PUSHED

2019-12-10 Thread osstest service owner
flight 144665 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/144665/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 144198 test-amd64-amd64-xl-qemuu-ws16-amd64 17

[Xen-devel] [PATCH AUTOSEL 4.19 120/177] xen/gntdev: Use select for DMA_SHARED_BUFFER

2019-12-10 Thread Sasha Levin
From: Jason Gunthorpe [ Upstream commit fa6614d8ef13c63aac52ad7c07c5e69ce4aba3dd ] DMA_SHARED_BUFFER can not be enabled by the user (it represents a library set in the kernel). The kconfig convention is to use select for such symbols so they are turned on implicitly when the user enables a

[Xen-devel] [PATCH AUTOSEL 5.4 234/350] xen/gntdev: Use select for DMA_SHARED_BUFFER

2019-12-10 Thread Sasha Levin
From: Jason Gunthorpe [ Upstream commit fa6614d8ef13c63aac52ad7c07c5e69ce4aba3dd ] DMA_SHARED_BUFFER can not be enabled by the user (it represents a library set in the kernel). The kconfig convention is to use select for such symbols so they are turned on implicitly when the user enables a

[Xen-devel] [xen-unstable-smoke test] 144672: tolerable all pass - PUSHED

2019-12-10 Thread osstest service owner
flight 144672 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/144672/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [ovmf test] 144661: regressions - FAIL

2019-12-10 Thread osstest service owner
flight 144661 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144661/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 144637 build-i386-xsm

[Xen-devel] [xen-4.13-testing test] 144655: trouble: broken/fail/pass

2019-12-10 Thread osstest service owner
flight 144655 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144655/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-4 broken

[Xen-devel] [tip: x86/cleanups] x86/Kconfig: Fix Kconfig indentation

2019-12-10 Thread tip-bot2 for Krzysztof Kozlowski
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: b03b016fe54edd1b527d749e139b2fc9407ac414 Gitweb: https://git.kernel.org/tip/b03b016fe54edd1b527d749e139b2fc9407ac414 Author:Krzysztof Kozlowski AuthorDate:Thu, 21 Nov 2019 04:21:09 +01:00

Re: [Xen-devel] [PATCH 5/6] xen/tasklet: Return -ERESTART from continue_hypercall_on_cpu()

2019-12-10 Thread Andrew Cooper
On 10/12/2019 08:55, Jan Beulich wrote: > On 09.12.2019 18:49, Andrew Cooper wrote: >> On 09/12/2019 16:52, Jan Beulich wrote: >>> On 05.12.2019 23:30, Andrew Cooper wrote: Some hypercalls tasklets want to create a continuation, rather than fail the hypercall with a hard error. By

[Xen-devel] [qemu-mainline test] 144650: trouble: broken/fail/pass

2019-12-10 Thread osstest service owner
flight 144650 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/144650/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt broken

[Xen-devel] baroque0 (was Re: [xen-4.13-testing test] 144645: trouble: broken/fail/pass)

2019-12-10 Thread Ian Jackson
Jürgen Groß writes ("Re: [Xen-devel] [xen-4.13-testing test] 144645: trouble: broken/fail/pass"): > On 10.12.19 10:06, osstest service owner wrote: > > flight 144645 xen-4.13-testing real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/144645/ > > Something wrong with baroque0? > >

Re: [Xen-devel] [PATCH for-next 7/7] x86: implement Hyper-V clock source

2019-12-10 Thread Jan Beulich
On 25.10.2019 11:16, Wei Liu wrote: > @@ -614,6 +615,89 @@ static struct platform_timesource __initdata > plt_xen_timer = > }; > #endif > > +#ifdef CONFIG_HYPERV_GUEST > +/ > + * PLATFORM TIMER 6: HYPER-V REFERENCE TSC I don't think

Re: [Xen-devel] [PATCH for-next 6/7] x86/hyperv: provide hyperv_guest variable

2019-12-10 Thread Jan Beulich
On 25.10.2019 11:16, Wei Liu wrote: > --- a/xen/arch/x86/guest/hyperv/hyperv.c > +++ b/xen/arch/x86/guest/hyperv/hyperv.c > @@ -24,6 +24,7 @@ > #include > > struct ms_hyperv_info ms_hyperv; > +bool hyperv_guest; With __read_mostly added here (perhaps also in the earlier patch for the

[Xen-devel] [ovmf bisection] complete build-amd64

2019-12-10 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-amd64 testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen

Re: [Xen-devel] [PATCH for-next 5/7] x86: use running_on_hypervisor to gate hypervisor_setup

2019-12-10 Thread Jan Beulich
On 25.10.2019 11:16, Wei Liu wrote: > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -1577,7 +1577,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) > max_cpus = nr_cpu_ids; > } > > -if ( xen_guest ) > +if ( running_on_hypervisor ) >

Re: [Xen-devel] [PATCH for-next 4/7] x86: add a comment regarding the location of hypervisor_probe

2019-12-10 Thread Jan Beulich
On 25.10.2019 11:16, Wei Liu wrote: > Signed-off-by: Wei Liu Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-next 3/7] x86/hyperv: extract more information from Hyper-V

2019-12-10 Thread Jan Beulich
On 25.10.2019 11:16, Wei Liu wrote: > --- a/xen/arch/x86/guest/hyperv/hyperv.c > +++ b/xen/arch/x86/guest/hyperv/hyperv.c > @@ -21,6 +21,9 @@ > #include > > #include > +#include > + > +struct ms_hyperv_info ms_hyperv; > > bool __init hyperv_probe(void) > { > @@ -36,6 +39,17 @@ bool

[Xen-devel] [PATCH v3 19/22] golang/xenlight: implement keyed union Go to C marshaling

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Since the C union cannot be directly populated, populate the fields of the corresponding C struct defined in the cgo preamble, and then copy that struct as bytes into the byte slice that Go uses as the union. Signed-off-by: Nick Rosbrook ---

[Xen-devel] [PATCH v3 21/22] golang/xenlight: revise use of Context type

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Remove the exported global context variable, 'Ctx.' Generally, it is better to not export global variables for use through a Go package. However, there are some exceptions that can be found in the standard library. Add a NewContext function instead, and remove the Open,

[Xen-devel] [PATCH v3 18/22] golang/xenlight: begin Go to C type marshaling

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Implement conversion of basic type conversions such as strings and integer types in toC functions. Signed-off-by: Nick Rosbrook --- tools/golang/xenlight/gengotypes.py | 80 ++ tools/golang/xenlight/helpers.gen.go | 1015 ++ 2 files changed, 1095

[Xen-devel] [PATCH v3 22/22] golang/xenlight: add error return type to Context.Cpupoolinfo

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook A previous commit that removed Context.CheckOpen revealed an ineffectual assignent to err in Context.Cpupoolinfo, as there is no error return type. Since it appears that the intent is to return an error here, add an error return value to the function signature.

[Xen-devel] [PATCH v3 14/22] golang/xenlight: remove no-longer used type MemKB

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Signed-off-by: Nick Rosbrook Acked-by: George Dunlap --- tools/golang/xenlight/xenlight.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go index 8f41047726..fb1c6d9e51 100644 ---

[Xen-devel] [PATCH v3 20/22] golang/xenlight: implement array Go to C marshaling

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Signed-off-by: Nick Rosbrook --- tools/golang/xenlight/gengotypes.py | 44 +++- tools/golang/xenlight/helpers.gen.go | 359 +++ 2 files changed, 402 insertions(+), 1 deletion(-) diff --git a/tools/golang/xenlight/gengotypes.py

[Xen-devel] [PATCH v3 06/22] golang/xenlight: define StringList builtin type

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Define StringList as []string an implement fromC and toC functions. Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap --- Changes in v2: - Define fromC with a pointer receiver since a newly-allocated slice is being assigned to the StringList. ---

[Xen-devel] [PATCH v3 12/22] golang/xenlight: re-factor Hwcap type implementation

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Re-define Hwcap as [8]uint32, and implement toC function. Also, re-name and modify signature of toGo function to fromC. Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap --- Changes in v2: - Fix comment in fromC since an array is being used now, not a slice. - Use a

[Xen-devel] [PATCH v3 16/22] golang/xenlight: implement keyed union C to Go marshaling

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Switch over union key to determine how to populate 'union' in Go struct. Since the unions of C types cannot be directly accessed in cgo, use a typeof trick to typedef a struct in the cgo preamble that is analagous to each inner struct of a keyed union. For example, to define

[Xen-devel] [PATCH v3 15/22] golang/xenlight: begin C to Go type marshaling

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Begin implementation of fromC marshaling functions for generated struct types. This includes support for converting fields that are basic primitive types such as string and integer types, nested anonymous structs, nested libxl structs, and libxl built-in types. This patch

[Xen-devel] [PATCH v3 13/22] golang/xenlight: generate structs from the IDL

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Add struct and keyed union generation to gengotypes.py. For keyed unions, use a method similar to gRPC's oneof to interpret C unions as Go types. Meaning, for a given struct with a union field, generate a struct for each sub-struct defined in the union. Then, define an

[Xen-devel] [PATCH v3 17/22] golang/xenlight: implement array C to Go marshaling

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Signed-off-by: Nick Rosbrook --- tools/golang/xenlight/gengotypes.py | 39 +++- tools/golang/xenlight/helpers.gen.go | 300 +++ 2 files changed, 338 insertions(+), 1 deletion(-) diff --git a/tools/golang/xenlight/gengotypes.py

[Xen-devel] [PATCH v3 11/22] golang/xenlight: re-factor Uuid type implementation

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Re-define Uuid as [16]byte and implement fromC, toC, and String functions. Signed-off-by: Nick Rosbrook --- Changes in v3: - In fromC, iterate over the indirect of u instead of creating a slice from the C type. --- tools/golang/xenlight/xenlight.go | 35

[Xen-devel] [PATCH v3 05/22] golang/xenlight: re-name Bitmap marshaling functions

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Re-name and modify signature of toGo function to fromC. The reason for using 'fromC' rather than 'toGo' is that it is not a good idea to define methods on the C types. Also, add error return type to Bitmap's toC function. Finally, as code-cleanup, re-organize the Bitmap

[Xen-devel] [PATCH v3 10/22] golang/xenlight: define CpuidPolicyList builtin type

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Define CpuidPolicyList as a string so that libxl_cpuid_parse_config can be used in the toC function. For now, fromC is a no-op since libxl does not support a way to read a policy, modify it,and then give it back to libxl. Signed-off-by: Nick Rosbrook Reviewed-by: George

[Xen-devel] [PATCH v3 09/22] golang/xenlight: define EvLink builtin as empty struct

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Define EvLink as empty struct as there is currently no reason the internal of this type should be used in Go. Implement fromC and toC functions as no-ops. Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap --- tools/golang/xenlight/xenlight.go | 10 ++ 1

[Xen-devel] [PATCH v3 03/22] golang/xenlight: define Devid type as int

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap --- tools/golang/xenlight/xenlight.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go index 640d82f35f..8ac26e63f0 100644 ---

[Xen-devel] [PATCH v3 01/22] golang/xenlight: generate enum types from IDL

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Introduce gengotypes.py to generate Go code the from IDL. As a first step, implement 'enum' type generation. As a result of the newly-generated code, remove the existing, and now conflicting definitions in xenlight.go. In the case of the Error type, rename the slice 'errors'

[Xen-devel] [PATCH v3 08/22] golang/xenlight: define MsVmGenid builtin type

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Define MsVmGenid as [int(C.LIBXL_MS_VM_GENID_LEN)]byte and implement fromC and toC functions. Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap --- Changes in v3: - In fromC, iterate over the indirect of mvg instead of creating a slice from the C type. ---

[Xen-devel] [PATCH v3 07/22] golang/xenlight: define Mac builtin type

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Define Mac as [6]byte and implement fromC, toC, and String functions. Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap --- Changes in v2: - Fix the format string in String function to use %02x. - Use a value reciever for the toC function. Changes in v3: - Iterate

[Xen-devel] [PATCH v3 02/22] golang/xenlight: define Defbool builtin type

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Define Defbool as struct analagous to the C type, and define the type 'defboolVal' that represent true, false, and default defbool values. Implement Set, Unset, SetIfDefault, IsDefault, Val, and String functions on Defbool so that the type can be used in Go analagously to

[Xen-devel] [PATCH v3 04/22] golang/xenlight: define KeyValueList as empty struct

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook Define KeyValueList as empty struct as there is currently no reason for this type to be available in the Go package. Implement fromC and toC functions as no-ops. Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap --- Changes in v2: - Re-define KeyValueList as empty

[Xen-devel] [PATCH v3 00/22] generated Go libxl bindings using IDL

2019-12-10 Thread Nick Rosbrook
From: Nick Rosbrook After Xen summit, we started the discussion in this[1] RFC thread to figure out how to generate Go bindings for libxl. This series implements that Go code generation using the existing IDL, and updates the existing hand-written code in xenlight.go to use the generated code.

Re: [Xen-devel] [PATCH for-next 1/7] x86: import hyperv-tlfs.h from Linux

2019-12-10 Thread Jan Beulich
On 10.12.2019 16:37, Durrant, Paul wrote: >> -Original Message- >> From: Xen-devel On Behalf Of Jan >> Beulich >> Sent: 10 December 2019 15:34 >> To: Wei Liu >> Cc: Wei Liu ; Paul Durrant ; Andrew >> Cooper ; Michael Kelley >> ; Xen Development List > de...@lists.xenproject.org>; Roger

Re: [Xen-devel] [PATCH for-next 1/7] x86: import hyperv-tlfs.h from Linux

2019-12-10 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of Jan > Beulich > Sent: 10 December 2019 15:34 > To: Wei Liu > Cc: Wei Liu ; Paul Durrant ; Andrew > Cooper ; Michael Kelley > ; Xen Development List de...@lists.xenproject.org>; Roger Pau Monné > Subject: Re: [Xen-devel] [PATCH

Re: [Xen-devel] [PATCH for-next 2/7] x86: fix up hyperv-tlfs.h

2019-12-10 Thread Jan Beulich
On 25.10.2019 11:16, Wei Liu wrote: > Do the following: > 1. include xen/types.h and xen/bitops.h > 2. fix up invocations of BIT macro Is it truly BIT(..., UL) in _all_ cases, and not BIT(..., U) in some? > Signed-off-by: Wei Liu > --- > This can be squashed into previous patch if preferred.

Re: [Xen-devel] [PATCH for-next 1/7] x86: import hyperv-tlfs.h from Linux

2019-12-10 Thread Jan Beulich
On 25.10.2019 11:16, Wei Liu wrote: > Taken from Linux commit b2d8b167e15bb5ec2691d1119c025630a247f649. > > This is a pristine copy from Linux. It is not used yet and probably > doesn't compile. Changes to make it work will come later. > > Signed-off-by: Wei Liu This coming from Linux and

Re: [Xen-devel] [PATCH for-4.13 v4 1/3] xen/flask: Drop the gen-policy.py script

2019-12-10 Thread Julien Grall
Hi, On 10/12/2019 12:17, Andrew Cooper wrote: The script is Python 2 specific, and fails with string/binary issues with Python 3: Traceback (most recent call last): File "gen-policy.py", line 14, in for char in sys.stdin.read(): File "/usr/lib/python3.5/codecs.py", line

Re: [Xen-devel] [PATCH v2 2/2] x86/mm: factor out the code for shattering an l2 PTE

2019-12-10 Thread Jan Beulich
On 09.12.2019 12:48, Hongyan Xia wrote: > map_pages_to_xen and modify_xen_mappings are performing almost exactly > the same operations when shattering an l2 PTE, the only difference > being whether we want to flush. > > Signed-off-by: Hongyan Xia Mostly the same comments as for patch 1 (I think

Re: [Xen-devel] [PATCH v2 1/2] x86/mm: factor out the code for shattering an l3 PTE

2019-12-10 Thread Jan Beulich
On 09.12.2019 12:48, Hongyan Xia wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -5151,6 +5151,51 @@ l1_pgentry_t *virt_to_xen_l1e(unsigned long v) > flush_area_local((const void *)v, f) : \ > flush_area_all((const void *)v, f)) >

[Xen-devel] [xen-unstable test] 144647: trouble: broken/fail/pass

2019-12-10 Thread osstest service owner
flight 144647 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/144647/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 broken

[Xen-devel] [PATCH] xen-blkback: prevent premature module unload

2019-12-10 Thread Paul Durrant
Objects allocated by xen_blkif_alloc come from the 'blkif_cache' kmem cache. This cache is destoyed when xen-blkif is unloaded so it is necessary to wait for the deferred free routine used for such objects to complete. This necessity was missed in commit 14855954f636 "xen-blkback: allow module to

[Xen-devel] [xen-unstable-smoke test] 144659: tolerable all pass - PUSHED

2019-12-10 Thread osstest service owner
flight 144659 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/144659/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH v2] x86/AMD: unbreak CPU hotplug on AMD systems without RstrFpErrPtrs

2019-12-10 Thread Igor Druzhinin
On 10/12/2019 13:58, Jan Beulich wrote: > On 10.12.2019 13:37, Andrew Cooper wrote: >> Furthermore, you will observe that there is an action item on me from >> the call to come up with a less broken alternative which I'm genuinely >> attempting to do. > > There's no indication towards this in the

[Xen-devel] [seabios test] 144649: trouble: broken/fail/pass

2019-12-10 Thread osstest service owner
flight 144649 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/144649/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 broken

Re: [Xen-devel] [PATCH for-4.13 v4 1/3] xen/flask: Drop the gen-policy.py script

2019-12-10 Thread Jan Beulich
On 10.12.2019 13:17, Andrew Cooper wrote: > The script is Python 2 specific, and fails with string/binary issues with > Python 3: > > Traceback (most recent call last): > File "gen-policy.py", line 14, in > for char in sys.stdin.read(): > File "/usr/lib/python3.5/codecs.py", line

Re: [Xen-devel] [PATCH v2] x86/AMD: unbreak CPU hotplug on AMD systems without RstrFpErrPtrs

2019-12-10 Thread Jan Beulich
On 10.12.2019 13:37, Andrew Cooper wrote: > On 10/12/2019 10:26, Jürgen Groß wrote: >> On 10.12.19 11:10, Jan Beulich wrote: >>> On 04.12.2019 00:56, Igor Druzhinin wrote: If the feature is not present Xen will try to force X86_BUG_FPU_PTRS feature at CPU identification time. This is

Re: [Xen-devel] [PATCH v3] CODING_STYLE: Document how to handle unexpected conditions

2019-12-10 Thread Jan Beulich
On 10.12.2019 11:56, George Dunlap wrote: > On 12/9/19 1:50 PM, Jan Beulich wrote: >> On 09.12.2019 12:29, George Dunlap wrote: >>> --- a/CODING_STYLE >>> +++ b/CODING_STYLE >>> @@ -133,3 +133,97 @@ the end of files. It should be: >>> * indent-tabs-mode: nil >>> * End: >>> */ >>> + >>>

Re: [Xen-devel] [PATCH v3 3/3] xen/build: Automatically locate a suitable python interpreter

2019-12-10 Thread Jürgen Groß
On 07.12.19 22:16, Andrew Cooper wrote: Needing to pass PYTHON=python3 into hypervisor builds is irritating and unnecessary. Locate a suitable interpreter automatically, defaulting to Py3 if it is available. Reported-by: Steven Haigh Signed-off-by: Andrew Cooper Release-acked-by: Juergen

Re: [Xen-devel] [PATCH for-4.13 v4 1/3] xen/flask: Drop the gen-policy.py script

2019-12-10 Thread Jürgen Groß
On 10.12.19 13:17, Andrew Cooper wrote: The script is Python 2 specific, and fails with string/binary issues with Python 3: Traceback (most recent call last): File "gen-policy.py", line 14, in for char in sys.stdin.read(): File "/usr/lib/python3.5/codecs.py", line 321, in

Re: [Xen-devel] [PATCH v2] x86/AMD: unbreak CPU hotplug on AMD systems without RstrFpErrPtrs

2019-12-10 Thread Andrew Cooper
On 10/12/2019 10:26, Jürgen Groß wrote: > On 10.12.19 11:10, Jan Beulich wrote: >> On 04.12.2019 00:56, Igor Druzhinin wrote: >>> If the feature is not present Xen will try to force X86_BUG_FPU_PTRS >>> feature at CPU identification time. This is especially noticeable in >>> PV-shim that usually

[Xen-devel] [PATCH for-4.13 v4 1/3] xen/flask: Drop the gen-policy.py script

2019-12-10 Thread Andrew Cooper
The script is Python 2 specific, and fails with string/binary issues with Python 3: Traceback (most recent call last): File "gen-policy.py", line 14, in for char in sys.stdin.read(): File "/usr/lib/python3.5/codecs.py", line 321, in decode (result, consumed) =

[Xen-devel] [ovmf test] 144651: regressions - FAIL

2019-12-10 Thread osstest service owner
flight 144651 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144651/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 144637 build-i386-xsm

Re: [Xen-devel] [PATCH 3/4] xen/interface: don't discard pending work in FRONT/BACK_RING_ATTACH

2019-12-10 Thread Jürgen Groß
On 09.12.19 17:38, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 09 December 2019 13:55 To: Durrant, Paul ; linux-ker...@vger.kernel.org; xen-devel@lists.xenproject.org Cc: Boris Ostrovsky ; Stefano Stabellini Subject: Re: [PATCH 3/4] xen/interface: don't discard

[Xen-devel] [PATCH v2 2/4] xenbus: limit when state is forced to closed

2019-12-10 Thread Paul Durrant
If a driver probe() fails then leave the xenstore state alone. There is no reason to modify it as the failure may be due to transient resource allocation issues and hence a subsequent probe() may succeed. If the driver supports re-binding then only force state to closed during remove() only in

[Xen-devel] [PATCH v2 3/4] xen/interface: re-define FRONT/BACK_RING_ATTACH()

2019-12-10 Thread Paul Durrant
Currently these macros are defined to re-initialize a front/back ring (respectively) to values read from the shared ring in such a way that any requests/responses that are added to the shared ring whilst the front/back is detached will be skipped over. This, in general, is not a desirable semantic

[Xen-devel] [PATCH v2 1/4] xenbus: move xenbus_dev_shutdown() into frontend code...

2019-12-10 Thread Paul Durrant
...and make it static xenbus_dev_shutdown() is seemingly intended to cause clean shutdown of PV frontends when a guest is rebooted. Indeed the function waits for a conpletion which is only set by a call to xenbus_frontend_closed(). This patch removes the shutdown() method from backends and moves

[Xen-devel] [PATCH v2 0/4] xen-blkback: support live update

2019-12-10 Thread Paul Durrant
Patch #1 is clean-up for an apparent mis-feature. Paul Durrant (4): xenbus: move xenbus_dev_shutdown() into frontend code... xenbus: limit when state is forced to closed xen/interface: re-define FRONT/BACK_RING_ATTACH() xen-blkback: support dynamic unbind/bind

[Xen-devel] [PATCH v2 4/4] xen-blkback: support dynamic unbind/bind

2019-12-10 Thread Paul Durrant
By simply re-attaching to shared rings during connect_ring() rather than assuming they are freshly allocated (i.e assuming the counters are zero) it is possible for vbd instances to be unbound and re-bound from and to (respectively) a running guest. This has been tested by running: while true;

Re: [Xen-devel] [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk

2019-12-10 Thread Roger Pau Monné
On Tue, Dec 10, 2019 at 08:15:22AM +0100, Jürgen Groß wrote: > On 09.12.19 21:14, Nathan Chancellor wrote: > > Clang warns: > > > > ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation; > > statement is not part of the previous 'if' [-Wmisleading-indentation] > >

Re: [Xen-devel] [PATCH v5 2/2] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-10 Thread Roger Pau Monné
On Tue, Dec 10, 2019 at 08:06:28AM +, SeongJae Park wrote: > Each `blkif` has a free pages pool for the grant mapping. The size of > the pool starts from zero and be increased on demand while processing > the I/O requests. If current I/O requests handling is finished or 100 > milliseconds

Re: [Xen-devel] [PATCH v3] CODING_STYLE: Document how to handle unexpected conditions

2019-12-10 Thread George Dunlap
On 12/9/19 1:50 PM, Jan Beulich wrote: > On 09.12.2019 12:29, George Dunlap wrote: >> --- a/CODING_STYLE >> +++ b/CODING_STYLE >> @@ -133,3 +133,97 @@ the end of files. It should be: >> * indent-tabs-mode: nil >> * End: >> */ >> + >> +Handling unexpected conditions >>

Re: [Xen-devel] [PATCH v4] x86: do not enable global pages when virtualized on AMD hardware

2019-12-10 Thread Jan Beulich
On 10.12.2019 11:18, Roger Pau Monné wrote: > On Tue, Dec 10, 2019 at 11:11:18AM +0100, Jan Beulich wrote: >> On 09.12.2019 18:37, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/pv/domain.c >>> +++ b/xen/arch/x86/pv/domain.c >>> @@ -118,6 +118,19 @@ unsigned long pv_fixup_guest_cr4(const struct

Re: [Xen-devel] [PATCH 6/6] x86/smt: Don't use -EBUSY for smt_up_down_helper() continuations

2019-12-10 Thread Jan Beulich
On 05.12.2019 23:30, Andrew Cooper wrote: > --- a/xen/arch/x86/sysctl.c > +++ b/xen/arch/x86/sysctl.c > @@ -85,6 +85,9 @@ long cpu_up_helper(void *data) > /* On EBUSY, flush RCU work and have one more go. */ > rcu_barrier(); > ret = cpu_up(cpu); > + > +if ( ret

Re: [Xen-devel] [PATCH v2] x86/AMD: unbreak CPU hotplug on AMD systems without RstrFpErrPtrs

2019-12-10 Thread Jürgen Groß
On 10.12.19 11:10, Jan Beulich wrote: On 04.12.2019 00:56, Igor Druzhinin wrote: If the feature is not present Xen will try to force X86_BUG_FPU_PTRS feature at CPU identification time. This is especially noticeable in PV-shim that usually hotplugs its vCPUs. We either need to restrict this

Re: [Xen-devel] [PATCH v5 1/2] xenbus/backend: Add memory pressure handler callback

2019-12-10 Thread SeongJae Park
On Tue, Dec 10, 2019 at 11:21 AM Roger Pau Monné wrote: > > On Tue, Dec 10, 2019 at 11:16:35AM +0100, Roger Pau Monné wrote: > > On Tue, Dec 10, 2019 at 08:06:27AM +, SeongJae Park wrote: > > > diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h > > > index 869c816d5f8c..cdb075e4182f

Re: [Xen-devel] [PATCH v5 1/2] xenbus/backend: Add memory pressure handler callback

2019-12-10 Thread Roger Pau Monné
On Tue, Dec 10, 2019 at 11:16:35AM +0100, Roger Pau Monné wrote: > On Tue, Dec 10, 2019 at 08:06:27AM +, SeongJae Park wrote: > > diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h > > index 869c816d5f8c..cdb075e4182f 100644 > > --- a/include/xen/xenbus.h > > +++ b/include/xen/xenbus.h >

Re: [Xen-devel] [PATCH v2] x86 / iommu: set up a scratch page in the quarantine domain

2019-12-10 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 10 December 2019 09:45 > To: Durrant, Paul > Cc: Jürgen Groß ; Tian, Kevin ; > Andrew Cooper ; xen-devel@lists.xenproject.org; > Roger Pau Monné ; Wei Liu > Subject: Re: [PATCH v2] x86 / iommu: set up a scratch page in the > quarantine

Re: [Xen-devel] [PATCH v4] x86: do not enable global pages when virtualized on AMD hardware

2019-12-10 Thread Roger Pau Monné
On Tue, Dec 10, 2019 at 11:11:18AM +0100, Jan Beulich wrote: > On 09.12.2019 18:37, Roger Pau Monne wrote: > > --- a/xen/arch/x86/pv/domain.c > > +++ b/xen/arch/x86/pv/domain.c > > @@ -118,6 +118,19 @@ unsigned long pv_fixup_guest_cr4(const struct vcpu *v, > > unsigned long cr4) > >

Re: [Xen-devel] [PATCH v5 1/2] xenbus/backend: Add memory pressure handler callback

2019-12-10 Thread Roger Pau Monné
On Tue, Dec 10, 2019 at 08:06:27AM +, SeongJae Park wrote: > Granting pages consumes backend system memory. In systems configured > with insufficient spare memory for those pages, it can cause a memory > pressure situation. However, finding the optimal amount of the spare > memory is

Re: [Xen-devel] [PATCH] Remove myself as vm_event maintainer

2019-12-10 Thread Razvan COJOCARU
On 12/10/19 11:57 AM, Jan Beulich wrote: > On 08.12.2019 11:07, Razvan Cojocaru wrote: >> --- >> MAINTAINERS | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 9c827ad759..012c847ebd 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -428,7

Re: [Xen-devel] [PATCH v4] x86: do not enable global pages when virtualized on AMD hardware

2019-12-10 Thread Jan Beulich
On 09.12.2019 18:37, Roger Pau Monne wrote: > --- a/xen/arch/x86/pv/domain.c > +++ b/xen/arch/x86/pv/domain.c > @@ -118,6 +118,19 @@ unsigned long pv_fixup_guest_cr4(const struct vcpu *v, > unsigned long cr4) > (mmu_cr4_features & PV_CR4_GUEST_VISIBLE_MASK)); > } > > +static

Re: [Xen-devel] [PATCH v2] x86/AMD: unbreak CPU hotplug on AMD systems without RstrFpErrPtrs

2019-12-10 Thread Jan Beulich
On 04.12.2019 00:56, Igor Druzhinin wrote: > If the feature is not present Xen will try to force X86_BUG_FPU_PTRS > feature at CPU identification time. This is especially noticeable in > PV-shim that usually hotplugs its vCPUs. We either need to restrict this > action for boot CPU only or allow

[Xen-devel] [PATCH V2] Remove myself as vm_event maintainer

2019-12-10 Thread Razvan Cojocaru
Signed-off-by: Razvan Cojocaru --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9c827ad759..012c847ebd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -428,7 +428,6 @@ L: xen-devel@lists.xenproject.org F: unmodified_drivers/linux-2.6/ VM

Re: [Xen-devel] [PATCH] x86: store cr4 during suspend/resume

2019-12-10 Thread Jan Beulich
On 10.12.2019 10:59, Andrew Cooper wrote: > On 09/12/2019 18:06, Roger Pau Monne wrote: >> Currently cr4 is not cached before suspension, and mmu_cr4_features is >> used in order to restore the expected cr4 value. This is correct so >> far because the tasklet that executes the suspend/resume code

Re: [Xen-devel] [PATCH 1/2] x86/mm: factor out the code for shattering an l3 PTE

2019-12-10 Thread Xia, Hongyan
On Mon, 2019-12-09 at 14:22 +0100, Jan Beulich wrote: > On 07.12.2019 19:20, Xia, Hongyan wrote: > > On Fri, 2019-12-06 at 17:50 +, Andrew Cooper wrote: > > > On 06/12/2019 15:53, Hongyan Xia wrote: > > > > +/* Shatter an l3 entry and populate l2. If virt is passed in, > > > > also > > > > do

Re: [Xen-devel] [PATCH] docs/sphinx: How Xen Boots on x86

2019-12-10 Thread Jan Beulich
On 10.12.2019 10:55, Andrew Cooper wrote: > On 10/12/2019 07:52, Jan Beulich wrote: >> On 09.12.2019 17:42, Andrew Cooper wrote: >>> On 09/12/2019 15:20, Jan Beulich wrote: On 06.12.2019 20:34, Andrew Cooper wrote: > +Objects > +~~~ > + > +To begin with, most object files

Re: [Xen-devel] [PATCH] x86: store cr4 during suspend/resume

2019-12-10 Thread Andrew Cooper
On 09/12/2019 18:06, Roger Pau Monne wrote: > Currently cr4 is not cached before suspension, and mmu_cr4_features is > used in order to restore the expected cr4 value. This is correct so > far because the tasklet that executes the suspend/resume code is > running in the idle vCPU context. > > In

  1   2   >