[Xen-devel] [qemu-mainline test] 146453: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146453 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146453/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

[Xen-devel] [libvirt test] 146455: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146455 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/146455/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt

Re: [Xen-devel] [PATCH] xen/sched: avoid cpumasks on stack in sched/core.c

2020-01-23 Thread Jürgen Groß
On 24.01.20 01:01, Dario Faggioli wrote: On Thu, 2020-01-23 at 10:03 +0100, Juergen Gross wrote: There are still several instances of cpumask_t on the stack in scheduling code. Avoid them as far as possible. Signed-off-by: Juergen Gross Reviewed-by: Dario Faggioli Just curious... ---

[Xen-devel] [xen-unstable-smoke test] 146457: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146457 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/146457/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 146401 build-armhf

Re: [Xen-devel] [RFC 0/6] vDSO support for Hyper-V guest on ARM64

2020-01-23 Thread Boqun Feng
Hi Vincenzo, On Thu, Jan 23, 2020 at 10:48:07AM +, Vincenzo Frascino wrote: > Hi Boqun Feng, > > sorry for the late reply. > That's OK, thanks for your review ;-) > On 16/12/2019 00:19, Boqun Feng wrote: > > Hi, > > > > This is the RFC patchset for vDSO support in ARM64 Hyper-V guest. To

[Xen-devel] [linux-5.4 test] 146423: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146423 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/146423/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 146121

[Xen-devel] [xen-unstable-smoke test] 146454: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146454 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/146454/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 146401 build-armhf

[Xen-devel] [qemu-mainline test] 146448: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146448 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146448/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

[Xen-devel] [xen-unstable-smoke test] 146447: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146447 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/146447/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 146401 build-armhf

[Xen-devel] [xen-unstable-smoke bisection] complete build-arm64-xsm

2020-01-23 Thread osstest service owner
branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-arm64-xsm testid xen-build Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug

Re: [Xen-devel] [PATCH] xen/sched: avoid cpumasks on stack in sched/core.c

2020-01-23 Thread Dario Faggioli
On Thu, 2020-01-23 at 10:03 +0100, Juergen Gross wrote: > There are still several instances of cpumask_t on the stack in > scheduling code. Avoid them as far as possible. > > Signed-off-by: Juergen Gross > Reviewed-by: Dario Faggioli Just curious... > --- a/xen/common/sched/core.c > +++

[Xen-devel] [qemu-mainline test] 146439: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146439 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146439/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

[Xen-devel] [xen-unstable-smoke test] 146438: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146438 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/146438/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 146401 build-armhf

Re: [Xen-devel] [RFC XEN PATCH 00/23] xen: beginning support for RISC-V

2020-01-23 Thread Lars Kurth
> On 23 Jan 2020, at 05:31, Bobby Eshleman wrote: > > On Wed, Jan 22, 2020 at 04:27:39PM +, Lars Kurth wrote: >> >> You should also leverage the developer summit: see >> https://events.linuxfoundation.org/xen-summit/program/cfp/ >>

[Xen-devel] [ovmf test] 146424: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146424 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/146424/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 145767

[Xen-devel] [xen-unstable test] 146419: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146419 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/146419/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs.

Re: [Xen-devel] HVM Driver Domain

2020-01-23 Thread Marek Marczykowski-Górecki
On Thu, Jan 23, 2020 at 10:36:34PM +, tosher 1 wrote: > > > I wasn't able to make the HVM driver domain work even with the latest Xen > version which is 4.14. I see the 'xendriverdomain' executable in the > /etc/init.d/ directory, but it doesn't seem to be running in the background. > >

Re: [Xen-devel] HVM Driver Domain

2020-01-23 Thread tosher 1
I wasn't able to make the HVM driver domain work even with the latest Xen version which is 4.14. I see the 'xendriverdomain' executable in the /etc/init.d/ directory, but it doesn't seem to be running in the background. On the other hand, I see the official "Qubes OS Architecture" document

[Xen-devel] [xen-unstable-smoke test] 146435: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146435 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/146435/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 146401 build-armhf

[Xen-devel] [qemu-mainline test] 146432: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146432 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146432/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

[Xen-devel] [examine test] 146421: tolerable trouble: pass/starved

2020-01-23 Thread osstest service owner
flight 146421 examine real [real] http://logs.test-lab.xenproject.org/osstest/logs/146421/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: examine-elbling1 2 hosts-allocate starved n/a examine-pinot02

[Xen-devel] [xen-unstable-smoke test] 146427: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146427 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/146427/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 146401 build-armhf

[Xen-devel] [PATCH v2 0/2] x86/apic: improvements to disconnect_bsp_APIC

2020-01-23 Thread Roger Pau Monne
Hello, The series contain some improvements to disconnect_bsp_APIC, which started as a way to fix the "APIC error on CPU0: 40(00)" error printed by some Intel boxes on reboot or shutdown. First patch is the fix for the error, second patch is a cleanup. Roger Pau Monne (2): x86/apic: fix

Re: [Xen-devel] [PATCH V8 1/4] x86/mm: Add array_index_nospec to guest provided index values

2020-01-23 Thread Tamas K Lengyel
On Thu, Jan 23, 2020 at 11:45 AM Andrew Cooper wrote: > > On 17/01/2020 13:31, Alexandru Stefan ISAILA wrote: > > This patch aims to sanitize indexes, potentially guest provided > > values, for altp2m_eptp[] and altp2m_p2m[] arrays. > > > > Requested-by: Jan Beulich > > Signed-off-by: Alexandru

[Xen-devel] [qemu-mainline test] 146422: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146422 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146422/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

Re: [Xen-devel] [PATCH V8 1/4] x86/mm: Add array_index_nospec to guest provided index values

2020-01-23 Thread Andrew Cooper
On 17/01/2020 13:31, Alexandru Stefan ISAILA wrote: > This patch aims to sanitize indexes, potentially guest provided > values, for altp2m_eptp[] and altp2m_p2m[] arrays. > > Requested-by: Jan Beulich > Signed-off-by: Alexandru Isaila > Acked-by: Tamas K Lengyel Something in this series broke

[Xen-devel] [PATCH v2 2/2] x86/apic: simplify disconnect_bsp_APIC setup of LVT{0/1}

2020-01-23 Thread Roger Pau Monne
There's no need to read the current values of LVT{0/1} for the purposes of the function, which seem to be to save the currently selected vector: in the destination modes used (ExtINT and NMI) the vector field is ignored and hence can be set to 0. Signed-off-by: Roger Pau Monné ---

Re: [Xen-devel] [xen-unstable bisection] complete test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm

2020-01-23 Thread Andrew Cooper
On 23/01/2020 18:15, Anthony PERARD wrote: > On Thu, Jan 23, 2020 at 06:17:06PM +0100, Roger Pau Monné wrote: >> On Thu, Jan 23, 2020 at 03:34:25PM +, Anthony PERARD wrote: >>> On Tue, Jan 21, 2020 at 10:21:09AM +, Roger Pau Monné wrote: The issue is that this change is passing the

Re: [Xen-devel] [xen-unstable bisection] complete test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm

2020-01-23 Thread Anthony PERARD
On Thu, Jan 23, 2020 at 06:17:06PM +0100, Roger Pau Monné wrote: > On Thu, Jan 23, 2020 at 03:34:25PM +, Anthony PERARD wrote: > > On Tue, Jan 21, 2020 at 10:21:09AM +, Roger Pau Monné wrote: > > > The issue is that this change is passing the guest domain_create_state > > > to

[Xen-devel] [PATCH v2 1/2] x86/apic: fix disabling LVT0 in disconnect_bsp_APIC

2020-01-23 Thread Roger Pau Monne
The Intel SDM states: "When an illegal vector value (0 to 15) is written to a LVT entry and the delivery mode is Fixed (bits 8-11 equal 0), the APIC may signal an illegal vector error, without regard to whether the mask bit is set or whether an interrupt is actually seen on the input." And

Re: [Xen-devel] Valgrind support upgraded to Xen 4.13

2020-01-23 Thread Andrew Cooper
On 23/01/2020 17:45, Tamas K Lengyel wrote: > Hi all, > I just wanted to bring it to the community's attention that I've upped > Valgrind's Xen support to include everything up to Xen 4.13. It's now > merged and will be part of the next Valgrind release: >

[Xen-devel] Valgrind support upgraded to Xen 4.13

2020-01-23 Thread Tamas K Lengyel
Hi all, I just wanted to bring it to the community's attention that I've upped Valgrind's Xen support to include everything up to Xen 4.13. It's now merged and will be part of the next Valgrind release: https://sourceware.org/git/?p=valgrind.git;a=commit;h=c88133141a354d65568fb85037abc5e1f74ce46b

Re: [Xen-devel] [PATCH v5 15/18] xen/mem_sharing: VM forking

2020-01-23 Thread Tamas K Lengyel
On Thu, Jan 23, 2020 at 10:21 AM George Dunlap wrote: > > On 1/21/20 5:49 PM, Tamas K Lengyel wrote: > > VM forking is the process of creating a domain with an empty memory space > > and a > > parent domain specified from which to populate the memory when necessary. > > For > > the new domain

Re: [Xen-devel] [PATCH v5 15/18] xen/mem_sharing: VM forking

2020-01-23 Thread George Dunlap
On 1/21/20 5:49 PM, Tamas K Lengyel wrote: > VM forking is the process of creating a domain with an empty memory space and > a > parent domain specified from which to populate the memory when necessary. For > the new domain to be functional the VM state is copied over as part of the > fork >

Re: [Xen-devel] [PATCH v5 14/18] x86/mem_sharing: use default_access in add_to_physmap

2020-01-23 Thread Tamas K Lengyel
On Thu, Jan 23, 2020 at 9:44 AM George Dunlap wrote: > > On 1/22/20 5:08 PM, Tamas K Lengyel wrote: > > On Wed, Jan 22, 2020 at 8:35 AM Jan Beulich wrote: > >> > >> On 21.01.2020 18:49, Tamas K Lengyel wrote: > >>> When plugging a hole in the target physmap don't use the access permission > >>>

Re: [Xen-devel] [xen-unstable bisection] complete test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm

2020-01-23 Thread Roger Pau Monné
On Thu, Jan 23, 2020 at 03:34:25PM +, Anthony PERARD wrote: > On Tue, Jan 21, 2020 at 10:21:09AM +, Roger Pau Monné wrote: > > The issue is that this change is passing the guest domain_create_state > > to libxl__domain_build in libxl__spawn_stub_dm, and hence the > > stubdomain doesn't get

[Xen-devel] [xen-unstable-smoke test] 146420: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146420 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/146420/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 146401 build-armhf

[Xen-devel] [linux-5.4 test] 146414: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146414 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/146414/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 146121

[Xen-devel] [XEN PATCH] libxl: Fix comment about dcs.sdss

2020-01-23 Thread Anthony PERARD
The field 'sdss' was named 'dmss' before, commit 3148bebbf0ab did the renamed but didn't update the comment. Fixes: 3148bebbf0ab ("libxl: rename a field in libxl__domain_create_state") Signed-off-by: Anthony PERARD --- tools/libxl/libxl_internal.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Xen-devel] [PATCH v5 10/18] x86/mem_sharing: Convert MEM_SHARING_DESTROY_GFN to a bool

2020-01-23 Thread Jan Beulich
On 23.01.2020 17:42, George Dunlap wrote: > On 1/23/20 4:37 PM, Jan Beulich wrote: >> On 23.01.2020 17:32, George Dunlap wrote: >>> On 1/23/20 4:23 PM, Tamas K Lengyel wrote: On Thu, Jan 23, 2020 at 9:14 AM George Dunlap wrote: > > On 1/21/20 5:49 PM, Tamas K Lengyel wrote:

[Xen-devel] [ovmf test] 146417: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146417 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/146417/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 145767

Re: [Xen-devel] [PATCH v5 14/18] x86/mem_sharing: use default_access in add_to_physmap

2020-01-23 Thread George Dunlap
On 1/22/20 5:08 PM, Tamas K Lengyel wrote: > On Wed, Jan 22, 2020 at 8:35 AM Jan Beulich wrote: >> >> On 21.01.2020 18:49, Tamas K Lengyel wrote: >>> When plugging a hole in the target physmap don't use the access permission >>> returned by __get_gfn_type_access as it can be non-sensical, >> >>

Re: [Xen-devel] [PATCH v5 10/18] x86/mem_sharing: Convert MEM_SHARING_DESTROY_GFN to a bool

2020-01-23 Thread George Dunlap
On 1/23/20 4:37 PM, Jan Beulich wrote: > On 23.01.2020 17:32, George Dunlap wrote: >> On 1/23/20 4:23 PM, Tamas K Lengyel wrote: >>> On Thu, Jan 23, 2020 at 9:14 AM George Dunlap >>> wrote: On 1/21/20 5:49 PM, Tamas K Lengyel wrote: > MEM_SHARING_DESTROY_GFN is used on the 'flags'

Re: [Xen-devel] [PATCH v5 10/18] x86/mem_sharing: Convert MEM_SHARING_DESTROY_GFN to a bool

2020-01-23 Thread Jan Beulich
On 23.01.2020 17:32, George Dunlap wrote: > On 1/23/20 4:23 PM, Tamas K Lengyel wrote: >> On Thu, Jan 23, 2020 at 9:14 AM George Dunlap >> wrote: >>> >>> On 1/21/20 5:49 PM, Tamas K Lengyel wrote: MEM_SHARING_DESTROY_GFN is used on the 'flags' bitfield during unsharing. However, the

Re: [Xen-devel] [PATCH v5 10/18] x86/mem_sharing: Convert MEM_SHARING_DESTROY_GFN to a bool

2020-01-23 Thread George Dunlap
On 1/23/20 4:23 PM, Tamas K Lengyel wrote: > On Thu, Jan 23, 2020 at 9:14 AM George Dunlap > wrote: >> >> On 1/21/20 5:49 PM, Tamas K Lengyel wrote: >>> MEM_SHARING_DESTROY_GFN is used on the 'flags' bitfield during unsharing. >>> However, the bitfield is not used for anything else, so just

Re: [Xen-devel] [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation

2020-01-23 Thread Boris Ostrovsky
On 1/22/20 3:07 PM, Anchal Agarwal wrote: >> In this case tsc_verify_tsc_adjust(true) this does nothing as >> feature bit X86_FEATURE_TSC_ADJUST is not available to guest. Is it not available to your specific guest? Because AFAICT it is available in general (to HVM/PVH guests). > 4. Also,

Re: [Xen-devel] [PATCH v5 10/18] x86/mem_sharing: Convert MEM_SHARING_DESTROY_GFN to a bool

2020-01-23 Thread Tamas K Lengyel
On Thu, Jan 23, 2020 at 9:14 AM George Dunlap wrote: > > On 1/21/20 5:49 PM, Tamas K Lengyel wrote: > > MEM_SHARING_DESTROY_GFN is used on the 'flags' bitfield during unsharing. > > However, the bitfield is not used for anything else, so just convert it to a > > bool instead. > > > >

Re: [Xen-devel] [PATCH v2] cmdline: treat hyphens and underscores the same

2020-01-23 Thread Andrew Cooper
On 23/01/2020 11:42, Jan Beulich wrote: > In order to avoid permanently having to ask that no new command line > options using underscores be introduced (albeit I'm likely to still make > remarks), and in order to also allow extending the use of hyphens to > pre-existing ones, introduce custom

Re: [Xen-devel] [PATCH v5 10/18] x86/mem_sharing: Convert MEM_SHARING_DESTROY_GFN to a bool

2020-01-23 Thread George Dunlap
On 1/21/20 5:49 PM, Tamas K Lengyel wrote: > MEM_SHARING_DESTROY_GFN is used on the 'flags' bitfield during unsharing. > However, the bitfield is not used for anything else, so just convert it to a > bool instead. > > Signed-off-by: Tamas K Lengyel > Reviewed-by: Jan Beulich But is there a

[Xen-devel] [qemu-mainline test] 146418: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146418 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146418/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Jan Beulich
On 23.01.2020 16:56, Durrant, Paul wrote: >> From: Jan Beulich >> Sent: 23 January 2020 15:32 >> >> On 23.01.2020 15:03, Paul Durrant wrote: >>> vmx_alloc_vlapic_mapping() currently contains some very odd looking code >>> that allocates a MEMF_no_owner domheap page and then shares with the >>

Re: [Xen-devel] [RFC XEN PATCH 00/23] xen: beginning support for RISC-V

2020-01-23 Thread Andrew Cooper
On 23/01/2020 05:19, Bobby Eshleman wrote: > On Wed, Jan 22, 2020 at 02:57:47PM +, Andrew Cooper wrote: >> How much time do you have to put towards the port?  Is this something in >> your free time, or something you are doing as part of work?  Ultimately, >> we are going to need to increase

Re: [Xen-devel] [PATCH v5 07/18] x86/mem_sharing: define mem_sharing_domain to hold some scattered variables

2020-01-23 Thread George Dunlap
On 1/21/20 5:49 PM, Tamas K Lengyel wrote: > Create struct mem_sharing_domain under hvm_domain and move mem sharing > variables into it from p2m_domain and hvm_domain. > > Expose the mem_sharing_enabled macro to be used consistently across Xen. > > Remove some duplicate calls to

Re: [Xen-devel] [PATCH] x86/apic: fix disabling LVT0 in disconnect_bsp_APIC

2020-01-23 Thread Jan Beulich
On 23.01.2020 16:43, Roger Pau Monné wrote: > On Fri, Jan 17, 2020 at 05:25:12PM +0100, Jan Beulich wrote: >> On 17.01.2020 17:08, Roger Pau Monné wrote: >>> On Fri, Jan 17, 2020 at 04:56:00PM +0100, Jan Beulich wrote: On 17.01.2020 16:09, Roger Pau Monne wrote: > The Intel SDM states:

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 23 January 2020 15:32 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Wei Liu ; Roger Pau Monné > ; George Dunlap ; Ian > Jackson ; Julien Grall ; Konrad > Rzeszutek Wilk ; Stefano Stabellini > ; Jun Nakajima ;

Re: [Xen-devel] [PATCH v5 05/18] x86/mem_sharing: drop flags from mem_sharing_unshare_page

2020-01-23 Thread George Dunlap
On 1/21/20 5:49 PM, Tamas K Lengyel wrote: > All callers pass 0 in. > > Signed-off-by: Tamas K Lengyel > Reviewed-by: Wei Liu Acked-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH v4 7/7] x86/hyperv: setup VP assist page

2020-01-23 Thread Jan Beulich
On 22.01.2020 21:23, Wei Liu wrote: > @@ -142,15 +143,40 @@ static void setup_hypercall_pcpu_arg(void) > this_cpu(hv_vp_index) = vp_index_msr; > } > > +static void setup_vp_assist(void) > +{ > +void *mapping; > +uint64_t val; > + > +mapping = this_cpu(hv_vp_assist); > + > +

Re: [Xen-devel] [PATCH v5 04/18] x86/mem_sharing: make get_two_gfns take locks conditionally

2020-01-23 Thread George Dunlap
On 1/21/20 5:49 PM, Tamas K Lengyel wrote: > During VM forking the client lock will already be taken. > > Signed-off-by: Tamas K Lengyel > Acked-by: Andrew Coopers Acked-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread George Dunlap
On 1/23/20 3:46 PM, Durrant, Paul wrote: >> -Original Message- >> From: Julien Grall >> Sent: 23 January 2020 15:26 >> To: Durrant, Paul ; xen-devel@lists.xenproject.org >> Cc: Jan Beulich ; Andrew Cooper >> ; Wei Liu ; Roger Pau Monné >> ; George Dunlap ; Ian >> Jackson ; Konrad

Re: [Xen-devel] [PATCH v4 6/7] x86/hyperv: retrieve vp_index from Hyper-V

2020-01-23 Thread Jan Beulich
On 22.01.2020 21:23, Wei Liu wrote: > This will be useful when invoking hypercall that targets specific > vcpu(s). > > Signed-off-by: Wei Liu > Reviewed-by: Paul Durrant For formal reasons Acked-by: Jan Beulich However I wonder whether the Viridian entry in MAINTAINERS shouldn't be extended

Re: [Xen-devel] [PATCH v5 03/18] x86/p2m: Allow p2m_get_page_from_gfn to return shared entries

2020-01-23 Thread Tamas K Lengyel
On Thu, Jan 23, 2020 at 8:32 AM George Dunlap wrote: > > On 1/22/20 4:55 PM, Jan Beulich wrote: > > On 22.01.2020 17:51, Tamas K Lengyel wrote: > >> On Wed, Jan 22, 2020 at 8:23 AM Jan Beulich wrote: > >>> > >>> On 21.01.2020 18:49, Tamas K Lengyel wrote: > The owner domain of shared pages

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Julien Grall
On 23/01/2020 15:46, Durrant, Paul wrote: -Original Message- From: Julien Grall Sent: 23 January 2020 15:26 To: Durrant, Paul ; xen-devel@lists.xenproject.org Cc: Jan Beulich ; Andrew Cooper ; Wei Liu ; Roger Pau Monné ; George Dunlap ; Ian Jackson ; Konrad Rzeszutek Wilk ; Stefano

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Durrant, Paul
> -Original Message- > From: Julien Grall > Sent: 23 January 2020 15:26 > To: Durrant, Paul ; xen-devel@lists.xenproject.org > Cc: Jan Beulich ; Andrew Cooper > ; Wei Liu ; Roger Pau Monné > ; George Dunlap ; Ian > Jackson ; Konrad Rzeszutek Wilk > ; Stefano Stabellini ; Jun > Nakajima ;

Re: [Xen-devel] [PATCH v4 5/7] x86/hyperv: provide percpu hypercall input page

2020-01-23 Thread Jan Beulich
On 22.01.2020 21:23, Wei Liu wrote: > --- a/xen/arch/x86/guest/hyperv/hyperv.c > +++ b/xen/arch/x86/guest/hyperv/hyperv.c > @@ -27,7 +27,10 @@ > #include > #include > > +#include "private.h" > + > struct ms_hyperv_info __read_mostly ms_hyperv; > +DEFINE_PER_CPU_READ_MOSTLY(void *,

Re: [Xen-devel] [PATCH] x86/apic: fix disabling LVT0 in disconnect_bsp_APIC

2020-01-23 Thread Roger Pau Monné
On Fri, Jan 17, 2020 at 05:25:12PM +0100, Jan Beulich wrote: > On 17.01.2020 17:08, Roger Pau Monné wrote: > > On Fri, Jan 17, 2020 at 04:56:00PM +0100, Jan Beulich wrote: > >> On 17.01.2020 16:09, Roger Pau Monne wrote: > >>> The Intel SDM states: > >>> > >>> "When an illegal vector value (0 to

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread George Dunlap
On 1/23/20 3:32 PM, Jan Beulich wrote: > On 23.01.2020 15:03, Paul Durrant wrote: >> vmx_alloc_vlapic_mapping() currently contains some very odd looking code >> that allocates a MEMF_no_owner domheap page and then shares with the guest >> as if it were a xenheap page. This then requires

Re: [Xen-devel] [xen-unstable bisection] complete test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm

2020-01-23 Thread Anthony PERARD
On Tue, Jan 21, 2020 at 10:21:09AM +, Roger Pau Monné wrote: > The issue is that this change is passing the guest domain_create_state > to libxl__domain_build in libxl__spawn_stub_dm, and hence the > stubdomain doesn't get created. I have the following patch that fixes > it, but it's kind of

Re: [Xen-devel] [PATCH v5 03/18] x86/p2m: Allow p2m_get_page_from_gfn to return shared entries

2020-01-23 Thread George Dunlap
On 1/22/20 4:55 PM, Jan Beulich wrote: > On 22.01.2020 17:51, Tamas K Lengyel wrote: >> On Wed, Jan 22, 2020 at 8:23 AM Jan Beulich wrote: >>> >>> On 21.01.2020 18:49, Tamas K Lengyel wrote: The owner domain of shared pages is dom_cow, use that for get_page otherwise the function fails

Re: [Xen-devel] [PATCH v3 1/3] x86 / vmx: make apic_access_mfn type-safe

2020-01-23 Thread Andrew Cooper
On 23/01/2020 14:03, Paul Durrant wrote: > Use mfn_t rather than unsigned long and change previous tests against 0 to > tests against INVALID_MFN (also introducing initialization to that value). > > Signed-off-by: Paul Durrant > Acked-by: Kevin Tian > Reviewed-by: Jan Beulich > --- > Cc: Andrew

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Jan Beulich
On 23.01.2020 15:03, Paul Durrant wrote: > vmx_alloc_vlapic_mapping() currently contains some very odd looking code > that allocates a MEMF_no_owner domheap page and then shares with the guest > as if it were a xenheap page. This then requires vmx_free_vlapic_mapping() > to call a special function

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Julien Grall
On 23/01/2020 14:03, Paul Durrant wrote: diff --git a/xen/common/domain.c b/xen/common/domain.c index ee3f9ffd3e..30c777acb8 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -339,6 +339,8 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config) return

Re: [Xen-devel] [PATCH v4 2/7] x86/hyperv: setup hypercall page

2020-01-23 Thread Michael Kelley
From: Jan Beulich Sent: Thursday, January 23, 2020 3:19 AM > > On 22.01.2020 21:23, Wei Liu wrote: > > --- a/xen/arch/x86/e820.c > > +++ b/xen/arch/x86/e820.c > > @@ -36,6 +36,22 @@ boolean_param("e820-verbose", e820_verbose); > > struct e820map e820; > > struct e820map __initdata e820_raw; >

Re: [Xen-devel] [PATCH v3 2/3] x86 / hvm: add domain_relinquish_resources() method

2020-01-23 Thread Jan Beulich
On 23.01.2020 15:03, Paul Durrant wrote: > There are two functions in hvm.c to deal with tear-down and a domain: > hvm_domain_relinquish_resources() and hvm_domain_destroy(). However, only > the latter has an associated method in 'hvm_funcs'. This patch adds > a method for the former. > > A

Re: [Xen-devel] [PATCH v3 2/2] xsm: hide detailed Xen version from unprivileged guests

2020-01-23 Thread Jan Beulich
On 23.01.2020 15:52, Julien Grall wrote: > Therefore, they will have to accept whatever string is reported by > HVMLoader (or Xen). As you already allow Xen to configure it, why would > that be a problem to change the one in Kconfig? Why do you need to fix > it up in hvmloader as well?

Re: [Xen-devel] [PATCH v3 2/2] xsm: hide detailed Xen version from unprivileged guests

2020-01-23 Thread George Dunlap
On 1/23/20 2:52 PM, Julien Grall wrote: > Hi, > > On 23/01/2020 14:45, George Dunlap wrote: >> On 1/23/20 2:42 PM, Julien Grall wrote: >>> Hi, >>> >>> On 23/01/2020 11:32, Sergey Dyasli wrote: On 22/01/2020 11:25, Julien Grall wrote: > > > On 22/01/2020 11:19, Sergey Dyasli

Re: [Xen-devel] [PATCH v3 2/2] xsm: hide detailed Xen version from unprivileged guests

2020-01-23 Thread Julien Grall
Hi, On 23/01/2020 14:45, George Dunlap wrote: On 1/23/20 2:42 PM, Julien Grall wrote: Hi, On 23/01/2020 11:32, Sergey Dyasli wrote: On 22/01/2020 11:25, Julien Grall wrote: On 22/01/2020 11:19, Sergey Dyasli wrote: On 22/01/2020 10:14, Julien Grall wrote: On 22/01/2020 10:01, Sergey

Re: [Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread George Dunlap
On 1/23/20 2:03 PM, Paul Durrant wrote: > vmx_alloc_vlapic_mapping() currently contains some very odd looking code > that allocates a MEMF_no_owner domheap page and then shares with the guest > as if it were a xenheap page. This then requires vmx_free_vlapic_mapping() > to call a special function

Re: [Xen-devel] [PATCH v3 2/2] xsm: hide detailed Xen version from unprivileged guests

2020-01-23 Thread George Dunlap
On 1/23/20 2:42 PM, Julien Grall wrote: > Hi, > > On 23/01/2020 11:32, Sergey Dyasli wrote: >> On 22/01/2020 11:25, Julien Grall wrote: >>> >>> >>> On 22/01/2020 11:19, Sergey Dyasli wrote: On 22/01/2020 10:14, Julien Grall wrote: > > > On 22/01/2020 10:01, Sergey Dyasli wrote:

Re: [Xen-devel] [PATCH v3 2/2] xsm: hide detailed Xen version from unprivileged guests

2020-01-23 Thread Julien Grall
Hi, On 23/01/2020 11:32, Sergey Dyasli wrote: On 22/01/2020 11:25, Julien Grall wrote: On 22/01/2020 11:19, Sergey Dyasli wrote: On 22/01/2020 10:14, Julien Grall wrote: On 22/01/2020 10:01, Sergey Dyasli wrote: On 20/01/2020 10:01, Jan Beulich wrote: On 17.01.2020 17:44, Sergey Dyasli

Re: [Xen-devel] [PATCH v3 2/2] xsm: hide detailed Xen version from unprivileged guests

2020-01-23 Thread George Dunlap
On 1/22/20 11:44 AM, Sergey Dyasli wrote: > On 22/01/2020 10:57, George Dunlap wrote: >> On 1/22/20 10:14 AM, Julien Grall wrote: >>> >>> >>> On 22/01/2020 10:01, Sergey Dyasli wrote: On 20/01/2020 10:01, Jan Beulich wrote: > On 17.01.2020 17:44, Sergey Dyasli wrote: >> v2 --> v3:

Re: [Xen-devel] [PATCH V8 4/4] x86/mm: Make use of the default access param from xc_altp2m_create_view

2020-01-23 Thread George Dunlap
On 1/17/20 1:31 PM, Alexandru Stefan ISAILA wrote: > At this moment the default_access param from xc_altp2m_create_view is > not used. > > This patch assigns default_access to p2m->default_access at the time of > initializing a new altp2m view. > > Signed-off-by: Alexandru Isaila > Acked-by:

[Xen-devel] [PATCH v3 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Paul Durrant
vmx_alloc_vlapic_mapping() currently contains some very odd looking code that allocates a MEMF_no_owner domheap page and then shares with the guest as if it were a xenheap page. This then requires vmx_free_vlapic_mapping() to call a special function in the mm code: free_shared_domheap_page(). By

[Xen-devel] [PATCH v3 0/3] purge free_shared_domheap_page()

2020-01-23 Thread Paul Durrant
Paul Durrant (3): x86 / vmx: make apic_access_mfn type-safe x86 / hvm: add domain_relinquish_resources() method x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE xen/arch/x86/hvm/hvm.c | 7 +- xen/arch/x86/hvm/mtrr.c| 2 +-

[Xen-devel] [PATCH v3 2/3] x86 / hvm: add domain_relinquish_resources() method

2020-01-23 Thread Paul Durrant
There are two functions in hvm.c to deal with tear-down and a domain: hvm_domain_relinquish_resources() and hvm_domain_destroy(). However, only the latter has an associated method in 'hvm_funcs'. This patch adds a method for the former. A subsequent patch will define a VMX implementation.

[Xen-devel] [PATCH v3 1/3] x86 / vmx: make apic_access_mfn type-safe

2020-01-23 Thread Paul Durrant
Use mfn_t rather than unsigned long and change previous tests against 0 to tests against INVALID_MFN (also introducing initialization to that value). Signed-off-by: Paul Durrant Acked-by: Kevin Tian Reviewed-by: Jan Beulich --- Cc: Andrew Cooper Cc: Wei Liu Cc: "Roger Pau Monné" Cc: Jun

[Xen-devel] [xen-unstable test] 146408: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146408 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/146408/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs.

Re: [Xen-devel] [PATCH v2 1/3] x86 / vmx: make apic_access_mfn type-safe

2020-01-23 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 23 January 2020 13:30 > To: Durrant, Paul > Cc: Kevin Tian ; Wei Liu ; Andrew Cooper > ; Jun Nakajima ; xen- > de...@lists.xenproject.org; Roger Pau Monné > Subject: Re: [PATCH v2 1/3] x86 / vmx: make apic_access_mfn type-safe > > On

[Xen-devel] [qemu-mainline test] 146416: regressions - FAIL

2020-01-23 Thread osstest service owner
flight 146416 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/146416/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 144861 build-arm64

Re: [Xen-devel] [PATCH v2 1/3] x86 / vmx: make apic_access_mfn type-safe

2020-01-23 Thread Jan Beulich
On 23.01.2020 14:09, Durrant, Paul wrote: >> -Original Message- >> From: Xen-devel On Behalf Of Jan >> Beulich >> Sent: 23 January 2020 12:45 >> To: Durrant, Paul >> Cc: Kevin Tian ; Wei Liu ; Andrew Cooper >> ; Jun Nakajima ; xen- >> de...@lists.xenproject.org; Roger Pau Monné >>

Re: [Xen-devel] [PATCH v2] cmdline: treat hyphens and underscores the same

2020-01-23 Thread Jan Beulich
On 23.01.2020 13:11, Durrant, Paul wrote: >> -Original Message- >> From: Xen-devel On Behalf Of Jan >> Beulich >> Sent: 23 January 2020 11:43 >> To: xen-devel@lists.xenproject.org >> Cc: Stefano Stabellini ; Julien Grall >> ; Wei Liu ; Konrad Wilk >> ; George Dunlap ; >> Andrew Cooper ;

Re: [Xen-devel] [PATCH v2 1/3] x86 / vmx: make apic_access_mfn type-safe

2020-01-23 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of Jan > Beulich > Sent: 23 January 2020 12:45 > To: Durrant, Paul > Cc: Kevin Tian ; Wei Liu ; Andrew Cooper > ; Jun Nakajima ; xen- > de...@lists.xenproject.org; Roger Pau Monné > Subject: Re: [Xen-devel] [PATCH v2 1/3] x86 / vmx: make

Re: [Xen-devel] [PATCH v2 1/3] x86 / vmx: make apic_access_mfn type-safe

2020-01-23 Thread Jan Beulich
On 23.01.2020 13:21, Paul Durrant wrote: > Use mfn_t rather than unsigned long and change previous tests against 0 to > tests against INVALID_MFN (also introducing initialization to that value). > > Signed-off-by: Paul Durrant > Acked-by: Kevin Tian > Reviewed-by: Jan Beulich No, this isn't

Re: [Xen-devel] [PATCH V8 3/4] x86/mm: Pull vendor-independent altp2m code out of p2m-ept.c and into p2m.c

2020-01-23 Thread George Dunlap
On 1/17/20 1:31 PM, Alexandru Stefan ISAILA wrote: > No functional changes. > > Requested-by: Jan Beulich > Signed-off-by: Alexandru Isaila > Reviewed-by: Jan Beulich Acked-by: George Dunlap ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH V8 2/4] x86/altp2m: Add hypercall to set a range of sve bits

2020-01-23 Thread George Dunlap
On 1/17/20 1:31 PM, Alexandru Stefan ISAILA wrote: > By default the sve bits are not set. > This patch adds a new hypercall, xc_altp2m_set_supress_ve_multi(), > to set a range of sve bits. > The core function, p2m_set_suppress_ve_multi(), does not break in case > of a error and it is doing a best

Re: [Xen-devel] [PATCH v4 1/2] xen/arm: remove physical timer offset

2020-01-23 Thread Julien Grall
Hi, On 21/01/2020 15:07, Jeff Kubascik wrote: The physical timer traps apply an offset so that time starts at 0 for the guest. However, this offset is not currently applied to the physical counter. Per the ARMv8 Reference Manual (ARM DDI 0487E.a), section D11.2.4 Timers, the "Offset" between

Re: [Xen-devel] [PATCH 1/2] nvmx: fix handling of interrupts

2020-01-23 Thread Roger Pau Monné
On Tue, Jan 21, 2020 at 03:34:13AM +, Tian, Kevin wrote: > > From: Roger Pau Monné > > Sent: Monday, January 20, 2020 6:19 PM > > > > On Sun, Jan 19, 2020 at 04:15:04AM +, Tian, Kevin wrote: > > > > From: Roger Pau Monne > > > > Sent: Wednesday, January 8, 2020 6:39 PM > > > > > > > >

Re: [Xen-devel] [PATCH v4 2/2] xen/arm: Sign extend TimerValue when computing the CompareValue

2020-01-23 Thread Julien Grall
Hi, On 21/01/2020 15:07, Jeff Kubascik wrote: Xen will only store the CompareValue as it can be derived from the TimerValue (ARM DDI 0487E.a section D11.2.4): CompareValue = (Counter[63:0] + SignExtend(TimerValue))[63:0] While the TimerValue is a 32-bit signed value, our implementation

Re: [Xen-devel] [PATCH v3 1/2] xen/arm: remove physical timer offset

2020-01-23 Thread Julien Grall
Hi, On 17/01/2020 21:24, Jeff Kubascik wrote: On 12/18/2019 9:20 AM, Julien Grall wrote: Hi Jeff, On 11/12/2019 21:13, Jeff Kubascik wrote: The physical timer traps apply an offset so that time starts at 0 for the guest. However, this offset is not currently applied to the physical counter.

Re: [Xen-devel] [PATCH V8 1/4] x86/mm: Add array_index_nospec to guest provided index values

2020-01-23 Thread George Dunlap
On 1/17/20 1:31 PM, Alexandru Stefan ISAILA wrote: > This patch aims to sanitize indexes, potentially guest provided > values, for altp2m_eptp[] and altp2m_p2m[] arrays. > > Requested-by: Jan Beulich > Signed-off-by: Alexandru Isaila > Acked-by: Tamas K Lengyel Acked-by: George Dunlap

[Xen-devel] [PATCH v2 3/3] x86 / vmx: use a 'normal' domheap page for APIC_DEFAULT_PHYS_BASE

2020-01-23 Thread Paul Durrant
vmx_alloc_vlapic_mapping() currently contains some very odd looking code that allocates a MEMF_no_owner domheap page and then shares with the guest as if it were a xenheap page. This then requires vmx_free_vlapic_mapping() to call a special function in the mm code: free_shared_domheap_page(). By

  1   2   >