Re: [Xen-devel] [PATCH 1/2] xen/mm: fold PGC_broken into PGC_state bits

2020-02-20 Thread Jan Beulich
On 07.02.2020 16:57, David Woodhouse wrote: > @@ -1145,16 +1145,19 @@ static int reserve_offlined_page(struct page_info > *head) > > for ( cur_head = head; cur_head < head + ( 1UL << head_order); > cur_head++ ) > { > -if ( !page_state_is(cur_head, offlined) ) > +

Re: [Xen-devel] [PATCH v4 3/3] x86/hyperv: L0 assisted TLB flush

2020-02-20 Thread Durrant, Paul
> -Original Message- > From: Wei Liu On Behalf Of Wei Liu > Sent: 19 February 2020 11:44 > To: Xen Development List > Cc: Michael Kelley ; Durrant, Paul > ; Wei Liu ; Wei Liu > ; Jan Beulich ; Andrew Cooper > ; Roger Pau Monné > Subject: [PATCH v4 3/3] x86/hyperv: L0 assisted TLB flush

[Xen-devel] [linux-4.4 test] 147279: regressions - FAIL

2020-02-20 Thread osstest service owner
flight 147279 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/147279/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 139698

Re: [Xen-devel] [PATCH 1/5] libxl/PCI: honor multiple per-device reserved memory regions

2020-02-20 Thread Wei Liu
On Tue, Feb 18, 2020 at 04:46:17PM +0100, Jan Beulich wrote: > While in "host" strategy all regions get processed, of the per-device > ones only the first entry has been consumed so far. > > Signed-off-by: Jan Beulich Acked-by: Wei Liu ___ Xen-devel

Re: [Xen-devel] [PATCH 0/3] tools/xentop: Fix calculation of used memory and some cleanups

2020-02-20 Thread Sander Eikelenboom
On 20/02/2020 01:53, Wei Liu wrote: > On Wed, Feb 19, 2020 at 09:31:29PM +0100, Sander Eikelenboom wrote: >> Fixes some fallout from: c588c002cc1 ('tools: remove tmem code and commands') > > Thanks. I made some suggestions on adding commit messages. Let me know > if you're okay with those. > >

Re: [Xen-devel] [PATCH V3] x86/altp2m: Hypercall to set altp2m view visibility

2020-02-20 Thread Jan Beulich
On 20.02.2020 10:59, Alexandru Stefan ISAILA wrote: > On 19.02.2020 19:00, Jan Beulich wrote: >> On 19.02.2020 10:18, Alexandru Stefan ISAILA wrote: >>> @@ -4835,6 +4836,23 @@ static int do_altp2m_op( >>> break; >>> } >>> >>> +case HVMOP_altp2m_set_visibility: >>> +{ >>>

Re: [Xen-devel] [PATCH 2/3] tools/xentop: Remove dead code

2020-02-20 Thread Wei Liu
On Thu, Feb 20, 2020 at 12:51:23AM +, Wei Liu wrote: > On Wed, Feb 19, 2020 at 09:31:31PM +0100, Sander Eikelenboom wrote: > > Signed-off-by: Sander Eikelenboom > > --- > > I will add the following commit message: > > The variable freealbe_mb was never really used. Delete it and the code >

Re: [Xen-devel] [PATCH 1/3] tools/xentop: Fix calculation of used memory.

2020-02-20 Thread Wei Liu
On Thu, Feb 20, 2020 at 12:48:16AM +, Wei Liu wrote: > The code looks correct to me, but I would like to add the following > commit message to this change. > > Used memory should be calculated by subtracting free memory from total > memory. Fixes: c588c002cc1 ("tools: remove tmem code and

Re: [Xen-devel] [PATCH 0/3] tools/xentop: Fix calculation of used memory and some cleanups

2020-02-20 Thread Wei Liu
On Wed, Feb 19, 2020 at 09:31:29PM +0100, Sander Eikelenboom wrote: > Fixes some fallout from: c588c002cc1 ('tools: remove tmem code and commands') Thanks. I made some suggestions on adding commit messages. Let me know if you're okay with those. Wei.

Re: [Xen-devel] [PATCH 3/3] tools/xentop: Cleanup some trailing whitespace

2020-02-20 Thread Wei Liu
On Wed, Feb 19, 2020 at 09:31:32PM +0100, Sander Eikelenboom wrote: > Signed-off-by: Sander Eikelenboom Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 2/3] tools/xentop: Remove dead code

2020-02-20 Thread Wei Liu
On Wed, Feb 19, 2020 at 09:31:31PM +0100, Sander Eikelenboom wrote: > Signed-off-by: Sander Eikelenboom > --- I will add the following commit message: The variable freealbe_mb was never really used. Delete it and the code associated with it. Acked-by: Wei Liu > tools/xenstat/xentop/xentop.c

Re: [Xen-devel] [PATCH V3] x86/altp2m: Hypercall to set altp2m view visibility

2020-02-20 Thread Alexandru Stefan ISAILA
On 19.02.2020 19:00, Jan Beulich wrote: > On 19.02.2020 10:18, Alexandru Stefan ISAILA wrote: >> @@ -4835,6 +4836,23 @@ static int do_altp2m_op( >> break; >> } >> >> +case HVMOP_altp2m_set_visibility: >> +{ >> +uint16_t altp2m_idx =

Re: [Xen-devel] [PATCH v3] ns16550: Add ACPI support for ARM only

2020-02-20 Thread Wei Xu
Hi Jan, On 2020/2/20 16:33, Jan Beulich wrote: > On 20.02.2020 08:44, Wei Xu wrote: >> On 2020/2/17 21:53, Jan Beulich wrote: >>> On 03.02.2020 12:21, Wei Xu wrote: +static int __init ns16550_acpi_uart_init(const void *data) +{ +struct acpi_table_header *table; +struct

Re: [Xen-devel] [PATCH 1/3] tools/xentop: Fix calculation of used memory.

2020-02-20 Thread Wei Liu
The code looks correct to me, but I would like to add the following commit message to this change. Used memory should be calculated by subtracting free memory from total memory. On Wed, Feb 19, 2020 at 09:31:30PM +0100, Sander Eikelenboom wrote: > Signed-off-by: Sander Eikelenboom > --- >

Re: [Xen-devel] [PATCH v2] xen/sched: add some diagnostic info in the run queue keyhandler

2020-02-20 Thread Dario Faggioli
On Tue, 2020-02-11 at 13:27 +0100, Juergen Gross wrote: > When dumping the run queue information add some more data regarding > current and (if known) previous vcpu for each physical cpu. > > With core scheduling activated the printed data will be e.g.: > > (XEN) CPUs info: > (XEN) CPU[00]

[Xen-devel] dom-u stuck in ---sr- state after reboot

2020-02-20 Thread msd+xen-devel
Hi everyone, Since I use Xen 4.11 on Debian 10, sometimes (about one in twenty times) after a dom-u reboot, it stays stuck with the state '---sr-'. This had never happened for me with Xen 4.4 on Debian 8. I have to manually destroy and reboot the dom-u stuck domain. I can't see any error in

Re: [Xen-devel] [PATCH] xen/sched: rework credit2 run-queue allocation

2020-02-20 Thread Dario Faggioli
On Thu, 2020-02-20 at 07:56 +0100, Jürgen Groß wrote: > On 19.02.20 19:37, Dario Faggioli wrote: > > On Wed, 2020-02-19 at 17:52 +0100, Jan Beulich wrote: > > > > > Nevertheless, I'd add a quick comment about that, to make it even > > more > > obvious. :-) > > Do we really need that? > >

Re: [Xen-devel] [PATCH V3] x86/altp2m: Hypercall to set altp2m view visibility

2020-02-20 Thread Alexandru Stefan ISAILA
On 19.02.2020 18:37, Tamas K Lengyel wrote: > On Wed, Feb 19, 2020 at 2:19 AM Alexandru Stefan ISAILA > wrote: >> >> At this moment a guest can call vmfunc to change the altp2m view. This >> should be limited in order to avoid any unwanted view switch. >> >> The new xc_altp2m_set_visibility()

Re: [Xen-devel] [PATCH 1/2] smp: convert the cpu maps lock into a rw lock

2020-02-20 Thread Roger Pau Monné
On Thu, Feb 20, 2020 at 08:57:33AM +, Julien Grall wrote: > > > On 20/02/2020 08:36, Jan Beulich wrote: > > On 20.02.2020 09:27, Jürgen Groß wrote: > > > On 20.02.20 09:13, Jan Beulich wrote: > > > > On 13.02.2020 12:32, Roger Pau Monne wrote: > > > > > Most users of the cpu maps just care

Re: [Xen-devel] [PATCH v5 8/8] xen: add runtime parameter access support to hypfs

2020-02-20 Thread Jürgen Groß
On 20.02.20 09:49, Jan Beulich wrote: On 20.02.2020 09:22, Jürgen Groß wrote: On 19.02.20 17:44, Jan Beulich wrote: On 19.02.2020 09:11, Juergen Gross wrote: --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -89,6 +89,11 @@ SECTIONS __start_schedulers_array = .;

Re: [Xen-devel] [RFC PATCH v3 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-02-20 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of > Roger Pau Monné > Sent: 20 February 2020 08:39 > To: Agarwal, Anchal > Cc: Valentin, Eduardo ; len.br...@intel.com; > pet...@infradead.org; b...@kernel.crashing.org; x...@kernel.org; linux- > m...@kvack.org; pa...@ucw.cz;

Re: [Xen-devel] [PATCH v5 3/8] xen: add basic hypervisor filesystem support

2020-02-20 Thread Jürgen Groß
On 20.02.20 09:43, Jan Beulich wrote: On 20.02.2020 08:27, Jürgen Groß wrote: On 19.02.20 16:49, Jan Beulich wrote: On 19.02.2020 09:11, Juergen Gross wrote: +static inline void hypfs_string_set(struct hypfs_entry_leaf *leaf, +const char *str) +{ +

[Xen-devel] [linux-4.9 test] 147255: regressions - FAIL

2020-02-20 Thread osstest service owner
flight 147255 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/147255/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 142947

Re: [Xen-devel] [PATCH 1/2] smp: convert the cpu maps lock into a rw lock

2020-02-20 Thread Julien Grall
On 20/02/2020 08:36, Jan Beulich wrote: On 20.02.2020 09:27, Jürgen Groß wrote: On 20.02.20 09:13, Jan Beulich wrote: On 13.02.2020 12:32, Roger Pau Monne wrote: Most users of the cpu maps just care about the maps not changing while the lock is being held, but don't actually modify the

Re: [Xen-devel] [PATCH v5 3/8] xen: add basic hypervisor filesystem support

2020-02-20 Thread Jan Beulich
On 20.02.2020 08:27, Jürgen Groß wrote: > On 19.02.20 16:49, Jan Beulich wrote: >> On 19.02.2020 09:11, Juergen Gross wrote: >>> +static inline void hypfs_string_set(struct hypfs_entry_leaf *leaf, >>> +const char *str) >>> +{ >>> +leaf->content = str; >>> +

Re: [Xen-devel] [PATCH v5 8/8] xen: add runtime parameter access support to hypfs

2020-02-20 Thread Jan Beulich
On 20.02.2020 09:22, Jürgen Groß wrote: > On 19.02.20 17:44, Jan Beulich wrote: >> On 19.02.2020 09:11, Juergen Gross wrote: >>> --- a/xen/arch/arm/xen.lds.S >>> +++ b/xen/arch/arm/xen.lds.S >>> @@ -89,6 +89,11 @@ SECTIONS >>> __start_schedulers_array = .; >>> *(.data.schedulers)

Re: [Xen-devel] [RFC PATCH v3 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-02-20 Thread Roger Pau Monné
Thanks for this work, please see below. On Wed, Feb 19, 2020 at 06:04:24PM +, Anchal Agarwal wrote: > On Tue, Feb 18, 2020 at 10:16:11AM +0100, Roger Pau Monné wrote: > > On Mon, Feb 17, 2020 at 11:05:53PM +, Anchal Agarwal wrote: > > > On Mon, Feb 17, 2020 at 11:05:09AM +0100, Roger Pau

Re: [Xen-devel] [PATCH 1/2] smp: convert the cpu maps lock into a rw lock

2020-02-20 Thread Jan Beulich
On 20.02.2020 09:27, Jürgen Groß wrote: > On 20.02.20 09:13, Jan Beulich wrote: >> On 13.02.2020 12:32, Roger Pau Monne wrote: >>> Most users of the cpu maps just care about the maps not changing while >>> the lock is being held, but don't actually modify the maps. >>> >>> Convert the lock into a

Re: [Xen-devel] [PATCH v3] ns16550: Add ACPI support for ARM only

2020-02-20 Thread Jan Beulich
On 20.02.2020 08:44, Wei Xu wrote: > On 2020/2/17 21:53, Jan Beulich wrote: >> On 03.02.2020 12:21, Wei Xu wrote: >>> +static int __init ns16550_acpi_uart_init(const void *data) >>> +{ >>> +struct acpi_table_header *table; >>> +struct acpi_table_spcr *spcr; >>> +acpi_status status; >>>

Re: [Xen-devel] [PATCH] x86/vpt: update last_guest_time with cmpxchg and drop pl_time_lock

2020-02-20 Thread Jan Beulich
On 19.02.2020 19:52, Igor Druzhinin wrote: > On 19/02/2020 07:48, Jan Beulich wrote: >> On 20.12.2019 22:39, Igor Druzhinin wrote: >>> @@ -38,24 +37,22 @@ void hvm_init_guest_time(struct domain *d) >>> uint64_t hvm_get_guest_time_fixed(const struct vcpu *v, uint64_t at_tsc) >>> { >>> struct

Re: [Xen-devel] [PATCH 1/2] smp: convert the cpu maps lock into a rw lock

2020-02-20 Thread Jürgen Groß
On 20.02.20 09:13, Jan Beulich wrote: On 13.02.2020 12:32, Roger Pau Monne wrote: Most users of the cpu maps just care about the maps not changing while the lock is being held, but don't actually modify the maps. Convert the lock into a rw lock, and take the lock in read mode in get_cpu_maps

Re: [Xen-devel] [PATCH v5 8/8] xen: add runtime parameter access support to hypfs

2020-02-20 Thread Jürgen Groß
On 19.02.20 17:44, Jan Beulich wrote: On 19.02.2020 09:11, Juergen Gross wrote: --- a/docs/misc/hypfs-paths.pandoc +++ b/docs/misc/hypfs-paths.pandoc @@ -152,3 +152,12 @@ The major version of Xen. /buildinfo/version/minor = INTEGER The minor version of Xen. + + /params/ + +A

Re: [Xen-devel] [PATCH 2/2] smp: convert cpu_hotplug_begin into a blocking lock acquisition

2020-02-20 Thread Jan Beulich
On 19.02.2020 18:03, Jan Beulich wrote: > On 19.02.2020 17:08, Roger Pau Monné wrote: >> On Wed, Feb 19, 2020 at 03:07:14PM +, Andrew Cooper wrote: >>> On 19/02/2020 14:57, Jan Beulich wrote: On 19.02.2020 15:45, Roger Pau Monné wrote: > On Wed, Feb 19, 2020 at 02:44:12PM +0100, Jan

Re: [Xen-devel] [PATCH 1/2] smp: convert the cpu maps lock into a rw lock

2020-02-20 Thread Jan Beulich
On 13.02.2020 12:32, Roger Pau Monne wrote: > Most users of the cpu maps just care about the maps not changing while > the lock is being held, but don't actually modify the maps. > > Convert the lock into a rw lock, and take the lock in read mode in > get_cpu_maps and in write mode in

<    1   2