Re: [PATCH 10/12] xen/arm: if is_domain_direct_mapped use native UART address for vPL011

2020-05-08 Thread Stefano Stabellini
On Fri, 1 May 2020, Julien Grall wrote: > On 01/05/2020 02:26, Stefano Stabellini wrote: > > On Wed, 15 Apr 2020, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 15/04/2020 02:02, Stefano Stabellini wrote: > > > > We always use a fix address to map the vPL011 to domains. The address > > > >

Re: [PATCH 09/12] xen/arm: if is_domain_direct_mapped use native addresses for GICv3

2020-05-08 Thread Stefano Stabellini
On Fri, 1 May 2020, Julien Grall wrote: > Hi Stefano, > > On 01/05/2020 02:31, Stefano Stabellini wrote: > > On Wed, 15 Apr 2020, Julien Grall wrote: > > > > diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c > > > > index 4e60ba15cc..4cf430f865 100644 > > > > ---

Re: [PATCH 08/12] xen/arm: if is_domain_direct_mapped use native addresses for GICv2

2020-05-08 Thread Stefano Stabellini
On Fri, 1 May 2020, Julien Grall wrote: > On 01/05/2020 02:26, Stefano Stabellini wrote: > > On Wed, 15 Apr 2020, Julien Grall wrote: > > > On 15/04/2020 02:02, Stefano Stabellini wrote: > > > > Today we use native addresses to map the GICv2 for Dom0 and fixed > > > > addresses for DomUs. > > > >

Re: [PATCH 03/12] xen/arm: introduce 1:1 mapping for domUs

2020-05-08 Thread Stefano Stabellini
On Fri, 1 May 2020, Julien Grall wrote: > On 01/05/2020 02:26, Stefano Stabellini wrote: > > On Wed, 15 Apr 2020, Julien Grall wrote: > > > On 15/04/2020 02:02, Stefano Stabellini wrote: > > > > In some cases it is desirable to map domU memory 1:1 (guest physical == > > > > physical.) For

Re: [RFC PATCH] docs/designs: domB design document

2020-05-08 Thread Christopher Clark
On Thu, May 7, 2020 at 1:15 AM Jan Beulich wrote: > > On 06.05.2020 05:23, Christopher Clark wrote: > > +It is with this understanding as presented that the DomB project used as > > the > > +basis for the development of its multiple domain boot capability for Xen. > > Within > > +the remainder

[linux-linus test] 150081: tolerable FAIL - PUSHED

2020-05-08 Thread osstest service owner
flight 150081 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/150081/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail like 150064 test-amd64-amd64-xl-qemut-win7-amd64

[PATCH] xen/cpuhotplug: Fix initial CPU offlining for PV(H) guests

2020-05-08 Thread Boris Ostrovsky
Commit a926f81d2f6c ("xen/cpuhotplug: Replace cpu_up/down() with device_online/offline()") replaced cpu_down() with device_offline() call which requires that the CPU has been registered before. This registration, however, happens later from topology_init() which is called as subsys_initcall().

Re: [PATCH v8 12/12] x86/HVM: don't needlessly intercept APERF/MPERF/TSC MSR reads

2020-05-08 Thread Andrew Cooper
On 05/05/2020 09:20, Jan Beulich wrote: > If the hardware can handle accesses, we should allow it to do so. This > way we can expose EFRO to HVM guests, I'm reminded now of the conversation I'm sure we've had before, although I have a feeling it was on IRC. APERF/MPERF (including the EFRO

[ovmf test] 150082: all pass - PUSHED

2020-05-08 Thread osstest service owner
flight 150082 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/150082/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3a3713e62cfad00d78bb938b0d9fb1eedaeff314 baseline version: ovmf

Re: [PATCH v8 10/12] x86/HVM: scale MPERF values reported to guests (on AMD)

2020-05-08 Thread Andrew Cooper
On 05/05/2020 09:18, Jan Beulich wrote: > AMD's PM specifies that MPERF (and its r/o counterpart) reads are > affected by the TSC ratio. Hence when processing such reads in software > we too should scale the values. While we don't currently (yet) expose > the underlying feature flags, besides us

[libvirt test] 150083: regressions - FAIL

2020-05-08 Thread osstest service owner
flight 150083 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/150083/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt

Re: [PATCH v8 09/12] x86emul: support FXSAVE/FXRSTOR

2020-05-08 Thread Andrew Cooper
On 05/05/2020 09:16, Jan Beulich wrote: > Note that FPU selector handling as well as MXCSR mask saving for now > does not honor differences between host and guest visible featuresets. > > While for Intel operation of the insns with CR4.OSFXSR=0 is > implementation dependent, use the easiest

Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-08 Thread Andrew Cooper
On 08/05/2020 16:04, Jan Beulich wrote: >>> +} >>> + >>> +if ( bytes == sizeof(fpstate.env) ) >>> +ptr = NULL; >>> +else >>> +ptr += sizeof(fpstate.env); >>> +break; >>> + >>> +case sizeof(struct x87_env16):

Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-08 Thread Andrew Cooper
On 05/05/2020 09:16, Jan Beulich wrote: > While the Intel SDM claims that FRSTOR itself may raise #MF upon > completion, this was confirmed by Intel to be a doc error which will be > corrected in due course; behavior is like FLDENV, and like old hard copy > manuals describe it. Otherwise we'd have

Re: [PATCH v8 07/12] x86emul: support FNSTENV and FNSAVE

2020-05-08 Thread Andrew Cooper
On 05/05/2020 09:15, Jan Beulich wrote: > To avoid introducing another boolean into emulator state, the > rex_prefix field gets (ab)used to convey the real/VM86 vs protected mode > info (affecting structure layout, albeit not size) to x86_emul_blk(). > > Signed-off-by: Jan Beulich > --- > TBD:

[qemu-mainline test] 150077: regressions - FAIL

2020-05-08 Thread osstest service owner
flight 150077 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/150077/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 150061 Tests which did

Re: [PATCH] x86/idle: prevent entering C6 with in service interrupts on Intel

2020-05-08 Thread Roger Pau Monné
On Fri, May 08, 2020 at 03:46:08PM +0200, Jan Beulich wrote: > On 07.05.2020 15:22, Roger Pau Monne wrote: > > diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c > > index b83446e77d..5023fea148 100644 > > --- a/xen/arch/x86/acpi/cpu_idle.c > > +++

Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-08 Thread Roger Pau Monné
On Fri, May 08, 2020 at 05:04:02PM +0200, Jan Beulich wrote: > On 08.05.2020 15:37, Roger Pau Monné wrote: > > On Tue, May 05, 2020 at 10:16:20AM +0200, Jan Beulich wrote: > >> --- a/tools/tests/x86_emulator/test_x86_emulator.c > >> +++ b/tools/tests/x86_emulator/test_x86_emulator.c > >> @@

Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Roger Pau Monné
On Fri, May 08, 2020 at 05:11:35PM +0200, Jan Beulich wrote: > On 08.05.2020 17:03, Roger Pau Monné wrote: > > On Fri, May 08, 2020 at 02:43:38PM +0200, Jan Beulich wrote: > >> --- a/xen/arch/x86/hvm/io.c > >> +++ b/xen/arch/x86/hvm/io.c > >> @@ -558,6 +558,47 @@ int

Re: Xen Coding style

2020-05-08 Thread Jürgen Groß
On 08.05.20 17:50, Julien Grall wrote: On 08/05/2020 15:42, Jürgen Groß wrote: On 08.05.20 16:23, Tamas K Lengyel wrote: On Fri, May 8, 2020 at 8:18 AM Jürgen Groß wrote: On 08.05.20 14:55, Tamas K Lengyel wrote: On Fri, May 8, 2020 at 6:21 AM Julien Grall wrote: Hi Jan, On

Re: Xen Coding style

2020-05-08 Thread Julien Grall
On 08/05/2020 15:42, Jürgen Groß wrote: On 08.05.20 16:23, Tamas K Lengyel wrote: On Fri, May 8, 2020 at 8:18 AM Jürgen Groß wrote: On 08.05.20 14:55, Tamas K Lengyel wrote: On Fri, May 8, 2020 at 6:21 AM Julien Grall wrote: Hi Jan, On 08/05/2020 12:20, Jan Beulich wrote: On

[xen-4.12-testing test] 150072: tolerable FAIL - PUSHED

2020-05-08 Thread osstest service owner
flight 150072 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/150072/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qcow217 guest-localmigrate/x10 fail like 150041 test-amd64-i386-xl-pvshim12

[PATCH v8 09/12] xen: add runtime parameter access support to hypfs

2020-05-08 Thread Juergen Gross
Add support to read and modify values of hypervisor runtime parameters via the hypervisor file system. As runtime parameters can be modified via a sysctl, too, this path has to take the hypfs rw_lock as writer. For custom runtime parameters the connection between the parameter value and the file

[PATCH v8 00/12] Add hypervisor sysfs-like support

2020-05-08 Thread Juergen Gross
On the 2019 Xen developer summit there was agreement that the Xen hypervisor should gain support for a hierarchical name-value store similar to the Linux kernel's sysfs. This is a first implementation of that idea adding the basic functionality to hypervisor and tools side. The interface to any

[PATCH v8 12/12] xen: remove XEN_SYSCTL_set_parameter support

2020-05-08 Thread Juergen Gross
The functionality of XEN_SYSCTL_set_parameter is available via hypfs now, so it can be removed. This allows to remove the kernel_param structure for runtime parameters by putting the now only used structure element into the hypfs node structure of the runtime parameters. Signed-off-by: Juergen

[PATCH v8 03/12] docs: add feature document for Xen hypervisor sysfs-like support

2020-05-08 Thread Juergen Gross
On the 2019 Xen developer summit there was agreement that the Xen hypervisor should gain support for a hierarchical name-value store similar to the Linux kernel's sysfs. In the beginning there should only be basic support: entries can be added from the hypervisor itself only, there is a simple

[PATCH v8 02/12] xen: add a generic way to include binary files as variables

2020-05-08 Thread Juergen Gross
Add a new script xen/tools/binfile for including a binary file at build time being usable via a pointer and a size variable in the hypervisor. Make use of that generic tool in xsm. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Reviewed-by: Wei Liu --- V3: - new patch V4: - add

[PATCH v8 05/12] libs: add libxenhypfs

2020-05-08 Thread Juergen Gross
Add the new library libxenhypfs for access to the hypervisor filesystem. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- V1: - rename to libxenhypfs - add xenhypfs_write() V3: - major rework due to new hypervisor interface - add decompression capability V4: - add dependency to libz in

[PATCH v8 10/12] tools/libxl: use libxenhypfs for setting xen runtime parameters

2020-05-08 Thread Juergen Gross
Instead of xc_set_parameters() use xenhypfs_write() for setting parameters of the hypervisor. Signed-off-by: Juergen Gross --- V6: - new patch --- tools/Rules.mk | 2 +- tools/libxl/Makefile | 3 +- tools/libxl/libxl.c | 53

[PATCH v8 01/12] xen/vmx: let opt_ept_ad always reflect the current setting

2020-05-08 Thread Juergen Gross
In case opt_ept_ad has not been set explicitly by the user via command line or runtime parameter, it is treated as "no" on Avoton cpus. Change that handling by setting opt_ept_ad to 0 for this cpu type explicitly if no user value has been set. By putting this into the (renamed) boot time

[PATCH v8 04/12] xen: add basic hypervisor filesystem support

2020-05-08 Thread Juergen Gross
Add the infrastructure for the hypervisor filesystem. This includes the hypercall interface and the base functions for entry creation, deletion and modification. In order not to have to repeat the same pattern multiple times in case adding a new node should BUG_ON() failure, the helpers for

[PATCH v8 11/12] tools/libxc: remove xc_set_parameters()

2020-05-08 Thread Juergen Gross
There is no user of xc_set_parameters() left, so remove it. Signed-off-by: Juergen Gross --- V6: - new patch --- tools/libxc/include/xenctrl.h | 1 - tools/libxc/xc_misc.c | 21 - 2 files changed, 22 deletions(-) diff --git a/tools/libxc/include/xenctrl.h

[PATCH v8 07/12] xen: provide version information in hypfs

2020-05-08 Thread Juergen Gross
Provide version and compile information in /buildinfo/ node of the Xen hypervisor file system. As this information is accessible by dom0 only no additional security problem arises. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V3: - new patch V4: - add __read_mostly annotations

[PATCH v8 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

2020-05-08 Thread Juergen Gross
Add the /buildinfo/config entry to the hypervisor filesystem. This entry contains the .config file used to build the hypervisor. Signed-off-by: Juergen Gross --- V3: - store data in gzip format - use binfile mechanism to create data file - move code to kernel.c V6: - add config item for the

[PATCH v8 06/12] tools: add xenfs tool

2020-05-08 Thread Juergen Gross
Add the xenfs tool for accessing the hypervisor filesystem. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- V1: - rename to xenhypfs - don't use "--" for subcommands - add write support V2: - escape non-printable characters per default with cat subcommand (Ian Jackson) - add -b option to

Re: [PATCH] tools/libxc: Reduce feature handling complexity in xc_cpuid_apply_policy()

2020-05-08 Thread Andrew Cooper
Tools ping? ~Andrew On 03/03/2020 18:23, Andrew Cooper wrote: > xc_cpuid_apply_policy() is gaining extra parameters to untangle CPUID > complexity in Xen. While an improvement in general, it does have the > unfortunate side effect of duplicating some settings across muliple > parameters. > >

[PATCH] x86/gen-cpuid: Distinguish default vs max in feature annotations

2020-05-08 Thread Andrew Cooper
Allow lowercase a/s/h to be used to annotate a non-default feature. However, until the toolstack migration logic is fixed, it is not safe to activate yet. Tolerate the annotations, but ignore them for now. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu

Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Jan Beulich
On 08.05.2020 17:03, Roger Pau Monné wrote: > On Fri, May 08, 2020 at 02:43:38PM +0200, Jan Beulich wrote: >> --- a/xen/arch/x86/hvm/io.c >> +++ b/xen/arch/x86/hvm/io.c >> @@ -558,6 +558,47 @@ int register_vpci_mmcfg_handler(struct d >> return 0; >> } >> >> +int

Re: [PATCH v8 04/12] x86emul: support SERIALIZE

2020-05-08 Thread Andrew Cooper
On 08/05/2020 14:59, Jan Beulich wrote: > On 08.05.2020 15:00, Andrew Cooper wrote: >> On 08/05/2020 08:34, Jan Beulich wrote: > @@ -5660,6 +5661,18 @@ x86_emulate( > goto done; > break; > > +case 0xe8: > +switch ( vex.pfx

Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-08 Thread Jan Beulich
On 08.05.2020 15:37, Roger Pau Monné wrote: > On Tue, May 05, 2020 at 10:16:20AM +0200, Jan Beulich wrote: >> --- a/tools/tests/x86_emulator/test_x86_emulator.c >> +++ b/tools/tests/x86_emulator/test_x86_emulator.c >> @@ -2442,6 +2442,27 @@ int main(int argc, char **argv) >> else >>

Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Roger Pau Monné
On Fri, May 08, 2020 at 02:43:38PM +0200, Jan Beulich wrote: > The op has a register/unregister flag, and hence registration shouldn't > happen unilaterally. Introduce unregister_vpci_mmcfg_handler() to handle > this case. > > Fixes: eb3dd90e4089 ("x86/physdev: enable PHYSDEVOP_pci_mmcfg_reserved

Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Roger Pau Monné
On Fri, May 08, 2020 at 03:49:35PM +0200, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 08.05.2020 14:54, Andrew Cooper wrote: > > On 08/05/2020 13:43, Jan Beulich wrote: >

Re: Xen Coding style

2020-05-08 Thread Jürgen Groß
On 08.05.20 16:23, Tamas K Lengyel wrote: On Fri, May 8, 2020 at 8:18 AM Jürgen Groß wrote: On 08.05.20 14:55, Tamas K Lengyel wrote: On Fri, May 8, 2020 at 6:21 AM Julien Grall wrote: Hi Jan, On 08/05/2020 12:20, Jan Beulich wrote: On 08.05.2020 12:00, Julien Grall wrote: You seem to

Re: [PATCH v8 05/12] x86emul: support X{SUS,RES}LDTRK

2020-05-08 Thread Jan Beulich
On 08.05.2020 15:15, Andrew Cooper wrote: > On 08/05/2020 08:38, Jan Beulich wrote: >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments >> unless you have verified the sender and know the content is safe. >> >> On 07.05.2020 22:13, Andrew Cooper wrote: >>> On 05/05/2020

Re: Xen Coding style

2020-05-08 Thread Tamas K Lengyel
On Fri, May 8, 2020 at 8:18 AM Jürgen Groß wrote: > > On 08.05.20 14:55, Tamas K Lengyel wrote: > > On Fri, May 8, 2020 at 6:21 AM Julien Grall wrote: > >> > >> Hi Jan, > >> > >> On 08/05/2020 12:20, Jan Beulich wrote: > >>> On 08.05.2020 12:00, Julien Grall wrote: > You seem to be the

Re: Xen Coding style

2020-05-08 Thread Jürgen Groß
On 08.05.20 14:55, Tamas K Lengyel wrote: On Fri, May 8, 2020 at 6:21 AM Julien Grall wrote: Hi Jan, On 08/05/2020 12:20, Jan Beulich wrote: On 08.05.2020 12:00, Julien Grall wrote: You seem to be the maintainer with the most unwritten rules. Would you mind to have a try at writing a

Re: [PATCH v8 04/12] x86emul: support SERIALIZE

2020-05-08 Thread Jan Beulich
On 08.05.2020 15:00, Andrew Cooper wrote: > On 08/05/2020 08:34, Jan Beulich wrote: @@ -5660,6 +5661,18 @@ x86_emulate( goto done; break; +case 0xe8: +switch ( vex.pfx ) +{ +case

Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Jan Beulich
On 08.05.2020 14:54, Andrew Cooper wrote: > On 08/05/2020 13:43, Jan Beulich wrote: >> The op has a register/unregister flag, and hence registration shouldn't >> happen unilaterally. Introduce unregister_vpci_mmcfg_handler() to handle >> this case. >> >> Fixes: eb3dd90e4089 ("x86/physdev: enable

Re: [PATCH] x86/idle: prevent entering C6 with in service interrupts on Intel

2020-05-08 Thread Jan Beulich
On 07.05.2020 15:22, Roger Pau Monne wrote: > Apply a workaround for Intel errata CLX30: "A Pending Fixed Interrupt > May Be Dispatched Before an Interrupt of The Same Priority Completes". > > It's not clear which models are affected, as the errata is listed in > the "Second Generation Intel Xeon

Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-08 Thread Roger Pau Monné
On Tue, May 05, 2020 at 10:16:20AM +0200, Jan Beulich wrote: > While the Intel SDM claims that FRSTOR itself may raise #MF upon > completion, this was confirmed by Intel to be a doc error which will be > corrected in due course; behavior is like FLDENV, and like old hard copy > manuals describe

Re: [PATCH v8 05/12] x86emul: support X{SUS,RES}LDTRK

2020-05-08 Thread Andrew Cooper
On 08/05/2020 08:38, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 07.05.2020 22:13, Andrew Cooper wrote: >> On 05/05/2020 09:14, Jan Beulich wrote: >>> ---

Re: [PATCH v2 2/3] various: Remove unnecessary OBJECT() cast

2020-05-08 Thread Philippe Mathieu-Daudé
On 5/8/20 2:49 PM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: The OBJECT() macro is defined as: #define OBJECT(obj) ((Object *)(obj)) which expands to: ((Object *)object_dynamic_cast_assert((Object *)(obj), (name), __FILE__,

Re: [PATCH v8 04/12] x86emul: support SERIALIZE

2020-05-08 Thread Andrew Cooper
On 08/05/2020 08:34, Jan Beulich wrote: >>> @@ -5660,6 +5661,18 @@ x86_emulate( >>> goto done; >>> break; >>> >>> +case 0xe8: >>> +switch ( vex.pfx ) >>> +{ >>> +case vex_none: /* serialize */ >>> +

Re: Xen Coding style

2020-05-08 Thread Tamas K Lengyel
On Fri, May 8, 2020 at 6:21 AM Julien Grall wrote: > > Hi Jan, > > On 08/05/2020 12:20, Jan Beulich wrote: > > On 08.05.2020 12:00, Julien Grall wrote: > >> You seem to be the maintainer with the most unwritten rules. Would > >> you mind to have a try at writing a coding style based on it? > > >

Re: [PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Andrew Cooper
On 08/05/2020 13:43, Jan Beulich wrote: > The op has a register/unregister flag, and hence registration shouldn't > happen unilaterally. Introduce unregister_vpci_mmcfg_handler() to handle > this case. > > Fixes: eb3dd90e4089 ("x86/physdev: enable PHYSDEVOP_pci_mmcfg_reserved for > PVH Dom0") >

Re: [PATCH v2 1/3] target: Remove unnecessary CPU() cast

2020-05-08 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > The CPU() macro is defined as: > > #define CPU(obj) ((CPUState *)(obj)) > > which expands to: > > ((CPUState *)object_dynamic_cast_assert((Object *)(obj), (name), > __FILE__, __LINE__, __func__)) > > This assertion

Re: [PATCH v2 2/3] various: Remove unnecessary OBJECT() cast

2020-05-08 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > The OBJECT() macro is defined as: > > #define OBJECT(obj) ((Object *)(obj)) > > which expands to: > > ((Object *)object_dynamic_cast_assert((Object *)(obj), (name), > __FILE__, __LINE__, __func__)) Nope :) > This

Re: [PATCH v2 3/3] hw: Remove unnecessary DEVICE() cast

2020-05-08 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > The DEVICE() macro is defined as: > > #define DEVICE(obj) OBJECT_CHECK(DeviceState, (obj), TYPE_DEVICE) > > which expands to: > > ((DeviceState *)object_dynamic_cast_assert((Object *)(obj), (name), > __FILE__,

[PATCH] x86/PVH: PHYSDEVOP_pci_mmcfg_reserved should not blindly register a region

2020-05-08 Thread Jan Beulich
The op has a register/unregister flag, and hence registration shouldn't happen unilaterally. Introduce unregister_vpci_mmcfg_handler() to handle this case. Fixes: eb3dd90e4089 ("x86/physdev: enable PHYSDEVOP_pci_mmcfg_reserved for PVH Dom0") Signed-off-by: Jan Beulich ---

Re: Xen Coding style

2020-05-08 Thread Julien Grall
Hi Jan, On 08/05/2020 12:20, Jan Beulich wrote: On 08.05.2020 12:00, Julien Grall wrote: You seem to be the maintainer with the most unwritten rules. Would you mind to have a try at writing a coding style based on it? On the basis that even small, single aspect patches to CODING_STYLE have

[xen-unstable-smoke test] 150088: tolerable all pass - PUSHED

2020-05-08 Thread osstest service owner
flight 150088 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150088/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[xen-4.13-testing test] 150073: tolerable FAIL - PUSHED

2020-05-08 Thread osstest service owner
flight 150073 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/150073/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 16 guest-localmigrate fail REGR. vs. 150042 Tests which did not

Re: Xen Coding style

2020-05-08 Thread Jan Beulich
On 08.05.2020 12:00, Julien Grall wrote: > You seem to be the maintainer with the most unwritten rules. Would > you mind to have a try at writing a coding style based on it? On the basis that even small, single aspect patches to CODING_STYLE have been ignored [1], I don't think this would be a

Re: [PATCH v3] accel: Move Xen accelerator code under accel/xen/

2020-05-08 Thread Juan Quintela
Philippe Mathieu-Daudé wrote: > This code is not related to hardware emulation. > Move it under accel/ with the other hypervisors. > > Reviewed-by: Paul Durrant > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

[PATCH v3] accel: Move Xen accelerator code under accel/xen/

2020-05-08 Thread Philippe Mathieu-Daudé
This code is not related to hardware emulation. Move it under accel/ with the other hypervisors. Reviewed-by: Paul Durrant Signed-off-by: Philippe Mathieu-Daudé --- We could also move the memory management functions from hw/i386/xen/xen-hvm.c but it is not trivial. v2: Use

Re: Xen Coding style

2020-05-08 Thread Julien Grall
On 08/05/2020 09:36, Jan Beulich wrote: On 07.05.2020 16:43, Julien Grall wrote: This was originally discussed during the last community call. A major part of the comments during review is related to coding style issues. This can lead to frustration from the contributor as the current

Re: [PATCH v2 1/2] exec: Check Xen is enabled before calling the Xen API

2020-05-08 Thread Philippe Mathieu-Daudé
Hi Juan, On 5/8/20 10:39 AM, Juan Quintela wrote: Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- include/exec/ram_addr.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h index

Re: [PATCH v2 1/2] exec: Check Xen is enabled before calling the Xen API

2020-05-08 Thread Juan Quintela
Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/exec/ram_addr.h | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h > index 5e59a3d8d7..dd8713179e 100644 > ---

Re: Xen Coding style

2020-05-08 Thread Jan Beulich
On 07.05.2020 16:43, Julien Grall wrote: > This was originally discussed during the last community call. > > A major part of the comments during review is related to coding style issues. > This can lead to frustration from the contributor as the current CODING_STYLE > is quite light and the

Re: [PATCH 3/3] xen/cpupool: fix removing cpu from a cpupool

2020-05-08 Thread Jürgen Groß
On 08.05.20 10:19, Jan Beulich wrote: On 07.05.2020 20:36, Dario Faggioli wrote: On Thu, 2020-04-30 at 17:15 +0200, Juergen Gross wrote: Commit cb563d7665f2 ("xen/sched: support core scheduling for moving cpus to/from cpupools") introduced a regression when trying to remove an offline cpu from

Re: [PATCH 3/3] xen/cpupool: fix removing cpu from a cpupool

2020-05-08 Thread Jan Beulich
On 07.05.2020 20:36, Dario Faggioli wrote: > On Thu, 2020-04-30 at 17:15 +0200, Juergen Gross wrote: >> Commit cb563d7665f2 ("xen/sched: support core scheduling for moving >> cpus to/from cpupools") introduced a regression when trying to remove >> an offline cpu from a cpupool, as the system would

Re: [PATCH v8 01/12] x86emul: disable FPU/MMX/SIMD insn emulation when !HVM

2020-05-08 Thread Jan Beulich
On 07.05.2020 20:11, Andrew Cooper wrote: > On 05/05/2020 09:12, Jan Beulich wrote: >> In a pure PV environment (the PV shim in particular) we don't really >> need emulation of all these. To limit #ifdef-ary utilize some of the >> CASE_*() macros we have, by providing variants expanding to >>

[PATCH v2 2/2] accel: Move Xen accelerator code under accel/xen/

2020-05-08 Thread Philippe Mathieu-Daudé
This code is not related to hardware emulation. Move it under accel/ with the other hypervisors. Reviewed-by: Paul Durrant Signed-off-by: Philippe Mathieu-Daudé --- We could also move the memory management functions from hw/i386/xen/xen-hvm.c but it is not trivial. v2: Use

[PATCH v2 1/2] exec: Check Xen is enabled before calling the Xen API

2020-05-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/exec/ram_addr.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h index 5e59a3d8d7..dd8713179e 100644 --- a/include/exec/ram_addr.h +++ b/include/exec/ram_addr.h @@

[PATCH v2 0/2] accel: Move Xen accelerator code under accel/xen/

2020-05-08 Thread Philippe Mathieu-Daudé
Supersedes: <20200507155813.16169-1-phi...@redhat.com> Philippe Mathieu-Daudé (2): exec: Check Xen is enabled before calling the Xen API accel: Move Xen accelerator code under accel/xen/ include/exec/ram_addr.h| 10 -- include/hw/xen/xen.h | 11

Re: [PATCH v2 1/4] x86/mm: no-one passes a NULL domain to init_xen_l4_slots()

2020-05-08 Thread Jan Beulich
On 07.05.2020 19:26, Andrew Cooper wrote: > On 05/05/2020 07:31, Jan Beulich wrote: >> On 21.04.2020 18:40, Roger Pau Monné wrote: >>> On Tue, Apr 21, 2020 at 11:11:03AM +0200, Jan Beulich wrote: Drop the NULL checks - they've been introduced by commit 8d7b633ada ("x86/mm: Consolidate

Re: [PATCH v8 05/12] x86emul: support X{SUS,RES}LDTRK

2020-05-08 Thread Jan Beulich
On 07.05.2020 22:13, Andrew Cooper wrote: > On 05/05/2020 09:14, Jan Beulich wrote: >> --- a/xen/tools/gen-cpuid.py >> +++ b/xen/tools/gen-cpuid.py >> @@ -284,6 +284,9 @@ def crunch_numbers(state): >> # as dependent features simplifies Xen's logic, and prevents the >> guest >> #

Re: [bug report] drm/xen-front: Add support for Xen PV display frontend

2020-05-08 Thread Oleksandr Andrushchenko
On 4/21/20 2:51 PM, Dan Carpenter wrote: > It turns out there aren't that many of these in xen. > > $ grep IS_ERR_OR_NULL drivers/gpu/drm/xen/ -Rn > drivers/gpu/drm/xen/xen_drm_front_kms.c:63: if (IS_ERR_OR_NULL(fb)) > drivers/gpu/drm/xen/xen_drm_front_gem.c:86: if

Re: [PATCH v8 04/12] x86emul: support SERIALIZE

2020-05-08 Thread Jan Beulich
On 07.05.2020 21:32, Andrew Cooper wrote: > On 05/05/2020 09:14, Jan Beulich wrote: >> ... enabling its use by all guest kinds at the same time. >> >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper Thanks. >> @@ -5660,6 +5661,18 @@ x86_emulate( >> goto done; >>

Re: [PATCH v8 03/12] x86emul: support ENQCMD insns

2020-05-08 Thread Jan Beulich
On 07.05.2020 20:59, Andrew Cooper wrote: > On 05/05/2020 09:13, Jan Beulich wrote: >> Note that the ISA extensions document revision 038 doesn't specify >> exception behavior for ModRM.mod == 0b11; assuming #UD here. > > Stale. In which way (beyond the question of whether to use goto

Re: [PATCH v8 02/12] x86emul: support MOVDIR{I,64B} insns

2020-05-08 Thread Jan Beulich
On 07.05.2020 20:30, Andrew Cooper wrote: > On 05/05/2020 09:13, Jan Beulich wrote: >> Introduce a new blk() hook, paralleling the rmw() one in a certain way, >> but being intended for larger data sizes, and hence its HVM intermediate >> handling function doesn't fall back to splitting the

Re: [PATCH v8 06/12] x86/HVM: make hvmemul_blk() capable of handling r/o operations

2020-05-08 Thread Jan Beulich
On 07.05.2020 22:34, Andrew Cooper wrote: > On 05/05/2020 09:15, Jan Beulich wrote: >> In preparation for handling e.g. FLDENV or {F,FX,X}RSTOR here as well. >> >> Signed-off-by: Jan Beulich >> --- >> v8: New (could be folded into "x86emul: support MOVDIR{I,64B} insns", >> but would

[linux-5.4 test] 150070: regressions - FAIL

2020-05-08 Thread osstest service owner
flight 150070 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/150070/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 149905 Regressions which

[xen-4.9-testing test] 150068: regressions - trouble: fail/pass/starved

2020-05-08 Thread osstest service owner
flight 150068 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/150068/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail in 150038 REGR. vs. 149649 Tests