Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

Hi Anchal, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.7-rc6] [cannot apply to xen-tip/linux-next tip/irq/core tip/auto-latest next-20200519] [if your patch is applied to the wrong git tree, please drop us a note to help

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

Hi Anchal, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.7-rc6] [cannot apply to xen-tip/linux-next tip/irq/core tip/auto-latest next-20200519] [if your patch is applied to the wrong git tree, please drop us a note to help

[xen-unstable test] 150247: regressions - FAIL

flight 150247 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/150247/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 150227 Tests which did

Re: grant table issues mapping a ring order 10

On 5/19/20 5:21 PM, Stefano Stabellini wrote: > Hi Juergen, Boris, > > I am trying to increase the size of the rings used for Xen 9pfs > connections for performance reasons and also to reduce the likehood of > the backend having to wait on the frontend to free up space from the > ring. > > FYI I

Re: [PATCH for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4

On Tue, May 19, 2020 at 8:28 PM Roman Shaposhnik wrote: > > On Tue, May 19, 2020, 7:15 PM Tamas K Lengyel > wrote: >> >> On Tue, May 19, 2020 at 5:50 PM Roman Shaposhnik wrote: >> > >> > On Tue, May 19, 2020 at 4:44 PM Tamas K Lengyel >> > wrote: >> > > >> > > On Tue, May 19, 2020 at 11:23 AM

Re: [PATCH for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4

On Tue, May 19, 2020, 7:15 PM Tamas K Lengyel wrote: > On Tue, May 19, 2020 at 5:50 PM Roman Shaposhnik wrote: > > > > On Tue, May 19, 2020 at 4:44 PM Tamas K Lengyel > > wrote: > > > > > > On Tue, May 19, 2020 at 11:23 AM Julien Grall wrote: > > > > > > > > > > > > > > > > On 19/05/2020

Re: [PATCH for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4

On Tue, May 19, 2020 at 5:50 PM Roman Shaposhnik wrote: > > On Tue, May 19, 2020 at 4:44 PM Tamas K Lengyel > wrote: > > > > On Tue, May 19, 2020 at 11:23 AM Julien Grall wrote: > > > > > > > > > > > > On 19/05/2020 04:08, Tamas K Lengyel wrote: > > > > On Mon, May 18, 2020 at 5:32 AM Julien

[linux-linus test] 150244: tolerable FAIL - PUSHED

flight 150244 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/150244/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 11 guest-start fail in 150236 pass in 150244 test-armhf-armhf-xl-rtds 16

[xen-unstable-smoke test] 150265: tolerable all pass - PUSHED

flight 150265 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150265/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4

On Tue, 19 May 2020, Tamas K Lengyel wrote: > On Tue, May 19, 2020 at 11:23 AM Julien Grall wrote: > > > > > > > > On 19/05/2020 04:08, Tamas K Lengyel wrote: > > > On Mon, May 18, 2020 at 5:32 AM Julien Grall wrote: > > >> > > >> From: Julien Grall > > >> > > >> Hi all, > > >> > > >> At the

Re: [PATCH for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4

On Tue, May 19, 2020 at 4:44 PM Tamas K Lengyel wrote: > > On Tue, May 19, 2020 at 11:23 AM Julien Grall wrote: > > > > > > > > On 19/05/2020 04:08, Tamas K Lengyel wrote: > > > On Mon, May 18, 2020 at 5:32 AM Julien Grall wrote: > > >> > > >> From: Julien Grall > > >> > > >> Hi all, > > >> >

Re: [PATCH for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4

On Tue, May 19, 2020 at 11:23 AM Julien Grall wrote: > > > > On 19/05/2020 04:08, Tamas K Lengyel wrote: > > On Mon, May 18, 2020 at 5:32 AM Julien Grall wrote: > >> > >> From: Julien Grall > >> > >> Hi all, > >> > >> At the moment, a user who wants to boot Xen on the Raspberry Pi 4 can > >>

Re: [RFC] UEFI Secure Boot on Xen Hosts

On Wed, Apr 29, 2020 at 05:51:08PM -0500, Bobby Eshleman wrote: > > # Option #1: PE/COFF and Shim > ... snip ... > > # Option #3: Lean on Grub2's LoadFile2() Verification > ... snip ... It's safe to say that the options boiled down to #1 and #3. Seeing as how we may not be able to start

Re: [PATCH 05/12] genirq: Shutdown irq chips in suspend/resume during hibernation

Thanks. Looks like send an old one without fix. Did resend the patch again. On Tue, 2020-05-19 at 23:26 +, Anchal Agarwal wrote: > Signed-off--by: Thomas Gleixner The Signed-off-by line needs to be fixed (hint: you have --) Balbir Singh

[PATCH 12/12] PM / hibernate: update the resume offset on SNAPSHOT_SET_SWAP_AREA

From: Aleksei Besogonov The SNAPSHOT_SET_SWAP_AREA is supposed to be used to set the hibernation offset on a running kernel to enable hibernating to a swap file. However, it doesn't actually update the swsusp_resume_block variable. As a result, the hibernation fails at the last step (after all

Re: [PATCH 05/12] genirq: Shutdown irq chips in suspend/resume during hibernation

On Tue, 2020-05-19 at 23:26 +, Anchal Agarwal wrote: > Signed-off--by: Thomas Gleixner The Signed-off-by line needs to be fixed (hint: you have --) Balbir Singh

[PATCH 07/12] xen-netfront: add callbacks for PM suspend and hibernation

From: Munehisa Kamata Add freeze, thaw and restore callbacks for PM suspend and hibernation support. The freeze handler simply disconnects the frotnend from the backend and frees resources associated with queues after disabling the net_device from the system. The restore handler just changes the

[PATCH 05/12] genirq: Shutdown irq chips in suspend/resume during hibernation

Many legacy device drivers do not implement power management (PM) functions which means that interrupts requested by these drivers stay in active state when the kernel is hibernated. This does not matter on bare metal and on most hypervisors because the interrupt is restored on resume without any

[PATCH 04/12] x86/xen: add system core suspend and resume callbacks

From: Munehisa Kamata Add Xen PVHVM specific system core callbacks for PM suspend and hibernation support. The callbacks suspend and resume Xen primitives,like shared_info, pvclock and grant table. Note that Xen suspend can handle them in a different manner, but system core callbacks are called

[PATCH 01/12] xen/manage: keep track of the on-going suspend mode

From: Munehisa Kamata Guest hibernation is different from xen suspend/resume/live migration. Xen save/restore does not use pm_ops as is needed by guest hibernation. Hibernation in guest follows ACPI path and is guest inititated , the hibernation image is saved within guest as compared to later

grant table issues mapping a ring order 10

Hi Juergen, Boris, I am trying to increase the size of the rings used for Xen 9pfs connections for performance reasons and also to reduce the likehood of the backend having to wait on the frontend to free up space from the ring. FYI I realized that we cannot choose order 11 or greater in Linux

[xen-unstable-smoke test] 150249: tolerable all pass

flight 150249 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150249/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[OSSTEST PATCH 26/38] 20_linux_xen: Adhoc template substitution

This file is a template that various build-time variables get substituted into. Make thos substitutions by hand (actually, by copying the values our file for stretch). And rename the file. So now we are using our file instead of the grub package's. But it is the same... Signed-off-by: Ian

[OSSTEST PATCH 22/38] buster: Extend guest bootloader workaround

CC: Julien Grall CC: Stefano Stabellini Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 6fed0b75..77508d19 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -1064,7 +1064,7

[OSSTEST PATCH 15/38] buster: make-hosts-flight: Add to possible suites for hosts flight

Signed-off-by: Ian Jackson --- make-hosts-flight | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/make-hosts-flight b/make-hosts-flight index 92da1c7c..e2c3776a 100755 --- a/make-hosts-flight +++ b/make-hosts-flight @@ -26,7 +26,7 @@ blessing=$4 buildflight=$5 :

[OSSTEST PATCH 23/38] Honour DebianImageFile_SUITE_ARCH

This lets us specify the whole filename, not just a version. This is needed because for buster we are going to use debian-10.2.0-ARCH-xfce-CD-1.iso Signed-off-by: Ian Jackson --- mfi-common | 9 + 1 file changed, 9 insertions(+) diff --git a/mfi-common b/mfi-common index

[OSSTEST PATCH 27/38] 20_linux_xen: Ignore xenpolicy and config files too

"file_is_not_sym" currently only checks for xen-syms. Extend it to disregard xenpolicy (XSM policy files) and files ending .config (which are built by the Xen upstream build system in some configurations and can therefore end up in /boot). Rename the function accordingly, to

[OSSTEST PATCH 31/38] overlay-initrd-buster/sbin/reopen-console: Fix #932416

This bug affects us. Cherry pick the changes to the relevant file from the commit in the upstream debian-installer repo: https://salsa.debian.org/installer-team/rootskel/commit/0ee43d05b83f8ef5a856f3282e002a111809cef9 Signed-off-by: Ian Jackson --- overlay-initrd-buster/sbin/reopen-console

[OSSTEST PATCH 33/38] buster: Provide TftpDiVersion

Signed-off-by: Ian Jackson --- production-config | 1 + 1 file changed, 1 insertion(+) diff --git a/production-config b/production-config index e3870d47..6372ac9a 100644 --- a/production-config +++ b/production-config @@ -91,6 +91,7 @@ TftpNetbootGroup osstest TftpDiVersion_wheezy 2016-06-08

[OSSTEST PATCH 16/38] buster: Extend grub2 uefi no install workaround

src:grub2 is RFH in Debian, which is a contributory factor to these patches in #789798 and #792547 languishing. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 8380c428..0958d080

[OSSTEST PATCH 28/38] 20_linux_xen: Support Xen Security Modules (XSM/FLASK)

XSM is enabled by adding "flask=enforcing" as a Xen command line argument, and providing the policy file as a grub module. We make entries for both with and without XSM. If XSM is not compiled into Xen, then there are no policy files, so no change to the boot options. Signed-off-by: Ian Jackson

[OSSTEST PATCH 20/38] buster: ts-host-install: NTP not honoured bug remains

Debian #778564 remains open. Signed-off-by: Ian Jackson --- ts-host-install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-install b/ts-host-install index fe26f70f..253dbb5d 100755 --- a/ts-host-install +++ b/ts-host-install @@ -152,7 +152,7 @@ END my

[OSSTEST PATCH 11/38] ts-debian-di-install: Provide guest with more RAM

buster cannot boot in so little because its initramfs and kernel are too large. Bump it to 2G. However, our armhf test nodes have very little RAM. And the Debian armhf does fit in them as a guest still, so use a smaller value there. Keying this off the architecture rather than the available

[OSSTEST PATCH 25/38] 20_linux_xen: Copy Debian buster version into our initramfs area

This is from 41e42571ebc50fa351cd63ce40044946652c5c72 in Debian's grub package. We are going to want to modify this to support XSM/FLASK and cope with upstream build outputs. In this commit we dump the exact file contents across. It's not effective right now because of the ".in" extension. In

[OSSTEST PATCH 24/38] buster: Specify DebianImageFile_SUITE_ARCH

Signed-off-by: Ian Jackson --- production-config | 3 +++ 1 file changed, 3 insertions(+) diff --git a/production-config b/production-config index 103b8915..f0ddc132 100644 --- a/production-config +++ b/production-config @@ -98,6 +98,9 @@ DebianSnapshotBackports_jessie

[OSSTEST PATCH 12/38] Debian: preseed: use priority= alias

This marginally reduces command line clobber. This alias has been supported approximately forever. (And this code is currently only used when DebconfPriority is set, which it generally isn't.) Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1

[OSSTEST PATCH 14/38] Honour 'LinuxSerialConsole ' host property

This works like LinuxSerialConsole. I originally wrote this to try to work around #940028, where multiple d-i autoinstalls run in parallel leading to hard-to-debug lossage! Explicitly specing the console causes it to run only on that one. However, it turns out that explicitly specifying the

[OSSTEST PATCH 13/38] Debian: Specify `priority=critical' rather than locale

In buster, it appears that specifying locale on the command line is not sufficient. Rather than adding more things to the command line, instead, just say `priority=critical', by defaulting $debconf_priority to 'critical'. I think this change should be fine for earlier suites too. Signed-off-by:

[OSSTEST PATCH 18/38] buster: Deinstall the "systemd" package

This installs a pam rule which causes logins to hang. It also seems to cause some kind of udev wedge. We are using sysvinit so this package is not desirable. Empirically, removing it makes the system work. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 1 + 1 file changed, 1 insertion(+)

[OSSTEST PATCH 10/38] Debian guests: Write systemd random seed file

This involves a new ts-debian-di-fixup script, which runs after xen-tools. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 14 ++ sg-run-job | 1 + ts-debian-di-fixup | 29 + ts-debian-fixup| 1 + 4 files changed, 45 insertions(+)

[OSSTEST PATCH 38/38] buster: Switch to Debian buster as the default suite

Signed-off-by: Ian Jackson --- Osstest.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest.pm b/Osstest.pm index 1e381d8f..6395 100644 --- a/Osstest.pm +++ b/Osstest.pm @@ -87,7 +87,7 @@ our %c = qw( Images images -DebianSuite stretch +DebianSuite

[OSSTEST PATCH 36/38] buster: setupboot_grub2: Handle missing policy file bug

This is a complex interaction between update-grub and the Xen build system on ARM64. Not sure exactly who to blame but since we have our own 20_linux_xen bodge, let's wait until we don't. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 12 +++- 1 file changed, 11 insertions(+), 1

[OSSTEST PATCH 19/38] buster: preseed partman-auto-lvm/guided_size

Otherwise we get this question: | You may use the whole volume group for guided partitioning, or part | of it. [...] | Amount of volume group to use for guided partitioning: Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 1 + 1 file changed, 1 insertion(+) diff --git

[OSSTEST PATCH 30/38] overlay-initrd-buster/sbin/reopen-console: Copy from Debian

We are going to patch this file to work around a bug, using the new overlay mechanism. The first step is to include the file in our overlay so we overwrite it. Currently, this is a no-op, so no functional change. Signed-off-by: Ian Jackson --- overlay-initrd-buster/sbin/reopen-console | 94

[OSSTEST PATCH 17/38] buster: ts-host-install: Extend net.ifnames workaround

Really we should fix this by making a .deb in Debian that we could install. But this is a longer-term project. Signed-off-by: Ian Jackson --- ts-host-install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-install b/ts-host-install index 7a72a867..fe26f70f 100755

[OSSTEST PATCH 29/38] mg-debian-installer-update: support overlay-intramfs-SUITE

This lets us patch the installer more easily. No uses yet. Signed-off-by: Ian Jackson --- mg-debian-installer-update | 20 1 file changed, 20 insertions(+) diff --git a/mg-debian-installer-update b/mg-debian-installer-update index f1e682f9..fb4fe2ab 100755 ---

[OSSTEST PATCH 21/38] buster: Extend ARM clock workaround

CC: Julien Grall CC: Stefano Stabellini Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index bec72788..6fed0b75 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -248,7 +248,7 @@

[OSSTEST PATCH 32/38] buster: chiark-scripts: Install a new version on buster too

We need various fixes that are not in buster, sadly. Signed-off-by: Ian Jackson --- production-config | 1 + 1 file changed, 1 insertion(+) diff --git a/production-config b/production-config index f0ddc132..e3870d47 100644 --- a/production-config +++ b/production-config @@ -107,6 +107,7 @@

[OSSTEST PATCH 34/38] buster: grub, arm64: extend chainloading workaround

multiboot[2] isn't supported. Also link to the bug report. CC: Julien Grall CC: Stefano Stabellini Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 77508d19..151677ed 100644 ---

[OSSTEST PATCH 35/38] buster: setupboot_grub2: Note what files exist in /boot

Nothing uses this yet. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 151677ed..c0b669c9 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -448,6 +448,11 @@ sub setupboot_grub2 ()

[OSSTEST PATCH 37/38] buster: Extend workaround for dhcpd EROFS bug

Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 6c289cc7..e1ce757e 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -1617,7 +1617,7 @@ sub debian_dhcp_rofs_fix ($$) { #

[OSSTEST PATCH 09/38] Bodge systemd random seed arrangements

systemd does not regard the contents of the random seed file as useful for the purposes of placating the kernel's entropy tracker. As a result, the system hangs at boot waiting for entropy. Fix this by providing a small program which can be used to load a seed file into /dev/random and also call

[OSSTEST PATCH 04/38] TestSupport: allow more time for apt

Empirically some of these operations can take longer than 30s, especially with a cold cache. Note that because of host sharing and our on-host apt lock, the timeout needs to be the same for every apt operation: a fast operation could be blocked behind a slow one. Signed-off-by: Ian Jackson ---

[OSSTEST PATCH 07/38] setupboot_grub2: Drop $submenu variable

We really only used this to check how many levels deep in { we are. That can be done by checking $#offsets, which is >0 if we are in a submenu and not otherwise. We lose the ability to report the start line of the submenu, but that's OK. But as a bonus, we no longer bomb out on nested submenus:

[OSSTEST PATCH 02/38] ts-xen-build-prep: Install rsync

osstest uses this for transferring configuration, build artefacts, and so on. In Debian stretch and earlier, rsync happened to be pulled in by something else. Signed-off-by: Ian Jackson --- ts-xen-build-prep | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-xen-build-prep

[OSSTEST PATCH 06/38] di_installcmdline_core: Pass locale on d-i command line

In buster, d-i wants when setting up the network, ie before the preseed is loaded. We leave it in the preseed too because why not. I think this change should be fine for older versions of Debian. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 3 ++- 1 file changed, 2 insertions(+), 1

[OSSTEST PATCH 05/38] Booting: Use `--' rather than `---' to introduce host cmdline

Because systemd did something obnoxious, the kernel retaliated in the game of Core Wars by hiding all arguments before `--' from userspace. So use `---' instead so that all the arguments remain visible. This in some sense now applies to host installs a change we had already made to Debian HVM

[OSSTEST PATCH 08/38] ts-leak-check: Ignore buster's udevd too

For reasons I don't propose to investigate, on buster udevd shows up like this: 2019-11-26 18:13:48 Z LEAKED [process 2633 /lib/systemd/systemd-udevd] process: root 2633 1555 0 18:10 ?00:00:00 /lib/systemd/systemd-udevd This does not match our suppression. Add an additional

[OSSTEST PATCH 03/38] lvcreate argments: pass --yes -Z y -W y

The documentation seesm to think this is the default but empirically it isn't. In our environment --yes is fine. I have reported this to Debian as #953183. Also vaguely related (and discovered by me at the same time) is #953185. This came up while trying to get things work on buster. I don't

[OSSTEST PATCH 00/38] Upgrade most hosts/guests to buster

buster is Debian stable right now. We don't want to be using oldstable because Debian have a history of breaking it. Paul: we should have a conversation about whether this should be pushed soon, or deferred until after the Xen 4.14 release. I have yet to do a final full formal retest of this

[OSSTEST PATCH 01/38] ts-logs-capture: Cope if xl shutdown leaves domain running for a bit

This seems mostly to affect buster but it could in principle affect earlier releases too I think. In principle it would be nice to fix this bug, and to have a proper test for it, but a reliable test is hard and an unreliable one is not useful. So I guess we are going to have this workaround

[qemu-mainline test] 150243: tolerable FAIL - PUSHED

flight 150243 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/150243/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail like 150235

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

On 19/05/2020 17:09, Jan Beulich wrote: > On 19.05.2020 17:33, Andrew Cooper wrote: >> On 19/05/2020 15:48, Jan Beulich wrote: >>> On 19.05.2020 16:11, Andrew Cooper wrote: Given that shadow frames are limited to 44 bits anyway (and not yet levelled safely in the migration stream), my

Re: [PATCH v2] xen: fix build without pci passthrough

On Tue, May 19, 2020 at 04:52:58PM +0100, Anthony PERARD wrote: > On Tue, May 19, 2020 at 04:31:01PM +0200, Roger Pau Monne wrote: > > has_igd_gfx_passthru is only available when QEMU is built with > > CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common > > code without checking if

Re: [PATCH for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4

On 19/05/2020 04:08, Tamas K Lengyel wrote: On Mon, May 18, 2020 at 5:32 AM Julien Grall wrote: From: Julien Grall Hi all, At the moment, a user who wants to boot Xen on the Raspberry Pi 4 can only use the first GB of memory. This is because several devices cannot DMA above 1GB but Xen

[PATCH v2 for-4.14 3/3] xen/arm: plat: Allocate as much as possible memory below 1GB for dom0 for RPI

From: Julien Grall The raspberry PI 4 has devices that can only DMA into the first GB of the RAM. Therefore we want allocate as much as possible memory below 1GB for dom0. Use the recently introduced dma_bitsize field to specify the DMA width supported. Signed-off-by: Julien Grall

[PATCH v2 for-4.14 2/3] xen/arm: Take into account the DMA width when allocating Dom0 memory banks

From: Julien Grall At the moment, Xen is assuming that all the devices are at least 32-bit DMA capable. However, some SoCs have devices that may be able to access a much restricted range. For instance, the Raspberry PI 4 has devices that can only access the first GB of RAM. The function

[PATCH v2 for-4.14 1/3] xen/arm: Allow a platform to override the DMA width

From: Julien Grall At the moment, Xen is assuming that all the devices are at least 32-bit DMA capable. However, some SoC have devices that may be able to access a much restricted range. For instance, the RPI has devices that can only access the first 1GB of RAM. The structure platform_desc is

[PATCH v2 for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4

From: Julien Grall Hi all, At the moment, a user who wants to boot Xen on the Raspberry Pi 4 can only use the first GB of memory. This is because several devices cannot DMA above 1GB but Xen doesn't necessarily allocate memory for Dom0 below 1GB. This small series is trying to address the

Re: [PATCH for-4.14 3/3] xen/arm: plat: Allocate as much as possible memory below 1GB for dom0 for RPI

Hi Corey, On 19/05/2020 01:02, Corey Minyard wrote: On Mon, May 18, 2020 at 08:36:08PM +, Volodymyr Babchuk wrote: Hi Julien, On Mon, 2020-05-18 at 12:30 +0100, Julien Grall wrote: From: Julien Grall The raspberry PI 4 has devices that can only DMA into the first GB of the RAM.

Re: [PATCH for-4.14 3/3] xen/arm: plat: Allocate as much as possible memory below 1GB for dom0 for RPI

On 18/05/2020 21:36, Volodymyr Babchuk wrote: Hi Julien, Hi, On Mon, 2020-05-18 at 12:30 +0100, Julien Grall wrote: From: Julien Grall The raspberry PI 4 has devices that can only DMA into the first GB of the RAM. Therefore we want allocate as much as possible memory below 1GB for

Re: [PATCH for-4.14 2/3] xen/arm: Take into account the DMA width when allocating Dom0 memory banks

On 18/05/2020 21:34, Volodymyr Babchuk wrote: Hi Julien, Hi Volodymyr, Thank you for the review. On Mon, 2020-05-18 at 12:30 +0100, Julien Grall wrote: From: Julien Grall At the moment, Xen is assuming that all the devices are at least 32-bit DMA capable. However, some SoCs have

[xen-unstable-smoke test] 150245: tolerable all pass - PUSHED

flight 150245 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150245/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

On 19.05.2020 17:33, Andrew Cooper wrote: > On 19/05/2020 15:48, Jan Beulich wrote: >> On 19.05.2020 16:11, Andrew Cooper wrote: >>> Given that shadow frames are limited to 44 bits anyway (and not yet >>> levelled safely in the migration stream), my suggestion for fixing this >>> was just to use

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

On 19/05/2020 15:55, Jan Beulich wrote: > On 19.05.2020 16:29, Andrew Cooper wrote: >> On 19/05/2020 09:14, Jan Beulich wrote: >>> On 18.05.2020 17:38, Andrew Cooper wrote: The reserved_bit_page_fault() paths effectively turn reserved bit faults into a warning, but in the light of

Re: [PATCH v2] xen: fix build without pci passthrough

On Tue, May 19, 2020 at 04:31:01PM +0200, Roger Pau Monne wrote: > has_igd_gfx_passthru is only available when QEMU is built with > CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common > code without checking if it's available. > > Fixes: 46472d82322d0 ('xen: convert "-machine

RE: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 16:37 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Paul Durrant' ; > 'Andrew Cooper' > ; 'George Dunlap' ; 'Ian > Jackson' > ; 'Julien Grall' ; 'Stefano > Stabellini' > ; 'Wei Liu' ; 'Volodymyr Babchuk' > ; >

[xen-unstable test] 150238: regressions - FAIL

flight 150238 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/150238/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 150227 Tests which did

Re: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

On 19.05.2020 17:32, Paul Durrant wrote: >> -Original Message- >> From: Jan Beulich >> Sent: 19 May 2020 16:18 >> To: p...@xen.org >> Cc: xen-devel@lists.xenproject.org; 'Paul Durrant' ; >> 'Andrew Cooper' >> ; 'George Dunlap' ; >> 'Ian Jackson' >> ; 'Julien Grall' ; 'Stefano >>

RE: [PATCH v3 4/5] common/domain: add a domain context record for shared_info...

> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 16:34 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Paul Durrant' ; > 'Ian Jackson' > ; 'Wei Liu' ; 'Andrew Cooper' > ; > 'George Dunlap' ; 'Julien Grall' ; > 'Stefano Stabellini' > > Subject: Re: [PATCH v3 4/5]

Re: [PATCH v7 07/19] libxl: write qemu arguments into separate xenstore keys

On Tue, May 19, 2020 at 11:21 AM Wei Liu wrote: > > On Tue, May 19, 2020 at 04:10:09PM +0100, Ian Jackson wrote: > > Jason Andryuk writes ("[PATCH v7 07/19] libxl: write qemu arguments into > > separate xenstore keys"): > > > From: Marek Marczykowski-Górecki > > > > > > This allows using

Re: [PATCH v3 4/5] common/domain: add a domain context record for shared_info...

On 19.05.2020 17:21, Paul Durrant wrote: >> From: Jan Beulich >> Sent: 19 May 2020 15:08 >> >> On 14.05.2020 12:44, Paul Durrant wrote: >>> --- a/xen/include/public/save.h >>> +++ b/xen/include/public/save.h >>> @@ -73,7 +73,16 @@ struct domain_save_header { >>> }; >>>

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

On 19/05/2020 15:48, Jan Beulich wrote: > On 19.05.2020 16:11, Andrew Cooper wrote: >> On 19/05/2020 09:34, Jan Beulich wrote: >>> On 18.05.2020 17:38, Andrew Cooper wrote: @@ -1439,6 +1418,18 @@ void do_page_fault(struct cpu_user_regs *regs) if ( unlikely(fixup_page_fault(addr,

RE: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 16:18 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Paul Durrant' ; > 'Andrew Cooper' > ; 'George Dunlap' ; 'Ian > Jackson' > ; 'Julien Grall' ; 'Stefano > Stabellini' > ; 'Wei Liu' ; 'Volodymyr Babchuk' > ; >

Re: [PATCH] x86/mem-paging: further adjustments to p2m_mem_paging_prep()'s error handling

On 19/05/2020 16:28, Jan Beulich wrote: > Address late comments on ecb913be4aaa ("x86/mem-paging: correct > p2m_mem_paging_prep()'s error handling"): > - insert a gprintk() ahead of domain_crash(), > - add a comment. > > Requested-by: Andrew Cooper > Signed-off-by: Jan Beulich Reviewed-by:

[PATCH] x86/mem-paging: further adjustments to p2m_mem_paging_prep()'s error handling

Address late comments on ecb913be4aaa ("x86/mem-paging: correct p2m_mem_paging_prep()'s error handling"): - insert a gprintk() ahead of domain_crash(), - add a comment. Requested-by: Andrew Cooper Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/mem_paging.c +++ b/xen/arch/x86/mm/mem_paging.c

RE: [PATCH v3 4/5] common/domain: add a domain context record for shared_info...

> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 15:08 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Paul Durrant ; Ian > Jackson > ; Wei Liu ; Andrew Cooper > ; George > Dunlap ; Julien Grall ; Stefano > Stabellini > > Subject: Re: [PATCH v3 4/5]

Re: [PATCH v7 07/19] libxl: write qemu arguments into separate xenstore keys

On Tue, May 19, 2020 at 04:10:09PM +0100, Ian Jackson wrote: > Jason Andryuk writes ("[PATCH v7 07/19] libxl: write qemu arguments into > separate xenstore keys"): > > From: Marek Marczykowski-Górecki > > > > This allows using arguments with spaces, like -append, without > > nominating any

Re: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

On 19.05.2020 17:10, Paul Durrant wrote: >> From: Jan Beulich >> Sent: 19 May 2020 15:24 >> >> On 19.05.2020 16:04, Paul Durrant wrote: From: Jan Beulich Sent: 19 May 2020 14:04 On 14.05.2020 12:44, Paul Durrant wrote: > +/* > + * Register save and restore handlers.

RE: [PATCH v3 2/5] xen/common/domctl: introduce XEN_DOMCTL_get/setdomaincontext

> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 14:49 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Paul Durrant ; > Daniel De Graaf > ; Ian Jackson ; Wei Liu > ; Andrew Cooper > ; George Dunlap ; Julien > Grall ; > Stefano Stabellini > Subject: Re: [PATCH v3

RE: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

> -Original Message- > From: Jan Beulich > Sent: 19 May 2020 15:24 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Paul Durrant' ; > 'Andrew Cooper' > ; 'George Dunlap' ; 'Ian > Jackson' > ; 'Julien Grall' ; 'Stefano > Stabellini' > ; 'Wei Liu' ; 'Volodymyr Babchuk' > ; >

Re: [PATCH v7 07/19] libxl: write qemu arguments into separate xenstore keys

Jason Andryuk writes ("[PATCH v7 07/19] libxl: write qemu arguments into separate xenstore keys"): > From: Marek Marczykowski-Górecki > > This allows using arguments with spaces, like -append, without > nominating any special "separator" character. > > Signed-off-by: Marek Marczykowski-Górecki

Re: [PATCH v7 06/19] libxl: Use libxl__xs_* in libxl__write_stub_dmargs

Jason Andryuk writes ("[PATCH v7 06/19] libxl: Use libxl__xs_* in libxl__write_stub_dmargs"): > Re-work libxl__write_stub_dmargs to use libxl_xs_* functions in a loop. Cool, thank you! Acked-by: Ian Jackson

Re: [PATCH 6/7] xen/guest_access: Consolidate guest access helpers in xen/guest_access.h

Hi. My attention was drawn to this thread. As I understand it, everyone is agreed that deduplicating the implementation is good (I also agree). The debate is only between: 1. Put it in xen/ until an arch comes along that needs something different, at which point maybe introduce an

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

On 19.05.2020 16:29, Andrew Cooper wrote: > On 19/05/2020 09:14, Jan Beulich wrote: >> On 18.05.2020 17:38, Andrew Cooper wrote: >>> The reserved_bit_page_fault() paths effectively turn reserved bit faults >>> into >>> a warning, but in the light of L1TF, the real impact is far more serious. >>>

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

On 19.05.2020 16:11, Andrew Cooper wrote: > On 19/05/2020 09:34, Jan Beulich wrote: >> On 18.05.2020 17:38, Andrew Cooper wrote: >>> @@ -1439,6 +1418,18 @@ void do_page_fault(struct cpu_user_regs *regs) >>> if ( unlikely(fixup_page_fault(addr, regs) != 0) ) >>> return; >>> >>> +

[PATCH v2] xen: fix build without pci passthrough

has_igd_gfx_passthru is only available when QEMU is built with CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common code without checking if it's available. Fixes: 46472d82322d0 ('xen: convert "-machine igd-passthru" to an accelerator property') Signed-off-by: Roger Pau Monné ---

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

On 19/05/2020 09:14, Jan Beulich wrote: > On 18.05.2020 17:38, Andrew Cooper wrote: >> The reserved_bit_page_fault() paths effectively turn reserved bit faults into >> a warning, but in the light of L1TF, the real impact is far more serious. >> >> Xen does not have any reserved bits set in its

Re: [PATCH v3 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

On 19.05.2020 16:04, Paul Durrant wrote: >> From: Jan Beulich >> Sent: 19 May 2020 14:04 >> >> On 14.05.2020 12:44, Paul Durrant wrote: >>> --- /dev/null >>> +++ b/xen/include/xen/save.h >>> @@ -0,0 +1,165 @@ >>> +/* >>> + * save.h: support routines for save/restore >>> + * >>> + * Copyright

Re: [PATCH] xen: fix build without pci passthrough

On Tue, May 19, 2020 at 01:20:51PM +0100, Peter Maydell wrote: > On Tue, 19 May 2020 at 12:28, Roger Pau Monné wrote: > > > > On Mon, May 11, 2020 at 02:40:43PM +0100, Anthony PERARD wrote: > > > On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote: > > > > diff --git a/hw/xen/xen_pt.h

  1   2   >