On 04/07/20 21:44, BALATON Zoltan wrote:
>
> No it's OK, no need to list all defines. I just did not notice the macro
> argument that's why I was wondering where it comes from. This seems to
> be used elsewhere at least here:
>
> hw/audio/es1370.c:#define a(n) if (val & CTRL_##n) strcat (buf, "
On Sat, Jul 4, 2020 at 7:50 AM Philippe Mathieu-Daudé
wrote:
> Add an section for the dwc2 host controller emulation
> introduced in commit 153ef1662c.
>
> Cc: Paul Zimmerman
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> MAINTAINERS | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff
flight 151622 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151622/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 10 debian-hvm-install
fail REGR. vs.
flight 151617 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151617/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-pvshim 7 xen-boot fail REGR. vs. 151214
On 7/4/20 9:44 PM, BALATON Zoltan wrote:
> On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote:
>> On 7/4/20 7:17 PM, BALATON Zoltan wrote:
>>> On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote:
Various machine/board/soc models create UHCI device instances
with the generic QDEV API, and
On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote:
On 7/4/20 7:17 PM, BALATON Zoltan wrote:
On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote:
Various machine/board/soc models create UHCI device instances
with the generic QDEV API, and don't need to access USB internals.
Simplify header
- 3 lip 2020 o 9:58, Julien Grall jul...@xen.org napisał(a):
> Hi,
>
> On 02/07/2020 21:28, Michał Leszczyński wrote:
>> - 2 lip 2020 o 16:31, Julien Grall jul...@xen.org napisał(a):
>>
>>> On 02/07/2020 15:17, Jan Beulich wrote:
On 02.07.2020 16:14, Julien Grall wrote:
> On
On 7/4/20 7:17 PM, BALATON Zoltan wrote:
> On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote:
>> Various machine/board/soc models create UHCI device instances
>> with the generic QDEV API, and don't need to access USB internals.
>>
>> Simplify header inclusions by moving the QOM type names into a
On 7/4/20 7:13 PM, BALATON Zoltan wrote:
> On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote:
>> Various machine/board/soc models create OHCI device instances
>> with the generic QDEV API, and don't need to access USB internals.
>>
>> Simplify header inclusions by moving the QOM type names into a
On 7/4/20 7:19 PM, BALATON Zoltan wrote:
> On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote:
>> Various machine/board/soc models create XHCI device instances
>> with the generic QDEV API, and don't need to access USB internals.
>>
>> Simplify header inclusions by moving the QOM type names into a
Hi,
On 30/06/2020 13:33, Michał Leszczyński wrote:
diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
index 71709dc585..891e8e28d6 100644
--- a/tools/libxl/libxl.h
+++ b/tools/libxl/libxl.h
@@ -438,6 +438,14 @@
*/
#define LIBXL_HAVE_CREATEINFO_PASSTHROUGH 1
+/*
+ *
Hi,
On 03/07/2020 11:11, Roger Pau Monné wrote:
On Fri, Jul 03, 2020 at 11:56:38AM +0200, Jan Beulich wrote:
On 03.07.2020 11:44, Roger Pau Monné wrote:
On Thu, Jul 02, 2020 at 06:23:28PM +0200, Michał Leszczyński wrote:
- 2 lip 2020 o 11:00, Roger Pau Monné roger@citrix.com
flight 151606 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151606/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-armhf-armhf-xl-rtds 16 guest-start/debian.repeat fail pass in 151586
Tests which did not succeed,
On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote:
Various machine/board/soc models create XHCI device instances
with the generic QDEV API, and don't need to access USB internals.
Simplify header inclusions by moving the QOM type names into a
simple header, with no need to include other "hw/usb"
On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote:
Various machine/board/soc models create UHCI device instances
with the generic QDEV API, and don't need to access USB internals.
Simplify header inclusions by moving the QOM type names into a
simple header, with no need to include other "hw/usb"
On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote:
Various machine/board/soc models create EHCI device instances
with the generic QDEV API, and don't need to access USB internals.
Simplify header inclusions by moving the QOM type names into a
simple header, with no need to include other "hw/usb"
On Sat, 4 Jul 2020, Philippe Mathieu-Daudé wrote:
Various machine/board/soc models create OHCI device instances
with the generic QDEV API, and don't need to access USB internals.
Simplify header inclusions by moving the QOM type names into a
simple header, with no need to include other "hw/usb"
On 7/3/20 11:08 AM, Vladimir Sementsov-Ogievskiy wrote:
> If we want to add some info to errp (by error_prepend() or
> error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
> Otherwise, this info will not be added when errp == _fatal
> (the program will exit prior to the
On 17/06/2020 17:23, Julien Grall wrote:
Hi,
On 16/06/2020 22:24, Stefano Stabellini wrote:
On Tue, 16 Jun 2020, Julien Grall wrote:
From: Julien Grall
Some CPUs can speculate past a RET instruction and potentially perform
speculative accesses to memory before processing the return.
There
Hi,
On 03/07/2020 07:02, jinchen wrote:
Thank you for your reply!
On 02/07/2020 02:41, jinchen wrote:
>> Hello xen experts:
>>
>> Is there any way to save xen and dom0 core dump log when xen or dom0
>> crash on ARM64 platform?
>Usually all the crash stack trace (Xen and Dom0) should be
Hi,
On 27/06/2020 10:55, Julien Grall wrote:
From: Julien Grall
The specification of pvcalls suggests there is padding for 32-bit x86
at the end of most the structure. However, they are not described in
in the public header.
Because of that all the structures would be 32-bit aligned and not
flight 151608 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151608/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-libvirt-pair 22 guest-migrate/src_host/dst_host fail REGR.
vs. 151496
Only the USB devices require to access the USB internal APIs.
The rest of the code base only wants to consume USB devices
with a generic API. Move the generic declarations to the new
"hw/usb/usb.h" header.
Reported-by: BALATON Zoltan
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/usb.h
Various machine/board/soc models create XHCI device instances
with the generic QDEV API, and don't need to access USB internals.
Simplify header inclusions by moving the QOM type names into a
simple header, with no need to include other "hw/usb" headers.
Suggested-by: BALATON Zoltan
Various machine/board/soc models create UHCI device instances
with the generic QDEV API, and don't need to access USB internals.
Simplify header inclusions by moving the QOM type names into a
simple header, with no need to include other "hw/usb" headers.
Suggested-by: BALATON Zoltan
USBDescString is forward-declared. Only bus.c uses the
usb_device_get_product_desc() and usb_device_get_usb_desc()
function. Move all that to the "desc.h" header to reduce
the big "hw/usb.h" header a bit.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/desc.h| 10 ++
Various machine/board/soc models create OHCI device instances
with the generic QDEV API, and don't need to access USB internals.
Simplify header inclusions by moving the QOM type names into a
simple header, with no need to include other "hw/usb" headers.
Suggested-by: BALATON Zoltan
Simplify usb_get_dev_path() a bit.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/bus.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/hw/usb/bus.c b/hw/usb/bus.c
index 111c3af7c1..f8901e822c 100644
--- a/hw/usb/bus.c
+++ b/hw/usb/bus.c
@@ -580,19
This file is not a header, but contains source code which is
included and compiled once. We use the '.inc.c' suffix in few
other cases in the repository. Follow the same convention with
this file.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/quirks.c | 2 +-
Various machine/board/soc models create EHCI device instances
with the generic QDEV API, and don't need to access USB internals.
Simplify header inclusions by moving the QOM type names into a
simple header, with no need to include other "hw/usb" headers.
Suggested-by: BALATON Zoltan
To avoid to access the USBDevice internals, and use the
recently added usb_get_port_path() helper instead.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ppc/spapr.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index
Move definitions only useful for hcd-ehci.c to this source file.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/hcd-ehci.h | 11 ---
hw/usb/hcd-ehci.c | 12
2 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h
index
Only redirect.c consumes the quirks API. Reduce the big "hw/usb.h"
header by moving the quirks related declaration into their own
header. As nothing out of hw/usb/ requires it, keep it local.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/usb-quirks.h | 27 +++
Refactor usb_get_full_dev_path() to take a 'want_full_path'
argument, and add usb_get_port_path() which returns a short
path.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/usb.h | 10 ++
hw/usb/bus.c | 18 +-
2 files changed, 23 insertions(+), 5 deletions(-)
"hcd-musb.h" is only required by USB device implementions.
As we keep these implementations in the hw/usb/ directory,
move the header there.
Signed-off-by: Philippe Mathieu-Daudé
---
{include/hw => hw}/usb/hcd-musb.h | 0
hw/usb/hcd-musb.c | 2 +-
hw/usb/tusb6010.c
Add an section for the dwc2 host controller emulation
introduced in commit 153ef1662c.
Cc: Paul Zimmerman
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2566566d72..e3f895bc6e 100644
---
Only the files under hw/usb/ require access to the USB internal
API. Move include/hw/usb.h to hw/usb/usb-internal.h to reduce
its scope.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/desc.h | 2 +-
hw/usb/hcd-dwc2.h | 2 +-
If the device has USB_DEV_FLAG_FULL_PATH set, usb_get_dev_path()
returns the full port path. Rename the function accordingly.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/bus.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/usb/bus.c b/hw/usb/bus.c
index
This header uses the USBPort type which is forward declared
by "hw/usb.h".
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/hcd-xhci.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/usb/hcd-xhci.h b/hw/usb/hcd-xhci.h
index 946af51fc2..8edbdc2c3e 100644
--- a/hw/usb/hcd-xhci.h
+++
The header "usb/hcd-dwc2.h" doesn't need to include "qemu/timer.h",
"sysemu/dma.h", "hw/irq.h" (the types required are forward declared).
Include them in the source file which is the only one requiring the
function declarations.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/hcd-dwc2.h | 3
We only use these register definitions in files under the
hw/usb/ directory. Keep that header local by moving it there.
Signed-off-by: Philippe Mathieu-Daudé
---
{include/hw => hw}/usb/dwc2-regs.h | 0
hw/usb/hcd-dwc2.c | 2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
Commit a5d2f7273c ("qdev/usb: make qemu aware of usb busses")
removed the last use of VM_USB_HUB_SIZE, 11 years ago. Time
to drop it.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/usb.h | 4
1 file changed, 4 deletions(-)
diff --git a/include/hw/usb.h b/include/hw/usb.h
index
Hi,
This is the second time I try to replace a magic typename string
by a constant, and Zoltan warns me this is counter productive as
"hw/usb.h" pulls in an insane amount of code.
Time to give the usb subsystem some love and move forward.
This series can be decomposed as follow:
1-2:
"exec/memory.h" is only required by "hw/usb/hcd-musb.h".
Include it there directly.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/usb.h | 1 -
include/hw/usb/hcd-musb.h | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/hw/usb.h b/include/hw/usb.h
As "qemu/main-loop.h" is not used, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/hcd-ehci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 1495e8f7fa..256fb91e0c 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -34,7 +34,6
"qemu/error-report.h" and "qemu/main-loop.h" are not used.
Remove them.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/hcd-dwc2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/usb/hcd-dwc2.c b/hw/usb/hcd-dwc2.c
index 72cbd051f3..590e75b455 100644
--- a/hw/usb/hcd-dwc2.c
+++
This header uses the USBPacket and USBDevice types which are
forward declared in "hw/usb.h".
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/desc.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/usb/desc.h b/hw/usb/desc.h
index 4d81c68e0e..92594fbe29 100644
--- a/hw/usb/desc.h
+++
This file doesn't access anything from "hw/usb.h", remove its
inclusion.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/sbsa-ref.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index e40c868a82..021e7c1b8b 100644
--- a/hw/arm/sbsa-ref.c
+++
This file uses pci_create_simple() and PCI_DEVFN() which are both
declared in "hw/pci/pci.h". This include is indirectly included
by an USB header. As we want to reduce the USB header inclusions
later, include the PCI header now, to avoid later:
hw/ppc/sam460ex.c:397:5: error: implicit
flight 151598 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151598/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 10 debian-hvm-install
fail REGR. vs.
flight 151594 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/151594/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-arm64-arm64-libvirt-xsm 16 guest-start/debian.repeat fail REGR. vs. 151214
The pull request you sent on Sat, 4 Jul 2020 08:57:02 +0200:
> git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git
> for-linus-5.8b-rc4-tag
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/35e884f89df4c48566d745dc5a97a0d058d04263
Thank you!
--
Deet-doot-dot,
Linus,
Please git pull the following tag:
git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git
for-linus-5.8b-rc4-tag
xen: branch for v5.8-rc4
It contains only 1 small cleanup patch for ARM and two patches for the
xenbus driver fixinf latent problems (large stack allocations and bad
53 matches
Mail list logo
