[PATCH v1 5/6] tools/ocaml/xenstored: use more efficient node trees

This changes the output of xenstore-ls to be sorted. Previously the keys were listed in the order in which they were inserted in. docs/misc/xenstore.txt doesn't specify in what order keys are listed. Map.update is used to retain semantics with replace_child: only an existing child is replaced, if

[PATCH v1 6/6] tools/ocaml/xenstored: use more efficient tries

No functional change, just an optimization. Signed-off-by: Edwin Török --- tools/ocaml/xenstored/connections.ml | 2 +- tools/ocaml/xenstored/trie.ml| 61 tools/ocaml/xenstored/trie.mli | 26 ++-- 3 files changed, 41 insertions(+), 48 deletions

[PATCH v1 3/6] tools/ocaml/xenstored: replace hand rolled GC with weak GC references

The code here is attempting to reduce memory usage by sharing common substrings in the tree: it replaces strings with ints, and keeps a string->int map that gets manually garbage collected using a hand-rolled mark and sweep algorithm. This is unnecessary: OCaml already has a mark-and-sweep Garbage

[PATCH v1 4/6] tools/ocaml/xenstored: drop select based

Poll has been the default since 2014, I think we can safely say by now that poll() works and we don't need to fall back to select(). This will allow fixing up the way we call poll to be more efficient (and pave the way for introducing epoll support): currently poll wraps the select API, which is i

[PATCH v1 1/6] tools/ocaml/libs/xc: Fix ambiguous documentation comment

Signed-off-by: Edwin Török --- tools/ocaml/libs/xc/xenctrl.mli | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index 26ec7e59b1..f7f6ec570d 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@

[PATCH v1 0/6] tools/ocaml/xenstored: simplify code

Fix warnings, and delete some obsolete code. oxenstored contained a hand-rolled GC to perform hash-consing: this can be done with a lot fewer lines of code by using the built-in Weak module. The choice of data structures for trees/tries is not very efficient: they are just lists. Using a map imp

[PATCH v1 2/6] tools/ocaml/xenstored: fix deprecation warning

``` File "xenstored/disk.ml", line 33, characters 9-23: 33 |let c = Char.lowercase c in ^^ (alert deprecated): Stdlib.Char.lowercase Use Char.lowercase_ascii instead. ``` Signed-off-by: Edwin Török --- tools/ocaml/xenstored/disk.ml | 2 +- 1 file changed, 1 insertio

[linux-linus test] 152599: regressions - FAIL

flight 152599 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152599/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-boot fail REGR. vs. 152332 test-amd64-i386-qem

[OSSTEST PATCH 32/60] sg-report-job-history: Prep for fork: Move $revisionsq query

We will need to prepare this in add_revisions so that it works when we do each (job,branch) in a different process. It is OK that it is still global, becauswe we only call add_revisions in the children. Signed-off-by: Ian Jackson --- sg-report-job-history | 9 + 1 file changed, 5 insert

[OSSTEST PATCH 22/60] history reporting: Skip undefined keys

This makes it work if the caller's cached hash contains an key which is bound to undef. sg-report-host-history already does this, which currently causes: Use of uninitialized value $_ in substitution (s///) at Osstest/HistoryReport.pm line 134. Use of uninitialized value $_ in printf at Osstes

[OSSTEST PATCH 38/60] history reporting (nfc): Add another test rune to the notes

Signed-off-by: Ian Jackson --- runes | 2 ++ 1 file changed, 2 insertions(+) diff --git a/runes b/runes index 8139f955..829e6106 100644 --- a/runes +++ b/runes @@ -11,3 +11,5 @@ select * from jobs full outer join steps using (job, flight) where flight=2364 o >v; env DBI_TRACE=2=v time ./sg-rep

[OSSTEST PATCH 47/60] history reporting (nfc): Break out url_quote

Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Osstest/HistoryReport.pm b/Osstest/HistoryReport.pm index bfbee28c..f30ded5b 100644 --- a/Osstest/HistoryReport.pm +++ b/Osstest/HistoryReport.pm @@ -156,6 +156,12

[OSSTEST PATCH 08/60] history reporting (nfc): Rename "existing" to "previous"

This seems more idiomatic use of English. Signed-off-by: Ian Jackson --- sg-report-host-history | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sg-report-host-history b/sg-report-host-history index 2724ef27..f37dd4a2 100755 --- a/sg-report-host-history +++ b/sg-report

[OSSTEST PATCH 60/60] sg-report-job-history: Increase default limit

Now this is a *lot* faster, we can print a lot more history. Signed-off-by: Ian Jackson --- sg-report-job-history | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sg-report-job-history b/sg-report-job-history index e09c694f..843dd776 100755 --- a/sg-report-job-history +++ b/sg

[OSSTEST PATCH 21/60] history reporting (nfc): Rename some module variables, remove "cache"

This makes the code terser and easier to read. No functional change. Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Osstest/HistoryReport.pm b/Osstest/HistoryReport.pm index a0565b6a..61b1ee8f 100644 --- a

[OSSTEST PATCH 14/60] history reporting (nfc): Use cacheable_fn for power methods

Avoids open-coding knowledge of the $jr convention at this use site. %powers becomes %$powers, so it's a bit noisy. Signed-off-by: Ian Jackson --- sg-report-host-history | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/sg-report-host-history b/sg-report-h

[OSSTEST PATCH 30/60] parallel by fork: Fix a variable name to $task

This code came from sg-report-host-history where tasks were hosts. But in the more general context, the names are wrong. Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Osstest/HistoryReport.pm b/Osstest/HistoryRep

[OSSTEST PATCH 28/60] parallel by fork: Break out into HistoryReport

Move this code from sg-report-host-history to HistoryReport, so that it can be reused. No significant functional change. Some changes to debug messages. Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 51 sg-report-host-history | 49

[OSSTEST PATCH 52/60] sg-report-job-history: Cache the per-flight revisions

This involves changing %revisions to %$revisions in the code which uses the value. No logical change. Signed-off-by: Ian Jackson --- sg-report-job-history | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/sg-report-job-history b/sg-report-job-histo

[OSSTEST PATCH 50/60] history reporting (nfc): url-quoting: quote = too

We are going to want to url-encode keys. If key contains =, we still need to be able to tell where it ends, so it must be encoded. Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/HistoryReport.pm b/Osstest/Histo

[OSSTEST PATCH 55/60] history reporting: Break out minflight_by_time

Move this from sg-report-host-history so we can reuse it. Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 16 sg-report-host-history | 13 ++--- 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/Osstest/HistoryReport.pm b/Osstest/HistoryReport.

[OSSTEST PATCH 26/60] history reporting: Improve an error message slightly

Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Osstest/HistoryReport.pm b/Osstest/HistoryReport.pm index b593f207..6a23cfba 100644 --- a/Osstest/HistoryReport.pm +++ b/Osstest/HistoryReport.pm @@ -128,6 +128,7 @@ sub c

[OSSTEST PATCH 51/60] history reporting (nfc): Quote keys too

Right now all the callers have keys which don't need quoting. Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Osstest/HistoryReport.pm b/Osstest/HistoryReport.pm index 20913d27..3e2ad0d3 100644 --- a/Osstest/Histo

[OSSTEST PATCH 24/60] history reporting: Cache data limit now in History module

Replace the ad-hoc query-specific limit strategy in sg-report-host-history with a new, more principled, arrangement, in HistoryReport. Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 38 -- sg-report-host-history | 14 +- 2 files change

[OSSTEST PATCH 44/60] sg-report-job-history (nfc): Drop $hostsq query

We have eliminated all the users of @hostvarcols before @hostvarcols2 is calculated from the row data. The query which produces this is very slow and can't be cached. We can abolish it now and just use the @hostvarcols2 calculation. Signed-off-by: Ian Jackson --- sg-report-job-history | 22 +--

[OSSTEST PATCH 49/60] history reporting (nfc): Break out $url_ok_chars

We will want this in a moment. Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Osstest/HistoryReport.pm b/Osstest/HistoryReport.pm index f8a49955..75ec75f3 100644 --- a/Osstest/HistoryReport.pm +++ b/Osstest/HistoryRe

[OSSTEST PATCH 58/60] sg-report-host-history: Cache report_run_getinfo

No logical change. Signed-off-by: Ian Jackson --- sg-report-host-history | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sg-report-host-history b/sg-report-host-history index efe652bb..a814ef37 100755 --- a/sg-report-host-history +++ b/sg-report-host-history @@ -266,7 +266

[OSSTEST PATCH 36/60] sg-report-job-history: Always write HTML output

Previously, unlike sg-report-host-history, if you didn't specify --html-dir, it would would do a lot work to no effect. This is not useful and nothing calls it this way. So abolish this notion. Signed-off-by: Ian Jackson --- sg-report-job-history | 2 +- 1 file changed, 1 insertion(+), 1 delet

[OSSTEST PATCH 39/60] history reporting (nfc): Make cacheable_fn work without cache

This would allow us to use this in call sites without a cache. I changed my mind about the code that prompted this, but it still seems plausibly useful, so I'm keeping this commit. Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/Osstes

[OSSTEST PATCH 19/60] history reporting (nfc): Introduce empty HistoryReport module

This is the boilerplate. Code will appear in it in a moment. Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 43 +++ sg-report-host-history | 1 + 2 files changed, 44 insertions(+) create mode 100644 Osstest/HistoryReport.pm diff --git a/Os

[OSSTEST PATCH 10/60] history reporting (nfc): Bind by name in cacheable_query

cacheable_query used to simply pass $jr->{flight} and ->{job}. But we want this to be reuseable for other kinds of query, with different cache keys. So bind by name: we expect the caller to use :name placeholders in the query. We can then look through the prepared query parameters, and fish the

[OSSTEST PATCH 42/60] sg-report-job-history (nfc): Add new hostvarcols calculation

We are going to want to replace the existing @hostvarcols calculation. Provide a new one based on $ri->{Hosts}. Right now, die if they don't produce the same answers. This still works, which shows that the calculation is right. Tested-by: Ian Jackson Signed-off-by: Ian Jackson --- sg-report-

[OSSTEST PATCH 57/60] sg-report-job-history: Cache report_run_getinfo

No logical change. Signed-off-by: Ian Jackson --- sg-report-job-history | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sg-report-job-history b/sg-report-job-history index 2cac123b..5d2a7e15 100755 --- a/sg-report-job-history +++ b/sg-report-job-history @@ -159,7 +159,7 @@ EN

[OSSTEST PATCH 18/60] history reporting (nfc): Remove now-obsolete stats variables

Signed-off-by: Ian Jackson --- sg-report-host-history | 5 - 1 file changed, 5 deletions(-) diff --git a/sg-report-host-history b/sg-report-host-history index 9c70b560..1b4566aa 100755 --- a/sg-report-host-history +++ b/sg-report-host-history @@ -94,17 +94,12 @@ sub cache_row_key ($) {

[OSSTEST PATCH 37/60] sg-report-job-history (nfc): Remove needless conditional

$htmlout is now always defined. Nothing other than indentation change, and removal of the surrounding if block. Signed-off-by: Ian Jackson --- sg-report-job-history | 162 +- 1 file changed, 80 insertions(+), 82 deletions(-) diff --git a/sg-repor

[OSSTEST PATCH 43/60] sg-report-job-history (nfc): Query hosts runvars in one go

Rather than doing one query for each entry in @hostvarcols, do one query for all the relevant runvars. This is quite a bit faster and will enable us to use the cache. This is correct because @hostvarcols was the union of all the host runvars, so this produces the same answers as the individual qu

[OSSTEST PATCH 35/60] sg-report-job-history (nfc): Have main program decide HTML filename

Signed-off-by: Ian Jackson --- sg-report-job-history | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/sg-report-job-history b/sg-report-job-history index 3307b281..3f10a74c 100755 --- a/sg-report-job-history +++ b/sg-report-job-history @@ -109,8 +109,8 @@ END }

[OSSTEST PATCH 54/60] sg-report-job-history: Cache osstestrevs

No logical change. Signed-off-by: Ian Jackson --- sg-report-job-history | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/sg-report-job-history b/sg-report-job-history index d5e37bcd..48dc2f57 100755 --- a/sg-report-job-history +++ b/sg-report-job-history @@ -26

[OSSTEST PATCH 20/60] history reporting (nfc): Move cache code into HistoryReport module

Finally this is now reuseable code and we can put it in the HistoryReport module. Pure cut-and-paste. Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 115 +++ sg-report-host-history | 115 --- 2

[OSSTEST PATCH 31/60] sg-report-job-history: Prep for fork: Move $buildsq query

We will need to prepare this once per (job,branch) so that it works when we do each of those in a different process. Signed-off-by: Ian Jackson --- sg-report-job-history | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sg-report-job-history b/sg-report-job-history inde

[OSSTEST PATCH 23/60] history reporting (nfc): Documentation for the new module

Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 27 +++ sg-report-host-history | 6 +- 2 files changed, 28 insertions(+), 5 deletions(-) diff --git a/Osstest/HistoryReport.pm b/Osstest/HistoryReport.pm index cb8c6ca1..6e5ed6ec 100644 --- a/Osstest/History

[OSSTEST PATCH 59/60] sg-report-job-history: Provide --time-limit

Calculate a minflight based on the time limit, and set the time limit to a year ago by default. Signed-off-by: Ian Jackson --- sg-report-job-history | 7 +++ 1 file changed, 7 insertions(+) diff --git a/sg-report-job-history b/sg-report-job-history index 5d2a7e15..e09c694f 100755 --- a/sg-r

[OSSTEST PATCH 27/60] sg-report-host-history: Write cache entry for unfinished jobs

We have to also check ->{finished}, rather than the existence of a row at all, since now unfinished jobs can appear in the cache. Because the cache key includes the job status, when the job becomes finished the cache entry will be invalidated. Signed-off-by: Ian Jackson --- sg-report-host-histo

[OSSTEST PATCH 46/60] sg-report-job-history: Introduce use of cache, for hosts query

* Set up the cache. * Call the per-row setup hook. * Cache the computation of $ri->{Hosts}. * Call the per-row cache write hook. * Finalise the cache. Output is the same, but with cache information in the output html, and faster. Signed-off-by: Ian Jackson --- sg-report-job-history | 20 +++

[OSSTEST PATCH 48/60] history reporting (nfc): Break out url_unquote

Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Osstest/HistoryReport.pm b/Osstest/HistoryReport.pm index f30ded5b..f8a49955 100644 --- a/Osstest/HistoryReport.pm +++ b/Osstest/HistoryReport.pm @@ -147,8 +147,7 @

[OSSTEST PATCH 45/60] history reporting (nfc): Provide cache_set_task_print

This takes a string which gets added to the cache messages. This will allow us to distinguish the output from different processes when using parallel by fork. Nothing sets this yet. Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletion

[OSSTEST PATCH 29/60] parallel by fork: Disconnect $dbh_tests as well as undefing it

If the caller is buggy and has statement handles still open, they can still "work" even if we have thrown away the db handle. Where, after forking, "work" means "use the same connection in multiple processes simultaneously, without locking". This could result in arbitrary crazy nbehaviour (eg, TL

[OSSTEST PATCH 56/60] sg-report-job-history (nfc): Abolish $fromstuff

This used to be reused, but that is no longer the case. Do away with it, for clarity and simplicity. Signed-off-by: Ian Jackson --- sg-report-job-history | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sg-report-job-history b/sg-report-job-history index 48dc2f57..2cac1

[OSSTEST PATCH 03/60] history reporting: Delete two debug prints

These are going to become invalid and I don't think it's important to save them. Signed-off-by: Ian Jackson --- sg-report-host-history | 2 -- 1 file changed, 2 deletions(-) diff --git a/sg-report-host-history b/sg-report-host-history index 50cc5b58..4c0022e8 100755 --- a/sg-report-host-history

[OSSTEST PATCH 53/60] sg-report-job-history (nfc): Refactor osstestrevs code

Split this into (1) get the data from the db (2) process it into the form we want. This will make it easy to cache (1). Signed-off-by: Ian Jackson --- sg-report-job-history | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sg-report-job-history b/sg-report-job-history i

[OSSTEST PATCH 16/60] history reporting (nfc): Record more row-specific stats

Prep work. Nothing uses these yet. Signed-off-by: Ian Jackson --- sg-report-host-history | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sg-report-host-history b/sg-report-host-history index 07e549a0..32cc883d 100755 --- a/sg-report-host-history +++ b/sg-report-host-hi

[OSSTEST PATCH 17/60] history reporting: Cache stats reporting: Centralise and rework

This uses the new variables instead of the old ones. Signed-off-by: Ian Jackson --- sg-report-host-history | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/sg-report-host-history b/sg-report-host-history index 32cc883d..9c70b560 100755 --- a/sg-report-host-

[OSSTEST PATCH 13/60] history reporting (nfc): Move cacheable_* further up the file

Pure code motion. Brings these together with the other work-cacheing code. Signed-off-by: Ian Jackson --- sg-report-host-history | 60 +- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/sg-report-host-history b/sg-report-host-histo

[OSSTEST PATCH 34/60] sg-report-job-history: Use one child per report

Rather than one child per job, which then did one report per branch. This will mean we can use the cache machinery, which is rather global so wouldn't cope well with processing multiple job history reports within a process. Signed-off-by: Ian Jackson --- sg-report-job-history | 15 -

[OSSTEST PATCH 40/60] sg-report-job-history: Refactor "ALL" handling

* Make an explicit entry ALL in @branches, rather than implicitly processing ALL as well. * Consequently, put explicit ALL entries in @tasks too, rather than putting in entries without a branch name. * Pass ALL to processjobbranch rather than undef, and turn it into the internally-used unde

[OSSTEST PATCH 04/60] history reporting (nfc): Refactor to generalise, cache_read_existing

* Introduce @cache_row_key_cols and cache_row_key * Handle $html_file pathname construction and $read_existing at the call site. * Rename cache_read_existing. Signed-off-by: Ian Jackson --- sg-report-host-history | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff

[OSSTEST PATCH 33/60] sg-report-job-history: Use fork-based parallelism

For now, one child per job (for all branches). This is already a speedup. Signed-off-by: Ian Jackson --- sg-report-job-history | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/sg-report-job-history b/sg-report-job-history index 424053f1..384a7670 100755 --- a/sg

[OSSTEST PATCH 12/60] history reporting (nfc): Record query-specific stats

Prep work. Nothing uses these yet. Signed-off-by: Ian Jackson --- sg-report-host-history | 6 ++ 1 file changed, 6 insertions(+) diff --git a/sg-report-host-history b/sg-report-host-history index 705367cf..32414322 100755 --- a/sg-report-host-history +++ b/sg-report-host-history @@ -77,6 +

[OSSTEST PATCH 02/60] history reporting (nfc): Add some test runes to the notes

Signed-off-by: Ian Jackson --- runes | 8 1 file changed, 8 insertions(+) diff --git a/runes b/runes index 27ece2af..8139f955 100644 --- a/runes +++ b/runes @@ -3,3 +3,11 @@ select * from resource_sharing s full outer join resources r on r.restype = 'sha select * from jobs full oute

[OSSTEST PATCH 09/60] history reporting (nfc): Provide cacheable_fn

Prep work. Signed-off-by: Ian Jackson --- sg-report-host-history | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/sg-report-host-history b/sg-report-host-history index f37dd4a2..90369ce4 100755 --- a/sg-report-host-history +++ b/sg-report-host-history @@ -181,

[OSSTEST PATCH 07/60] history reporting (nfc): Break out cache_row_lookup_prep

Prep work. Signed-off-by: Ian Jackson --- sg-report-host-history | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/sg-report-host-history b/sg-report-host-history index a8dae159..2724ef27 100755 --- a/sg-report-host-history +++ b/sg-report-host-history @@ -112

[OSSTEST PATCH 06/60] history reporting (nfc): Rename jobquery to cacheable_query

Prep work. Signed-off-by: Ian Jackson --- sg-report-host-history | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sg-report-host-history b/sg-report-host-history index fe5b7cc2..a8dae159 100755 --- a/sg-report-host-history +++ b/sg-report-host-history @@ -171,7 +171,7

[OSSTEST PATCH 41/60] sg-report-job-history (nfc): Make $ri->{Hosts} a hash

This will make it easier to cache this. Signed-off-by: Ian Jackson --- sg-report-job-history | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sg-report-job-history b/sg-report-job-history index 8932458e..118926c6 100755 --- a/sg-report-job-history +++ b/sg-report-job-his

[OSSTEST PATCH 25/60] history reporting: Print debug for cache misses

Signed-off-by: Ian Jackson --- Osstest/HistoryReport.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Osstest/HistoryReport.pm b/Osstest/HistoryReport.pm index b576c02a..b593f207 100644 --- a/Osstest/HistoryReport.pm +++ b/Osstest/HistoryReport.pm @@ -155,6 +155,9 @@ sub cache_row_lookup

[OSSTEST PATCH 01/60] history reporting (nfc): Do not key cache on hostname any more

Now we process only one host at a time, so we don't need to distinguish. Replace all references to $tcache with %cache. Signed-off-by: Ian Jackson --- sg-report-host-history | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/sg-report-host-history b/sg-report-host

[OSSTEST PATCH 00/60] Speed up sg-report-job-history

I think this is the final section of my work to speed up osstest's reporting db queries etc. After this is pushed and working, I will look and see what the interval is now, between one flight finishing and the next starting, to see ig there is more to be done. Ian Jackson (60): history reportin

[OSSTEST PATCH 15/60] history reporting (nfc): Introduce cache_set_key_cols

This setter function will be needed when this becomes its own module. Signed-off-by: Ian Jackson --- sg-report-host-history | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sg-report-host-history b/sg-report-host-history index 9510757f..07e549a0 100755 --- a/sg-report-hos

[OSSTEST PATCH 05/60] history reporting (nfc): Make cache_write_entry into a top-level sub

Signed-off-by: Ian Jackson --- sg-report-host-history | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/sg-report-host-history b/sg-report-host-history index 83344a40..fe5b7cc2 100755 --- a/sg-report-host-history +++ b/sg-report-h

[OSSTEST PATCH 11/60] history reporting (nfc): Rename $cachehits to $rows_hit

Prep work. Signed-off-by: Ian Jackson --- sg-report-host-history | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sg-report-host-history b/sg-report-host-history index 8c5cd105..705367cf 100755 --- a/sg-report-host-history +++ b/sg-report-host-history @@ -118,7 +118,7 @@

Re: Planned osstest outage, around 17th August

Ian Jackson writes ("Planned osstest outage, around 17th August"): > osstest's infrastructure hosts need upgrading to Debian "buster" (aka > Debian "stable"). We are planning to do this on Monday the 17th of > August. > > This will involve telling osstest to start draining its queues some > time

Re: [GIT PULL] xen: branch for v5.9-rc1b

The pull request you sent on Fri, 14 Aug 2020 15:39:39 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-5.9-rc1b-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0520058d0578c2924b1571c16281f873cb4a3d2b Thank you! -- Deet-doot-dot, I

Re: [PATCH 3/4] build: also check for empty .bss.* in .o -> .init.o conversion

Hi Jan, On 06/08/2020 10:05, Jan Beulich wrote: We're gaining such sections, and like .text.* and .data.* they shouldn't be present in objects subject to automatic to-init conversion. Oddly enough for quite some time we did have an instance breaking this rule, which gets fixed at this occasion,

Re: [PATCH] xen/x86: irq: Avoid a TOCTOU race in pirq_spin_lock_irq_desc()

Hi Andrew, Sorry for the late answer. On 23/07/2020 14:59, Andrew Cooper wrote: On 23/07/2020 14:22, Julien Grall wrote: Hi Jan, On 23/07/2020 12:23, Jan Beulich wrote: On 22.07.2020 18:53, Julien Grall wrote: --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -1187,7 +1187,7 @@ struct ir

Re: [RESEND][PATCH v2 7/7] xen/guest_access: Fix coding style in xen/guest_access.h

Hi Jan, On 31/07/2020 12:41, Jan Beulich wrote: On 30.07.2020 20:18, Julien Grall wrote: From: Julien Grall * Add space before and after operator * Align \ * Format comments How about also * remove/replace leading underscores ? I don't have any plan for this. You are

Re: [RESEND][PATCH v2 6/7] xen/guest_access: Consolidate guest access helpers in xen/guest_access.h

Hi Jan, On 31/07/2020 12:45, Jan Beulich wrote: On 30.07.2020 20:18, Julien Grall wrote: From: Julien Grall Most of the helpers to access guest memory are implemented the same way on Arm and x86. The only differences are: - guest_handle_{from, to}_param(): while on x86 XEN_GUEST_HANDLE()

Re: [RESEND][PATCH v2 6/7] xen/guest_access: Consolidate guest access helpers in xen/guest_access.h

Hi Stefano, On 30/07/2020 20:37, Stefano Stabellini wrote: On Thu, 30 Jul 2020, Julien Grall wrote: From: Julien Grall Most of the helpers to access guest memory are implemented the same way on Arm and x86. The only differences are: - guest_handle_{from, to}_param(): while on x86 XEN_GUE

Re: [RESEND][PATCH v2 5/7] xen: include xen/guest_access.h rather than asm/guest_access.h

Hi Jan, On 31/07/2020 12:36, Jan Beulich wrote: On 30.07.2020 20:18, Julien Grall wrote: From: Julien Grall Only a few places are actually including asm/guest_access.h. While this is fine today, a follow-up patch will want to move most of the helpers from asm/guest_access.h to xen/guest_acces

Re: [RESEND][PATCH v2 4/7] xen/arm: guestcopy: Re-order the includes

Hi, On 31/07/2020 13:53, Bertrand Marquis wrote: On 30 Jul 2020, at 20:18, Julien Grall wrote: From: Julien Grall We usually have xen/ includes first and then asm/. They are also ordered alphabetically among themselves. Signed-off-by: Julien Grall This could have been merged in patch

Re: [Xen-devel] [PATCH v2] x86/hvm: re-work viridian APIC assist code

On Fri, Aug 14, 2020 at 03:13:51PM +0100, David Woodhouse wrote: > On Thu, 2020-08-13 at 11:45 +0200, Roger Pau Monné wrote: > > > The loop appears to be there to handle the case where multiple > > > devices assigned to a domain have MSIs programmed with the same > > > dest/vector... which seems li

Re: [RESEND][PATCH v2 3/7] xen/arm: decode: Re-order the includes

Hi Stefano, On 30/07/2020 20:37, Stefano Stabellini wrote: On Thu, 30 Jul 2020, Julien Grall wrote: From: Julien Grall We usually have xen/ includes first and then asm/. They are also ordered alphabetically among themselves. Signed-off-by: Julien Grall Might wanna mention the change from

Re: [RESEND][PATCH v2 1/7] xen/guest_access: Add emacs magics

Hi, On 31/07/2020 14:04, Bertrand Marquis wrote: On 30 Jul 2020, at 20:18, Julien Grall wrote: From: Julien Grall Add emacs magics for xen/guest_access.h and asm-x86/guest_access.h. Signed-off-by: Julien Grall Acked-by: Jan Beulich Most of file in Xen source code seem to have a white

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

On Fri, Aug 14, 2020 at 02:54:38PM +0200, Jürgen Groß wrote: > On 14.08.20 14:47, Roger Pau Monné wrote: > > On Fri, Aug 14, 2020 at 12:27:32PM +0200, Jürgen Groß wrote: > > > On 14.08.20 11:56, Roger Pau Monné wrote: > > > > On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: > > >

Re: [OSSTEST PATCH] sg-report-flight: Use WITH OFFSET 0 for optimisation fence

> On Aug 14, 2020, at 12:39 PM, Ian Jackson wrote: > > I am not best pleased. > > CC: George Dunlap > Signed-off-by: Ian Jackson Reviewed-by: George Dunlap It is too bad they’re not backporting the “turn off the optimization that breaks everyone’s queries” feature. I was going to say

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

On Fri, Aug 14, 2020 at 12:27:32PM +0200, Jürgen Groß wrote: > On 14.08.20 11:56, Roger Pau Monné wrote: > > On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: > > > On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monn?? wrote: > > > > On Thu, Aug 13, 2020 at 08:33:37AM +0100, C

Re: [RFC PATCH V1 07/12] A collection of tweaks to be able to run emulator in driver domain

Hello all. -Original Message- From: Jan Beulich Sent: 05 August 2020 17:20 To: Oleksandr Tyshchenko ; Paul Durrant Cc: xen-devel@lists.xenproject.org; Oleksandr Tyshchenko ; Andrew Cooper ; George Dunlap ; Ian Jackson ; Julien Grall ; Stefano Stabellini ; Wei Liu ; Daniel De Graaf

Re: [PATCH v3 1/8] public/io/netif: specify MTU override node

On Tue, Aug 11, 2020 at 09:01:55AM +0100, Paul Durrant wrote: > From: Paul Durrant > > There is currently no documentation to state what MTU a frontend should > adertise to its network stack. It has however long been assumed that the > default value of 1500 is correct. > > This patch specifies a

[xen-unstable test] 152597: tolerable FAIL - PUSHED

flight 152597 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152597/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stopfail like 152566 test-amd64-amd64-xl-qemut-win7-amd64

Re: [XEN PATCH] rpmball: Adjust to new rpm, do not require --force

On Sun, Aug 09, 2020 at 02:22:34PM -0400, Don Slutz wrote: > From: Don Slutz > > Also prevent warning: directory /boot: remove failed > > Before: > > [root@TestCloud1 xen]# rpm -hiv dist/xen*rpm > Preparing... # [100%] > file /boo

Re: [Xen-devel] [PATCH 1/2] tools/xenstore: Do not abort xenstore-ls if a node disappears while iterating

On Fri, Aug 14, 2020 at 03:23:10PM +0100, David Woodhouse wrote: > On Mon, 2020-03-30 at 17:40 +0100, Ian Jackson wrote: > > Ian Jackson writes ("Re: [Xen-devel] [PATCH 1/2] tools/xenstore: Do > > not abort xenstore-ls if a node disappears while iterating"): > > > And making a node visible by XS_DI

Re: [PATCH 4/4] EFI: free unused boot mem in at least some cases

On Mon, 2020-08-10 at 18:09 +0100, Andrew Cooper wrote: > I think the better course of action is to go with David Woodhouse's work > to not relocate the trampoline until later on boot (if even necessary), > at which point both of the custom allocators can disappear. I confess I had mostly given up

Re: [RFC PATCH 2/2] libxl: prototype libxl_device_nic_add/remove with IDL

On Mon, Jul 27, 2020 at 09:26:33AM -0400, Nick Rosbrook wrote: > Add a DeviceFunction class and describe prototypes for > libxl_device_nic_add/remove in libxl_types.idl. > > Signed-off-by: Nick Rosbrook > -- > This is mostly to serve as an example of how the first patch would be > used for functi

Re: [RFC PATCH 1/2] libxl: add Function class to IDL

On Mon, Jul 27, 2020 at 09:26:32AM -0400, Nick Rosbrook wrote: > Add a Function and CtxFunction classes to idl.py to allow generator > scripts to generate wrappers which are repetitive and straight forward > when doing so by hand. Examples of such functions are the > device_add/remove functions. >

Re: [Xen-devel] [PATCH 1/2] tools/xenstore: Do not abort xenstore-ls if a node disappears while iterating

On Mon, 2020-03-30 at 17:40 +0100, Ian Jackson wrote: > Ian Jackson writes ("Re: [Xen-devel] [PATCH 1/2] tools/xenstore: Do > not abort xenstore-ls if a node disappears while iterating"): > > And making a node visible by XS_DIRECTORY[_PART] doesn't count as > > reading it. But it does count as rea

Re: [Xen-devel] [PATCH v2] x86/hvm: re-work viridian APIC assist code

On Thu, 2020-08-13 at 11:45 +0200, Roger Pau Monné wrote: > > The loop appears to be there to handle the case where multiple > > devices assigned to a domain have MSIs programmed with the same > > dest/vector... which seems like an odd thing for a guest to do but I > > guess it is at liberty to do

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: > On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monn?? wrote: > > On Thu, Aug 13, 2020 at 08:33:37AM +0100, Christoph Hellwig wrote: > > > On Tue, Aug 11, 2020 at 11:44:47AM +0200, Roger Pau Monne wrote: > > > > If enabled (be

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

On 14.08.20 15:35, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 02:54:38PM +0200, Jürgen Groß wrote: On 14.08.20 14:47, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 12:27:32PM +0200, Jürgen Groß wrote: On 14.08.20 11:56, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 08:29:20AM +0100, Chr

[GIT PULL] xen: branch for v5.9-rc1b

Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.9-rc1b-tag xen: branch for v5.9-rc1, 2nd batch It contains 2 series: - Removal of support for running as 32-bit Xen PV-guest. 32-bit PV guests are rarely used, are lacking securi

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

On 14.08.20 14:47, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 12:27:32PM +0200, Jürgen Groß wrote: On 14.08.20 11:56, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monn?? wrote: On Thu, Aug 13,

Re: [RFC PATCH V1 04/12] xen/arm: Introduce arch specific bits for IOREQ/DM features

On 14.08.20 01:14, Julien Grall wrote: Hi Julien On Thu, 13 Aug 2020 at 21:40, Oleksandr Tyshchenko wrote: Hi Sorry for the possible format issue. On Thu, Aug 13, 2020 at 9:42 PM Oleksandr wrote: On 11.08.20 20:50, Julien Grall wrote: Hi Julien On 11/08/2020 18:09, Oleksandr wrote

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

On 14.08.20 11:56, Roger Pau Monné wrote: On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monn?? wrote: On Thu, Aug 13, 2020 at 08:33:37AM +0100, Christoph Hellwig wrote: On Tue, Aug 11, 2020 at 11:44:47AM +0200, Roger Pau

  1   2   >