Re: [PATCH] xen: remove trailing semicolon in macro definition

2020-12-15 Thread Jürgen Groß
On 27.11.20 17:07, t...@redhat.com wrote: From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix Applied to: xen/tip.git for-linus-5.11 Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: application/pgp-keys OpenPGP_signature Description: OpenPGP digital

Re: [PATCH 138/141] xen/manage: Fix fall-through warnings for Clang

2020-12-15 Thread Jürgen Groß
On 20.11.20 19:40, Gustavo A. R. Silva wrote: In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R.

Re: [PATCH 058/141] xen-blkfront: Fix fall-through warnings for Clang

2020-12-15 Thread Jürgen Groß
On 20.11.20 19:32, Gustavo A. R. Silva wrote: In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R.

Re: [PATCH 0/2] Remove Xen PVH dependency on PCI

2020-12-15 Thread Jürgen Groß
On 14.10.20 19:53, Jason Andryuk wrote: A Xen PVH domain doesn't have a PCI bus or devices, so it doesn't need PCI support built in. Currently, XEN_PVH depends on XEN_PVHVM which depends on PCI. The first patch introduces XEN_PVHVM_GUEST as a toplevel item and changes XEN_PVHVM to a hidden

Re: [PATCH -next v2] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE

2020-12-15 Thread Jürgen Groß
On 17.09.20 14:55, Qinglang Miao wrote: Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao Applied to: xen/tip.git for-linus-5.11 Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: application/pgp-keys OpenPGP_signature Description: OpenPGP digital

Re: [PATCH v10 04/25] tools/libxenevtchn: add possibility to not close file descriptor on exec

2020-12-15 Thread Jürgen Groß
On 15.12.20 19:09, Andrew Cooper wrote: On 15/12/2020 16:35, Juergen Gross wrote: Signed-off-by: Juergen Gross Reviewed-by: Wei Liu Reviewed-by: Julien Grall --- V7: - new patch V8: - some minor comments by Julien Grall addressed Signed-off-by: Juergen Gross Various of your patches

[xen-4.14-testing test] 157564: tolerable FAIL - PUSHED

2020-12-15 Thread osstest service owner
flight 157564 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/157564/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 157133

[xen-unstable-smoke test] 157590: regressions - FAIL

2020-12-15 Thread osstest service owner
flight 157590 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/157590/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 157560 Tests which

[xen-4.13-testing test] 157563: regressions - FAIL

2020-12-15 Thread osstest service owner
flight 157563 xen-4.13-testing real [real] flight 157592 xen-4.13-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157563/ http://logs.test-lab.xenproject.org/osstest/logs/157592/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

[xen-4.12-testing test] 157562: regressions - FAIL

2020-12-15 Thread osstest service owner
flight 157562 xen-4.12-testing real [real] flight 157578 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157562/ http://logs.test-lab.xenproject.org/osstest/logs/157578/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

Re: Xen-ARM DomUs

2020-12-15 Thread Elliott Mitchell
On Tue, Dec 15, 2020 at 08:36:34AM -0800, Stefano Stabellini wrote: > On Mon, 14 Dec 2020, Elliott Mitchell wrote: > > The available examples seem geared towards Linux DomUs. I'm looking at a > > FreeBSD installation image and it appears to expect an EFI firmware. > > Beyond having a bunch of

[xen-unstable-smoke test] 157582: regressions - FAIL

2020-12-15 Thread osstest service owner
flight 157582 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/157582/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 157560 Tests which

[xen-unstable-smoke bisection] complete build-amd64-libvirt

2020-12-15 Thread osstest service owner
branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-amd64-libvirt testid libvirt-build Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu

arm32 tools/flask build failure

2020-12-15 Thread Stefano Stabellini
Hi all, I am building Xen tools for ARM32 using qemu-user. I am getting the following error building tools/flask. Everything else works fine. It is worth noting that make -j1 works fine, it is only make -j4 that fails. I played with .NOTPARALLEL but couldn't get it to work. Anyone has any ideas?

Re: [PATCH v2 00/12] x86: major paravirt cleanup

2020-12-15 Thread Josh Poimboeuf
On Tue, Dec 15, 2020 at 03:54:08PM +0100, Peter Zijlstra wrote: > The problem is that a single instance of unwind information (ORC) must > capture and correctly unwind all alternatives. Since the trivially > correct mandate is out, implement the straight forward brute-force > approach: > > 1)

[xen-unstable-smoke test] 157575: regressions - FAIL

2020-12-15 Thread osstest service owner
flight 157575 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/157575/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 157560 Tests which

Re: [openxt-dev] Re: Follow up on libxl-fix-reboot.patch

2020-12-15 Thread Chris Rogers
Hopefully I can provide a little more context. Here is a link to the patch: https://github.com/OpenXT/xenclient-oe/blob/master/recipes-extended/xen/files/libxl-fix-reboot.patch The patch is a bit mis-named. It does not implement XEN_DOMCTL_SENDTRIGGER_RESET. It's just a workaround to handle

Re: [PATCH v2] xen/xenbus: make xs_talkv() interruptible

2020-12-15 Thread Andrew Cooper
On 15/12/2020 11:10, Juergen Gross wrote: > In case a process waits for any Xenstore action in the xenbus driver > it should be interruptible by signals. > > Signed-off-by: Juergen Gross > --- > V2: > - don't special case SIGKILL as libxenstore is handling -EINTR fine > --- >

Re: [SPECIFICATION RFC] The firmware and bootloader log specification

2020-12-15 Thread Simon Glass
Hi Daniel, On Fri, 13 Nov 2020 at 19:07, Daniel Kiper wrote: > > Hey, > > This is next attempt to create firmware and bootloader log specification. > Due to high interest among industry it is an extension to the initial > bootloader log only specification. It takes into the account most of the >

[xen-unstable-smoke test] 157570: regressions - FAIL

2020-12-15 Thread osstest service owner
flight 157570 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/157570/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 157560 Tests which

Re: [PATCH v2] xen/xenbus: make xs_talkv() interruptible

2020-12-15 Thread boris . ostrovsky
On 12/15/20 6:10 AM, Juergen Gross wrote: > In case a process waits for any Xenstore action in the xenbus driver > it should be interruptible by signals. > > Signed-off-by: Juergen Gross > --- > V2: > - don't special case SIGKILL as libxenstore is handling -EINTR fine Reviewed-by: Boris

Re: [RFC PATCH v2 00/15] xen/arm: port Linux LL/SC and LSE atomics helpers to Xen.

2020-12-15 Thread Julien Grall
On 11/11/2020 21:51, Ash Wilding wrote: From: Ash Wilding Hey, Hi Ash, I've found some time to improve this series a bit: Changes since RFC v1 - Broken up patches into smaller chunks to aid in readability. - As per Julien's feedback I've also introduced

Re: Recent upgrade of 4.13 -> 4.14 issue

2020-12-15 Thread Liwei
Hi list, This is a reply to the thread of the same title (linked here: https://www.mail-archive.com/xen-devel@lists.xenproject.org/msg84916.html ) which I could not reply to because I receive this list by digest. I'm unclear if this is exactly the reason, but I experienced the same

[linux-linus test] 157555: regressions - FAIL

2020-12-15 Thread osstest service owner
flight 157555 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/157555/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332

Re: [RFC PATCH v2 10/15] xen/arm64: port Linux's arm64 cmpxchg.h to Xen

2020-12-15 Thread Julien Grall
Hi Ash, On 11/11/2020 21:51, Ash Wilding wrote: From: Ash Wilding - s/arch_xchg/xchg/ - s/arch_cmpxchg/cmpxchg/ - Replace calls to BUILD_BUG() with calls to __bad_cmpxchg() as we don't currently have a BUILD_BUG() macro in Xen and this will equivalently cause a link-time

Re: [RFC PATCH v2 08/15] xen/arm64: port Linux's arm64 atomic_ll_sc.h to Xen

2020-12-15 Thread Julien Grall
Hi Ash, On 11/11/2020 21:51, Ash Wilding wrote: From: Ash Wilding Most of the "work" here is simply deleting the atomic64_t helper definitions as we don't have an atomic64_t type in Xen. There is some request to support atomic64_t in Xen. I would suggest to keep as this would be simpler to

Re: [RFC PATCH 1/6] xen/arm: Support detection of CPU features in other ID registers

2020-12-15 Thread Julien Grall
Hi Ash, Apologies for the late reply. On 05/11/2020 18:55, Ash Wilding wrote: The current Arm boot_cpu_feature64() and boot_cpu_feature32() macros are hardcoded to only detect features in ID_AA64PFR{0,1}_EL1 and ID_PFR{0,1} respectively. This patch replaces these macros with a new macro,

Re: [PATCH v10 04/25] tools/libxenevtchn: add possibility to not close file descriptor on exec

2020-12-15 Thread Andrew Cooper
On 15/12/2020 16:35, Juergen Gross wrote: > Signed-off-by: Juergen Gross > Reviewed-by: Wei Liu > Reviewed-by: Julien Grall > --- > V7: > - new patch > > V8: > - some minor comments by Julien Grall addressed > > Signed-off-by: Juergen Gross Various of your patches still have double SoB. 

Re: [PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

2020-12-15 Thread Sergio Lopez
On Tue, Dec 15, 2020 at 04:01:19PM +0100, Kevin Wolf wrote: > Am 15.12.2020 um 14:15 hat Sergio Lopez geschrieben: > > On Tue, Dec 15, 2020 at 01:12:33PM +0100, Kevin Wolf wrote: > > > Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben: > > > > While processing the parents of a BDS, one of the

Re: [PATCH v2 4/4] block: Close block exports in two steps

2020-12-15 Thread Sergio Lopez
On Tue, Dec 15, 2020 at 04:34:05PM +0100, Kevin Wolf wrote: > Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben: > > There's a cross-dependency between closing the block exports and > > draining the block layer. The latter needs that we close all export's > > client connections to ensure they

Re: [PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

2020-12-15 Thread Sergio Lopez
On Tue, Dec 15, 2020 at 01:12:33PM +0100, Kevin Wolf wrote: > Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben: > > While processing the parents of a BDS, one of the parents may process > > the child that's doing the tail recursion, which leads to a BDS being > > processed twice. This is

Re: [PATCH 6/6] x86/p2m: set_shared_p2m_entry() is MEM_SHARING-only

2020-12-15 Thread Tamas K Lengyel
On Tue, Dec 15, 2020 at 11:28 AM Jan Beulich wrote: > > Signed-off-by: Jan Beulich Reviewed-by: Tamas K Lengyel

Re: Xen-ARM DomUs

2020-12-15 Thread Julien Grall
Hi, On 15/12/2020 02:35, Roman Shaposhnik wrote: On Mon, Dec 14, 2020 at 6:16 PM Elliott Mitchell wrote: Finally getting to the truly productive stages of my project with Xen on ARM. How many of the OSes which function as x86 DomUs for Xen, function as ARM DomUs? Getting Linux operational

[PATCH v10 23/25] tools/xenstore: add read watch state for live update

2020-12-15 Thread Juergen Gross
Add reading the watch state records for live update. This requires factoring out some of the add watch functionality into a dedicated function. Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant --- V4: - add comment (Julien Grall) V6: - correct check_watch_path() (setting errno)

[PATCH v10 21/25] tools/xenstore: add read connection state for live update

2020-12-15 Thread Juergen Gross
Add the needed functions for reading connection state for live update. As the connection is identified by a unique connection id in the state records we need to add this to struct connection. Add a new function to return the connection based on a connection id. Signed-off-by: Juergen Gross

[ovmf test] 157561: regressions - FAIL

2020-12-15 Thread osstest service owner
flight 157561 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157561/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 157345

[PATCH v10 24/25] tools/xenstore: handle dying domains in live update

2020-12-15 Thread Juergen Gross
From: Julien Grall A domain could just be dying when live updating Xenstore, so the case of not being able to map the ring page or to connect to the event channel must be handled gracefully. Signed-off-by: Julien Grall Reviewed-by: Paul Durrant --- V4: - new patch (Julien, I hope adding the

Re: Xen-ARM DomUs

2020-12-15 Thread Stefano Stabellini
On Mon, 14 Dec 2020, Elliott Mitchell wrote: > Finally getting to the truly productive stages of my project with Xen on > ARM. > > How many of the OSes which function as x86 DomUs for Xen, function as > ARM DomUs? Getting Linux operational was straightforward, but what of > others? I know of

Re: Xen-ARM DomUs

2020-12-15 Thread Julien Grall
Hi, On 15/12/2020 02:16, Elliott Mitchell wrote: Finally getting to the truly productive stages of my project with Xen on ARM. How many of the OSes which function as x86 DomUs for Xen, function as ARM DomUs? Getting Linux operational was straightforward, but what of others? If you are

[PATCH v10 25/25] tools/xenstore: activate new binary for live update

2020-12-15 Thread Juergen Gross
Add activation of the new binary for live update. The daemon case is handled completely, while for stubdom we only add stubs. Signed-off-by: Juergen Gross --- V7: - added unbinding dom0 and virq event channels V8: - no longer close dom0 evtchn (Julien Grall) V10: - remember original argc and

[PATCH v10 22/25] tools/xenstore: add read node state for live update

2020-12-15 Thread Juergen Gross
Add the needed functions for reading node state for live update. This requires some refactoring of current node handling in Xenstore in order to avoid repeating the same code patterns multiple times. Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant Acked-by: Julien Grall --- V4: - drop

[PATCH v10 15/25] tools/xenstore: dump the xenstore state for live update

2020-12-15 Thread Juergen Gross
Dump the complete Xenstore status to a file (daemon case) or memory (stubdom case). As we don't know the exact length of the needed area in advance we are using an anonymous rather large mapping in stubdom case, which will use only virtual address space until accessed. And as we are writing the

[PATCH v10 18/25] tools/xenstore: evaluate the live update flag when starting

2020-12-15 Thread Juergen Gross
In the live update case several initialization steps of xenstore must be omitted or modified. Add the proper handling for that. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V4: - set xprintf = trace in daemon case (Julien Grall) - only update /tool/xenstored node contents V7: -

[PATCH v10 16/25] tools/xenstore: handle CLOEXEC flag for local files and pipes

2020-12-15 Thread Juergen Gross
For support of live update the locally used files need to have the "close on exec" flag set. Fortunately the used Xen libraries are already doing this, so only the logging and tdb related files and pipes are affected. openlog() has the close on exec attribute, too. In order to be able to keep the

[PATCH v10 20/25] tools/xenstore: add reading global state for live update

2020-12-15 Thread Juergen Gross
Add reading the global state for live update. Signed-off-by: Juergen Gross Acked-by: Julien Grall Reviewed-by: Paul Durrant --- tools/xenstore/xenstored_control.c | 1 + tools/xenstore/xenstored_core.c| 9 + tools/xenstore/xenstored_core.h| 2 ++ 3 files changed, 12

[PATCH v10 19/25] tools/xenstore: read internal state when doing live upgrade

2020-12-15 Thread Juergen Gross
When started due to a live upgrade read the internal state and apply it to the data base and internal structures. Add the main control functions for that. For now only handle the daemon case. Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant Acked-by: Julien Grall --- V4: - directly

[PATCH v10 13/25] docs: update the xenstore migration stream documentation

2020-12-15 Thread Juergen Gross
For live update of Xenstore some records defined in the migration stream document need to be changed: - Support of the read-only socket has been dropped from all Xenstore implementations, so ro-socket-fd in the global record can be removed. - Some guests require the event channel to Xenstore

[PATCH v10 07/25] tools/xenstore: add basic live-update command parsing

2020-12-15 Thread Juergen Gross
Add the basic parts for parsing the live-update control command. For now only add the parameter evaluation and calling appropriate functions. Those function only print a message for now and return success. Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant Reviewed-by: Julien Grall ---

[PATCH v10 17/25] tools/xenstore: split off domain introduction from do_introduce()

2020-12-15 Thread Juergen Gross
For live update the functionality to introduce a new domain similar to the XS_INTRODUCE command is needed, so split that functionality off into a dedicated function introduce_domain(). Switch initial dom0 initialization to use this function, too. Signed-off-by: Juergen Gross Reviewed-by: Julien

[PATCH v10 12/25] tools/xenstore: allow live update only with no transaction active

2020-12-15 Thread Juergen Gross
In order to simplify live update state dumping only allow live update to happen when no transaction is active. A timeout is used to detect guests which have a transaction active for longer periods of time. In case such a guest is detected when trying to do a live update it will be reported and

[PATCH v10 06/25] tools/xenstore: add live update command to xenstore-control

2020-12-15 Thread Juergen Gross
Add the "live-update" command to xenstore-control enabling updating xenstored to a new version in a running Xen system. With -c it is possible to pass a different command line to the new instance of xenstored. This will replace the command line used for the invocation of the just running

[PATCH v10 14/25] tools/xenstore: add include file for state structure definitions

2020-12-15 Thread Juergen Gross
Add an include file containing all structures and defines needed for dumping and restoring the internal Xenstore state. Signed-off-by: Juergen Gross Acked-by: Julien Grall --- V4: - drop mfn from connection record (rebase to V5 of state doc patch) - add #ifdef __MINIOS__ (Julien Grall) -

[PATCH v10 05/25] tools/xenstore: refactor XS_CONTROL handling

2020-12-15 Thread Juergen Gross
In order to allow control commands with binary data refactor handling of XS_CONTROL: - get primary command first - add maximum number of additional parameters to pass to command handler Signed-off-by: Juergen Gross Reviewed-by: Julien Grall Reviewed-by: Paul Durrant --- V2: - add comment

[PATCH v10 11/25] tools/xenstore: add the basic framework for doing the live update

2020-12-15 Thread Juergen Gross
Add the main framework for executing the live update. This for now only defines the basic execution steps with empty dummy functions. This final step returning means failure, as in case of success the new executable will have taken over. Signed-off-by: Juergen Gross Acked-by: Julien Grall

[PATCH v10 03/25] tools/xenstore: remove unused cruft from xenstored_domain.c

2020-12-15 Thread Juergen Gross
domain->remote_port and restore_existing_connections() are useless and can be removed. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- V7: - new patch --- tools/xenstore/xenstored_core.c | 3 --- tools/xenstore/xenstored_domain.c | 11 ---

[PATCH v10 09/25] tools/xenstore: save new binary for live update

2020-12-15 Thread Juergen Gross
Save the new binary name for the daemon case and the new kernel for stubdom in order to support live update of Xenstore.. Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant Reviewed-by: Julien Grall --- tools/xenstore/xenstored_control.c | 41 +- 1 file

[PATCH v10 10/25] tools/xenstore: add command line handling for live update

2020-12-15 Thread Juergen Gross
Updating an instance of Xenstore via live update needs to hand over the command line parameters to the updated instance. Those can be either the parameters used by the updated instance or new ones when supplied when starting the live update. So when supplied store the new command line parameters

[PATCH v10 00/25] tools/xenstore: support live update for xenstored

2020-12-15 Thread Juergen Gross
Today Xenstore is not restartable. This means a Xen server needing an update of xenstored has to be rebooted in order to let this update become effective. This patch series is changing that: The internal state of xenstored (the contents of Xenstore, all connections to various clients like

[PATCH v10 08/25] tools/xenstore: introduce live update status block

2020-12-15 Thread Juergen Gross
Live update of Xenstore is done in multiple steps. It needs a status block holding the current state of live update and related data. It is allocated as child of the connection live update was started over in order to abort live update in case the connection is closed. Allocation of the block is

[PATCH v10 02/25] tools/xenstore: make set_tdb_key() non-static

2020-12-15 Thread Juergen Gross
set_tdb_key() can be used by destroy_node(), too. So remove the static attribute and move it to xenstored_core.c. Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant --- V5: - new patch V6: - add comment (Julien Grall) Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c

[PATCH v10 04/25] tools/libxenevtchn: add possibility to not close file descriptor on exec

2020-12-15 Thread Juergen Gross
Today the file descriptor for the access of the event channel driver is being closed in case of exec(2). For the support of live update of a daemon using libxenevtchn this can be problematic, so add a way to keep that file descriptor open. Add support of a flag XENEVTCHN_NO_CLOEXEC for

[PATCH v10 01/25] tools/xenstore: switch barf[_perror]() to use syslog()

2020-12-15 Thread Juergen Gross
When xenstored crashes due to an unrecoverable condition it is calling either barf() or barf_perror() to issue a message and then exit(). Make sure the message is visible somewhere by using syslog() additionally to xprintf(), as the latter will be visible only with tracing active. Signed-off-by:

Re: [PATCH v2 4/4] livepatch: adjust a stale comment

2020-12-15 Thread Konrad Rzeszutek Wilk
On Tue, Dec 15, 2020 at 05:13:43PM +0100, Jan Beulich wrote: > As of 005de45c887e ("xen: do live patching only from main idle loop") > the comment ahead of livepatch_do_action() has been stale. > Reviewed-by: Konrad Rzeszutek Wilk Thank you! > Signed-off-by: Jan Beulich > > ---

Re: [PATCH v1 3/3] tools: add API to work with sevaral bits at once

2020-12-15 Thread Wei Liu
On Tue, Dec 15, 2020 at 05:29:17PM +0100, Olaf Hering wrote: > Am Tue, 15 Dec 2020 16:22:44 + > schrieb Wei Liu : > > > What's wrong with requiring the input addr be const unsigned long *? > > Probably nothing. In the end I just borrowed the prototypes from the other > functions in this

Re: [PATCH v2 3/4] x86/PV: avoid double stack reset during schedule tail handling

2020-12-15 Thread Wei Liu
On Tue, Dec 15, 2020 at 05:12:36PM +0100, Jan Beulich wrote: > Invoking check_wakeup_from_wait() from assembly allows the new > continue_pv_domain() to replace the prior continue_nonidle_domain() as > the tail hook, eliminating an extra reset_stack_and_jump(). > > Signed-off-by: Jan Beulich >

Re: [PATCH v1 3/3] tools: add API to work with sevaral bits at once

2020-12-15 Thread Olaf Hering
Am Tue, 15 Dec 2020 16:22:44 + schrieb Wei Liu : > What's wrong with requiring the input addr be const unsigned long *? Probably nothing. In the end I just borrowed the prototypes from the other functions in this file. I will resend with this change once I have the consumers ready. Olaf

Re: [PATCH v2 2/4] x86: clobber registers in switch_stack_and_jump() when !LIVEPATCH

2020-12-15 Thread Wei Liu
On Tue, Dec 15, 2020 at 05:12:12PM +0100, Jan Beulich wrote: > In order to have the same effect on registers as a call to > check_for_livepatch_work() may have, clobber all call-clobbered > registers in debug builds. > > Signed-off-by: Jan Beulich Reviewed-by: Wei Liu

Re: [PATCH v2 1/4] x86: verify function type (and maybe attribute) in switch_stack_and_jump()

2020-12-15 Thread Wei Liu
On Tue, Dec 15, 2020 at 05:11:41PM +0100, Jan Beulich wrote: > It is imperative that the functions passed here are taking no arguments, > return no values, and don't return in the first place. While the type > can be checked uniformly, the attribute check is limited to gcc 9 and > newer (no clang

[PATCH 6/6] x86/p2m: set_shared_p2m_entry() is MEM_SHARING-only

2020-12-15 Thread Jan Beulich
Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -1476,6 +1476,8 @@ int clear_identity_p2m_entry(struct doma return ret; } +#ifdef CONFIG_MEM_SHARING + /* Returns: 0 for success, -errno for failure */ int set_shared_p2m_entry(struct domain *d,

[PATCH 5/6] x86/mm: the gva_to_gfn() hook is HVM-only

2020-12-15 Thread Jan Beulich
As is the adjacent ga_to_gfn() one as well as paging_gva_to_gfn(). Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -1772,7 +1772,6 @@ void np2m_schedule(int dir) p2m_unlock(p2m); } } -#endif unsigned long paging_gva_to_gfn(struct vcpu *v,

[PATCH 4/6] x86/p2m: {,un}map_mmio_regions() are HVM-only

2020-12-15 Thread Jan Beulich
Mirror the "translated" check the functions do to do_domctl(), allowing the calls to be DCEd by the compiler. Add ASSERT_UNREACHABLE() to the original checks. Also arrange for {set,clear}_mmio_p2m_entry() and {set,clear}_identity_p2m_entry() to respectively live next to each other, such that

[PATCH 3/6] x86/p2m: set_{foreign,mmio}_p2m_entry() are HVM-only

2020-12-15 Thread Jan Beulich
Extend a respective #ifdef from inside set_typed_p2m_entry() to around all three functions. Add ASSERT_UNREACHABLE() to the latter one's safety check path. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -1257,6 +1257,8 @@ int p2m_finish_type_change(struct

[PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2020-12-15 Thread Jan Beulich
This is together with its only caller, xenmem_add_to_physmap_one(). Move the latter next to p2m_add_foreign(), allowing this one to become static at the same time. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -118,7 +118,6 @@ #include #include #include

[PATCH 1/6] x86/p2m: tidy p2m_add_foreign() a little

2020-12-15 Thread Jan Beulich
Drop a bogus ASSERT() - we don't typically assert incoming domain pointers to be non-NULL, and there's no particular reason to do so here. Replace the open-coded DOMID_SELF check by use of rcu_lock_remote_domain_by_id(), at the same time covering the request being made with the current domain's

[PATCH 0/6] x86/p2m: restrict more code to build just for HVM

2020-12-15 Thread Jan Beulich
1: p2m: tidy p2m_add_foreign() a little 2: mm: p2m_add_foreign() is HVM-only 3: p2m: set_{foreign,mmio}_p2m_entry() are HVM-only 4: p2m: {,un}map_mmio_regions() are HVM-only 5: mm: the gva_to_gfn() hook is HVM-only 6: p2m: set_shared_p2m_entry() is MEM_SHARING-only Jan

Re: [PATCH v1 3/3] tools: add API to work with sevaral bits at once

2020-12-15 Thread Wei Liu
On Wed, Dec 09, 2020 at 04:54:51PM +0100, Olaf Hering wrote: > Introduce new API to test if a fixed number of bits is clear or set, > and clear or set them all at once. > > The caller has to make sure the input bitnumber is a multiply of > BITS_PER_LONG. > > This API avoids the loop over each

Re: [PATCH v1 2/3] tools: remove unused ORDER_LONG

2020-12-15 Thread Wei Liu
On Wed, Dec 09, 2020 at 04:54:50PM +0100, Olaf Hering wrote: > There are no users left, xenpaging has its own variant. > The last user was removed with commit 11d0044a168994de85b9b328452292852aedc871 > > Signed-off-by: Olaf Hering Acked-by: Wei Liu

Re: [PATCH] xen: Rework WARN_ON() to return whether a warning was triggered

2020-12-15 Thread Jürgen Groß
On 15.12.20 14:11, Julien Grall wrote: Hi Juergen, On 15/12/2020 11:31, Jürgen Groß wrote: On 15.12.20 12:26, Julien Grall wrote: From: Julien Grall So far, our implementation of WARN_ON() cannot be used in the following situation: if ( WARN_ON() ) ... This is because the WARN_ON()

[qemu-mainline test] 157548: regressions - FAIL

2020-12-15 Thread osstest service owner
flight 157548 qemu-mainline real [real] flight 157567 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157548/ http://logs.test-lab.xenproject.org/osstest/logs/157567/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not

[PATCH v2 4/4] livepatch: adjust a stale comment

2020-12-15 Thread Jan Beulich
As of 005de45c887e ("xen: do live patching only from main idle loop") the comment ahead of livepatch_do_action() has been stale. Signed-off-by: Jan Beulich --- a/xen/common/livepatch.c +++ b/xen/common/livepatch.c @@ -1392,8 +1392,8 @@ static inline bool was_action_consistent } /* - * This

[PATCH v2 3/4] x86/PV: avoid double stack reset during schedule tail handling

2020-12-15 Thread Jan Beulich
Invoking check_wakeup_from_wait() from assembly allows the new continue_pv_domain() to replace the prior continue_nonidle_domain() as the tail hook, eliminating an extra reset_stack_and_jump(). Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross --- a/xen/arch/x86/pv/domain.c +++

[xen-unstable-smoke test] 157560: tolerable all pass - PUSHED

2020-12-15 Thread osstest service owner
flight 157560 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/157560/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[PATCH v2 2/4] x86: clobber registers in switch_stack_and_jump() when !LIVEPATCH

2020-12-15 Thread Jan Beulich
In order to have the same effect on registers as a call to check_for_livepatch_work() may have, clobber all call-clobbered registers in debug builds. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/include/asm-x86/current.h +++ b/xen/include/asm-x86/current.h @@ -120,6 +120,14 @@ unsigned

[PATCH v2 1/4] x86: verify function type (and maybe attribute) in switch_stack_and_jump()

2020-12-15 Thread Jan Beulich
It is imperative that the functions passed here are taking no arguments, return no values, and don't return in the first place. While the type can be checked uniformly, the attribute check is limited to gcc 9 and newer (no clang support for this so far afaict). Note that I didn't want to have the

Re: [PATCH v1 1/3] tools: allocate bitmaps in units of unsigned long

2020-12-15 Thread Wei Liu
On Wed, Dec 09, 2020 at 04:54:49PM +0100, Olaf Hering wrote: > Allocate enough memory so that the returned pointer can be safely > accessed as an array of unsigned long. > > The actual bitmap size in units of bytes, as returned by bitmap_size, > remains unchanged. > > Signed-off-by: Olaf Hering

[PATCH v2 0/4] x86: XSA-348 follow-up

2020-12-15 Thread Jan Beulich
The changes for this XSA introduced an inefficiency and could do with some further hardening. Addressing of this wasn't sensible as part of the XSA, though (but you may take this as an explanation of why this starts out as v2). 1: x86: verify function type (and maybe attribute) in

Re: [PATCH v6 23/25] xl: support naming of assignable devices

2020-12-15 Thread Wei Liu
On Tue, Dec 08, 2020 at 07:30:31PM +, Paul Durrant wrote: > From: Paul Durrant > > This patch converts libxl to use libxl_pci_bdf_assignable_add/remove/list/ > list_free() rather than libxl_device_pci_assignable_add/remove/list/ > list_free(), which then allows naming of assignable devices

Re: [PATCH v6 22/25] libxl: introduce libxl_pci_bdf_assignable_add/remove/list/list_free(), ...

2020-12-15 Thread Wei Liu
On Tue, Dec 08, 2020 at 07:30:30PM +, Paul Durrant wrote: > From: Paul Durrant > > which support naming and use 'libxl_pci_bdf' rather than 'libxl_device_pci', > as replacements for libxl_device_pci_assignable_add/remove/list/list_free(). > > libxl_pci_bdf_assignable_add() takes a 'name'

Re: [PATCH v6 21/25] libxl: convert internal functions in libxl_pci.c...

2020-12-15 Thread Wei Liu
On Tue, Dec 08, 2020 at 07:30:29PM +, Paul Durrant wrote: > From: Paul Durrant > > ... to use 'libx_pci_bdf' where appropriate. > > No API change. > > Signed-off-by: Paul Durrant Acked-by: Wei Liu

Re: [PATCH v6 02/25] xl: s/pcidev/pci where possible

2020-12-15 Thread Wei Liu
On Tue, Dec 08, 2020 at 07:30:10PM +, Paul Durrant wrote: > From: Paul Durrant > > To improve naming consistency, replaces occurrences of 'pcidev' with 'pci'. > The only remaining use of the term should be in relation to > 'libxl_domain_config' where there are fields named 'pcidevs' and >

Re: [PATCH v6 01/25] libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X

2020-12-15 Thread Wei Liu
On Tue, Dec 08, 2020 at 07:30:09PM +, Paul Durrant wrote: > From: Paul Durrant > > The seemingly arbitrary use of 'pci' and 'pcidev' in the code in libxl_pci.c > is confusing and also compromises use of some macros used for other device > types. Indeed it seems that

Re: [PATCH] tools/xenstore: rework path length check

2020-12-15 Thread Wei Liu
On Tue, Dec 15, 2020 at 04:04:11PM +0100, Juergen Gross wrote: > The different fixed limits for absolute and relative path lengths of > Xenstore nodes make it possible to create per-domain nodes via > absolute paths which are not accessible using relative paths, as the > two limits differ by 1024

Re: [PATCH] examples: Add PVH example to config example list

2020-12-15 Thread Wei Liu
On Mon, Dec 14, 2020 at 06:35:32PM -0800, Elliott Mitchell wrote: > Somewhat helpful to actually install the example configurations. > > Signed-off-by: Elliott Mitchell Acked-by: Wei Liu

Re: [PATCH v2 4/4] block: Close block exports in two steps

2020-12-15 Thread Kevin Wolf
Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben: > There's a cross-dependency between closing the block exports and > draining the block layer. The latter needs that we close all export's > client connections to ensure they won't queue more requests, but the > exports may have coroutines

Re: [PATCH v2 00/12] x86: major paravirt cleanup

2020-12-15 Thread Jürgen Groß
On 15.12.20 15:54, Peter Zijlstra wrote: On Tue, Dec 15, 2020 at 03:18:34PM +0100, Peter Zijlstra wrote: Ah, I was waiting for Josh to have an opinion (and then sorta forgot about the whole thing again). Let me refresh and provide at least a Changelog. How's this then? Thanks, will add it

Re: [PATCH] tools/xenstore: rework path length check

2020-12-15 Thread Andrew Cooper
On 15/12/2020 15:04, Juergen Gross wrote: > The different fixed limits for absolute and relative path lengths of > Xenstore nodes make it possible to create per-domain nodes via > absolute paths which are not accessible using relative paths, as the > two limits differ by 1024 characters. > >

[PATCH] tools/xenstore: rework path length check

2020-12-15 Thread Juergen Gross
The different fixed limits for absolute and relative path lengths of Xenstore nodes make it possible to create per-domain nodes via absolute paths which are not accessible using relative paths, as the two limits differ by 1024 characters. Instead of this weird limits use only one limit, which

Re: [PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

2020-12-15 Thread Kevin Wolf
Am 15.12.2020 um 14:15 hat Sergio Lopez geschrieben: > On Tue, Dec 15, 2020 at 01:12:33PM +0100, Kevin Wolf wrote: > > Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben: > > > While processing the parents of a BDS, one of the parents may process > > > the child that's doing the tail recursion,

Re: [PATCH v2 00/12] x86: major paravirt cleanup

2020-12-15 Thread Peter Zijlstra
On Tue, Dec 15, 2020 at 03:18:34PM +0100, Peter Zijlstra wrote: > Ah, I was waiting for Josh to have an opinion (and then sorta forgot > about the whole thing again). Let me refresh and provide at least a > Changelog. How's this then? --- Subject: objtool: Alternatives vs ORC, the hard way From:

Re: [PATCH v4 23/32] qdev: Move dev->realized check to qdev_property_set()

2020-12-15 Thread Igor Mammedov
On Mon, 14 Dec 2020 12:24:18 -0500 Eduardo Habkost wrote: > On Mon, Dec 14, 2020 at 03:55:30PM +0100, Igor Mammedov wrote: > > On Fri, 11 Dec 2020 17:05:20 -0500 > > Eduardo Habkost wrote: > > > > > Every single qdev property setter function manually checks > > > dev->realized. We can just

  1   2   >