[xen-unstable test] 159453: tolerable FAIL - PUSHED

2021-02-18 Thread osstest service owner
flight 159453 xen-unstable real [real] flight 159473 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159453/ http://logs.test-lab.xenproject.org/osstest/logs/159473/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm6

[linux-5.4 bisection] complete test-armhf-armhf-libvirt

2021-02-18 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-armhf-armhf-libvirt testid guest-start Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tr

Re: [RFC] xen/arm: introduce XENFEAT_ARM_dom0_iommu

2021-02-18 Thread Stefano Stabellini
On Thu, 18 Feb 2021, Julien Grall wrote: > On 17/02/2021 23:54, Stefano Stabellini wrote: > > On Wed, 17 Feb 2021, Julien Grall wrote: > > > On 17/02/2021 02:00, Stefano Stabellini wrote: > > > > Hi all, > > > > > > > > Today Linux uses the swiotlb-xen driver (drivers/xen/swiotlb-xen.c) to > > > >

Re: [PATCH] firmware: don't build hvmloader if it is not needed

2021-02-18 Thread Stefano Stabellini
On Thu, 18 Feb 2021, Jan Beulich wrote: > On 18.02.2021 00:45, Stefano Stabellini wrote: > > Given this, I take there is no 32bit build env? A bit of Googling tells > > me that gcc on Alpine Linux is compiled without multilib support. > > > > > > That said I was looking at the Alpine Linux APKBUI

[xen-4.14-testing test] 159450: tolerable FAIL - PUSHED

2021-02-18 Thread osstest service owner
flight 159450 xen-4.14-testing real [real] flight 159467 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159450/ http://logs.test-lab.xenproject.org/osstest/logs/159467/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

[libvirt test] 159454: regressions - FAIL

2021-02-18 Thread osstest service owner
flight 159454 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/159454/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

[xen-4.13-testing test] 159448: tolerable FAIL - PUSHED

2021-02-18 Thread osstest service owner
flight 159448 xen-4.13-testing real [real] flight 159465 xen-4.13-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159448/ http://logs.test-lab.xenproject.org/osstest/logs/159465/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [for-4.15][PATCH v3 3/3] xen/iommu: x86: Harden the IOMMU page-table allocator

2021-02-18 Thread Julien Grall
On 18/02/2021 17:04, Jan Beulich wrote: On 18.02.2021 14:19, Julien Grall wrote: On 18/02/2021 13:10, Jan Beulich wrote: On 17.02.2021 17:29, Julien Grall wrote: On 17/02/2021 15:13, Jan Beulich wrote: On 17.02.2021 15:24, Julien Grall wrote:> --- a/xen/drivers/passthrough/x86/iommu.c> +

Re: [for-4.15][PATCH v3 3/3] xen/iommu: x86: Harden the IOMMU page-table allocator

2021-02-18 Thread Jan Beulich
On 18.02.2021 14:19, Julien Grall wrote: > > > On 18/02/2021 13:10, Jan Beulich wrote: >> On 17.02.2021 17:29, Julien Grall wrote: >>> On 17/02/2021 15:13, Jan Beulich wrote: On 17.02.2021 15:24, Julien Grall wrote:> --- a/xen/drivers/passthrough/x86/iommu.c> +++ b/xen/drivers/pa

Re: [PATCH v2] drm/gem: Move drm_gem_fb_prepare_fb() to GEM atomic helpers

2021-02-18 Thread Maxime Ripard
Hi, On Thu, Feb 11, 2021 at 09:16:36AM +0100, Thomas Zimmermann wrote: > diff --git a/include/drm/drm_gem_framebuffer_helper.h > b/include/drm/drm_gem_framebuffer_helper.h > index 6b013154911d..495d174d9989 100644 > --- a/include/drm/drm_gem_framebuffer_helper.h > +++ b/include/drm/drm_gem_frameb

Re: [PATCH v2 1/4] xl: Add support for ignore_msrs option

2021-02-18 Thread Jan Beulich
On 18.02.2021 16:52, Roger Pau Monné wrote: > On Thu, Feb 18, 2021 at 12:54:13PM +0100, Jan Beulich wrote: >> On 18.02.2021 11:42, Roger Pau Monné wrote: >>> Not that you need to implement the full thing now, but maybe we could >>> have something like: >>> >>> " >>> =item B >>> >>> Specify a list o

Re: [PATCH v2 3/4] x86: Allow non-faulting accesses to non-emulated MSRs if policy permits this

2021-02-18 Thread Roger Pau Monné
On Thu, Feb 18, 2021 at 12:57:13PM +0100, Jan Beulich wrote: > On 18.02.2021 12:24, Roger Pau Monné wrote: > > On Wed, Jan 20, 2021 at 05:49:11PM -0500, Boris Ostrovsky wrote: > >> --- a/xen/arch/x86/hvm/vmx/vmx.c > >> +++ b/xen/arch/x86/hvm/vmx/vmx.c > >> @@ -3017,8 +3017,8 @@ static int vmx_msr_r

Re: [PATCH v2 1/4] xl: Add support for ignore_msrs option

2021-02-18 Thread Roger Pau Monné
On Thu, Feb 18, 2021 at 12:54:13PM +0100, Jan Beulich wrote: > On 18.02.2021 11:42, Roger Pau Monné wrote: > > On Wed, Jan 20, 2021 at 05:49:09PM -0500, Boris Ostrovsky wrote: > >> This option allows guest administrator specify what should happen when > >> guest accesses an MSR which is not explici

[xen-unstable-smoke test] 159461: tolerable all pass - PUSHED

2021-02-18 Thread osstest service owner
flight 159461 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159461/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-armhf-armhf-xl 1

[linux-linus test] 159440: regressions - FAIL

2021-02-18 Thread osstest service owner
flight 159440 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/159440/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: [PATCH v2 7/7] tests/avocado: add boot_xen tests

2021-02-18 Thread Cleber Rosa
On Thu, Feb 18, 2021 at 10:43:54AM +0100, Philippe Mathieu-Daudé wrote: > On 2/17/21 9:46 PM, Cleber Rosa wrote: > > On Thu, Feb 11, 2021 at 05:19:45PM +, Alex Bennée wrote: > >> These tests make sure we can boot the Xen hypervisor with a Dom0 > >> kernel using the guest-loader. We currently ha

Re: [PATCH v2 7/7] tests/avocado: add boot_xen tests

2021-02-18 Thread Cleber Rosa
On Wed, Feb 17, 2021 at 10:22:50PM +, Alex Bennée wrote: > > I think the solution is to use archive links here. There is a snapshot > archive of sid (we've used it in the past) but I suspect there isn't an > archive of old stable packages for a reason. > If the packages you need are available

[PATCH HVM v4 1/1] hvm: refactor set param

2021-02-18 Thread Norbert Manthey
To prevent leaking HVM params via L1TF and similar issues on a hyperthread pair, let's load values of domains only after performing all relevant checks, and blocking speculative execution. For both get and set, the value of the index is already checked in the outer calling function. The block_spec

Re: [PATCH 3/3] gnttab: GTF_sub_page is a v2-only flag

2021-02-18 Thread Jan Beulich
On 18.02.2021 15:22, Andrew Cooper wrote: > On 17/02/2021 10:46, Jan Beulich wrote: >> Prior to its introduction, v1 entries weren't checked for this flag, and >> the flag also has been meaningless for v1 entries. Therefore it also >> shouldn't be checked. (The only consistent alternative would be

Re: ld 2.36 regression linking EFI binary from ELF input

2021-02-18 Thread Jan Beulich
On 04.02.2021 14:21, Jan Beulich via Binutils wrote: > the Xen project hypervisor build system includes building the > hypervisor binary as an EFI application, as an option (i.e. > as long as the tool chain supports this). Already when probing > the linker we now suddenly get several "relocation tr

[qemu-mainline test] 159434: regressions - FAIL

2021-02-18 Thread osstest service owner
flight 159434 qemu-mainline real [real] flight 159460 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/159434/ http://logs.test-lab.xenproject.org/osstest/logs/159460/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH 3/3] gnttab: GTF_sub_page is a v2-only flag

2021-02-18 Thread Andrew Cooper
On 17/02/2021 10:46, Jan Beulich wrote: > Prior to its introduction, v1 entries weren't checked for this flag, and > the flag also has been meaningless for v1 entries. Therefore it also > shouldn't be checked. (The only consistent alternative would be to also > check for all currently undefined fla

Re: [for-4.15][PATCH v3 2/3] xen/x86: iommu: Ignore IOMMU mapping requests when a domain is dying

2021-02-18 Thread Paul Durrant
On 18/02/2021 13:05, Jan Beulich wrote: On 17.02.2021 17:07, Julien Grall wrote: On 17/02/2021 15:01, Jan Beulich wrote: On 17.02.2021 15:24, Julien Grall wrote: From: Julien Grall The new x86 IOMMU page-tables allocator will release the pages when relinquishing the domain resources. However

Re: [for-4.15][PATCH v3 2/3] xen/x86: iommu: Ignore IOMMU mapping requests when a domain is dying

2021-02-18 Thread Julien Grall
Hi, On 18/02/2021 13:05, Jan Beulich wrote: On 17.02.2021 17:07, Julien Grall wrote: On 17/02/2021 15:01, Jan Beulich wrote: On 17.02.2021 15:24, Julien Grall wrote: From: Julien Grall The new x86 IOMMU page-tables allocator will release the pages when relinquishing the domain resources. Ho

Re: [for-4.15][PATCH v3 3/3] xen/iommu: x86: Harden the IOMMU page-table allocator

2021-02-18 Thread Julien Grall
On 18/02/2021 13:10, Jan Beulich wrote: On 17.02.2021 17:29, Julien Grall wrote: On 17/02/2021 15:13, Jan Beulich wrote: On 17.02.2021 15:24, Julien Grall wrote:> --- a/xen/drivers/passthrough/x86/iommu.c> +++ b/xen/drivers/passthrough/x86/iommu.c> @@ -149,6 +149,13 @@ int arch_iommu_domain

Re: [for-4.15][PATCH v3 3/3] xen/iommu: x86: Harden the IOMMU page-table allocator

2021-02-18 Thread Jan Beulich
On 17.02.2021 17:29, Julien Grall wrote: > On 17/02/2021 15:13, Jan Beulich wrote: >> On 17.02.2021 15:24, Julien Grall wrote:> --- >> a/xen/drivers/passthrough/x86/iommu.c> +++ >> b/xen/drivers/passthrough/x86/iommu.c> @@ -149,6 +149,13 @@ int >> arch_iommu_domain_init(struct domain *d)> > vo

Re: [for-4.15][PATCH v3 2/3] xen/x86: iommu: Ignore IOMMU mapping requests when a domain is dying

2021-02-18 Thread Jan Beulich
On 17.02.2021 17:07, Julien Grall wrote: > On 17/02/2021 15:01, Jan Beulich wrote: >> On 17.02.2021 15:24, Julien Grall wrote: >>> From: Julien Grall >>> >>> The new x86 IOMMU page-tables allocator will release the pages when >>> relinquishing the domain resources. However, this is not sufficient

Re: [PATCH v2 3/4] x86: Allow non-faulting accesses to non-emulated MSRs if policy permits this

2021-02-18 Thread Jan Beulich
On 18.02.2021 12:24, Roger Pau Monné wrote: > On Wed, Jan 20, 2021 at 05:49:11PM -0500, Boris Ostrovsky wrote: >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/vmx/vmx.c >> @@ -3017,8 +3017,8 @@ static int vmx_msr_read_intercept(unsigned int msr, >> uint64_t *msr_content) >>

Re: [PATCH v2 1/4] xl: Add support for ignore_msrs option

2021-02-18 Thread Jan Beulich
On 18.02.2021 11:42, Roger Pau Monné wrote: > On Wed, Jan 20, 2021 at 05:49:09PM -0500, Boris Ostrovsky wrote: >> This option allows guest administrator specify what should happen when >> guest accesses an MSR which is not explicitly emulated by the hypervisor. >> >> Signed-off-by: Boris Ostrovsky

Re: [PATCH v2 4/4] tools/libs: Apply MSR policy to a guest

2021-02-18 Thread Roger Pau Monné
On Wed, Jan 20, 2021 at 05:49:12PM -0500, Boris Ostrovsky wrote: > When creating a guest, if ignore_msrs option has been specified, > apply it to guest's MSR policy. > > Signed-off-by: Boris Ostrovsky > --- > tools/include/xenctrl.h | 2 + > tools/libs/guest/Makefile | 1 +

Xen Security Advisory 366 v1 - missed flush in XSA-321 backport

2021-02-18 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory XSA-366 missed flush in XSA-321 backport ISSUE DESCRIPTION = An oversight was made when backporting XSA-320, leading entries in the IOMMU not being properly updated under

Re: [PATCH v2 3/8] xen/events: avoid handling the same event on two cpus at the same time

2021-02-18 Thread Jürgen Groß
On 15.02.21 22:35, Boris Ostrovsky wrote: On 2/11/21 5:16 AM, Juergen Gross wrote: @@ -622,6 +623,7 @@ static void xen_irq_lateeoi_locked(struct irq_info *info, bool spurious) } info->eoi_time = 0; + smp_store_release(&info->is_active, 0); Can this be done in lateeoi_a

Re: [PATCH v2 8/8] xen/evtchn: use READ/WRITE_ONCE() for accessing ring indices

2021-02-18 Thread Jürgen Groß
On 17.02.21 14:29, Ross Lagerwall wrote: On 2021-02-11 10:16, Juergen Gross wrote: For avoiding read- and write-tearing by the compiler use READ_ONCE() and WRITE_ONCE() for accessing the ring indices in evtchn.c. Signed-off-by: Juergen Gross --- V2: - modify all accesses (Julien Grall) --- d

Re: [PATCH] firmware: don't build hvmloader if it is not needed

2021-02-18 Thread Jan Beulich
On 18.02.2021 00:45, Stefano Stabellini wrote: > Given this, I take there is no 32bit build env? A bit of Googling tells > me that gcc on Alpine Linux is compiled without multilib support. > > > That said I was looking at the Alpine Linux APKBUILD script: > https://gitlab.alpinelinux.org/alpine/a

Re: [PATCH 1/3] gnttab: never permit mapping transitive grants

2021-02-18 Thread Jan Beulich
On 18.02.2021 11:25, Julien Grall wrote: > On 17/02/2021 10:46, Jan Beulich wrote: >> Transitive grants allow an intermediate domain I to grant a target >> domain T access to a page which origin domain O did grant I access to. >> As an implementation restriction, T is not allowed to map such a gran

Re: [PATCH v2 3/4] x86: Allow non-faulting accesses to non-emulated MSRs if policy permits this

2021-02-18 Thread Roger Pau Monné
On Wed, Jan 20, 2021 at 05:49:11PM -0500, Boris Ostrovsky wrote: > Starting with commit 84e848fd7a16 ("x86/hvm: disallow access to unknown MSRs") > accesses to unhandled MSRs result in #GP sent to the guest. This caused a > regression for Solaris who tries to acccess MSR_RAPL_POWER_UNIT and (unlike

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-18 Thread Roger Pau Monné
On Wed, Jan 20, 2021 at 05:49:10PM -0500, Boris Ostrovsky wrote: > When toolstack updates MSR policy, this MSR offset (which is the last > index in the hypervisor MSR range) is used to indicate hypervisor > behavior when guest accesses an MSR which is not explicitly emulated. It's kind of weird to

Re: [PATCH v2 1/4] xl: Add support for ignore_msrs option

2021-02-18 Thread Roger Pau Monné
On Wed, Jan 20, 2021 at 05:49:09PM -0500, Boris Ostrovsky wrote: > This option allows guest administrator specify what should happen when > guest accesses an MSR which is not explicitly emulated by the hypervisor. > > Signed-off-by: Boris Ostrovsky > --- > docs/man/xl.cfg.5.pod.in | 20 +

Re: [RFC] xen/arm: introduce XENFEAT_ARM_dom0_iommu

2021-02-18 Thread Julien Grall
Hi Stefano, On 17/02/2021 23:54, Stefano Stabellini wrote: On Wed, 17 Feb 2021, Julien Grall wrote: On 17/02/2021 02:00, Stefano Stabellini wrote: I saw that the topic has generated quite a bit of discussion. I suggest we keep gathering data and do brainstorming on the thread for a few days a

Re: [PATCH 1/3] gnttab: never permit mapping transitive grants

2021-02-18 Thread Julien Grall
Hi Jan, On 17/02/2021 10:46, Jan Beulich wrote: Transitive grants allow an intermediate domain I to grant a target domain T access to a page which origin domain O did grant I access to. As an implementation restriction, T is not allowed to map such a grant. This restriction is currently tried to

Re: oxenstored restart after system crash

2021-02-18 Thread Edwin Torok
Hi, oxenstored doesn't have a tdb file, by default it stores the entire tree in memory only. There is a way to persistently store the tree (--persistent), but that is not enabled by default and I don't know whether it even works. Master (or the hotfixed releases) have a live-update functionalit

Re: [RFC] xen/arm: introduce XENFEAT_ARM_dom0_iommu

2021-02-18 Thread Julien Grall
Hi Stefano, On 17/02/2021 23:54, Stefano Stabellini wrote: On Wed, 17 Feb 2021, Julien Grall wrote: On 17/02/2021 02:00, Stefano Stabellini wrote: Hi all, Today Linux uses the swiotlb-xen driver (drivers/xen/swiotlb-xen.c) to translate addresses for DMA operations in Dom0. Specifically, swiot

oxenstored restart after system crash

2021-02-18 Thread Roger Pau Monné
Hello, Last month I got a query from a FreeBSD Xen user having issues with xenstored after a power failure: https://lists.freebsd.org/pipermail/freebsd-xen/2021-January/003446.html I'm not sure what's the right approach here. I've been told cxenstored will attempt to unlink the tdb file when sta

Re: [PATCH v2 7/7] tests/avocado: add boot_xen tests

2021-02-18 Thread Philippe Mathieu-Daudé
On 2/17/21 9:46 PM, Cleber Rosa wrote: > On Thu, Feb 11, 2021 at 05:19:45PM +, Alex Bennée wrote: >> These tests make sure we can boot the Xen hypervisor with a Dom0 >> kernel using the guest-loader. We currently have to use a kernel I >> built myself because there are issues using the Debian k

Re: Linux DomU freezes and dies under heavy memory shuffling

2021-02-18 Thread Jürgen Groß
On 18.02.21 06:21, Roman Shaposhnik wrote: On Wed, Feb 17, 2021 at 12:29 AM Jürgen Groß > wrote: On 17.02.21 09:12, Roman Shaposhnik wrote: > Hi Jürgen, thanks for taking a look at this. A few comments below: > > On Tue, Feb 16, 2021 at 10:47 PM Jürgen

HEADS UP: FreeBSD/Xen dom0 UEFI support

2021-02-18 Thread Roger Pau Monné
Hello, Since commit 97527e9c4fd37140 on main branch FreeBSD should be able to boot and work as a Xen dom0 from UEFI. Booting from UEFI also requires the usage of xen-kernel 4.14.1_1, previous versions of xen-kernel won't boot correctly under UEFI. The way to setup the system is exactly the same

[linux-5.4 test] 159431: regressions - FAIL

2021-02-18 Thread osstest service owner
flight 159431 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/159431/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 158387 test-arm64-arm64-xl-c

Re: [PATCH v5 4/8] x86/mm/tlb: Flush remote and local TLBs concurrently

2021-02-18 Thread Christoph Hellwig
Given that the last patch killed the last previously existing user of on_each_cpu_cond_mask there are now the only users. > if (info->freed_tables) { > - smp_call_function_many(cpumask, flush_tlb_func, > -(void *)info, 1); > + on_each_cpu_c