[linux-linus test] 161817: regressions - FAIL

2021-05-06 Thread osstest service owner
flight 161817 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/161817/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332

RE: Discussion of Xenheap problems on AArch64

2021-05-06 Thread Henry Wang
Hi Julien, > From: Julien Grall > On 28/04/2021 10:28, Henry Wang wrote: > > Hi Julien, > > Hi Henry, > > > > > I've done some test about the patch series in > > https://xenbits.xen.org/gitweb/?p=people/julieng/xen- > unstable.git;a=shortlog;h=refs/heads/pt/rfc-v2 > > > > Thanks you for the

[qemu-mainline test] 161812: regressions - FAIL

2021-05-06 Thread osstest service owner
flight 161812 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/161812/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631

[PATCH] optee: enable OPTEE_SMC_SEC_CAP_MEMREF_NULL capability

2021-05-06 Thread Volodymyr Babchuk
OP-TEE mediator already have support for NULL memory references. It was added in patch 0dbed3ad336 ("optee: allow plain TMEM buffers with NULL address"). But it does not propagate OPTEE_SMC_SEC_CAP_MEMREF_NULL capability flag to a guest, so well behaving guest can't use this feature. Note: linux

[xen-unstable test] 161811: tolerable FAIL - PUSHED

2021-05-06 Thread osstest service owner
flight 161811 xen-unstable real [real] flight 161822 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/161811/ http://logs.test-lab.xenproject.org/osstest/logs/161822/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

[xen-4.12-testing test] 161807: regressions - FAIL

2021-05-06 Thread osstest service owner
flight 161807 xen-4.12-testing real [real] flight 161819 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/161807/ http://logs.test-lab.xenproject.org/osstest/logs/161819/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

[xtf test] 161814: all pass - PUSHED

2021-05-06 Thread osstest service owner
flight 161814 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/161814/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf 880092854e5473558af77289bb7c01a9fa9dda5a baseline version: xtf

Re: [PATCH] Xen Keyboard: don't advertise every key known to man

2021-05-06 Thread Dmitry Torokhov
On Thu, May 06, 2021 at 02:36:54PM +, Phillip Susi wrote: > For reasons I still don't understand, the input subsystem allows > input devices to advertise what keys they have, and adds this > information to the modalias for the device. The Xen Virtual > Keyboard was advertising every known

[linux-linus test] 161799: regressions - FAIL

2021-05-06 Thread osstest service owner
flight 161799 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/161799/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332

[qemu-mainline bisection] complete test-amd64-amd64-xl-qemuu-ws16-amd64

2021-05-06 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-qemuu-ws16-amd64 testid guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu

Re: [PATCH v2] tools: fix incorrect suggestions for XENCONSOLED_TRACE on BSD

2021-05-06 Thread Andrew Cooper
On 06/05/2021 16:17, Olaf Hering wrote: > --log does not take a file, it specifies what is supposed to be logged. > > Also separate the XENSTORED and XENCONSOLED variables by a newline. > > Signed-off-by: Olaf Hering Acked-by: Andrew Cooper

Re: [PATCH v2] tools: remove unused sysconfig variable XENSTORED_ROOTDIR

2021-05-06 Thread Andrew Cooper
On 06/05/2021 16:16, Olaf Hering wrote: > The sysconfig variable XENSTORED_ROOTDIR is not used anymore. > It used to point to a directory with tdb files, which is now a tmpfs. > > In case the database is not in tmpfs, like on sysv and BSD systems, > xenstored will truncate existing database files

Re: [xen-4.12-testing test] 161776: regressions - FAIL

2021-05-06 Thread Ian Jackson
osstest service owner writes ("[xen-4.12-testing test] 161776: regressions - FAIL"): > flight 161776 xen-4.12-testing real [real] > flight 161806 xen-4.12-testing real-retest [real] > http://logs.test-lab.xenproject.org/osstest/logs/161776/ >

[PATCH] tools/xenstored: Prevent a buffer overflow in dump_state_node_perms()

2021-05-06 Thread Julien Grall
From: Julien Grall ASAN reported one issue when Live Updating Xenstored: = ==873==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffc194f53e0 at pc 0x555c6b323292 bp 0x7ffc194f5340 sp 0x7ffc194f5338 WRITE of size 1 at

[PATCH v2] tools: fix incorrect suggestions for XENCONSOLED_TRACE on BSD

2021-05-06 Thread Olaf Hering
--log does not take a file, it specifies what is supposed to be logged. Also separate the XENSTORED and XENCONSOLED variables by a newline. Signed-off-by: Olaf Hering --- tools/hotplug/FreeBSD/rc.d/xencommons.in | 5 +++-- tools/hotplug/NetBSD/rc.d/xencommons.in | 5 +++-- 2 files changed, 6

[PATCH v2] tools: remove unused sysconfig variable XENSTORED_ROOTDIR

2021-05-06 Thread Olaf Hering
The sysconfig variable XENSTORED_ROOTDIR is not used anymore. It used to point to a directory with tdb files, which is now a tmpfs. In case the database is not in tmpfs, like on sysv and BSD systems, xenstored will truncate existing database files during start. Fixes commit

Re: [PATCH v5 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-05-06 Thread Jan Beulich
On 06.05.2021 16:43, Luca Fancellu wrote: >> On 6 May 2021, at 10:58, Jan Beulich wrote: >> On 06.05.2021 10:48, Luca Fancellu wrote: On 4 May 2021, at 23:27, Stefano Stabellini wrote: On Tue, 4 May 2021, Luca Fancellu wrote: > @@ -51,13 +55,10 @@ > * know the real machine

Re: [PATCH v5 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-05-06 Thread Luca Fancellu
> On 6 May 2021, at 10:58, Jan Beulich wrote: > > On 06.05.2021 10:48, Luca Fancellu wrote: >>> On 4 May 2021, at 23:27, Stefano Stabellini wrote: >>> On Tue, 4 May 2021, Luca Fancellu wrote: @@ -51,13 +55,10 @@ * know the real machine address of a page it is sharing. This makes

Re: [PATCH RFC 1/2] docs/design: Add a design document for Live Update

2021-05-06 Thread Paul Durrant
On 06/05/2021 11:42, Julien Grall wrote: From: Julien Grall Looks good in general... just a few comments below... Administrators often require updating the Xen hypervisor to address security vulnerabilities, introduce new features, or fix software defects. Currently, we offer the following

[PATCH] Xen Keyboard: don't advertise every key known to man

2021-05-06 Thread Phillip Susi
For reasons I still don't understand, the input subsystem allows input devices to advertise what keys they have, and adds this information to the modalias for the device. The Xen Virtual Keyboard was advertising every known key, which resulted in a modalias string over 2 KiB in length, which

Re: [PATCH v1] tools: fix incorrect suggestions for XENCONSOLED_TRACE on FreeBSD

2021-05-06 Thread Olaf Hering
Am Tue, 4 May 2021 18:47:12 +0100 schrieb Andrew Cooper : > I'd also be tempted to fold this and the NetBSD change together.  It's > not as if these bugfixes are distro-specific. I will redo the BSD patches as you suggested. Olaf pgpl9o7VzEidt.pgp Description: Digitale Signatur von OpenPGP

Re: [PATCH v2] SUPPORT.md: Un-shimmed 32-bit PV guests are no longer supported

2021-05-06 Thread Andrew Cooper
On 06/05/2021 14:09, Jan Beulich wrote: > On 06.05.2021 14:47, George Dunlap wrote: >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -55,7 +55,7 @@ config PV >> config PV32 >> bool "Support for 32bit PV guests" >> depends on PV >> -default y >> +default PV_SHIM

[PATCH v2 12/13] vtpmmgr: Check req_len before unpacking command

2021-05-06 Thread Jason Andryuk
vtpm_handle_cmd doesn't ensure there is enough space before unpacking the req buffer. Add a minimum size check. Called functions will have to do their own checking if they need more data from the request. The error case is tricky since abort_egress wants to rely with a corresponding tag. Just

[PATCH v2 11/13] vtpmmgr: Fix owner_auth & srk_auth parsing

2021-05-06 Thread Jason Andryuk
Argument parsing only matches to before ':' and then the string with leading ':' is passed to parse_auth_string which fails to parse. Extend the length to include the seperator in the match. While here, switch the seperator to "=". The man page documented "=" and the other tpm.* arguments

[PATCH v2 13/13] vtpm: Correct timeout units and command duration

2021-05-06 Thread Jason Andryuk
Add two patches: vtpm-microsecond-duration.patch fixes the units for timeouts and command durations. vtpm-command-duration.patch increases the timeout linux uses to allow commands to succeed. Linux works around low timeouts, but not low durations. The second patch allows commands to complete

[PATCH v2 10/13] vtpmmgr: Remove bogus cast from TPM2_GetRandom

2021-05-06 Thread Jason Andryuk
The UINT32 <-> UINT16 casting in TPM2_GetRandom is incorrect. Use a local UINT16 as needed for the TPM hardware command and assign the result. Suggested-by: Samuel Thibault Signed-off-by: Jason Andryuk --- stubdom/vtpmmgr/tpm2.c | 13 ++--- 1 file changed, 10 insertions(+), 3

Re: [PATCH v2 08/13] vtpmmgr: Shutdown more gracefully

2021-05-06 Thread Jason Andryuk
On Thu, May 6, 2021 at 10:00 AM Jason Andryuk wrote: > > vtpmmgr uses the default, weak app_shutdown, which immediately calls the > shutdown hypercall. This short circuits the vtpmmgr clean up logic. We > need to perform the clean up to actually Flush our key out of the tpm. > > Setting

[PATCH v2 09/13] vtpmmgr: Support GetRandom passthrough on TPM 2.0

2021-05-06 Thread Jason Andryuk
GetRandom passthrough currently fails when using vtpmmgr with a hardware TPM 2.0. vtpmmgr (8): INFO[VTPM]: Passthrough: TPM_GetRandom vtpm (12): vtpm_cmd.c:120: Error: TPM_GetRandom() failed with error code (30) When running on TPM 2.0 hardware, vtpmmgr needs to convert the TPM 1.2

[PATCH v2 08/13] vtpmmgr: Shutdown more gracefully

2021-05-06 Thread Jason Andryuk
vtpmmgr uses the default, weak app_shutdown, which immediately calls the shutdown hypercall. This short circuits the vtpmmgr clean up logic. We need to perform the clean up to actually Flush our key out of the tpm. Setting do_shutdown is one step in that direction, but vtpmmgr will most likely

[PATCH v2 07/13] vtpmmgr: Flush all transient keys

2021-05-06 Thread Jason Andryuk
We're only flushing 2 transients, but there are 3 handles. Use <= to also flush the third handle since TRANSIENT_LAST is inclusive The number of transient handles/keys is hardware dependent, so this should query for the limit. And assignment of handles is assumed to be sequential from the

[PATCH v2 06/13] vtpmmgr: Flush transient keys on shutdown

2021-05-06 Thread Jason Andryuk
Remove our key so it isn't left in the TPM for someone to come along after vtpmmgr shutsdown. Signed-off-by: Jason Andryuk Reviewed-by: Samuel Thibault --- stubdom/vtpmmgr/init.c | 8 1 file changed, 8 insertions(+) diff --git a/stubdom/vtpmmgr/init.c b/stubdom/vtpmmgr/init.c index

[PATCH v2 05/13] vtpmmgr: Move vtpmmgr_shutdown

2021-05-06 Thread Jason Andryuk
Reposition vtpmmgr_shutdown so it can call flush_tpm2 without a forward declaration. Signed-off-by: Jason Andryuk Reviewed-by: Samuel Thibault --- stubdom/vtpmmgr/init.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/stubdom/vtpmmgr/init.c

[PATCH v2 04/13] vtpmmgr: Allow specifying srk_handle for TPM2

2021-05-06 Thread Jason Andryuk
Bypass taking ownership of the TPM2 if an srk_handle is specified. This srk_handle must be usable with Null auth for the time being. Signed-off-by: Jason Andryuk --- v2: Use "=" seperator --- docs/man/xen-vtpmmgr.7.pod | 7 +++ stubdom/vtpmmgr/init.c | 11 ++- 2 files changed,

[PATCH v2 03/13] stubom: newlib: Enable C99 formats for %z

2021-05-06 Thread Jason Andryuk
vtpmmgr was changed to print size_t with the %z modifier, but newlib isn't compiled with %z support. So you get output like: root seal: zu; sector of 13: zu root: zu v=zu itree: 36; sector of 112: zu group: zu v=zu id=zu md=zu group seal: zu; 5 in parent: zu; sector of 13: zu vtpm: zu+zu; sector

[PATCH v2 02/13] vtpmmgr: Print error code to aid debugging

2021-05-06 Thread Jason Andryuk
tpm_get_error_name returns "Unknown Error Code" when an error string is not defined. In that case, we should print the Error Code so it can be looked up offline. tpm_get_error_name returns a const string, so just have the two callers always print the error code so it is always available.

[PATCH v2 01/13] docs: Warn about incomplete vtpmmgr TPM 2.0 support

2021-05-06 Thread Jason Andryuk
The vtpmmgr TPM 2.0 support is incomplete. Add a warning about that to the documentation so others don't have to work through discovering it is broken. Signed-off-by: Jason Andryuk Acked-by: Andrew Cooper --- docs/man/xen-vtpmmgr.7.pod | 11 +++ 1 file changed, 11 insertions(+) diff

[PATCH v2 00/13] vtpmmgr: Some fixes - still incomplete

2021-05-06 Thread Jason Andryuk
vtpmmgr TPM 2.0 support is incomplete. There is no code to save the tpm2 keys generated by the vtpmmgr, so it's impossible to restore vtpm state with tpm2. The vtpmmgr also issues TPM 1.2 commands to the TPM 2.0 hardware which naturally fails. Dag reported this [1][2], and I independently

Re: [PATCH v2] SUPPORT.md: Un-shimmed 32-bit PV guests are no longer supported

2021-05-06 Thread Jan Beulich
On 06.05.2021 14:47, George Dunlap wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -55,7 +55,7 @@ config PV > config PV32 > bool "Support for 32bit PV guests" > depends on PV > - default y > + default PV_SHIM > select COMPAT > ---help--- >

Re: [PATCH v4 3/3] unzstd: make helper symbols static

2021-05-06 Thread Julien Grall
Hi Jan, On 06/05/2021 07:21, Jan Beulich wrote: On 05.05.2021 19:35, Julien Grall wrote: On 29/04/2021 14:26, Jan Beulich wrote: On 29.04.2021 13:27, Julien Grall wrote: On 21/04/2021 11:22, Jan Beulich wrote: While for the original library's purposes these functions of course want to be

[PATCH v2] SUPPORT.md: Un-shimmed 32-bit PV guests are no longer supported

2021-05-06 Thread George Dunlap
The support status of 32-bit guests doesn't seem particularly useful. With it changed to fully unsupported outside of PV-shim, adjust the PV32 Kconfig default accordingly. Reported-by: Jann Horn Signed-off-by: George Dunlap Signed-off-by: Jan Beulich --- v2: - add in Kconfig from advisory,

Re: [PATCH] SUPPORT.md: Un-shimmed 32-bit PV guests are no longer supported

2021-05-06 Thread George Dunlap
> On May 6, 2021, at 1:29 PM, George Dunlap wrote: > > The support status of 32-bit guests doesn't seem particularly useful. > > Signed-off-by: George Dunlap > --- > > NB this patch should be considered a proposal to the community, as a > follow-on to XSA-370. As mentioned in the

[qemu-mainline test] 161780: regressions - FAIL

2021-05-06 Thread osstest service owner
flight 161780 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/161780/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631

[PATCH] SUPPORT.md: Un-shimmed 32-bit PV guests are no longer supported

2021-05-06 Thread George Dunlap
The support status of 32-bit guests doesn't seem particularly useful. Signed-off-by: George Dunlap --- NB this patch should be considered a proposal to the community, as a follow-on to XSA-370. As mentioned in the advisory, we will wait until 25 May for comments before checking it in. ---

[xen-unstable test] 161778: tolerable FAIL - PUSHED

2021-05-06 Thread osstest service owner
flight 161778 xen-unstable real [real] flight 161809 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/161778/ http://logs.test-lab.xenproject.org/osstest/logs/161809/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH v3 08/13] libs/guest: make a cpu policy compatible with older Xen versions

2021-05-06 Thread Jan Beulich
On 06.05.2021 12:23, Roger Pau Monné wrote: > On Wed, May 05, 2021 at 09:42:09AM +0200, Jan Beulich wrote: >> On 04.05.2021 17:34, Roger Pau Monné wrote: >>> On Mon, May 03, 2021 at 01:09:41PM +0200, Jan Beulich wrote: On 30.04.2021 17:52, Roger Pau Monne wrote: > @@ -1086,3 +1075,42 @@

[PATCH RFC 1/2] docs/design: Add a design document for Live Update

2021-05-06 Thread Julien Grall
From: Julien Grall Administrators often require updating the Xen hypervisor to address security vulnerabilities, introduce new features, or fix software defects. Currently, we offer the following methods to perform the update: * Rebooting the guests and the host: this is highly disrupting

[PATCH RFC 0/2] Add a design document for Live Updating Xen

2021-05-06 Thread Julien Grall
From: Julien Grall Hi all, A couple of years ago, AWS presented at Xen Summit [1] a new method called "Live Update" to replace the underlying the hypervisor without rebooting/migrating VMs. Since then we worked on implementing the feature in Xen and now have a working PoC. This series is a

[PATCH RFC 2/2] xen/kexec: Reserve KEXEC_TYPE_LIVEUPDATE and KEXEC_RANGE_MA_LIVEUPDATE

2021-05-06 Thread Julien Grall
From: Julien Grall Unfortunately, the code to support Live Update has already been merged in Kexec and shipped since 2.0.21. Reserve the IDs used by Kexec before they end up to be re-used for a different purpose. This patch reserves two IDs: * KEXEC_TYPE_LIVEUPDATE: New operation to request

Re: [PATCH v3 08/13] libs/guest: make a cpu policy compatible with older Xen versions

2021-05-06 Thread Roger Pau Monné
On Wed, May 05, 2021 at 09:42:09AM +0200, Jan Beulich wrote: > On 04.05.2021 17:34, Roger Pau Monné wrote: > > On Mon, May 03, 2021 at 01:09:41PM +0200, Jan Beulich wrote: > >> On 30.04.2021 17:52, Roger Pau Monne wrote: > >>> @@ -1086,3 +1075,42 @@ int xc_cpu_policy_calc_compatible(xc_interface

Re: [PATCH v5 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-05-06 Thread Jan Beulich
On 06.05.2021 10:48, Luca Fancellu wrote: >> On 4 May 2021, at 23:27, Stefano Stabellini wrote: >> On Tue, 4 May 2021, Luca Fancellu wrote: >>> @@ -51,13 +55,10 @@ >>> * know the real machine address of a page it is sharing. This makes >>> * it possible to share memory correctly with domains

[PATCH v2] tools/libs: move cpu policy related prototypes to xenguest.h

2021-05-06 Thread Roger Pau Monne
Do this before adding any more stuff to xg_cpuid_x86.c. The placement in xenctrl.h is wrong, as they are implemented by the xenguest library. Note that xg_cpuid_x86.c needs to include xg_private.h, and in turn also fix xg_private.h to include xc_bitops.h. The bitops definition of BITS_PER_LONG

Re: [PATCH v5 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-05-06 Thread Luca Fancellu
> On 4 May 2021, at 23:27, Stefano Stabellini wrote: > > On Tue, 4 May 2021, Luca Fancellu wrote: >> Modification to include/public/grant_table.h: >> >> 1) Add doxygen tags to: >> - Create Grant tables section >> - include variables in the generated documentation >> - Used

[xen-4.12-testing test] 161776: regressions - FAIL

2021-05-06 Thread osstest service owner
flight 161776 xen-4.12-testing real [real] flight 161806 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/161776/ http://logs.test-lab.xenproject.org/osstest/logs/161806/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

[libvirt test] 161804: regressions - FAIL

2021-05-06 Thread osstest service owner
flight 161804 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/161804/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-armhf-libvirt

Re: [PATCH v4 3/3] unzstd: make helper symbols static

2021-05-06 Thread Jan Beulich
On 05.05.2021 19:35, Julien Grall wrote: > > > On 29/04/2021 14:26, Jan Beulich wrote: >> On 29.04.2021 13:27, Julien Grall wrote: >>> On 21/04/2021 11:22, Jan Beulich wrote: While for the original library's purposes these functions of course want to be externally exposed, we don't

Re: [PATCH 5/5] x86/cpuid: Fix handling of xsave dynamic leaves

2021-05-06 Thread Jan Beulich
On 05.05.2021 18:59, Andrew Cooper wrote: > On 05/05/2021 09:33, Jan Beulich wrote: >> On 04.05.2021 16:17, Andrew Cooper wrote: >>> On 04/05/2021 13:56, Jan Beulich wrote: On 03.05.2021 17:39, Andrew Cooper wrote: > +unsigned int xstate_compressed_size(uint64_t xstates) > +{ > +

Re: [PATCH v3 02/10] arm/domain: Get rid of READ/WRITE_SYSREG32

2021-05-06 Thread Michal Orzel
Hi Julien, On 05.05.2021 20:03, Julien Grall wrote: > Hi Michal, > > On 05/05/2021 08:43, Michal Orzel wrote: >> AArch64 registers are 64bit whereas AArch32 registers >> are 32bit or 64bit. MSR/MRS are expecting 64bit values thus >> we should get rid of helpers READ/WRITE_SYSREG32 >> in favour