[libvirt test] 166305: regressions - FAIL

2021-11-22 Thread osstest service owner
flight 166305 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/166305/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH 1/2] rangeset: add RANGESETF_no_print flag

2021-11-22 Thread Oleksandr Andrushchenko
On 23.11.21 09:38, Jan Beulich wrote: > On 22.11.2021 10:28, Oleksandr Andrushchenko wrote: >> --- a/xen/include/xen/rangeset.h >> +++ b/xen/include/xen/rangeset.h >> @@ -51,6 +51,9 @@ void rangeset_limit( >>/* Pretty-print range limits in hexadecimal. */ >> #define

Re: [PATCH 1/2] rangeset: add RANGESETF_no_print flag

2021-11-22 Thread Jan Beulich
On 22.11.2021 10:28, Oleksandr Andrushchenko wrote: > --- a/xen/include/xen/rangeset.h > +++ b/xen/include/xen/rangeset.h > @@ -51,6 +51,9 @@ void rangeset_limit( > /* Pretty-print range limits in hexadecimal. */ > #define _RANGESETF_prettyprint_hex 0 > #define RANGESETF_prettyprint_hex (1U

Re: [PATCH v6 5/7] xen/arm: do not map IRQs and memory for disabled devices

2021-11-22 Thread Oleksandr Andrushchenko
Hi, Julien! On 22.11.21 21:31, Julien Grall wrote: > Hi Oleksandr, > > On 18/11/2021 06:59, Oleksandr Andrushchenko wrote: >> Hi, Julien! >> >> On 16.11.21 21:22, Julien Grall wrote: >>> Hi Oleksandr, >>> >>> On 05/11/2021 06:33, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko

Re: [PATCH v6 3/7] xen/arm: setup MMIO range trap handlers for hardware domain

2021-11-22 Thread Oleksandr Andrushchenko
Hi, Julien! On 22.11.21 19:36, Julien Grall wrote: > Hi, > > On 18/11/2021 10:46, Oleksandr Andrushchenko wrote: >> On 18.11.21 09:27, Oleksandr Andrushchenko wrote: >>> Hi, Julien! >>> >>> On 16.11.21 21:12, Julien Grall wrote: Hi Oleksandr, On 05/11/2021 06:33, Oleksandr

Re: [PATCH v6 2/7] xen/arm: add pci-domain for disabled devices

2021-11-22 Thread Oleksandr Andrushchenko
On 22.11.21 19:17, Julien Grall wrote: > Hi, > > On 22/11/2021 16:23, Oleksandr Andrushchenko wrote: >> On 22.11.21 17:29, Julien Grall wrote: >>> I would prefer to go with my way. This can be refined in the future if we >>> find Device-Tree that matches what you wrote. >> Ok, so just to make

Re: [PATCH v3] xen: detect uninitialized xenbus in xenbus_init

2021-11-22 Thread Juergen Gross
On 22.11.21 23:16, Stefano Stabellini wrote: From: Stefano Stabellini If the xenstore page hasn't been allocated properly, reading the value of the related hvm_param (HVM_PARAM_STORE_PFN) won't actually return error. Instead, it will succeed and return zero. Instead of attempting to xen_remap

Re: [RFC PATCH] Added the logic to decode 32 bit ldr/str post-indexing instructions

2021-11-22 Thread Stefano Stabellini
On Mon, 22 Nov 2021, Julien Grall wrote: > On Mon, 22 Nov 2021 at 19:59, Stefano Stabellini > wrote: > > > > On Mon, 22 Nov 2021, Ayan Kumar Halder wrote: > > > Stefano > It doesn't look like we are setting dabt->write anywhere. > > > > > > Ayan > Yes, this is a miss. Depending on the opc, this

Re: ACPI/UEFI support for Xen/ARM status?

2021-11-22 Thread Elliott Mitchell
On Tue, Nov 16, 2021 at 08:18:26AM +0100, Jan Beulich wrote: > On 15.11.2021 20:09, Julien Grall wrote: > > > > However, for Elliott's case, I am not sure this is going to sufficient. > > The Raspberry PI has some devices that can only DMA into the first 1GB > > of the RAM (the GPU seems to be

Re: [PATCH v2] xen: detect uninitialized xenbus in xenbus_init

2021-11-22 Thread Stefano Stabellini
On Mon, 22 Nov 2021, Stefano Stabellini wrote: > On Mon, 22 Nov 2021, Jan Beulich wrote: > > On 19.11.2021 21:29, Stefano Stabellini wrote: > > > --- a/drivers/xen/xenbus/xenbus_probe.c > > > +++ b/drivers/xen/xenbus/xenbus_probe.c > > > @@ -951,6 +951,20 @@ static int __init xenbus_init(void) > >

[PATCH v3] xen: detect uninitialized xenbus in xenbus_init

2021-11-22 Thread Stefano Stabellini
From: Stefano Stabellini If the xenstore page hasn't been allocated properly, reading the value of the related hvm_param (HVM_PARAM_STORE_PFN) won't actually return error. Instead, it will succeed and return zero. Instead of attempting to xen_remap a bad guest physical address, detect this

Re: [PATCH] xen/pvh: add missing prototype to header

2021-11-22 Thread Boris Ostrovsky
On 11/19/21 10:39 AM, Juergen Gross wrote: The prototype of mem_map_via_hcall() is missing in its header, so add it. Reported-by: kernel test robot Fixes: a43fb7da53007e67ad ("xen/pvh: Move Xen code for getting mem map via hcall out of common file") Signed-off-by: Juergen Gross Applied

Re: [PATCH v2] xen: detect uninitialized xenbus in xenbus_init

2021-11-22 Thread Stefano Stabellini
On Mon, 22 Nov 2021, Jan Beulich wrote: > On 19.11.2021 21:29, Stefano Stabellini wrote: > > --- a/drivers/xen/xenbus/xenbus_probe.c > > +++ b/drivers/xen/xenbus/xenbus_probe.c > > @@ -951,6 +951,20 @@ static int __init xenbus_init(void) > > err = hvm_get_parameter(HVM_PARAM_STORE_PFN,

[qemu-mainline test] 166267: tolerable FAIL - PUSHED

2021-11-22 Thread osstest service owner
flight 166267 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/166267/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 166260 test-amd64-amd64-qemuu-nested-amd

[linux-linus test] 166266: tolerable FAIL - PUSHED

2021-11-22 Thread osstest service owner
flight 166266 linux-linus real [real] flight 166299 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/166266/ http://logs.test-lab.xenproject.org/osstest/logs/166299/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [RFC PATCH] Added the logic to decode 32 bit ldr/str post-indexing instructions

2021-11-22 Thread Julien Grall
Hi, On Mon, 22 Nov 2021 at 19:59, Stefano Stabellini wrote: > > On Mon, 22 Nov 2021, Ayan Kumar Halder wrote: > > Stefano > It doesn't look like we are setting dabt->write anywhere. > > > > Ayan > Yes, this is a miss. Depending on the opc, this should be upadeted > > accordingly in

Re: [RFC PATCH] Added the logic to decode 32 bit ldr/str post-indexing instructions

2021-11-22 Thread Stefano Stabellini
On Mon, 22 Nov 2021, Ayan Kumar Halder wrote: > Stefano > It doesn't look like we are setting dabt->write anywhere. > > Ayan > Yes, this is a miss. Depending on the opc, this should be upadeted > accordingly in decode_64bit_loadstore_postindexing(). > > Stefano > Also, is info.gpa in

Re: [PATCH v6 5/7] xen/arm: do not map IRQs and memory for disabled devices

2021-11-22 Thread Julien Grall
Hi Oleksandr, On 18/11/2021 06:59, Oleksandr Andrushchenko wrote: Hi, Julien! On 16.11.21 21:22, Julien Grall wrote: Hi Oleksandr, On 05/11/2021 06:33, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Currently Xen maps all IRQs and memory ranges for all devices except those

Re: [PATCH v6 7/7] xen/arm: do not use void pointer in pci_host_common_probe

2021-11-22 Thread Julien Grall
On 18/11/2021 07:34, Oleksandr Andrushchenko wrote: Hi, Julien! Hi, On 17.11.21 23:45, Julien Grall wrote: Hi Oleksandr, On 05/11/2021 06:33, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko There is no reason to use void pointer while passing ECAM ops to the

Re: [PATCH v6 3/7] xen/arm: setup MMIO range trap handlers for hardware domain

2021-11-22 Thread Julien Grall
Hi, On 18/11/2021 10:46, Oleksandr Andrushchenko wrote: On 18.11.21 09:27, Oleksandr Andrushchenko wrote: Hi, Julien! On 16.11.21 21:12, Julien Grall wrote: Hi Oleksandr, On 05/11/2021 06:33, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko In order for vPCI to work it needs

Re: [PATCH v6 2/7] xen/arm: add pci-domain for disabled devices

2021-11-22 Thread Julien Grall
Hi, On 22/11/2021 16:23, Oleksandr Andrushchenko wrote: On 22.11.21 17:29, Julien Grall wrote: I would prefer to go with my way. This can be refined in the future if we find Device-Tree that matches what you wrote. Ok, so just to make it clear: >a PCI device would always be described as a

Re: [PATCH 5/5] x86/traps: Clean up diagnostics

2021-11-22 Thread Jan Beulich
On 22.11.2021 17:26, Andrew Cooper wrote: > On 22/11/2021 09:08, Jan Beulich wrote: >> On 19.11.2021 19:21, Andrew Cooper wrote: >>> --- a/xen/arch/x86/traps.c >>> +++ b/xen/arch/x86/traps.c >>> @@ -759,21 +759,7 @@ static int nmi_show_execution_state(const struct >>> cpu_user_regs *regs, int

Re: [PATCH 4/5] x86/traps: Drop exception_table[] and use if/else dispatching

2021-11-22 Thread Jan Beulich
On 22.11.2021 17:16, Andrew Cooper wrote: > On 22/11/2021 09:04, Jan Beulich wrote: >> On 19.11.2021 19:21, Andrew Cooper wrote: >>> --- a/xen/arch/x86/x86_64/entry.S >>> +++ b/xen/arch/x86/x86_64/entry.S >>> @@ -773,14 +773,48 @@ handle_exception_saved: >>> sti >>> 1: movq

Re: [PATCH 5/5] x86/traps: Clean up diagnostics

2021-11-22 Thread Andrew Cooper
On 22/11/2021 09:08, Jan Beulich wrote: > On 19.11.2021 19:21, Andrew Cooper wrote: >> do{_reserved,}_trap() should use fatal_trap() rather than opencoding part of > Nit: That's do{_unhandled,}_trap() now. Ah yes.  Will fix. >> --- a/xen/arch/x86/traps.c >> +++ b/xen/arch/x86/traps.c >> @@

Re: [PATCH v6 2/7] xen/arm: add pci-domain for disabled devices

2021-11-22 Thread Oleksandr Andrushchenko
On 22.11.21 17:29, Julien Grall wrote: > > > On 18/11/2021 07:13, Oleksandr Andrushchenko wrote: >> Hi, Julien! > > Hi Oleksandr, > >> On 17.11.21 23:33, Julien Grall wrote: >>> Hi Oleksandr, >>> >>> On 17/11/2021 06:56, Oleksandr Andrushchenko wrote: Hi, Julien! On 16.11.21

Re: [PATCH 4/5] x86/traps: Drop exception_table[] and use if/else dispatching

2021-11-22 Thread Andrew Cooper
On 22/11/2021 09:04, Jan Beulich wrote: > On 19.11.2021 19:21, Andrew Cooper wrote: >> --- a/xen/arch/x86/x86_64/entry.S >> +++ b/xen/arch/x86/x86_64/entry.S >> @@ -773,14 +773,48 @@ handle_exception_saved: >> sti >> 1: movq %rsp,%rdi >> movzbl

[PATCH] cpu/hotplug: Allow the CPU in CPU_UP_PREPARE state to be brought up again.

2021-11-22 Thread Sebastian Andrzej Siewior
From: "Longpeng(Mike)" A CPU will not show up in virtualized environment which includes an Enclave. The VM splits its resources into a primary VM and a Enclave VM. While the Enclave is active, the hypervisor will ignore all requests to bring up a CPU and this CPU will remain in CPU_UP_PREPARE

Re: [PATCH RFC 3/4] xen: add new stable control hypercall

2021-11-22 Thread Jan Beulich
On 14.09.2021 14:35, Juergen Gross wrote: > The sysctl and domctl hypercalls are not stable, so tools using those > need to be in sync with the hypervisor. > > In order to decouple (some) tools from the hypervisor add a new stable > hypercall __HYPERVISOR_control_op I'm not convinced we need a

Re: [PATCH v6 2/7] xen/arm: add pci-domain for disabled devices

2021-11-22 Thread Julien Grall
On 18/11/2021 07:13, Oleksandr Andrushchenko wrote: Hi, Julien! Hi Oleksandr, On 17.11.21 23:33, Julien Grall wrote: Hi Oleksandr, On 17/11/2021 06:56, Oleksandr Andrushchenko wrote: Hi, Julien! On 16.11.21 20:48, Julien Grall wrote: Hi Oleksander, On 05/11/2021 06:33, Oleksandr

Re: [PATCH v3 10/10] xen/docs: Document how to do passthrough without IOMMU

2021-11-22 Thread Bertrand Marquis
Hi Penny, > On 16 Nov 2021, at 06:31, Penny Zheng wrote: > > From: Stefano Stabellini > > This commit creates a new doc to document how to do passthrough without IOMMU. > > Signed-off-by: Stefano Stabellini > Signed-off-by: Penny Zheng > --- > docs/misc/arm/passthrough-noiommu.txt | 52

Re: [RFC PATCH] Added the logic to decode 32 bit ldr/str post-indexing instructions

2021-11-22 Thread Bertrand Marquis
Hi Ayan > On 22 Nov 2021, at 14:19, Ayan Kumar Halder > wrote: > > Hi Julien/Stefano/Wei/Jan, > > Many thanks for your review. > > As some of the comments were inter-related, I have consolidated my response > to all the comments below. > > On 19/11/2021 17:26, Julien Grall wrote: >> Hi

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-22 Thread Oleksandr Andrushchenko
On 22.11.21 16:57, Jan Beulich wrote: > On 22.11.2021 15:45, Oleksandr Andrushchenko wrote: >> >> On 22.11.21 16:37, Jan Beulich wrote: >>> On 22.11.2021 15:21, Oleksandr Andrushchenko wrote: On 19.11.21 15:34, Oleksandr Andrushchenko wrote: > On 19.11.21 15:25, Jan Beulich wrote:

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-22 Thread Jan Beulich
On 22.11.2021 15:45, Oleksandr Andrushchenko wrote: > > > On 22.11.21 16:37, Jan Beulich wrote: >> On 22.11.2021 15:21, Oleksandr Andrushchenko wrote: >>> On 19.11.21 15:34, Oleksandr Andrushchenko wrote: On 19.11.21 15:25, Jan Beulich wrote: > On 19.11.2021 14:16, Oleksandr

RE: [PATCH] MAINTAINERS: remove Josh from ARINC 653 maintainers

2021-11-22 Thread Stewart Hildebrand
On Monday, November 22, 2021 9:39 AM, From: Jan Beulich wrote: >On 22.11.2021 15:17, Stewart Hildebrand wrote: >> Josh works at another company now > >You don't happen to know his email there, do you? Else if would have been >good to Cc him so he could confirm. > >Jan I added Josh in CC. Josh -

Re: [PATCH 3/5] x86/crash: Drop manual hooking of exception_table[]

2021-11-22 Thread Jan Beulich
On 22.11.2021 14:48, Andrew Cooper wrote: > On 22/11/2021 08:57, Jan Beulich wrote: >> On 19.11.2021 19:21, Andrew Cooper wrote: >>> --- a/xen/arch/x86/crash.c >>> +++ b/xen/arch/x86/crash.c >>> @@ -36,10 +36,8 @@ static unsigned int crashing_cpu; >>> static DEFINE_PER_CPU_READ_MOSTLY(bool,

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-22 Thread Oleksandr Andrushchenko
On 22.11.21 16:37, Jan Beulich wrote: > On 22.11.2021 15:21, Oleksandr Andrushchenko wrote: >> On 19.11.21 15:34, Oleksandr Andrushchenko wrote: >>> On 19.11.21 15:25, Jan Beulich wrote: On 19.11.2021 14:16, Oleksandr Andrushchenko wrote: > On 19.11.21 15:00, Jan Beulich wrote: >>

Re: [PATCH] MAINTAINERS: remove Josh from ARINC 653 maintainers

2021-11-22 Thread Jan Beulich
On 22.11.2021 15:17, Stewart Hildebrand wrote: > Josh works at another company now You don't happen to know his email there, do you? Else if would have been good to Cc him so he could confirm. Jan > Signed-off-by: Stewart Hildebrand > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) >

Re: [PATCH RFC 1/4] xen: add a domain unique id to each domain

2021-11-22 Thread Julien Grall
On 22/11/2021 14:29, Juergen Gross wrote: On 22.11.21 15:10, Julien Grall wrote: Hi, Hi, On 22/11/2021 12:48, Juergen Gross wrote: On 22.11.21 12:42, Julien Grall wrote: Hi Juergen, On 14/09/2021 13:35, Juergen Gross wrote: Xenstore is referencing domains by their domid, but reuse of

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-22 Thread Jan Beulich
On 22.11.2021 15:21, Oleksandr Andrushchenko wrote: > On 19.11.21 15:34, Oleksandr Andrushchenko wrote: >> On 19.11.21 15:25, Jan Beulich wrote: >>> On 19.11.2021 14:16, Oleksandr Andrushchenko wrote: On 19.11.21 15:00, Jan Beulich wrote: > On 19.11.2021 13:34, Oleksandr Andrushchenko

Re: [PATCH RFC 1/4] xen: add a domain unique id to each domain

2021-11-22 Thread Juergen Gross
On 22.11.21 15:10, Julien Grall wrote: Hi, On 22/11/2021 12:48, Juergen Gross wrote: On 22.11.21 12:42, Julien Grall wrote: Hi Juergen, On 14/09/2021 13:35, Juergen Gross wrote: Xenstore is referencing domains by their domid, but reuse of a domid can lead to the situation that Xenstore

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-22 Thread Oleksandr Andrushchenko
On 19.11.21 15:34, Oleksandr Andrushchenko wrote: > > On 19.11.21 15:25, Jan Beulich wrote: >> On 19.11.2021 14:16, Oleksandr Andrushchenko wrote: >>> On 19.11.21 15:00, Jan Beulich wrote: On 19.11.2021 13:34, Oleksandr Andrushchenko wrote: > Possible locking and other work needed:

Re: [RFC PATCH] Added the logic to decode 32 bit ldr/str post-indexing instructions

2021-11-22 Thread Ayan Kumar Halder
Hi Julien/Stefano/Wei/Jan, Many thanks for your review. As some of the comments were inter-related, I have consolidated my response to all the comments below. On 19/11/2021 17:26, Julien Grall wrote: Hi Ayan, On 19/11/2021 16:52, Ayan Kumar Halder wrote: At present, post indexing

[PATCH] MAINTAINERS: remove Josh from ARINC 653 maintainers

2021-11-22 Thread Stewart Hildebrand
Josh works at another company now Signed-off-by: Stewart Hildebrand --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4956db1011..fc8b2c1169 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -221,7 +221,6 @@ F: xen/include/xen/argo.h F:

Re: [PATCH RFC 1/4] xen: add a domain unique id to each domain

2021-11-22 Thread Julien Grall
Hi, On 22/11/2021 12:48, Juergen Gross wrote: On 22.11.21 12:42, Julien Grall wrote: Hi Juergen, On 14/09/2021 13:35, Juergen Gross wrote: Xenstore is referencing domains by their domid, but reuse of a domid can lead to the situation that Xenstore can't tell whether a domain with that domid

Re: [PATCH 3/5] x86/crash: Drop manual hooking of exception_table[]

2021-11-22 Thread Andrew Cooper
On 22/11/2021 08:57, Jan Beulich wrote: > On 19.11.2021 19:21, Andrew Cooper wrote: >> --- a/xen/arch/x86/crash.c >> +++ b/xen/arch/x86/crash.c >> @@ -36,10 +36,8 @@ static unsigned int crashing_cpu; >> static DEFINE_PER_CPU_READ_MOSTLY(bool, crash_save_done); >> >> /* This becomes the NMI

Re: [PATCH RFC 2/4] xen: add bitmap to indicate per-domain state changes

2021-11-22 Thread Jan Beulich
On 22.11.2021 13:46, Juergen Gross wrote: > On 22.11.21 11:41, Jan Beulich wrote: >> On 14.09.2021 14:35, Juergen Gross wrote: >>> Add a bitmap with one bit per possible domid indicating the respective >>> domain has changed its state (created, deleted, dying, crashed, >>> shutdown). >>> >>>

Re: [PATCH RFC 1/4] xen: add a domain unique id to each domain

2021-11-22 Thread Juergen Gross
On 22.11.21 12:42, Julien Grall wrote: Hi Juergen, On 14/09/2021 13:35, Juergen Gross wrote: Xenstore is referencing domains by their domid, but reuse of a domid can lead to the situation that Xenstore can't tell whether a domain with that domid has been deleted and created again without

Re: [PATCH RFC 2/4] xen: add bitmap to indicate per-domain state changes

2021-11-22 Thread Juergen Gross
On 22.11.21 11:41, Jan Beulich wrote: On 14.09.2021 14:35, Juergen Gross wrote: Add a bitmap with one bit per possible domid indicating the respective domain has changed its state (created, deleted, dying, crashed, shutdown). Registering the VIRQ_DOM_EXC event will result in setting the bits

Re: [OSSTEST PATCH 2/2] allow.all: Treat freeBSD memdisk-try-append failures as nonblocking

2021-11-22 Thread Roger Pau Monné
On Mon, Nov 22, 2021 at 11:52:39AM +, Ian Jackson wrote: > In practice this currently fails on some of our hosts. We don't seem > to have resources to investigate properly, and this will be blocking > recomissioning of hosts if we don't get it out of the way. > > Signed-off-by: Ian Jackson

[OSSTEST PATCH 1/2] README.dev: Document to use updated osstest for commissioning

2021-11-22 Thread Ian Jackson
Signed-off-by: Ian Jackson Release-Acked-by: Ian Jackson --- README.dev | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.dev b/README.dev index 3d09b3c6b..132772fb4 100644 --- a/README.dev +++ b/README.dev @@ -108,6 +108,8 @@ Create the tftp directory (must be done after firmware is

[OSSTEST PATCH 2/2] allow.all: Treat freeBSD memdisk-try-append failures as nonblocking

2021-11-22 Thread Ian Jackson
In practice this currently fails on some of our hosts. We don't seem to have resources to investigate properly, and this will be blocking recomissioning of hosts if we don't get it out of the way. Signed-off-by: Ian Jackson Release-Acked-by: Ian Jackson CC: Roger Pau Monné --- allow.all | 1

Re: [PATCH RFC 1/4] xen: add a domain unique id to each domain

2021-11-22 Thread Julien Grall
Hi Juergen, On 14/09/2021 13:35, Juergen Gross wrote: Xenstore is referencing domains by their domid, but reuse of a domid can lead to the situation that Xenstore can't tell whether a domain with that domid has been deleted and created again without Xenstore noticing the domain is a new one

Re: [PATCH 1/2] rangeset: add RANGESETF_no_print flag

2021-11-22 Thread Oleksandr Andrushchenko
On 22.11.21 11:28, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > There are range sets which should not be printed, so introduce a flag > which allows marking those as such. Implement relevant logic to skip > such entries while printing. > > Suggested-by: Jan Beulich >

Commit Moratorium (was Re: Xen 4.16 development update - tree status)

2021-11-22 Thread Ian Jackson
tl;dr: Commit moratorium is now in force until further notice (which will be given tomorrow afternoon). Jan Beulich writes ("Re: Xen 4.16 development update - tree status"): > On 19.11.2021 16:15, Ian Jackson wrote: > > Tree status > > === > > > > We are now in deep code freeze,

Re: [PATCH 2/2] vpci: use named rangeset for BARs

2021-11-22 Thread Oleksandr Andrushchenko
On 22.11.21 13:08, Jan Beulich wrote: > On 22.11.2021 11:59, Oleksandr Andrushchenko wrote: >> On 22.11.21 12:54, Jan Beulich wrote: >>> On 22.11.2021 11:50, Oleksandr Andrushchenko wrote: On 22.11.21 12:43, Jan Beulich wrote: > On 22.11.2021 11:27, Roger Pau Monné wrote: >> On Mon,

Re: [PATCH for-4.16 v2] CHANGELOG: add missing entries for work during the 4.16 release cycle

2021-11-22 Thread Jan Beulich
On 22.11.2021 12:00, Roger Pau Monné wrote: > On Mon, Nov 22, 2021 at 11:51:59AM +0100, Jan Beulich wrote: >> On 22.11.2021 11:40, Roger Pau Monne wrote: >>> +### Added >>> + - 32bit Arm builds to the gitlab-ci automated tests. >>> + - x86 full system tests to the gitlab-ci automated tests. >>> +

Re: [PATCH 2/2] vpci: use named rangeset for BARs

2021-11-22 Thread Jan Beulich
On 22.11.2021 11:59, Oleksandr Andrushchenko wrote: > On 22.11.21 12:54, Jan Beulich wrote: >> On 22.11.2021 11:50, Oleksandr Andrushchenko wrote: >>> >>> On 22.11.21 12:43, Jan Beulich wrote: On 22.11.2021 11:27, Roger Pau Monné wrote: > On Mon, Nov 22, 2021 at 11:28:25AM +0200,

Re: [PATCH for-4.16 v2] CHANGELOG: add missing entries for work during the 4.16 release cycle

2021-11-22 Thread Roger Pau Monné
On Mon, Nov 22, 2021 at 11:51:59AM +0100, Jan Beulich wrote: > (reducing Cc list) > > On 22.11.2021 11:40, Roger Pau Monne wrote: > > --- a/CHANGELOG.md > > +++ b/CHANGELOG.md > > @@ -21,6 +21,32 @@ The format is based on [Keep a > > Changelog](https://keepachangelog.com/en/1.0.0/) > > -

Re: [PATCH 2/2] vpci: use named rangeset for BARs

2021-11-22 Thread Oleksandr Andrushchenko
On 22.11.21 12:54, Jan Beulich wrote: > On 22.11.2021 11:50, Oleksandr Andrushchenko wrote: >> >> On 22.11.21 12:43, Jan Beulich wrote: >>> On 22.11.2021 11:27, Roger Pau Monné wrote: On Mon, Nov 22, 2021 at 11:28:25AM +0200, Oleksandr Andrushchenko wrote: > ---

Re: [PATCH 2/2] vpci: use named rangeset for BARs

2021-11-22 Thread Jan Beulich
On 22.11.2021 11:50, Oleksandr Andrushchenko wrote: > > > On 22.11.21 12:43, Jan Beulich wrote: >> On 22.11.2021 11:27, Roger Pau Monné wrote: >>> On Mon, Nov 22, 2021 at 11:28:25AM +0200, Oleksandr Andrushchenko wrote: --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c

Re: [PATCH 2/2] vpci: use named rangeset for BARs

2021-11-22 Thread Roger Pau Monné
On Mon, Nov 22, 2021 at 10:50:18AM +, Oleksandr Andrushchenko wrote: > > > On 22.11.21 12:43, Jan Beulich wrote: > > On 22.11.2021 11:27, Roger Pau Monné wrote: > >> On Mon, Nov 22, 2021 at 11:28:25AM +0200, Oleksandr Andrushchenko wrote: > >>> --- a/xen/drivers/vpci/header.c > >>> +++

Re: [PATCH for-4.16 v2] CHANGELOG: add missing entries for work during the 4.16 release cycle

2021-11-22 Thread Jan Beulich
(reducing Cc list) On 22.11.2021 11:40, Roger Pau Monne wrote: > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -21,6 +21,32 @@ The format is based on [Keep a > Changelog](https://keepachangelog.com/en/1.0.0/) > - qemu-traditional based device models (both, qemu-traditional and > ioemu-stubdom)

Re: [PATCH 2/2] vpci: use named rangeset for BARs

2021-11-22 Thread Oleksandr Andrushchenko
On 22.11.21 12:43, Jan Beulich wrote: > On 22.11.2021 11:27, Roger Pau Monné wrote: >> On Mon, Nov 22, 2021 at 11:28:25AM +0200, Oleksandr Andrushchenko wrote: >>> --- a/xen/drivers/vpci/header.c >>> +++ b/xen/drivers/vpci/header.c >>> @@ -206,12 +206,16 @@ static void defer_map(struct domain

[xen-unstable test] 166263: tolerable FAIL

2021-11-22 Thread osstest service owner
flight 166263 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/166263/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 166256 Tests which did not

Re: [PATCH 2/2] vpci: use named rangeset for BARs

2021-11-22 Thread Jan Beulich
On 22.11.2021 11:27, Roger Pau Monné wrote: > On Mon, Nov 22, 2021 at 11:28:25AM +0200, Oleksandr Andrushchenko wrote: >> --- a/xen/drivers/vpci/header.c >> +++ b/xen/drivers/vpci/header.c >> @@ -206,12 +206,16 @@ static void defer_map(struct domain *d, struct pci_dev >> *pdev, >> static int

Re: [PATCH RFC 2/4] xen: add bitmap to indicate per-domain state changes

2021-11-22 Thread Jan Beulich
On 14.09.2021 14:35, Juergen Gross wrote: > Add a bitmap with one bit per possible domid indicating the respective > domain has changed its state (created, deleted, dying, crashed, > shutdown). > > Registering the VIRQ_DOM_EXC event will result in setting the bits for > all existing domains and

[PATCH for-4.16 v2] CHANGELOG: add missing entries for work during the 4.16 release cycle

2021-11-22 Thread Roger Pau Monne
Document some of the relevant changes during the 4.16 release cycle. Signed-off-by: Roger Pau Monné Release-Acked-by: Ian Jackson --- Changes since v1: - Add qemu-traditional and pvgrub notes. - Expand vPMU support to note it's limited. - xenstore library API changes. - xencall2L addition.

Re: [PATCH 2/2] vpci: use named rangeset for BARs

2021-11-22 Thread Roger Pau Monné
On Mon, Nov 22, 2021 at 11:28:25AM +0200, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Use a named range set instead of an anonymous one, but do not print it > while dumping range sets for a domain. > > Suggested-by: Jan Beulich > Signed-off-by: Oleksandr Andrushchenko >

Re: [PATCH for-4.16 2/2] CHANGELOG: add missing entries for work during the 4.16 release cycle

2021-11-22 Thread Bertrand Marquis
Hi, > On 19 Nov 2021, at 09:34, Oleksandr wrote: > > > On 19.11.21 09:59, Roger Pau Monné wrote: > > Hi Roger, all > > >> On Thu, Nov 18, 2021 at 09:04:30PM +0200, Oleksandr wrote: >>> On 18.11.21 19:33, Roger Pau Monné wrote: >>> >>> Hi Roger >>> >>> On Thu, Nov 18, 2021 at

Re: [PATCH RFC 1/4] xen: add a domain unique id to each domain

2021-11-22 Thread Jan Beulich
On 14.09.2021 14:35, Juergen Gross wrote: > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -84,6 +84,9 @@ vcpu_info_t dummy_vcpu_info; > > bool __read_mostly vmtrace_available; > > +/* Unique domain identifier, protected by domctl lock. */ > +static uint64_t unique_id; Unless a

[PATCH 1/2] rangeset: add RANGESETF_no_print flag

2021-11-22 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko There are range sets which should not be printed, so introduce a flag which allows marking those as such. Implement relevant logic to skip such entries while printing. Suggested-by: Jan Beulich Signed-off-by: Oleksandr Andrushchenko --- xen/common/rangeset.c

[PATCH 2/2] vpci: use named rangeset for BARs

2021-11-22 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Use a named range set instead of an anonymous one, but do not print it while dumping range sets for a domain. Suggested-by: Jan Beulich Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/vpci/header.c | 6 +- 1 file changed, 5 insertions(+), 1

[libvirt test] 166264: regressions - FAIL

2021-11-22 Thread osstest service owner
flight 166264 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/166264/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH] xen/smp: Support NULL IPI function pointers

2021-11-22 Thread Luca Fancellu
> On 18 Nov 2021, at 10:35, Andrew Cooper wrote: > > On 18/11/2021 09:58, Jan Beulich wrote: >> On 17.11.2021 17:48, Andrew Cooper wrote: >>> There are several cases where the act of interrupting a remote processor has >>> the required side effect. Explicitly allow NULL function pointers so

Re: [PATCH 5/5] x86/traps: Clean up diagnostics

2021-11-22 Thread Jan Beulich
On 19.11.2021 19:21, Andrew Cooper wrote: > do{_reserved,}_trap() should use fatal_trap() rather than opencoding part of Nit: That's do{_unhandled,}_trap() now. > it. This lets the remote stack trace logic work in more fatal error > conditions. > > With do_trap() converted, there is only one

Re: [PATCH 4/5] x86/traps: Drop exception_table[] and use if/else dispatching

2021-11-22 Thread Jan Beulich
On 19.11.2021 19:21, Andrew Cooper wrote: > --- a/xen/arch/x86/x86_64/entry.S > +++ b/xen/arch/x86/x86_64/entry.S > @@ -773,14 +773,48 @@ handle_exception_saved: > sti > 1: movq %rsp,%rdi > movzbl UREGS_entry_vector(%rsp),%eax > -leaq exception_table(%rip),%rdx >

Re: [PATCH 3/5] x86/crash: Drop manual hooking of exception_table[]

2021-11-22 Thread Jan Beulich
On 19.11.2021 19:21, Andrew Cooper wrote: > NMI hooking in the crash path has undergone several revisions since its > introduction. What we have now is not sufficiently different from the regular > nmi_callback() mechanism to warrant special casing. > > Use set_nmi_callback() directly, and do

Re: [PATCH 2/5] x86/traps: Drop dummy_nmi_callback()

2021-11-22 Thread Jan Beulich
On 19.11.2021 19:21, Andrew Cooper wrote: > The unconditional nmi_callback() call in do_nmi() calls dummy_nmi_callback() > in all cases other than for a few specific and rare tasks (alternative > patching, microcode loading, etc). > > Indirect calls are expensive under retpoline, so rearrange the

Re: [PATCH 1/5] x86/traps: Collect PERFC_exceptions stats for IST vectors too

2021-11-22 Thread Jan Beulich
On 19.11.2021 19:21, Andrew Cooper wrote: > This causes NMIs, #DB and #MC to be counted, rather than being reported as 0. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

Re: [PATCH v4 00/11] PCI devices passthrough on Arm, part 3

2021-11-22 Thread Jan Beulich
On 22.11.2021 09:34, Oleksandr Andrushchenko wrote: > On 22.11.21 10:22, Jan Beulich wrote: >> On 19.11.2021 15:23, Roger Pau Monné wrote: >>> On Fri, Nov 19, 2021 at 02:56:12PM +0100, Jan Beulich wrote: On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko

Re: [PATCH v4 00/11] PCI devices passthrough on Arm, part 3

2021-11-22 Thread Oleksandr Andrushchenko
On 22.11.21 10:22, Jan Beulich wrote: > On 19.11.2021 15:23, Roger Pau Monné wrote: >> On Fri, Nov 19, 2021 at 02:56:12PM +0100, Jan Beulich wrote: >>> On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Hi, all! This patch series is

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-22 Thread Oleksandr Andrushchenko
On 22.11.21 10:24, Jan Beulich wrote: > On 19.11.2021 15:09, Oleksandr Andrushchenko wrote: >> On 19.11.21 15:57, Jan Beulich wrote: >>> On 19.11.2021 14:41, Oleksandr Andrushchenko wrote: On 19.11.21 15:16, Jan Beulich wrote: > On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: >>

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-22 Thread Jan Beulich
On 19.11.2021 15:09, Oleksandr Andrushchenko wrote: > On 19.11.21 15:57, Jan Beulich wrote: >> On 19.11.2021 14:41, Oleksandr Andrushchenko wrote: >>> On 19.11.21 15:16, Jan Beulich wrote: On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: > @@ -95,10 +102,25 @@ int

Re: [PATCH v4 00/11] PCI devices passthrough on Arm, part 3

2021-11-22 Thread Jan Beulich
On 19.11.2021 15:23, Roger Pau Monné wrote: > On Fri, Nov 19, 2021 at 02:56:12PM +0100, Jan Beulich wrote: >> On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> Hi, all! >>> >>> This patch series is focusing on vPCI and adds support for non-identity >>>

Re: [PATCH 0/5] xen: cleanup detection of non-essential pv devices

2021-11-22 Thread Juergen Gross
On 22.10.21 08:47, Juergen Gross wrote: Today the non-essential pv devices are hard coded in the xenbus driver and this list is lacking multiple entries. This series reworks the detection logic of non-essential devices by adding a flag for that purpose to struct xenbus_driver. Juergen Gross

Re: Xen 4.16 development update - tree status

2021-11-22 Thread Jan Beulich
On 19.11.2021 16:15, Ian Jackson wrote: > Tree status > === > > We are now in deep code freeze, during which we will try to discover > and eliminate serious bugs and regressions. > > All patches other than documentation patches need a Release-Ack. > Fixes for serious bugs, and test

Re: [RFC PATCH] Added the logic to decode 32 bit ldr/str post-indexing instructions

2021-11-22 Thread Jan Beulich
On 19.11.2021 17:52, Ayan Kumar Halder wrote: > --- a/xen/arch/arm/decode.c > +++ b/xen/arch/arm/decode.c > @@ -84,6 +84,80 @@ bad_thumb2: > return 1; > } > > +static inline int32_t extract32(uint32_t value, int start, int length) > +{ > +int32_t ret; > + > +if ( !(start >= 0 &&

Re: [RFC PATCH] Added the logic to decode 32 bit ldr/str post-indexing instructions

2021-11-22 Thread Jan Beulich
On 20.11.2021 02:41, Stefano Stabellini wrote: > On Fri, 19 Nov 2021, Ayan Kumar Halder wrote: >> +static int decode_64bit_loadstore_postindexing(register_t pc, struct >> hsr_dabt *dabt) >> +{ >> +uint32_t instr; >> +int size; >> +int v; >> +int opc; >> +int rt; >> +int

Re: [PATCH for-4.16 v3] efi: fix alignment of function parameters in compat mode

2021-11-22 Thread Jan Beulich
On 19.11.2021 18:09, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH for-4.16 v3] efi: fix alignment of function > parameters in compat mode"): >> Some hardtabs appear to have slipped in. > > Thanks. Fixed. > >> Jan gave a conditional R-by which permitted a change along these lines, >>