Re: [PATCH] xen/CET: Fix __initconst_cf_clobber

2022-03-03 Thread Andrew Cooper
On 03/03/2022 07:35, Jan Beulich wrote: > On 02.03.2022 23:10, Andrew Cooper wrote: >> The linker script collecting .init.rodata.* ahead of .init.rodata.cf_clobber >> accidentally causes __initconst_cf_clobber to be a no-op. >> >> Rearrange the linker script to unbreak this. >> >> The IOMMU

Re: [PATCH RFC] xen/sched: Optimise when only one scheduler is compiled in

2022-03-03 Thread Juergen Gross
On 03.03.22 09:33, Juergen Gross wrote: On 03.03.22 01:40, Andrew Cooper wrote: When only one scheduler is compiled in, function pointers can be optimised to direct calls, and the hooks hardened against controlflow hijacking. RFC for several reasons. 1) There's an almost beautiful way of not

Re: [PATCH v3 0/7] (mainly) xz imports from Linux

2022-03-03 Thread Jan Beulich
On 03.03.2022 11:03, Jan Beulich wrote: > While going through their 5.15.3 log I did notice two changes, which made > me go check what else we might be missing. The series here is the result. > Linux has also updated zstd, but that includes a pretty large change which > I'm not ready to deal with

[PATCH v3 7/7] xz: fix spelling in comments

2022-03-03 Thread Jan Beulich
From: Lasse Collin uncompressible -> incompressible non-splitted -> non-split Link: https://lore.kernel.org/r/20211010213145.17462-6-xi...@kernel.org Signed-off-by: Lasse Collin Signed-off-by: Gao Xiang [Linux commit: 0a434e0a2c9f4395e4560aac22677ef25ab4afd9] Signed-off-by: Jan Beulich

[PATCH v3 6/7] xz: move s->lzma.len = 0 initialization to lzma_reset()

2022-03-03 Thread Jan Beulich
From: Lasse Collin It's a more logical place even if the resetting needs to be done only once per LZMA2 stream (if lzma_reset() called in the middle of an LZMA2 stream, .len will already be 0). Link: https://lore.kernel.org/r/20211010213145.17462-4-xi...@kernel.org Signed-off-by: Lasse Collin

[PATCH v3 5/7] xz: validate the value before assigning it to an enum variable

2022-03-03 Thread Jan Beulich
From: Lasse Collin This might matter, for example, if the underlying type of enum xz_check was a signed char. In such a case the validation wouldn't have caught an unsupported header. I don't know if this problem can occur in the kernel on any arch but it's still good to fix it because some

[PATCH v3 4/7] xz: avoid overlapping memcpy() with invalid input with in-place decompression

2022-03-03 Thread Jan Beulich
From: Lasse Collin With valid files, the safety margin described in lib/decompress_unxz.c ensures that these buffers cannot overlap. But if the uncompressed size of the input is larger than the caller thought, which is possible when the input file is invalid/corrupt, the buffers can overlap.

Re: [PATCH RFC] xen/sched: Optimise when only one scheduler is compiled in

2022-03-03 Thread Juergen Gross
On 03.03.22 09:33, Juergen Gross wrote: On 03.03.22 01:40, Andrew Cooper wrote: When only one scheduler is compiled in, function pointers can be optimised to direct calls, and the hooks hardened against controlflow hijacking. RFC for several reasons. 1) There's an almost beautiful way of not

[PATCH v3 3/7] decompressors: fix spelling mistakes

2022-03-03 Thread Jan Beulich
From: Zhen Lei Fix some spelling mistakes in comments: sentinal ==> sentinel compresed ==> compressed immediatelly ==> immediately dervied ==> derived splitted ==> split nore ==> not independed ==> independent asumed ==> assumed Link:

[PATCH v3 2/7] xz: fix XZ_DYNALLOC to avoid useless memory reallocations

2022-03-03 Thread Jan Beulich
From: Lasse Collin s->dict.allocated was initialized to 0 but never set after a successful allocation, thus the code always thought that the dictionary buffer has to be reallocated. Link: http://lkml.kernel.org/r/20191104185107.3b633...@tukaani.org Reported-by: Yu Sun Signed-off-by: Lasse

[PATCH v3 1/7] xz: add fall-through comments to a switch statement

2022-03-03 Thread Jan Beulich
From: Lasse Collin It's good style. I was also told that GCC 7 is more strict and might give a warning when such comments are missing. Suggested-by: Andrei Borzenkov Signed-off-by: Lasse Collin Signed-off-by: Jiri Kosina [Linux commit: 5a244f48ecbbd03a11eb84819c5c599db81823ee] Signed-off-by:

[PATCH v3 0/7] (mainly) xz imports from Linux

2022-03-03 Thread Jan Beulich
While going through their 5.15.3 log I did notice two changes, which made me go check what else we might be missing. The series here is the result. Linux has also updated zstd, but that includes a pretty large change which I'm not ready to deal with right now. Them moving closer to the upstream

[PATCH] x86/tboot: adjust Kconfig default

2022-03-03 Thread Jan Beulich
We shouldn't include unsupported code by default, with not even a means for its building to be disabled. Convert the dependency from merely affecting the prompt's visibility to a real one. Signed-off-by: Jan Beulich --- We could of course go further and make the default also account for DEBUG,

[libvirt test] 168354: regressions - FAIL

2022-03-03 Thread osstest service owner
flight 168354 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/168354/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: Proposal for Porting Xen to Armv8-R64 - DraftA

2022-03-03 Thread Julien Grall
Hi Wei, On 03/03/2022 01:35, Wei Chen wrote: 1. Assembly code for EL1 MPU context_switch This discussion reminds me when KVM decided to rewrite their context switch from assembly to C. The outcome was the compiler is able to do a better job than us when it comes to optimizing. With a C

Re: [PATCH RFC] xen/sched: Optimise when only one scheduler is compiled in

2022-03-03 Thread Juergen Gross
On 03.03.22 01:40, Andrew Cooper wrote: When only one scheduler is compiled in, function pointers can be optimised to direct calls, and the hooks hardened against controlflow hijacking. RFC for several reasons. 1) There's an almost beautiful way of not introducing MAYBE_SCHED() and hiding

Re: [PATCH RFC] xen/sched: Optimise when only one scheduler is compiled in

2022-03-03 Thread Jan Beulich
On 03.03.2022 01:40, Andrew Cooper wrote: > When only one scheduler is compiled in, function pointers can be optimised to > direct calls, and the hooks hardened against controlflow hijacking. > > RFC for several reasons. > > 1) There's an almost beautiful way of not introducing MAYBE_SCHED() and

Re: [XEN PATCH v2 16/29] libs,tools/include: Clean "clean" targets

2022-03-03 Thread Juergen Gross
On 25.02.22 16:13, Anthony PERARD wrote: There is no need for an extra "cleanlocal" target, we can use double-colon rules instead. Generated headers are now in tools/include/, so remove those file there. Remove -f flag as it's already in $(RM). libs.mk: - don't try to remove "*.rpm"

Re: [XEN PATCH v2 15/29] libs: Remove need for *installlocal targets

2022-03-03 Thread Juergen Gross
On 25.02.22 16:13, Anthony PERARD wrote: There is no need for an extra "installlocal" target, we can use double-colon rules instead. "install-headers" in "libs/store" was introduced for the same reason that "installlocal" exist, so it is replaced as well. Signed-off-by: Anthony PERARD

Re: [XEN PATCH v2 11/29] tools/xenstore: Cleanup makefile

2022-03-03 Thread Juergen Gross
On 25.02.22 16:13, Anthony PERARD wrote: Regroup *FLAGS together, use $(LDLIBS). Remove $(LDLIBS_xenstored) which was the wrong name name as it doesn't decribe how to link to a potential libxenstored.so, instead add the value to $(LDLIBS) of xenstored. Add SYSTEMD_LIBS into $(LDLIBS) instead

<    1   2