Re: [PATCH v2 2/3] xen/heap: Split init_heap_pages() in two

2022-07-18 Thread Wei Chen
Hi Julien, On 2022/7/16 1:03, Julien Grall wrote: From: Julien Grall At the moment, init_heap_pages() will call free_heap_pages() page by page. To reduce the time to initialize the heap, we will want to provide multiple pages at the same time. init_heap_pages() is now split in two parts:

Re: [PATCH v2 1/3] xen: page_alloc: Don't open-code IS_ALIGNED()

2022-07-18 Thread Jan Beulich
On 15.07.2022 19:03, Julien Grall wrote: > From: Julien Grall > > init_heap_pages() is using an open-code version of IS_ALIGNED(). Replace > it to improve the readability of the code. > > No functional change intended. > > Signed-off-by: Julien Grall Acked-by: Jan Beulich

Re: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number

2022-07-18 Thread Jan Beulich
On 18.07.2022 09:51, Wei Chen wrote: >> From: Julien Grall >> Sent: 2022年7月14日 19:27 >> >> On 14/07/2022 12:10, Jan Beulich wrote: >>> On 14.07.2022 12:14, Wei Chen wrote: > From: Jan Beulich > Sent: 2022年7月12日 22:34 > > On 08.07.2022 16:54, Wei Chen wrote: >> ---

Re: [PATCH v2 1/3] xen: page_alloc: Don't open-code IS_ALIGNED()

2022-07-18 Thread Wei Chen
Hi Julien, On 2022/7/16 1:03, Julien Grall wrote: From: Julien Grall init_heap_pages() is using an open-code version of IS_ALIGNED(). Replace it to improve the readability of the code. No functional change intended. Signed-off-by: Julien Grall --- Changes in v2: - Patch added ---

RE: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number

2022-07-18 Thread Wei Chen
Hi Julien, Jan, > -Original Message- > From: Julien Grall > Sent: 2022年7月14日 19:27 > To: Jan Beulich ; Wei Chen > Cc: nd ; Andrew Cooper ; George > Dunlap ; Stefano Stabellini > ; Wei Liu ; Roger Pau Monné > ; xen-devel@lists.xenproject.org > Subject: Re: [PATCH v2 9/9] xen: introduce a

Re: Arm64's xen.efi vs GNU binutils (and alike)

2022-07-18 Thread Wei Chen
Hi Jan, On 2022/7/11 22:32, Jan Beulich wrote: Hello, the other day I wanted to look at the basic structure of xen.efi. First I used my own dumping tool, which didn't work. Then I used objdump, which appeared to work. I decided that I should look into what they do different, and whether I

[libvirt test] 171667: regressions - FAIL

2022-07-18 Thread osstest service owner
flight 171667 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171667/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

[PATCH 0/5] xen/wait: Improvements

2022-07-18 Thread Andrew Cooper
This started out as patch 2 for a different task, and quickly identified some technical debt, long overdue for cleaning up. Andrew Cooper (5): xen/wait: Drop vestigial remnants of TRAP_regs_partial xen/wait: Extend the description of how this logic actually works xen/wait: Minor asm

[PATCH 3/5] xen/wait: Minor asm improvements

2022-07-18 Thread Andrew Cooper
There is no point preserving all registers. Instead, preserve an arbitrary 6 registers, and list the rest as clobbered. This does not alter the register scheduling at all, but does reduce the amount of state needing saving. Use a named parameter for page size, instead of needing to parse which

[PATCH 4/5] xen/wait: Use relative stack adjustments

2022-07-18 Thread Andrew Cooper
The waitqueue's esp field is overloaded. It serves both as an indication that the waitqueue is in use, and as a direction to check_wakeup_from_wait() as to where to adjust the stack pointer to, but using an absolute pointer comes with a cost if requiring the vCPU to wake up on the same pCPU it

[PATCH 2/5] xen/wait: Extend the description of how this logic actually works

2022-07-18 Thread Andrew Cooper
Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/common/wait.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/xen/common/wait.c b/xen/common/wait.c index 3ebb884fe738..4dcfa17a8a3f 100644 ---

[PATCH 5/5] xen/wait: Remove VCPU_AFFINITY_WAIT

2022-07-18 Thread Andrew Cooper
With the waitqueue logic updated to not use an absolute stack pointer reference, the vCPU can safely be resumed anywhere. Remove VCPU_AFFINITY_WAIT completely, getting rid of two domain crashes, and a logical corner case where resetting the vcpu with an oustanding waitqueue would crash the

[PATCH 1/5] xen/wait: Drop vestigial remnants of TRAP_regs_partial

2022-07-18 Thread Andrew Cooper
The preservation of entry_vector was introduced with ecf9846a6a20 ("x86: save/restore only partial register state where possible") where TRAP_regs_partial was introduced, but missed from f9eb74789af7 ("x86/entry: Remove support for partial cpu_user_regs frames") where TRAP_regs_partial was

RE: [PATCH v8 9/9] xen: retrieve reserved pages on populate_physmap

2022-07-18 Thread Penny Zheng
Hi Jan > -Original Message- > From: Jan Beulich > Sent: Friday, July 8, 2022 9:06 PM > To: Penny Zheng > Cc: Wei Chen ; Andrew Cooper > ; George Dunlap ; > Julien Grall ; Stefano Stabellini ; > Wei Liu ; xen-devel@lists.xenproject.org > Subject: Re: [PATCH v8 9/9] xen: retrieve reserved

RE: [PATCH v8 2/9] xen: do not free reserved memory into heap

2022-07-18 Thread Penny Zheng
Hi Jan > -Original Message- > From: Jan Beulich > Sent: Friday, July 8, 2022 8:48 PM > To: Penny Zheng > Cc: Wei Chen ; Stefano Stabellini > ; Julien Grall ; Bertrand Marquis > ; Volodymyr Babchuk > ; Andrew Cooper > ; George Dunlap ; > Wei Liu ; xen-devel@lists.xenproject.org >

Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR

2022-07-18 Thread Jan Beulich
On 15.07.2022 21:53, Chuck Zmudzinski wrote: > Two things I see here in my efforts to get a patch to fix this regression: > > 1. Does Xen have plans to give Linux running in Dom0 write-access to the > PAT MSR? No, as this is not technically feasible (all physical CPUs should run with the same

<    1   2