[xen-4.13-testing test] 174570: tolerable FAIL - PUSHED

2022-11-01 Thread osstest service owner
flight 174570 xen-4.13-testing real [real] flight 174579 xen-4.13-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174570/ http://logs.test-lab.xenproject.org/osstest/logs/174579/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [PATCH 01/20] tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR

2022-11-01 Thread Juergen Gross
On 01.11.22 17:43, Andrew Cooper wrote: On 01/11/2022 15:28, Juergen Gross wrote: XEN_LIB_STORED is serving no real purpose, as it is a mount point for a tmpfs, so it can be replaced easily by XEN_RUN_STORED. XENSTORED_ROOTDIR is basically unused already, there is just a single reference in xs_

RE: Feedback for postponing the 4.17 release to a week later

2022-11-01 Thread Henry Wang
Hi Julien and Jan, > -Original Message- > > > Somewhat related. When should we branch for the release and set > > > CONFIG_DEBUG=n? > > > > > > I think we would at least need a RC with CONFIG_DEBUG=n but IIUC we > > > usually do it at a point where the tree is nearly frozen. > > > > > > AF

RE: [PATCH 01/20] tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR

2022-11-01 Thread Henry Wang
Hi Andrew, > -Original Message- > From: Andrew Cooper > Subject: Re: [PATCH 01/20] tools/xenstore: remove XEN_LIB_STORED and > XENSTORED_ROOTDIR > > On 01/11/2022 15:28, Juergen Gross wrote: > > XEN_LIB_STORED is serving no real purpose, as it is a mount point for > > a tmpfs, so it can

[xen-4.15-testing test] 174572: tolerable FAIL - PUSHED

2022-11-01 Thread osstest service owner
flight 174572 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174572/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 174555 test-amd64-amd64-xl-qemut-win7-a

[xen-4.16-testing test] 174568: tolerable FAIL - PUSHED

2022-11-01 Thread osstest service owner
flight 174568 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174568/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 174553 test-amd64-amd64-xl-qemut-win7-a

[linux-linus test] 174566: regressions - FAIL

2022-11-01 Thread osstest service owner
flight 174566 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174566/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl

Re: [PATCH 28/30] x86/xen: Use kstrtobool() instead of strtobool()

2022-11-01 Thread Boris Ostrovsky
On 11/1/22 5:14 PM, Christophe JAILLET wrote: strtobool() is the same as kstrtobool(). However, the latter is more used within the kernel. In order to remove strtobool() and slightly simplify kstrtox.h, switch to the other function name. While at it, include the corresponding header file ()

[PATCH 28/30] x86/xen: Use kstrtobool() instead of strtobool()

2022-11-01 Thread Christophe JAILLET
strtobool() is the same as kstrtobool(). However, the latter is more used within the kernel. In order to remove strtobool() and slightly simplify kstrtox.h, switch to the other function name. While at it, include the corresponding header file () Signed-off-by: Christophe JAILLET --- This patch

Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices

2022-11-01 Thread Elliott Mitchell
On Tue, Nov 01, 2022 at 04:30:31PM +, Bertrand Marquis wrote: > > > On 1 Nov 2022, at 15:01, Elliott Mitchell wrote: > > > > On Mon, Oct 31, 2022 at 01:26:44PM +, Bertrand Marquis wrote: > >> > >>> On 30 Oct 2022, at 21:14, Stefano Stabellini > >>> wrote: > >>> > >>> Ideally this wou

[ovmf test] 174569: all pass - PUSHED

2022-11-01 Thread osstest service owner
flight 174569 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174569/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 85dba961c761021755cd2aa6bc98b8e789f751ef baseline version: ovmf 720c25ab41400f9a3dfd0

[xen-unstable-smoke test] 174567: tolerable all pass - PUSHED

2022-11-01 Thread osstest service owner
flight 174567 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174567/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist

2022-11-01 Thread Edwin Török
Pau has performed some performance tests by booting 1000 mirage unikernels test VMs and shutting them down. We've noticed on the flamegraphs that a lot of time is spent in Xenctrl `domain_getinfolist`, 17.7% of overall time (This needs to be multiplied by 16 because Dom0 100% usage = 16 vCPUs) In p

[PATCH for-4.17 v1 2/2] xenctrl: use larger chunksize in domain_getinfolist

2022-11-01 Thread Edwin Török
The support limit of XAPI is 1000, so using 1024 will very likely get everything in one go. Other code in Xen also uses chunk sizes of 256 or 1024, and would be much better than 2, especially now that list construction is more efficient. Xenopsd should also use `domain_getinfo` instead of `domain_

[PATCH for-4.17 v1 1/2] xenctrl.ml: make domain_getinfolist tail recursive

2022-11-01 Thread Edwin Török
On a host with ~1000 VMs (the support limit for XAPI) domain_getinfolist took O(n^2) time (n=number of domains). This couples with xenopsd making inefficient calls to domain_getinfolist(1 call/VM) resulted in visibly bad performance of XAPI. It was calling the Xen domainfolist hypercall N/2 times.

Re: [PATCH 01/20] tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR

2022-11-01 Thread Andrew Cooper
On 01/11/2022 15:28, Juergen Gross wrote: > XEN_LIB_STORED is serving no real purpose, as it is a mount point for > a tmpfs, so it can be replaced easily by XEN_RUN_STORED. > > XENSTORED_ROOTDIR is basically unused already, there is just a single > reference in xs_daemon_rootdir() with a fallback t

Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices

2022-11-01 Thread Bertrand Marquis
Hi Elliot, > On 1 Nov 2022, at 15:01, Elliott Mitchell wrote: > > On Mon, Oct 31, 2022 at 01:26:44PM +, Bertrand Marquis wrote: >> >>> On 30 Oct 2022, at 21:14, Stefano Stabellini wrote: >>> >>> Ideally this would be something quick that can be easily invoked as the >>> first step of an e

[PATCH 07/10] tools/xenstore: remove stale TODO file

2022-11-01 Thread Juergen Gross
The TODO file is not really helpful any longer. It contains only entries which no longer apply or it is unknown what they are meant for ("Dynamic/supply nodes", "Remove assumption that rename doesn't fail"). Signed-off-by: Juergen Gross --- tools/xenstore/TODO | 10 -- 1 file changed, 10

[PATCH 09/10] tools/xenstore: remove support of file backed data base

2022-11-01 Thread Juergen Gross
In order to prepare the replacement of TDB with direct accessible nodes in memory, remove the support for a file backed data base. This allows to remove xs_tdb_dump, too. Signed-off-by: Juergen Gross --- tools/xenstore/Makefile | 5 +- tools/xenstore/xenstored_core.c | 18 ++- tool

[PATCH 10/10] tools/xenstore: remove no longer needed functions from xs_lib.c

2022-11-01 Thread Juergen Gross
xs_daemon_tdb() in xs_lib.c is no longer used at all, so it can be removed. xs_domain_dev() is not used by xenstored, so it can be moved to tools/libs/store/xs.c. Move functions used by xenstore-client only to xenstore_client.c. Signed-off-by: Juergen Gross --- tools/libs/store/xs.c

[PATCH 08/10] tools/xenstore: remove unused events list

2022-11-01 Thread Juergen Gross
struct watch contains an used struct list_head events. Remove it. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_watch.c | 5 - 1 file changed, 5 deletions(-) diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index ca0194966e..0078c60f32 100644 ---

[PATCH 06/10] tools/xenstore: switch write limiting to use millisecond time base

2022-11-01 Thread Juergen Gross
There is no need to keep struct wrl_timestampt, as it serves the same purpose as the more simple time base provided by get_now(). Move some more stuff from xenstored_domain.h into xenstored_domain.c as it is being used nowhere else. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core

[PATCH 05/10] tools/xenstore: make some write limit functions static

2022-11-01 Thread Juergen Gross
Some wrl_*() functions are only used in xenstored_domain.c, so make them static. In order to avoid the need of forward declarations, move the whole function block to the start of the file. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 456 +++--- to

[PATCH 11/12] tools/xenstore: use generic accounting for remaining quotas

2022-11-01 Thread Juergen Gross
The maxrequests, node size, number of node permissions, and path length quota are a little bit special, as they are either active in transactions only (maxrequests), or they are just per item instead of count values. Nevertheless being able to know the maximum number of those quota related values p

[PATCH 04/10] tools/xenstore: let hashtable_insert() return 0 on success

2022-11-01 Thread Juergen Gross
Today hashtable_insert() returns 0 in case of an error. Change that to let it return an errno value in the error case and 0 in case of success. Even if not used today, do the same switch for the return value of hashtable_expand(). Signed-off-by: Juergen Gross --- tools/xenstore/hashtable.c

[PATCH 12/12] tools/xenstore: switch quota management to be table based

2022-11-01 Thread Juergen Gross
Instead of having individual quota variables switch to a table based approach like the generic accounting. Include all the related data in the same table and add accessor functions. This enables to use the command line --quota parameter for setting all possible quota values, keeping the previous p

[PATCH 03/10] tools/xenstore: modify interface of create_hashtable()

2022-11-01 Thread Juergen Gross
The minsize parameter of create_hashtable() doesn't have any real use case for Xenstore, so drop it. For better talloc_report_full() diagnostic output add a name parameter to create_hashtable(). Signed-off-by: Juergen Gross --- tools/xenstore/hashtable.c| 24 to

[PATCH 09/12] tools/xenstore: switch transaction accounting to generic accounting

2022-11-01 Thread Juergen Gross
As transaction accounting is active for unprivileged domains only, it can easily be added to the generic per-domain accounting. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c| 3 +-- tools/xenstore/xenstored_core.h| 1 - tools/xenstore/xenstored_domain.c

[PATCH 02/10] tools/xenstore: do some cleanup of hashtable.c

2022-11-01 Thread Juergen Gross
Do the following cleanups: - hashtable_count() isn't used at all, so remove it - replace prime_table_length and max_load_factor with macros - make hash() static - add a loadlimit() helper function - remove the /***/ lines between functions - do some style corrections Signed-off-by: Juergen Gross

[PATCH 08/12] tools/xenstore: add TDB access trace support

2022-11-01 Thread Juergen Gross
Add a new trace switch "tdb" and the related trace calls. The "tdb" switch is off per default. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c| 8 +++- tools/xenstore/xenstored_core.h| 6 ++ tools/xenstore/xenstored_transaction.c | 7 ++- 3 files cha

[PATCH 00/10] tools/xenstore: more cleanups

2022-11-01 Thread Juergen Gross
Some more cleanups of Xenstore. Based on top of the previous 2 Xenstore series "tools/xenstore: do some cleanup and fixes" and the accounting rework series (sorry for the cut off series header). Juergen Gross (10): tools/xenstore: verify command line parameters better tools/xenstore: do some

[PATCH 10/12] tools/xenstore: remember global and per domain max accounting values

2022-11-01 Thread Juergen Gross
Add saving the maximum values of the different accounting data seen per domain and (for unprivileged domains) globally, and print those values via the xenstore-control quota command. Add a sub-command for resetting the global maximum values seen. This should help for a decision how to set the rela

[PATCH 01/10] tools/xenstore: verify command line parameters better

2022-11-01 Thread Juergen Gross
Add some more verification of command line parameters. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index ae1ea29b80..714

[PATCH 07/12] tools/xenstore: add accounting trace support

2022-11-01 Thread Juergen Gross
Add a new trace switch "acc" and the related trace calls. The "acc" switch is off per default. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 2 +- tools/xenstore/xenstored_core.h | 1 + tools/xenstore/xenstored_domain.c | 10 ++ 3 files changed, 12 insertions(

[PATCH 05/12] tools/xenstore: add current connection to domain_memory_add() parameters

2022-11-01 Thread Juergen Gross
In order to enable switching memory accounting to the generic array based accounting, add the current connection to the parameters of domain_memory_add(). This requires to add the connection to some other functions, too. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 28 ++

[PATCH 06/12] tools/xenstore: use accounting data array for per-domain values

2022-11-01 Thread Juergen Gross
Add the accounting of per-domain usage of Xenstore memory, watches, and outstanding requests to the array based mechanism. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 8 +-- tools/xenstore/xenstored_domain.c | 111 +++--- tools/xenstore/xenstore

[PATCH 04/12] tools/xenstore: use accounting buffering for node accounting

2022-11-01 Thread Juergen Gross
Add the node accounting to the accounting information buffering in order to avoid having to undo it in case of failure. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 21 ++--- tools/xenstore/xenstored_domain.h | 4 ++-- 2 files changed, 4 insertions(+), 21

[PATCH 02/12] tools/xenstore: introduce accounting data array for per-domain values

2022-11-01 Thread Juergen Gross
Introduce the scheme of an accounting data array for per-domain accounting data and use it initially for the number of nodes owned by a domain. Make the accounting data type to be unsigned int, as no data is allowed to be negative at any time. Signed-off-by: Juergen Gross --- tools/xenstore/xen

[PATCH 03/12] tools/xenstore: add framework to commit accounting data on success only

2022-11-01 Thread Juergen Gross
Instead of modifying accounting data and undo those modifications in case of an error during further processing, add a framework for collecting the needed changes and commit them only when the whole operation has succeeded. This scheme can reuse large parts of the per transaction accounting. The c

[PATCH 01/12] tools/xenstore: manage per-transaction domain accounting data in an array

2022-11-01 Thread Juergen Gross
In order to prepare keeping accounting data in an array instead of using independent fields, switch the struct changed_domain accounting data to that scheme, for now only using an array with one element. In order to be able to extend this scheme add the needed indexing enum to xenstored_domain.h.

[PATCH 00/12] tools/xenstore

2022-11-01 Thread Juergen Gross
This series reworks the Xenstore internal accounting to use a uniform generic framework. It is adding some additional useful diagnostic information, like accounting trace and max. per-domain and global quota values seen. This series is based on top of the series "tools/xenstore: do some cleanup an

[PATCH 17/20] tools/xenstore: switch hashtable to use the talloc framework

2022-11-01 Thread Juergen Gross
Instead of using malloc() and friends, let the hashtable implementation use the talloc framework. Signed-off-by: Juergen Gross --- tools/xenstore/hashtable.c| 86 --- tools/xenstore/hashtable.h| 3 +- tools/xenstore/xenstored_core.c | 5 +- tools/x

[PATCH 09/20] tools/xenstore: introduce dummy nodes for special watch paths

2022-11-01 Thread Juergen Gross
Instead of special casing the permission handling and watch event firing for the special watch paths "@introduceDomain" and "@releaseDomain", use static dummy nodes added to the data base when starting Xenstore. This allows to simplify quite some code. Note that this requires to rework the calls

[PATCH 11/20] tools/xenstore: move changed domain handling

2022-11-01 Thread Juergen Gross
Move all code related to struct changed_domain from xenstored_transaction.c to xenstored_domain.c. This will be needed later in order to simplify the accounting data updates in cases of errors during a request. Split the code to have a more generic base framework. Signed-off-by: Juergen Gross -

[PATCH 16/20] tools/xenstore: let chk_domain_generation() return a bool

2022-11-01 Thread Juergen Gross
Instead of returning 0 or 1 let chk_domain_generation() return a boolean value. Simplify the only caller by removing the ret variable. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/tools

[PATCH 07/20] tools/xenstore: enhance hashtable implementation

2022-11-01 Thread Juergen Gross
Today it is possible to set a flag when calling hashtable_destroy() in order to specify whether the data associated with the hashtable entries should be freed or not. The keys of the entries will always be freed. Change that by replacing the flag of hashtable_destroy() by two flags for create_hash

[PATCH 19/20] tools/xenstore: introduce trace classes

2022-11-01 Thread Juergen Gross
Make the xenstored internal trace configurable by adding classes which can be switched on and off independently from each other. Define the following classes: - obj: Creation and deletion of interesting "objects" (watch, transaction, connection) - io: incoming requests and outgoing responses -

[PATCH 15/20] tools/xenstore: make domain_is_unprivileged() an inline function

2022-11-01 Thread Juergen Gross
clang is complaining about a NULL dereference for constructs like: domain_is_unprivileged(conn) ? conn->in : NULL as it can't know that domain_is_unprivileged(conn) will return false if conn is NULL. Fix that by making domain_is_unprivileged() an inline function (and related to that domid_is_u

[PATCH 13/20] tools/xenstore: don't allow creating too many nodes in a transaction

2022-11-01 Thread Juergen Gross
The accounting for the number of nodes of a domain in an active transaction is not working correctly, as it allows to create arbitrary number of nodes. The transaction will finally fail due to exceeding the number of nodes quota, but before closing the transaction an unprivileged guest could cause

[PATCH 20/20] tools/xenstore: let check_store() check the accounting data

2022-11-01 Thread Juergen Gross
Today check_store() is only testing the correctness of the node tree. Add verification of the accounting data (number of nodes) and correct the data if it is wrong. Do the initial check_store() call only after Xenstore entries of a live update have been read. Signed-off-by: Juergen Gross ---

[PATCH 18/20] tools/xenstore: make log macro globally available

2022-11-01 Thread Juergen Gross
Move the definition of the log() macro to xenstored_core.h in order to make it usable from other source files, too. While at it preserve errno from being modified. Signed-off-by: Juergen Gross --- V2: - preserve errno (Julien Grall) --- tools/xenstore/xenstored_core.c | 14 -- tools

[PATCH 12/20] tools/xenstore: change per-domain node accounting interface

2022-11-01 Thread Juergen Gross
Rework the interface and the internals of the per-domain node accounting: - rename the functions to domain_nbentry_*() in order to better match the related counter name - switch from node pointer to domid as interface, as all nodes have the owner filled in - use a common internal function fo

[PATCH 10/20] tools/xenstore: replace watch->relative_path with a prefix length

2022-11-01 Thread Juergen Gross
Instead of storing a pointer to the path which is prepended to relative paths in struct watch, just use the length of the prepended path. It should be noted that the now removed special case of the relative path being "" in get_watch_path() can't happen at all. Signed-off-by: Juergen Gross ---

[PATCH 14/20] tools/xenstore: replace literal domid 0 with dom0_domid

2022-11-01 Thread Juergen Gross
There are some places left where dom0 is associated with domid 0. Use dom0_domid instead. Signed-off-by: Juergen Gross --- V2: - new patch --- tools/xenstore/xenstored_core.c | 5 +++-- tools/xenstore/xenstored_domain.c | 8 2 files changed, 7 insertions(+), 6 deletions(-) diff --gi

[PATCH 08/20] tools/xenstore: add hashlist for finding struct domain by domid

2022-11-01 Thread Juergen Gross
Today finding a struct domain by its domain id requires to scan the list of domains until finding the correct domid. Add a hashlist for being able to speed this up. This allows to remove the linking of struct domain in a list. Note that the list of changed domains per transaction is kept as a list

[PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped

2022-11-01 Thread Juergen Gross
When a domain has been recognized to have stopped, remove all its registered watches. This avoids sending watch events to the dead domain when all the nodes related to it are being removed by the Xen tools. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 6 ++ 1 file cha

[PATCH 04/20] tools/xenstore: let tdb_logger() preserve errno

2022-11-01 Thread Juergen Gross
tdb_logger() is called by TDB for logging errors. As errno is checked often after doing the logging, tdb_logger() should preserve errno. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/xenstore/xenstored_core.c b/tools

[PATCH 05/20] tools/xenstore: preserve errno across corrupt()

2022-11-01 Thread Juergen Gross
Let corrupt() preserve errno in order to be able to simplify error handling in future. This is rather easy as the errno value when entering corrupt() is saved already. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/xe

[PATCH 02/20] tools/xenstore: call remove_domid_from_perm() for special nodes

2022-11-01 Thread Juergen Gross
When destroying a domain, any stale permissions of the domain must be removed from the special nodes "@...", too. This was not done in the fix for XSA-322. Fixes: 496306324d8d ("tools/xenstore: revoke access rights for removed domains") Signed-off-by: Juergen Gross Reviewed-by: Julien Grall ---

[PATCH 01/20] tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR

2022-11-01 Thread Juergen Gross
XEN_LIB_STORED is serving no real purpose, as it is a mount point for a tmpfs, so it can be replaced easily by XEN_RUN_STORED. XENSTORED_ROOTDIR is basically unused already, there is just a single reference in xs_daemon_rootdir() with a fallback to XEN_LIB_STORED, and a .gdbinit file setting it.

[PATCH 03/20] tools/xenstore: let talloc_free() preserve errno

2022-11-01 Thread Juergen Gross
Today talloc_free() is not guaranteed to preserve errno, especially in case a custom destructor is being used. Change that by renaming talloc_free() to _talloc_free() in talloc.c and adding a wrapper to talloc.c. This allows to remove some errno saving outside of talloc.c. Signed-off-by: Juergen

[PATCH 00/20] tools/xenstore: do some cleanup and fixes

2022-11-01 Thread Juergen Gross
This is a first run of post-XSA patches which piled up during the development phase of all the recent Xenstore related XSA patches. At least the first 7 patches are completely independent from each other. After those the dependencies are starting to be more complex. This is a mixture of small fix

Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices

2022-11-01 Thread Elliott Mitchell
On Mon, Oct 31, 2022 at 01:26:44PM +, Bertrand Marquis wrote: > > > On 30 Oct 2022, at 21:14, Stefano Stabellini wrote: > > > > Ideally this would be something quick that can be easily invoked as the > > first step of an external third-party build process. > > I think that we are making thi

Re: [XEN v2 10/12] xen/Arm: GICv3: Use ULL instead of UL for 64bits

2022-11-01 Thread Ayan Kumar Halder
On 01/11/2022 10:03, Xenia Ragiadakou wrote: Hi Ayan, Hi Xenia, On 10/31/22 17:13, Ayan Kumar Halder wrote: "unsigned long long" is defined as 64 bits on AArch64 and AArch32 Thus, one should this instead of "unsigned long" which is 32 bits on AArch32. Also use 'PRIx64' instead of 'lx' or '

Re: [XEN v2 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit

2022-11-01 Thread Xenia Ragiadakou
On 11/1/22 13:57, Julien Grall wrote: Hi Ayan, On 01/11/2022 10:59, Ayan Kumar Halder wrote: On 01/11/2022 09:50, Julien Grall wrote: Hi, Hi Xenia, Julien, I have few clarifications. On 01/11/2022 07:08, Xenia Ragiadakou wrote: On 10/31/22 17:13, Ayan Kumar Halder wrote: Defined read

[linux-linus test] 174564: regressions - FAIL

2022-11-01 Thread osstest service owner
flight 174564 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174564/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl

[ovmf test] 174565: all pass - PUSHED

2022-11-01 Thread osstest service owner
flight 174565 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174565/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 720c25ab41400f9a3dfd0742da5a6d237991df5b baseline version: ovmf df7ce74e6c75e19a528d5

Xen Security Advisory 421 v2 (CVE-2022-42325,CVE-2022-42326) - Xenstore: Guests can create arbitrary number of nodes via transactions

2022-11-01 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2022-42325,CVE-2022-42326 / XSA-421 version 2 Xenstore: Guests can create arbitrary number of nodes via transactions UPDATES IN VERSION 2 Fix typo in title. Publi

Xen Security Advisory 420 v2 (CVE-2022-42324) - Oxenstored 32->31 bit integer truncation issues

2022-11-01 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2022-42324 / XSA-420 version 2 Oxenstored 32->31 bit integer truncation issues UPDATES IN VERSION 2 Public release. ISSUE DESCRIPTION ==

Xen Security Advisory 419 v2 (CVE-2022-42322,CVE-2022-42323) - Xenstore: Cooperating guests can create arbitrary numbers of nodes

2022-11-01 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2022-42322,CVE-2022-42323 / XSA-419 version 2 Xenstore: Cooperating guests can create arbitrary numbers of nodes UPDATES IN VERSION 2 Public release. ISSUE DESC

Xen Security Advisory 412 v2 (CVE-2022-42327) - x86: unintended memory sharing between guests

2022-11-01 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2022-42327 / XSA-412 version 2 x86: unintended memory sharing between guests UPDATES IN VERSION 2 Public release. ISSUE DESCRIPTION =

Xen Security Advisory 415 v2 (CVE-2022-42310) - Xenstore: Guests can create orphaned Xenstore nodes

2022-11-01 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2022-42310 / XSA-415 version 2 Xenstore: Guests can create orphaned Xenstore nodes UPDATES IN VERSION 2 Public release. ISSUE DESCRIPTION

Xen Security Advisory 414 v2 (CVE-2022-42309) - Xenstore: Guests can crash xenstored

2022-11-01 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2022-42309 / XSA-414 version 2 Xenstore: Guests can crash xenstored UPDATES IN VERSION 2 Public release. ISSUE DESCRIPTION

Xen Security Advisory 417 v2 (CVE-2022-42320) - Xenstore: Guests can get access to Xenstore nodes of deleted domains

2022-11-01 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2022-42320 / XSA-417 version 2 Xenstore: Guests can get access to Xenstore nodes of deleted domains UPDATES IN VERSION 2 Public release. ISSUE DESCRIPTION

Re: [XEN v2 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit

2022-11-01 Thread Julien Grall
Hi Ayan, On 01/11/2022 10:59, Ayan Kumar Halder wrote: On 01/11/2022 09:50, Julien Grall wrote: Hi, Hi Xenia, Julien, I have few clarifications. On 01/11/2022 07:08, Xenia Ragiadakou wrote: On 10/31/22 17:13, Ayan Kumar Halder wrote: Defined readq_relaxed()/writeq_relaxed() to read and

Re: [XEN v2 02/12] xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32

2022-11-01 Thread Ayan Kumar Halder
On 01/11/2022 08:58, Michal Orzel wrote: On 31/10/2022 18:53, Michal Orzel wrote: Hi Ayan, Hi Michal, On 31/10/2022 16:13, Ayan Kumar Halder wrote: Refer https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.1-rc1%2Fsource%2Farch%2Farm64%2F&d

Re: [PATCH v1 09/12] accel/xen/xen-all: export xenstore_record_dm_state

2022-11-01 Thread Alex Bennée
"Garhwal, Vikram" writes: > Thanks, Alex, for reviewing this one. I built for all the archs and it was > fine. Can you please share more about what > environment builds are breaking? So, I can test the changes for v2. My cross build environment failed: ../../configure' '--disable-docs' '--

Re: [XEN v2 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit

2022-11-01 Thread Ayan Kumar Halder
On 01/11/2022 09:50, Julien Grall wrote: Hi, Hi Xenia, Julien, I have few clarifications. On 01/11/2022 07:08, Xenia Ragiadakou wrote: On 10/31/22 17:13, Ayan Kumar Halder wrote: Defined readq_relaxed()/writeq_relaxed() to read and write 64 bit regs. This uses ldrd/strd instructions. S

Re: [XEN v2 10/12] xen/Arm: GICv3: Use ULL instead of UL for 64bits

2022-11-01 Thread Xenia Ragiadakou
Hi Ayan, On 10/31/22 17:13, Ayan Kumar Halder wrote: "unsigned long long" is defined as 64 bits on AArch64 and AArch32 Thus, one should this instead of "unsigned long" which is 32 bits on AArch32. Also use 'PRIx64' instead of 'lx' or 'llx' to print uint64_t. Signed-off-by: Ayan Kumar Halder -

[xen-unstable test] 174563: tolerable FAIL

2022-11-01 Thread osstest service owner
flight 174563 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174563/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 174547 test-amd64-i386-xl-qemuu-win7-amd64

Re: [XEN v2 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit

2022-11-01 Thread Julien Grall
Hi, On 01/11/2022 07:08, Xenia Ragiadakou wrote: On 10/31/22 17:13, Ayan Kumar Halder wrote: Defined readq_relaxed()/writeq_relaxed() to read and write 64 bit regs. This uses ldrd/strd instructions. Signed-off-by: Ayan Kumar Halder --- Changes from :- v1 - 1. Use ldrd/strd for readq_relaxed(

Re: [XEN v2 02/12] xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32

2022-11-01 Thread Michal Orzel
On 31/10/2022 18:53, Michal Orzel wrote: > > > Hi Ayan, > > On 31/10/2022 16:13, Ayan Kumar Halder wrote: >> >> >> Refer >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.1-rc1%2Fsource%2Farch%2Farm64%2F&data=05%7C01%7Cmichal.orzel%40amd.com

Re: [linux-linus test] 174539: regressions - FAIL

2022-11-01 Thread Juergen Gross
On 29.10.22 23:50, osstest service owner wrote: flight 174539 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174539/ Regressions :-( I'm rather sure this is not kernel related, as the issue is occurring only on Arm and it doesn't seem to be an architecture related iss

Re: [XEN v2 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit

2022-11-01 Thread Xenia Ragiadakou
Hi Ayan, On 10/31/22 17:13, Ayan Kumar Halder wrote: Defined readq_relaxed()/writeq_relaxed() to read and write 64 bit regs. This uses ldrd/strd instructions. Signed-off-by: Ayan Kumar Halder --- Changes from :- v1 - 1. Use ldrd/strd for readq_relaxed()/writeq_relaxed(). 2. No need to use le6