Re: [RFC PATCH 04/10] xen: add reference counter support

2023-02-16 Thread Jan Beulich
On 17.02.2023 02:56, Volodymyr Babchuk wrote: > Jan Beulich writes: >> On 31.08.2022 16:10, Volodymyr Babchuk wrote: >>> --- /dev/null >>> +++ b/xen/include/xen/refcnt.h >>> @@ -0,0 +1,28 @@ >>> +#ifndef __XEN_REFCNT_H__ >>> +#define __XEN_REFCNT_H__ >>> + >>> +#include >>> + >>> +typedef

Re: [RFC PATCH 03/10] xen: pci: introduce ats_list_lock

2023-02-16 Thread Jan Beulich
On 17.02.2023 02:20, Volodymyr Babchuk wrote: > Jan Beulich writes: >> On 27.01.2023 00:56, Stefano Stabellini wrote: >>> On Wed, 31 Aug 2022, Volodymyr Babchuk wrote: --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -1641,6 +1641,7 @@ void

Re: [PATCH] xen: Remove the use of K functions

2023-02-16 Thread Jan Beulich
On 17.02.2023 00:17, Andrew Cooper wrote: > On 16/02/2023 11:02 pm, Andrew Cooper wrote: >> On 16/02/2023 10:44 pm, Andrew Cooper wrote: >>> Clang-15 (as seen in the FreeBSD 14 tests) complains: >>> >>> arch/x86/time.c:1364:20: error: a function declaration without a >>> prototype is

Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json

2023-02-16 Thread Jan Beulich
On 17.02.2023 02:44, Stefano Stabellini wrote: > On Thu, 16 Feb 2023, Luca Fancellu wrote: >>> On 16 Feb 2023, at 08:19, Jan Beulich wrote: >>> On 16.02.2023 00:49, Stefano Stabellini wrote: On Wed, 15 Feb 2023, Julien Grall wrote: > On 14/02/2023 22:25, Stefano Stabellini wrote: >>>

Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-02-16 Thread Jan Beulich
On 16.02.2023 21:44, Oleksii wrote: > On Thu, 2023-02-16 at 12:19 +, Andrew Cooper wrote: >> On 16/02/2023 12:09 pm, Oleksii wrote: >>> On Thu, 2023-02-16 at 12:44 +0200, Oleksii wrote: On Thu, 2023-02-16 at 08:31 +0100, Jan Beulich wrote: > On 15.02.2023 18:59, Oleksii wrote: >>

[linux-linus test] 177531: tolerable trouble: fail/pass/starved - PUSHED

2023-02-16 Thread osstest service owner
flight 177531 linux-linus real [real] flight 177568 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177531/ http://logs.test-lab.xenproject.org/osstest/logs/177568/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [RFC PATCH 04/10] xen: add reference counter support

2023-02-16 Thread Volodymyr Babchuk
Hello Jan, Jan Beulich writes: > On 31.08.2022 16:10, Volodymyr Babchuk wrote: >> --- /dev/null >> +++ b/xen/include/xen/refcnt.h >> @@ -0,0 +1,28 @@ >> +#ifndef __XEN_REFCNT_H__ >> +#define __XEN_REFCNT_H__ >> + >> +#include >> + >> +typedef atomic_t refcnt_t; > > Like Linux has it, I think

Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json

2023-02-16 Thread Stefano Stabellini
On Thu, 16 Feb 2023, Luca Fancellu wrote: > > On 16 Feb 2023, at 08:19, Jan Beulich wrote: > > On 16.02.2023 00:49, Stefano Stabellini wrote: > >> On Wed, 15 Feb 2023, Julien Grall wrote: > >>> On 14/02/2023 22:25, Stefano Stabellini wrote: > > Patch 1's example has a "comment" field, which

[xen-unstable-smoke test] 177547: tolerable trouble: pass/starved - PUSHED

2023-02-16 Thread osstest service owner
flight 177547 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177547/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [RFC PATCH 03/10] xen: pci: introduce ats_list_lock

2023-02-16 Thread Volodymyr Babchuk
Hello Jan, Jan Beulich writes: > On 27.01.2023 00:56, Stefano Stabellini wrote: >> On Wed, 31 Aug 2022, Volodymyr Babchuk wrote: >>> --- a/xen/drivers/passthrough/pci.c >>> +++ b/xen/drivers/passthrough/pci.c >>> @@ -1641,6 +1641,7 @@ void iommu_dev_iotlb_flush_timeout(struct domain *d, >>>

[PATCH RFC] xen: Work around Clang-IAS macro expansion bug.

2023-02-16 Thread Andrew Cooper
https://github.com/llvm/llvm-project/issues/60792 RFC. I very much dislike this patch, but it does work for me. Why the parameter name of foo? Turns out I found a different Clang-IAS bug/misfeature when trying to name the parameter uniq. In file included from arch/x86/asm-macros.c:3:

Re: [PATCH] xen: Remove the use of K functions

2023-02-16 Thread Andrew Cooper
On 16/02/2023 11:02 pm, Andrew Cooper wrote: > On 16/02/2023 10:44 pm, Andrew Cooper wrote: >> Clang-15 (as seen in the FreeBSD 14 tests) complains: >> >> arch/x86/time.c:1364:20: error: a function declaration without a >> prototype is deprecated in all versions of C

[PATCH] tools: Remove the use of K functions

2023-02-16 Thread Andrew Cooper
Clang-15 (as seen in the FreeBSD 14 tests) complains: xg_main.c:1248 error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] xg_init() ^ void The error message is a bit confusing but appears to new as part of

[xen-unstable-smoke test] 177537: tolerable trouble: pass/starved - PUSHED

2023-02-16 Thread osstest service owner
flight 177537 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177537/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH] xen: Remove the use of K functions

2023-02-16 Thread Andrew Cooper
On 16/02/2023 10:44 pm, Andrew Cooper wrote: > Clang-15 (as seen in the FreeBSD 14 tests) complains: > > arch/x86/time.c:1364:20: error: a function declaration without a > prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] > s_time_t get_s_time() >

[PATCH] xen: Remove the use of K functions

2023-02-16 Thread Andrew Cooper
Clang-15 (as seen in the FreeBSD 14 tests) complains: arch/x86/time.c:1364:20: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] s_time_t get_s_time() ^ void The error message is a

Re: [XEN v6 2/2] xen/arm: domain_build: Use pfn start and end address for rangeset_{xxx}_range()

2023-02-16 Thread Julien Grall
Hi Ayan, The title is a bit strange to read as a 'pfn' is not an address. So how about: xen/arm: domain_build: Track unallocated pages using the frame number On 13/02/2023 12:44, Ayan Kumar Halder wrote: rangeset_{xxx}_range() functions are invoked with 'start' and 'size' as arguments which

[xen-unstable test] 177485: regressions - trouble: broken/fail/pass/starved

2023-02-16 Thread osstest service owner
flight 177485 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/177485/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-livepatch broken test-amd64-amd64-livepatch5

[ovmf test] 177524: all pass - PUSHED

2023-02-16 Thread osstest service owner
flight 177524 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/177524/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 02fcfdce1e5ce86f1951191883e7e30de5aa08be baseline version: ovmf

Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-02-16 Thread Oleksii
On Thu, 2023-02-16 at 12:19 +, Andrew Cooper wrote: > On 16/02/2023 12:09 pm, Oleksii wrote: > > On Thu, 2023-02-16 at 12:44 +0200, Oleksii wrote: > > > On Thu, 2023-02-16 at 08:31 +0100, Jan Beulich wrote: > > > > On 15.02.2023 18:59, Oleksii wrote: > > > > > Hello Jan and community, > > > >

Re: [XEN PATCH 3/4] automation: Remove expired root certificates used to be used by let's encrypt

2023-02-16 Thread Stefano Stabellini
On Thu, 16 Feb 2023, Anthony PERARD wrote: > On Wed, Feb 15, 2023 at 04:14:53PM -0800, Stefano Stabellini wrote: > > On Wed, 15 Feb 2023, Andrew Cooper wrote: > > > Honestly, I think I'd prefer to drop all of these legacy versions... > > > > Good timing! It just so happens that we need to shave

Re: [PATCH 4/6] x86/MSI: use standard C types in structures/unions

2023-02-16 Thread Andrew Cooper
On 16/02/2023 2:16 pm, Jan Beulich wrote: > On 16.02.2023 11:55, Andrew Cooper wrote: >> On 09/02/2023 10:39 am, Jan Beulich wrote: >>> Consolidate this to use exclusively standard types, and change >>> indentation style to Xen's there at the same time (the file already had >>> a mix of styles).

Xen Security Advisory 426 v2 (CVE-2022-27672) - x86: Cross-Thread Return Address Predictions

2023-02-16 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2022-27672 / XSA-426 version 2 x86: Cross-Thread Return Address Predictions UPDATES IN VERSION 2 Xen 4.16 is vulnerable too. The previous

Re: [XEN PATCH v2] libs: Fix unstable libs build on FreeBSD, auto-generate version-script

2023-02-16 Thread Andrew Cooper
On 16/02/2023 4:55 pm, Anthony PERARD wrote: > On Thu, Feb 16, 2023 at 04:50:09PM +, Andrew Cooper wrote: >> On 16/02/2023 2:10 pm, Anthony PERARD wrote: >>> diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk >>> index 0e4b5e0bd0..ffb6c9f064 100644 >>> --- a/tools/libs/libs.mk >>> +++

Re: [XEN PATCH v2] libs: Fix unstable libs build on FreeBSD, auto-generate version-script

2023-02-16 Thread Anthony PERARD
On Thu, Feb 16, 2023 at 04:50:09PM +, Andrew Cooper wrote: > On 16/02/2023 2:10 pm, Anthony PERARD wrote: > > diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk > > index 0e4b5e0bd0..ffb6c9f064 100644 > > --- a/tools/libs/libs.mk > > +++ b/tools/libs/libs.mk > > @@ -120,7 +127,7 @@ TAGS: > >

Re: [XEN PATCH v2] libs: Fix unstable libs build on FreeBSD, auto-generate version-script

2023-02-16 Thread Jan Beulich
On 16.02.2023 17:50, Andrew Cooper wrote: > On 16/02/2023 2:10 pm, Anthony PERARD wrote: >> diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk >> index 0e4b5e0bd0..ffb6c9f064 100644 >> --- a/tools/libs/libs.mk >> +++ b/tools/libs/libs.mk >> @@ -120,7 +127,7 @@ TAGS: >> clean:: >> rm -rf

Re: [XEN PATCH v2] libs: Fix unstable libs build on FreeBSD, auto-generate version-script

2023-02-16 Thread Andrew Cooper
On 16/02/2023 2:10 pm, Anthony PERARD wrote: > diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk > index 0e4b5e0bd0..ffb6c9f064 100644 > --- a/tools/libs/libs.mk > +++ b/tools/libs/libs.mk > @@ -120,7 +127,7 @@ TAGS: > clean:: > rm -rf $(TARGETS) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS) >

[libvirt test] 177457: tolerable trouble: fail/pass/starved - PUSHED

2023-02-16 Thread osstest service owner
flight 177457 libvirt real [real] flight 177511 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177457/ http://logs.test-lab.xenproject.org/osstest/logs/177511/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-16 Thread Tamas K Lengyel
On Thu, Feb 16, 2023 at 10:24 AM Jan Beulich wrote: > > On 16.02.2023 16:10, Tamas K Lengyel wrote: > > On Thu, Feb 16, 2023 at 9:27 AM Jan Beulich wrote: > >> > >> On 16.02.2023 13:22, Tamas K Lengyel wrote: > >>> On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: > > On 15.02.2023

Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-16 Thread Jan Beulich
On 16.02.2023 16:10, Tamas K Lengyel wrote: > On Thu, Feb 16, 2023 at 9:27 AM Jan Beulich wrote: >> >> On 16.02.2023 13:22, Tamas K Lengyel wrote: >>> On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: On 15.02.2023 17:29, Tamas K Lengyel wrote: > On Wed, Feb 15, 2023 at 5:27 AM

[linux-linus test] 177451: tolerable trouble: fail/pass/starved - PUSHED

2023-02-16 Thread osstest service owner
flight 177451 linux-linus real [real] flight 177502 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177451/ http://logs.test-lab.xenproject.org/osstest/logs/177502/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-16 Thread Jan Beulich
On 16.02.2023 16:07, Matias Ezequiel Vara Larsen wrote: > On Wed, Dec 14, 2022 at 08:29:53AM +0100, Jan Beulich wrote: >> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: >>> @@ -287,6 +289,20 @@ static inline void vcpu_runstate_change( >>> } >>> >>> v->runstate.state =

Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-16 Thread Tamas K Lengyel
On Thu, Feb 16, 2023 at 9:27 AM Jan Beulich wrote: > > On 16.02.2023 13:22, Tamas K Lengyel wrote: > > On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: > >> > >> On 15.02.2023 17:29, Tamas K Lengyel wrote: > >>> On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: > Did you consider the

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-16 Thread Jan Beulich
On 16.02.2023 15:48, Matias Ezequiel Vara Larsen wrote: > On Tue, Dec 13, 2022 at 06:02:55PM +0100, Jan Beulich wrote: >> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: >>> This commit proposes a new mechanism to query the RUNSTATE_running counter >>> for >>> a given vcpu from a dom0

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-16 Thread Matias Ezequiel Vara Larsen
On Wed, Dec 14, 2022 at 08:29:53AM +0100, Jan Beulich wrote: > On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > > --- a/xen/common/memory.c > > +++ b/xen/common/memory.c > > @@ -1078,6 +1078,12 @@ unsigned int ioreq_server_max_frames(const struct > > domain *d) > > return nr; > >

Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-02-16 Thread Jan Beulich
On 16.02.2023 11:44, Oleksii wrote: > On Thu, 2023-02-16 at 08:31 +0100, Jan Beulich wrote: >> On 15.02.2023 18:59, Oleksii wrote: >>> The only thing I am worried about is: >>> >>> #define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ >>>   [bf_type] "i" (type), ... >>> because as I understand it can

Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-02-16 Thread Jan Beulich
On 16.02.2023 11:48, Andrew Cooper wrote: > On 16/02/2023 7:31 am, Jan Beulich wrote: >> On 15.02.2023 18:59, Oleksii wrote: >>> Hello Jan and community, >>> >>> I experimented and switched RISC-V to x86 implementation. All that I >>> changed in x86 implementation for RISC-V was

Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type

2023-02-16 Thread Matias Ezequiel Vara Larsen
Hello Jan and thanks for your comments. I addressed most of the them but I've still some questions. Please find my questions below: On Tue, Dec 13, 2022 at 06:02:55PM +0100, Jan Beulich wrote: > On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > > This commit proposes a new mechanism to

Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-16 Thread Jan Beulich
On 16.02.2023 13:22, Tamas K Lengyel wrote: > On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: >> >> On 15.02.2023 17:29, Tamas K Lengyel wrote: >>> On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: Did you consider the alternative of adjusting the ASSERT() in question instead? It

Re: [PATCH 4/6] x86/MSI: use standard C types in structures/unions

2023-02-16 Thread Jan Beulich
On 16.02.2023 11:55, Andrew Cooper wrote: > On 09/02/2023 10:39 am, Jan Beulich wrote: >> Consolidate this to use exclusively standard types, and change >> indentation style to Xen's there at the same time (the file already had >> a mix of styles). >> >> No functional change intended. >> >>

[XEN PATCH v2] libs: Fix unstable libs build on FreeBSD, auto-generate version-script

2023-02-16 Thread Anthony PERARD
Unfortunatly, --default-symver doesn't work with LLVM's LD, LLD. Instead, we will generate a temporary version-script. In order to allow regenerating the script, we'll have a different filename. In order to check if the content is up-to-date, we'll always generated it and compare. Reported-by:

Re: [PATCH] x86/Xen: drop leftover VM-assist uses

2023-02-16 Thread Andrew Cooper
On 15/02/2023 11:27 am, Jan Beulich wrote: > Both the 4Gb-segments and the PAE-extended-CR3 one are applicable to > 32-bit guests only. The PAE-extended-CR3 use, furthermore, was redundant > with the PAE_MODE ELF note anyway. > > Signed-off-by: Jan Beulich > > --- a/arch/x86/xen/setup.c > +++

Re: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback

2023-02-16 Thread Andrew Cooper
On 16/02/2023 1:36 pm, Xenia Ragiadakou wrote: > Hi Andrew, > > On 2/16/23 12:28, Andrew Cooper wrote: >> On 13/02/2023 11:50 am, Xenia Ragiadakou wrote: >>> diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h >>> b/xen/arch/x86/include/asm/hvm/vmx/vmx.h >>> index 234da4a7f4..97d6b810ec 100644 >>>

Re: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback

2023-02-16 Thread Xenia Ragiadakou
Hi Andrew, On 2/16/23 12:28, Andrew Cooper wrote: On 13/02/2023 11:50 am, Xenia Ragiadakou wrote: diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 234da4a7f4..97d6b810ec 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++

Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-16 Thread Tamas K Lengyel
On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: > > On 15.02.2023 17:29, Tamas K Lengyel wrote: > > On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: > >> Did you consider the alternative of adjusting the ASSERT() in question > >> instead? It could reasonably become > >> > >> #ifdef

Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-02-16 Thread Oleksii
On Thu, 2023-02-16 at 10:48 +, Andrew Cooper wrote: > On 16/02/2023 7:31 am, Jan Beulich wrote: > > On 15.02.2023 18:59, Oleksii wrote: > > > Hello Jan and community, > > > > > > I experimented and switched RISC-V to x86 implementation. All > > > that I > > > changed in x86 implementation for

Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-02-16 Thread Andrew Cooper
On 16/02/2023 12:09 pm, Oleksii wrote: > On Thu, 2023-02-16 at 12:44 +0200, Oleksii wrote: >> On Thu, 2023-02-16 at 08:31 +0100, Jan Beulich wrote: >>> On 15.02.2023 18:59, Oleksii wrote: Hello Jan and community, I experimented and switched RISC-V to x86 implementation. All

[xen-unstable-smoke test] 177483: tolerable trouble: pass/starved - PUSHED

2023-02-16 Thread osstest service owner
flight 177483 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177483/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH 6/6] common: __u8 is history

2023-02-16 Thread Andrew Cooper
On 09/02/2023 10:43 am, Jan Beulich wrote: > With the last uses gone, move the type to linux-compat.h. > > No functional change intended. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper

Re: [PATCH 5/6] x86: use standard C types in struct cpuinfo_x86

2023-02-16 Thread Andrew Cooper
On 09/02/2023 10:42 am, Jan Beulich wrote: > Consolidate this to use exclusively standard types, and change oprofile > code (apparently trying to mirror those types) at the same time. Where > sensible actually drop local variables. > > No functional change intended. > > Signed-off-by: Jan Beulich

Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-02-16 Thread Oleksii
On Thu, 2023-02-16 at 12:44 +0200, Oleksii wrote: > On Thu, 2023-02-16 at 08:31 +0100, Jan Beulich wrote: > > On 15.02.2023 18:59, Oleksii wrote: > > > Hello Jan and community, > > > > > > I experimented and switched RISC-V to x86 implementation. All > > > that > > > I > > > changed in x86

Re: [Discussion] Xen grants and access permissions

2023-02-16 Thread Andrew Cooper
On 16/02/2023 11:13 am, Viresh Kumar wrote: > Hi Oleksandr, > > As you already know, I am looking at how we can integrate the Xen > grants work in our implementation of Rust based Xen vhost frontend [1]. > > The hypervisor independent vhost-user backends [2] talk to > xen-vhost-frontend using the

Re: [XEN PATCH 3/4] automation: Remove expired root certificates used to be used by let's encrypt

2023-02-16 Thread Anthony PERARD
On Wed, Feb 15, 2023 at 04:14:53PM -0800, Stefano Stabellini wrote: > On Wed, 15 Feb 2023, Andrew Cooper wrote: > > Honestly, I think I'd prefer to drop all of these legacy versions... > > Good timing! It just so happens that we need to shave some of the old > container tests as we have too many

[Discussion] Xen grants and access permissions

2023-02-16 Thread Viresh Kumar
Hi Oleksandr, As you already know, I am looking at how we can integrate the Xen grants work in our implementation of Rust based Xen vhost frontend [1]. The hypervisor independent vhost-user backends [2] talk to xen-vhost-frontend using the standard vhost-user protocol [3]. Every memory region

Re: [PATCH 4/6] x86/MSI: use standard C types in structures/unions

2023-02-16 Thread Andrew Cooper
On 09/02/2023 10:39 am, Jan Beulich wrote: > Consolidate this to use exclusively standard types, and change > indentation style to Xen's there at the same time (the file already had > a mix of styles). > > No functional change intended. > > Signed-off-by: Jan Beulich So I suppose Acked-by:

Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-02-16 Thread Andrew Cooper
On 16/02/2023 7:31 am, Jan Beulich wrote: > On 15.02.2023 18:59, Oleksii wrote: >> Hello Jan and community, >> >> I experimented and switched RISC-V to x86 implementation. All that I >> changed in x86 implementation for RISC-V was _ASM_BUGFRAME_TEXT. Other >> things are the same as for x86. >> >>

Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-02-16 Thread Oleksii
On Thu, 2023-02-16 at 08:31 +0100, Jan Beulich wrote: > On 15.02.2023 18:59, Oleksii wrote: > > Hello Jan and community, > > > > I experimented and switched RISC-V to x86 implementation. All that > > I > > changed in x86 implementation for RISC-V was _ASM_BUGFRAME_TEXT. > > Other > > things are

Re: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback

2023-02-16 Thread Andrew Cooper
On 13/02/2023 11:50 am, Xenia Ragiadakou wrote: > diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h > b/xen/arch/x86/include/asm/hvm/vmx/vmx.h > index 234da4a7f4..97d6b810ec 100644 > --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h > +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h > @@ -85,7 +85,7 @@

[xen-unstable test] 177428: tolerable trouble: fail/pass/starved - PUSHED

2023-02-16 Thread osstest service owner
flight 177428 xen-unstable real [real] flight 177479 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177428/ http://logs.test-lab.xenproject.org/osstest/logs/177479/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json

2023-02-16 Thread Luca Fancellu
> On 16 Feb 2023, at 08:19, Jan Beulich wrote: > > On 16.02.2023 00:49, Stefano Stabellini wrote: >> On Wed, 15 Feb 2023, Julien Grall wrote: >>> On 14/02/2023 22:25, Stefano Stabellini wrote: > Patch 1's example has a "comment" field, which no entry makes use of. > Without that, how

Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-16 Thread Jan Beulich
On 15.02.2023 17:29, Tamas K Lengyel wrote: > On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: >> Did you consider the alternative of adjusting the ASSERT() in question >> instead? It could reasonably become >> >> #ifdef CONFIG_MEM_SHARING >> ASSERT(!p2m_is_hostp2m(p2m) || !remove_root || >

Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json

2023-02-16 Thread Jan Beulich
On 16.02.2023 00:49, Stefano Stabellini wrote: > On Wed, 15 Feb 2023, Julien Grall wrote: >> On 14/02/2023 22:25, Stefano Stabellini wrote: Patch 1's example has a "comment" field, which no entry makes use of. Without that, how does it become clear _why_ a particular file is to be

[ovmf test] 177466: all pass - PUSHED

2023-02-16 Thread osstest service owner
flight 177466 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/177466/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5c551d6d912967ada3084033acea8acf37256043 baseline version: ovmf

Re: [XEN PATCH] libs: Fix unstable libs build on FreeBSD, auto-generate version-script

2023-02-16 Thread Jan Beulich
On 15.02.2023 18:41, Anthony PERARD wrote: > On Wed, Feb 15, 2023 at 04:30:43PM +0100, Jan Beulich wrote: >> On 15.02.2023 16:21, Anthony PERARD wrote: >>> @@ -13,6 +14,10 @@ MAJOR := $(shell $(XEN_ROOT)/version.sh >>> $(XEN_ROOT)/xen/Makefile) >>> endif >>> MINOR ?= 0 >>> >>> +ifeq ($(origin