[xen-unstable-smoke test] 180034: tolerable trouble: pass/starved - PUSHED

2023-03-27 Thread osstest service owner
flight 180034 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180034/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

RE: [XEN PATCH v5] x86/monitor: Add new monitor event to catch I/O instructions

2023-03-27 Thread Tian, Kevin
> From: Dmitry Isaykin > Sent: Tuesday, March 21, 2023 9:59 PM > > Adds monitor support for I/O instructions. > > Signed-off-by: Dmitry Isaykin > Signed-off-by: Anton Belousov Reviewed-by: Kevin Tian

Re: [PATCH v2 7/7] xen/x86: Replace GPL v2.0+ license boilerplate with an SPDX tag in *.h

2023-03-27 Thread Stefano Stabellini
On Mon, 27 Mar 2023, Julien Grall wrote: > From: Julien Grall > > It is easier to understand the license of a file when using SPDX. > > This is replacing the below pattern with the SPDX tag GPL-2.0-or-later > in xen/arch/x86/*.h: > > * This program is free software; you can redistribute it

Re: [PATCH v2 6/7] xen/x86: Replace GPL v2.0+ license boilerplate with an SPDX tag in *.c

2023-03-27 Thread Stefano Stabellini
On Mon, 27 Mar 2023, Julien Grall wrote: > From: Julien Grall > > It is easier to understand the license of a file when using SPDX. > > This is replacing the below pattern with the SPDX tag GPL-2.0-or-later > in xen/arch/x86/*.c: > > * This program is free software; you can redistribute it

Re: [PATCH v2 5/7] xen/x86: Replace GPL v2.0 license boilerplate with an SPDX tag in *.h (part 3)

2023-03-27 Thread Stefano Stabellini
On Mon, 27 Mar 2023, Julien Grall wrote: > From: Julien Grall > > It is easier to understand the license of a file when using SPDX. > > This is replacing the below pattern with the SPDX tag GPL-2.0-only > in xen/arch/x86/*.h: > > * This program is free software; you can redistribute it and/or

Re: [PATCH v2 4/7] xen/x86: Replace GPL v2.0 license boilerplate with an SPDX tag in *.h

2023-03-27 Thread Stefano Stabellini
On Mon, 27 Mar 2023, Julien Grall wrote: > From: Julien Grall > > It is easier to understand the license of a file when using SPDX. > > This is replacing the below pattern with the SPDX tag GPL-2.0-only > in xen/arch/x86/*.h: > > * This program is free software; you can redistribute it and/or

Re: [PATCH v2 3/7] xen/x86: Replace GPL v2.0 license boilerplate with an SPDX tag in *.c (part 3)

2023-03-27 Thread Stefano Stabellini
On Mon, 27 Mar 2023, Julien Grall wrote: > From: Julien Grall > > It is easier to understand the license of a file when using SPDX. > > This is replacing the below pattern with the SPDX tag GPL-2.0-only > in xen/arch/x86/*.c: > > * This program is free software; you can redistribute it and/or

Re: [PATCH v2 2/7] xen/x86: Replace GPL v2.0 license boilerplate with an SPDX tag in *.c

2023-03-27 Thread Stefano Stabellini
On Mon, 27 Mar 2023, Julien Grall wrote: > From: Julien Grall > > It is easier to understand the license of a file when using SPDX. > > This is replacing the below pattern with the SPDX tag GPL-2.0-only > in xen/arch/x86/*.c: > > * This program is free software; you can redistribute it and/or

Re: [PATCH v2 2/2] automation: add a smoke and suspend test on an Alder Lake system

2023-03-27 Thread Stefano Stabellini
On Sat, 25 Mar 2023, Marek Marczykowski-Górecki wrote: > This is a first test using Qubes OS CI infra. The gitlab-runner has > access to ssh-based control interface (control@thor.testnet, ssh key > exposed to the test via ssh-agent) and pre-configured HTTP dir for boot > files (mapped under

Re: [PATCH v2 1/2] automation: update x86-64 tests to Linux 6.1.19

2023-03-27 Thread Stefano Stabellini
On Sat, 25 Mar 2023, Marek Marczykowski-Górecki wrote: > It will be used in tests added in subsequent patches. > Enable config options needed for those tests. > While at it, migrate all the x86 tests to the newer kernel, and > introduce x86-64-test-needs to allow deduplication later (for now it's

Re: [PATCH v2 1/7] LICENSES: Clarify that the SPDX tag GPL-2.0 is deprecated

2023-03-27 Thread Stefano Stabellini
On Mon, 27 Mar 2023, Julien Grall wrote: > From: Julien Grall > > >From https://spdx.org/licenses/GPL-2.0.html, the SPDX tag GPL-2.0 > is deprecated. Instead, GPL-2.0-only should be used. > > Signed-off-by: Julien Grall Acked-by: Stefano Stabellini > --- > Changes in v2: > -

[qemu-upstream-unstable test] 180030: tolerable trouble: fail/pass/starved - PUSHED

2023-03-27 Thread osstest service owner
flight 180030 qemu-upstream-unstable real [real] flight 180033 qemu-upstream-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180030/ http://logs.test-lab.xenproject.org/osstest/logs/180033/ Failures :-/ but no regressions. Tests which are failing intermittently (not

[PATCH 5/5] x86/ucode: Drop ucode_mod and ucode_blob

2023-03-27 Thread Andrew Cooper
These both incorrectly cache bootstrap_map()'d pointers across returns back to __start_xen(). This is never valid, and such pointers may fault, or point to something unrelated. With the refactoring work in the previous patches, they're clearly now just non-standard function return parameters.

[PATCH 2/5] x86/ucode: Fold early_update_cache() into microcode_init_cache()

2023-03-27 Thread Andrew Cooper
It is not valid to retain a bootstrap_map() across returning back to __start_xen(), but various pointers get stashed across calls. Begin to address this by folding early_update_cache() into it's single caller, rearranging the exit path to always invalidate the mapping. No practical change.

[PATCH 4/5] x86/ucode: Cache results in microcode_scan_module()

2023-03-27 Thread Andrew Cooper
When microcode_scan_module() is used, it's used twice. The caching of the bootstrap_map() pointer in ucode_blob.data is buggy for multiple reasons and is going to be removed. Right now, the boot flow depends on the second pass over bootstrap_map()/find_cpio_data() altering ucode_blob.data to use

[PATCH 1/5] xen/earlycpio: Drop nextoff parameter

2023-03-27 Thread Andrew Cooper
This is imported from Linux, but the parameter being signed is dubious in the first place and we're not plausibly going to gain a use for the functionality. Linux has subsequently made it an optional parameter to avoid forcing callers to pass a stack variable they don't care about using. In the

[PATCH 0/5] x86/ucode: Fixes to bootstrap_map() handling

2023-03-27 Thread Andrew Cooper
Stumbled on to while trying to fix bugs elsewhere with bootstrap_map(). I don't know if I'd conciously reaslised how bogus microcode_init() was previously, but it absolutely can't stay... Andrew Cooper (5): xen/earlycpio: Drop nextoff parameter x86/ucode: Fold early_update_cache() into

[PATCH 3/5] x86/ucode: Fold early_microcode_update_cpu() into early_microcode_init()

2023-03-27 Thread Andrew Cooper
It is not valid to retain a bootstrap_map() across returning back to __start_xen(), but various pointers get stashed across calls. Begin to address this by folding early_update_cache() into it's single caller, rearranging the exit path to always invalidate the mapping. No practical change.

[linux-linus test] 180029: regressions - trouble: fail/pass/starved

2023-03-27 Thread osstest service owner
flight 180029 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180029/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 178042

[ovmf test] 180031: all pass - PUSHED

2023-03-27 Thread osstest service owner
flight 180031 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180031/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 144028626e0072c2c4fdfcc0fe1b72de319bdd2f baseline version: ovmf

[PATCH v2 5/7] xen/x86: Replace GPL v2.0 license boilerplate with an SPDX tag in *.h (part 3)

2023-03-27 Thread Julien Grall
From: Julien Grall It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0-only in xen/arch/x86/*.h: * This program is free software; you can redistribute it and/or * modify it under the terms and conditions of the GNU

[PATCH v2 7/7] xen/x86: Replace GPL v2.0+ license boilerplate with an SPDX tag in *.h

2023-03-27 Thread Julien Grall
From: Julien Grall It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0-or-later in xen/arch/x86/*.h: * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General

[PATCH v2 1/7] LICENSES: Clarify that the SPDX tag GPL-2.0 is deprecated

2023-03-27 Thread Julien Grall
From: Julien Grall >From https://spdx.org/licenses/GPL-2.0.html, the SPDX tag GPL-2.0 is deprecated. Instead, GPL-2.0-only should be used. Signed-off-by: Julien Grall --- Changes in v2: - Patch added --- LICENSES/GPL-2.0 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 6/7] xen/x86: Replace GPL v2.0+ license boilerplate with an SPDX tag in *.c

2023-03-27 Thread Julien Grall
From: Julien Grall It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0-or-later in xen/arch/x86/*.c: * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General

[PATCH v2 0/7] xen/x86: Use SPDX (take 1)

2023-03-27 Thread Julien Grall
From: Julien Grall Hi all, This is a first attempt to replace all the full license text with SPX tag in xen/arch/x86/. This is covering most of the x86 files. I have used the script below to remove the full license and add an SPDX tag. The script is based on the work from Anthony [1]. #!

[PATCH v2 2/7] xen/x86: Replace GPL v2.0 license boilerplate with an SPDX tag in *.c

2023-03-27 Thread Julien Grall
From: Julien Grall It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0-only in xen/arch/x86/*.c: * This program is free software; you can redistribute it and/or modify it * under the terms and conditions of the GNU

[PATCH v2 4/7] xen/x86: Replace GPL v2.0 license boilerplate with an SPDX tag in *.h

2023-03-27 Thread Julien Grall
From: Julien Grall It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0-only in xen/arch/x86/*.h: * This program is free software; you can redistribute it and/or modify it * under the terms and conditions of the GNU

[PATCH v2 3/7] xen/x86: Replace GPL v2.0 license boilerplate with an SPDX tag in *.c (part 3)

2023-03-27 Thread Julien Grall
From: Julien Grall It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0-only in xen/arch/x86/*.c: * This program is free software; you can redistribute it and/or * modify it under the terms and conditions of the GNU

[PATCH v3 1/3] xen/riscv: introduce setup_initial_pages

2023-03-27 Thread Oleksii Kurochko
The idea was taken from xvisor but the following changes were done: * Use only a minimal part of the code enough to enable MMU * rename {_}setup_initial_pagetables functions * add an argument for setup_initial_mapping to have an opportunity to make set PTE flags. * update

[PATCH v3 2/3] xen/riscv: setup initial pagetables

2023-03-27 Thread Oleksii Kurochko
The patch does two thing: 1. Setup initial pagetables. 2. Enable MMU which end up with code in cont_after_mmu_is_enabled() Signed-off-by: Oleksii Kurochko --- Changes in V3: - update the commit message that MMU is also enabled here - remove early_printk("All set up\n") as it was moved to

[PATCH v3 0/3] enable MMU for RISC-V

2023-03-27 Thread Oleksii Kurochko
The patch series is based on top patches [1] and [2] The patch series introduces the following things: 1. Functionality to build the page tables for Xen that map link-time to physical-time location. 2. Check that Xen is less then page size. 3. Check that load addresses don't overlap with

[PATCH v3 3/3] xen/riscv: remove dummy_bss variable

2023-03-27 Thread Oleksii Kurochko
After introduction of initial pagetables there is no any sense in dummy_bss variable as bss section will not be empty anymore. Signed-off-by: Oleksii Kurochko --- Changes in V3: * patch was introduced in the current one patch series (v3). --- Changes in V2: * patch was introduced in the

Re: [PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-27 Thread Juergen Gross
On 27.03.23 17:38, Jan Beulich wrote: On 27.03.2023 12:07, Juergen Gross wrote: On 27.03.23 11:49, Jan Beulich wrote: On 27.03.2023 10:36, Juergen Gross wrote: @@ -413,6 +418,13 @@ static void xenvif_get_requests(struct xenvif_queue *queue, cop->dest.u.gmfn =

[PATCH 1/2] xenalyze: Handle start-of-day ->RUNNING transitions

2023-03-27 Thread George Dunlap
A recent xentrace highlighted an unhandled corner case in the vcpu "start-of-day" logic, if the trace starts after the last running -> non-running transition, but before the first non-running -> running transition. Because start-of-day wasn't handled, vcpu_next_update() was expecting p->current

[PATCH 2/2] xenalyze: Basic TRC_HVM_EMUL handling

2023-03-27 Thread George Dunlap
For now, mainly just do volume analysis and get rid of the warnings. Signed-off-by: George Dunlap --- CC: Wei Liu CC: Anthony PERARD --- tools/xentrace/xenalyze.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/tools/xentrace/xenalyze.c

Re: [PATCH v8 5/5] xen/x86: switch x86 to use generic implemetation of bug.h

2023-03-27 Thread Oleksii
Hello Jan, On Thu, 2023-03-16 at 10:52 +0100, Jan Beulich wrote: > On 15.03.2023 18:21, Oleksii Kurochko wrote: > > The following changes were made: > > * Make GENERIC_BUG_FRAME mandatory for X86 > > * Update asm/bug.h using generic implementation in > > * Update do_invalid_op using generic

Re: preparations for 4.16.4 and 4.17.1

2023-03-27 Thread Jan Beulich
On 27.03.2023 12:55, Andrew Cooper wrote: > On 21/03/2023 2:30 pm, Jan Beulich wrote: >> All, >> >> the former release is due in a couple of weeks time, the latter a week >> or two later. Note that with us following the 4 month cadence pretty >> strictly this time, 4.16.4 isn't expected to be the

Re: [PATCH v5] ACPI: processor: Fix evaluating _PDC method when running as Xen dom0

2023-03-27 Thread Juergen Gross
On 27.03.23 17:49, Roger Pau Monné wrote: On Mon, Mar 27, 2023 at 03:58:26PM +0200, Juergen Gross wrote: On 21.03.23 15:19, Roger Pau Monne wrote: In ACPI systems, the OS can direct power management, as opposed to the firmware. This OS-directed Power Management is called OSPM. Part of

Re: [PATCH v5] ACPI: processor: Fix evaluating _PDC method when running as Xen dom0

2023-03-27 Thread Roger Pau Monné
On Mon, Mar 27, 2023 at 03:58:26PM +0200, Juergen Gross wrote: > On 21.03.23 15:19, Roger Pau Monne wrote: > > In ACPI systems, the OS can direct power management, as opposed to the > > firmware. This OS-directed Power Management is called OSPM. Part of > > telling the firmware that the OS going

Re: [PATCH v4] x86: detect CMOS aliasing on ports other than 0x70/0x71

2023-03-27 Thread Jan Beulich
On 23.03.2023 17:40, Roger Pau Monné wrote: > On Thu, Mar 23, 2023 at 05:08:43PM +0100, Jan Beulich wrote: >> On 23.03.2023 15:49, Roger Pau Monné wrote: >>> On Mon, Mar 20, 2023 at 09:32:26AM +0100, Jan Beulich wrote: --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@

Re: [PATCH v4] x86: detect CMOS aliasing on ports other than 0x70/0x71

2023-03-27 Thread Jan Beulich
On 23.03.2023 15:49, Roger Pau Monné wrote: > On Mon, Mar 20, 2023 at 09:32:26AM +0100, Jan Beulich wrote: >> @@ -1249,6 +1252,80 @@ static unsigned long get_cmos_time(void) >> return mktime(rtc.year, rtc.mon, rtc.day, rtc.hour, rtc.min, rtc.sec); >> } >> >> +static unsigned int

Re: [PATCH v4] x86: detect CMOS aliasing on ports other than 0x70/0x71

2023-03-27 Thread Jan Beulich
On 21.03.2023 15:12, Roger Pau Monné wrote: > On Mon, Mar 20, 2023 at 09:32:26AM +0100, Jan Beulich wrote: >> ... in order to also intercept Dom0 accesses through the alias ports. > > I'm trying to get some documentation about this aliasing, but so far I > haven't been able to find any. Do you

Re: [PATCH] x86/boot: Restrict directmap permissions for .text/.rodata

2023-03-27 Thread Jan Beulich
On 24.03.2023 23:08, Andrew Cooper wrote: > While we've been diligent to ensure that the main text/data/rodata mappings > have suitable restrictions, their aliases via the directmap were left fully > read/write. Worse, we even had pieces of code making use of this as a > feature. > > Restrict

Re: [PATCH v2 1/3] x86/msi: passthrough all MSI-X vector ctrl writes to device model

2023-03-27 Thread Roger Pau Monné
On Mon, Mar 27, 2023 at 05:32:01PM +0200, Jan Beulich wrote: > On 27.03.2023 12:12, Roger Pau Monné wrote: > > On Sat, Mar 25, 2023 at 03:49:22AM +0100, Marek Marczykowski-Górecki wrote: > >> QEMU needs to know whether clearing maskbit of a vector is really > >> clearing, or was already cleared

Re: [PATCH] x86/ucode: Fix error paths control_thread_fn()

2023-03-27 Thread Jan Beulich
On 24.03.2023 22:44, Andrew Cooper wrote: > These two early exits skipped re-enabling the watchdog, and restoring the NMI > callback. Always execute the tail of the function on the way out. > > Fixes: 8dd4dfa92d62 ("x86/microcode: Synchronize late microcode loading") > Signed-off-by: Andrew

Re: [PATCH 07/16] x86/shadow: call sh_update_cr3() directly from sh_page_fault()

2023-03-27 Thread Tim Deegan
Hi, At 10:33 +0100 on 22 Mar (1679481226), Jan Beulich wrote: > There's no need for an indirect call here, as the mode is invariant > throughout the entire paging-locked region. All it takes to avoid it is > to have a forward declaration of sh_update_cr3() in place. > > Signed-off-by: Jan

Re: [PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-27 Thread Jan Beulich
On 27.03.2023 12:07, Juergen Gross wrote: > On 27.03.23 11:49, Jan Beulich wrote: >> On 27.03.2023 10:36, Juergen Gross wrote: >>> @@ -413,6 +418,13 @@ static void xenvif_get_requests(struct xenvif_queue >>> *queue, >>> cop->dest.u.gmfn = virt_to_gfn(skb->data + skb_headlen(skb) >>>

Re: [PATCH v2 1/3] x86/msi: passthrough all MSI-X vector ctrl writes to device model

2023-03-27 Thread Jan Beulich
On 27.03.2023 12:12, Roger Pau Monné wrote: > On Sat, Mar 25, 2023 at 03:49:22AM +0100, Marek Marczykowski-Górecki wrote: >> QEMU needs to know whether clearing maskbit of a vector is really >> clearing, or was already cleared before. Currently Xen sends only >> clearing that bit to the device

Re: [PATCH v2 1/3] x86/msi: passthrough all MSI-X vector ctrl writes to device model

2023-03-27 Thread Roger Pau Monné
On Mon, Mar 27, 2023 at 04:20:45PM +0200, Marek Marczykowski-Górecki wrote: > On Mon, Mar 27, 2023 at 03:29:55PM +0200, Roger Pau Monné wrote: > > On Mon, Mar 27, 2023 at 01:34:23PM +0200, Marek Marczykowski-Górecki wrote: > > > On Mon, Mar 27, 2023 at 12:51:09PM +0200, Roger Pau Monné wrote: > >

Re: [PATCH v2 1/3] x86/msi: passthrough all MSI-X vector ctrl writes to device model

2023-03-27 Thread Marek Marczykowski-Górecki
On Mon, Mar 27, 2023 at 03:29:55PM +0200, Roger Pau Monné wrote: > On Mon, Mar 27, 2023 at 01:34:23PM +0200, Marek Marczykowski-Górecki wrote: > > On Mon, Mar 27, 2023 at 12:51:09PM +0200, Roger Pau Monné wrote: > > > On Mon, Mar 27, 2023 at 12:26:05PM +0200, Marek Marczykowski-Górecki > > >

Re: [PATCH] include: don't mention stub headers more than once in a make rule

2023-03-27 Thread Anthony PERARD
On Wed, Mar 22, 2023 at 11:59:40AM +0100, Jan Beulich wrote: > When !GRANT_TABLE and !PV_SHIM headers-n contains grant_table.h twice, > causing make to complain "target '...' given more than once in the same > rule" for the rule generating the stub headers. We don't need duplicate > entries in

Re: [PATCH] configure: Drop --enable-githttp

2023-03-27 Thread Anthony PERARD
On Fri, Mar 24, 2023 at 08:14:04PM +, Andrew Cooper wrote: > Following Demi's work to use HTTPS everywhere, all users of GIT_HTTP have > been removed from the build system. Drop the configure knob. > > Signed-off-by: Andrew Cooper Do we need a changelog entry about these changes? (That git

Re: [PATCH v5] ACPI: processor: Fix evaluating _PDC method when running as Xen dom0

2023-03-27 Thread Juergen Gross
On 21.03.23 15:19, Roger Pau Monne wrote: In ACPI systems, the OS can direct power management, as opposed to the firmware. This OS-directed Power Management is called OSPM. Part of telling the firmware that the OS going to direct power management is making ACPI "_PDC" (Processor Driver

OSSTEST: adding back rimava0 and rimava1 in production

2023-03-27 Thread Anthony PERARD
Hi, Just to let you know that we've added both machines "rimava0" and "rimava1" in back in production. I did run a whole "xen-unstable" flight on just those two machines and it looked fine. Cheers, -- Anthony PERARD

Re: [XEN v4 07/11] xen/arm: Introduce choice to enable 64/32 bit physical addressing

2023-03-27 Thread Julien Grall
Hi, On 27/03/2023 12:46, Ayan Kumar Halder wrote: On 22/03/2023 13:53, Jan Beulich wrote: On 22.03.2023 14:29, Julien Grall wrote: On 22/03/2023 06:59, Jan Beulich wrote: On 21.03.2023 19:33, Ayan Kumar Halder wrote: On 21/03/2023 16:53, Jan Beulich wrote: On 21.03.2023 17:15, Ayan Kumar

Re: [PATCH v2 1/3] x86/msi: passthrough all MSI-X vector ctrl writes to device model

2023-03-27 Thread Roger Pau Monné
On Mon, Mar 27, 2023 at 01:34:23PM +0200, Marek Marczykowski-Górecki wrote: > On Mon, Mar 27, 2023 at 12:51:09PM +0200, Roger Pau Monné wrote: > > On Mon, Mar 27, 2023 at 12:26:05PM +0200, Marek Marczykowski-Górecki wrote: > > > On Mon, Mar 27, 2023 at 12:12:29PM +0200, Roger Pau Monné wrote: > >

Re: [PATCH] x86/ucode: Fix error paths control_thread_fn()

2023-03-27 Thread Sergey Dyasli
On Fri, Mar 24, 2023 at 9:44 PM Andrew Cooper wrote: > > These two early exits skipped re-enabling the watchdog, and restoring the NMI > callback. Always execute the tail of the function on the way out. > > Fixes: 8dd4dfa92d62 ("x86/microcode: Synchronize late microcode loading") >

[ovmf test] 180028: all pass - PUSHED

2023-03-27 Thread osstest service owner
flight 180028 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180028/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2bc854588309b6a9b348655297f3f82165de23a7 baseline version: ovmf

Re: [XEN v4 07/11] xen/arm: Introduce choice to enable 64/32 bit physical addressing

2023-03-27 Thread Ayan Kumar Halder
Hi Jan, Julien, On 22/03/2023 13:53, Jan Beulich wrote: On 22.03.2023 14:29, Julien Grall wrote: On 22/03/2023 06:59, Jan Beulich wrote: On 21.03.2023 19:33, Ayan Kumar Halder wrote: On 21/03/2023 16:53, Jan Beulich wrote: On 21.03.2023 17:15, Ayan Kumar Halder wrote: On 21/03/2023 14:22,

[linux-linus test] 180025: regressions - trouble: blocked/fail/pass/starved

2023-03-27 Thread osstest service owner
flight 180025 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180025/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 178042

Re: [PATCH v2 1/3] x86/msi: passthrough all MSI-X vector ctrl writes to device model

2023-03-27 Thread Marek Marczykowski-Górecki
On Mon, Mar 27, 2023 at 12:51:09PM +0200, Roger Pau Monné wrote: > On Mon, Mar 27, 2023 at 12:26:05PM +0200, Marek Marczykowski-Górecki wrote: > > On Mon, Mar 27, 2023 at 12:12:29PM +0200, Roger Pau Monné wrote: > > > On Sat, Mar 25, 2023 at 03:49:22AM +0100, Marek Marczykowski-Górecki > > >

[PATCH v4 12/12] xen/changelog: Add SVE and "dom0" options to the changelog for Arm

2023-03-27 Thread Luca Fancellu
Arm now can use the "dom0=" Xen command line option and the support for guests running SVE instructions is added, put entries in the changelog. Signed-off-by: Luca Fancellu --- Change from v3: - new patch --- CHANGELOG.md | 5 + 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md

[PATCH v4 10/12] xen/tools: add sve parameter in XL configuration

2023-03-27 Thread Luca Fancellu
Add sve parameter in XL configuration to allow guests to use SVE feature. Signed-off-by: Luca Fancellu Acked-by: George Dunlap --- Changes from v3: - no changes Changes from v2: - domain configuration field name has changed to sve_vl, also its value now is VL/128. - Add Ack-by George for

[PATCH v4 09/12] tools: add physinfo arch_capabilities handling for Arm

2023-03-27 Thread Luca Fancellu
On Arm, the SVE vector length is encoded in arch_capabilities field of struct xen_sysctl_physinfo, make use of this field in the tools when building for arm. Create header arm-arch-capabilities.h to handle the arch_capabilities field of physinfo for Arm. Removed include for

[PATCH v4 11/12] xen/arm: add sve property for dom0less domUs

2023-03-27 Thread Luca Fancellu
Add a device tree property in the dom0less domU configuration to enable the guest to use SVE. Update documentation. Signed-off-by: Luca Fancellu --- Changes from v3: - Now domainconfig_encode_vl is named sve_encode_vl Changes from v2: - xen_domctl_createdomain field name has changed into

[PATCH v4 06/12] xen/common: add dom0 xen command line argument for Arm

2023-03-27 Thread Luca Fancellu
Currently x86 defines a Xen command line argument dom0= where there can be specified dom0 controlling sub-options, to use it also on Arm, move the code that loops through the list of arguments from x86 to the common code and from there, call architecture specific functions to handle the comma

[PATCH v4 07/12] xen: enable Dom0 to use SVE feature

2023-03-27 Thread Luca Fancellu
Add a command line parameter to allow Dom0 the use of SVE resources, the command line parameter sve=, sub argument of dom0=, controls the feature on this domain and sets the maximum SVE vector length for Dom0. Add a new function, parse_integer(), to parse an integer command line argument.

[PATCH v4 04/12] xen/arm: add SVE exception class handling

2023-03-27 Thread Luca Fancellu
SVE has a new exception class with code 0x19, introduce the new code and handle the exception. Signed-off-by: Luca Fancellu --- Changes from v3: - No changes Changes from v2: - No changes Changes from v1: - No changes Changes from RFC: - No changes --- xen/arch/arm/include/asm/processor.h |

[PATCH v4 08/12] xen/physinfo: encode Arm SVE vector length in arch_capabilities

2023-03-27 Thread Luca Fancellu
When the arm platform supports SVE, advertise the feature in the field arch_capabilities in struct xen_sysctl_physinfo by encoding the SVE vector length in it. Signed-off-by: Luca Fancellu --- Changes from v3: - domainconfig_encode_vl is now named sve_encode_vl Changes from v2: - Remove

[PATCH v4 05/12] arm/sve: save/restore SVE context switch

2023-03-27 Thread Luca Fancellu
Save/restore context switch for SVE, allocate memory to contain the Z0-31 registers whose length is maximum 2048 bits each and FFR who can be maximum 256 bits, the allocated memory depends on how many bits is the vector length for the domain and how many bits are supported by the platform. Save

[PATCH v4 01/12] xen/arm: enable SVE extension for Xen

2023-03-27 Thread Luca Fancellu
Enable Xen to handle the SVE extension, add code in cpufeature module to handle ZCR SVE register, disable trapping SVE feature on system boot only when SVE resources are accessed. While there, correct coding style for the comment on coprocessor trapping. Now cptr_el2 is part of the domain context

[PATCH v4 03/12] xen/arm: Expose SVE feature to the guest

2023-03-27 Thread Luca Fancellu
When a guest is allowed to use SVE, expose the SVE features through the identification registers. Signed-off-by: Luca Fancellu --- Changes from v3: - no changes Changes from v2: - no changes Changes from v1: - No changes Changes from RFC: - No changes --- xen/arch/arm/arm64/vsysreg.c | 39

[PATCH v4 00/12] SVE feature for arm guests

2023-03-27 Thread Luca Fancellu
This serie is introducing the possibility for Dom0 and DomU guests to use sve/sve2 instructions. SVE feature introduces new instruction and registers to improve performances on floating point operations. The SVE feature is advertised using the ID_AA64PFR0_EL1 register, SVE field, and when

[PATCH v4 02/12] xen/arm: add SVE vector length field to the domain

2023-03-27 Thread Luca Fancellu
Add sve_vl field to arch_domain and xen_arch_domainconfig struct, to allow the domain to have an information about the SVE feature and the number of SVE register bits that are allowed for this domain. sve_vl field is the vector length in bits divided by 128, this allows to use less space in the

Re: preparations for 4.16.4 and 4.17.1

2023-03-27 Thread Andrew Cooper
On 21/03/2023 2:30 pm, Jan Beulich wrote: > All, > > the former release is due in a couple of weeks time, the latter a week > or two later. Note that with us following the 4 month cadence pretty > strictly this time, 4.16.4 isn't expected to be the last ordinary stable > release from the 4.16

Re: [PATCH v2 1/3] xen/riscv: introduce setup_initial_pages

2023-03-27 Thread Julien Grall
On 27/03/2023 11:50, Oleksii wrote: Hello Julien, Hi, On Tue, 2023-03-21 at 17:58 +, Julien Grall wrote: +    /* Setup level0 table */ +    if ( !pte_is_valid([index0]) ) On the previous version, you said it should be checked for each level. But here you still only check

Re: [PATCH v2 1/3] x86/msi: passthrough all MSI-X vector ctrl writes to device model

2023-03-27 Thread Roger Pau Monné
On Mon, Mar 27, 2023 at 12:26:05PM +0200, Marek Marczykowski-Górecki wrote: > On Mon, Mar 27, 2023 at 12:12:29PM +0200, Roger Pau Monné wrote: > > On Sat, Mar 25, 2023 at 03:49:22AM +0100, Marek Marczykowski-Górecki wrote: > > > QEMU needs to know whether clearing maskbit of a vector is really > >

Re: [PATCH v2 1/3] xen/riscv: introduce setup_initial_pages

2023-03-27 Thread Oleksii
Hello Julien, On Tue, 2023-03-21 at 17:58 +, Julien Grall wrote: > > +    /* Setup level0 table */ > > +    if ( !pte_is_valid([index0]) ) > > On the previous version, you said it should be checked for each > level. > But here you still only check for a single level. > >

Re: [PATCH v2 2/3] x86/hvm: Allow writes to registers on the same page as MSI-X table

2023-03-27 Thread Andrew Cooper
On 25/03/2023 2:49 am, Marek Marczykowski-Górecki wrote: > diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c > index 9c82bf9b4ec2..9293009a4075 100644 > --- a/xen/arch/x86/hvm/vmsi.c > +++ b/xen/arch/x86/hvm/vmsi.c > @@ -438,6 +438,152 @@ static const struct hvm_io_ops

Re: [PATCH v2 1/3] x86/msi: passthrough all MSI-X vector ctrl writes to device model

2023-03-27 Thread Marek Marczykowski-Górecki
On Mon, Mar 27, 2023 at 12:12:29PM +0200, Roger Pau Monné wrote: > On Sat, Mar 25, 2023 at 03:49:22AM +0100, Marek Marczykowski-Górecki wrote: > > QEMU needs to know whether clearing maskbit of a vector is really > > clearing, or was already cleared before. Currently Xen sends only > > clearing

Re: [PATCH v2 1/3] x86/msi: passthrough all MSI-X vector ctrl writes to device model

2023-03-27 Thread Roger Pau Monné
On Sat, Mar 25, 2023 at 03:49:22AM +0100, Marek Marczykowski-Górecki wrote: > QEMU needs to know whether clearing maskbit of a vector is really > clearing, or was already cleared before. Currently Xen sends only > clearing that bit to the device model, but not setting it, so QEMU > cannot detect

[PATCH 0/2] Add API for making parts of a MMIO page R/O and use it in XHCI console

2023-03-27 Thread Marek Marczykowski-Górecki
On older systems, XHCI xcap had a layout that no other (interesting) registers were placed on the same page as the debug capability, so Linux was fine with making the whole page R/O. But at least on Tiger Lake and Alder Lake, Linux needs to write to some other registers on the same page too. Add

[PATCH 2/2] drivers/char: Use sub-page ro API to make just xhci dbc cap RO

2023-03-27 Thread Marek Marczykowski-Górecki
... not the whole page, which may contain other registers too. In fact on Tiger Lake and newer (at least), this page do contain other registers that Linux tries to use. And with share=yes, a domU would use them too. Without this patch, PV dom0 would fail to initialize the controller, while HVM

[PATCH 1/2] x86/mm: add API for marking only part of a MMIO page read only

2023-03-27 Thread Marek Marczykowski-Górecki
In some cases, only few registers on a page needs to be write-protected. Examples include USB3 console (64 bytes worth of registers) or MSI-X's PBA table (which doesn't need to span the whole table either). Current API allows only marking whole pages pages read-only, which sometimes may cover

Re: [PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-27 Thread Juergen Gross
On 27.03.23 11:49, Jan Beulich wrote: On 27.03.2023 10:36, Juergen Gross wrote: Fix xenvif_get_requests() not to do grant copy operations across local page boundaries. This requires to double the maximum number of copy operations per queue, as each copy could now be split into 2. Make sure

Re: [PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-27 Thread Jan Beulich
On 27.03.2023 10:36, Juergen Gross wrote: > Fix xenvif_get_requests() not to do grant copy operations across local > page boundaries. This requires to double the maximum number of copy > operations per queue, as each copy could now be split into 2. > > Make sure that struct xenvif_tx_cb doesn't

[ovmf test] 180027: all pass - PUSHED

2023-03-27 Thread osstest service owner
flight 180027 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180027/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d55d73152ebf5c793b645d6ec5bc517d219881cd baseline version: ovmf

[xen-unstable test] 180024: trouble: broken/fail/pass/starved

2023-03-27 Thread osstest service owner
flight 180024 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180024/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386-xsmbroken Tests

Re: [PATCH 2/2] xen/netback: remove not needed test in xenvif_tx_build_gops()

2023-03-27 Thread Paul Durrant
On 27/03/2023 09:36, Juergen Gross wrote: The tests for the number of grant mapping or copy operations reaching the array size of the operations buffer at the end of the main loop in xenvif_tx_build_gops() isn't needed. The loop can handle at maximum MAX_PENDING_REQS transfer requests, as

Re: [PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-27 Thread Paul Durrant
On 27/03/2023 09:36, Juergen Gross wrote: Fix xenvif_get_requests() not to do grant copy operations across local page boundaries. This requires to double the maximum number of copy operations per queue, as each copy could now be split into 2. Make sure that struct xenvif_tx_cb doesn't grow too

Re: [PATCH] ARM+RISC-V: BSS handling improvements

2023-03-27 Thread Oleksii
Hi Andrew, Reviewed-by: Oleksii Kurochko ~ Oleksii

[PATCH 2/2] xen/netback: remove not needed test in xenvif_tx_build_gops()

2023-03-27 Thread Juergen Gross
The tests for the number of grant mapping or copy operations reaching the array size of the operations buffer at the end of the main loop in xenvif_tx_build_gops() isn't needed. The loop can handle at maximum MAX_PENDING_REQS transfer requests, as XEN_RING_NR_UNCONSUMED_REQUESTS() is taking

[PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-27 Thread Juergen Gross
Fix xenvif_get_requests() not to do grant copy operations across local page boundaries. This requires to double the maximum number of copy operations per queue, as each copy could now be split into 2. Make sure that struct xenvif_tx_cb doesn't grow too large. Cc: sta...@vger.kernel.org Fixes:

[PATCH 0/2] xen/netback: fix issue introduced recently

2023-03-27 Thread Juergen Gross
The fix for XSA-423 introduced a bug which resulted in loss of network connection in some configurations. The first patch is fixing the issue, while the second one is removing a test which isn't needed. Juergen Gross (2): xen/netback: don't do grant copy across page boundary xen/netback:

[ovmf test] 180026: all pass - PUSHED

2023-03-27 Thread osstest service owner
flight 180026 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180026/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1bfc89414dbc2b4e620e06231ae98d714914fc46 baseline version: ovmf