[qemu-mainline test] 181993: regressions - FAIL

2023-07-24 Thread osstest service owner
flight 181993 qemu-mainline real [real] flight 182003 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181993/ http://logs.test-lab.xenproject.org/osstest/logs/182003/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not

Re: [PATCH mm-unstable v7 00/31] Split ptdesc from struct page

2023-07-24 Thread Hugh Dickins
On Mon, 24 Jul 2023, Vishal Moola (Oracle) wrote: > The MM subsystem is trying to shrink struct page. This patchset > introduces a memory descriptor for page table tracking - struct ptdesc. > > This patchset introduces ptdesc, splits ptdesc from struct page, and > converts many callers of page

[PATCH mm-unstable v7 29/31] sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents

2023-07-24 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable pte constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- arch/sparc/mm/srmmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/sparc/mm/srmmu.c

[PATCH mm-unstable v7 15/31] mm: Remove page table members from struct page

2023-07-24 Thread Vishal Moola (Oracle)
The page table members are now split out into their own ptdesc struct. Remove them from struct page. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- include/linux/mm_types.h | 18 -- include/linux/pgtable.h | 3 --- 2 files changed, 21 deletions(-)

[PATCH mm-unstable v7 28/31] sparc64: Convert various functions to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- arch/sparc/mm/init_64.c | 17 + 1 file changed, 9

[PATCH mm-unstable v7 22/31] m68k: Convert various functions to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v7 30/31] um: Convert {pmd, pte}_free_tlb() to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Also cleans up some spacing issues. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- arch/um/include/asm/pgalloc.h | 18 +- 1 file changed, 9 insertions(+), 9

[PATCH mm-unstable v7 31/31] mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers

2023-07-24 Thread Vishal Moola (Oracle)
These functions are no longer necessary. Remove them and cleanup Documentation referencing them. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- Documentation/mm/split_page_table_lock.rst| 12 +-- .../zh_CN/mm/split_page_table_lock.rst| 14

[PATCH mm-unstable v7 21/31] loongarch: Convert various functions to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v7 23/31] mips: Convert various functions to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v7 18/31] arm64: Convert various functions to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) Acked-by: Catalin Marinas --- arch/arm64/include/asm/tlb.h | 14 --

[PATCH mm-unstable v7 24/31] nios2: Convert __pte_free_tlb() to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) Acked-by: Dinh Nguyen --- arch/nios2/include/asm/pgalloc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH mm-unstable v7 12/31] powerpc: Convert various functions to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
In order to split struct ptdesc from struct page, convert various functions to use ptdescs. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- arch/powerpc/mm/book3s64/mmu_context.c | 10 ++--- arch/powerpc/mm/book3s64/pgtable.c | 32 +++

[PATCH mm-unstable v7 26/31] riscv: Convert alloc_{pmd, pte}_late() to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v7 14/31] s390: Convert various pgalloc functions to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v7 17/31] arm: Convert various functions to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. late_alloc() also uses the __get_free_pages() helper function. Convert this to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v7 19/31] csky: Convert __pte_free_tlb() to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) Acked-by: Guo Ren Acked-by: Mike Rapoport (IBM) --- arch/csky/include/asm/pgalloc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH mm-unstable v7 20/31] hexagon: Convert __pte_free_tlb() to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- arch/hexagon/include/asm/pgalloc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH mm-unstable v7 27/31] sh: Convert pte_free_tlb() to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Also cleans up some spacing issues. Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Geert Uytterhoeven Acked-by: John Paul Adrian Glaubitz Acked-by: Mike Rapoport (IBM) ---

[PATCH mm-unstable v7 25/31] openrisc: Convert __pte_free_tlb() to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- arch/openrisc/include/asm/pgalloc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v2 01/47] mm: vmscan: move shrinker-related code into a separate file

2023-07-24 Thread Muchun Song
> On Jul 25, 2023, at 11:09, Qi Zheng wrote: > > > > On 2023/7/25 10:35, Muchun Song wrote: >>> On Jul 24, 2023, at 17:43, Qi Zheng wrote: >>> >>> The mm/vmscan.c file is too large, so separate the shrinker-related >>> code from it into a separate file. No functional changes. >>> >>>

Re: [PATCH v2 02/47] mm: shrinker: remove redundant shrinker_rwsem in debugfs operations

2023-07-24 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > The debugfs_remove_recursive() will wait for debugfs_file_put() to return, > so the shrinker will not be freed when doing debugfs operations (such as > shrinker_debugfs_count_show() and shrinker_debugfs_scan_write()), so there > is no need to

Re: [PATCH v2 01/47] mm: vmscan: move shrinker-related code into a separate file

2023-07-24 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > The mm/vmscan.c file is too large, so separate the shrinker-related > code from it into a separate file. No functional changes. > > Signed-off-by: Qi Zheng > --- > include/linux/shrinker.h | 3 + > mm/Makefile | 4 +- >

[PATCH mm-unstable v7 16/31] pgalloc: Convert various functions to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v7 13/31] x86: Convert various functions to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
In order to split struct ptdesc from struct page, convert various functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola

[PATCH mm-unstable v7 11/31] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor}

2023-07-24 Thread Vishal Moola (Oracle)
Create pagetable_pte_ctor(), pagetable_pmd_ctor(), pagetable_pte_dtor(), and pagetable_pmd_dtor() and make the original pgtable constructor/destructors wrappers. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- include/linux/mm.h | 56

[PATCH mm-unstable v7 07/31] mm: Convert pmd_ptlock_init() to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- include/linux/mm.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH mm-unstable v7 10/31] mm: Convert ptlock_free() to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- include/linux/mm.h | 10 +- mm/memory.c| 4 ++-- 2 files changed, 7 insertions(+), 7

[PATCH mm-unstable v7 08/31] mm: Convert ptlock_init() to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- include/linux/mm.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH mm-unstable v7 09/31] mm: Convert pmd_ptlock_free() to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- include/linux/mm.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH mm-unstable v7 04/31] mm: Convert pmd_pgtable_page() callers to use pmd_ptdesc()

2023-07-24 Thread Vishal Moola (Oracle)
Converts internal pmd_pgtable_page() callers to use pmd_ptdesc(). This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- include/linux/mm.h | 4 ++-- 1 file changed,

[PATCH mm-unstable v7 06/31] mm: Convert ptlock_ptr() to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- arch/x86/xen/mmu_pv.c | 2 +- include/linux/mm.h| 14 +++--- 2 files changed, 8 insertions(+), 8

[PATCH mm-unstable v7 05/31] mm: Convert ptlock_alloc() to use ptdescs

2023-07-24 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- include/linux/mm.h | 6 +++--- mm/memory.c| 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-)

[PATCH mm-unstable v7 01/31] mm: Add PAGE_TYPE_OP folio functions

2023-07-24 Thread Vishal Moola (Oracle)
No folio equivalents for page type operations have been defined, so define them for later folio conversions. Also changes the Page##uname macros to take in const struct page* since we only read the memory here. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) ---

[PATCH mm-unstable v7 02/31] pgtable: Create struct ptdesc

2023-07-24 Thread Vishal Moola (Oracle)
Currently, page table information is stored within struct page. As part of simplifying struct page, create struct ptdesc for page table information. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- include/linux/pgtable.h | 71 + 1

[PATCH mm-unstable v7 03/31] mm: add utility functions for ptdesc

2023-07-24 Thread Vishal Moola (Oracle)
Introduce utility functions setting the foundation for ptdescs. These will also assist in the splitting out of ptdesc from struct page. Functions that focus on the descriptor are prefixed with ptdesc_* while functions that focus on the pagetable are prefixed with pagetable_*. pagetable_alloc()

[PATCH mm-unstable v7 00/31] Split ptdesc from struct page

2023-07-24 Thread Vishal Moola (Oracle)
The MM subsystem is trying to shrink struct page. This patchset introduces a memory descriptor for page table tracking - struct ptdesc. This patchset introduces ptdesc, splits ptdesc from struct page, and converts many callers of page table constructor/destructors to use ptdescs. Ptdesc is a

Re: [PATCH v2 01/47] mm: vmscan: move shrinker-related code into a separate file

2023-07-24 Thread Qi Zheng
On 2023/7/25 11:23, Muchun Song wrote: On Jul 25, 2023, at 11:09, Qi Zheng wrote: On 2023/7/25 10:35, Muchun Song wrote: On Jul 24, 2023, at 17:43, Qi Zheng wrote: The mm/vmscan.c file is too large, so separate the shrinker-related code from it into a separate file. No functional

Re: [PATCH v2 01/47] mm: vmscan: move shrinker-related code into a separate file

2023-07-24 Thread Qi Zheng
On 2023/7/25 10:35, Muchun Song wrote: On Jul 24, 2023, at 17:43, Qi Zheng wrote: The mm/vmscan.c file is too large, so separate the shrinker-related code from it into a separate file. No functional changes. Signed-off-by: Qi Zheng --- include/linux/shrinker.h | 3 + mm/Makefile

Re: [PATCH v2 24/47] drm/panfrost: dynamically allocate the drm-panfrost shrinker

2023-07-24 Thread Qi Zheng
Hi Steven, On 2023/7/24 19:17, Steven Price wrote: On 24/07/2023 10:43, Qi Zheng wrote: In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the drm-panfrost shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait

Re: [PATCH v2 03/47] mm: shrinker: add infrastructure for dynamically allocating shrinker

2023-07-24 Thread Qi Zheng
Hi Peter, On 2023/7/24 20:25, Peter Zijlstra wrote: On Mon, Jul 24, 2023 at 05:43:10PM +0800, Qi Zheng wrote: +void shrinker_unregister(struct shrinker *shrinker) +{ + struct dentry *debugfs_entry; + int debugfs_id; + + if (!shrinker || !(shrinker->flags &

RE: [PATCH] xen/dt: Rework the prototype of dt_property_read_string() to help Eclair

2023-07-24 Thread Henry Wang
Hi Julien, > -Original Message- > Subject: [PATCH] xen/dt: Rework the prototype of dt_property_read_string() > to help Eclair > > From: Julien Grall > > Eclair vXXX is unable to prove the parameter out_string will only be > used the return of dt_property_read_string() is 0. So it will

RE: [PATCH v2] xen/arm32: head: Widen the use of the temporary mapping

2023-07-24 Thread Henry Wang
Hi Julien, > -Original Message- > Subject: [PATCH v2] xen/arm32: head: Widen the use of the temporary > mapping > > From: Julien Grall > > At the moment, the temporary mapping is only used when the virtual > runtime region of Xen is clashing with the physical region. > > In follow-up

RE: [XEN PATCH v2] device_tree: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-07-24 Thread Henry Wang
Hi Federico, > -Original Message- > From: Xen-devel On Behalf Of > Federico Serafini > Sent: Monday, July 24, 2023 4:40 PM > To: xen-devel@lists.xenproject.org > Cc: consult...@bugseng.com; Federico Serafini > ; Stefano Stabellini > ; Julien Grall > Subject: [XEN PATCH v2] device_tree:

Re: [XEN PATCH v2] automation: add ECLAIR pipeline

2023-07-24 Thread Stefano Stabellini
On Mon, 24 Jul 2023, Simone Ballarin wrote: > Add two pipelines that analyze an ARM64 and a X86_64 build with the > ECLAIR static analyzer on the guidelines contained in Set1. > > The analysis configuration is stored in automation/eclair_analysis. > > All commits on the xen-project/xen:staging

Re: [XEN PATCH v2] device_tree: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-07-24 Thread Stefano Stabellini
On Mon, 24 Jul 2023, Federico Serafini wrote: > Give a name to unnamed parameters thus addressing violations of > MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with > named parameters"). > Keep consistency between parameter names and types used in function > declarations and

Re: [PATCH] docs: Correct name for xen-command-line.pandoc

2023-07-24 Thread Stefano Stabellini
On Mon, 24 Jul 2023, Leo Yan wrote: > In the commit d661611d08 ("docs/markdown: Switch to using pandoc, and > fix underscore escaping"), the documentation suffix was changed from > ".markdown" to ".pandoc"; however, the reference was missed to update. > > This patch updates the documentation name

Re: [XEN PATCH] docs/misra: document the usage of array range initializers

2023-07-24 Thread Stefano Stabellini
On Mon, 24 Jul 2023, Nicola Vetrini wrote: > The usage of a documented GNU extension that allows a range of elements > in an array to be initalized to the same value using a designated > initalizer is added to this document, to fully comply with > MISRA C:2012 Rule 1.1. > > Signed-off-by: Nicola

Re: [XEN PATCH 3/3] x86/irq: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-07-24 Thread Stefano Stabellini
On Mon, 24 Jul 2023, Federico Serafini wrote: > Give a name to unnamed parameters thus addressing violations of > MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with > named parameters"). > Keep consistency between parameter names and types used in function > declarations and

Re: [XEN PATCH 2/3] xen/arm: irq: address violations of MISRA C: 2012 Rules 8.2 and 8.3

2023-07-24 Thread Stefano Stabellini
On Mon, 24 Jul 2023, Federico Serafini wrote: > Give a name to unnamed parameters thus addressing violations of > MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with > named parameters"). > Keep consistency between parameter names and types used in function > declarations and

Re: [XEN PATCH 1/3] xen/irq: add missing parameter names

2023-07-24 Thread Stefano Stabellini
On Mon, 24 Jul 2023, Federico Serafini wrote: > -extern int pirq_guest_bind(struct vcpu *, struct pirq *, int will_share); > -extern void pirq_guest_unbind(struct domain *d, struct pirq *); > -extern void pirq_set_affinity(struct domain *d, int irq, const cpumask_t *); > -extern irq_desc_t

Re: [XEN PATCH v2] efi: mechanical renaming to address MISRA C:2012 Rule 5.3

2023-07-24 Thread Stefano Stabellini
On Mon, 24 Jul 2023, Nicola Vetrini wrote: > Rule 5.3 has the following headline: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope" > > The function parameters renamed in this patch are hiding a variable defined > in an enclosing scope. > >

Re: [PATCH] xen/dt: Rework the prototype of dt_property_read_string() to help Eclair

2023-07-24 Thread Stefano Stabellini
On Mon, 24 Jul 2023, Julien Grall wrote: > From: Julien Grall > > Eclair vXXX is unable to prove the parameter out_string will only be > used the return of dt_property_read_string() is 0. So it will consider > that MISRA C:2012 Rule 9.1 was violated. > > Rework the prototype so the string is

Re: [XEN PATCH v2] xen/arm/atomic: change parameter name in atomic_cmpxchg() definition

2023-07-24 Thread Stefano Stabellini
On Mon, 24 Jul 2023, Federico Serafini wrote: > Change parameter name from 'ptr' to 'v' in the function definition thus > addressing violations of MISRA C:2012 Rule 8.3: "All declarations of an > object or function shall use the same names and type qualifiers". > > No functional changes. > >

Re: [XEN PATCH] xen/sched: mechanical renaming to address MISRA C:2012 Rule 5.3

2023-07-24 Thread Stefano Stabellini
On Sat, 22 Jul 2023, Nicola Vetrini wrote: > On 22/07/23 01:06, Stefano Stabellini wrote: > > On Fri, 21 Jul 2023, Nicola Vetrini wrote: > > > Rule 5.3 has the following headline: > > > "An identifier declared in an inner scope shall not hide an > > > identifier declared in an outer scope" > > >

Re: [PATCH] automation: avoid duplicated builds of staging branch

2023-07-24 Thread Stefano Stabellini
On Mon, 24 Jul 2023, Oleksii wrote: > Hi Stefano, > > On Fri, 2023-07-21 at 18:18 -0700, Stefano Stabellini wrote: > > Hi Andrew, Oleksii, > > > > Please see below. > > > > It looks like you have configured your personal repositories to > > mirror > > upstream Xen: > > > >

Re: Python in Domain Configurations

2023-07-24 Thread Elliott Mitchell
On Fri, Jul 07, 2023 at 03:13:07PM -0700, Elliott Mitchell wrote: > > The only context I could find was 54fbaf446b and > https://wiki.xenproject.org/wiki/PythonInXlConfig which don't explain > the reasoning. > > Would the maintainers be amenable to revisiting the decision to remove > support for

[xen-unstable-smoke test] 181999: tolerable all pass - PUSHED

2023-07-24 Thread osstest service owner
flight 181999 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181999/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v6 06/15] cpufreq: Add Hardware P-State (HWP) driver

2023-07-24 Thread Jason Andryuk
On Mon, Jul 24, 2023 at 12:15 PM Jan Beulich wrote: > > On 24.07.2023 14:58, Jason Andryuk wrote: > > --- /dev/null > > +++ b/xen/arch/x86/acpi/cpufreq/hwp.c > > @@ -0,0 +1,521 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* > > + * hwp.c cpufreq driver to run Intel Hardware P-States

Re: [PATCH 6/8] mm/pdx: Standardize region validation wrt pdx compression

2023-07-24 Thread Julien Grall
Hi Alejandro, On 24/07/2023 13:18, Alejandro Vallejo wrote: On Fri, Jul 21, 2023 at 06:05:51PM +0100, Julien Grall wrote: Hi Alejandro, On 17/07/2023 17:03, Alejandro Vallejo wrote: +bool pdx_is_region_compressible(unsigned long smfn, unsigned long emfn) For newer interface, I would rather

Re: [XEN PATCH 2/3] xen/arm: irq: address violations of MISRA C: 2012 Rules 8.2 and 8.3

2023-07-24 Thread Julien Grall
Hi, On 24/07/2023 18:50, Federico Serafini wrote: Give a name to unnamed parameters thus addressing violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Keep consistency between parameter names and types used in function declarations and the

[XEN PATCH 3/3] x86/irq: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-07-24 Thread Federico Serafini
Give a name to unnamed parameters thus addressing violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Keep consistency between parameter names and types used in function declarations and the ones used in the corresponding function definitions,

[XEN PATCH 2/3] xen/arm: irq: address violations of MISRA C: 2012 Rules 8.2 and 8.3

2023-07-24 Thread Federico Serafini
Give a name to unnamed parameters thus addressing violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Keep consistency between parameter names and types used in function declarations and the ones used in the corresponding function definitions,

[XEN PATCH 0/3] IRQ: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-07-24 Thread Federico Serafini
This patch serie addresses violations of rules 8.2 and 8.3 related to the IRQ module. Changes are divided by architecture. No functional changes. Federico Serafini (3): xen/irq: add missing parameter names xen/arm: irq: address violations of MISRA C: 2012 Rules 8.2 and 8.3 x86/irq: address

[XEN PATCH 1/3] xen/irq: add missing parameter names

2023-07-24 Thread Federico Serafini
Add missing parameter names thus addressing violations of MISRA C:2012 Rule 8.2: "Function types shall be in prototype form with named parameters". No functional changes. Signed-off-by: Federico Serafini --- xen/include/xen/irq.h | 59 ---

Re: [PATCH v3 3/6] libxl: introduce MSR data in libxl_cpuid_policy

2023-07-24 Thread Anthony PERARD
On Thu, Jul 20, 2023 at 10:25:37AM +0200, Roger Pau Monne wrote: > --- > It would be nice to rename the json output field to 'cpu_policy' > instead of 'cpuid', so that it looks like: > > "cpu_policy": { > "cpuid": [ > { > "leaf": 7, > "subleaf": 0, >

[XEN PATCH v2] automation: add ECLAIR pipeline

2023-07-24 Thread Simone Ballarin
Add two pipelines that analyze an ARM64 and a X86_64 build with the ECLAIR static analyzer on the guidelines contained in Set1. The analysis configuration is stored in automation/eclair_analysis. All commits on the xen-project/xen:staging branch will be analyzed and their artifacts will be

Re: [PATCH v2] xen/arm32: head: Widen the use of the temporary mapping

2023-07-24 Thread Luca Fancellu
> On 24 Jul 2023, at 11:14, Julien Grall wrote: > > From: Julien Grall > > At the moment, the temporary mapping is only used when the virtual > runtime region of Xen is clashing with the physical region. > > In follow-up patches, we will rework how secondary CPU bring-up works > and it will

[PATCH v6 3/3] x86/microcode: Disable microcode update handler if DIS_MCU_UPDATE is set

2023-07-24 Thread Alejandro Vallejo
If IA32_MSR_MCU_CONTROL exists then it's possible a CPU may be unable to perform microcode updates. This is controlled through the DIS_MCU_LOAD bit and is intended for baremetal clouds where the owner may not trust the tenant to choose the microcode version in use. If we notice that bit being set

[PATCH v6 2/3] x86: Read MSR_ARCH_CAPS immediately after early_microcode_init()

2023-07-24 Thread Alejandro Vallejo
Move MSR_ARCH_CAPS read code from tsx_init() to early_cpu_init(). Because microcode updates might make them that MSR to appear/have different values we also must reload it after a microcode update in early_microcode_init(). Signed-off-by: Alejandro Vallejo Reviewed-by: Jan Beulich --- v6: *

[PATCH v6 1/3] x86/microcode: Ignore microcode loading interface for revision = -1

2023-07-24 Thread Alejandro Vallejo
Some hypervisors report ~0 as the microcode revision to mean "don't issue microcode updates". Ignore the microcode loading interface in that case. Signed-off-by: Alejandro Vallejo Reviewed-by: Jan Beulich --- v6: * Change message content and move severity WARNING -> INFO (Andrew) NOTE:

[PATCH v6 0/3] Prevent attempting updates known to fail

2023-07-24 Thread Alejandro Vallejo
Under certain conditions a CPU may not be able to perform microcode updates even if hardware exists to that effect. In particular: * If Xen runs under certain hypervisors they won't allow microcode updates, and will signal this fact by reporting a microcode revision of -1. * If the

[xen-unstable-smoke test] 181991: tolerable all pass - PUSHED

2023-07-24 Thread osstest service owner
flight 181991 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181991/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[XEN PATCH] docs/misra: document the usage of array range initializers

2023-07-24 Thread Nicola Vetrini
The usage of a documented GNU extension that allows a range of elements in an array to be initalized to the same value using a designated initalizer is added to this document, to fully comply with MISRA C:2012 Rule 1.1. Signed-off-by: Nicola Vetrini --- docs/misra/C-language-toolchain.rst | 4

Re: [PATCH v6 06/15] cpufreq: Add Hardware P-State (HWP) driver

2023-07-24 Thread Jan Beulich
On 24.07.2023 14:58, Jason Andryuk wrote: > --- /dev/null > +++ b/xen/arch/x86/acpi/cpufreq/hwp.c > @@ -0,0 +1,521 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * hwp.c cpufreq driver to run Intel Hardware P-States (HWP) > + * > + * Copyright (C) 2021 Jason Andryuk > + */ > + >

Xen Security Advisory 433 v1 - x86/AMD: Zenbleed

2023-07-24 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory XSA-433 x86/AMD: Zenbleed ISSUE DESCRIPTION = Researchers at Google have discovered Zenbleed, a hardware bug causing corruption of the vector registers. When a

Re: [PATCH v4 2/2] xen/riscv: introduce identity mapping

2023-07-24 Thread Oleksii
On Mon, 2023-07-24 at 16:11 +0200, Jan Beulich wrote: > On 24.07.2023 11:42, Oleksii Kurochko wrote: > > @@ -35,8 +36,10 @@ unsigned long __ro_after_init phys_offset; > >   * > >   * It might be needed one more page table in case when Xen load > > address > >   * isn't 2 MB aligned. > > + * > > +

[linux-linus test] 181989: regressions - FAIL

2023-07-24 Thread osstest service owner
flight 181989 linux-linus real [real] flight 181992 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181989/ http://logs.test-lab.xenproject.org/osstest/logs/181992/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[PATCH] vpci: add permission checks to map_range()

2023-07-24 Thread Roger Pau Monne
Just like it's done for the XEN_DOMCTL_memory_mapping hypercall, add the permissions checks to vPCI map_range(), which is used to map the BARs into the domain p2m. Adding those checks requires that for x86 PVH hardware domain builder the permissions are set before initializing the IOMMU, or else

Re: [PATCH v5 3/4] xen/ppc: Implement early serial printk on pseries

2023-07-24 Thread Shawn Anastasio
On 7/24/23 7:40 AM, Jan Beulich wrote: > On 21.07.2023 19:02, Shawn Anastasio wrote: >> On typical Power VMs (e.g. QEMU's -M pseries), a variety of services >> including an early serial console are provided by Open Firmware. >> Implement the required interfaces to call into Open Firmware and write

Re: [PATCH v4 1/2] xen/riscv: introduce function for physical offset calculation

2023-07-24 Thread Oleksii
On Mon, 2023-07-24 at 15:40 +0200, Jan Beulich wrote: > On 24.07.2023 11:42, Oleksii Kurochko wrote: > > @@ -19,9 +20,10 @@ struct mmu_desc { > > pte_t *pgtbl_base; > >  }; > >   > > -#define PHYS_OFFSET ((unsigned long)_start - XEN_VIRT_START) > > -#define LOAD_TO_LINK(addr) ((addr) -

Re: [XEN PATCH v2] efi: mechanical renaming to address MISRA C:2012 Rule 5.3

2023-07-24 Thread Jan Beulich
On 24.07.2023 16:26, Nicola Vetrini wrote: > Rule 5.3 has the following headline: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope" > > The function parameters renamed in this patch are hiding a variable defined > in an enclosing scope. > >

Re: [PATCH v3] ns16550: add support for polling mode when device tree is used

2023-07-24 Thread Jan Beulich
On 24.07.2023 16:27, Oleksii Kurochko wrote: > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -993,6 +993,8 @@ void __init console_init_preirq(void) > #endif > else if ( !strncmp(p, "none", 4) ) > continue; > +else if ( !strncmp(p,

[XEN PATCH v2] efi: mechanical renaming to address MISRA C:2012 Rule 5.3

2023-07-24 Thread Nicola Vetrini
Rule 5.3 has the following headline: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" The function parameters renamed in this patch are hiding a variable defined in an enclosing scope. The following rename is made: - s/cfg/file/ to distinguish

[PATCH v3] ns16550: add support for polling mode when device tree is used

2023-07-24 Thread Oleksii Kurochko
RISC-V doesn't support interrupts for the time being, so it would be nice to have polling mode. The patch adds new option to console='...,polling' which forces driver to use polling mode. If there is no interrupt property in UART node, then polling will be used.     According to 4.2.2 National

Re: [PATCH v4 2/2] xen/riscv: introduce identity mapping

2023-07-24 Thread Jan Beulich
On 24.07.2023 11:42, Oleksii Kurochko wrote: > @@ -35,8 +36,10 @@ unsigned long __ro_after_init phys_offset; > * > * It might be needed one more page table in case when Xen load address > * isn't 2 MB aligned. > + * > + * CONFIG_PAGING_LEVELS page tables are needed for identity mapping. >

Re: [PATCH v8 08/13] vpci/header: program p2m with guest BAR view

2023-07-24 Thread Roger Pau Monné
On Mon, Jul 24, 2023 at 03:31:56PM +0200, Jan Beulich wrote: > On 24.07.2023 15:16, Roger Pau Monné wrote: > > On Mon, Jul 24, 2023 at 12:43:26PM +0200, Jan Beulich wrote: > >> On 20.07.2023 02:32, Volodymyr Babchuk wrote: > >>> @@ -52,8 +66,8 @@ static int cf_check map_range( > >>> * -

Re: [PATCH v4 1/2] xen/riscv: introduce function for physical offset calculation

2023-07-24 Thread Jan Beulich
On 24.07.2023 11:42, Oleksii Kurochko wrote: > @@ -19,9 +20,10 @@ struct mmu_desc { > pte_t *pgtbl_base; > }; > > -#define PHYS_OFFSET ((unsigned long)_start - XEN_VIRT_START) > -#define LOAD_TO_LINK(addr) ((addr) - PHYS_OFFSET) > -#define LINK_TO_LOAD(addr) ((addr) + PHYS_OFFSET) >

Re: [XEN PATCH] xen/arm: p2m: refactor 'p2m_get_entry'

2023-07-24 Thread Julien Grall
On 24/07/2023 14:15, Nicola Vetrini wrote: On 21/07/23 12:01, Julien Grall wrote: Hi Nicola, I would add "to please ECLAIR" in the commit title. I would be against this. It's the MISRA assessor that needs to understand and agree on what has been done to claim MISRA compliance. A static

Re: [PATCH v8 08/13] vpci/header: program p2m with guest BAR view

2023-07-24 Thread Jan Beulich
On 24.07.2023 15:16, Roger Pau Monné wrote: > On Mon, Jul 24, 2023 at 12:43:26PM +0200, Jan Beulich wrote: >> On 20.07.2023 02:32, Volodymyr Babchuk wrote: >>> @@ -52,8 +66,8 @@ static int cf_check map_range( >>> * - {un}map_mmio_regions doesn't support preemption. >>> */ >>>

Re: [PATCH v8 08/13] vpci/header: program p2m with guest BAR view

2023-07-24 Thread Roger Pau Monné
On Mon, Jul 24, 2023 at 12:43:26PM +0200, Jan Beulich wrote: > On 20.07.2023 02:32, Volodymyr Babchuk wrote: > > @@ -52,8 +66,8 @@ static int cf_check map_range( > > * - {un}map_mmio_regions doesn't support preemption. > > */ > > > > -rc = map->map ?

Re: [PATCH] xen/dt: Rework the prototype of dt_property_read_string() to help Eclair

2023-07-24 Thread Julien Grall
Hi Nicola, On 24/07/2023 13:58, Nicola Vetrini wrote: On 24/07/23 12:24, Julien Grall wrote: From: Julien Grall Eclair vXXX is unable to prove the parameter out_string will only be used the return of dt_property_read_string() is 0. So it will consider that MISRA C:2012 Rule 9.1 was

Re: [XEN PATCH] xen/arm: p2m: refactor 'p2m_get_entry'

2023-07-24 Thread Nicola Vetrini
On 21/07/23 12:01, Julien Grall wrote: Hi Nicola, I would add "to please ECLAIR" in the commit title. I would be against this. It's the MISRA assessor that needs to understand and agree on what has been done to claim MISRA compliance. A static analysis tool is just a useful way to help

Re: [PATCH v5 0/4] Early serial on Power

2023-07-24 Thread Jan Beulich
On 21.07.2023 19:02, Shawn Anastasio wrote: > Changes in v5: > - (xen/macros.h) Add signoff > - (xen/macros.h) Fix up comment formatting and macro parameter names > - (*.S) Use 8-space column alignment for assembly > - (of-call.S) Add missing space after comma > - (asm-offsets.c) Fix

[PATCH v6 12/15] xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op

2023-07-24 Thread Jason Andryuk
Add SET_CPUFREQ_HWP xen_sysctl_pm_op to set HWP parameters. The sysctl supports setting multiple values simultaneously as indicated by the set_params bits. This allows atomically applying new HWP configuration via a single wrmsr. XEN_SYSCTL_HWP_SET_PRESET_BALANCE/PERFORMANCE/POWERSAVE provide

[PATCH v6 15/15] CHANGELOG: Add Intel HWP entry

2023-07-24 Thread Jason Andryuk
Signed-off-by: Jason Andryuk Acked-by: Henry Wang --- v3: Position under existing Added section Add Henry's Ack v2: Add blank line --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7d7e0590f8..8d6e6c3088 100644 ---

[PATCH v6 05/15] pmstat: Re-arrage for cpufreq union

2023-07-24 Thread Jason Andryuk
Rearrange code now that xen_sysctl_pm_op's get_para fields has the nested union and struct. In particular, the scaling governor information like scaling_available_governors is inside the union, so it is not always available. Move those fields (op->u.get_para.u.s.u.*) together as well as the

[PATCH v6 09/15] cpufreq: Export HWP parameters to userspace as CPPC

2023-07-24 Thread Jason Andryuk
Extend xen_get_cpufreq_para to return hwp parameters. HWP is an implementation of ACPI CPPC (Collaborative Processor Performance Control). Use the CPPC name since that might be useful in the future for AMD P-state. We need the features bitmask to indicate fields supported by the actual hardware

[PATCH v6 11/15] xenpm: Print HWP/CPPC parameters

2023-07-24 Thread Jason Andryuk
Print HWP-specific parameters. Some are always present, but others depend on hardware support. Signed-off-by: Jason Andryuk Reviewed-by: Jan Beulich --- v2: Style fixes Declare i outside loop Replace repearted hardware/configured limits with spaces Fixup for hw_ removal Use XEN_HWP_GOVERNOR

[PATCH v6 14/15] xenpm: Add set-cpufreq-cppc subcommand

2023-07-24 Thread Jason Andryuk
set-cpufreq-cppc allows setting the Hardware P-State (HWP) parameters. It can be run on all or just a single cpu. There are presets of balance, powersave & performance. Those can be further tweaked by param:val arguments as explained in the usage description. Parameter names are just checked

  1   2   3   >