Re: [PATCH v4 1/5] xen/ppc: Implement atomic.h

2023-09-11 Thread Jan Beulich
On 12.09.2023 01:56, Shawn Anastasio wrote: > On 9/11/23 6:33 AM, Jan Beulich wrote: >> On 09.09.2023 00:50, Shawn Anastasio wrote: >>> +static always_inline void read_atomic_size(const volatile void *p, void >>> *res, >>> + unsigned int size) >>> +{ >>> +

Re: [XEN PATCH 10/13] x86/viridian: address violations of MISRA C:2012 Rule 7.3

2023-09-11 Thread Paul Durrant
On 03/08/2023 11:22, Simone Ballarin wrote: From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity

Re: [PATCH v2 for-4.18?] x86: support data operand independent timing mode

2023-09-11 Thread Jan Beulich
On 12.09.2023 02:48, Henry Wang wrote: >> On Sep 11, 2023, at 23:01, Jan Beulich wrote: >> --- a/docs/misc/xen-command-line.pandoc >> +++ b/docs/misc/xen-command-line.pandoc >> @@ -788,6 +788,14 @@ Specify the size of the console debug tr >> additionally a trace buffer of the specified size is all

Re: [XEN PATCH v5 3/4] x86/viridian: address violations of MISRA C:2012 Rule 7.2

2023-09-11 Thread Paul Durrant
On 28/08/2023 12:03, Simone Ballarin wrote: From: Gianluca Luparini The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline states: "A 'u' or 'U' suffix shall be applied to all integer constants that are represented in an unsigned type". Add the 'U' suffix to integers liter

[linux-linus test] 182949: regressions - FAIL

2023-09-11 Thread osstest service owner
flight 182949 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182949/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 182531 test-amd64

Re: [PATCH RESEND v2 2/2] xen/arm: Enlarge identity map space to 127TiB

2023-09-11 Thread Leo Yan
Hi Henry, On Tue, Sep 12, 2023 at 03:01:30AM +, Henry Wang wrote: [...] > At Arm we also test Xen on AVA in our CI, but our setup is based on Yocto > meta-adlink-ampere layer [1]. Thanks for sharing the info. Yes, we (Linaro) also work with Yocto based on EWAOL [1] or TRS [2]. > >> Also,

Re: [PATCH RESEND v2 2/2] xen/arm: Enlarge identity map space to 127TiB

2023-09-11 Thread Henry Wang
Hi Leo, > On Sep 12, 2023, at 10:41, Leo Yan wrote: > > Hi Julien, > > On Mon, Sep 11, 2023 at 04:13:27PM +0100, Julien Grall wrote: >> Hi Leo, >> >> I know you said you will respin the series. I'd like to leave some comments >> to avoid having another round afterwards. > > Thanks! > >> On 0

[xen-unstable test] 182941: regressions - FAIL

2023-09-11 Thread osstest service owner
flight 182941 xen-unstable real [real] flight 182952 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182941/ http://logs.test-lab.xenproject.org/osstest/logs/182952/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: [PATCH RESEND v2 2/2] xen/arm: Enlarge identity map space to 127TiB

2023-09-11 Thread Leo Yan
Hi Julien, On Mon, Sep 11, 2023 at 04:13:27PM +0100, Julien Grall wrote: > Hi Leo, > > I know you said you will respin the series. I'd like to leave some comments > to avoid having another round afterwards. Thanks! > On 09/09/2023 09:34, Leo Yan wrote: > > On some platforms, the memory regions

RE: [EXT] Re: xen arm64 low power sleep support

2023-09-11 Thread Stefano Stabellini
On Mon, 11 Sep 2023, Anthony Chan wrote: > On Wed, 6 Sep 2023, Stefano Stabellini wrote: > > On Wed, 6 Sep 2023, Anthony Chan wrote: > > > Thanks, I've tried patches that stemmed from that discussion but > > > unfortunately, doesn't resolve the issue. In fact, the s2idle_loop > > > branch might no

Re: [XEN PATCH v2 1/5] automation: add python3's setuptools to containers

2023-09-11 Thread Stefano Stabellini
On Mon, 11 Sep 2023, Javi Merino wrote: > In preparation of dropping python distutils and moving to setuptools, > add the python3 setuptools module to the containers that need it. > > The centos7 container was building using python2. Change it to build > python scripts using python3. > > Debian

Re: [PATCH v6 00/13] xen/arm: Split MMU code as the prepration of MPU work

2023-09-11 Thread Henry Wang
Hi Ayan, > On Sep 11, 2023, at 22:03, Ayan Kumar Halder wrote: > > Hi Henry, > > On 08/09/2023 23:15, Stefano Stabellini wrote: >> >> I committed patches 1-5 >> >> On Mon, 28 Aug 2023, Henry Wang wrote: >>> >>> Henry Wang (9): >>> xen/arm: Introduce CONFIG_MMU Kconfig option >>> xen/arm6

Re: [PATCH v2 for-4.18?] x86: support data operand independent timing mode

2023-09-11 Thread Henry Wang
Hi Jan, > On Sep 11, 2023, at 23:01, Jan Beulich wrote: > > [1] specifies a long list of instructions which are intended to exhibit > timing behavior independent of the data they operate on. On certain > hardware this independence is optional, controlled by a bit in a new > MSR. Provide a comman

Re: [PATCH v6 08/13] xen/arm: Fold mmu_init_secondary_cpu() to head.S

2023-09-11 Thread Henry Wang
Hi Julien, > On Sep 11, 2023, at 22:51, Julien Grall wrote: > On 31/08/2023 10:16, Henry Wang wrote: >>> On Aug 31, 2023, at 17:12, Ayan Kumar Halder wrote: >>> >>> Hi Henry, >>> >>> On 28/08/2023 02:32, Henry Wang wrote: diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/h

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-11 Thread Stefano Stabellini
On Mon, 11 Sep 2023, Julien Grall wrote: > Hi Stefano, > > On 09/09/2023 00:03, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > During the discussions that led to the acceptance of Rule 2.1, we > > decided on a few exceptions that were not properly recorded in > > rules.rst. Add t

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-11 Thread Stefano Stabellini
On Mon, 11 Sep 2023, Jan Beulich wrote: > On 09.09.2023 01:03, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > During the discussions that led to the acceptance of Rule 2.1, we > > decided on a few exceptions that were not properly recorded in > > rules.rst. Add them now. > > > >

Re: [PATCH v4 1/5] xen/ppc: Implement atomic.h

2023-09-11 Thread Shawn Anastasio
On 9/11/23 6:33 AM, Jan Beulich wrote: > On 09.09.2023 00:50, Shawn Anastasio wrote: >> Implement atomic.h for PPC, based off of the original Xen 3.2 >> implementation. This implementation depends on some functions that are >> not yet defined (notably __cmpxchg), so it can't yet be used. >> >> Sign

Re: [PATCH] xen/arm: Skip Xen specific nodes/properties from hwdom /chosen node

2023-09-11 Thread Stefano Stabellini
On Mon, 11 Sep 2023, Michal Orzel wrote: > On 11/09/2023 16:48, Julien Grall wrote: > > On 11/09/2023 15:01, Michal Orzel wrote: > >> Hi Julien, > >> > >> On 11/09/2023 15:14, Julien Grall wrote: > >>> > >>> > >>> Hi, > >>> > >>> On 11/09/2023 13:34, Michal Orzel wrote: > Host device tree node

Re: [PATCH] xen/arm: Skip Xen specific nodes/properties from hwdom /chosen node

2023-09-11 Thread Stefano Stabellini
On Mon, 11 Sep 2023, Julien Grall wrote: > On 11/09/2023 13:34, Michal Orzel wrote: > > Host device tree nodes under /chosen with compatible string > > "xen,evtchn-v1", "xen,domain-shared-memory-v1" are Xen specific and not > > meant to be exposed to hardware domain. > > So, how dom0 is meant to d

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

2023-09-11 Thread Stefano Stabellini
On Mon, 11 Sep 2023, Andrew Cooper wrote: > Physical CPU Hotplug does not pass the bar for being anything more than > experimental.  It's absolutely not tech-preview level because the only > demo it has had in an environment (admittedly virtual) which does > implement the spec in a usable way demon

[qemu-mainline test] 182943: regressions - FAIL

2023-09-11 Thread osstest service owner
flight 182943 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182943/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 182707 build-i386

[xen-unstable-smoke test] 182948: tolerable all pass - PUSHED

2023-09-11 Thread osstest service owner
flight 182948 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182948/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[seabios test] 182944: tolerable FAIL - PUSHED

2023-09-11 Thread osstest service owner
flight 182944 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/182944/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 182507 test-amd64-amd64-qemuu-nested-amd 20 debi

[linux-linus test] 182923: regressions - FAIL

2023-09-11 Thread osstest service owner
flight 182923 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182923/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 182531 test-amd64

[PATCH] xen/efi: refactor deprecated strncpy

2023-09-11 Thread Justin Stitt
nfo.efi_loader_signature)); boot_params->efi_info.efi_systab = (__u32)__pa(efi_systab_xen); boot_params->efi_info.efi_systab_hi = (__u32)(__pa(efi_systab_xen) >> 32); --- base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c change-id: 20230911-strncpy-arch-x86-xen-efi-c-14292f5a79ee Best regards, -- Justin Stitt

Re: [PATCH] include: make domain_page.h's stubs properly use type-unsafe MFN <-> virt helpers

2023-09-11 Thread Shawn Anastasio
On 9/11/23 1:38 AM, Jan Beulich wrote: > The first of the commits referenced below didn't go far enough, and the > 2nd of them, while trying to close (some of) the gap, wrongly kept using > the potentially type-safe variant. This is getting in the way of new > ports preferably not having any type-u

[xen-unstable-smoke test] 182945: tolerable all pass - PUSHED

2023-09-11 Thread osstest service owner
flight 182945 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182945/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

2023-09-11 Thread Andrew Cooper
On 06/09/2023 9:49 pm, Stefano Stabellini wrote: > On Fri, 1 Sep 2023, Jan Beulich wrote: >> On 07.08.2023 11:38, Simon Gaiser wrote: >>> It seems some firmwares put dummy entries in the ACPI MADT table for non >>> existing processors. On my NUC11TNHi5 those have the invalid APIC ID >>> 0xff. Linux

Re: [PATCH v6 3/4] xen/vpci: header: status register handler

2023-09-11 Thread Stewart Hildebrand
On 9/11/23 07:10, Jan Beulich wrote: > On 09.09.2023 04:16, Stewart Hildebrand wrote: >> @@ -544,6 +545,18 @@ static int cf_check init_bars(struct pci_dev *pdev) >> if ( rc ) >> return rc; >> >> +/* >> + * If mask_cap_list is true, PCI_STATUS_CAP_LIST will be set in both >> +

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

2023-09-11 Thread Simon Gaiser
Jan Beulich: > On 07.08.2023 11:38, Simon Gaiser wrote: >> It seems some firmwares put dummy entries in the ACPI MADT table for non >> existing processors. On my NUC11TNHi5 those have the invalid APIC ID >> 0xff. Linux already has code to handle those cases both in >> acpi_parse_lapic [1] as well a

Re: [XEN PATCH] x86/ACPI: Ignore entries marked as unusable when parsing MADT

2023-09-11 Thread Simon Gaiser
Jan Beulich: > On 11.09.2023 12:12, Simon Gaiser wrote: >> Up to version 6.2 Errata B [2] the ACPI spec only defines >> ACPI_MADT_ENABLE as: >> >> If zero, this processor is unusable, and the operating system >> support will not attempt to use it. >> >> The bit that later will be ACPI_MADT_

Re: [PATCH] coverage: update gcov info for newer versions of gcc

2023-09-11 Thread Alex Bennée
Jan Beulich writes: > On 11.09.2023 17:26, Alex Bennée wrote: >> Jan Beulich writes: >>> On 02.09.2023 17:11, Javi Merino wrote: --- a/xen/common/coverage/Makefile +++ b/xen/common/coverage/Makefile @@ -5,7 +5,9 @@ obj-y += $(call cc-ifversion,-lt,0407, \ gcc_3_4

Re: [XEN PATCH v2] tools/xentrace/xentrace_format: Add python 3 compatibility

2023-09-11 Thread Andrew Cooper
On 11/09/2023 5:07 pm, Javi Merino wrote: > Resolves: xen-project/xen#155 > > Signed-off-by: Javi Merino Acked-by: Andrew Cooper

[XEN PATCH v2 5/5] README: update to remove old note about the build system's python expectation

2023-09-11 Thread Javi Merino
The configure script tests for the availability of python3, python and python2 in that order and sets PYTHON to the first one found in path. You don't need to have a symlink to python. Signed-off-by: Javi Merino --- README | 7 --- 1 file changed, 7 deletions(-) diff --git a/README b/README

[XEN PATCH v2 3/5] tools: don't use distutils in configure nor Makefile

2023-09-11 Thread Javi Merino
From: Marek Marczykowski-Górecki Python distutils is deprecated and is going to be removed in Python 3.12. The distutils.sysconfig is available as sysconfig module in stdlib since Python 3.2, so use that directly. Signed-off-by: Marek Marczykowski-Górecki --- m4/python_devel.m4 | 28

[XEN PATCH v2 2/5] tools: convert setup.py to use setuptools

2023-09-11 Thread Javi Merino
From: Marek Marczykowski-Górecki Python distutils is deprecated and is going to be removed in Python 3.12. Migrate to setuptools. Setuptools in Python 3.11 complains: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools. Keep using setup

[XEN PATCH v2 1/5] automation: add python3's setuptools to containers

2023-09-11 Thread Javi Merino
In preparation of dropping python distutils and moving to setuptools, add the python3 setuptools module to the containers that need it. The centos7 container was building using python2. Change it to build python scripts using python3. Debian Stretch is no longer debian oldstable, so move to the

[XEN PATCH v2 0/5] python: Use setuptools instead of the deprecated distutils

2023-09-11 Thread Javi Merino
This series picks up Marek's v1 from https://lore.kernel.org/xen-devel/20230316171634.320626-1-marma...@invisiblethingslab.com/ Changes since v1: - Update all containers to have setuptools, as python 3.12 depecrates distutils in favour of setuptools - Keep python2's support by falling back to

Re: [PATCH v6 08/13] xen/arm: Fold mmu_init_secondary_cpu() to head.S

2023-09-11 Thread Ayan Kumar Halder
Hi Julien, On 11/09/2023 15:51, Julien Grall wrote: On 31/08/2023 10:16, Henry Wang wrote: On Aug 31, 2023, at 17:12, Ayan Kumar Halder wrote: Hi Henry, On 28/08/2023 02:32, Henry Wang wrote: diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index 33b038e7e0..39218cf15f

Re: [PATCH] build: restrict gcc11 workaround to versions earlier than 11.3.0

2023-09-11 Thread Julien Grall
Hi Jan, On 22/08/2023 15:40, Jan Beulich wrote: The fix for this issue was backported to 11.3, so let's not unduly engage the workaround. Signed-off-by: Jan Beulich Acked-by: Julien Grall Cheers, -- Julien Grall

[XEN PATCH v2] tools/xentrace/xentrace_format: Add python 3 compatibility

2023-09-11 Thread Javi Merino
Resolves: xen-project/xen#155 Signed-off-by: Javi Merino --- Changes since v1: - Remove unneeded import from past.utils to avoid depending on python3's future module. Tested using the format file in tools/xentrace/formats. With this patch, both python 2.7.18.6 and python 3.10.12 produce th

Re: [PATCH] coverage: update gcov info for newer versions of gcc

2023-09-11 Thread Jan Beulich
On 11.09.2023 17:26, Alex Bennée wrote: > Jan Beulich writes: >> On 02.09.2023 17:11, Javi Merino wrote: >>> --- a/xen/common/coverage/Makefile >>> +++ b/xen/common/coverage/Makefile >>> @@ -5,7 +5,9 @@ obj-y += $(call cc-ifversion,-lt,0407, \ >>> gcc_3_4.o, $(call cc-ifversion,-lt,040

RE: [EXT] Re: xen arm64 low power sleep support

2023-09-11 Thread Anthony Chan
On Wed, 6 Sep 2023, Stefano Stabellini wrote: > On Wed, 6 Sep 2023, Anthony Chan wrote: > > Thanks, I've tried patches that stemmed from that discussion but > > unfortunately, doesn't resolve the issue. In fact, the s2idle_loop > > branch might not be the problem at all. I experimented with Xen t

Re: [PATCH] coverage: update gcov info for newer versions of gcc

2023-09-11 Thread Alex Bennée
Jan Beulich writes: > On 02.09.2023 17:11, Javi Merino wrote: >> --- a/xen/common/coverage/Makefile >> +++ b/xen/common/coverage/Makefile >> @@ -5,7 +5,9 @@ obj-y += $(call cc-ifversion,-lt,0407, \ >> gcc_3_4.o, $(call cc-ifversion,-lt,0409, \ This isn't even supported, see below:

Ping: [PATCH] build: restrict gcc11 workaround to versions earlier than 11.3.0

2023-09-11 Thread Jan Beulich
On 22.08.2023 16:40, Jan Beulich wrote: > The fix for this issue was backported to 11.3, so let's not unduly > engage the workaround. > > Signed-off-by: Jan Beulich Anyone? Please? Thanks, Jan > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -146,7 +146,8 @@ > __

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-11 Thread Julien Grall
Hi Stefano, On 09/09/2023 00:03, Stefano Stabellini wrote: From: Stefano Stabellini During the discussions that led to the acceptance of Rule 2.1, we decided on a few exceptions that were not properly recorded in rules.rst. Add them now. Signed-off-by: Stefano Stabellini Acked-by: Jan Beulic

Re: [XEN PATCH] xen/PCI: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-09-11 Thread Jan Beulich
On 11.09.2023 17:13, Federico Serafini wrote: > On 11/09/23 10:42, Jan Beulich wrote: >> On 11.09.2023 10:15, Federico Serafini wrote: >>> Add missing parameter names and make function declarations and >>> definitions consistent. No functional change. >>> >>> Signed-off-by: Federico Serafini >> >>

Re: [XEN PATCH] xen/PCI: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-09-11 Thread Federico Serafini
On 11/09/23 10:42, Jan Beulich wrote: On 11.09.2023 10:15, Federico Serafini wrote: Add missing parameter names and make function declarations and definitions consistent. No functional change. Signed-off-by: Federico Serafini Since formally correct: Acked-by: Jan Beulich Nevertheless, it i

Re: [PATCH RESEND v2 2/2] xen/arm: Enlarge identity map space to 127TiB

2023-09-11 Thread Julien Grall
Hi Leo, I know you said you will respin the series. I'd like to leave some comments to avoid having another round afterwards. On 09/09/2023 09:34, Leo Yan wrote: On some platforms, the memory regions could be: Can you add some details in the commit message on which platform you saw the iss

Re: [PATCH] xen/arm: Skip Xen specific nodes/properties from hwdom /chosen node

2023-09-11 Thread Michal Orzel
On 11/09/2023 16:48, Julien Grall wrote: > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 11/09/2023 15:01, Michal Orzel wrote: >> Hi Julien, >> >> On 11/09/2023 15:14, Julien Grall wrote: >>> >>

Re: [PATCH] OvmfPkg/OvmfXen: Fix S3

2023-09-11 Thread Anthony PERARD
Hi Xenia, On Thu, Jul 13, 2023 at 01:47:12PM +0300, Xenia Ragiadakou wrote: > Currently, resuming an S3 suspended guest results in the following > assertion failure: > ASSERT > MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.c(41): > MemoryLength > 0 > This happens because som

[PATCH v2 for-4.18?] x86: support data operand independent timing mode

2023-09-11 Thread Jan Beulich
[1] specifies a long list of instructions which are intended to exhibit timing behavior independent of the data they operate on. On certain hardware this independence is optional, controlled by a bit in a new MSR. Provide a command line option to control the mode Xen and its guests are to operate i

Re: [PATCH] include: make domain_page.h's stubs properly use type-unsafe MFN <-> virt helpers

2023-09-11 Thread Julien Grall
Hi Jan, On 11/09/2023 07:38, Jan Beulich wrote: The first of the commits referenced below didn't go far enough, and the 2nd of them, while trying to close (some of) the gap, wrongly kept using the potentially type-safe variant. This is getting in the way of new ports preferably not having any ty

Re: [PATCH v6 08/13] xen/arm: Fold mmu_init_secondary_cpu() to head.S

2023-09-11 Thread Julien Grall
On 31/08/2023 10:16, Henry Wang wrote: On Aug 31, 2023, at 17:12, Ayan Kumar Halder wrote: Hi Henry, On 28/08/2023 02:32, Henry Wang wrote: diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index 33b038e7e0..39218cf15f 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch

Re: [PATCH] xen/arm: Skip Xen specific nodes/properties from hwdom /chosen node

2023-09-11 Thread Julien Grall
On 11/09/2023 15:01, Michal Orzel wrote: Hi Julien, On 11/09/2023 15:14, Julien Grall wrote: Hi, On 11/09/2023 13:34, Michal Orzel wrote: Host device tree nodes under /chosen with compatible string "xen,evtchn-v1", "xen,domain-shared-memory-v1" are Xen specific and not meant to be expose

Re: [PATCH v4 3/5] xen/ppc: Define minimal stub headers required for full build

2023-09-11 Thread Jan Beulich
On 09.09.2023 00:50, Shawn Anastasio wrote: > Additionally, change inclusion of asm/ headers to corresponding xen/ ones > throughout arch/ppc now that they work. > > Signed-off-by: Shawn Anastasio Acked-by: Jan Beulich albeit ... > > xen/arch/ppc/Kconfig | 1 + > xen/ar

Re: [PATCH] cmdline: move irq-max-guests doc entry

2023-09-11 Thread Jan Beulich
On 11.09.2023 16:34, George Dunlap wrote: > On Thu, Sep 7, 2023 at 3:17 PM Jan Beulich wrote: >> >> ... to adhere to intended sorting. >> >> Fixes: e373bc1bdc59 ("x86/IRQ: make max number of guests for a shared IRQ >> configurable") > > This seems a bit strong, but in any case... I can drop it

Re: [PATCH] cmdline: move irq-max-guests doc entry

2023-09-11 Thread George Dunlap
On Thu, Sep 7, 2023 at 3:17 PM Jan Beulich wrote: > > ... to adhere to intended sorting. > > Fixes: e373bc1bdc59 ("x86/IRQ: make max number of guests for a shared IRQ > configurable") This seems a bit strong, but in any case... > Signed-off-by: Jan Beulich Acked-by: George Dunlap

[ovmf test] 182940: all pass - PUSHED

2023-09-11 Thread osstest service owner
flight 182940 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182940/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a5cbb5990593559eb9d93ebd1df1e8da0fa5d72b baseline version: ovmf cc26a2cb3162845bf51d4

Re: [PATCH v6 00/13] xen/arm: Split MMU code as the prepration of MPU work

2023-09-11 Thread Ayan Kumar Halder
Hi Henry, On 08/09/2023 23:15, Stefano Stabellini wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. I committed patches 1-5 On Mon, 28 Aug 2023, Henry Wang wrote:

[qemu-mainline test] 182929: regressions - FAIL

2023-09-11 Thread osstest service owner
flight 182929 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182929/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 182707 build-i386

Re: [PATCH] xen/arm: Skip Xen specific nodes/properties from hwdom /chosen node

2023-09-11 Thread Michal Orzel
Hi Julien, On 11/09/2023 15:14, Julien Grall wrote: > > > Hi, > > On 11/09/2023 13:34, Michal Orzel wrote: >> Host device tree nodes under /chosen with compatible string >> "xen,evtchn-v1", "xen,domain-shared-memory-v1" are Xen specific and not >> meant to be exposed to hardware domain. > > So

[XEN v1 4/4] xen/arm: traps.c: Enclose VMSA specific registers within CONFIG_MMU

2023-09-11 Thread Ayan Kumar Halder
The VMSA specific registers (ie TCR, TTBR0, TTBR1, VTTBR, etc) are valid when MMU is used, thus we can enclose them with CONFIG_MMU. Signed-off-by: Ayan Kumar Halder --- xen/arch/arm/traps.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/traps

[XEN v1 3/4] xen/arm32: Split and move MMU-specific head.S to mmu/head.S

2023-09-11 Thread Ayan Kumar Halder
This is based on "[PATCH v6 03/13] xen/arm64: Split and move MMU-specific head.S to mmu/head.S" https://www.mail-archive.com/xen-devel@lists.xenproject.org/msg151920.html Signed-off-by: Ayan Kumar Halder --- xen/arch/arm/arm32/head.S | 603 +--- xen/arch/arm/ar

[XEN v1 2/4] xen/arm32: head.S: Introduce enable_{boot,secondary}_cpu_mm()

2023-09-11 Thread Ayan Kumar Halder
This is based on:- "[PATCH v6 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm()" https://www.mail-archive.com/xen-devel@lists.xenproject.org/msg151918.html This is being done for Arm32 as MPU support will be added for Arm32 as well. Signed-off-by: Ayan Kumar Halder --- xen/ar

[XEN v1 1/4] xen/arm: arm32: Move pt_enforce_wxn() so that it can be bundled with other MMU functionality

2023-09-11 Thread Ayan Kumar Halder
pt_enforce_wxn() is moved up (as the previous instruction ie mov_w has no effect on this). This way it is grouped with other MMU related functions so that they can be moved together in the subsequent patch. Signed-off-by: Ayan Kumar Halder --- This is based on my comment on "[PATCH v6 08/13] xen/

[XEN v1 0/4] xen/arm: Split MMU code as the prepration of MPU work form Arm32

2023-09-11 Thread Ayan Kumar Halder
Hi, These are the set of patches based on top of "[PATCH v6 00/13] xen/arm: Split MMU code as the prepration of MPU work". These patches aim to do similar MMU rework for Arm32. Similar to the former series, this is the preparation work to add MPU support for Arm32. Ayan Kumar Halder (4): xen/a

Re: [PATCH v1] tools/xentrace/xentrace_format: Add python 3 compatibility

2023-09-11 Thread Javi Merino
On Mon, Sep 11, 2023 at 02:45:56PM +0100, Andrew Cooper wrote: > On 11/09/2023 2:44 pm, Javi Merino wrote: > > On Mon, Sep 11, 2023 at 11:52:43AM +0100, Andrew Cooper wrote: > >> On 06/09/2023 2:14 pm, Javi Merino wrote: > >>> diff --git a/tools/xentrace/xentrace_format > >>> b/tools/xentrace/xent

Re: [PATCH v4 2/5] xen/ppc: Implement bitops.h

2023-09-11 Thread Jan Beulich
On 09.09.2023 00:50, Shawn Anastasio wrote: > +/** > + * test_bit - Determine whether a bit is set > + * @nr: bit number to test > + * @addr: Address to start counting from > + */ > +static inline int test_bit(int nr, const volatile void *addr) > +{ > +const volatile unsigned long *p = (const v

Re: [PATCH v1] tools/xentrace/xentrace_format: Add python 3 compatibility

2023-09-11 Thread Andrew Cooper
On 11/09/2023 2:44 pm, Javi Merino wrote: > On Mon, Sep 11, 2023 at 11:52:43AM +0100, Andrew Cooper wrote: >> On 06/09/2023 2:14 pm, Javi Merino wrote: >>> diff --git a/tools/xentrace/xentrace_format b/tools/xentrace/xentrace_format >>> index 5ff85ae2e8..166ebae325 100644 >>> --- a/tools/xentrace/x

Re: [PATCH v1] tools/xentrace/xentrace_format: Add python 3 compatibility

2023-09-11 Thread Javi Merino
On Mon, Sep 11, 2023 at 11:52:43AM +0100, Andrew Cooper wrote: > On 06/09/2023 2:14 pm, Javi Merino wrote: > > diff --git a/tools/xentrace/xentrace_format b/tools/xentrace/xentrace_format > > index 5ff85ae2e8..166ebae325 100644 > > --- a/tools/xentrace/xentrace_format > > +++ b/tools/xentrace/xentr

Re: [PATCH] xen/arm: Skip Xen specific nodes/properties from hwdom /chosen node

2023-09-11 Thread Julien Grall
Hi, On 11/09/2023 13:34, Michal Orzel wrote: Host device tree nodes under /chosen with compatible string "xen,evtchn-v1", "xen,domain-shared-memory-v1" are Xen specific and not meant to be exposed to hardware domain. So, how dom0 is meant to discover the static event channel, shared memory it

Re: [PATCH] tools/misc/xencov_split: Add python 3 compatibility

2023-09-11 Thread Javi Merino
On Mon, Sep 11, 2023 at 11:40:59AM +0100, Anthony PERARD wrote: > On Sat, Sep 02, 2023 at 05:21:08PM +0100, Javi Merino wrote: > > diff --git a/tools/misc/xencov_split b/tools/misc/xencov_split > > index e4f68ebb6e..8f1271bfe7 100755 > > --- a/tools/misc/xencov_split > > +++ b/tools/misc/xencov_spl

[xen-unstable test] 182912: tolerable FAIL

2023-09-11 Thread osstest service owner
flight 182912 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182912/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 182849 test-amd64-i386-xl-qemuu-win7-amd64

[PATCH] xen/arm: Skip Xen specific nodes/properties from hwdom /chosen node

2023-09-11 Thread Michal Orzel
Host device tree nodes under /chosen with compatible string "xen,evtchn-v1", "xen,domain-shared-memory-v1" are Xen specific and not meant to be exposed to hardware domain. The same applies to "xen,static-heap" property. Skip them from being included into hwdom /chosen node. Signed-off-by: Michal O

[qemu-mainline bisection] complete build-i386-xsm

2023-09-11 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-i386-xsm testid xen-build Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu https://gitlab.com/qemu-project/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tr

Re: [PATCH v4 09/10] xen/arm: fix duplicate /reserved-memory node in Dom0

2023-09-11 Thread Michal Orzel
Hi Penny, On 11/09/2023 12:39, Penny Zheng wrote: > > > Hi Michal > > On 2023/9/11 17:40, Michal Orzel wrote: >> Hi Penny, >> >> On 11/09/2023 06:04, Penny Zheng wrote: >>> >>> >>> In case there is a /reserved-memory node already present in the host dtb, >>> current Xen codes would create yet a

Re: [PATCH v4 1/5] xen/ppc: Implement atomic.h

2023-09-11 Thread Jan Beulich
On 09.09.2023 00:50, Shawn Anastasio wrote: > Implement atomic.h for PPC, based off of the original Xen 3.2 > implementation. This implementation depends on some functions that are > not yet defined (notably __cmpxchg), so it can't yet be used. > > Signed-off-by: Shawn Anastasio Acked-by: Jan Be

Re: [PATCH 6/7] block: Clean up local variable shadowing

2023-09-11 Thread Ilya Dryomov
On Thu, Aug 31, 2023 at 3:25 PM Markus Armbruster wrote: > > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: delete inner declarations when they are actually redundant, > else rename variabl

Re: [PATCH v6 3/4] xen/vpci: header: status register handler

2023-09-11 Thread Jan Beulich
On 09.09.2023 04:16, Stewart Hildebrand wrote: > @@ -544,6 +545,18 @@ static int cf_check init_bars(struct pci_dev *pdev) > if ( rc ) > return rc; > > +/* > + * If mask_cap_list is true, PCI_STATUS_CAP_LIST will be set in both > + * rsvdz_mask and ro_mask, and thus will

Re: [PATCH 2/2] tools/light: Revoke permissions when a PCI detach for HVM domain

2023-09-11 Thread Anthony PERARD
On Thu, Aug 24, 2023 at 06:27:12PM +0100, Julien Grall wrote: > On 24/08/2023 17:58, Anthony PERARD wrote: > > On Thu, Aug 24, 2023 at 05:46:45PM +0100, Julien Grall wrote: > > > On 24/08/2023 17:34, Anthony PERARD wrote: > > > > On Thu, Aug 24, 2023 at 12:15:39PM +0100, Julien Grall wrote: > > > >

Re: [PATCH v4 00/10] Follow-up static shared memory PART I

2023-09-11 Thread Penny Zheng
Hi Michal On 2023/9/11 17:01, Michal Orzel wrote: Hi Penny, On 11/09/2023 06:04, Penny Zheng wrote: There are some unsolving issues on current 4.17 static shared memory feature[1], including: - In order to avoid keeping growing 'membank', having the shared memory info in separate structures

Re: [PATCH v4 04/10] xen/arm: use paddr_assigned to indicate whether host address is provided

2023-09-11 Thread Penny Zheng
Hi, On 2023/9/11 12:04, Penny Zheng wrote: We use paddr_assigned to indicate whether host address is provided, by checking the length of "xen,shared-mem" property. The shm matching criteria shall also be adapt to cover the new scenario, by adding when host address is not provided, if SHMID matc

Re: [PATCH v4 09/10] xen/arm: fix duplicate /reserved-memory node in Dom0

2023-09-11 Thread Penny Zheng
Hi Michal On 2023/9/11 17:40, Michal Orzel wrote: Hi Penny, On 11/09/2023 06:04, Penny Zheng wrote: In case there is a /reserved-memory node already present in the host dtb, current Xen codes would create yet another /reserved-memory node specially s/codes/code/ for the static shm in Dom0

[xen-unstable-smoke test] 182930: tolerable all pass - PUSHED

2023-09-11 Thread osstest service owner
flight 182930 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182930/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v1] tools/xentrace/xentrace_format: Add python 3 compatibility

2023-09-11 Thread Andrew Cooper
On 06/09/2023 2:14 pm, Javi Merino wrote: > diff --git a/tools/xentrace/xentrace_format b/tools/xentrace/xentrace_format > index 5ff85ae2e8..166ebae325 100644 > --- a/tools/xentrace/xentrace_format > +++ b/tools/xentrace/xentrace_format > @@ -4,11 +4,15 @@ > > # Program for reformatting trace bu

Re: [XEN PATCH] x86/ACPI: Ignore entries marked as unusable when parsing MADT

2023-09-11 Thread Jan Beulich
On 11.09.2023 12:12, Simon Gaiser wrote: > Up to version 6.2 Errata B [2] the ACPI spec only defines > ACPI_MADT_ENABLE as: > > If zero, this processor is unusable, and the operating system > support will not attempt to use it. > > The bit that later will be ACPI_MADT_ONLINE_CAPABLE is re

Re: [PATCH 6/7] block: Clean up local variable shadowing

2023-09-11 Thread Anthony PERARD
On Thu, Aug 31, 2023 at 03:25:45PM +0200, Markus Armbruster wrote: > diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c > index 3906b9058b..a07cd7eb5d 100644 > --- a/hw/block/xen-block.c > +++ b/hw/block/xen-block.c > @@ -369,7 +369,7 @@ static void xen_block_get_vdev(Object *obj, Visitor *v,

Re: [PATCH v2] tools/misc/xencov_split: Add python 3 compatibility

2023-09-11 Thread Andrew Cooper
On 05/09/2023 9:15 pm, Javi Merino wrote: > Closes #154 This wants to be: Resolves: xen-project/xen#154 I'll fix on commit. > Signed-off-by: Javi Merino Acked-by: Andrew Cooper

Re: [PATCH] tools/misc/xencov_split: Add python 3 compatibility

2023-09-11 Thread Anthony PERARD
On Sat, Sep 02, 2023 at 05:21:08PM +0100, Javi Merino wrote: > diff --git a/tools/misc/xencov_split b/tools/misc/xencov_split > index e4f68ebb6e..8f1271bfe7 100755 > --- a/tools/misc/xencov_split > +++ b/tools/misc/xencov_split > @@ -1,5 +1,7 @@ > -#!/usr/bin/env python > +#!/usr/bin/env python3 B

Re: [XEN PATCH v2 1/2] coverage: simplify the logic of choosing the number of gcov counters depending on the gcc version

2023-09-11 Thread Jan Beulich
On 11.09.2023 11:59, Andrew Cooper wrote: > On 11/09/2023 10:53 am, Jan Beulich wrote: >> On 11.09.2023 11:48, Andrew Cooper wrote: >>> On 11/09/2023 8:54 am, Jan Beulich wrote: On 08.09.2023 18:20, Javi Merino wrote: > The current structure of choosing the correct file based on the >

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

2023-09-11 Thread Simon Gaiser
Andrew Cooper: > On 07/08/2023 3:45 pm, Simon Gaiser wrote: >> Andrew Cooper: >>> On 07/08/2023 10:38 am, Simon Gaiser wrote: It seems some firmwares put dummy entries in the ACPI MADT table for non existing processors. On my NUC11TNHi5 those have the invalid APIC ID 0xff. Linux alre

[XEN PATCH] x86/ACPI: Ignore entries marked as unusable when parsing MADT

2023-09-11 Thread Simon Gaiser
Up to version 6.2 Errata B [2] the ACPI spec only defines ACPI_MADT_ENABLE as: If zero, this processor is unusable, and the operating system support will not attempt to use it. The bit that later will be ACPI_MADT_ONLINE_CAPABLE is reserved with "Must be zero". Version 6.3 [3] then adds

Re: [XEN PATCH v2 1/2] coverage: simplify the logic of choosing the number of gcov counters depending on the gcc version

2023-09-11 Thread Andrew Cooper
On 11/09/2023 10:53 am, Jan Beulich wrote: > On 11.09.2023 11:48, Andrew Cooper wrote: >> On 11/09/2023 8:54 am, Jan Beulich wrote: >>> On 08.09.2023 18:20, Javi Merino wrote: The current structure of choosing the correct file based on the compiler version makes us make 33 line files just

Re: [XEN PATCH v2 1/2] coverage: simplify the logic of choosing the number of gcov counters depending on the gcc version

2023-09-11 Thread Jan Beulich
On 11.09.2023 11:48, Andrew Cooper wrote: > On 11/09/2023 8:54 am, Jan Beulich wrote: >> On 08.09.2023 18:20, Javi Merino wrote: >>> The current structure of choosing the correct file based on the >>> compiler version makes us make 33 line files just to define a >>> constant. The changes after gcc

Re: [XEN PATCH v2 1/2] coverage: simplify the logic of choosing the number of gcov counters depending on the gcc version

2023-09-11 Thread Andrew Cooper
On 11/09/2023 8:54 am, Jan Beulich wrote: > On 08.09.2023 18:20, Javi Merino wrote: >> The current structure of choosing the correct file based on the >> compiler version makes us make 33 line files just to define a >> constant. The changes after gcc 4.7 are minimal, just the number of >> counters

[PATCH v6 05/45] xenbus/backend: dynamically allocate the xen-backend shrinker

2023-09-11 Thread Qi Zheng
Use new APIs to dynamically allocate the xen-backend shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Acked-by: Juergen Gross CC: Stefano Stabellini CC: Oleksandr Tyshchenko CC: xen-devel@lists.xenproject.org --- drivers/xen/xenbus/xenbus_probe_backend.c | 17 ++--- 1 f

Re: [PATCH v4 09/10] xen/arm: fix duplicate /reserved-memory node in Dom0

2023-09-11 Thread Michal Orzel
Hi Penny, On 11/09/2023 06:04, Penny Zheng wrote: > > > In case there is a /reserved-memory node already present in the host dtb, > current Xen codes would create yet another /reserved-memory node specially s/codes/code/ > for the static shm in Dom0 Device Tree. > > Xen will use write_properti

Re: [XEN PATCH v2 2/2] coverage: update gcov info for newer versions of gcc

2023-09-11 Thread Javi Merino
On Mon, Sep 11, 2023 at 10:00:14AM +0200, Jan Beulich wrote: > On 08.09.2023 18:20, Javi Merino wrote: > > Shamelessly copy changes to gcov_info structures from linux so that we > > can capture coverage for xen built with newer compilers. > > > > Signed-off-by: Javi Merino > > --- > > xen/common

Re: [XEN PATCH v2 1/2] coverage: simplify the logic of choosing the number of gcov counters depending on the gcc version

2023-09-11 Thread Javi Merino
On Mon, Sep 11, 2023 at 09:54:53AM +0200, Jan Beulich wrote: > On 08.09.2023 18:20, Javi Merino wrote: > > The current structure of choosing the correct file based on the > > compiler version makes us make 33 line files just to define a > > constant. The changes after gcc 4.7 are minimal, just the

  1   2   >