flight 183960 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/183960/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm
On 12/1/23 01:57, Stefan Hajnoczi wrote:
On Thu, Nov 30, 2023 at 10:14:47AM +0100, Ilya Leoshkevich wrote:
On Wed, 2023-11-29 at 16:26 -0500, Stefan Hajnoczi wrote:
The name "iothread" is overloaded. Use the term Big QEMU Lock (BQL)
instead, it is already widely used and unambiguous.
On 01.12.2023 03:47, Stefano Stabellini wrote:
> On Wed, 29 Nov 2023, Nicola Vetrini wrote:
>> No functional change.
>>
>> Signed-off-by: Nicola Vetrini
>> ---
>> The preferred way to deviate is to use asmlinkage, but this modification is
>> only
>> the consequence of NUMA on ARM (and possibly
On 30.11.2023 23:30, Stefano Stabellini wrote:
> Hi everyone following this thread,
>
> please see:
> https://marc.info/?l=xen-devel=170135718323946
> https://cryptpad.fr/form/#/2/form/view/7ByH95Vd7KiDOvN4wjV5iUGlMuZbkVdwk7cYpZdluWo/
>
> For a vote on the usage of the word "broken"
So I did
On 30.11.2023 23:57, Tamas K Lengyel wrote:
> I think this form is bad and is not helpful. We ought to be able to
> recommend an alternative term beside "broken" and "deprecated". I
> would not use the term broken in this context but that also doesn't
> mean we shouldn't use it in any context. But
On 30.11.2023 18:06, Stewart Hildebrand wrote:
> On 11/30/23 03:33, Jan Beulich wrote:
>> On 30.11.2023 03:47, Stewart Hildebrand wrote:
>>> On 11/14/23 04:13, Jan Beulich wrote:
On 13.11.2023 23:21, Stewart Hildebrand wrote:
> --- a/xen/arch/x86/include/asm/domain.h
> +++
On 30.11.2023 18:37, Roger Pau Monné wrote:
> On Thu, Nov 30, 2023 at 05:55:07PM +0100, Jan Beulich wrote:
>> On 28.11.2023 11:03, Roger Pau Monne wrote:
>>> The minimal function size requirements for livepatch are either 5 bytes (for
>>> jmp) or 9 bytes (for endbr + jmp). Ensure that functions
On Wed, 2023-11-29 at 16:26 -0500, Stefan Hajnoczi wrote:
> The Big QEMU Lock (BQL) has many names and they are confusing. The
> actual QemuMutex variable is called qemu_global_mutex but it's
> commonly
> referred to as the BQL in discussions and some code comments. The
> locking APIs, however,
Hi Stefan,
On 11/30/23 02:56, Stefan Hajnoczi wrote:
The Big QEMU Lock (BQL) has many names and they are confusing. The
actual QemuMutex variable is called qemu_global_mutex but it's commonly
referred to as the BQL in discussions and some code comments. The
locking APIs, however, are called
flight 183952 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/183952/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 183938
On Thu, 30 Nov 2023, Roger Pau Monné wrote:
> On Wed, Nov 29, 2023 at 07:53:59PM -0800, Stefano Stabellini wrote:
> > On Fri, 24 Nov 2023, Jiqian Chen wrote:
> > > This patch is to solve two problems we encountered when we try to
> > > passthrough a device to hvm domU base on Xen PVH dom0.
> > >
On Thu, 30 Nov 2023, Roger Pau Monné wrote:
> On Wed, Nov 29, 2023 at 08:02:40PM -0800, Stefano Stabellini wrote:
> > n Wed, 29 Nov 2023, Stefano Stabellini wrote:
> > > On Tue, 28 Nov 2023, Roger Pau Monné wrote:
> > > > On Fri, Nov 24, 2023 at 06:41:36PM +0800, Jiqian Chen wrote:
> > > > > In
flight 183958 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/183958/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
ovmf 534021965f6f7c417610add53984f39d6945bbcf
baseline version:
ovmf
On Thu, 30 Nov 2023, Simone Ballarin wrote:
> The scheduled analyses are intended to maintain an overall vision
> of the MISRA complaince of the entire project. For this reason,
> the file exclusions in "out_of_scope.ecl" should not be applied.
>
> This patch amends ECLAIR settings to prevent
On Wed, 29 Nov 2023, Federico Serafini wrote:
> Update ECLAIR configuration to take into account the adopted files
> and type "ret_t".
> Update docs/misra/deviations.rst accordingly.
>
> Signed-off-by: Federico Serafini
Acked-by: Stefano Stabellini
On Wed, 29 Nov 2023, Nicola Vetrini wrote:
> No functional change.
>
> Signed-off-by: Nicola Vetrini
> ---
> The preferred way to deviate is to use asmlinkage, but this modification is
> only
> the consequence of NUMA on ARM (and possibly PPC) being a work in progress.
> As stated in the
On Wed, 29 Nov 2023, Nicola Vetrini wrote:
> This is consistent with other instances of the same function
> and also resolves a violation of MISRA C:2012 Rule 8.4.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
On Wed, 29 Nov 2023, Nicola Vetrini wrote:
> The definitions needing the inclusion of asm/setup.h are
> boot_{first,second,third}(_id)?, whereas vmap.h is needed by
> arch_vmap_virt_end.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
On Fri, 24 Nov 2023, Federico Serafini wrote:
> Add missing parameter name. No functional change.
>
> Signed-off-by: Federico Serafini
Reviewed-by: Stefano Stabellini
On Fri, 24 Nov 2023, Federico Serafini wrote:
> Add missing parameter name. No functional change.
>
> Signed-off-by: Federico Serafini
Reviewed-by: Stefano Stabellini
On Fri, 24 Nov 2023, Federico Serafini wrote:
> Add missing parameter name. No functional change.
>
> Signed-off-by: Federico Serafini
Reviewed-by: Stefano Stabellini
On Fri, 24 Nov 2023, Federico Serafini wrote:
> Add missing parameter name. No functional change.
>
> Signed-off-by: Federico Serafini
Reviewed-by: Stefano Stabellini
On Fri, 24 Nov 2023, Federico Serafini wrote:
> Add missing parameter names. No functional change.
>
> Signed-off-by: Federico Serafini
Reviewed-by: Stefano Stabellini
On Fri, 24 Nov 2023, Federico Serafini wrote:
> Add missing parameter names. No functional change.
>
> Signed-off-by: Federico Serafini
Reviewed-by: Stefano Stabellini
On Thu, 30 Nov 2023, Nicola Vetrini wrote:
> No functional changes.
>
> Signed-off-by: Nicola Vetrini
Acked-by: Stefano Stabellini
> ---
> docs/misra/rules.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst
> index
Hi Roger, Stewart,
Roger Pau Monné writes:
> On Thu, Oct 12, 2023 at 10:09:18PM +, Volodymyr Babchuk wrote:
>> From: Oleksandr Andrushchenko
>>
>> Xen and/or Dom0 may have put values in PCI_COMMAND which they expect
>> to remain unaltered. PCI_COMMAND_SERR bit is a good example: while
On Wed, 2023-11-29 at 15:07 -0600, Madhavan T. Venkataraman wrote:
> Threat Model
>
>
> In the threat model in Heki, the attacker is a user space attacker
> who exploits
> a kernel vulnerability to gain more privileges or bypass the kernel's
> access
> control and self-protection
Hi all,
I think this form is bad and is not helpful. We ought to be able to
recommend an alternative term beside "broken" and "deprecated". I
would not use the term broken in this context but that also doesn't
mean we shouldn't use it in any context. But also in this context
deprecated is not the
On Wed, Nov 29, 2023 at 02:55:51PM -0500, Stefan Hajnoczi wrote:
> The SCSI subsystem no longer uses the AioContext lock. Request
> processing runs exclusively in the BlockBackend's AioContext since
> "scsi: only access SCSIDevice->requests from one thread" and hence the
> lock is unnecessary.
>
On Wed, Nov 29, 2023 at 02:55:50PM -0500, Stefan Hajnoczi wrote:
> Encourage the use of locking primitives and stop mentioning the
> AioContext lock since it is being removed.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> docs/devel/multiple-iothreads.txt | 45 +++
> 1
Hi everyone following this thread,
please see:
https://marc.info/?l=xen-devel=170135718323946
https://cryptpad.fr/form/#/2/form/view/7ByH95Vd7KiDOvN4wjV5iUGlMuZbkVdwk7cYpZdluWo/
For a vote on the usage of the word "broken"
On Tue, 15 Aug 2023, Andrew Cooper wrote:
> Recently in XenServer, we
Hi all,
This vote is in the context of this thread:
https://marc.info/?l=xen-devel=169213351810075
On Thu, 30 Nov 2023, Kelly Choi wrote:
> Hi all,
> There have been a few discussions about how we use documentation wording
> within the community. Whilst there are differences in opinions and
>
flight 183956 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/183956/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
ovmf 26d484d0867b03ebd8a1ecdd9895f17e96732503
baseline version:
ovmf
On Wed, Nov 29, 2023 at 02:55:49PM -0500, Stefan Hajnoczi wrote:
> Delete these functions because nothing calls these functions anymore.
>
> I introduced these APIs in commit 98563fc3ec44 ("aio: add
> aio_context_acquire() and aio_context_release()") in 2014. It's with a
> sigh of relief that I
On Thu, 30 Nov 2023, Stefan Hajnoczi wrote:
On Thu, Nov 30, 2023 at 03:08:49PM -0500, Peter Xu wrote:
On Wed, Nov 29, 2023 at 04:26:20PM -0500, Stefan Hajnoczi wrote:
The Big QEMU Lock (BQL) has many names and they are confusing. The
actual QemuMutex variable is called qemu_global_mutex but
On Wed, Nov 29, 2023 at 02:55:48PM -0500, Stefan Hajnoczi wrote:
> Now that the AioContext lock no longer exists, AIO_WAIT_WHILE() and
> AIO_WAIT_WHILE_UNLOCKED() are equivalent.
>
> A future patch will get rid of AIO_WAIT_WHILE_UNLOCKED().
>
> Signed-off-by: Stefan Hajnoczi
> ---
>
On Wed, Nov 29, 2023 at 02:55:47PM -0500, Stefan Hajnoczi wrote:
> The AioContext lock no longer has any effect. Remove it.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> include/hw/virtio/virtio-scsi.h | 14 --
> hw/scsi/scsi-bus.c | 2 --
> hw/scsi/scsi-disk.c
On Wed, Nov 29, 2023 at 02:55:46PM -0500, Stefan Hajnoczi wrote:
> This is the big patch that removes
> aio_context_acquire()/aio_context_release() from the block layer and
> affected block layer users.
>
> There isn't a clean way to split this patch and the reviewers are likely
> the same group
On Thu, Nov 30, 2023 at 03:43:25PM -0500, Stefan Hajnoczi wrote:
> On Thu, Nov 30, 2023 at 03:08:49PM -0500, Peter Xu wrote:
> > On Wed, Nov 29, 2023 at 04:26:20PM -0500, Stefan Hajnoczi wrote:
> > > The Big QEMU Lock (BQL) has many names and they are confusing. The
> > > actual QemuMutex variable
On Thu, Nov 30, 2023 at 03:08:49PM -0500, Peter Xu wrote:
> On Wed, Nov 29, 2023 at 04:26:20PM -0500, Stefan Hajnoczi wrote:
> > The Big QEMU Lock (BQL) has many names and they are confusing. The
> > actual QemuMutex variable is called qemu_global_mutex but it's commonly
> > referred to as the BQL
On Thu, Nov 30, 2023 at 02:49:48PM +0100, Philippe Mathieu-Daudé wrote:
> On 29/11/23 22:26, Stefan Hajnoczi wrote:
> > The term "QEMU global mutex" is identical to the more widely used Big
> > QEMU Lock ("BQL"). Update the code comments and documentation to use
> > "BQL" instead of "QEMU global
On Thu, Nov 30, 2023 at 02:47:49PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Stefan,
>
> On 29/11/23 22:26, Stefan Hajnoczi wrote:
> > The term "iothread lock" is obsolete. The APIs use Big QEMU Lock (BQL)
> > in their names. Update the code comments to use "BQL" instead of
> > "iothread lock".
>
On Thu, Nov 30, 2023 at 02:44:07PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Stefan,
>
> On 29/11/23 22:26, Stefan Hajnoczi wrote:
> > The APIs using qemu_global_mutex now follow the Big QEMU Lock (BQL)
> > nomenclature. It's a little strange that the actual QemuMutex variable
> > that embodies
On Thu, Nov 30, 2023 at 10:14:47AM +0100, Ilya Leoshkevich wrote:
> On Wed, 2023-11-29 at 16:26 -0500, Stefan Hajnoczi wrote:
> > The name "iothread" is overloaded. Use the term Big QEMU Lock (BQL)
> > instead, it is already widely used and unambiguous.
> >
> > Signed-off-by: Stefan Hajnoczi
> >
On Wed, Nov 29, 2023 at 04:26:20PM -0500, Stefan Hajnoczi wrote:
> The Big QEMU Lock (BQL) has many names and they are confusing. The
> actual QemuMutex variable is called qemu_global_mutex but it's commonly
> referred to as the BQL in discussions and some code comments. The
> locking APIs,
On Wed, Nov 29, 2023 at 02:55:45PM -0500, Stefan Hajnoczi wrote:
> Stop acquiring/releasing the AioContext lock in
> bdrv_graph_wrlock()/bdrv_graph_unlock() since the lock no longer has any
> effect.
>
> The distinction between bdrv_graph_wrunlock() and
> bdrv_graph_wrunlock_ctx() becomes
On Thu, Nov 30, 2023 at 05:55:07PM +0100, Jan Beulich wrote:
> On 28.11.2023 11:03, Roger Pau Monne wrote:
> > The minimal function size requirements for livepatch are either 5 bytes (for
> > jmp) or 9 bytes (for endbr + jmp). Ensure that functions are always at
> > least
> > that size by
On Wed, Nov 29, 2023 at 02:55:44PM -0500, Stefan Hajnoczi wrote:
> aio_context_acquire()/aio_context_release() has been replaced by
> fine-grained locking to protect state shared by multiple threads. The
> AioContext lock still plays the role of balancing locking in
> AIO_WAIT_WHILE() and many
No functional changes.
Signed-off-by: Nicola Vetrini
---
docs/misra/rules.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst
index 53dab0070c7b..75921b9a3463 100644
--- a/docs/misra/rules.rst
+++ b/docs/misra/rules.rst
@@ -531,7
On 11/30/23 03:33, Jan Beulich wrote:
> On 30.11.2023 03:47, Stewart Hildebrand wrote:
>> On 11/14/23 04:13, Jan Beulich wrote:
>>> On 13.11.2023 23:21, Stewart Hildebrand wrote:
--- a/xen/arch/x86/include/asm/domain.h
+++ b/xen/arch/x86/include/asm/domain.h
@@ -503,6 +503,8 @@
The scheduled analyses are intended to maintain an overall vision
of the MISRA complaince of the entire project. For this reason,
the file exclusions in "out_of_scope.ecl" should not be applied.
This patch amends ECLAIR settings to prevent exempting files for
scheduled analyses.
Signed-off-by:
On 28.11.2023 11:03, Roger Pau Monne wrote:
> --- /dev/null
> +++ b/xen/arch/x86/test-smc.c
> @@ -0,0 +1,68 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +#include
> +
> +#include
> +#include
> +#include
> +
> +static bool cf_check test_insn_replacement(void)
> +{
> +#define
On 2023-11-30 17:48, Jan Beulich wrote:
On 29.11.2023 16:24, Nicola Vetrini wrote:
--- a/xen/arch/x86/i8259.c
+++ b/xen/arch/x86/i8259.c
@@ -19,6 +19,7 @@
#include
#include
#include
+#include
#include
#include
A patch doing this (among other things) is already pending: "x86:
On 28.11.2023 11:03, Roger Pau Monne wrote:
> The minimal function size requirements for livepatch are either 5 bytes (for
> jmp) or 9 bytes (for endbr + jmp). Ensure that functions are always at least
> that size by requesting the compiled to align the functions to 8 or 16 bytes,
> depending on
On 29.11.2023 16:24, Nicola Vetrini wrote:
> --- a/xen/arch/x86/i8259.c
> +++ b/xen/arch/x86/i8259.c
> @@ -19,6 +19,7 @@
> #include
> #include
> #include
> +#include
> #include
> #include
A patch doing this (among other things) is already pending: "x86: detect
PIC aliasing on ports
On 29.11.2023 16:24, Nicola Vetrini wrote:
> --- a/xen/arch/x86/desc.c
> +++ b/xen/arch/x86/desc.c
> @@ -91,7 +91,7 @@ seg_desc_t boot_compat_gdt[PAGE_SIZE / sizeof(seg_desc_t)] =
> * References boot_cpu_gdt_table for a short period, until the CPUs switch
> * onto their per-CPU GDTs.
> */
>
On 29.11.2023 16:24, Nicola Vetrini wrote:
> The comment referred to the declaration for do_mca, which
> now is part of hypercall-defs.h, therefore the comment is stale.
If the comments were stale, the #include-s should also be able to
disappear?
> --- a/xen/arch/x86/cpu/mcheck/mce.c
> +++
On 30/11/23 04:13, Stefano Stabellini wrote:
On Thu, 23 Nov 2023, Simone Ballarin wrote:
The scheduled analyses are intended to maintain an overall vision
of the MISRA complaince of the entire project. For this reason,
the file exclusions in "out_of_scope.ecl" should not be applied.
This patch
On 24.11.2023 15:03, Federico Serafini wrote:
> Add missing parameter name. No functional change.
>
> Signed-off-by: Federico Serafini
Acked-by: Jan Beulich
On 24.11.2023 15:03, Federico Serafini wrote:
> Add missing parameter name. No functional change.
>
> Signed-off-by: Federico Serafini
Acked-by: Jan Beulich
On 24.11.2023 15:03, Federico Serafini wrote:
> Add missing parameter name. No functional change.
>
> Signed-off-by: Federico Serafini
Acked-by: Jan Beulich
> --- a/xen/include/xen/param.h
> +++ b/xen/include/xen/param.h
> @@ -22,7 +22,7 @@ struct kernel_param {
> unsigned int len;
>
flight 183944 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/183944/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in
183927
test-armhf-armhf-libvirt 16
On Wed, Nov 29, 2023 at 07:53:59PM -0800, Stefano Stabellini wrote:
> On Fri, 24 Nov 2023, Jiqian Chen wrote:
> > This patch is to solve two problems we encountered when we try to
> > passthrough a device to hvm domU base on Xen PVH dom0.
> >
> > First, hvm guest will alloc a pirq and irq for a
On 24.11.2023 15:03, Federico Serafini wrote:
> Add missing parameter names to address violations of MISRA C:2012
> Rule 8.2 and remove uses of u{8,16,32} in favor of C standard types.
> No functional change.
>
> Signed-off-by: Federico Serafini
Acked-by: Jan Beulich
On 24.11.2023 15:03, Federico Serafini wrote:
> Add missing parameter name. No functional change.
>
> Signed-off-by: Federico Serafini
Acked-by: Jan Beulich
On 24.11.2023 15:03, Federico Serafini wrote:
> Add missing parameter names. No functional change.
>
> Signed-off-by: Federico Serafini
Acked-by: Jan Beulich
On 24.11.2023 15:03, Federico Serafini wrote:
> Add missing parameter names. No functional change.
>
> Signed-off-by: Federico Serafini
Acked-by: Jan Beulich
On 30/11/23 16:48, Federico Serafini wrote:
Patch 1/2 does some preparation work, hence it needs to be committed as first.
Patch 2/2 addresses the violation.
Federico Serafini (2):
x86/p2m: preparation work for xenmem_add_to_physmap_one()
x86/p2m: address a violation of MISRA C:2012 Rule
Patch 1/2 does some preparation work, hence it needs to be committed as first.
Patch 2/2 addresses the violation.
Federico Serafini (2):
x86/p2m: preparation work for xenmem_add_to_physmap_one()
x86/p2m: address a violation of MISRA C:2012 Rule 8.3
xen/arch/x86/mm/p2m.c | 36
Make function declaration and definition consistent changing
parameter name from "gpfn" to "gfn".
For consistency, rename also "old_gpfn" to "old_gfn".
No functional change.
Signed-off-by: Federico Serafini
---
This patch depends on patch 1/2 of the same series.
---
xen/arch/x86/mm/p2m.c | 28
The objective is to use parameter name "gfn" for
xenmem_add_to_physmap_one().
Since the name "gfn" is currently used as identifier for a local
variable, bad things could happen if new uses of such variable are
committed while a renaming patch is waiting for the approval.
To avoid such danger, as
On Wed, Nov 29, 2023 at 02:55:43PM -0500, Stefan Hajnoczi wrote:
> The aio_context_acquire() API is being removed. Drop the test case that
> calls the API.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> tests/unit/test-aio.c | 67 +--
> 1 file changed, 1
From: Zhao Liu
Support user-child for topology devices.
This will affect these 2 aspects:
1. For the basic topology device (with DEVICE_CATEGORY_CPU_DEF
category), user could specify "parent" to build the topology
relationship from cli. And cpu-slot will collect all topology
devices.
On Wed, Nov 29, 2023 at 02:55:42PM -0500, Stefan Hajnoczi wrote:
> Protect the Task Management Function BH state with a lock. The TMF BH
> runs in the main loop thread. An IOThread might process a TMF at the
> same time as the TMF BH is running. Therefore tmf_bh_list and tmf_bh
> must be protected
From: Zhao Liu
QOM topology allows user to create topology tree from cli without -smp,
in this case, validate the topology tree to meet the smp requirement.
Currently, for compatibility with MachineState.smp, initialize
MachineState.smp from topology tree in this case.
Signed-off-by: Zhao Liu
On Thu, Nov 30, 2023 at 06:32:00AM +, Chen, Jiqian wrote:
>
> On 2023/11/28 22:17, Roger Pau Monné wrote:
> > On Fri, Nov 24, 2023 at 06:41:35PM +0800, Jiqian Chen wrote:
> >> If we run Xen with PVH dom0 and hvm domU, hvm will map a pirq for
> >> a passthrough device by using gsi, see
Hi all,
There have been a few discussions about how we use documentation wording
within the community. Whilst there are differences in opinions and
perceptions of the definition, it would be helpful to see a wider consensus
of how we feel.
*Discussion: Should we use the term 'broken' in our
On 11/30/23 02:03, Chen, Jiqian wrote:
>
> On 2023/11/30 11:46, Stefano Stabellini wrote:
>> On Fri, 24 Nov 2023, Jiqian Chen wrote:
>>> When device on dom0 side has been reset, the vpci on Xen side
>>> won't get notification, so that the cached state in vpci is
>>> all out of date with the real
On 30.11.2023 08:55, Jan Beulich wrote:
> The rule demands that all array elements be initialized (or dedicated
> initializers be used). Introduce a small set of macros to allow doing so
> without unduly affecting use sites (in particular in terms of how many
> elements .matches[] actually has;
On Thu, Nov 30, 2023 at 07:39:38AM -0500, Daniel P. Smith wrote:
> On 11/30/23 07:25, Daniel P. Smith wrote:
> > On 11/30/23 01:22, Chen, Jiqian wrote:
> > > Hi Roger and Daniel P. Smith,
> > >
> > > On 2023/11/28 22:08, Roger Pau Monné wrote:
> > > > On Fri, Nov 24, 2023 at 06:41:34PM +0800,
From: Zhao Liu
Topology relationship is based on child<> property, therefore introduce
a new user-child interface to help bus-less devices create child<>
property from cli.
User-child interface works in qdev_set_id(), where the child<> property
is created for cli devices.
With several methods,
From: Zhao Liu
The properties setting does not conflict with the creation of child<>
property.
Pre-setting the device's properties can help the device's parent
selection. Some topology devices (e.g., CPUs that support hotplug)
usually define topology sub indexes as properties, and the selection
From: Zhao Liu
QOM topology needs to search parent cpu-core for hotplugged CPU to
create topology child<> property in qdev_set_id().
This process is before x86_cpu_pre_plug(), thus place 2 helpers
x86_cpu_assign_apic_id() and x86_cpu_assign_topo_id() in
x86_cpu_search_parent_pre_plug() to help
From: Zhao Liu
When we support child<> property creation from cli, the peripheral
container (/machine/peripheral) may not be the direct parent of the
devices created from cli.
For this case, add a helper to resolve path from non-direct parent.
Signed-off-by: Zhao Liu
---
include/qom/object.h
From: Zhao Liu
After i386 supports QOM topology, drop original topology logic.
Signed-off-by: Zhao Liu
---
hw/i386/x86.c | 52 +++
1 file changed, 11 insertions(+), 41 deletions(-)
diff --git a/hw/i386/x86.c b/hw/i386/x86.c
index
From: Zhao Liu
For QOM topology, maximum number of CPUs and the number of plugged CPUs
are configured in core level.
Iterate through all the cpu-cores to determine how many CPUs should be
created in each cpu-core.
Signed-off-by: Zhao Liu
---
hw/i386/x86.c | 32
From: Zhao Liu
Currently, the devices added by "-device" are linked via bus, and are
set the parent as peripheral-anon or peripheral containers of the
machine.
But this is not enough for building CPU topology hierarchies as:
1. The relationship between different CPU hierarchies is child<>
From: Zhao Liu
Topology devices are required to complete CPU topology building before
*_init_cpus() in MachineClass.init().
Add a qemu_create_cli_base_devices() before board initialization to
help create and realize topology devices from cli early.
Signed-off-by: Zhao Liu
---
system/vl.c |
From: Zhao Liu
Set MachineClass.smp_props.possible_cpus_qom_granu and
TopoClass.search_parent_pre_plug for i386.
So far, the i386 topology is based on the QOM topology.
Signed-off-by: Zhao Liu
---
hw/i386/x86.c | 1 +
target/i386/cpu.c | 4
2 files changed, 5 insertions(+)
diff
From: Zhao Liu
x86_cpu_new() is only invoked in x86.c. Declear it as static in x86.c.
Signed-off-by: Zhao Liu
---
hw/i386/x86.c | 3 ++-
include/hw/i386/x86.h | 2 --
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/i386/x86.c b/hw/i386/x86.c
index
From: Zhao Liu
The CPU slot, as the root of the topology tree, is responsible for
global topology information collection and updates.
When a new topology device is added to/deleted from the topology tree,
update the corresponding information in the slot.
Signed-off-by: Zhao Liu
---
From: Zhao Liu
For QOM topology, these 2 helpers are needed for hotplugged CPU to
verify its topology sub indexes and then search its parent core.
Signed-off-by: Zhao Liu
---
hw/i386/x86.c | 173 --
1 file changed, 96 insertions(+), 77
From: Zhao Liu
Abstract the root of topology tree as a special topology device
"cpu-slot".
Signed-off-by: Zhao Liu
---
MAINTAINERS| 2 ++
hw/core/cpu-slot.c | 48 ++
hw/core/meson.build| 1 +
include/hw/core/cpu-slot.h | 38
From: Zhao Liu
Abstract book level as a topology device "cpu-book" to allow user to
create book level topology from cli and later the cpu-books could be
added into topology tree.
In addition, mark the cpu-book as DEVICE_CATEGORY_CPU_DEF category to
indicate it belongs to the basic CPU
From: Zhao Liu
For the architecture supports QOM topology (the field
MachineClass.possible_cpus_qom_granu is set), implement smp QOM topology
tree from MachineState.smp.
Signed-off-by: Zhao Liu
---
hw/core/cpu-slot.c | 217 +
hw/core/machine-smp.c
From: Zhao Liu
For QOM topology, CPU should be inserted under its parent core.
Extend x86_cpu_new() to allow caller to specify topology parent.
Signed-off-by: Zhao Liu
---
hw/i386/x86.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/hw/i386/x86.c
From: Zhao Liu
Abstract die level as a topology device "cpu-die" to allow user to
create die level topology from cli and later the cpu-dies could be added
into topology tree.
In addition, mark the cpu-die as DEVICE_CATEGORY_CPU_DEF category to
indicate it belongs to the basic CPU definition and
From: Zhao Liu
Implement CPUTopoClass.check_topo_child() in cpu-slot to be compatible
with the limitations of the current smp topology.
Signed-off-by: Zhao Liu
---
hw/core/cpu-slot.c | 37 +
hw/core/cpu-topo.c | 2 +-
From: Zhao Liu
Abstract drawer level as a topology device "cpu-drawer" to allow user to
create drawer level topology from cli and later the cpu-drawers could be
added into topology tree.
In addition, mark the cpu-drawer as DEVICE_CATEGORY_CPU_DEF category to
indicate it belongs to the basic CPU
From: Zhao Liu
Add a cpu-slot in machine as the root of topology tree to maintain the
QOM topology.
Signed-off-by: Zhao Liu
---
hw/core/cpu-slot.c | 31 +++
include/hw/boards.h| 2 ++
include/hw/core/cpu-slot.h | 7 +++
system/vl.c
1 - 100 of 184 matches
Mail list logo
