On 07/12/2023 12:39, Jan Beulich wrote:
On 07.12.2023 13:14, Julien Grall wrote:
Hi Jan,
On 07/12/2023 09:30, Jan Beulich wrote:
On 07.12.2023 09:26, Juergen Gross wrote:
On 21.11.23 12:40, Juergen Gross wrote:
Remove some command line options which have no real use case.
Changes in V2:
On 07.12.2023 12:48, Federico Serafini wrote:
> On 07/12/23 12:43, Federico Serafini wrote:
>> Hello everyone,
>>
>> Rule 5.6 states that a typedef name shall be a unique identifier.
>> This is to avoid developer confusion.
>>
>> For ARM, the violations left [1] are generated by two definitions
>>
Hi Julien,
On 07/12/2023 13:20, Julien Grall wrote:
>
>
> Hi Michal,
>
> On 07/12/2023 10:14, Michal Orzel wrote:
>> As a result of not checking the return code of device_tree_for_each_node()
>> in boot_fdt_info(), any error occured during early FDT parsing does not
>> stop Xen from booting.
On 07.12.2023 13:14, Julien Grall wrote:
> Hi Jan,
>
> On 07/12/2023 09:30, Jan Beulich wrote:
>> On 07.12.2023 09:26, Juergen Gross wrote:
>>> On 21.11.23 12:40, Juergen Gross wrote:
Remove some command line options which have no real use case.
Changes in V2:
- moved removal
Hi Michal,
On 07/12/2023 10:14, Michal Orzel wrote:
As a result of not checking the return code of device_tree_for_each_node()
in boot_fdt_info(), any error occured during early FDT parsing does not
stop Xen from booting. This can result in an unwanted behavior in later
boot stages. Fix it by
Hi Jan,
On 07/12/2023 09:30, Jan Beulich wrote:
On 07.12.2023 09:26, Juergen Gross wrote:
On 21.11.23 12:40, Juergen Gross wrote:
Remove some command line options which have no real use case.
Changes in V2:
- moved removal of "-N" into last patch of the series, as this is the
only option
flight 184022 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/184022/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm
On Mon, Dec 4, 2023 at 4:56 PM Jan Beulich wrote:
>
> On 04.12.2023 16:23, Juergen Gross wrote:
> > Do cleanup in sched_move_domain() in a dedicated service function,
> > which is called either in error case with newly allocated data, or in
> > success case with the old data to be freed.
> >
> >
On Mon, Dec 4, 2023 at 4:55 PM Jan Beulich wrote:
>
> On 04.12.2023 16:23, Juergen Gross wrote:
> > Trying to add an offline cpu to a cpupool can crash the hypervisor,
> > as the probably non-existing percpu area of the cpu is accessed before
> > the availability of the cpu is being tested. This
On 07/12/23 12:43, Federico Serafini wrote:
Hello everyone,
Rule 5.6 states that a typedef name shall be a unique identifier.
This is to avoid developer confusion.
For ARM, the violations left [1] are generated by two definitions
of the type phys_addr_t within two different files.
I would like
On Fri, Dec 01, 2023 at 10:42:43AM +0530, Harsh Prateek Bora wrote:
> On 11/30/23 02:56, Stefan Hajnoczi wrote:
> > diff --git a/hw/remote/mpqemu-link.c b/hw/remote/mpqemu-link.c
> > index 9bd98e8219..ffb2c25145 100644
> > --- a/hw/remote/mpqemu-link.c
> > +++ b/hw/remote/mpqemu-link.c
> > @@
The file exclude-list.json contains files that are classified as
adopted code for MISRA compliance. Therefore, this file is used to
automatically generate a suitable .ecl configuration for ECLAIR.
As such, many entries in out_of_scope.ecl can be removed, as they
would be duplicates.
Hi Penny,
On 06/12/2023 10:06, Penny Zheng wrote:
>
>
> In case there is a /reserved-memory node already present in the host dtb,
> current Xen codes would create yet another /reserved-memory node specially
> for the static shm in Dom0 Device Tree.
Rational missing:
This would result in an
No functional change.
Signed-off-by: Nicola Vetrini
---
Changes in v2:
- The attribute on boot_gdtr and l1_fixmap_x has been dropped, as detailed in
the cover letter.
---
xen/arch/x86/efi/efi-boot.h | 5 +++--
xen/arch/x86/smpboot.c | 2 +-
2 files changed, 4 insertions(+), 3
MISRA C:2012 Rule 8.4 states:
"A compatible declaration shall be visible when an object or function with
external linkage is defined".
Changes from v1:
- Patch 1/7 has been committed;
- Patch 2/7 has been dropped, as the fix is already part of [1];
- Patch 3/7 drops the addition of asmlinkage on
Such declaration is needed to comply with MISRA C Rule 8.4, because a
compatible declaration is not visible in xen/common/page_alloc.c, where the
variable is defined. That variable can't yet be static because of the lack of
support from ARM and PPC for NUMA.
No functional change.
Signed-off-by:
This is consistent with other instances of the same function
and also resolves a violation of MISRA C:2012 Rule 8.4.
No functional change.
Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
---
xen/arch/x86/hvm/viridian/synic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 07.12.2023 10:48, Simone Ballarin wrote:
> --- a/xen/arch/x86/hpet.c
> +++ b/xen/arch/x86/hpet.c
> @@ -279,7 +279,7 @@ static int hpet_msi_write(struct hpet_event_channel *ch,
> struct msi_msg *msg)
> {
> ch->msi.msg = *msg;
>
> -if ( iommu_intremap )
> +if ( iommu_intremap !=
As of 732571959f17 ("xen/build: use new $(c_flags) and $(a_flags)
instead of $(CFLAGS)") -M options aren't part of CFLAGS anymore, and
c_flags isn't supposed to be passed to this macro. Drop the now dead
part of filtering.
Signed-off-by: Jan Beulich
--- a/xen/scripts/Kbuild.include
+++
Passing in $(CFLAGS) means also requesting inclusion of certain headers
(via -include command line options). That's particularly xen/config.h,
which in turn requires generated/autoconf.h. This has not caused any
problems so far only because arch.mk is processed twice, and the missing
header on the
The first is a fix for a latent issue (which became real with one of my
pending changes), while the 2nd is merely cleanup noticed as possible /
useful to do in the course of investigating.
1: x86/EFI: correct compiler probing
2: Kbuild: simplify as-insn a little
Jan
On 07.12.2023 11:09, Federico Serafini wrote:
> On 07/12/23 10:19, Jan Beulich wrote:
>> On 07.12.2023 09:47, Federico Serafini wrote:
>>> Remove apci_pic_set_trigger() declaration: there is no definition and there
>>> are
>>> no calls to such function in the XEN project.
>>>
>>> Signed-off-by:
Hi Michal
On 2023/12/6 19:35, Michal Orzel wrote:
Hi Penny,
On 06/12/2023 10:06, Penny Zheng wrote:
Putting overlap and overflow checking in the loop is causing repetitive
operation, so this commit extracts both checking outside the loop.
Signed-off-by: Penny Zheng
In general the patch
As a result of not checking the return code of device_tree_for_each_node()
in boot_fdt_info(), any error occured during early FDT parsing does not
stop Xen from booting. This can result in an unwanted behavior in later
boot stages. Fix it by checking the return code and panicing on an error.
On 07/12/23 10:19, Jan Beulich wrote:
On 07.12.2023 09:47, Federico Serafini wrote:
Remove apci_pic_set_trigger() declaration: there is no definition and there are
no calls to such function in the XEN project.
Signed-off-by: Federico Serafini
Reviewed-by: Jan Beulich
A reference to the
On 07.12.2023 10:48, Simone Ballarin wrote:
> From: Maria Celeste Cesario
>
> The xen sources contain violations of MISRA C:2012 Rule 14.4 whose
> headline states:
> "The controlling expression of an if statement and the controlling
> expression of an iteration-statement shall have essentially
On 07.12.2023 10:22, Oleksii wrote:
> On Tue, 2023-12-05 at 16:38 +0100, Jan Beulich wrote:
>>> On 24.11.2023 11:30, Oleksii Kurochko wrote:
> The patch also fixes the build script as conf util expects
> to have each config on separate line.
>>>
>>> The approach doesn't really scale (it's
From: Maria Celeste Cesario
The xen sources contain violations of MISRA C:2012 Rule 14.4 whose
headline states:
"The controlling expression of an if statement and the controlling
expression of an iteration-statement shall have essentially Boolean type".
Struct domain member is_dying is an
From: Maria Celeste Cesario
The xen sources contain violations of MISRA C:2012 Rule 14.4 whose
headline states:
"The controlling expression of an if statement and the controlling
expression of an iteration-statement shall have essentially Boolean type".
Add comparisons to avoid using enum
From: Maria Celeste Cesario
The xen sources contain violations of MISRA C:2012 Rule 14.4 whose
headline states:
"The controlling expression of an if statement and the controlling
expression of an iteration-statement shall have essentially Boolean type".
Add comparisons to avoid using enum
From: Maria Celeste Cesario
The xen sources contain violations of MISRA C:2012 Rule 14.4 whose
headline states:
"The controlling expression of an if statement and the controlling
expression of an iteration-statement shall have essentially Boolean type".
Add comparisons to avoid using enum
Pipeline #1098406925 has failed!
Project: xen ( https://gitlab.com/xen-project/xen )
Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging )
Commit: dbe69e1c (
https://gitlab.com/xen-project/xen/-/commit/dbe69e1c8555b40a43cde482615501eb8515ab80
)
Commit Message: x86/DMI:
On 07.12.2023 10:42, Oleksii wrote:
> On Tue, 2023-12-05 at 16:56 +0100, Jan Beulich wrote:
>> On 24.11.2023 11:30, Oleksii Kurochko wrote:
>>> --- /dev/null
>>> +++ b/xen/arch/riscv/include/asm/fence.h
>>> @@ -0,0 +1,12 @@
>>> +#ifndef _ASM_RISCV_FENCE_H
>>> +#define _ASM_RISCV_FENCE_H
>>> +
>>>
> > In my opinion, cross-checking is the better approach, because it means that
> > violations of the assumptions get noticed more quickly, and hopefully by
> > whomever is working on the new feature which alters the assumptions.
>
> Yeah, I can make the change.
Hi Andrew,
Following is the
On Tue, 2023-12-05 at 16:56 +0100, Jan Beulich wrote:
> On 24.11.2023 11:30, Oleksii Kurochko wrote:
> > --- /dev/null
> > +++ b/xen/arch/riscv/include/asm/fence.h
> > @@ -0,0 +1,12 @@
> > +#ifndef _ASM_RISCV_FENCE_H
> > +#define _ASM_RISCV_FENCE_H
> > +
> > +#ifdef CONFIG_SMP
> > +#define
Hi Penny,
On 06/12/2023 10:06, Penny Zheng wrote:
>
>
> We split the code of allocate_bank_memory into two parts,
> allocate_domheap_memory and guest_physmap_memory.
>
> One is about allocating guest RAM from heap, which could be re-used later for
> allocating static shared memory from heap
On Tue, 2023-12-05 at 16:40 +0100, Jan Beulich wrote:
> On 24.11.2023 11:30, Oleksii Kurochko wrote:
> > Some headers are the same as asm-generic verions of them
> > so use them instead of arch-specific headers.
> >
> > Signed-off-by: Oleksii Kurochko
>
> Acked-by: Jan Beulich
> assuming ...
>
On 07.12.2023 09:26, Juergen Gross wrote:
> On 21.11.23 12:40, Juergen Gross wrote:
>> Remove some command line options which have no real use case.
>>
>> Changes in V2:
>> - moved removal of "-N" into last patch of the series, as this is the
>>only option which seems to have a use case (OTOH
On 06.12.23 19:17, Randy Dunlap wrote:
Correct function kernel-doc notation to prevent warnings from
scripts/kernel-doc.
xenbus_client.c:134: warning: No description found for return value of
'xenbus_watch_path'
xenbus_client.c:177: warning: No description found for return value of
On Tue, 2023-12-05 at 16:38 +0100, Jan Beulich wrote:
> > On 24.11.2023 11:30, Oleksii Kurochko wrote:
> > > > The patch also fixes the build script as conf util expects
> > > > to have each config on separate line.
> >
> > The approach doesn't really scale (it's already odd that you add
> > the
On 07.12.2023 09:47, Federico Serafini wrote:
> Remove apci_pic_set_trigger() declaration: there is no definition and there
> are
> no calls to such function in the XEN project.
>
> Signed-off-by: Federico Serafini
Reviewed-by: Jan Beulich
A reference to the offending commit would have been
MISRA C:2012 Rule 16.3 states that an unconditional break statement
shall terminate every switch-clause.
Update ECLAIR configuration to take into account:
- continue, goto, return statements;
- functions and macros that do not give the control back;
- fallthrough comments and pseudo-keywords.
On Wed, 2023-12-06 at 21:01 -0500, Daniel P. Smith wrote:
> On 12/1/23 15:56, Julien Grall wrote:
> > (+ Arm and RISC-V folks)
> >
> > Hi Shawn,
> >
> > On 01/12/2023 20:59, Shawn Anastasio wrote:
> > > Adapt arm's earlyfdt parsing code to ppc64 and enable Xen's early
> > > boot
> > > allocator.
flight 184007 xen-4.17-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/184007/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 183842
test-armhf-armhf-libvirt 16
On 07.12.2023 09:43, Julien Grall wrote:
> On 07/12/2023 07:28, Jan Beulich wrote:
>> On 06.12.2023 18:55, Julien Grall wrote:
>>> On 06/12/2023 02:32, George Dunlap wrote:
On Tue, Dec 5, 2023 at 2:07 PM Jan Beulich wrote:
> On 05.12.2023 14:46, Luca Fancellu wrote:
>> In my opinion,
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
Changes in v2:
- do not add parameters to compat_subarch_memory_op() (removed).
---
xen/arch/x86/include/asm/mm.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git
This patch series adds the missing parameter names and remove useless function
declarations. No functional changes are introduced.
Federico Serafini (5):
x86/acpi: remove acpi_pic_sci_set_trigger()
xen/acpi: address violations of MISRA C:2012 Rule 8.2
x86/mm: remove
Add missing parameter names to address violations of MISRA C:2012
Rule 8.2. Remove trailing spaces and use C standard types to comply
with XEN coding style. No functional change.
Signed-off-by: Federico Serafini
---
Changes in v2:
- use "enable" instead of "iommu_control" as parameter name.
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
Changes in v2:
- do not add parameters to acpi_pic_sci_set_trigger() (removed).
---
xen/include/acpi/apei.h | 5 +++--
xen/include/acpi/cpufreq/cpufreq.h| 2 +-
Remove apci_pic_set_trigger() declaration: there is no definition and there are
no calls to such function in the XEN project.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/acpi.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/xen/arch/x86/include/asm/acpi.h
Remove remove compat_subarch_memory_op() declaration: there is no
definition and there are no calls to such function in the XEN project.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/mm.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/xen/arch/x86/include/asm/mm.h
Hi,
On 07/12/2023 07:28, Jan Beulich wrote:
On 06.12.2023 18:55, Julien Grall wrote:
On 06/12/2023 02:32, George Dunlap wrote:
On Tue, Dec 5, 2023 at 2:07 PM Jan Beulich wrote:
On 05.12.2023 14:46, Luca Fancellu wrote:
In my opinion, I don’t know of any tool that can address all the
On 21.11.23 12:40, Juergen Gross wrote:
Remove some command line options which have no real use case.
Changes in V2:
- moved removal of "-N" into last patch of the series, as this is the
only option which seems to have a use case (OTOH using it has some
downsides as well).
Juergen Gross
Today the cpu type for a 32-bit x86 kernel is not specified in the
used kernel config, resulting in the M686 to be used.
Instead of using the M686 which isn't even a 64-bit cpu (thus not
capable to run a Xen guest), use the X86_GENERIC variant which is
more appropriate.
Signed-off-by: Juergen
101 - 154 of 154 matches
Mail list logo
