Re: [PATCH v5 06/13] xen/arm: add support for cache coloring configuration via device-tree

2024-01-08 Thread Carlo Nonato
Hi Julien, On Fri, Jan 5, 2024 at 6:38 PM Julien Grall wrote: > > Hi Carlo, > > On 02/01/2024 09:51, Carlo Nonato wrote: > > This commit adds the "llc-colors" Device Tree attribute that can be used > > for DomUs and Dom0less color configurations. The syntax is the same used > > for every color

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Carlo Nonato
Hi Jan, On Mon, Jan 8, 2024 at 9:43 AM Jan Beulich wrote: > > On 02.01.2024 10:51, Carlo Nonato wrote: > > --- a/xen/arch/arm/llc-coloring.c > > +++ b/xen/arch/arm/llc-coloring.c > > @@ -9,6 +9,7 @@ > > *Carlo Nonato > > */ > > #include > > +#include > > #include > > #include > >

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Carlo Nonato
Hi Julien, On Mon, Jan 8, 2024 at 12:01 PM Julien Grall wrote: > > Hi Carlo, > > On 08/01/2024 10:27, Carlo Nonato wrote: > > On Fri, Jan 5, 2024 at 6:26 PM Julien Grall wrote: > >> On 02/01/2024 09:51, Carlo Nonato wrote: > >>> This commit updates the domctl interface to allow the user to set

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-08 Thread Federico Serafini
On 08/01/24 09:02, Jan Beulich wrote: On 05.01.2024 17:19, Federico Serafini wrote: Hello everyone, On 21/12/23 13:41, Jan Beulich wrote: On 21.12.2023 13:01, Nicola Vetrini wrote: Hi Andrew, On 2023-12-21 12:03, Andrew Cooper wrote: On 21/12/2023 10:58 am, Jan Beulich wrote: On

Re: [PATCH v5 03/13] xen/arm: add Dom0 cache coloring support

2024-01-08 Thread Carlo Nonato
Hi Julien, On Mon, Jan 8, 2024 at 11:25 AM Julien Grall wrote: > > Hi Carlo, > > On 08/01/2024 10:06, Carlo Nonato wrote: > >> One of the reason is at least in the dom0less case, you will override > >> the value afterwards. > > > > In that case I need to allocate the array before parsing the

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Julien Grall
Hi Carlo, On 08/01/2024 10:27, Carlo Nonato wrote: On Fri, Jan 5, 2024 at 6:26 PM Julien Grall wrote: On 02/01/2024 09:51, Carlo Nonato wrote: This commit updates the domctl interface to allow the user to set cache coloring configurations from the toolstack. It also implements the

Re: [PATCH v6 5/9] xen/asm-generic: introduce stub header numa.h

2024-01-08 Thread Jan Beulich
On 20.12.2023 15:08, Oleksii Kurochko wrote: > is common through some archs so it is moved > to asm-generic. > > Signed-off-by: Oleksii Kurochko > Reviewed-by: Michal Orzel > Acked-by: Jan Beulich > Acked-by: Shawn Anastasio I'd like to withdraw my ack here. As said elsewhere (and see the

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Carlo Nonato
Hi Julien, On Fri, Jan 5, 2024 at 6:26 PM Julien Grall wrote: > > Hi Carlo, > > On 02/01/2024 09:51, Carlo Nonato wrote: > > This commit updates the domctl interface to allow the user to set cache > > coloring configurations from the toolstack. > > It also implements the functionality for arm64.

Re: [PATCH v5 03/13] xen/arm: add Dom0 cache coloring support

2024-01-08 Thread Julien Grall
Hi Carlo, On 08/01/2024 10:06, Carlo Nonato wrote: One of the reason is at least in the dom0less case, you will override the value afterwards. In that case I need to allocate the array before parsing the string. I allocate a full array then the string is parsed and the actual size is found at

[ovmf test] 184273: all pass - PUSHED

2024-01-08 Thread osstest service owner
flight 184273 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184273/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c3d865a4c21d91f2e338a91d0c8b1eaf205575b5 baseline version: ovmf

Re: [PATCH v5 03/13] xen/arm: add Dom0 cache coloring support

2024-01-08 Thread Carlo Nonato
Hi Julien, On Fri, Jan 5, 2024 at 6:50 PM Julien Grall wrote: > > > > On 05/01/2024 16:52, Carlo Nonato wrote: > > Hi Julien, > > > > On Thu, Jan 4, 2024 at 8:54 PM Julien Grall wrote: > >> > >> Hi Carlo, > >> > >> On 02/01/2024 09:51, Carlo Nonato wrote: > >>> This commit allows the user to

[xen-unstable test] 184271: tolerable FAIL

2024-01-08 Thread osstest service owner
flight 184271 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184271/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184267

Re: [RFC XEN PATCH v4 2/5] x86/pvh: Allow (un)map_pirq when caller isn't DOMID_SELF

2024-01-08 Thread Jan Beulich
On 08.01.2024 10:15, Chen, Jiqian wrote: > On 2024/1/8 16:47, Jan Beulich wrote: >> On 06.01.2024 01:46, Stefano Stabellini wrote: >>> On Fri, 5 Jan 2024, Jiqian Chen wrote: @@ -72,8 +73,30 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) switch ( cmd )

Re: [RFC XEN PATCH v4 2/5] x86/pvh: Allow (un)map_pirq when caller isn't DOMID_SELF

2024-01-08 Thread Chen, Jiqian
On 2024/1/8 16:47, Jan Beulich wrote: > On 06.01.2024 01:46, Stefano Stabellini wrote: >> On Fri, 5 Jan 2024, Jiqian Chen wrote: >>> @@ -72,8 +73,30 @@ long hvm_physdev_op(int cmd, >>> XEN_GUEST_HANDLE_PARAM(void) arg) >>> >>> switch ( cmd ) >>> { >>> -case PHYSDEVOP_map_pirq: >>>

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-08 Thread Jan Beulich
On 06.01.2024 02:08, Stefano Stabellini wrote: > On Fri, 5 Jan 2024, Jiqian Chen wrote: >> --- a/tools/libs/light/libxl_pci.c >> +++ b/tools/libs/light/libxl_pci.c >> @@ -1418,6 +1418,7 @@ static void pci_add_dm_done(libxl__egc *egc, >> unsigned long long start, end, flags, size; >> int

Re: [RFC XEN PATCH v4 3/5] x86/pvh: Add PHYSDEVOP_setup_gsi for PVH dom0

2024-01-08 Thread Jan Beulich
On 06.01.2024 01:54, Stefano Stabellini wrote: > On Fri, 5 Jan 2024, Jiqian Chen wrote: >> On PVH dom0, the gsis don't get registered, but >> the gsi of a passthrough device must be configured for it to >> be able to be mapped into a hvm domU. >> On Linux kernel side, it calles PHYSDEVOP_setup_gsi

Re: [RFC XEN PATCH v4 2/5] x86/pvh: Allow (un)map_pirq when caller isn't DOMID_SELF

2024-01-08 Thread Jan Beulich
On 06.01.2024 01:46, Stefano Stabellini wrote: > On Fri, 5 Jan 2024, Jiqian Chen wrote: >> @@ -72,8 +73,30 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) >> arg) >> >> switch ( cmd ) >> { >> -case PHYSDEVOP_map_pirq: >> -case PHYSDEVOP_unmap_pirq: >> +case

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-08 Thread Jan Beulich
On 02.01.2024 10:51, Carlo Nonato wrote: > --- a/xen/arch/arm/llc-coloring.c > +++ b/xen/arch/arm/llc-coloring.c > @@ -9,6 +9,7 @@ > *Carlo Nonato > */ > #include > +#include > #include > #include > #include > @@ -278,6 +279,22 @@ int dom0_set_llc_colors(struct domain *d) >

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-08 Thread Jan Beulich
On 05.01.2024 23:48, Stefano Stabellini wrote: > On Fri, 5 Jan 2024, Federico Serafini wrote: >> Hello everyone, >> >> On 21/12/23 13:41, Jan Beulich wrote: >>> On 21.12.2023 13:01, Nicola Vetrini wrote: Hi Andrew, On 2023-12-21 12:03, Andrew Cooper wrote: > On 21/12/2023 10:58

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-08 Thread Jan Beulich
On 05.01.2024 17:19, Federico Serafini wrote: > Hello everyone, > > On 21/12/23 13:41, Jan Beulich wrote: >> On 21.12.2023 13:01, Nicola Vetrini wrote: >>> Hi Andrew, >>> >>> On 2023-12-21 12:03, Andrew Cooper wrote: On 21/12/2023 10:58 am, Jan Beulich wrote: > On 21.12.2023 11:53,

<    1   2