[xen-unstable test] 185036: tolerable FAIL - PUSHED

2024-03-14 Thread osstest service owner
flight 185036 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185036/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 185019 test-armhf-armhf-libvirt 16

Re: [PATCH 7/7] verifiers: Verify after decompression

2024-03-14 Thread Michael Chang
On Wed, Mar 13, 2024 at 03:07:48PM +, Ross Lagerwall via Grub-devel wrote: > It is convenient and common to have binaries stored in gzip archives > (e.g. xen.gz). Verification should be run after decompression rather > than before so reorder the file filter list as appropriate. The proposed

[PATCH v3] docs/misra/rules.rst: add rule 5.5

2024-03-14 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini --- Changes in v3: - better clarify what is allowed and not allowed with examples --- docs/misra/rules.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst index 1e134ccebc..5766b2286d 100644 ---

Re: [PATCH] do_multicall and MISRA Rule 8.3\

2024-03-14 Thread Stefano Stabellini
On Mon, 11 Mar 2024, Julien Grall wrote: > On 11/03/2024 11:32, George Dunlap wrote: > > On Sat, Mar 9, 2024 at 1:59 AM Stefano Stabellini > > wrote: > > > > > > I would like to resurrect this thread and ask other opinions. > > > > > > > > > On Thu, 23 Nov 2023, Jan Beulich wrote: > > > > On

Re: [XEN PATCH v3 14/16] xen/x86: address violations of MISRA C:2012 Directive 4.10

2024-03-14 Thread Stefano Stabellini
On Tue, 12 Mar 2024, Jan Beulich wrote: > On 11.03.2024 09:59, Simone Ballarin wrote: > > From: Maria Celeste Cesario > > > > Edit inclusion guards to address violations of > > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to > > prevent the contents of a header file being

Re: [XEN PATCH v3 11/16] xen/arm: address violations of MISRA C:2012 Directive 4.10

2024-03-14 Thread Stefano Stabellini
On Mon, 11 Mar 2024, Simone Ballarin wrote: > From: Maria Celeste Cesario > > Add or modify inclusion guards to address violations of > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to > prevent the contents of a header file being included more than once"). > Mechanical

Re: [XEN PATCH v3 09/16] xen: address violations of MISRA C:2012 Directive 4.10

2024-03-14 Thread Stefano Stabellini
On Mon, 11 Mar 2024, Simone Ballarin wrote: > Amend inclusion guards to address violations of > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order > to prevent the contents of a header file being included more than > once"). > > Inclusion guards must appear at the beginning of the

Re: [XEN PATCH v3 08/16] xen/efi: address violations of MISRA C:2012 Directive 4.10

2024-03-14 Thread Stefano Stabellini
On Mon, 11 Mar 2024, Simone Ballarin wrote: > Add inclusion guards to address violations of > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order > to prevent the contents of a header file being included more than > once"). > > Mechanical change. > > Signed-off-by: Simone Ballarin

Re: [XEN PATCH v3 07/16] xen/common: address violations of MISRA C:2012 Directive 4.10

2024-03-14 Thread Stefano Stabellini
On Mon, 11 Mar 2024, Simone Ballarin wrote: > Add inclusion guards to address violations of > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order > to prevent the contents of a header file being included more than > once"). > > Mechanical change. > > Signed-off-by: Simone Ballarin

Re: [XEN PATCH v3 06/16] x86/EFI: address violations of MISRA C:2012 Directive 4.10

2024-03-14 Thread Stefano Stabellini
On Mon, 11 Mar 2024, Simone Ballarin wrote: > Add inclusion guard to address violations of > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order > to prevent the contents of a header file being included more than > once"). > > Mechanical change. > > Signed-off-by: Simone Ballarin

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-14 Thread Stefano Stabellini
On Mon, 11 Mar 2024, Simone Ballarin wrote: > On 11/03/24 14:56, Jan Beulich wrote: > > On 11.03.2024 13:00, Simone Ballarin wrote: > > > On 11/03/24 11:08, Jan Beulich wrote: > > > > On 11.03.2024 09:59, Simone Ballarin wrote: > > > > > --- a/xen/arch/arm/include/asm/hypercall.h > > > > > +++

Re: [XEN PATCH v3 02/16] misra: modify deviations for empty and generated headers

2024-03-14 Thread Stefano Stabellini
On Mon, 11 Mar 2024, Simone Ballarin wrote: > This patch modifies deviations for Directive 4.10: > "Precautions shall be taken in order to prevent the contents of > a header file being included more than once" > > This patch avoids the file-based deviation for empty headers, and > replaces it

Re: [XEN PATCH v3 01/16] misra: add deviation for headers that explicitly avoid guards

2024-03-14 Thread Stefano Stabellini
On Mon, 11 Mar 2024, Jan Beulich wrote: > On 11.03.2024 09:59, Simone Ballarin wrote: > > Some headers, under specific circumstances (documented in a comment at > > the beginning of the file), explicitly avoid inclusion guards: the caller > > is responsible for including them correctly. > > > >

[xen-4.18-testing test] 185032: tolerable FAIL - PUSHED

2024-03-14 Thread osstest service owner
flight 185032 xen-4.18-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/185032/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-raw 13 guest-start fail in 185020 pass in 185032

[PATCH v2] docs/misra: document the expected sizes of integer types

2024-03-14 Thread Stefano Stabellini
Xen makes assumptions about the size of integer types on the various architectures. Document these assumptions. Signed-off-by: Stefano Stabellini --- Changes in v2: - add alignment info --- docs/misra/C-language-toolchain.rst | 58 + 1 file changed, 58 insertions(+)

[PATCH v3 1/9] EFI: Introduce inline stub for efi_enabled on !X86 && !ARM

2024-03-14 Thread Shawn Anastasio
On architectures with no EFI support, define an inline stub implementation of efi_enabled in efi.h that always returns false. Suggested-by: Jan Beulich Signed-off-by: Shawn Anastasio --- xen/include/xen/efi.h | 8 1 file changed, 8 insertions(+) diff --git a/xen/include/xen/efi.h

[PATCH v3 7/9] xen/ppc: Enable bootfdt and boot allocator

2024-03-14 Thread Shawn Anastasio
Enable usage of bootfdt for populating the boot info struct from the firmware-provided device tree. Also enable the Xen boot page allocator. Includes minor changes to bootfdt.c's boot_fdt_info() to tolerate the scenario in which the FDT overlaps a reserved memory region, as is the case on PPC

[PATCH v3 0/9] Early Boot Allocation on Power

2024-03-14 Thread Shawn Anastasio
Hello all, This series enables the Xen boot time allocator on Power by parsing the available memory regions from the firmware-provided device tree. Version 3 of the patch set greatly reduces the amount of code copied from ARM, instead opting to move things into common code where possible.

[PATCH v3 6/9] xen/common: Move Arm's bootfdt.c to common

2024-03-14 Thread Shawn Anastasio
Move Arm's bootfdt.c to xen/common so that it can be used by other device tree architectures like PPC and RISCV. Suggested-by: Julien Grall Signed-off-by: Shawn Anastasio Acked-by: Julien Grall --- Changes in v2: - Drop #if defined(CONFIG_ARM_EFI) now that efi_enabled is stubbed

[PATCH v3 5/9] xen/device-tree: Move Arm's setup.c bootinfo functions to common

2024-03-14 Thread Shawn Anastasio
Arm's setup.c contains a collection of functions for parsing memory map and other boot information from a device tree. Since these routines are generally useful on any architecture that supports device tree booting, move them into xen/common/device-tree. Suggested-by: Julien Grall Signed-off-by:

[PATCH v3 8/9] xen/ppc: mm-radix: Replace debug printing code with printk

2024-03-14 Thread Shawn Anastasio
Now that we have common code building, there's no need to keep the old itoa64+debug print function in mm-radix.c Signed-off-by: Shawn Anastasio --- Changes in v2: - Use CONFIG_DEBUG instead of NDEBUG xen/arch/ppc/mm-radix.c | 58 + 1 file changed, 12

[PATCH v3 3/9] xen/ppc: Introduce stub asm/static-shmem.h

2024-03-14 Thread Shawn Anastasio
Required for bootfdt.c to build. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/static-shmem.h | 12 1 file changed, 12 insertions(+) create mode 100644 xen/arch/ppc/include/asm/static-shmem.h diff --git a/xen/arch/ppc/include/asm/static-shmem.h

[PATCH v3 4/9] xen/ppc: Update setup.h with required definitions for bootfdt

2024-03-14 Thread Shawn Anastasio
Add the definitions used by ARM's bootfdt.c, which will be moved into xen/common in a later patch, to PPC's setup.h. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/setup.h | 112 +++ 1 file changed, 112 insertions(+) diff --git

[PATCH v3 2/9] xen/asm-generic: Introduce generic acpi.h

2024-03-14 Thread Shawn Anastasio
Introduce a generic acpi.h header that provides the required definitions to allow files including xen/acpi.h to be compiled. The definitions were largely derived from the !CONFIG_ACPI parts of ARM's acpi.h. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/Makefile | 1 +

[PATCH v3 9/9] xen/ppc: mm-radix: Allocate all paging structures at runtime

2024-03-14 Thread Shawn Anastasio
In the initial mm-radix implementation, the in-memory partition and process tables required to configure the MMU, as well as the page tables themselves were all allocated statically since the boot allocator was not yet available. Now that it is, allocate these structures at runtime and bump the

Re: [PATCH] docs/misra: document the expected sizes of integer types

2024-03-14 Thread Stefano Stabellini
On Thu, 14 Mar 2024, George Dunlap wrote: > On Thu, Mar 14, 2024 at 7:36 AM Jan Beulich wrote: > > > > On 14.03.2024 00:23, Stefano Stabellini wrote: > > > Xen makes assumptions about the size of integer types on the various > > > architectures. Document these assumptions. > > > > This all reads

Re: [XEN PATCH] amd/iommu: add fixed size to function parameter of array type

2024-03-14 Thread Stefano Stabellini
On Thu, 14 Mar 2024, Jan Beulich wrote: > On 14.03.2024 10:25, Nicola Vetrini wrote: > > On 2024-03-14 09:32, Jan Beulich wrote: > >> On 14.03.2024 08:42, Nicola Vetrini wrote: > >>> The 'cmd' parameter of amd_iommu_send_guest_cmd is passed > >>> to a function that expects arrays of size 4,

[PATCH v2] docs/misra: add Rule 16.4

2024-03-14 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini --- Changes in v2: - mention -Werror - change the position of the in-code comment in the example - use "notifier pattern" in the example - clarify it is only an example --- docs/misra/rules.rst | 25 + 1 file changed, 25 insertions(+)

[xen-unstable-smoke test] 185041: tolerable all pass - PUSHED

2024-03-14 Thread osstest service owner
flight 185041 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185041/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[ovmf test] 185037: all pass - PUSHED

2024-03-14 Thread osstest service owner
flight 185037 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185037/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e7486b50646d6a645706b61d2f8d74b3dca23ce0 baseline version: ovmf

Re: [PATCH v2 2/3] libelf: Expand ELF note printing

2024-03-14 Thread Jason Andryuk
On 2024-03-14 09:16, Jan Beulich wrote: On 13.03.2024 20:30, Jason Andryuk wrote: @@ -217,6 +225,15 @@ elf_errorstatus elf_xen_parse_note(struct elf_binary *elf, case XEN_ELFNOTE_PHYS32_ENTRY: parms->phys_entry = val; break; + +case XEN_ELFNOTE_L1_MFN_VALID: +

Re: [XEN PATCH] automation/eclair: allow parameter name "unused"

2024-03-14 Thread Stefano Stabellini
On Thu, 14 Mar 2024, Federico Serafini wrote: > Update ECLAIR configuration of MISRA C:2012 Rule 8.3 to deviate > violations involving parameter name "unused": > it makes explicit the intention of not using the parameter within > the function. > > Signed-off-by: Federico Serafini Reviewed-by:

Re: [PATCH] MAINTAINERS: remove myself from various positions

2024-03-14 Thread Stefano Stabellini
On Thu, 14 Mar 2024, Wei Liu wrote: > I have not been active in the Xen community for some time. Update the > MAINTAINERS file to reflect reality. > > Signed-off-by: Wei Liu Acked-by: Stefano Stabellini > --- > It has been a pleasure working with all of you. I'm sure we will cross > paths in

Re: [PATCH v2 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-14 Thread Jason Andryuk
On 2024-03-14 09:31, Jan Beulich wrote: On 13.03.2024 20:30, Jason Andryuk wrote: --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -537,6 +537,108 @@ static paddr_t __init find_memory( return INVALID_PADDR; } +static bool __init check_load_address( +

[PATCH] MAINTAINERS: remove myself from various positions

2024-03-14 Thread Wei Liu
I have not been active in the Xen community for some time. Update the MAINTAINERS file to reflect reality. Signed-off-by: Wei Liu --- It has been a pleasure working with all of you. I'm sure we will cross paths in the future. Seabios is in need for a new owner. For now I left my name there. ---

[linux-linus test] 185023: tolerable FAIL - PUSHED

2024-03-14 Thread osstest service owner
flight 185023 linux-linus real [real] flight 185038 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/185023/ http://logs.test-lab.xenproject.org/osstest/logs/185038/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH 6/7] xen: Swap find_first_set_bit() for ffsl() - 1

2024-03-14 Thread Andrew Cooper
On 14/03/2024 6:47 pm, Andrew Cooper wrote: > On 14/03/2024 2:30 pm, Jan Beulich wrote: >> On 13.03.2024 18:27, Andrew Cooper wrote: >>> --- a/xen/drivers/passthrough/x86/iommu.c >>> +++ b/xen/drivers/passthrough/x86/iommu.c >>> @@ -641,7 +641,7 @@ struct page_info *iommu_alloc_pgtable(struct >>>

Re: [PATCH 6/7] xen: Swap find_first_set_bit() for ffsl() - 1

2024-03-14 Thread Andrew Cooper
On 14/03/2024 2:30 pm, Jan Beulich wrote: > On 13.03.2024 18:27, Andrew Cooper wrote: >> --- a/xen/drivers/passthrough/x86/iommu.c >> +++ b/xen/drivers/passthrough/x86/iommu.c >> @@ -641,7 +641,7 @@ struct page_info *iommu_alloc_pgtable(struct >> domain_iommu *hd, >> if ( contig_mask ) >>

[xen-unstable-smoke test] 185035: tolerable all pass - PUSHED

2024-03-14 Thread osstest service owner
flight 185035 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185035/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v2 7/7] xen/ppc: mm-radix: Allocate Partition and Process Tables at runtime

2024-03-14 Thread Shawn Anastasio
Hi Jan, I'm revisiting this series in preparation for a v3 and had some follow-up comments. On 12/21/23 1:06 AM, Jan Beulich wrote: > On 15.12.2023 03:44, Shawn Anastasio wrote: >> In the initial mm-radix implementation, the in-memory partition and >> process tables required to configure the MMU

Re: [PATCH] SUPPORT.MD: Fix matrix generation after 43c416d0d819 and 77c39a53cf5b

2024-03-14 Thread Julien Grall
On 14/03/2024 17:41, Andrew Cooper wrote: On 14/03/2024 5:39 pm, Julien Grall wrote: From: Julien Grall The script docs/support-matrix-generate throw the following error on the latest staging. MDCCSR_EL0 DBGDTR_EL0 DBGDTRTX_EL0 DBGDTRRX_EL0 DBGDSCRINT DBGDTRTXINT DBGDTRRXINT ^ cannot

Re: [PATCH] SUPPORT.MD: Fix matrix generation after 43c416d0d819 and 77c39a53cf5b

2024-03-14 Thread Andrew Cooper
On 14/03/2024 5:39 pm, Julien Grall wrote: > From: Julien Grall > > The script docs/support-matrix-generate throw the following error on the > latest staging. > > MDCCSR_EL0 > DBGDTR_EL0 > DBGDTRTX_EL0 > DBGDTRRX_EL0 > DBGDSCRINT > DBGDTRTXINT > DBGDTRRXINT > ^ cannot parse status codeblock line:

[PATCH] SUPPORT.MD: Fix matrix generation after 43c416d0d819 and 77c39a53cf5b

2024-03-14 Thread Julien Grall
From: Julien Grall The script docs/support-matrix-generate throw the following error on the latest staging. MDCCSR_EL0 DBGDTR_EL0 DBGDTRTX_EL0 DBGDTRRX_EL0 DBGDSCRINT DBGDTRTXINT DBGDTRRXINT ^ cannot parse status codeblock line: MDCCSR_EL0 ? at docs/parse-support-md line 172, chunk 1. With

Re: [PATCH 7/7] xen/bitops: Delete find_first_set_bit()

2024-03-14 Thread Andrew Cooper
On 14/03/2024 3:59 pm, Jan Beulich wrote: > On 13.03.2024 18:27, Andrew Cooper wrote: >> --- a/xen/arch/x86/include/asm/bitops.h >> +++ b/xen/arch/x86/include/asm/bitops.h >> @@ -401,18 +401,6 @@ static always_inline unsigned int __scanbit(unsigned >> long val, unsigned int max) >> r__;

Re: [PATCH v2 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-14 Thread Jan Beulich
On 14.03.2024 17:59, Jason Andryuk wrote: > On 2024-03-14 11:30, Jan Beulich wrote: >> On 14.03.2024 15:33, Roger Pau Monné wrote: >>> On Thu, Mar 14, 2024 at 09:51:22AM -0400, Jason Andryuk wrote: On 2024-03-14 05:48, Roger Pau Monné wrote: > On Wed, Mar 13, 2024 at 03:30:21PM -0400,

Re: [PATCH v2 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-14 Thread Jason Andryuk
On 2024-03-14 11:30, Jan Beulich wrote: On 14.03.2024 15:33, Roger Pau Monné wrote: On Thu, Mar 14, 2024 at 09:51:22AM -0400, Jason Andryuk wrote: On 2024-03-14 05:48, Roger Pau Monné wrote: On Wed, Mar 13, 2024 at 03:30:21PM -0400, Jason Andryuk wrote: @@ -234,6 +235,17 @@ elf_errorstatus

Re: [PATCH 6/7] xen: Swap find_first_set_bit() for ffsl() - 1

2024-03-14 Thread Jan Beulich
On 14.03.2024 17:48, Oleksii wrote: > On Thu, 2024-03-14 at 15:30 +0100, Jan Beulich wrote: >> On 13.03.2024 18:27, Andrew Cooper wrote: >>> --- a/xen/drivers/passthrough/x86/iommu.c >>> +++ b/xen/drivers/passthrough/x86/iommu.c >>> @@ -641,7 +641,7 @@ struct page_info *iommu_alloc_pgtable(struct

Re: [PATCH v2 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-14 Thread Roger Pau Monné
On Thu, Mar 14, 2024 at 04:30:05PM +0100, Jan Beulich wrote: > On 14.03.2024 15:33, Roger Pau Monné wrote: > > On Thu, Mar 14, 2024 at 09:51:22AM -0400, Jason Andryuk wrote: > >> On 2024-03-14 05:48, Roger Pau Monné wrote: > >>> On Wed, Mar 13, 2024 at 03:30:21PM -0400, Jason Andryuk wrote: >

Re: [PATCH 6/7] xen: Swap find_first_set_bit() for ffsl() - 1

2024-03-14 Thread Oleksii
On Thu, 2024-03-14 at 15:30 +0100, Jan Beulich wrote: > On 13.03.2024 18:27, Andrew Cooper wrote: > > --- a/xen/drivers/passthrough/x86/iommu.c > > +++ b/xen/drivers/passthrough/x86/iommu.c > > @@ -641,7 +641,7 @@ struct page_info *iommu_alloc_pgtable(struct > > domain_iommu *hd, > > if (

[XEN PATCH] automation/eclair: allow parameter name "unused"

2024-03-14 Thread Federico Serafini
Update ECLAIR configuration of MISRA C:2012 Rule 8.3 to deviate violations involving parameter name "unused": it makes explicit the intention of not using the parameter within the function. Signed-off-by: Federico Serafini --- automation/eclair_analysis/ECLAIR/deviations.ecl | 4

Re: [PATCH 2/7] xen/bitops: Implement ffs() in common logic

2024-03-14 Thread Jan Beulich
On 14.03.2024 17:23, Andrew Cooper wrote: > On 14/03/2024 2:16 pm, Jan Beulich wrote: >> On 13.03.2024 18:27, Andrew Cooper wrote: >>> --- a/xen/arch/arm/include/asm/bitops.h >>> +++ b/xen/arch/arm/include/asm/bitops.h >>> @@ -157,7 +157,7 @@ static inline int fls(unsigned int x) >>> } >>> >>>

Re: [RISCV] [PATCH 0/7] xen/bitops: Reduce the mess, starting with ffs()

2024-03-14 Thread Oleksii
On Thu, 2024-03-14 at 16:33 +0100, Jan Beulich wrote: > On 14.03.2024 15:45, Andrew Cooper wrote: > > On 13/03/2024 5:27 pm, Andrew Cooper wrote: > > > Start cleaning it up with ffs() and friends.  Across the board, > > > this adds: > > > > > >  * Functioning bitops without arch-specific asm > >

Re: [PATCH] MAINTAINERS: drop AMD IOMMU and Intel VT-d sections

2024-03-14 Thread Andrew Cooper
On 14/03/2024 4:22 pm, Jan Beulich wrote: > We'd like to thank Kevin, so far the VT-d maintainer, for his past > contributions, while at the same time we'd like to reflect reality as it > has been for quite some time. Have VT-d maintainership (and for symmetry > also AMD IOMMU's) fall back to the

Re: [PATCH 2/7] xen/bitops: Implement ffs() in common logic

2024-03-14 Thread Andrew Cooper
On 14/03/2024 2:16 pm, Jan Beulich wrote: > On 13.03.2024 18:27, Andrew Cooper wrote: >> --- a/xen/arch/arm/include/asm/bitops.h >> +++ b/xen/arch/arm/include/asm/bitops.h >> @@ -157,7 +157,7 @@ static inline int fls(unsigned int x) >> } >> >> >> -#define ffs(x) ({ unsigned int __t = (x);

[PATCH] MAINTAINERS: drop AMD IOMMU and Intel VT-d sections

2024-03-14 Thread Jan Beulich
We'd like to thank Kevin, so far the VT-d maintainer, for his past contributions, while at the same time we'd like to reflect reality as it has been for quite some time. Have VT-d maintainership (and for symmetry also AMD IOMMU's) fall back to the maintainers of general x86. This also brings

Re: [PATCH v3 3/3] x86/svmdebug: Print np, sev and sev_es vmcb bits

2024-03-14 Thread Jan Beulich
On 13.03.2024 17:41, Vaishali Thakkar wrote: > Currently only raw _np_ctrl is being printed. It can > be informational to know about which particular bits > are enabled. So, this commit adds the bit-by-bit decode > for np, sev and sev_es bits. > > Note that while, only np is enabled in certain

Re: [PATCH v3 2/3] x86/svm: Drop the suffix _guest from vmcb bit

2024-03-14 Thread Jan Beulich
On 13.03.2024 17:41, Vaishali Thakkar wrote: > The suffix _guest is redundant for asid bit. Drop it > to avoid adding extra code volume. > > While we're here, replace 0/1 with false/true and use > VMCB accessors instead of open coding. > > Suggested-by: Andrew Cooper > Signed-off-by: Vaishali

Re: [PATCH 7/7] xen/bitops: Delete find_first_set_bit()

2024-03-14 Thread Jan Beulich
On 13.03.2024 18:27, Andrew Cooper wrote: > --- a/xen/arch/x86/include/asm/bitops.h > +++ b/xen/arch/x86/include/asm/bitops.h > @@ -401,18 +401,6 @@ static always_inline unsigned int __scanbit(unsigned > long val, unsigned int max) > r__;

Re: [PATCH 5/7] xen/bitops: Implement ffs64() in common logic

2024-03-14 Thread Jan Beulich
On 13.03.2024 18:27, Andrew Cooper wrote: > --- a/xen/common/bitops.c > +++ b/xen/common/bitops.c > @@ -47,6 +47,18 @@ static void test_ffs(void) > CHECK(ffsl, 1UL << (BITS_PER_LONG - 1), BITS_PER_LONG); > if ( BITS_PER_LONG > 32 ) > CHECK(ffsl, 1UL << 32, 33); > + > +/* > +

Re: [RISCV] [PATCH 0/7] xen/bitops: Reduce the mess, starting with ffs()

2024-03-14 Thread Andrew Cooper
On 14/03/2024 3:33 pm, Jan Beulich wrote: > On 14.03.2024 15:45, Andrew Cooper wrote: >> On 13/03/2024 5:27 pm, Andrew Cooper wrote: >>> Start cleaning it up with ffs() and friends. Across the board, this adds: >>> >>> * Functioning bitops without arch-specific asm >> It turns out that RISC-V

[xen-unstable test] 185029: regressions - FAIL

2024-03-14 Thread osstest service owner
flight 185029 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185029/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 185019

[xen-unstable-smoke test] 185033: tolerable all pass - PUSHED

2024-03-14 Thread osstest service owner
flight 185033 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185033/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [RISCV] [PATCH 0/7] xen/bitops: Reduce the mess, starting with ffs()

2024-03-14 Thread Jan Beulich
On 14.03.2024 15:45, Andrew Cooper wrote: > On 13/03/2024 5:27 pm, Andrew Cooper wrote: >> Start cleaning it up with ffs() and friends. Across the board, this adds: >> >> * Functioning bitops without arch-specific asm > > It turns out that RISC-V doesn't have a CLZ instruction in the base >

Re: [PATCH v2 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-14 Thread Jan Beulich
On 14.03.2024 15:33, Roger Pau Monné wrote: > On Thu, Mar 14, 2024 at 09:51:22AM -0400, Jason Andryuk wrote: >> On 2024-03-14 05:48, Roger Pau Monné wrote: >>> On Wed, Mar 13, 2024 at 03:30:21PM -0400, Jason Andryuk wrote: @@ -234,6 +235,17 @@ elf_errorstatus elf_xen_parse_note(struct

Re: [PATCH] docs/misra: add Rule 16.4

2024-03-14 Thread Bertrand Marquis
Hi Stefano, > On 14 Mar 2024, at 00:04, Stefano Stabellini wrote: > > On Wed, 13 Mar 2024, Jan Beulich wrote: >> On 13.03.2024 01:28, Stefano Stabellini wrote: >>> --- a/docs/misra/rules.rst >>> +++ b/docs/misra/rules.rst >>> @@ -478,6 +478,30 @@ maintainers if you want to suggest a change. >>>

[RISCV] [PATCH 0/7] xen/bitops: Reduce the mess, starting with ffs()

2024-03-14 Thread Andrew Cooper
On 13/03/2024 5:27 pm, Andrew Cooper wrote: > Start cleaning it up with ffs() and friends. Across the board, this adds: > > * Functioning bitops without arch-specific asm It turns out that RISC-V doesn't have a CLZ instruction in the base ISA.  As a consequence, __builtin_ffs() emits a library

Re: [PATCH v2 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-14 Thread Roger Pau Monné
On Thu, Mar 14, 2024 at 09:51:22AM -0400, Jason Andryuk wrote: > On 2024-03-14 05:48, Roger Pau Monné wrote: > > On Wed, Mar 13, 2024 at 03:30:21PM -0400, Jason Andryuk wrote: > > > Xen tries to load a PVH dom0 kernel at the fixed guest physical address > > > from the elf headers. For Linux, this

Re: [PATCH 1/7] multiboot2: Add load type header and support for the PE binary type

2024-03-14 Thread Jan Beulich
On 14.03.2024 15:24, Ross Lagerwall wrote: > On Thu, Mar 14, 2024 at 1:37 PM Jan Beulich wrote: >> On 14.03.2024 10:30, Ross Lagerwall wrote: >>> On Thu, Mar 14, 2024 at 7:24 AM Jan Beulich wrote: On 13.03.2024 16:07, Ross Lagerwall wrote: > In addition to the existing address and ELF

Re: [PATCH 6/7] xen: Swap find_first_set_bit() for ffsl() - 1

2024-03-14 Thread Jan Beulich
On 13.03.2024 18:27, Andrew Cooper wrote: > --- a/xen/drivers/passthrough/x86/iommu.c > +++ b/xen/drivers/passthrough/x86/iommu.c > @@ -641,7 +641,7 @@ struct page_info *iommu_alloc_pgtable(struct domain_iommu > *hd, > if ( contig_mask ) > { > /* See pt-contig-markers.h for a

Re: [PATCH 1/7] multiboot2: Add load type header and support for the PE binary type

2024-03-14 Thread Ross Lagerwall
On Thu, Mar 14, 2024 at 1:37 PM Jan Beulich wrote: > > On 14.03.2024 10:30, Ross Lagerwall wrote: > > On Thu, Mar 14, 2024 at 7:24 AM Jan Beulich wrote: > >> > >> On 13.03.2024 16:07, Ross Lagerwall wrote: > >>> In addition to the existing address and ELF load types, specify a new > >>> optional

Re: [PATCH v2] xen/arm: Set correct per-cpu cpu_core_mask

2024-03-14 Thread Henry Wang
Hi Julien, On 3/14/2024 9:27 PM, Julien Grall wrote: Hi Henry, On 28/02/2024 01:58, Henry Wang wrote: diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index a84e706d77..d9ebd55d4a 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -66,7 +66,6 @@ static bool

Re: [PATCH v2] xen/blkback: use kmap_local_page()

2024-03-14 Thread Roger Pau Monné
On Thu, Mar 14, 2024 at 09:28:43PM +0800, flyingpeng...@gmail.com wrote: > From: Peng Hao > > Use kmap_local_page() instead of kmap_atomic() which has been > deprecated. > > Signed-off-by: Peng Hao Acked-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH v2 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-14 Thread Jan Beulich
On 14.03.2024 15:13, Jason Andryuk wrote: > On 2024-03-14 09:21, Jan Beulich wrote: >> On 13.03.2024 20:30, Jason Andryuk wrote: >>> --- a/xen/include/public/elfnote.h >>> +++ b/xen/include/public/elfnote.h >>> @@ -194,6 +194,17 @@ >>>*/ >>> #define XEN_ELFNOTE_PHYS32_ENTRY 18 >>> >>> +/*

Re: [PATCH 2/7] xen/bitops: Implement ffs() in common logic

2024-03-14 Thread Jan Beulich
On 13.03.2024 18:27, Andrew Cooper wrote: > --- a/xen/arch/arm/include/asm/bitops.h > +++ b/xen/arch/arm/include/asm/bitops.h > @@ -157,7 +157,7 @@ static inline int fls(unsigned int x) > } > > > -#define ffs(x) ({ unsigned int __t = (x); fls(ISOLATE_LSB(__t)); }) > +#define arch_ffs(x) ({

Re: [PATCH v2 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-14 Thread Jason Andryuk
On 2024-03-14 09:21, Jan Beulich wrote: On 13.03.2024 20:30, Jason Andryuk wrote: --- a/xen/include/public/elfnote.h +++ b/xen/include/public/elfnote.h @@ -194,6 +194,17 @@ */ #define XEN_ELFNOTE_PHYS32_ENTRY 18 +/* + * Physical loading constraints for PVH kernels + * + * Used to place

Re: [PATCH 1/7] xen/bitops: Cleanup ahead of rearrangements

2024-03-14 Thread Jan Beulich
On 13.03.2024 18:27, Andrew Cooper wrote: > * Rename __attribute_pure__ to just __pure before it gains users. > * Identify the areas of xen/bitops.h which are a mess. > * Create common/bitops.c for compile and runtime testing. This provides a >statement of the ABI, and a confirmation that

RE: IMPORTANT - : Need help on USB port virtualization with Xen hypervisor

2024-03-14 Thread LARRIEU Dominique
Hi Julien, You will find here above the answers to your questions. Thank you very much for your help. Best regards, Dominique -Message d'origine- De : Julien Grall mailto:jul...@xen.org>> Envoyé : jeudi 29 février 2024 12:52 À : LARRIEU Dominique

Re: [PATCH v2 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-14 Thread Jason Andryuk
On 2024-03-14 05:48, Roger Pau Monné wrote: On Wed, Mar 13, 2024 at 03:30:21PM -0400, Jason Andryuk wrote: Xen tries to load a PVH dom0 kernel at the fixed guest physical address from the elf headers. For Linux, this defaults to 0x100 (16MB), but it can be configured. Unfortunately there

Re: [XEN PATCH] tools: add x2APIC entries in MADT based on APIC ID

2024-03-14 Thread Jan Beulich
On 13.03.2024 16:35, Matthew Barnes wrote: > libacpi is a tool that is used by libxl (for PVH guests) and hvmloader > (for HVM guests) to construct ACPI tables for guests. > > Currently, libacpi only uses APIC entries to enumerate processors for > guests in the MADT. > > The APIC ID field in

Re: [PATCH 3/7] xen/bitops: Implement ffsl() in common logic

2024-03-14 Thread Andrew Cooper
On 13/03/2024 5:48 pm, Andrew Cooper wrote: > On 13/03/2024 5:27 pm, Andrew Cooper wrote: >> xen/arch/arm/include/asm/bitops.h | 2 +- >> xen/arch/ppc/include/asm/bitops.h | 1 - >> xen/arch/x86/include/asm/bitops.h | 30 +- >> xen/common/bitops.c | 7

Re: [PATCH 1/7] multiboot2: Add load type header and support for the PE binary type

2024-03-14 Thread Jan Beulich
On 14.03.2024 10:30, Ross Lagerwall wrote: > On Thu, Mar 14, 2024 at 7:24 AM Jan Beulich wrote: >> >> On 13.03.2024 16:07, Ross Lagerwall wrote: >>> In addition to the existing address and ELF load types, specify a new >>> optional PE binary load type. This new type is a useful addition since >>>

Re: [PATCH v2 1/3] Revert "xen/x86: bzImage parse kernel_alignment"

2024-03-14 Thread Jan Beulich
On 14.03.2024 14:01, Jason Andryuk wrote: > On 2024-03-14 03:11, Jan Beulich wrote: >> On 13.03.2024 20:30, Jason Andryuk wrote: >>> A new ELF note will specify the alignment for a relocatable PVH kernel. >>> ELF notes are suitable for vmlinux and other ELF files, so this >>> Linux-specific

Re: [PATCH v2 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-14 Thread Jan Beulich
On 13.03.2024 20:30, Jason Andryuk wrote: > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build.c > @@ -537,6 +537,108 @@ static paddr_t __init find_memory( > return INVALID_PADDR; > } > > +static bool __init check_load_address( > +const struct domain *d, const

[PATCH v2] xen/blkback: use kmap_local_page()

2024-03-14 Thread flyingpenghao
From: Peng Hao Use kmap_local_page() instead of kmap_atomic() which has been deprecated. Signed-off-by: Peng Hao --- drivers/block/xen-blkback/blkback.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c

Re: [PATCH] xen/blkback: use kmap_local_page()

2024-03-14 Thread Hao Peng
On Wed, Mar 6, 2024 at 4:41 PM Roger Pau Monné wrote: > > On Wed, Mar 06, 2024 at 01:15:48PM +0800, flyingpeng...@gmail.com wrote: > > From: Peng Hao > > > > From: Peng Hao > > > > Use kmap_local_page() instead of kmap_atomic() which has been > > deprecated. > > > > Signed-off-by: Peng Hao > >

Re: [PATCH v2] xen/arm: Set correct per-cpu cpu_core_mask

2024-03-14 Thread Julien Grall
Hi Henry, On 28/02/2024 01:58, Henry Wang wrote: In the common sysctl command XEN_SYSCTL_physinfo, the value of cores_per_socket is calculated based on the cpu_core_mask of CPU0. Currently on Arm this is a fixed value 1 (can be checked via xl info), which is not correct. This is because during

Re: [PATCH v2 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-14 Thread Jan Beulich
On 13.03.2024 20:30, Jason Andryuk wrote: > --- a/xen/include/public/elfnote.h > +++ b/xen/include/public/elfnote.h > @@ -194,6 +194,17 @@ > */ > #define XEN_ELFNOTE_PHYS32_ENTRY 18 > > +/* > + * Physical loading constraints for PVH kernels > + * > + * Used to place constraints on the guest

Re: [PATCH v2 2/3] libelf: Expand ELF note printing

2024-03-14 Thread Jan Beulich
On 13.03.2024 20:30, Jason Andryuk wrote: > @@ -217,6 +225,15 @@ elf_errorstatus elf_xen_parse_note(struct elf_binary > *elf, > case XEN_ELFNOTE_PHYS32_ENTRY: > parms->phys_entry = val; > break; > + > +case XEN_ELFNOTE_L1_MFN_VALID: > +if ( elf_uval(elf, note,

Re: [XEN v6 0/3] xen/arm: Add emulation of Debug Data Transfer Registers

2024-03-14 Thread Julien Grall
Hi Ayan, On 07/03/2024 12:39, Ayan Kumar Halder wrote: Hi, Refer https://lore.kernel.org/all/alpine.DEB.2.22.394.2312071341540.1265976@ubuntu-linux-20-04-desktop/T/ for the previous discussion on this issue. Also, the linux earlycon hvc driver has been fixed. See

Re: [PATCH v2 1/3] Revert "xen/x86: bzImage parse kernel_alignment"

2024-03-14 Thread Jason Andryuk
On 2024-03-14 03:11, Jan Beulich wrote: On 13.03.2024 20:30, Jason Andryuk wrote: A new ELF note will specify the alignment for a relocatable PVH kernel. ELF notes are suitable for vmlinux and other ELF files, so this Linux-specific bzImage parsing in unnecessary. Hmm, shouldn't the order of

Re: [XEN PATCH v3 15/16] x86/mtrr: address violations of MISRA C:2012 Directive 4.10

2024-03-14 Thread Jan Beulich
On 11.03.2024 09:59, Simone Ballarin wrote: > From: Maria Celeste Cesario > > Add inclusion guard to address violations of > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to > prevent the contents of a header file being included more than once"). > Mechanical change. > --- >

Re: [PATCH v2 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-14 Thread Jason Andryuk
On 2024-03-14 03:12, Jan Beulich wrote: On 13.03.2024 22:02, Jason Andryuk wrote: On 2024-03-13 15:30, Jason Andryuk wrote: +/* Find an e820 RAM region that fits the kernel at a suitable alignment. */ +static paddr_t __init find_kernel_memory( +const struct domain *d, struct elf_binary

Re: [XEN PATCH] perfc: add pseudo-keyword fallthrough

2024-03-14 Thread Jan Beulich
On 14.03.2024 13:25, Federico Serafini wrote: > Add pseudo-keyword fallthrough to make explicit the intention of the > code and meet requirements to deviate MISRA C:2012 Rule 16.3 > ("An unconditional `break' statement shall terminate every > switch-clause"). > > No functional change. > >

[XEN PATCH] perfc: add pseudo-keyword fallthrough

2024-03-14 Thread Federico Serafini
Add pseudo-keyword fallthrough to make explicit the intention of the code and meet requirements to deviate MISRA C:2012 Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause"). No functional change. Signed-off-by: Federico Serafini --- xen/common/perfc.c | 2 ++ 1

Re: [XEN PATCH] amd/iommu: add fixed size to function parameter of array type

2024-03-14 Thread Jan Beulich
On 14.03.2024 10:25, Nicola Vetrini wrote: > On 2024-03-14 09:32, Jan Beulich wrote: >> On 14.03.2024 08:42, Nicola Vetrini wrote: >>> The 'cmd' parameter of amd_iommu_send_guest_cmd is passed >>> to a function that expects arrays of size 4, therefore >>> specifying explicitly the size also in

Re: [XEN PATCH v2] xen: avoid grep fodder define and undef

2024-03-14 Thread Andrew Cooper
On 14/03/2024 7:37 am, Federico Serafini wrote: > Place an "#if 0" before grep fodder #define-s and remove > the #undef-s. > > This addresses violations of MISRA C:2012 Rules 20.5 ("#undef should > not be used") and 5.5 ("Identifiers shall be distinct from macro > names"). > > No functional

[xen-4.18-testing test] 185020: regressions - FAIL

2024-03-14 Thread osstest service owner
flight 185020 xen-4.18-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/185020/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 185003

Re: [PATCH v5 13/13] xen: allow up to 16383 cpus

2024-03-14 Thread Jürgen Groß
On 14.03.24 08:26, Jan Beulich wrote: On 14.03.2024 08:20, Juergen Gross wrote: With lock handling now allowing up to 16384 cpus (spinlocks can handle 65535 cpus, rwlocks can handle 16384 cpus), raise the allowed limit for the number of cpus to be configured to 16383. The new limit is imposed

Re: [PATCH v5 01/13] xen/spinlock: remove misra rule 21.1 violations

2024-03-14 Thread Jürgen Groß
On 14.03.24 08:32, Jan Beulich wrote: On 14.03.2024 08:20, Juergen Gross wrote: In xen spinlock code there are several violations of MISRA rule 21.1 (identifiers starting with "__" or "_[A-Z]"). Fix them by using trailing underscores instead. Signed-off-by: Juergen Gross I can live with

Re: [PATCH] MAINTAINERS: make Roger an IOMMU Maintainer

2024-03-14 Thread Roger Pau Monné
On Thu, Mar 14, 2024 at 08:06:27AM +0100, Jan Beulich wrote: > On 14.03.2024 00:40, Stefano Stabellini wrote: > > Roger kindly volunteered to step up as IOMMU Maintainer. > > > > Signed-off-by: Stefano Stabellini > > Acked-by: Jan Beulich Acked-by: Roger Pau Monné Thanks.

  1   2   >