Re: [PATCH v2 06/12] VT-d: respect ACPI SATC's ATC_REQUIRED flag

2024-05-20 Thread Jan Beulich
On 20.05.2024 13:36, Roger Pau Monné wrote: > On Wed, May 15, 2024 at 12:42:40PM +0200, Jan Beulich wrote: >> On 06.05.2024 15:38, Roger Pau Monné wrote: >>> On Thu, Feb 15, 2024 at 11:16:11AM +0100, Jan Beulich wrote: When the flag is set, permit Dom0 to control the device (no worse than

Re: [PATCH v2 05/12] IOMMU: rename and re-type ats_enabled

2024-05-20 Thread Jan Beulich
On 20.05.2024 12:29, Roger Pau Monné wrote: > On Wed, May 15, 2024 at 12:07:50PM +0200, Jan Beulich wrote: >> On 06.05.2024 15:53, Roger Pau Monné wrote: >>> On Mon, May 06, 2024 at 03:20:38PM +0200, Jan Beulich wrote: On 06.05.2024 14:42, Roger Pau Monné wrote: > On Thu, Feb 15, 2024 at 1

Re: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"

2024-05-20 Thread Jan Beulich
On 17.05.2024 22:28, Stefano Stabellini wrote: > On Fri, 17 May 2024, Jan Beulich wrote: >> On 17.05.2024 03:21, Stefano Stabellini wrote: >>> On Thu, 16 May 2024, Jan Beulich wrote: 1) In the discussion George claimed that exposing status information in an uncontrolled manner is okay. I'

Re: [PATCH] tools: Add install/uninstall targets to tests/x86_emulator

2024-05-20 Thread Jan Beulich
On 16.05.2024 16:46, Alejandro Vallejo wrote: > Hi, > > On 16/05/2024 13:37, Jan Beulich wrote: >> On 16.05.2024 14:29, Alejandro Vallejo wrote: >>> On 16/05/2024 12:35, Roger Pau Monné wrote: On Thu, May 16, 2024 at 12:07:10PM +0100, Alejandro Vallejo wrote: > Bring test_x86_emulator in

Re: [XEN PATCH v3 2/6] x86/intel: move vmce_has_lmce() routine to header

2024-05-20 Thread Jan Beulich
On 20.05.2024 11:32, Sergiy Kibrik wrote: > 16.05.24 12:39, Jan Beulich: >> On 14.05.2024 10:20, Sergiy Kibrik wrote: >>> Moving this function out of mce_intel.c would make it possible to disable >>> build of Intel MCE code later on, because the function gets called from >>> common x86 code. >> >>

[xen-unstable test] 186049: tolerable FAIL - PUSHED

2024-05-20 Thread osstest service owner
flight 186049 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/186049/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 186042 test-amd64-amd64-xl-qemut-win7-amd64

[PATCH v3 8/8] docs: Add device tree overlay documentation

2024-05-20 Thread Henry Wang
From: Vikram Garhwal Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Signed-off-by: Henry Wang --- v3: - No change. v2: - Update the content based on the changes in this version. --- docs/misc/arm/overlay.txt | 99 +++ 1 file changed, 99 ins

[PATCH v3 0/8] Remaining patches for dynamic node programming using overlay dtbo

2024-05-20 Thread Henry Wang
Hi all, This is the remaining series for the full functional "dynamic node programming using overlay dtbo" feature. The first part [1] has already been merged. Quoting from the original series, the first part has already made Xen aware of new device tree node which means updating the dt_host with

[PATCH v3 3/8] xen/arm, doc: Add a DT property to specify IOMMU for Dom0less domUs

2024-05-20 Thread Henry Wang
There are some use cases in which the dom0less domUs need to have the XEN_DOMCTL_CDF_iommu set at the domain construction time. For example, the dynamic dtbo feature allows the domain to be assigned a device that is behind the IOMMU at runtime. For these use cases, we need to have a way to specify

[PATCH v3 1/8] xen/common/dt-overlay: Fix lock issue when add/remove the device

2024-05-20 Thread Henry Wang
If CONFIG_DEBUG=y, below assertion will be triggered: (XEN) Assertion 'rw_is_locked(&dt_host_lock)' failed at drivers/passthrough/device_tree.c:146 (XEN) [ Xen-4.19-unstable arm64 debug=y Not tainted ] [...] (XEN) Xen call trace: (XEN)[<0a257418>] iommu_remove_dt_device+0x8c

[PATCH v3 7/8] tools: Introduce the "xl dt-overlay {attach,detach}" commands

2024-05-20 Thread Henry Wang
With the XEN_DOMCTL_dt_overlay DOMCTL added, users should be able to attach/detach devices from the provided DT overlay to domains. Support this by introducing a new set of "xl dt-overlay" commands and related documentation, i.e. "xl dt-overlay {attach,detach}". Slightly rework the command option p

[PATCH v3 6/8] xen/arm: Add XEN_DOMCTL_dt_overlay DOMCTL and related operations

2024-05-20 Thread Henry Wang
In order to support the dynamic dtbo device assignment to a running VM, the add/remove of the DT overlay and the attach/detach of the device from the DT overlay should happen separately. Therefore, repurpose the existing XEN_SYSCTL_dt_overlay to only add the DT overlay to Xen device tree, instead o

[PATCH v3 5/8] xen/arm/gic: Allow routing/removing interrupt to running VMs

2024-05-20 Thread Henry Wang
From: Vikram Garhwal Currently, routing/removing physical interrupts are only allowed at the domain creation/destroy time. For use cases such as dynamic device tree overlay adding/removing, the routing/removing of physical IRQ to running domains should be allowed. Removing the above-mentioned do

[PATCH v3 4/8] tools/arm: Introduce the "nr_spis" xl config entry

2024-05-20 Thread Henry Wang
Currently, the number of SPIs allocated to the domain is only configurable for Dom0less DomUs. Xen domains are supposed to be platform agnostics and therefore the numbers of SPIs for libxl guests should not be based on the hardware. Introduce a new xl config entry for Arm to provide a method for u

[PATCH v3 2/8] tools/xl: Correct the help information and exit code of the dt-overlay command

2024-05-20 Thread Henry Wang
Fix the name mismatch in the xl dt-overlay command, the command name should be "dt-overlay" instead of "dt_overlay". Add the missing "," in the cmdtable. Fix the exit code of the dt-overlay command, use EXIT_FAILURE instead of ERROR_FAIL. Fixes: 61765a07e3d8 ("tools/xl: Add new xl command overlay

[ovmf test] 186054: all pass - PUSHED

2024-05-20 Thread osstest service owner
flight 186054 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186054/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7142e648416ff5d3eac6c6d607874805f5de0ca8 baseline version: ovmf 284dbac43da752ee34825

[xen-unstable-smoke test] 186050: regressions - FAIL

2024-05-20 Thread osstest service owner
flight 186050 xen-unstable-smoke real [real] flight 186053 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186050/ http://logs.test-lab.xenproject.org/osstest/logs/186053/ Regressions :-( Tests which did not succeed and are blocking, including tests which co

[PATCH v3 0/2] Add API for making parts of a MMIO page R/O and use it in XHCI console

2024-05-20 Thread Marek Marczykowski-Górecki
On older systems, XHCI xcap had a layout that no other (interesting) registers were placed on the same page as the debug capability, so Linux was fine with making the whole page R/O. But at least on Tiger Lake and Alder Lake, Linux needs to write to some other registers on the same page too. Add a

[PATCH v3 2/2] drivers/char: Use sub-page ro API to make just xhci dbc cap RO

2024-05-20 Thread Marek Marczykowski-Górecki
Not the whole page, which may contain other registers too. The XHCI specification describes DbC as designed to be controlled by a different driver, but does not mandate placing registers on a separate page. In fact on Tiger Lake and newer (at least), this page do contain other registers that Linux

[PATCH v3 1/2] x86/mm: add API for marking only part of a MMIO page read only

2024-05-20 Thread Marek Marczykowski-Górecki
In some cases, only few registers on a page needs to be write-protected. Examples include USB3 console (64 bytes worth of registers) or MSI-X's PBA table (which doesn't need to span the whole table either), although in the latter case the spec forbids placing other registers on the same page. Curre

Re: [PATCH v2 5/8] xen/arm/gic: Allow routing/removing interrupt to running VMs

2024-05-20 Thread Stefano Stabellini
On Mon, 20 May 2024, Julien Grall wrote: > Hi Henry, > > On 20/05/2024 02:01, Henry Wang wrote: > > Hi Julien, > > > > On 5/19/2024 7:08 PM, Julien Grall wrote: > > > Hi, > > > > > > On 17/05/2024 07:03, Henry Wang wrote: > > > > > @@ -444,14 +444,18 @@ int vgic_connect_hw_irq(struct domain *d,

[linux-linus test] 186047: tolerable FAIL - PUSHED

2024-05-20 Thread osstest service owner
flight 186047 linux-linus real [real] flight 186051 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186047/ http://logs.test-lab.xenproject.org/osstest/logs/186051/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-

Re: [PATCH v2 7/8] tools: Introduce the "xl dt-overlay {attach,detach}" commands

2024-05-20 Thread Henry Wang
Hi Jason, On 5/21/2024 3:41 AM, Jason Andryuk wrote: On 2024-05-16 06:03, Henry Wang wrote: +    domain_id = strtol(argv[optind+2], NULL, 10); domain_id = find_domain(argv[optind+2]); Good point, thanks. I will use the find_domain() in the next version. Kind regards, Henry And y

Re: [PATCH v2 4/8] tools/arm: Introduce the "nr_spis" xl config entry

2024-05-20 Thread Henry Wang
Hi Jason, On 5/21/2024 3:13 AM, Jason Andryuk wrote: + +=item B + +A 32-bit optional integer parameter specifying the number of SPIs (Shared I'd phrase it "An optional 32-but integer" +Peripheral Interrupts) to allocate for the domain. If the `nr_spis` parameter +is missing, the max number

Re: [PATCH v3 1/4] xen/arm/static-shmem: Static-shmem should be direct-mapped for direct-mapped domains

2024-05-20 Thread Henry Wang
Hi Michal, On 5/21/2024 12:09 AM, Michal Orzel wrote: Thanks. I will take the tag if you are ok with above diff (for the case if this series goes in later than Luca's). I would move this check to process_shm() right after "gbase = dt_read_paddr" setting. This would be the most natural placemen

[xen-unstable-smoke test] 186048: tolerable all pass - PUSHED

2024-05-20 Thread osstest service owner
flight 186048 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/186048/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] tools/xl: add suspend-to-ram and resume subcommands

2024-05-20 Thread Jason Andryuk
Hi Zithro, On 2024-04-24 10:03, Jason Andryuk wrote: On 2024-02-29 02:00, zithro / Cyril Rébert wrote: The xl command doesn't provide suspend/resume, so add them :    xl suspend-to-ram    xl resume This patch follows a discussion on XenDevel: when you want the virtualized equivalent of "slee

Re: [PATCH v2 7/8] tools: Introduce the "xl dt-overlay {attach,detach}" commands

2024-05-20 Thread Jason Andryuk
On 2024-05-16 06:03, Henry Wang wrote: With the XEN_DOMCTL_dt_overlay DOMCTL added, users should be able to attach/detach devices from the provided DT overlay to domains. Support this by introducing a new set of "xl dt-overlay" commands and related documentation, i.e. "xl dt-overlay {attach,detac

Re: [PATCH v2 4/8] tools/arm: Introduce the "nr_spis" xl config entry

2024-05-20 Thread Jason Andryuk
On 2024-05-16 06:03, Henry Wang wrote: Currently, the number of SPIs allocated to the domain is only configurable for Dom0less DomUs. Xen domains are supposed to be platform agnostics and therefore the numbers of SPIs for libxl guests should not be based on the hardware. Introduce a new xl confi

Re: [PATCH v2 2/8] tools/xl: Correct the help information and exit code of the dt-overlay command

2024-05-20 Thread Jason Andryuk
On 2024-05-16 06:03, Henry Wang wrote: Fix the name mismatch in the xl dt-overlay command, the command name should be "dt-overlay" instead of "dt_overlay". Add the missing "," in the cmdtable. Fix the exit code of the dt-overlay command, use EXIT_FAILURE instead of ERROR_FAIL. Fixes: 61765a07e3

Re: [PATCH v3 3/4] tools/init-dom0less: Avoid hardcoding GUEST_MAGIC_BASE

2024-05-20 Thread Jason Andryuk
On 2024-05-16 23:21, Henry Wang wrote: Currently the GUEST_MAGIC_BASE in the init-dom0less application is hardcoded, which will lead to failures for 1:1 direct-mapped Dom0less DomUs. Since the guest magic region allocation from init-dom0less is for XenStore, and the XenStore page is now allocate

[xen-unstable-smoke test] 186046: tolerable all pass - PUSHED

2024-05-20 Thread osstest service owner
flight 186046 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/186046/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v3.5 3/4] tools/xen-cpuid: Use automatically generated feature names

2024-05-20 Thread Andrew Cooper
On 20/05/2024 5:29 pm, Roger Pau Monné wrote: > On Mon, May 20, 2024 at 04:20:37PM +0100, Andrew Cooper wrote: >> On 20/05/2024 4:07 pm, Roger Pau Monné wrote: >>> On Mon, May 20, 2024 at 03:33:59PM +0100, Andrew Cooper wrote: From: Roger Pau Monné Have gen-cpuid.py write out INIT_F

Re: [PATCH] tools/libs/light: Fix nic->vlan memory allocation

2024-05-20 Thread Jason Andryuk
On 2024-05-20 12:44, Leigh Brown wrote: After the following commit: 3bc14e4fa4b9 ("tools/libs/light: Add vlan field to libxl_device_nic") xl list -l aborts with a double free error if a domain has at least one vif defined: $ sudo xl list -l free(): double free detected in tcache 2 Abort

[PATCH] tools/libs/light: Fix nic->vlan memory allocation

2024-05-20 Thread Leigh Brown
After the following commit: 3bc14e4fa4b9 ("tools/libs/light: Add vlan field to libxl_device_nic") xl list -l aborts with a double free error if a domain has at least one vif defined: $ sudo xl list -l free(): double free detected in tcache 2 Aborted Orginally, the vlan field was called vid

Re: xl list -l aborts with double free error with vlan patches

2024-05-20 Thread Leigh Brown
Hi, On 2024-05-20 15:33, Leigh Brown wrote: Hello, When running xl list -l with my VLAN patches applied, a double free error is raised. I'm unable to determine why. broken: 0cc01c603f4287233715a526b056bc20e0e97412 (HEAD) tools/xl: add vlan keyword to vif option okay: 3bc14e4fa4b9832888710

Re: [PATCH v3.5 3/4] tools/xen-cpuid: Use automatically generated feature names

2024-05-20 Thread Roger Pau Monné
On Mon, May 20, 2024 at 04:20:37PM +0100, Andrew Cooper wrote: > On 20/05/2024 4:07 pm, Roger Pau Monné wrote: > > On Mon, May 20, 2024 at 03:33:59PM +0100, Andrew Cooper wrote: > >> From: Roger Pau Monné > >> > >> Have gen-cpuid.py write out INIT_FEATURE_VAL_TO_NAME, derived from the same > >> da

Re: [PATCH v3 1/4] xen/arm/static-shmem: Static-shmem should be direct-mapped for direct-mapped domains

2024-05-20 Thread Michal Orzel
On 20/05/2024 17:51, Henry Wang wrote: > Hi Michal, > > On 5/20/2024 11:46 PM, Michal Orzel wrote: >> Hi Henry, >> >> On 20/05/2024 16:52, Henry Wang wrote: >>> Hi Michal, Luca, >>> >>> On 5/20/2024 7:24 PM, Michal Orzel wrote: Hi Henry, +CC: Luca On 17/05/2024 05:21, H

Re: [PATCH v3 1/4] xen/arm/static-shmem: Static-shmem should be direct-mapped for direct-mapped domains

2024-05-20 Thread Henry Wang
Hi Michal, On 5/20/2024 11:46 PM, Michal Orzel wrote: Hi Henry, On 20/05/2024 16:52, Henry Wang wrote: Hi Michal, Luca, On 5/20/2024 7:24 PM, Michal Orzel wrote: Hi Henry, +CC: Luca On 17/05/2024 05:21, Henry Wang wrote: To make things easier, add restriction that static shared memory sho

Re: [PATCH v3 1/4] xen/arm/static-shmem: Static-shmem should be direct-mapped for direct-mapped domains

2024-05-20 Thread Michal Orzel
Hi Henry, On 20/05/2024 16:52, Henry Wang wrote: > Hi Michal, Luca, > > On 5/20/2024 7:24 PM, Michal Orzel wrote: >> Hi Henry, >> >> +CC: Luca >> >> On 17/05/2024 05:21, Henry Wang wrote: >>> To make things easier, add restriction that static shared memory >>> should also be direct-mapped for dir

Re: [PATCH v3.5 3/4] tools/xen-cpuid: Use automatically generated feature names

2024-05-20 Thread Andrew Cooper
On 20/05/2024 4:07 pm, Roger Pau Monné wrote: > On Mon, May 20, 2024 at 03:33:59PM +0100, Andrew Cooper wrote: >> From: Roger Pau Monné >> >> Have gen-cpuid.py write out INIT_FEATURE_VAL_TO_NAME, derived from the same >> data source as INIT_FEATURE_NAME_TO_VAL, although both aliases of common_1d >

Re: [PATCH v3.5 3/4] tools/xen-cpuid: Use automatically generated feature names

2024-05-20 Thread Roger Pau Monné
On Mon, May 20, 2024 at 03:33:59PM +0100, Andrew Cooper wrote: > From: Roger Pau Monné > > Have gen-cpuid.py write out INIT_FEATURE_VAL_TO_NAME, derived from the same > data source as INIT_FEATURE_NAME_TO_VAL, although both aliases of common_1d > are needed. > > In xen-cpuid.c, sanity check at b

Re: [PATCH v2 2/2] tools/xg: Clean up xend-style overrides for CPU policies

2024-05-20 Thread Roger Pau Monné
On Fri, May 17, 2024 at 05:08:35PM +0100, Alejandro Vallejo wrote: > Factor out policy getters/setters from both (CPUID and MSR) policy override > functions. Additionally, use host policy rather than featureset when > preparing the cur policy, saving one hypercall and several lines of > boilerplate

[linux-linus test] 186044: regressions - FAIL

2024-05-20 Thread osstest service owner
flight 186044 linux-linus real [real] flight 186045 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186044/ http://logs.test-lab.xenproject.org/osstest/logs/186045/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

Re: [PATCH v3 1/4] xen/arm/static-shmem: Static-shmem should be direct-mapped for direct-mapped domains

2024-05-20 Thread Henry Wang
Hi Michal, Luca, On 5/20/2024 7:24 PM, Michal Orzel wrote: Hi Henry, +CC: Luca On 17/05/2024 05:21, Henry Wang wrote: To make things easier, add restriction that static shared memory should also be direct-mapped for direct-mapped domains. Check the host physical address to be matched with gue

xl list -l aborts with double free error with vlan patches

2024-05-20 Thread Leigh Brown
Hello, When running xl list -l with my VLAN patches applied, a double free error is raised. I'm unable to determine why. broken: 0cc01c603f4287233715a526b056bc20e0e97412 (HEAD) tools/xl: add vlan keyword to vif option okay: 3bc14e4fa4b9832888710759a7dbe5f0d239f33b tools/libs/light: Add vla

[PATCH v3.5 3/4] tools/xen-cpuid: Use automatically generated feature names

2024-05-20 Thread Andrew Cooper
From: Roger Pau Monné Have gen-cpuid.py write out INIT_FEATURE_VAL_TO_NAME, derived from the same data source as INIT_FEATURE_NAME_TO_VAL, although both aliases of common_1d are needed. In xen-cpuid.c, sanity check at build time that leaf_info[] and feature_names[] are of sensible length. As du

Re: [PATCH 1/4] x86/gen-cpuid: Minor cleanup

2024-05-20 Thread Andrew Cooper
On 14/05/2024 8:14 am, Roger Pau Monné wrote: > On Fri, May 10, 2024 at 11:39:59PM +0100, Andrew Cooper wrote: >> Rename INIT_FEATURE_NAMES to INIT_FEATURE_NAME_TO_VAL as we're about to gain >> a >> inverse mapping of the same thing. >> >> Use dict.items() unconditionally. iteritems() is a margin

Re: [PATCH v2 1/2] tools/xg: Streamline cpu policy serialise/deserialise calls

2024-05-20 Thread Roger Pau Monné
On Fri, May 17, 2024 at 05:08:34PM +0100, Alejandro Vallejo wrote: > The idea is to use xc_cpu_policy_t as a single object containing both the > serialised and deserialised forms of the policy. Note that we need lengths > for the arrays, as the serialised policies may be shorter than the array > ca

Re: [PATCH for-4.19] x86/msi: prevent watchdog triggering when dumping MSI state

2024-05-20 Thread Andrew Cooper
On 17/05/2024 2:56 pm, Roger Pau Monne wrote: > Use the same check that's used in dump_irqs(). > > Signed-off-by: Roger Pau Monné Acked-by: Andrew Cooper

Re: [PATCH v2 6/7] xen/arm: Implement the logic for static shared memory from Xen heap

2024-05-20 Thread Michal Orzel
On 20/05/2024 15:11, Luca Fancellu wrote: > > >>> > +struct shmem_membank_extra *bank_extra_info; > +} alloc_heap_pages_cb_extra; > + > +static struct meminfo __initdata shm_heap_banks = { > +.common.max_banks = NR_MEM_BANKS Do we expect that many banks? >

Re: [PATCH v2 6/7] xen/arm: Implement the logic for static shared memory from Xen heap

2024-05-20 Thread Luca Fancellu
>> >>> +struct shmem_membank_extra *bank_extra_info; +} alloc_heap_pages_cb_extra; + +static struct meminfo __initdata shm_heap_banks = { +.common.max_banks = NR_MEM_BANKS >>> Do we expect that many banks? >> >> Not really, but I was trying to don’t introduce ano

Re: [PATCH] tools/golang: Add missing golang bindings for vlan

2024-05-20 Thread George Dunlap
On Mon, May 20, 2024 at 9:21 AM Henry Wang wrote: > > It is noticed that commit: > 3bc14e4fa4b9 ("tools/libs/light: Add vlan field to libxl_device_nic") > introduces a new "vlan" string field to libxl_device_nic. But the > golang bindings are missing. Add it in this patch. > > Fixes: 3bc14e4fa4b9

Re: [PATCH v2 6/7] xen/arm: Implement the logic for static shared memory from Xen heap

2024-05-20 Thread Michal Orzel
On 20/05/2024 14:44, Luca Fancellu wrote: > > > Hi Michal, > >> On 20 May 2024, at 12:16, Michal Orzel wrote: >> >> Hi Luca, >> >> On 15/05/2024 16:26, Luca Fancellu wrote: >>> >>> >>> This commit implements the logic to have the static shared memory banks >>> from the Xen heap instead of ha

Re: [PATCH v2 0/3] Clean the policy manipulation path in domain creation

2024-05-20 Thread Roger Pau Monné
On Fri, May 17, 2024 at 05:08:33PM +0100, Alejandro Vallejo wrote: > v2: > * Removed xc_cpu_policy from xenguest.h > * Added accessors for xc_cpu_policy so the serialised form can be extracted. > * Modified xen-cpuid to use accessors. > > Original cover letter > > In the context o

Re: [PATCH v2 6/7] xen/arm: Implement the logic for static shared memory from Xen heap

2024-05-20 Thread Luca Fancellu
Hi Michal, > On 20 May 2024, at 12:16, Michal Orzel wrote: > > Hi Luca, > > On 15/05/2024 16:26, Luca Fancellu wrote: >> >> >> This commit implements the logic to have the static shared memory banks >> from the Xen heap instead of having the host physical address passed from >> the user. >>

Re: [PATCH v3 1/4] xen/arm/static-shmem: Static-shmem should be direct-mapped for direct-mapped domains

2024-05-20 Thread Luca Fancellu
> On 20 May 2024, at 12:24, Michal Orzel wrote: > > Hi Henry, > > +CC: Luca > > On 17/05/2024 05:21, Henry Wang wrote: >> >> >> Currently, users are allowed to map static shared memory in a >> non-direct-mapped way for direct-mapped domains. This can lead to >> clashing of guest memory spac

Re: [PATCH v2 06/12] VT-d: respect ACPI SATC's ATC_REQUIRED flag

2024-05-20 Thread Roger Pau Monné
On Wed, May 15, 2024 at 12:42:40PM +0200, Jan Beulich wrote: > On 06.05.2024 15:38, Roger Pau Monné wrote: > > On Thu, Feb 15, 2024 at 11:16:11AM +0100, Jan Beulich wrote: > >> When the flag is set, permit Dom0 to control the device (no worse than > >> what we had before and in line with other "bes

Re: [PATCH v3 1/4] xen/arm/static-shmem: Static-shmem should be direct-mapped for direct-mapped domains

2024-05-20 Thread Michal Orzel
Hi Henry, +CC: Luca On 17/05/2024 05:21, Henry Wang wrote: > > > Currently, users are allowed to map static shared memory in a > non-direct-mapped way for direct-mapped domains. This can lead to > clashing of guest memory spaces. Also, the current extended region > finding logic only removes th

Re: [PATCH v2 6/7] xen/arm: Implement the logic for static shared memory from Xen heap

2024-05-20 Thread Michal Orzel
Hi Luca, On 15/05/2024 16:26, Luca Fancellu wrote: > > > This commit implements the logic to have the static shared memory banks > from the Xen heap instead of having the host physical address passed from > the user. > > When the host physical address is not supplied, the physical memory is > t

Re: [PATCH v2 05/12] IOMMU: rename and re-type ats_enabled

2024-05-20 Thread Roger Pau Monné
On Wed, May 15, 2024 at 12:07:50PM +0200, Jan Beulich wrote: > On 06.05.2024 15:53, Roger Pau Monné wrote: > > On Mon, May 06, 2024 at 03:20:38PM +0200, Jan Beulich wrote: > >> On 06.05.2024 14:42, Roger Pau Monné wrote: > >>> On Thu, Feb 15, 2024 at 11:15:39AM +0100, Jan Beulich wrote: > Make

Re: [PATCH v2 5/8] xen/arm/gic: Allow routing/removing interrupt to running VMs

2024-05-20 Thread Julien Grall
Hi Henry, On 20/05/2024 02:01, Henry Wang wrote: Hi Julien, On 5/19/2024 7:08 PM, Julien Grall wrote: Hi, On 17/05/2024 07:03, Henry Wang wrote: @@ -444,14 +444,18 @@ int vgic_connect_hw_irq(struct domain *d, struct vcpu *v, unsigned int virq,   {   /* The VIRQ should not be alr

Re: [PATCH v2 5/7] xen/arm: Rework heap page allocation outside allocate_bank_memory

2024-05-20 Thread Michal Orzel
Hi Luca, On 15/05/2024 16:26, Luca Fancellu wrote: > > > The function allocate_bank_memory allocates pages from the heap and > maps them to the guest using guest_physmap_add_page. > > As a preparation work to support static shared memory bank when the > host physical address is not provided, Xe

Re: [XEN PATCH v3 5/6] x86/MCE: add default switch case in init_nonfatal_mce_checker()

2024-05-20 Thread Sergiy Kibrik
16.05.24 12:46, Jan Beulich: --- a/xen/arch/x86/cpu/mcheck/non-fatal.c +++ b/xen/arch/x86/cpu/mcheck/non-fatal.c @@ -29,9 +29,13 @@ static int __init cf_check init_nonfatal_mce_checker(void) /* Assume we are on K8 or newer AMD or Hygon CPU here */ amd_nonfatal_mche

Re: [PATCH v2 4/7] xen/arm: Parse xen,shared-mem when host phys address is not provided

2024-05-20 Thread Michal Orzel
Hi Luca, On 15/05/2024 16:26, Luca Fancellu wrote: > > > Handle the parsing of the 'xen,shared-mem' property when the host physical > address is not provided, this commit is introducing the logic to parse it, > but the functionality is still not implemented and will be part of future > commits.

Re: [XEN PATCH v3 2/6] x86/intel: move vmce_has_lmce() routine to header

2024-05-20 Thread Sergiy Kibrik
16.05.24 12:39, Jan Beulich: On 14.05.2024 10:20, Sergiy Kibrik wrote: Moving this function out of mce_intel.c would make it possible to disable build of Intel MCE code later on, because the function gets called from common x86 code. Why "would"? "Will" or "is going to" would seem more to the

[xen-unstable test] 186042: tolerable FAIL

2024-05-20 Thread osstest service owner
flight 186042 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/186042/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit1 8 xen-boot fail in 186037 pass in 186042 test-armhf-armhf-xl-arndale 8

Re: [PATCH for-4.19? v4 1/6] x86/p2m: Add braces for better code clarity

2024-05-20 Thread Roger Pau Monné
On Sat, May 18, 2024 at 11:02:12AM +, Petr Beneš wrote: > From: Petr Beneš > > No functional change. > > Signed-off-by: Petr Beneš > Reviewed-by: Stefano Stabellini TBH I'm fine without the braces, but if lack of them can cause confusion: Acked-by: Roger Pau Monné CODING_STYLE states t

Re: [PATCH for-4.19? v4 4/6] x86: Make the maximum number of altp2m views configurable

2024-05-20 Thread Roger Pau Monné
On Sat, May 18, 2024 at 11:02:15AM +, Petr Beneš wrote: > From: Petr Beneš > > This commit introduces the ability to configure the maximum number of altp2m > views for the domain during its creation. Previously, the limits were > hardcoded > to a maximum of 10. This change allows for greater

[PATCH] tools/golang: Add missing golang bindings for vlan

2024-05-20 Thread Henry Wang
It is noticed that commit: 3bc14e4fa4b9 ("tools/libs/light: Add vlan field to libxl_device_nic") introduces a new "vlan" string field to libxl_device_nic. But the golang bindings are missing. Add it in this patch. Fixes: 3bc14e4fa4b9 ("tools/libs/light: Add vlan field to libxl_device_nic") Signed-

Re: [PATCH for-4.19] x86/msi: prevent watchdog triggering when dumping MSI state

2024-05-20 Thread Oleksii K.
On Fri, 2024-05-17 at 15:56 +0200, Roger Pau Monne wrote: > Use the same check that's used in dump_irqs(). > > Signed-off-by: Roger Pau Monné > --- >  xen/arch/x86/msi.c | 4 >  1 file changed, 4 insertions(+) > > diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c > index 19830528b65a..0c9