Re: [PATCH v11 6/7] xen/arm: enable dom0 to use PCI devices with pci-passthrough=no

2025-06-03 Thread Jan Beulich
On 03.06.2025 15:31, Mykyta Poturai wrote: > On 02.06.25 11:11, Jan Beulich wrote: >> On 28.05.2025 11:12, Mykyta Poturai wrote: >>> From: Stewart Hildebrand >>> >>> Enable the use of IOMMU + PCI in dom0 without having to specify >>> "pci-passthrough=yes". Due to possible platform specific depende

[PATCH] x86/boot: Fix domain_cmdline_size()

2025-06-03 Thread Andrew Cooper
The early exit from domain_cmdline_size() is buggy. Even if there's no bootloader cmdline and no kextra, there still might be Xen parameters to forward, and therefore a nonzero cmdline. Explain what the function is doing, and rewrite it to be both more legible and more extendible. Fixes: 142f0a4

[PATCH v3] automation/eclair: update configuration of D4.10

2025-06-03 Thread Stefano Stabellini
MISRA C Directive 4.10 states that "Precautions shall be taken in order to prevent the contents of a header file being included more than once". Add a SAF tag to the existing comment on top of cpufeatures.h. Add a header inclusion guard to compile.h. Update ECLAIR configuration to: - extend exist

Re: [PATCH v4][PART 1 2/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests

2025-06-03 Thread Julien Grall
Hi Mykola, On 27/05/2025 10:18, Mykola Kvach wrote: From: Mykola Kvach This patch adds support for the PSCI SYSTEM_SUSPEND function in the vPSCI (virtual PSCI) interface, allowing guests to request suspend via the PSCI v1.0 SYSTEM_SUSPEND call (both 32-bit and 64-bit variants). The implementa

Re: [PATCH] xen/kernel: Move parse_params() back into __init

2025-06-03 Thread Julien Grall
Hi Andrew, On 03/06/2025 13:52, Andrew Cooper wrote: It's non-init caller was dropped in Xen 4.14 No functional change. Fixes: 02e9a9cf2095 ("xen: remove XEN_SYSCTL_set_parameter support") Signed-off-by: Andrew Cooper Acked-by: Julien Grall Cheers, --- CC: Anthony PERARD CC: Michal Orz

Re: [PATCH v4 1/5] xen/arm: Add way to disable traps on accesses to unmapped addresses

2025-06-03 Thread Julien Grall
Hi Edgar, On 03/06/2025 15:49, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Add a per-domain way to optionally disable traps for accesses to unmapped addresses. The domain flag is general but it's only implemented for Arm for now. Reviewed-by: Stefano Stabellini Signed-off-by: Edgar E

Re: [XEN PATCH 8/9] CI: Workaround extra content in junit

2025-06-03 Thread Stefano Stabellini
On Tue, 3 Jun 2025, Marek Marczykowski-Górecki wrote: > On Tue, Jun 03, 2025 at 11:29:11AM -0700, Stefano Stabellini wrote: > > On Tue, 3 Jun 2025, Anthony PERARD wrote: > > > On Tue, Jun 03, 2025 at 03:12:32PM +0100, Andrew Cooper wrote: > > > > On 03/06/2025 1:42 pm, Anthony PERARD wrote: > > > >

Re: [PATCH v3 1/2] xen/arm: exclude xen,reg from direct-map domU extended regions

2025-06-03 Thread Stewart Hildebrand
On 5/14/25 03:31, Orzel, Michal wrote: > On 13/05/2025 21:54, Stewart Hildebrand wrote: >> Similarly to fba1b0974dd8, when a device is passed through to a >> direct-map dom0less domU, the xen,reg ranges may overlap with the >> extended regions. Remove xen,reg from direct-map domU extended regions.

Re: [PATCH 2/2] x86/vpci: refuse to map BARs at position 0

2025-06-03 Thread Stewart Hildebrand
On 5/22/25 12:24, Roger Pau Monné wrote: > On Thu, May 22, 2025 at 11:44:24AM -0400, Stewart Hildebrand wrote: >> On 5/22/25 10:59, Jan Beulich wrote: >>> On 22.05.2025 16:03, Roger Pau Monne wrote: diff --git a/xen/arch/x86/pci.c b/xen/arch/x86/pci.c index 26bb7f6a3c3a..39fd5a16a4aa 1006

Re: [PATCH v2 2/3] Add lockdown mode

2025-06-03 Thread Ross Lagerwall
On Tue, Jun 3, 2025 at 5:29 PM Andrew Cooper wrote: > > On 02/06/2025 2:46 pm, Kevin Lampis wrote: > > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > > index 1f5cb67bd0..efeed5eafc 100644 > > --- a/xen/arch/x86/setup.c > > +++ b/xen/arch/x86/setup.c > > @@ -15,6 +15,7 @@ > > #include

Re: [PATCH v3 08/22] x86/slaunch: restore boot MTRRs after Intel TXT DRTM

2025-06-03 Thread ross . philipson
On 5/30/25 6:17 AM, Sergii Dmytruk wrote: From: Krystian Hebel In preparation for TXT SENTER call, GRUB had to modify MTRR settings to be UC for everything except SINIT ACM. Old values are restored from SLRT where they were saved by the bootloader. Signed-off-by: Krystian Hebel Signed-off-by:

Re: [XEN PATCH 1/9] CI: Add SELECTED_JOBS_ONLY to analyze.yaml

2025-06-03 Thread Stefano Stabellini
On Tue, 3 Jun 2025, Andrew Cooper wrote: > On 03/06/2025 1:42 pm, Anthony PERARD wrote: > > From: Anthony PERARD > > > > Signed-off-by: Anthony PERARD > > Acked-by: Andrew Cooper Acked-by: Stefano Stabellini

Re: [XEN PATCH 8/9] CI: Workaround extra content in junit

2025-06-03 Thread Marek Marczykowski-Górecki
On Tue, Jun 03, 2025 at 11:29:11AM -0700, Stefano Stabellini wrote: > On Tue, 3 Jun 2025, Anthony PERARD wrote: > > On Tue, Jun 03, 2025 at 03:12:32PM +0100, Andrew Cooper wrote: > > > On 03/06/2025 1:42 pm, Anthony PERARD wrote: > > > > if [ -n "$retrieve_xml" ]; then > > > > nc -w 10 "$SUT_

Re: [XEN PATCH 9/9] CI: Add timing to junit

2025-06-03 Thread Stefano Stabellini
On Tue, 3 Jun 2025, Anthony PERARD wrote: > From: Anthony PERARD > > Signed-off-by: Anthony PERARD > --- > automation/scripts/run-tools-tests | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/automation/scripts/run-tools-tests > b/automation/scripts/run-tools-tests

Re: [XEN PATCH 8/9] CI: Workaround extra content in junit

2025-06-03 Thread Stefano Stabellini
On Tue, 3 Jun 2025, Anthony PERARD wrote: > On Tue, Jun 03, 2025 at 03:12:32PM +0100, Andrew Cooper wrote: > > On 03/06/2025 1:42 pm, Anthony PERARD wrote: > > > if [ -n "$retrieve_xml" ]; then > > > nc -w 10 "$SUT_ADDR" 8080 > tests-junit.xml > > +# Workaround duplicated data been recei

Re: [XEN PATCH 7/9] CI: Use CDATA avoid the need to escape tests outputs

2025-06-03 Thread Stefano Stabellini
On Tue, 3 Jun 2025, Andrew Cooper wrote: > On 03/06/2025 1:42 pm, Anthony PERARD wrote: > > diff --git a/automation/scripts/run-tools-tests > > b/automation/scripts/run-tools-tests > > index 695ed77e46..852c1cfbcf 100755 > > --- a/automation/scripts/run-tools-tests > > +++ b/automation/scripts/run

Re: [XEN PATCH 3/9] CI: Fix status check for tools/tests

2025-06-03 Thread Stefano Stabellini
On Tue, 3 Jun 2025, Andrew Cooper wrote: > On 03/06/2025 1:42 pm, Anthony PERARD wrote: > > From: Anthony PERARD > > > > Without "pipefail", $? have the exit value of `tee`, which should > > always be 0. But instead of using "pipefail", do collect the value of > > from the test with $PIPESTATUS. >

Re: [PATCH v2 6/6] tools/arm: exclude iomem from domU extended regions

2025-06-03 Thread Stefano Stabellini
On Tue, 3 Jun 2025, Orzel, Michal wrote: > On 03/06/2025 02:38, Stefano Stabellini wrote: > > I plan to commit this patch, unless someone objects > AFAICT there is a new revision (v3) that has pending comments: > https://lore.kernel.org/xen-devel/20250513195452.699600-1-stewart.hildebr...@amd.com/

Re: [XEN PATCH 5/9] CI: Have the gitlab job fail on tools/tests failure

2025-06-03 Thread Andrew Cooper
On 03/06/2025 4:58 pm, Anthony PERARD wrote: > On Tue, Jun 03, 2025 at 02:41:50PM +0100, Andrew Cooper wrote: >> On 03/06/2025 1:42 pm, Anthony PERARD wrote: >>> if [ -n "$retrieve_xml" ]; then >>> nc -w 10 "$SUT_ADDR" 8080 > tests-junit.xml >> +# Findout if one of the test failed >>> +

[ANNOUNCE] Call for agenda items for June 5, 2025 Xen Community Call @ 15:00 UTC

2025-06-03 Thread Cody Zuschlag
Hi everyone, We’re getting ready for June's Xen Project Community Call on *Thursday, 5 June 2025* at *15:00 UTC* (4 pm UK time). We’d love for you to join. Feel free to just observe or jump in! This call is a great opportunity to see what the community is working on, align our various efforts, and

Re: [PATCH v3 05/22] x86/boot/slaunch-early: early TXT checks and boot data retrieval

2025-06-03 Thread ross . philipson
On 5/30/25 6:17 AM, Sergii Dmytruk wrote: From: Krystian Hebel The tests validate that important parts of memory are protected against DMA attacks, including Xen and MBI. Modules can be tested later, when it is possible to report issues to a user before invoking TXT reset. TPM event log valida

Re: [PATCH v2 2/3] Add lockdown mode

2025-06-03 Thread Andrew Cooper
On 02/06/2025 2:46 pm, Kevin Lampis wrote: > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index 1f5cb67bd0..efeed5eafc 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include >

Re: [XEN PATCH 8/9] CI: Workaround extra content in junit

2025-06-03 Thread Anthony PERARD
On Tue, Jun 03, 2025 at 03:12:32PM +0100, Andrew Cooper wrote: > On 03/06/2025 1:42 pm, Anthony PERARD wrote: > > if [ -n "$retrieve_xml" ]; then > > nc -w 10 "$SUT_ADDR" 8080 > tests-junit.xml > +# Workaround duplicated data been received > > +sed -i.old '/^<\/testsuites>/q' tests-j

Re: [PATCH v3 04/22] x86/boot/slaunch-early: implement early initialization

2025-06-03 Thread ross . philipson
On 5/30/25 6:17 AM, Sergii Dmytruk wrote: Make head.S invoke a C function to retrieve MBI and SLRT addresses in a platform-specific way. This is also the place to perform sanity checks of DRTM. Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk --- xen/arch/x86/Makefile

Re: [PATCH v3 2/2] docs: fusa: Add the requirements for few commands of XEN_VERSION

2025-06-03 Thread Ayan Kumar Halder
On 21/05/2025 13:10, Bertrand Marquis wrote: Hi Ayan, Hi Bertrand, On 9 May 2025, at 13:24, Ayan Kumar Halder wrote: Define requirements for specific commands. Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - 1. Reworded the requirement so as to avoid mentioining variable names

Re: [XEN PATCH 6/9] CI: Upload junit result as artefact

2025-06-03 Thread Anthony PERARD
On Tue, Jun 03, 2025 at 02:13:59PM +0100, Andrew Cooper wrote: > On 03/06/2025 1:42 pm, Anthony PERARD wrote: > > From: Anthony PERARD > > > > This allow to investigate the file in cases of error. Not all > > jobs that extend ".adl-x86-64" are creating a "tests-junit.xml" but > > Gitlab only produ

Re: [XEN PATCH 5/9] CI: Have the gitlab job fail on tools/tests failure

2025-06-03 Thread Anthony PERARD
On Tue, Jun 03, 2025 at 02:41:50PM +0100, Andrew Cooper wrote: > On 03/06/2025 1:42 pm, Anthony PERARD wrote: > > if [ -n "$retrieve_xml" ]; then > > nc -w 10 "$SUT_ADDR" 8080 > tests-junit.xml > +# Findout if one of the test failed > > +if ! grep -q '' tests-junit.xml; then > > +

Re: [PATCH v2 01/22] x86/include/asm/intel-txt.h: constants and accessors for TXT registers and heap

2025-06-03 Thread Sergii Dmytruk
On Tue, Jun 03, 2025 at 10:52:09AM +0200, Jan Beulich wrote: > On 03.06.2025 10:50, Sergii Dmytruk wrote: > > On Tue, Jun 03, 2025 at 09:06:53AM +0200, Jan Beulich wrote: > >> On 03.06.2025 00:00, Sergii Dmytruk wrote: > >>> On Mon, Jun 02, 2025 at 09:17:37AM +0200, Jan Beulich wrote: > On 23.

Re: [PATCH 3/4] device-tree: Move Arm's static-memory feature to common

2025-06-03 Thread Orzel, Michal
On 03/06/2025 15:28, Julien Grall wrote: > Hi Michal, > > On 03/06/2025 11:03, Michal Orzel wrote: >> This feature is arch agnostic, thus move it to common. >> >> Signed-off-by: Michal Orzel > > With one remark below: > > Acked-by: Julien Grall > > [...] > >> diff --git a/xen/arch/arm/inc

[PATCH v4 5/5] tools/golang: Regenerate bindings for trap_unmapped_accesses

2025-06-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- tools/golang/xenlight/helpers.gen.go | 6 ++ tools/golang/xenlight/types.gen.go | 1 + 2 files changed, 7 insertions(+) diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index 90846ea8e

[PATCH v4 1/5] xen/arm: Add way to disable traps on accesses to unmapped addresses

2025-06-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a per-domain way to optionally disable traps for accesses to unmapped addresses. The domain flag is general but it's only implemented for Arm for now. Reviewed-by: Stefano Stabellini Signed-off-by: Edgar E. Iglesias --- tools/libs/light/libxl_arm.c | 3 +++ xe

[PATCH v4 3/5] tools/arm: Add the trap_unmapped_accesses xl config option

2025-06-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Reviewed-by: Stefano Stabellini Signed-off-by: Edgar E. Iglesias --- docs/man/xl.cfg.5.pod.in | 9 + tools/include/libxl.h| 7 +++ tools/libs/light/libxl_arm.c | 6 +++--- tools/libs/light/libxl_create.c | 3 +++ tools/libs/light/l

[PATCH v4 4/5] tools/ocaml: Update bindings for CDF_TRAP_UNMAPPED_ACCESSES

2025-06-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Acked-by: Christian Lindig Signed-off-by: Edgar E. Iglesias --- tools/ocaml/libs/xc/xenctrl.ml | 1 + tools/ocaml/libs/xc/xenctrl.mli | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 2690f9a92

[PATCH v4 2/5] xen/arm: dom0less: Add trap-unmapped-accesses

2025-06-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add the trap-unmapped-accesses per-domain fdt property. Reviewed-by: Stefano Stabellini Signed-off-by: Edgar E. Iglesias --- docs/misc/arm/device-tree/booting.txt | 10 ++ xen/arch/arm/dom0less-build.c | 9 - 2 files changed, 18 insertions(+)

[PATCH v4 0/5] xen/arm: Add option to optionally disable trapping on unmapped acceses

2025-06-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This follows up on the virtio-pci discussion and adds a per-domain option to select the behaviour of accesses to unmapped address ranges. The new option is trap_unmapped_accesses, it's general but for now only implemented for ARM. I'm happy with any name, so if you have

Re: [XEN PATCH 5/9] CI: Have the gitlab job fail on tools/tests failure

2025-06-03 Thread Andrew Cooper
On 03/06/2025 3:09 pm, Andrew Cooper wrote: > On 03/06/2025 2:44 pm, Marek Marczykowski-Górecki wrote: >> On Tue, Jun 03, 2025 at 02:41:50PM +0100, Andrew Cooper wrote: >>> On 03/06/2025 1:42 pm, Anthony PERARD wrote: From: Anthony PERARD We can't rely on an exit value from `run-too

Re: [XEN PATCH 9/9] CI: Add timing to junit

2025-06-03 Thread Andrew Cooper
On 03/06/2025 1:42 pm, Anthony PERARD wrote: > From: Anthony PERARD > > Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper > --- > automation/scripts/run-tools-tests | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/automation/scripts/run-tools-tests > b/automat

Re: [XEN PATCH 8/9] CI: Workaround extra content in junit

2025-06-03 Thread Andrew Cooper
On 03/06/2025 1:42 pm, Anthony PERARD wrote: > From: Anthony PERARD > > Signed-off-by: Anthony PERARD > --- > automation/scripts/qubes-x86-64.sh | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/automation/scripts/qubes-x86-64.sh > b/automation/scripts/qubes-x86-64.sh > index 7a4c5

Re: [XEN PATCH 5/9] CI: Have the gitlab job fail on tools/tests failure

2025-06-03 Thread Andrew Cooper
On 03/06/2025 2:44 pm, Marek Marczykowski-Górecki wrote: > On Tue, Jun 03, 2025 at 02:41:50PM +0100, Andrew Cooper wrote: >> On 03/06/2025 1:42 pm, Anthony PERARD wrote: >>> From: Anthony PERARD >>> >>> We can't rely on an exit value from `run-tools-tests` since we only >>> have the console output

Re: [XEN PATCH 5/9] CI: Have the gitlab job fail on tools/tests failure

2025-06-03 Thread Marek Marczykowski-Górecki
On Tue, Jun 03, 2025 at 02:41:50PM +0100, Andrew Cooper wrote: > On 03/06/2025 1:42 pm, Anthony PERARD wrote: > > From: Anthony PERARD > > > > We can't rely on an exit value from `run-tools-tests` since we only > > have the console output. `console.exp` only look for success or it > > times out. W

Re: [XEN PATCH 5/9] CI: Have the gitlab job fail on tools/tests failure

2025-06-03 Thread Andrew Cooper
On 03/06/2025 1:42 pm, Anthony PERARD wrote: > From: Anthony PERARD > > We can't rely on an exit value from `run-tools-tests` since we only > have the console output. `console.exp` only look for success or it > times out. We could parse the console output, but the junit is more > concise. Also che

Re: [XEN PATCH 4/9] CI: Ignore run-tools-test return value

2025-06-03 Thread Marek Marczykowski-Górecki
On Tue, Jun 03, 2025 at 02:26:31PM +0100, Andrew Cooper wrote: > On 03/06/2025 1:42 pm, Anthony PERARD wrote: > > diff --git a/automation/scripts/qubes-x86-64.sh > > b/automation/scripts/qubes-x86-64.sh > > index 2750d24eba..046137a4a6 100755 > > --- a/automation/scripts/qubes-x86-64.sh > > +++ b/

Re: [PATCH v11 6/7] xen/arm: enable dom0 to use PCI devices with pci-passthrough=no

2025-06-03 Thread Mykyta Poturai
On 02.06.25 11:11, Jan Beulich wrote: > On 28.05.2025 11:12, Mykyta Poturai wrote: >> From: Stewart Hildebrand >> >> Enable the use of IOMMU + PCI in dom0 without having to specify >> "pci-passthrough=yes". Due to possible platform specific dependencies >> of the PCI host, we rely on dom0 to initi

Re: [PATCH 4/4] device-tree: Move Arm's static-shmem feature to common

2025-06-03 Thread Julien Grall
Hi Michal, On 03/06/2025 11:03, Michal Orzel wrote: This feature is arch agnostic, thus move it to common. Signed-off-by: Michal Orzel Acked-by: Julien Grall Cheers, -- Julien Grall

Re: [PATCH 3/4] device-tree: Move Arm's static-memory feature to common

2025-06-03 Thread Julien Grall
Hi Michal, On 03/06/2025 11:03, Michal Orzel wrote: This feature is arch agnostic, thus move it to common. Signed-off-by: Michal Orzel With one remark below: Acked-by: Julien Grall [...] diff --git a/xen/arch/arm/include/asm/static-memory.h b/xen/include/xen/static-memory.h similarity

Re: [XEN PATCH 4/9] CI: Ignore run-tools-test return value

2025-06-03 Thread Andrew Cooper
On 03/06/2025 1:42 pm, Anthony PERARD wrote: > diff --git a/automation/scripts/qubes-x86-64.sh > b/automation/scripts/qubes-x86-64.sh > index 2750d24eba..046137a4a6 100755 > --- a/automation/scripts/qubes-x86-64.sh > +++ b/automation/scripts/qubes-x86-64.sh > @@ -135,10 +135,11 @@ done > ###

Re: [PATCH 2/4] device-tree: Move domain_fdt_begin_node() to common

2025-06-03 Thread Julien Grall
Hi Michal, On 03/06/2025 11:03, Michal Orzel wrote: This is just a wrapper around fdt_begin_node(). Move it to common and remove asm/domain_build.h inclusion from static-shmem.c. Signed-off-by: Michal Orzel Acked-by: Julien Grall Cheers, -- Julien Grall

Re: [XEN PATCH 1/9] CI: Add SELECTED_JOBS_ONLY to analyze.yaml

2025-06-03 Thread Andrew Cooper
On 03/06/2025 1:42 pm, Anthony PERARD wrote: > From: Anthony PERARD > > Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper

Re: [XEN PATCH 6/9] CI: Upload junit result as artefact

2025-06-03 Thread Andrew Cooper
On 03/06/2025 1:42 pm, Anthony PERARD wrote: > From: Anthony PERARD > > This allow to investigate the file in cases of error. Not all > jobs that extend ".adl-x86-64" are creating a "tests-junit.xml" but > Gitlab only produce a warning when the file isn't found. I'm not sure what you're trying to

Re: [XEN PATCH 3/9] CI: Fix status check for tools/tests

2025-06-03 Thread Andrew Cooper
On 03/06/2025 1:42 pm, Anthony PERARD wrote: > From: Anthony PERARD > > Without "pipefail", $? have the exit value of `tee`, which should > always be 0. But instead of using "pipefail", do collect the value of > from the test with $PIPESTATUS. > > Signed-off-by: Anthony PERARD Reviewed-by: Andre

Re: [PATCH v2 3/3] Disallow most command-line options when lockdown mode is enabled

2025-06-03 Thread Marek Marczykowski-Górecki
On Mon, Jun 02, 2025 at 04:22:06PM +0200, Jan Beulich wrote: > On 02.06.2025 16:16, Marek Marczykowski-Górecki wrote: > > On Mon, Jun 02, 2025 at 02:46:56PM +0100, Kevin Lampis wrote: > >> --- a/xen/common/lockdown.c > >> +++ b/xen/common/lockdown.c > >> @@ -35,7 +35,7 @@ static int __init parse_lo

Re: [XEN PATCH 2/9] tools/tests: Fix return value of test-rangeset

2025-06-03 Thread Andrew Cooper
On 03/06/2025 1:42 pm, Anthony PERARD wrote: > From: Anthony PERARD > > Otherwise, failed tests are ignored by automated test. Fixes 7bf777b42cad > Signed-off-by: Anthony PERARD Reviewed-by: Andrew Cooper

Re: [XEN PATCH 7/9] CI: Use CDATA avoid the need to escape tests outputs

2025-06-03 Thread Andrew Cooper
On 03/06/2025 1:42 pm, Anthony PERARD wrote: > diff --git a/automation/scripts/run-tools-tests > b/automation/scripts/run-tools-tests > index 695ed77e46..852c1cfbcf 100755 > --- a/automation/scripts/run-tools-tests > +++ b/automation/scripts/run-tools-tests > @@ -25,9 +25,9 @@ for f in "$1"/*; do

Re: [PATCH v3 2/5] xen/arm: dom0less: Add trap-unmapped-accesses

2025-06-03 Thread Edgar E. Iglesias
On Mon, Jun 02, 2025 at 03:57:28PM -0700, Stefano Stabellini wrote: > On Mon, 2 Jun 2025, Julien Grall wrote: > > Hi, > > > > On 02/06/2025 23:36, Stefano Stabellini wrote: > > > On Fri, 30 May 2025, Edgar E. Iglesias wrote: > > > > From: "Edgar E. Iglesias" > > > > > > > > Add the trap-unmapped

[PATCH] xen/kernel: Move parse_params() back into __init

2025-06-03 Thread Andrew Cooper
It's non-init caller was dropped in Xen 4.14 No functional change. Fixes: 02e9a9cf2095 ("xen: remove XEN_SYSCTL_set_parameter support") Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Michal Orzel CC: Jan Beulich CC: Julien Grall CC: Roger Pau Monné CC: Stefano Stabellini Found wh

Re: [PATCH v3 3/5] tools/arm: Add the trap_unmapped_accesses xl config option

2025-06-03 Thread Edgar E. Iglesias
On Tue, Jun 03, 2025 at 10:34:53AM +0100, Julien Grall wrote: > Hi Edgar, > > On 30/05/2025 14:45, Edgar E. Iglesias wrote: > > @@ -1714,6 +1711,9 @@ int > > libxl__arch_domain_build_info_setdefault(libxl__gc *gc, > > /* ACPI is disabled by default */ > > libxl_defbool_setdefault(&b_i

Re: [PATCH v3 1/5] xen/arm: Add way to disable traps on accesses to unmapped addresses

2025-06-03 Thread Edgar E. Iglesias
On Tue, Jun 03, 2025 at 10:36:40AM +0100, Julien Grall wrote: > Hi Edgar, Hi Julien, > > On 30/05/2025 14:45, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Add a per-domain way to optionally disable traps for accesses > > to unmapped addresses. > > > > The domain flag is gene

Re: [PATCH 2/2] CI: Adjust how domU is packaged in dom0

2025-06-03 Thread Marek Marczykowski-Górecki
On Mon, Jun 02, 2025 at 06:46:18PM +0100, Andrew Cooper wrote: > Package domU for dom0 and insert into the uncompressed part of dom0's rootfs, > rather than recompressing it as part of the overlay. > > For Qubes, this avoids putting the domU kernel in dom0's rootfs for tests > which aren't going t

[XEN PATCH 1/9] CI: Add SELECTED_JOBS_ONLY to analyze.yaml

2025-06-03 Thread Anthony PERARD
From: Anthony PERARD Signed-off-by: Anthony PERARD --- automation/gitlab-ci/analyze.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/automation/gitlab-ci/analyze.yaml b/automation/gitlab-ci/analyze.yaml index 35ff3620cf..5b00b9f25c 100644 --- a/automation/gitlab-ci/analyze.yaml +++

[XEN PATCH 3/9] CI: Fix status check for tools/tests

2025-06-03 Thread Anthony PERARD
From: Anthony PERARD Without "pipefail", $? have the exit value of `tee`, which should always be 0. But instead of using "pipefail", do collect the value of from the test with $PIPESTATUS. Signed-off-by: Anthony PERARD --- Notes: Without the next patch "CI: Ignore run-tools-test return val

[XEN PATCH 9/9] CI: Add timing to junit

2025-06-03 Thread Anthony PERARD
From: Anthony PERARD Signed-off-by: Anthony PERARD --- automation/scripts/run-tools-tests | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/automation/scripts/run-tools-tests b/automation/scripts/run-tools-tests index 852c1cfbcf..e38cc4068c 100755 --- a/automation/scripts

[XEN PATCH 5/9] CI: Have the gitlab job fail on tools/tests failure

2025-06-03 Thread Anthony PERARD
From: Anthony PERARD We can't rely on an exit value from `run-tools-tests` since we only have the console output. `console.exp` only look for success or it times out. We could parse the console output, but the junit is more concise. Also check if we have it or fail as well. Signed-off-by: Anthon

[XEN PATCH 7/9] CI: Use CDATA avoid the need to escape tests outputs

2025-06-03 Thread Anthony PERARD
From: Anthony PERARD This is easier than escaping individual characters, especially '&' and '<' which are problematic if present. We might still need to escape ']]>' if this string is present in the test output, but hopefully not. Signed-off-by: Anthony PERARD --- automation/scripts/run-tools

[XEN PATCH 8/9] CI: Workaround extra content in junit

2025-06-03 Thread Anthony PERARD
From: Anthony PERARD Signed-off-by: Anthony PERARD --- automation/scripts/qubes-x86-64.sh | 6 ++ 1 file changed, 6 insertions(+) diff --git a/automation/scripts/qubes-x86-64.sh b/automation/scripts/qubes-x86-64.sh index 7a4c5ae489..6ab8412f45 100755 --- a/automation/scripts/qubes-x86-64.

[XEN PATCH 6/9] CI: Upload junit result as artefact

2025-06-03 Thread Anthony PERARD
From: Anthony PERARD This allow to investigate the file in cases of error. Not all jobs that extend ".adl-x86-64" are creating a "tests-junit.xml" but Gitlab only produce a warning when the file isn't found. Signed-off-by: Anthony PERARD --- automation/gitlab-ci/test.yaml | 1 + 1 file changed

[XEN PATCH 4/9] CI: Ignore run-tools-test return value

2025-06-03 Thread Anthony PERARD
From: Anthony PERARD The main script expect to find the string "$passed" or it just timeout. Then, it doesn't try to download the junit file. So ignore the return value of run-tools-test for now. This mean the job will not fail, but at least we should have the junit files with the error messages

[XEN PATCH 0/9] CI: Fixes for tools/tests and junit and other

2025-06-03 Thread Anthony PERARD
From: Anthony PERARD Patch series available in this git branch: https://xenbits.xenproject.org/git-http/people/aperard/xen-unstable.git br.ci-tools-tests-junit-fixes-v1 All the *-tools-tests-* are currently only checking automatically if the machine as booted. The only way to find out if one of

[XEN PATCH 2/9] tools/tests: Fix return value of test-rangeset

2025-06-03 Thread Anthony PERARD
From: Anthony PERARD Otherwise, failed tests are ignored by automated test. Signed-off-by: Anthony PERARD --- tools/tests/rangeset/test-rangeset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/tests/rangeset/test-rangeset.c b/tools/tests/rangeset/test-rangeset.c in

[PATCH 2/4] device-tree: Move domain_fdt_begin_node() to common

2025-06-03 Thread Michal Orzel
This is just a wrapper around fdt_begin_node(). Move it to common and remove asm/domain_build.h inclusion from static-shmem.c. Signed-off-by: Michal Orzel --- xen/arch/arm/domain_build.c | 32 - xen/arch/arm/include/asm/domain_build.h | 1 - xen/arch/arm/stat

Re: [PATCH v4][PART 2 07/10] xen/arm: Add support for system suspend triggered by hardware domain

2025-06-03 Thread Mykola Kvach
Hi, @Jan Beulich On Mon, Jun 2, 2025 at 12:26 PM Jan Beulich wrote: > > On 02.06.2025 11:04, Mykola Kvach wrote: > > @@ -857,8 +860,24 @@ void arch_domain_destroy(struct domain *d) > > domain_io_free(d); > > } > > > > -void arch_domain_shutdown(struct domain *d) > > +int arch_domain_shutdow

Re: [PATCH 1/2] CI: Use bash arrays to simplfy dom0 rootfs construction

2025-06-03 Thread Marek Marczykowski-Górecki
On Mon, Jun 02, 2025 at 06:46:17PM +0100, Andrew Cooper wrote: > For Qubes, this requires switching from sh to bash. > > This reduces the number of times the target filename needs to be written to 1. > > Expand the comment to explain the concatination constraints. > > No functional change. > >

Re: [PATCH v2 1/3] efi: Add a function to check if Secure Boot mode is enabled

2025-06-03 Thread Andrew Cooper
On 02/06/2025 2:46 pm, Kevin Lampis wrote: > From: Ross Lagerwall > > Also cache it to avoid needing to repeatedly ask the firmware. > > Signed-off-by: Ross Lagerwall > Signed-off-by: Kevin Lampis You must CC the maintainers on patches.  If in doubt, use ./scripts/get_maintainer.pl. > diff --g

Re: [PATCH v3 1/5] xen/arm: Add way to disable traps on accesses to unmapped addresses

2025-06-03 Thread Julien Grall
Hi Edgar, On 30/05/2025 14:45, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Add a per-domain way to optionally disable traps for accesses to unmapped addresses. The domain flag is general but it's only implemented for ARM for now. Signed-off-by: Edgar E. Iglesias --- tools/libs/ligh

Re: [PATCH v3 3/5] tools/arm: Add the trap_unmapped_accesses xl config option

2025-06-03 Thread Julien Grall
Hi Edgar, On 30/05/2025 14:45, Edgar E. Iglesias wrote: @@ -1714,6 +1711,9 @@ int libxl__arch_domain_build_info_setdefault(libxl__gc *gc, /* ACPI is disabled by default */ libxl_defbool_setdefault(&b_info->acpi, false); +/* Trapping of unmapped accesses enabled by default. *

Re: [PATCH] tests/vpci: Use $(CC) instead of $(HOSTCC)

2025-06-03 Thread Orzel, Michal
On 03/06/2025 12:30, Roger Pau Monné wrote: > On Tue, Jun 03, 2025 at 08:52:38AM +0200, Orzel, Michal wrote: >> >> >> On 03/06/2025 08:46, Roger Pau Monné wrote: >>> On Mon, Jun 02, 2025 at 05:09:29PM +0200, Michal Orzel wrote: These tests are supposed to run on target. HOSTCC can be differ

[PATCH v2] x86/hvmloader: select xenpci MMIO BAR UC or WB MTRR cache attribute

2025-06-03 Thread Roger Pau Monne
The Xen PCI device (vendor ID 0x5853) exposed to x86 HVM guests doesn't have the functionality of a traditional PCI device. The exposed MIO BAR is used by some guests (including Linux) as a safe place to map foreign memory, including the grant table itself. Traditionally BARs from devices have th

Re: [PATCH 1/4] common: Drop unneeded Arm dependency for static-evtchn

2025-06-03 Thread Jan Beulich
On 03.06.2025 12:03, Michal Orzel wrote: > DOM0LESS_BOOT is sufficient (only Arm selects it today). If needed, > proper arch dependency can be introduced while adding support for it for > another architecture. > > Suggested-by: Jan Beulich > Signed-off-by: Michal Orzel Acked-by: Jan Beulich

Re: [PATCH] Revert tools/python part of "tools: remove support for running a guest with qemu-traditional"

2025-06-03 Thread Marek Marczykowski-Górecki
On Mon, Jun 02, 2025 at 12:31:59PM +0100, Andrew Cooper wrote: > On 02/06/2025 12:27 pm, Marek Marczykowski-Górecki wrote: > > On Mon, Jun 02, 2025 at 12:22:53PM +0100, Andrew Cooper wrote: > >> The migration stream is a stable ABI. What this does is break the ability > >> to > >> inspection and

[PATCH 4/4] device-tree: Move Arm's static-shmem feature to common

2025-06-03 Thread Michal Orzel
This feature is arch agnostic, thus move it to common. Signed-off-by: Michal Orzel --- xen/arch/arm/Kconfig | 6 -- xen/arch/arm/Makefile| 1 - xen/arch/arm/arm32/mmu/mm.c | 2 +- xen/arch/ar

Re: [PATCH] tests/vpci: Use $(CC) instead of $(HOSTCC)

2025-06-03 Thread Roger Pau Monné
On Tue, Jun 03, 2025 at 08:52:38AM +0200, Orzel, Michal wrote: > > > On 03/06/2025 08:46, Roger Pau Monné wrote: > > On Mon, Jun 02, 2025 at 05:09:29PM +0200, Michal Orzel wrote: > >> These tests are supposed to run on target. HOSTCC can be different than > >> CC (when cross-compiling). At the mo

[PATCH 1/4] common: Drop unneeded Arm dependency for static-evtchn

2025-06-03 Thread Michal Orzel
DOM0LESS_BOOT is sufficient (only Arm selects it today). If needed, proper arch dependency can be introduced while adding support for it for another architecture. Suggested-by: Jan Beulich Signed-off-by: Michal Orzel --- xen/common/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v3 1/2] docs: fusa: Define the requirements for XEN_VERSION hypercall.

2025-06-03 Thread Ayan Kumar Halder
On 21/05/2025 13:02, Bertrand Marquis wrote: Hi Ayan, Hi Bertrand, On 9 May 2025, at 13:24, Ayan Kumar Halder wrote: Define the requirements which are common for all the commands for XEN_VERSION hypercall. Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - 1. Fixed `XenProd~ver

[PATCH 3/4] device-tree: Move Arm's static-memory feature to common

2025-06-03 Thread Michal Orzel
This feature is arch agnostic, thus move it to common. Signed-off-by: Michal Orzel --- xen/arch/arm/Makefile| 1 - xen/arch/arm/arm32/mmu/mm.c | 2 +- xen/arch/arm/arm64/mmu/mm.c | 2 +- xen/arch/arm/do

[PATCH 0/4] device-tree: Move static features to common

2025-06-03 Thread Michal Orzel
Finish the work to move static features that are arch agnostic to common. Michal Orzel (4): common: Drop unneeded Arm dependency for static-evtchn device-tree: Move domain_fdt_begin_node() to common device-tree: Move Arm's static-memory feature to common device-tree: Move Arm's static-shme

Re: [PATCH] device-tree: Move Arm's static-evtchn feature to common

2025-06-03 Thread Jan Beulich
On 03.06.2025 09:06, Orzel, Michal wrote: > > > On 03/06/2025 09:02, Jan Beulich wrote: >> On 03.06.2025 08:54, Orzel, Michal wrote: >>> >>> >>> On 02/06/2025 10:37, Jan Beulich wrote: On 27.05.2025 10:21, Michal Orzel wrote: > There's nothing Arm specific about this feature. Move it to

Re: [PATCH] tests/vpci: Use $(CC) instead of $(HOSTCC)

2025-06-03 Thread Roger Pau Monné
On Mon, Jun 02, 2025 at 05:09:29PM +0200, Michal Orzel wrote: > These tests are supposed to run on target. HOSTCC can be different than > CC (when cross-compiling). At the moment, tests installation would put > a binary of a wrong format in the destdir. > > Fixes: e90580f25bd7 ("vpci: introduce ba

Re: [PATCH v2 01/22] x86/include/asm/intel-txt.h: constants and accessors for TXT registers and heap

2025-06-03 Thread Jan Beulich
On 03.06.2025 10:50, Sergii Dmytruk wrote: > On Tue, Jun 03, 2025 at 09:06:53AM +0200, Jan Beulich wrote: >> On 03.06.2025 00:00, Sergii Dmytruk wrote: >>> On Mon, Jun 02, 2025 at 09:17:37AM +0200, Jan Beulich wrote: On 23.05.2025 21:51, Sergii Dmytruk wrote: > On Wed, May 21, 2025 at 05:1

Re: [PATCH v2 01/22] x86/include/asm/intel-txt.h: constants and accessors for TXT registers and heap

2025-06-03 Thread Sergii Dmytruk
On Tue, Jun 03, 2025 at 09:06:53AM +0200, Jan Beulich wrote: > On 03.06.2025 00:00, Sergii Dmytruk wrote: > > On Mon, Jun 02, 2025 at 09:17:37AM +0200, Jan Beulich wrote: > >> On 23.05.2025 21:51, Sergii Dmytruk wrote: > >>> On Wed, May 21, 2025 at 05:19:57PM +0200, Jan Beulich wrote: > > +stat

Re: [PATCH] device-tree: Move Arm's static-evtchn feature to common

2025-06-03 Thread Orzel, Michal
On 03/06/2025 09:09, Jan Beulich wrote: > On 03.06.2025 09:06, Orzel, Michal wrote: >> >> >> On 03/06/2025 09:02, Jan Beulich wrote: >>> On 03.06.2025 08:54, Orzel, Michal wrote: On 02/06/2025 10:37, Jan Beulich wrote: > On 27.05.2025 10:21, Michal Orzel wrote: >> There's

Re: [PATCH] compat: add header guard to xlat.h

2025-06-03 Thread Andrew Cooper
On 03/06/2025 7:44 am, Jan Beulich wrote: > This is to conform with Misra C:2012 Directive 4.10. > > Reported-by: Stefano Stabellini > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper

Re: [PATCH] device-tree: Move Arm's static-evtchn feature to common

2025-06-03 Thread Jan Beulich
On 03.06.2025 08:54, Orzel, Michal wrote: > > > On 02/06/2025 10:37, Jan Beulich wrote: >> On 27.05.2025 10:21, Michal Orzel wrote: >>> There's nothing Arm specific about this feature. Move it to common as >>> part of a larger activity to commonalize device tree related features. >>> For now, sel

Re: [PATCH 07/19] arm/gnttab: Break cycle between asm/grant_table.h and xen/grant_table.h

2025-06-03 Thread Jan Beulich
On 02.06.2025 18:39, Alejandro Vallejo wrote: > On Mon Jun 2, 2025 at 4:51 PM CEST, Jan Beulich wrote: >> On 02.06.2025 16:30, Alejandro Vallejo wrote: >>> On Mon Jun 2, 2025 at 9:53 AM CEST, Jan Beulich wrote: On 30.05.2025 14:02, Alejandro Vallejo wrote:> --- a/xen/include/xen/grant_ta

Re: [PATCH v2 01/22] x86/include/asm/intel-txt.h: constants and accessors for TXT registers and heap

2025-06-03 Thread Jan Beulich
On 03.06.2025 00:00, Sergii Dmytruk wrote: > On Mon, Jun 02, 2025 at 09:17:37AM +0200, Jan Beulich wrote: >> On 23.05.2025 21:51, Sergii Dmytruk wrote: >>> On Wed, May 21, 2025 at 05:19:57PM +0200, Jan Beulich wrote: > +static inline uint64_t txt_bios_data_size(void *heap) Here, below

Re: [PATCH] device-tree: Move Arm's static-evtchn feature to common

2025-06-03 Thread Orzel, Michal
On 03/06/2025 09:02, Jan Beulich wrote: > On 03.06.2025 08:54, Orzel, Michal wrote: >> >> >> On 02/06/2025 10:37, Jan Beulich wrote: >>> On 27.05.2025 10:21, Michal Orzel wrote: There's nothing Arm specific about this feature. Move it to common as part of a larger activity to commonali

Re: [PATCH] device-tree: Move Arm's static-evtchn feature to common

2025-06-03 Thread Orzel, Michal
On 02/06/2025 10:37, Jan Beulich wrote: > On 27.05.2025 10:21, Michal Orzel wrote: >> There's nothing Arm specific about this feature. Move it to common as >> part of a larger activity to commonalize device tree related features. >> For now, select it only for ARM until others (e.g. RISC-V) veri